From d26bad079d6977309699e0bc9203451904acbd86 Mon Sep 17 00:00:00 2001 From: Jim Grosbach Date: Thu, 19 Jan 2012 01:50:30 +0000 Subject: [PATCH] Add comment and fix range check in condition. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@148455 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp b/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp index adedc208d0e..2a8f7c6dc4e 100644 --- a/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp +++ b/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp @@ -180,8 +180,10 @@ bool ARMAsmBackend::fixupNeedsRelaxation(const MCFixup &Fixup, return Offset > 254 || Offset < -256; } case ARM::fixup_arm_thumb_cp: { + // If the immediate is negative, greater than 1020, or not a multiple + // of four, the wide version of the instruction must be used. int64_t Offset = int64_t(Value) - 4; - return Offset > 4095 || Offset < 0; + return Offset > 1020 || Offset < 0 || Offset & 3; } } llvm_unreachable("Invalid switch/cash!?");