RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-11-27 21:50:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[X86] Create the correct ADC/SBB SDNode when lowering add.

Browse Source 
Differential Revision:  https://reviews.llvm.org/D31911

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@299973 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Davide Italiano 2017-04-11 19:11:20 +00:00
parent 2ef157559b
commit d7dec945d0
2 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Target/X86/X86ISelLowering.cpp
View File

@ -34606,15 +34606,17 @@ static SDValue combineAddOrSubToADCOrSBB(SDNode *N, SelectionDAG &DAG) {
SDValue NewCmp = DAG.getNode(X86ISD::CMP, DL, MVT::i32, Z,
DAG.getConstant(1, DL, Z.getValueType()));
SDVTList VTs = DAG.getVTList(N->getValueType(0), MVT::i32);
// X - (Z != 0) --> sub X, (zext(setne Z, 0)) --> adc X, -1, (cmp Z, 1)
// X + (Z != 0) --> add X, (zext(setne Z, 0)) --> sbb X, -1, (cmp Z, 1)
if (CC == X86::COND_NE)
return DAG.getNode(IsSub ? X86ISD::ADC : X86ISD::SBB, DL, VT, X,
return DAG.getNode(IsSub ? X86ISD::ADC : X86ISD::SBB, DL, VTs, X,
DAG.getConstant(-1ULL, DL, VT), NewCmp);
// X - (Z == 0) --> sub X, (zext(sete Z, 0)) --> sbb X, 0, (cmp Z, 1)
// X + (Z == 0) --> add X, (zext(sete Z, 0)) --> adc X, 0, (cmp Z, 1)
return DAG.getNode(IsSub ? X86ISD::SBB : X86ISD::ADC, DL, VT, X,
return DAG.getNode(IsSub ? X86ISD::SBB : X86ISD::ADC, DL, VTs, X,
DAG.getConstant(0, DL, VT), NewCmp);
}

27
test/CodeGen/X86/pr32588.ll Normal file
View File

@ -0,0 +1,27 @@
; RUN: llc < %s -mcpu=generic -mtriple=x86_64-linux | FileCheck %s
@c = external local_unnamed_addr global i32, align 4
@b = external local_unnamed_addr global i32, align 4
@d = external local_unnamed_addr global i32, align 4
; CHECK: cmpl $1, c(%rip)
; CHECK-NEXT: sbbl %eax, %eax
; CHECK-NEXT: andl $1, %eax
; CHECK-NEXT: movl %eax, d(%rip)
; CHECK-NEXT: retq
define void @fn1() {
entry:
%0 = load i32, i32* @c, align 4
%tobool1 = icmp eq i32 %0, 0
%xor = zext i1 %tobool1 to i32
%1 = load i32, i32* @b, align 4
%tobool2 = icmp ne i32 %1, 0
%tobool4 = icmp ne i32 undef, 0
%2 = and i1 %tobool4, %tobool2
%sub = sext i1 %2 to i32
%div = sdiv i32 %sub, 2
%add = add nsw i32 %div, %xor
store i32 %add, i32* @d, align 4
ret void
}