RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-11-24 04:09:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

AArch64: be careful of large immediates when optimising cmps.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@243492 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Tim Northover 2015-07-28 22:42:32 +00:00
parent 62df004d25
commit db059db6ad
2 changed files with 38 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Target/AArch64/AArch64ConditionOptimizer.cpp
View File

@ -154,11 +154,18 @@ MachineInstr *AArch64ConditionOptimizer::findSuitableCompare(
// cmn is an alias for adds with a dead destination register.
case AArch64::ADDSWri:
case AArch64::ADDSXri:
if (MRI->use_empty(I->getOperand(0).getReg()))
return I;
DEBUG(dbgs() << "Destination of cmp is not dead, " << *I << '\n');
return nullptr;
if (!I->getOperand(2).isImm()) {
DEBUG(dbgs() << "Immediate of cmp is symbolic, " << *I << '\n');
return nullptr;
} else if (I->getOperand(2).getImm() << I->getOperand(3).getImm() >=
0xfff) {
DEBUG(dbgs() << "Immediate of cmp may be out of range, " << *I << '\n');
return nullptr;
} else if (!MRI->use_empty(I->getOperand(0).getReg())) {
DEBUG(dbgs() << "Destination of cmp is not dead, " << *I << '\n');
return nullptr;
}
return I;
// Prevent false positive case like:
// cmp w19, #0

26
test/CodeGen/AArch64/combine-comparisons-by-cse.ll
View File

@ -403,6 +403,32 @@ return: ; preds = %land.lhs.true, %con
ret i32 %retval.0
}
define void @cmp_shifted(i32 %in, i32 %lhs, i32 %rhs) {
; CHECK-LABEL: cmp_shifted:
; CHECK: cmp w0, #1
; [...]
; CHECK: cmp w0, #2, lsl #12
%tst_low = icmp sgt i32 %in, 0
br i1 %tst_low, label %true, label %false
true:
call i32 @zoo(i32 128)
ret void
false:
%tst = icmp sgt i32 %in, 8191
br i1 %tst, label %truer, label %falser
truer:
call i32 @zoo(i32 42)
ret void
falser:
call i32 @zoo(i32 1)
ret void
}
declare i32 @zoo(i32)
declare double @yoo(i32)