diff --git a/include/llvm/Bytecode/BytecodeHandler.h b/include/llvm/Bytecode/BytecodeHandler.h index b8aecb57341..4084efa14cc 100644 --- a/include/llvm/Bytecode/BytecodeHandler.h +++ b/include/llvm/Bytecode/BytecodeHandler.h @@ -175,7 +175,7 @@ public: virtual void handleSymbolTableValue( unsigned i, ///< The index of the value in this plane unsigned slot, ///< Slot number of the named value - const std::string& name ///< Name of the value. + const char *name, unsigned NameLen ///< Name of the value. ) {} /// @brief Handle the end of a value symbol table diff --git a/lib/Bytecode/Reader/Analyzer.cpp b/lib/Bytecode/Reader/Analyzer.cpp index fe503f4d124..880605c40fc 100644 --- a/lib/Bytecode/Reader/Analyzer.cpp +++ b/lib/Bytecode/Reader/Analyzer.cpp @@ -250,10 +250,10 @@ public: } virtual void handleSymbolTableValue(unsigned TySlot, unsigned ValSlot, - const std::string& name) { + const char *Name, unsigned NameLen) { if (os) *os << " Value " << TySlot << " Slot=" << ValSlot - << " Name: " << name << "\n"; + << " Name: " << std::string(Name, Name+NameLen) << "\n"; if (ValSlot > bca.maxValueSlot) bca.maxValueSlot = ValSlot; } diff --git a/lib/Bytecode/Reader/Reader.cpp b/lib/Bytecode/Reader/Reader.cpp index 0f0cf5e6cdf..376c0702a3e 100644 --- a/lib/Bytecode/Reader/Reader.cpp +++ b/lib/Bytecode/Reader/Reader.cpp @@ -132,6 +132,17 @@ inline std::string BytecodeReader::read_str() { return std::string((char*)OldAt, Size); } +void BytecodeReader::read_str(SmallVectorImpl &StrData) { + StrData.clear(); + unsigned Size = read_vbr_uint(); + const unsigned char *OldAt = At; + At += Size; + if (At > BlockEnd) // Size invalid? + error("Ran out of data reading a string!"); + StrData.append(OldAt, At); +} + + /// Read an arbitrary block of data inline void BytecodeReader::read_data(void *Ptr, void *End) { unsigned char *Start = (unsigned char *)Ptr; @@ -943,6 +954,8 @@ void BytecodeReader::ParseValueSymbolTable(Function *CurrentFunction, E = CurrentFunction->end(); I != E; ++I) BBMap.push_back(I); + SmallVector NameStr; + while (moreInBlock()) { // Symtab block header: [num entries][type id number] unsigned NumEntries = read_vbr_uint(); @@ -951,19 +964,22 @@ void BytecodeReader::ParseValueSymbolTable(Function *CurrentFunction, for (unsigned i = 0; i != NumEntries; ++i) { // Symtab entry: [def slot #][name] unsigned slot = read_vbr_uint(); - std::string Name = read_str(); + read_str(NameStr); Value *V = 0; if (Typ == LabelTySlot) { - if (slot < BBMap.size()) - V = BBMap[slot]; + V = (slot < BBMap.size()) ? BBMap[slot] : 0; } else { - V = getValue(Typ, slot, false); // Find mapping... + V = getValue(Typ, slot, false); // Find mapping. } - if (Handler) Handler->handleSymbolTableValue(Typ, slot, Name); + if (Handler) Handler->handleSymbolTableValue(Typ, slot, + &NameStr[0], NameStr.size()); if (V == 0) - error("Failed value look-up for name '" + Name + "', type #" + + error("Failed value look-up for name '" + + std::string(NameStr.begin(), NameStr.end()) + "', type #" + utostr(Typ) + " slot #" + utostr(slot)); - V->setName(Name); + V->setName(&NameStr[0], NameStr.size()); + + NameStr.clear(); } } checkPastBlockEnd("Symbol Table"); diff --git a/lib/Bytecode/Reader/Reader.h b/lib/Bytecode/Reader/Reader.h index 8acf6c042f8..ca966f1cc74 100644 --- a/lib/Bytecode/Reader/Reader.h +++ b/lib/Bytecode/Reader/Reader.h @@ -438,6 +438,7 @@ private: /// @brief Read a string inline std::string read_str(); + inline void read_str(SmallVectorImpl &StrData); /// @brief Read a float value inline void read_float(float& FloatVal);