mirror of
https://github.com/RPCSX/llvm.git
synced 2024-11-23 11:49:50 +00:00
[LiveVariables] Switch Kill/Defs sets to be DenseSet(s).
The testcase in PR32984 shows a non linear compile time increase after a change that made the LoopUnroll pass more aggressive (increasing the threshold). My profiling shows all the time of PHI elimination goes to llvm::LiveVariables::addNewBlock. This is because we keep Defs/Kills registers in a SmallSet and vfind(const T &V); is O(N). Switching to a DenseSet reduces the time spent in the pass from 297 seconds to 97 seconds. Profiling still shows a lot of time is spent iterating the data structure, so I guess there's room for improvement. Dan tells me GCC uses real set operations for live registers and it takes no-time on this testcase. Matthias points out we might want to switch all this to LiveIntervalAnalysis so it's not entirely sure if a rewrite is worth it. Differential Revision: https://reviews.llvm.org/D33088 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@302819 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
483eed9183
commit
ded71be5b1
@ -767,7 +767,7 @@ void LiveVariables::addNewBlock(MachineBasicBlock *BB,
|
||||
MachineBasicBlock *SuccBB) {
|
||||
const unsigned NumNew = BB->getNumber();
|
||||
|
||||
SmallSet<unsigned, 16> Defs, Kills;
|
||||
DenseSet<unsigned> Defs, Kills;
|
||||
|
||||
MachineBasicBlock::iterator BBI = SuccBB->begin(), BBE = SuccBB->end();
|
||||
for (; BBI != BBE && BBI->isPHI(); ++BBI) {
|
||||
|
Loading…
Reference in New Issue
Block a user