RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-11-30 23:20:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Before sample pgo annotation, do not inline a function that has no debug info. (NFC)

Browse Source 
If there is no debug info in the callee, inlining it will not help annotator. This avoids infinite loop as reported in PR/31119.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@287710 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dehao Chen 2016-11-22 22:50:01 +00:00
parent 4f65080637
commit ded77cc923
4 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Transforms/IPO/SampleProfile.cpp
View File

@ -651,6 +651,8 @@ bool SampleProfileLoader::inlineHotFunctions(Function &F) {
InvokeInst *II = dyn_cast<InvokeInst>(I);
Function *CalledFunction =
(CI == nullptr ? II->getCalledFunction() : CI->getCalledFunction());
if (!CalledFunction || !CalledFunction->getSubprogram())
continue;
DebugLoc DLoc = I->getDebugLoc();
uint64_t NumSamples = findCalleeFunctionSamples(*I)->getTotalSamples();
if ((CI && InlineFunction(CI, IFI)) || (II && InlineFunction(II, IFI))) {

2
test/Transforms/SampleProfile/Inputs/nodebug.prof Normal file
View File

@ -0,0 +1,2 @@
foo:100:10
0: bar:10

3
test/Transforms/SampleProfile/early-inline.ll
View File

@ -28,7 +28,7 @@ define void @_Z3foov() #0 personality i8* bitcast (i32 (...)* @__gxx_personality
}
; Function Attrs: nounwind uwtable
define internal void @_ZL3barv() #1 {
define internal void @_ZL3barv() !dbg !12 {
ret void
}
@ -45,3 +45,4 @@ declare i32 @__gxx_personality_v0(...)
!9 = !DILocation(line: 6, column: 3, scope: !6)
!10 = !DILocation(line: 8, column: 5, scope: !11)
!11 = distinct !DILexicalBlock(scope: !6, file: !1, line: 7, column: 7)
!12 = distinct !DISubprogram(linkageName: "_ZL3barv", scope: !1, line: 20, scopeLine: 20, unit: !0)

20
test/Transforms/SampleProfile/nodebug.ll Normal file
View File

@ -0,0 +1,20 @@
; RUN: opt < %s -sample-profile -sample-profile-file=%S/Inputs/nodebug.prof
define void @foo() !dbg !3 {
call void @bar(), !dbg !4
ret void
}
define void @bar() {
call void @bar()
ret void
}
!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!2}
!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1)
!1 = !DIFile(filename: "t", directory: "/tmp/")
!2 = !{i32 2, !"Debug Info Version", i32 3}
!3 = distinct !DISubprogram(name: "a", scope: !1, file: !1, line: 10, unit: !0)
!4 = !DILocation(line: 10, scope: !3)