RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-01-23 04:35:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[PPC] Fix PR24686 by failing assembly for an invalid relocation

Browse Source 
PR24686 identifies a problem where a relocation expression is invalid
when not all of the symbols in the expression can be locally
resolved.  This causes the compiler to request a PC-relative half16ds
relocation, which is nonsensical for PowerPC.  This patch recognizes
this situation and ensures we fail the assembly cleanly.

Test case provided by Anton Blanchard.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251027 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Bill Schmidt 2015-10-22 15:53:44 +00:00
parent 1183c6f920
commit e2e776f769
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Target/PowerPC/MCTargetDesc/PPCELFObjectWriter.cpp
View File

@ -113,6 +113,13 @@ unsigned PPCELFObjectWriter::GetRelocType(const MCValue &Target,
break;
}
break;
case PPC::fixup_ppc_half16ds: {
raw_ostream &OS = *(new raw_fd_ostream(2, false));
Target.print(OS);
OS << "\n";
report_fatal_error("Invalid PC-relative half16ds relocation");
break;
}
case FK_Data_4:
case FK_PCRel_4:
Type = ELF::R_PPC_REL32;

7
test/MC/PowerPC/pr24686.s Normal file
View File

@ -0,0 +1,7 @@
# RUN: not llvm-mc -triple=powerpc64le-unknown-linux-gnu -filetype=obj %s \
# RUN: 2>&1 | FileCheck %s
_stext:
ld %r5, p_end - _stext(%r5)
# CHECK: LLVM ERROR: Invalid PC-relative half16ds relocation