RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-02-13 17:20:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "[SimplifyCFG] allow speculation of exactly one expensive instruction (PR24818)"

Browse Source 
This reverts commit r255660.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@258903 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Majnemer 2016-01-27 02:43:22 +00:00
parent de2c3bc98d
commit e7026ee101
3 changed files with 47 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/Transforms/Utils/SimplifyCFG.cpp
View File

@ -85,11 +85,6 @@ static cl::opt<bool> MergeCondStoresAggressively(
cl::desc("When merging conditional stores, do so even if the resultant "
"basic blocks are unlikely to be if-converted as a result"));
static cl::opt<bool> SpeculateOneExpensiveInst(
"speculate-one-expensive-inst", cl::Hidden, cl::init(true),
cl::desc("Allow exactly one expensive instruction to be speculatively "
"executed"));
STATISTIC(NumBitMaps, "Number of switch instructions turned into bitmaps");
STATISTIC(NumLinearMaps, "Number of switch instructions turned into linear mapping");
STATISTIC(NumLookupTables, "Number of switch instructions turned into lookup tables");
@ -267,8 +262,7 @@ static unsigned ComputeSpeculationCost(const User *I,
static bool DominatesMergePoint(Value *V, BasicBlock *BB,
SmallPtrSetImpl<Instruction*> *AggressiveInsts,
unsigned &CostRemaining,
const TargetTransformInfo &TTI,
unsigned Depth = 0) {
const TargetTransformInfo &TTI) {
Instruction *I = dyn_cast<Instruction>(V);
if (!I) {
// Non-instructions all dominate instructions, but not all constantexprs
@ -306,24 +300,15 @@ static bool DominatesMergePoint(Value *V, BasicBlock *BB,
unsigned Cost = ComputeSpeculationCost(I, TTI);
// Allow exactly one instruction to be speculated regardless of its cost
// (as long as it is safe to do so).
// This is intended to flatten the CFG even if the instruction is a division
// or other expensive operation. The speculation of an expensive instruction
// is expected to be undone in CodeGenPrepare if the speculation has not
// enabled further IR optimizations.
if (Cost > CostRemaining &&
(!SpeculateOneExpensiveInst || !AggressiveInsts->empty() || Depth > 0))
if (Cost > CostRemaining)
return false;
// Avoid unsigned wrap.
CostRemaining = (Cost > CostRemaining) ? 0 : CostRemaining - Cost;
CostRemaining -= Cost;
// Okay, we can only really hoist these out if their operands do
// not take us over the cost threshold.
for (User::op_iterator i = I->op_begin(), e = I->op_end(); i != e; ++i)
if (!DominatesMergePoint(*i, BB, AggressiveInsts, CostRemaining, TTI,
Depth + 1))
if (!DominatesMergePoint(*i, BB, AggressiveInsts, CostRemaining, TTI))
return false;
// Okay, it's safe to do this! Remember this instruction.
AggressiveInsts->insert(I);

24
test/Transforms/SimplifyCFG/X86/speculate-cttz-ctlz.ll
View File

@ -7,7 +7,9 @@ define i64 @test1(i64 %A) {
; ALL-LABEL: @test1(
; ALL: [[COND:%[A-Za-z0-9]+]] = icmp eq i64 %A, 0
; ALL: [[CTLZ:%[A-Za-z0-9]+]] = tail call i64 @llvm.ctlz.i64(i64 %A, i1 true)
; ALL-NEXT: select i1 [[COND]], i64 64, i64 [[CTLZ]]
; LZCNT-NEXT: select i1 [[COND]], i64 64, i64 [[CTLZ]]
; BMI-NOT: select
; GENERIC-NOT: select
; ALL: ret
entry:
%tobool = icmp eq i64 %A, 0
@ -26,7 +28,9 @@ define i32 @test2(i32 %A) {
; ALL-LABEL: @test2(
; ALL: [[COND:%[A-Za-z0-9]+]] = icmp eq i32 %A, 0
; ALL: [[CTLZ:%[A-Za-z0-9]+]] = tail call i32 @llvm.ctlz.i32(i32 %A, i1 true)
; ALL-NEXT: select i1 [[COND]], i32 32, i32 [[CTLZ]]
; LZCNT-NEXT: select i1 [[COND]], i32 32, i32 [[CTLZ]]
; BMI-NOT: select
; GENERIC-NOT: select
; ALL: ret
entry:
%tobool = icmp eq i32 %A, 0
@ -46,7 +50,9 @@ define signext i16 @test3(i16 signext %A) {
; ALL-LABEL: @test3(
; ALL: [[COND:%[A-Za-z0-9]+]] = icmp eq i16 %A, 0
; ALL: [[CTLZ:%[A-Za-z0-9]+]] = tail call i16 @llvm.ctlz.i16(i16 %A, i1 true)
; ALL-NEXT: select i1 [[COND]], i16 16, i16 [[CTLZ]]
; LZCNT-NEXT: select i1 [[COND]], i16 16, i16 [[CTLZ]]
; BMI-NOT: select
; GENERIC-NOT: select
; ALL: ret
entry:
%tobool = icmp eq i16 %A, 0
@ -66,7 +72,9 @@ define i64 @test1b(i64 %A) {
; ALL-LABEL: @test1b(
; ALL: [[COND:%[A-Za-z0-9]+]] = icmp eq i64 %A, 0
; ALL: [[CTTZ:%[A-Za-z0-9]+]] = tail call i64 @llvm.cttz.i64(i64 %A, i1 true)
; ALL-NEXT: select i1 [[COND]], i64 64, i64 [[CTTZ]]
; BMI-NEXT: select i1 [[COND]], i64 64, i64 [[CTTZ]]
; LZCNT-NOT: select
; GENERIC-NOT: select
; ALL: ret
entry:
%tobool = icmp eq i64 %A, 0
@ -86,7 +94,9 @@ define i32 @test2b(i32 %A) {
; ALL-LABEL: @test2b(
; ALL: [[COND:%[A-Za-z0-9]+]] = icmp eq i32 %A, 0
; ALL: [[CTTZ:%[A-Za-z0-9]+]] = tail call i32 @llvm.cttz.i32(i32 %A, i1 true)
; ALL-NEXT: select i1 [[COND]], i32 32, i32 [[CTTZ]]
; BMI-NEXT: select i1 [[COND]], i32 32, i32 [[CTTZ]]
; LZCNT-NOT: select
; GENERIC-NOT: select
; ALL: ret
entry:
%tobool = icmp eq i32 %A, 0
@ -106,7 +116,9 @@ define signext i16 @test3b(i16 signext %A) {
; ALL-LABEL: @test3b(
; ALL: [[COND:%[A-Za-z0-9]+]] = icmp eq i16 %A, 0
; ALL: [[CTTZ:%[A-Za-z0-9]+]] = tail call i16 @llvm.cttz.i16(i16 %A, i1 true)
; ALL-NEXT: select i1 [[COND]], i16 16, i16 [[CTTZ]]
; BMI-NEXT: select i1 [[COND]], i16 16, i16 [[CTTZ]]
; LZCNT-NOT: select
; GENERIC-NOT: select
; ALL: ret
entry:
%tobool = icmp eq i16 %A, 0

42
test/Transforms/SimplifyCFG/speculate-math.ll
View File

@ -1,5 +1,4 @@
; RUN: opt -S -simplifycfg < %s | FileCheck %s --check-prefix=EXPENSIVE --check-prefix=ALL
; RUN: opt -S -simplifycfg -speculate-one-expensive-inst=false < %s | FileCheck %s --check-prefix=CHEAP --check-prefix=ALL
; RUN: opt -S -simplifycfg -phi-node-folding-threshold=2 < %s | FileCheck %s
declare float @llvm.sqrt.f32(float) nounwind readonly
declare float @llvm.fma.f32(float, float, float) nounwind readonly
@ -8,10 +7,19 @@ declare float @llvm.fabs.f32(float) nounwind readonly
declare float @llvm.minnum.f32(float, float) nounwind readonly
declare float @llvm.maxnum.f32(float, float) nounwind readonly
; ALL-LABEL: @fdiv_test(
; EXPENSIVE: select i1 %cmp, double %div, double 0.0
; CHEAP-NOT: select
; FIXME: This is intended to be a temporary test. As discussed in
; D12882, we actually do want to speculate even expensive operations
; in SimplifyCFG because it can expose more optimizations for other
; passes. Therefore, we either need to adjust SimplifyCFG's
; calculations that use the TTI cost model or use a different cost
; model for deciding which ops should be speculated in SimplifyCFG.
; We should also be using the TTI cost model later - for example in
; CodeGenPrepare - to potentially undo this speculation.
; Do not speculate fdiv by default because it is generally expensive.
; CHECK-LABEL: @fdiv_test(
; CHECK-NOT: select
define double @fdiv_test(double %a, double %b) {
entry:
%cmp = fcmp ogt double %a, 0.0
@ -26,8 +34,8 @@ cond.end:
ret double %cond
}
; ALL-LABEL: @sqrt_test(
; ALL: select
; CHECK-LABEL: @sqrt_test(
; CHECK: select
define void @sqrt_test(float addrspace(1)* noalias nocapture %out, float %a) nounwind {
entry:
%cmp.i = fcmp olt float %a, 0.000000e+00
@ -43,8 +51,8 @@ test_sqrt.exit: ; preds = %cond.else.i, %entry
ret void
}
; ALL-LABEL: @fabs_test(
; ALL: select
; CHECK-LABEL: @fabs_test(
; CHECK: select
define void @fabs_test(float addrspace(1)* noalias nocapture %out, float %a) nounwind {
entry:
%cmp.i = fcmp olt float %a, 0.000000e+00
@ -60,8 +68,8 @@ test_fabs.exit: ; preds = %cond.else.i, %entry
ret void
}
; ALL-LABEL: @fma_test(
; ALL: select
; CHECK-LABEL: @fma_test(
; CHECK: select
define void @fma_test(float addrspace(1)* noalias nocapture %out, float %a, float %b, float %c) nounwind {
entry:
%cmp.i = fcmp olt float %a, 0.000000e+00
@ -77,8 +85,8 @@ test_fma.exit: ; preds = %cond.else.i, %entry
ret void
}
; ALL-LABEL: @fmuladd_test(
; ALL: select
; CHECK-LABEL: @fmuladd_test(
; CHECK: select
define void @fmuladd_test(float addrspace(1)* noalias nocapture %out, float %a, float %b, float %c) nounwind {
entry:
%cmp.i = fcmp olt float %a, 0.000000e+00
@ -94,8 +102,8 @@ test_fmuladd.exit: ; preds = %cond.else.i, %en
ret void
}
; ALL-LABEL: @minnum_test(
; ALL: select
; CHECK-LABEL: @minnum_test(
; CHECK: select
define void @minnum_test(float addrspace(1)* noalias nocapture %out, float %a, float %b) nounwind {
entry:
%cmp.i = fcmp olt float %a, 0.000000e+00
@ -111,8 +119,8 @@ test_minnum.exit: ; preds = %cond.else.i, %ent
ret void
}
; ALL-LABEL: @maxnum_test(
; ALL: select
; CHECK-LABEL: @maxnum_test(
; CHECK: select
define void @maxnum_test(float addrspace(1)* noalias nocapture %out, float %a, float %b) nounwind {
entry:
%cmp.i = fcmp olt float %a, 0.000000e+00