RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-12-04 01:43:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

MC/X86: Chris pointed that 'as' isn't consistent in accepting the long form of

Browse Source 
instructions which have no direct register usage.

Darwin 'as' accepts:
  add $0, (%rax)
but rejects
  mov $0, (%rax)
for example.

Given that, only accept suffix matches which match exactly one form. We still
need to emit nice diagnostics for failures...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@103015 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Daniel Dunbar 2010-05-04 17:31:02 +00:00
parent 28428cd6f3
commit e9f0fb4179
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Target/X86/AsmParser/X86AsmParser.cpp
View File

@ -683,11 +683,6 @@ X86ATTAsmParser::MatchInstruction(const SmallVectorImpl<MCParsedAsmOperand*>
if (MatchB + MatchW + MatchL == 2)
return false;
// Similarly, if all three matched then we assume this is a generic operation
// involving memory, and take the 'l' form (to match 'gas').
if (MatchB + MatchW + MatchL == 0)
return false;
// Otherwise, the match failed.
return true;
}

2
test/MC/AsmParser/X86/x86_64-suffix-matching.s
View File

@ -4,5 +4,3 @@
add $0, %eax
// CHECK: addb $255, %al
add $0xFF, %al
// CHECK: addl $0, (%rax)
add $0, 0(%rax)