RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-01-24 21:25:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[CodeGen] Fix FREM on 32-bit MSVC on x86

Browse Source 
Patch by Dylan McKay!

Differential Revision: http://reviews.llvm.org/D12099

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@246615 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Vedant Kumar 2015-09-02 01:31:58 +00:00
parent 6ad37ecd02
commit ec0cd29de8
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Target/X86/X86ISelLowering.cpp
View File

@ -304,7 +304,17 @@ X86TargetLowering::X86TargetLowering(const X86TargetMachine &TM,
setOperationAction(ISD::SIGN_EXTEND_INREG, MVT::i8 , Legal);
setOperationAction(ISD::SIGN_EXTEND_INREG, MVT::i1 , Expand);
setOperationAction(ISD::FP_ROUND_INREG , MVT::f32 , Expand);
setOperationAction(ISD::FREM , MVT::f32 , Expand);
if (Subtarget->is32Bit() && Subtarget->isTargetKnownWindowsMSVC()) {
// On 32 bit MSVC, `fmodf(f32)` is not defined - only `fmod(f64)`
// is. We should promote the value to 64-bits to solve this.
// This is what the CRT headers do - `fmodf` is an inline header
// function casting to f64 and calling `fmod`.
setOperationAction(ISD::FREM , MVT::f32 , Promote);
} else {
setOperationAction(ISD::FREM , MVT::f32 , Expand);
}
setOperationAction(ISD::FREM , MVT::f64 , Expand);
setOperationAction(ISD::FREM , MVT::f80 , Expand);
setOperationAction(ISD::FLT_ROUNDS_ , MVT::i32 , Custom);

12
test/CodeGen/X86/frem-msvc32.ll Normal file
View File

@ -0,0 +1,12 @@
; Make sure that 32-bit FREM is promoted to 64-bit FREM on 32-bit MSVC.
; MSVC does not have a 32-bit fmodf function, so it must be promoted to
; a 64-bit fmod rtlib call.
; RUN: llc -mtriple=i686-pc-windows-msvc -O0 < %s | FileCheck %s
; CHECK: @do_frem32
; CHECK: {{_fmod$}}
define float @do_frem32(float %a, float %b) {
%val = frem float %a, %b
ret float %val
}