mirror of
https://github.com/RPCSX/llvm.git
synced 2024-12-14 07:31:47 +00:00
Revert "[AMDGPU] Disassembler: print label names in branch instructions"
This reverts commit 6c6dbe6252.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@282396 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Sam Kolton
parent
6c6dbe6252
commit
ecba0242f4
@ -28,7 +28,6 @@
|
||||
#include "llvm/MC/MCInst.h"
|
||||
#include "llvm/MC/MCInstrDesc.h"
|
||||
#include "llvm/MC/MCSubtargetInfo.h"
|
||||
#include "llvm/Support/ELF.h"
|
||||
#include "llvm/Support/Endian.h"
|
||||
#include "llvm/Support/Debug.h"
|
||||
#include "llvm/Support/TargetRegistry.h"
|
||||
@ -49,18 +48,6 @@ addOperand(MCInst &Inst, const MCOperand& Opnd) {
|
||||
MCDisassembler::SoftFail;
|
||||
}
|
||||
|
||||
static DecodeStatus decodeSoppBrTarget(MCInst &Inst, unsigned Imm,
|
||||
uint64_t Addr, const void *Decoder) {
|
||||
auto DAsm = static_cast<const AMDGPUDisassembler*>(Decoder);
|
||||
|
||||
APInt SignedOffset(18, Imm * 4, true);
|
||||
int64_t Offset = (SignedOffset.sext(64) + 4 + Addr).getSExtValue();
|
||||
|
||||
if (DAsm->tryAddingSymbolicOperand(Inst, Offset, Addr, true, 2, 2))
|
||||
return MCDisassembler::Success;
|
||||
return addOperand(Inst, MCOperand::createImm(Imm));
|
||||
}
|
||||
|
||||
#define DECODE_OPERAND2(RegClass, DecName) \
|
||||
static DecodeStatus Decode##RegClass##RegisterClass(MCInst &Inst, \
|
||||
unsigned Imm, \
|
||||
@ -444,50 +431,6 @@ MCOperand AMDGPUDisassembler::decodeSpecialReg64(unsigned Val) const {
|
||||
return errOperand(Val, "unknown operand encoding " + Twine(Val));
|
||||
}
|
||||
|
||||
//===----------------------------------------------------------------------===//
|
||||
// AMDGPUSymbolizer
|
||||
//===----------------------------------------------------------------------===//
|
||||
|
||||
// Try to find symbol name for specified label
|
||||
bool AMDGPUSymbolizer::tryAddingSymbolicOperand(MCInst &Inst,
|
||||
raw_ostream &/*cStream*/, int64_t Value,
|
||||
uint64_t /*Address*/, bool IsBranch,
|
||||
uint64_t /*Offset*/, uint64_t /*InstSize*/) {
|
||||
typedef std::tuple<uint64_t, StringRef, uint8_t> SymbolInfoTy;
|
||||
typedef std::vector<SymbolInfoTy> SectionSymbolsTy;
|
||||
|
||||
if (!IsBranch) {
|
||||
return false;
|
||||
}
|
||||
|
||||
auto *Symbols = static_cast<SectionSymbolsTy *>(DisInfo);
|
||||
auto Result = std::find_if(Symbols->begin(), Symbols->end(),
|
||||
[Value](const SymbolInfoTy& Val) {
|
||||
return std::get<0>(Val) == static_cast<uint64_t>(Value)
|
||||
&& std::get<2>(Val) == ELF::STT_NOTYPE;
|
||||
});
|
||||
if (Result != Symbols->end()) {
|
||||
auto *Sym = Ctx.getOrCreateSymbol(std::get<1>(*Result));
|
||||
const auto *Add = MCSymbolRefExpr::create(Sym, Ctx);
|
||||
Inst.addOperand(MCOperand::createExpr(Add));
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
//===----------------------------------------------------------------------===//
|
||||
// Initialization
|
||||
//===----------------------------------------------------------------------===//
|
||||
|
||||
static MCSymbolizer *createAMDGPUSymbolizer(const Triple &/*TT*/,
|
||||
LLVMOpInfoCallback /*GetOpInfo*/,
|
||||
LLVMSymbolLookupCallback /*SymbolLookUp*/,
|
||||
void *DisInfo,
|
||||
MCContext *Ctx,
|
||||
std::unique_ptr<MCRelocationInfo> &&RelInfo) {
|
||||
return new AMDGPUSymbolizer(*Ctx, std::move(RelInfo), DisInfo);
|
||||
}
|
||||
|
||||
static MCDisassembler *createAMDGPUDisassembler(const Target &T,
|
||||
const MCSubtargetInfo &STI,
|
||||
MCContext &Ctx) {
|
||||
@ -496,5 +439,4 @@ static MCDisassembler *createAMDGPUDisassembler(const Target &T,
|
||||
|
||||
extern "C" void LLVMInitializeAMDGPUDisassembler() {
|
||||
TargetRegistry::RegisterMCDisassembler(TheGCNTarget, createAMDGPUDisassembler);
|
||||
TargetRegistry::RegisterMCSymbolizer(TheGCNTarget, createAMDGPUSymbolizer);
|
||||
}
|
||||
|
||||
@ -18,7 +18,6 @@
|
||||
|
||||
#include "llvm/ADT/ArrayRef.h"
|
||||
#include "llvm/MC/MCDisassembler/MCDisassembler.h"
|
||||
#include "llvm/MC/MCDisassembler/MCSymbolizer.h"
|
||||
|
||||
namespace llvm {
|
||||
|
||||
@ -28,10 +27,6 @@ class MCOperand;
|
||||
class MCSubtargetInfo;
|
||||
class Twine;
|
||||
|
||||
//===----------------------------------------------------------------------===//
|
||||
// AMDGPUDisassembler
|
||||
//===----------------------------------------------------------------------===//
|
||||
|
||||
class AMDGPUDisassembler : public MCDisassembler {
|
||||
private:
|
||||
mutable ArrayRef<uint8_t> Bytes;
|
||||
@ -93,32 +88,6 @@ public:
|
||||
MCOperand decodeSpecialReg32(unsigned Val) const;
|
||||
MCOperand decodeSpecialReg64(unsigned Val) const;
|
||||
};
|
||||
|
||||
//===----------------------------------------------------------------------===//
|
||||
// AMDGPUSymbolizer
|
||||
//===----------------------------------------------------------------------===//
|
||||
|
||||
class AMDGPUSymbolizer : public MCSymbolizer {
|
||||
private:
|
||||
void *DisInfo;
|
||||
|
||||
public:
|
||||
AMDGPUSymbolizer(MCContext &Ctx, std::unique_ptr<MCRelocationInfo> &&RelInfo,
|
||||
void *disInfo)
|
||||
: MCSymbolizer(Ctx, std::move(RelInfo)), DisInfo(disInfo) {}
|
||||
|
||||
bool tryAddingSymbolicOperand(MCInst &Inst, raw_ostream &cStream,
|
||||
int64_t Value, uint64_t Address,
|
||||
bool IsBranch, uint64_t Offset,
|
||||
uint64_t InstSize) override;
|
||||
|
||||
void tryAddingPcLoadReferenceComment(raw_ostream &cStream,
|
||||
int64_t Value,
|
||||
uint64_t Address) override {
|
||||
assert(false && "Implement if needed");
|
||||
}
|
||||
};
|
||||
|
||||
} // namespace llvm
|
||||
|
||||
#endif //LLVM_LIB_TARGET_AMDGPU_DISASSEMBLER_AMDGPUDISASSEMBLER_H
|
||||
|
||||
@ -291,7 +291,6 @@ def SoppBrTarget : AsmOperandClass {
|
||||
|
||||
def sopp_brtarget : Operand<OtherVT> {
|
||||
let EncoderMethod = "getSOPPBrEncoding";
|
||||
let DecoderMethod = "decodeSoppBrTarget";
|
||||
let OperandType = "OPERAND_PCREL";
|
||||
let ParserMatchClass = SoppBrTarget;
|
||||
}
|
||||
|
||||
@ -6,19 +6,19 @@ s_branch loop_start
|
||||
// VI: s_branch loop_start ; encoding: [A,A,0x82,0xbf]
|
||||
// VI-NEXT: ; fixup A - offset: 0, value: loop_start, kind: fixup_si_sopp_br
|
||||
// BIN: loop_start:
|
||||
// BIN-NEXT: s_branch loop_start // 000000000000: BF82FFFF
|
||||
// BIN-NEXT: BF82FFFF
|
||||
|
||||
s_branch loop_end
|
||||
// VI: s_branch loop_end ; encoding: [A,A,0x82,0xbf]
|
||||
// VI-NEXT: ; fixup A - offset: 0, value: loop_end, kind: fixup_si_sopp_br
|
||||
// BIN: s_branch loop_end // 000000000004: BF820000
|
||||
// BIN: BF820000
|
||||
// BIN: loop_end:
|
||||
loop_end:
|
||||
|
||||
s_branch gds
|
||||
// VI: s_branch gds ; encoding: [A,A,0x82,0xbf]
|
||||
// VI-NEXT: ; fixup A - offset: 0, value: gds, kind: fixup_si_sopp_br
|
||||
// BIN: s_branch gds // 000000000008: BF820000
|
||||
// BIN: BF820000
|
||||
// BIN: gds:
|
||||
gds:
|
||||
s_nop 0
|
||||
|
||||
@ -1228,18 +1228,6 @@ static void DisassembleObject(const ObjectFile *Obj, bool InlineRelocs) {
|
||||
std::sort(DataMappingSymsAddr.begin(), DataMappingSymsAddr.end());
|
||||
std::sort(TextMappingSymsAddr.begin(), TextMappingSymsAddr.end());
|
||||
|
||||
if (Obj->isELF() && Obj->getArch() == Triple::amdgcn) {
|
||||
// AMDGPU disassembler uses symbolizer for printing labels
|
||||
std::unique_ptr<MCRelocationInfo> RelInfo(
|
||||
TheTarget->createMCRelocationInfo(TripleName, Ctx));
|
||||
if (RelInfo) {
|
||||
std::unique_ptr<MCSymbolizer> Symbolizer(
|
||||
TheTarget->createMCSymbolizer(
|
||||
TripleName, nullptr, nullptr, &Symbols, &Ctx, std::move(RelInfo)));
|
||||
DisAsm->setSymbolizer(std::move(Symbolizer));
|
||||
}
|
||||
}
|
||||
|
||||
// Make a list of all the relocations for this section.
|
||||
std::vector<RelocationRef> Rels;
|
||||
if (InlineRelocs) {
|
||||
|
||||
Loading…
Reference in New Issue
Block a user