mirror of
https://github.com/RPCSX/llvm.git
synced 2024-12-02 08:46:23 +00:00
Do not convert "call asm" to "invoke asm" in Inliner.
Given that backend does not handle "invoke asm" correctly ("invoke asm" will be handled by SelectionDAGBuilder::visitInlineAsm, which does not have the right setup for LPadToCallSiteMap) and we already made the assumption that inline asm does not throw in InstCombiner::visitCallSite, we are going to make the same assumption in Inliner to make sure we don't convert "call asm" to "invoke asm". If it becomes necessary to add support for "invoke asm" later on, we will need to modify the backend as well as remove the assumptions that inline asm does not throw. Fix rdar://15317907 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@193808 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
fe0ae1db3a
commit
ef34496b3f
@ -193,7 +193,8 @@ static bool HandleCallsInBlockInlinedThroughInvoke(BasicBlock *BB,
|
||||
CallInst *CI = dyn_cast<CallInst>(I);
|
||||
|
||||
// If this call cannot unwind, don't convert it to an invoke.
|
||||
if (!CI || CI->doesNotThrow())
|
||||
// Inline asm calls cannot throw.
|
||||
if (!CI || CI->doesNotThrow() || isa<InlineAsm>(CI->getCalledValue()))
|
||||
continue;
|
||||
|
||||
// Convert this function call into an invoke instruction. First, split the
|
||||
|
30
test/Transforms/Inline/inline_invoke_with_asm_call.ll
Normal file
30
test/Transforms/Inline/inline_invoke_with_asm_call.ll
Normal file
@ -0,0 +1,30 @@
|
||||
; RUN: opt < %s -inline -S | FileCheck %s
|
||||
target triple = "x86_64-apple-darwin"
|
||||
|
||||
; rdar://15317907
|
||||
; CHECK-LABEL: @caller
|
||||
; Make sure we are generating "call asm" instead of "invoke asm".
|
||||
; CHECK: call void asm
|
||||
; CHECK-LABEL: @callee_with_asm
|
||||
define void @caller() {
|
||||
br i1 undef, label %1, label %4
|
||||
|
||||
; <label>:1
|
||||
invoke void @callee_with_asm()
|
||||
to label %4 unwind label %2
|
||||
|
||||
; <label>:2
|
||||
%3 = landingpad { i8*, i32 } personality i8* bitcast (i32 (...)* @__objc_personality_v0 to i8*)
|
||||
cleanup
|
||||
resume { i8*, i32 } undef
|
||||
|
||||
; <label>:4
|
||||
ret void
|
||||
}
|
||||
|
||||
define void @callee_with_asm() {
|
||||
call void asm sideeffect "mov\09r7, r7\09\09@ marker for objc_retainAutoreleaseReturnValue", ""()
|
||||
ret void
|
||||
}
|
||||
|
||||
declare i32 @__objc_personality_v0(...)
|
Loading…
Reference in New Issue
Block a user