RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-02-23 06:21:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve the remark generated for -Rpass-missed.

Browse Source 
The current remark is ambiguous and makes it sounds like explicitly specifying vectorization will allow the loop to be vectorized. This is not the case. The improved remark directs the user to -Rpass-analysis=loop-vectorize to determine the cause of the pass-miss.

Reviewed by Arnold Schwaighofer`


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214445 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Tyler Nowicki 2014-07-31 21:22:22 +00:00
parent db50d8bdaf
commit f7be7f15c1
4 changed files with 17 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
lib/Transforms/Vectorize/LoopVectorize.cpp
View File

@ -1021,24 +1021,20 @@ public:
std::string emitRemark() const {
Report R;
R << "vectorization ";
switch (Force) {
case LoopVectorizeHints::FK_Disabled:
R << "is explicitly disabled";
break;
case LoopVectorizeHints::FK_Enabled:
R << "is explicitly enabled";
if (Width != 0 && Unroll != 0)
R << " with width " << Width << " and interleave count " << Unroll;
else if (Width != 0)
R << " with width " << Width;
else if (Unroll != 0)
R << " with interleave count " << Unroll;
break;
case LoopVectorizeHints::FK_Undefined:
R << "was not specified";
break;
if (Force == LoopVectorizeHints::FK_Disabled)
R << "vectorization is explicitly disabled";
else {
R << "use -Rpass-analysis=loop-vectorize for more info";
if (Force == LoopVectorizeHints::FK_Enabled) {
R << " (Force=true";
if (Width != 0)
R << ", Vector Width=" << Width;
if (Unroll != 0)
R << ", Interleave Count=" << Unroll;
R << ")";
}
}
return R.str();
}

4
test/Transforms/LoopVectorize/X86/vectorization-remarks-missed.ll
View File

@ -24,10 +24,10 @@
; File, line, and column should match those specified in the metadata
; CHECK: remark: source.cpp:4:5: loop not vectorized: could not determine number of loop iterations
; CHECK: remark: source.cpp:4:5: loop not vectorized: vectorization was not specified
; CHECK: remark: source.cpp:4:5: loop not vectorized: use -Rpass-analysis=loop-vectorize for more info
; CHECK: remark: source.cpp:13:5: loop not vectorized: vector width and interleave count are explicitly set to 1
; CHECK: remark: source.cpp:19:5: loop not vectorized: cannot identify array bounds
; CHECK: remark: source.cpp:19:5: loop not vectorized: vectorization is explicitly enabled
; CHECK: remark: source.cpp:19:5: loop not vectorized: use -Rpass-analysis=loop-vectorize for more info
; CHECK: warning: source.cpp:19:5: loop not vectorized: failed explicitly specified loop vectorization
; CHECK: _Z4testPii

2
test/Transforms/LoopVectorize/control-flow.ll
View File

@ -11,7 +11,7 @@
; }
; CHECK: remark: source.cpp:5:9: loop not vectorized: loop control flow is not understood by vectorizer
; CHECK: remark: source.cpp:5:9: loop not vectorized: vectorization was not specified
; CHECK: remark: source.cpp:5:9: loop not vectorized: use -Rpass-analysis=loop-vectorize for more info
; CHECK: _Z4testPii
; CHECK-NOT: x i32>

2
test/Transforms/LoopVectorize/no_switch.ll
View File

@ -1,7 +1,7 @@
; RUN: opt < %s -loop-vectorize -force-vector-width=4 -S -pass-remarks-missed='loop-vectorize' -pass-remarks-analysis='loop-vectorize' 2>&1 | FileCheck %s
; CHECK: remark: source.cpp:4:5: loop not vectorized: loop contains a switch statement
; CHECK: remark: source.cpp:4:5: loop not vectorized: vectorization is explicitly enabled with width 4
; CHECK: remark: source.cpp:4:5: loop not vectorized: use -Rpass-analysis=loop-vectorize for more info (Force=true, Vector Width=4)
; CHECK: warning: source.cpp:4:5: loop not vectorized: failed explicitly specified loop vectorization
; CHECK: _Z11test_switchPii