mirror of
https://github.com/RPCSX/llvm.git
synced 2024-12-02 16:56:50 +00:00
32b845d223
See r230786 and r230794 for similar changes to gep and load
respectively.
Call is a bit different because it often doesn't have a single explicit
type - usually the type is deduced from the arguments, and just the
return type is explicit. In those cases there's no need to change the
IR.
When that's not the case, the IR usually contains the pointer type of
the first operand - but since typed pointers are going away, that
representation is insufficient so I'm just stripping the "pointerness"
of the explicit type away.
This does make the IR a bit weird - it /sort of/ reads like the type of
the first operand: "call void () %x(" but %x is actually of type "void
()*" and will eventually be just of type "ptr". But this seems not too
bad and I don't think it would benefit from repeating the type
("void (), void () * %x(" and then eventually "void (), ptr %x(") as has
been done with gep and load.
This also has a side benefit: since the explicit type is no longer a
pointer, there's no ambiguity between an explicit type and a function
that returns a function pointer. Previously this case needed an explicit
type (eg: a function returning a void() function was written as
"call void () () * @x(" rather than "call void () * @x(" because of the
ambiguity between a function returning a pointer to a void() function
and a function returning void).
No ambiguity means even function pointer return types can just be
written alone, without writing the whole function's type.
This leaves /only/ the varargs case where the explicit type is required.
Given the special type syntax in call instructions, the regex-fu used
for migration was a bit more involved in its own unique way (as every
one of these is) so here it is. Use it in conjunction with the apply.sh
script and associated find/xargs commands I've provided in rr230786 to
migrate your out of tree tests. Do let me know if any of this doesn't
cover your cases & we can iterate on a more general script/regexes to
help others with out of tree tests.
About 9 test cases couldn't be automatically migrated - half of those
were functions returning function pointers, where I just had to manually
delete the function argument types now that we didn't need an explicit
function type there. The other half were typedefs of function types used
in calls - just had to manually drop the * from those.
import fileinput
import sys
import re
pat = re.compile(r'((?:=|:|^|\s)call\s(?:[^@]*?))(\s*$|\s*(?:(?:\[\[[a-zA-Z0-9_]+\]\]|[@%](?:(")?[\\\?@a-zA-Z0-9_.]*?(?(3)"|)|{{.*}}))(?:\(|$)|undef|inttoptr|bitcast|null|asm).*$)')
addrspace_end = re.compile(r"addrspace\(\d+\)\s*\*$")
func_end = re.compile("(?:void.*|\)\s*)\*$")
def conv(match, line):
if not match or re.search(addrspace_end, match.group(1)) or not re.search(func_end, match.group(1)):
return line
return line[:match.start()] + match.group(1)[:match.group(1).rfind('*')].rstrip() + match.group(2) + line[match.end():]
for line in sys.stdin:
sys.stdout.write(conv(re.search(pat, line), line))
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@235145 91177308-0d34-0410-b5e6-96231b3b80d8
233 lines
6.4 KiB
LLVM
233 lines
6.4 KiB
LLVM
; RUN: opt -objc-arc-contract -S < %s | FileCheck %s
|
|
|
|
target datalayout = "e-p:64:64:64"
|
|
|
|
declare i8* @objc_retain(i8*)
|
|
declare void @objc_release(i8*)
|
|
declare i8* @objc_autorelease(i8*)
|
|
declare i8* @objc_autoreleaseReturnValue(i8*)
|
|
declare i8* @objc_retainAutoreleasedReturnValue(i8*)
|
|
|
|
declare void @use_pointer(i8*)
|
|
declare i8* @returner()
|
|
declare void @callee()
|
|
|
|
; CHECK-LABEL: define void @test0(
|
|
; CHECK: call void @use_pointer(i8* %0)
|
|
; CHECK: }
|
|
define void @test0(i8* %x) nounwind {
|
|
entry:
|
|
%0 = call i8* @objc_retain(i8* %x) nounwind
|
|
call void @use_pointer(i8* %x)
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: define void @test1(
|
|
; CHECK: call void @use_pointer(i8* %0)
|
|
; CHECK: }
|
|
define void @test1(i8* %x) nounwind {
|
|
entry:
|
|
%0 = call i8* @objc_autorelease(i8* %x) nounwind
|
|
call void @use_pointer(i8* %x)
|
|
ret void
|
|
}
|
|
|
|
; Merge objc_retain and objc_autorelease into objc_retainAutorelease.
|
|
|
|
; CHECK-LABEL: define void @test2(
|
|
; CHECK: tail call i8* @objc_retainAutorelease(i8* %x) [[NUW:#[0-9]+]]
|
|
; CHECK: }
|
|
define void @test2(i8* %x) nounwind {
|
|
entry:
|
|
%0 = tail call i8* @objc_retain(i8* %x) nounwind
|
|
call i8* @objc_autorelease(i8* %0) nounwind
|
|
call void @use_pointer(i8* %x)
|
|
ret void
|
|
}
|
|
|
|
; Same as test2 but the value is returned. Do an RV optimization.
|
|
|
|
; CHECK-LABEL: define i8* @test2b(
|
|
; CHECK: tail call i8* @objc_retainAutoreleaseReturnValue(i8* %x) [[NUW]]
|
|
; CHECK: }
|
|
define i8* @test2b(i8* %x) nounwind {
|
|
entry:
|
|
%0 = tail call i8* @objc_retain(i8* %x) nounwind
|
|
tail call i8* @objc_autoreleaseReturnValue(i8* %0) nounwind
|
|
ret i8* %x
|
|
}
|
|
|
|
; Merge a retain,autorelease pair around a call.
|
|
|
|
; CHECK-LABEL: define void @test3(
|
|
; CHECK: tail call i8* @objc_retainAutorelease(i8* %x) [[NUW]]
|
|
; CHECK: @use_pointer(i8* %0)
|
|
; CHECK: }
|
|
define void @test3(i8* %x, i64 %n) {
|
|
entry:
|
|
tail call i8* @objc_retain(i8* %x) nounwind
|
|
call void @use_pointer(i8* %x)
|
|
call i8* @objc_autorelease(i8* %x) nounwind
|
|
ret void
|
|
}
|
|
|
|
; Trivial retain,autorelease pair with intervening call, but it's post-dominated
|
|
; by another release. The retain and autorelease can be merged.
|
|
|
|
; CHECK-LABEL: define void @test4(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: @objc_retainAutorelease(i8* %x) [[NUW]]
|
|
; CHECK-NEXT: @use_pointer
|
|
; CHECK-NEXT: @objc_release
|
|
; CHECK-NEXT: ret void
|
|
; CHECK-NEXT: }
|
|
define void @test4(i8* %x, i64 %n) {
|
|
entry:
|
|
tail call i8* @objc_retain(i8* %x) nounwind
|
|
call void @use_pointer(i8* %x)
|
|
call i8* @objc_autorelease(i8* %x) nounwind
|
|
tail call void @objc_release(i8* %x) nounwind
|
|
ret void
|
|
}
|
|
|
|
; Don't merge retain and autorelease if they're not control-equivalent.
|
|
|
|
; CHECK-LABEL: define void @test5(
|
|
; CHECK: tail call i8* @objc_retain(i8* %p) [[NUW]]
|
|
; CHECK: true:
|
|
; CHECK: call i8* @objc_autorelease(i8* %0) [[NUW]]
|
|
; CHECK: }
|
|
define void @test5(i8* %p, i1 %a) {
|
|
entry:
|
|
tail call i8* @objc_retain(i8* %p) nounwind
|
|
br i1 %a, label %true, label %false
|
|
|
|
true:
|
|
call i8* @objc_autorelease(i8* %p) nounwind
|
|
call void @use_pointer(i8* %p)
|
|
ret void
|
|
|
|
false:
|
|
ret void
|
|
}
|
|
|
|
; Don't eliminate objc_retainAutoreleasedReturnValue by merging it into
|
|
; an objc_autorelease.
|
|
; TODO? Merge objc_retainAutoreleasedReturnValue and objc_autorelease into
|
|
; objc_retainAutoreleasedReturnValueAutorelease and merge
|
|
; objc_retainAutoreleasedReturnValue and objc_autoreleaseReturnValue
|
|
; into objc_retainAutoreleasedReturnValueAutoreleaseReturnValue?
|
|
; Those entrypoints don't exist yet though.
|
|
|
|
; CHECK-LABEL: define i8* @test6(
|
|
; CHECK: call i8* @objc_retainAutoreleasedReturnValue(i8* %p) [[NUW]]
|
|
; CHECK: %t = tail call i8* @objc_autoreleaseReturnValue(i8* %1) [[NUW]]
|
|
; CHECK: }
|
|
define i8* @test6() {
|
|
%p = call i8* @returner()
|
|
tail call i8* @objc_retainAutoreleasedReturnValue(i8* %p) nounwind
|
|
%t = tail call i8* @objc_autoreleaseReturnValue(i8* %p) nounwind
|
|
call void @use_pointer(i8* %t)
|
|
ret i8* %t
|
|
}
|
|
|
|
; Don't spoil the RV optimization.
|
|
|
|
; CHECK: define i8* @test7(i8* %p)
|
|
; CHECK: tail call i8* @objc_retain(i8* %p)
|
|
; CHECK: call void @use_pointer(i8* %1)
|
|
; CHECK: tail call i8* @objc_autoreleaseReturnValue(i8* %1)
|
|
; CHECK: ret i8* %2
|
|
; CHECK-NEXT: }
|
|
define i8* @test7(i8* %p) {
|
|
%1 = tail call i8* @objc_retain(i8* %p)
|
|
call void @use_pointer(i8* %p)
|
|
%2 = tail call i8* @objc_autoreleaseReturnValue(i8* %p)
|
|
ret i8* %p
|
|
}
|
|
|
|
; Do the return value substitution for PHI nodes too.
|
|
|
|
; CHECK-LABEL: define i8* @test8(
|
|
; CHECK: %retval = phi i8* [ %p, %if.then ], [ null, %entry ]
|
|
; CHECK: }
|
|
define i8* @test8(i1 %x, i8* %c) {
|
|
entry:
|
|
br i1 %x, label %return, label %if.then
|
|
|
|
if.then: ; preds = %entry
|
|
%p = call i8* @objc_retain(i8* %c) nounwind
|
|
br label %return
|
|
|
|
return: ; preds = %if.then, %entry
|
|
%retval = phi i8* [ %c, %if.then ], [ null, %entry ]
|
|
ret i8* %retval
|
|
}
|
|
|
|
; Kill calls to @clang.arc.use(...)
|
|
; CHECK-LABEL: define void @test9(
|
|
; CHECK-NOT: clang.arc.use
|
|
; CHECK: }
|
|
define void @test9(i8* %a, i8* %b) {
|
|
call void (...) @clang.arc.use(i8* %a, i8* %b) nounwind
|
|
ret void
|
|
}
|
|
|
|
|
|
; Turn objc_retain into objc_retainAutoreleasedReturnValue if its operand
|
|
; is a return value.
|
|
|
|
; CHECK: define void @test10()
|
|
; CHECK: tail call i8* @objc_retainAutoreleasedReturnValue(i8* %p)
|
|
define void @test10() {
|
|
%p = call i8* @returner()
|
|
tail call i8* @objc_retain(i8* %p) nounwind
|
|
ret void
|
|
}
|
|
|
|
; Convert objc_retain to objc_retainAutoreleasedReturnValue if its
|
|
; argument is a return value.
|
|
|
|
; CHECK-LABEL: define void @test11(
|
|
; CHECK-NEXT: %y = call i8* @returner()
|
|
; CHECK-NEXT: tail call i8* @objc_retainAutoreleasedReturnValue(i8* %y) [[NUW]]
|
|
; CHECK-NEXT: ret void
|
|
define void @test11() {
|
|
%y = call i8* @returner()
|
|
tail call i8* @objc_retain(i8* %y) nounwind
|
|
ret void
|
|
}
|
|
|
|
; Don't convert objc_retain to objc_retainAutoreleasedReturnValue if its
|
|
; argument is not a return value.
|
|
|
|
; CHECK-LABEL: define void @test12(
|
|
; CHECK-NEXT: tail call i8* @objc_retain(i8* %y) [[NUW]]
|
|
; CHECK-NEXT: ret void
|
|
; CHECK-NEXT: }
|
|
define void @test12(i8* %y) {
|
|
tail call i8* @objc_retain(i8* %y) nounwind
|
|
ret void
|
|
}
|
|
|
|
; Don't Convert objc_retain to objc_retainAutoreleasedReturnValue if it
|
|
; isn't next to the call providing its return value.
|
|
|
|
; CHECK-LABEL: define void @test13(
|
|
; CHECK-NEXT: %y = call i8* @returner()
|
|
; CHECK-NEXT: call void @callee()
|
|
; CHECK-NEXT: tail call i8* @objc_retain(i8* %y) [[NUW]]
|
|
; CHECK-NEXT: ret void
|
|
; CHECK-NEXT: }
|
|
define void @test13() {
|
|
%y = call i8* @returner()
|
|
call void @callee()
|
|
tail call i8* @objc_retain(i8* %y) nounwind
|
|
ret void
|
|
}
|
|
|
|
|
|
declare void @clang.arc.use(...) nounwind
|
|
|
|
; CHECK: attributes [[NUW]] = { nounwind }
|