mirror of
https://github.com/RPCSX/llvm.git
synced 2024-11-24 20:29:53 +00:00
198d8baafb
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230786 91177308-0d34-0410-b5e6-96231b3b80d8
62 lines
1.9 KiB
LLVM
62 lines
1.9 KiB
LLVM
; RUN: opt < %s -instcombine -S | FileCheck %s
|
|
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
|
|
target triple = "x86_64-pc-win32"
|
|
|
|
declare void @use(i32) readonly
|
|
|
|
; We prefer to canonicalize the machine width gep indices early
|
|
define void @test(i32* %p, i32 %index) {
|
|
; CHECK-LABEL: @test
|
|
; CHECK-NEXT: %1 = sext i32 %index to i64
|
|
; CHECK-NEXT: %addr = getelementptr i32, i32* %p, i64 %1
|
|
%addr = getelementptr i32, i32* %p, i32 %index
|
|
%val = load i32* %addr
|
|
call void @use(i32 %val)
|
|
ret void
|
|
}
|
|
; If they've already been canonicalized via zext, that's fine
|
|
define void @test2(i32* %p, i32 %index) {
|
|
; CHECK-LABEL: @test2
|
|
; CHECK-NEXT: %i = zext i32 %index to i64
|
|
; CHECK-NEXT: %addr = getelementptr i32, i32* %p, i64 %i
|
|
%i = zext i32 %index to i64
|
|
%addr = getelementptr i32, i32* %p, i64 %i
|
|
%val = load i32* %addr
|
|
call void @use(i32 %val)
|
|
ret void
|
|
}
|
|
; If we can use a zext, we prefer that. This requires
|
|
; knowing that the index is positive.
|
|
define void @test3(i32* %p, i32 %index) {
|
|
; CHECK-LABEL: @test3
|
|
; CHECK: zext
|
|
; CHECK-NOT: sext
|
|
%addr_begin = getelementptr i32, i32* %p, i64 40
|
|
%addr_fixed = getelementptr i32, i32* %addr_begin, i64 48
|
|
%val_fixed = load i32* %addr_fixed, !range !0
|
|
%addr = getelementptr i32, i32* %addr_begin, i32 %val_fixed
|
|
%val = load i32* %addr
|
|
call void @use(i32 %val)
|
|
ret void
|
|
}
|
|
; Replace sext with zext where possible
|
|
define void @test4(i32* %p, i32 %index) {
|
|
; CHECK-LABEL: @test4
|
|
; CHECK: zext
|
|
; CHECK-NOT: sext
|
|
%addr_begin = getelementptr i32, i32* %p, i64 40
|
|
%addr_fixed = getelementptr i32, i32* %addr_begin, i64 48
|
|
%val_fixed = load i32* %addr_fixed, !range !0
|
|
%i = sext i32 %val_fixed to i64
|
|
%addr = getelementptr i32, i32* %addr_begin, i64 %i
|
|
%val = load i32* %addr
|
|
call void @use(i32 %val)
|
|
ret void
|
|
}
|
|
|
|
;; !range !0
|
|
!0 = !{i32 0, i32 2147483647}
|
|
|
|
|
|
|