mirror of
https://github.com/RPCSX/llvm.git
synced 2024-12-15 16:09:02 +00:00
5052940c27
Summary: This patch was originally in D5304 (I could not find a way to reopen that revision). It was accepted, commited and broke the build bots because the overloading of the constructor of ArrayRef for braced initializer lists is not supported by all toolchains. I then reverted it, and propose this fixed version that uses a plain C array instead in makeDMB (that array is then converted implicitly to an ArrayRef, but that is not behind an ifdef). Could someone confirm me whether initialization lists for plain C arrays are supported by every toolchain used to build llvm ? Otherwise I can just initialize the array in the old way: args[0] = ...; .. ; args[5] = ...; Below is the description of the original patch: ``` I had only tested this code for ARMv7 and ARMv8. This patch adds several fallback paths if the processor does not support dmb ish: - dmb sy if a cortex-M with support for dmb - mcr p15, #0, r0, c7, c10, #5 for ARMv6 (special instruction equivalent to a DMB) These fallback paths were chosen based on the code for fence seq_cst. Thanks to luqmana for having noticed this bug. ``` Test Plan: Added more cases to atomic-load-store.ll + make check-all Reviewers: jfb, t.p.northover, luqmana Subscribers: llvm-commits, aemerson Differential Revision: http://reviews.llvm.org/D5386 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218066 91177308-0d34-0410-b5e6-96231b3b80d8
108 lines
2.8 KiB
LLVM
108 lines
2.8 KiB
LLVM
; RUN: llc < %s -mtriple=armv7-apple-ios -verify-machineinstrs | FileCheck %s -check-prefix=ARM
|
|
; RUN: llc < %s -mtriple=armv7-apple-ios -O0 | FileCheck %s -check-prefix=ARM
|
|
; RUN: llc < %s -mtriple=thumbv7-apple-ios -verify-machineinstrs | FileCheck %s -check-prefix=THUMBTWO
|
|
; RUN: llc < %s -mtriple=thumbv6-apple-ios | FileCheck %s -check-prefix=THUMBONE
|
|
; RUN: llc < %s -mtriple=armv4-apple-ios | FileCheck %s -check-prefix=ARMV4
|
|
; RUN: llc < %s -mtriple=armv6-apple-ios | FileCheck %s -check-prefix=ARMV6
|
|
; RUN: llc < %s -mtriple=thumbv7m-apple-ios | FileCheck %s -check-prefix=THUMBM
|
|
|
|
define void @test1(i32* %ptr, i32 %val1) {
|
|
; ARM-LABEL: test1
|
|
; ARM: dmb {{ish$}}
|
|
; ARM-NEXT: str
|
|
; ARM-NEXT: dmb {{ish$}}
|
|
; THUMBONE-LABEL: test1
|
|
; THUMBONE: __sync_lock_test_and_set_4
|
|
; THUMBTWO-LABEL: test1
|
|
; THUMBTWO: dmb {{ish$}}
|
|
; THUMBTWO-NEXT: str
|
|
; THUMBTWO-NEXT: dmb {{ish$}}
|
|
; ARMV6-LABEL: test1
|
|
; ARMV6: mcr p15, #0, {{r[0-9]*}}, c7, c10, #5
|
|
; ARMV6: str
|
|
; ARMV6: mcr p15, #0, {{r[0-9]*}}, c7, c10, #5
|
|
; THUMBM-LABEL: test1
|
|
; THUMBM: dmb sy
|
|
; THUMBM: str
|
|
; THUMBM: dmb sy
|
|
store atomic i32 %val1, i32* %ptr seq_cst, align 4
|
|
ret void
|
|
}
|
|
|
|
define i32 @test2(i32* %ptr) {
|
|
; ARM-LABEL: test2
|
|
; ARM: ldr
|
|
; ARM-NEXT: dmb {{ish$}}
|
|
; THUMBONE-LABEL: test2
|
|
; THUMBONE: __sync_val_compare_and_swap_4
|
|
; THUMBTWO-LABEL: test2
|
|
; THUMBTWO: ldr
|
|
; THUMBTWO-NEXT: dmb {{ish$}}
|
|
; ARMV6-LABEL: test2
|
|
; ARMV6: ldr
|
|
; ARMV6: mcr p15, #0, {{r[0-9]*}}, c7, c10, #5
|
|
; THUMBM-LABEL: test2
|
|
; THUMBM: ldr
|
|
; THUMBM: dmb sy
|
|
%val = load atomic i32* %ptr seq_cst, align 4
|
|
ret i32 %val
|
|
}
|
|
|
|
define void @test3(i8* %ptr1, i8* %ptr2) {
|
|
; ARM-LABEL: test3
|
|
; ARM-NOT: dmb
|
|
; ARM: ldrb
|
|
; ARM-NOT: dmb
|
|
; ARM: strb
|
|
; ARM-NOT: dmb
|
|
; ARM: bx lr
|
|
|
|
; THUMBTWO-LABEL: test3
|
|
; THUMBTWO-NOT: dmb
|
|
; THUMBTWO: ldrb
|
|
; THUMBTWO-NOT: dmb
|
|
; THUMBTWO: strb
|
|
; THUMBTWO-NOT: dmb
|
|
; THUMBTWO: bx lr
|
|
|
|
; THUMBONE-LABEL: test3
|
|
; THUMBONE-NOT: dmb
|
|
; THUMBONE: ldrb
|
|
; THUMBONE-NOT: dmb
|
|
; THUMBONE: strb
|
|
; THUMBONE-NOT: dmb
|
|
|
|
; ARMV6-LABEL: test3
|
|
; ARMV6-NOT: mcr
|
|
; THUMBM-LABEL: test3
|
|
; THUMBM-NOT: dmb sy
|
|
%val = load atomic i8* %ptr1 unordered, align 1
|
|
store atomic i8 %val, i8* %ptr2 unordered, align 1
|
|
ret void
|
|
}
|
|
|
|
define void @test4(i8* %ptr1, i8* %ptr2) {
|
|
; THUMBONE-LABEL: test4
|
|
; THUMBONE: ___sync_val_compare_and_swap_1
|
|
; THUMBONE: ___sync_lock_test_and_set_1
|
|
; ARMV6-LABEL: test4
|
|
; THUMBM-LABEL: test4
|
|
%val = load atomic i8* %ptr1 seq_cst, align 1
|
|
store atomic i8 %val, i8* %ptr2 seq_cst, align 1
|
|
ret void
|
|
}
|
|
|
|
define i64 @test_old_load_64bit(i64* %p) {
|
|
; ARMV4-LABEL: test_old_load_64bit
|
|
; ARMV4: ___sync_val_compare_and_swap_8
|
|
%1 = load atomic i64* %p seq_cst, align 8
|
|
ret i64 %1
|
|
}
|
|
|
|
define void @test_old_store_64bit(i64* %p, i64 %v) {
|
|
; ARMV4-LABEL: test_old_store_64bit
|
|
; ARMV4: ___sync_lock_test_and_set_8
|
|
store atomic i64 %v, i64* %p seq_cst, align 8
|
|
ret void
|
|
}
|