Kevin Enderby 34a869ca6c Add a checkSymbolTable() method to the MachOObjectFile class. ... The philosophy of the error checking in libObject for Mach-O files is that the constructor will check the load commands so for their tables the offsets and sizes are properly contained in the file. But there is no checking of the entries of any of the tables. For the contents of the tables themselves the methods accessing the contents of the entries return errors as needed. In some cases this however makes it difficult or cumbersome to produce a good error message which would include the tool name, file name, archive member, and name of the architecture of a slice of a universal file the error occurred in. So idea is that there will be a method to check a table which can be called up front before using it allowing a good error message to be produced before a table is used. And if only verification of the Mach-O file and its tables are wanted a new possible method checkAllTables() could be added to call all of the methods to check all the tables at some time when such methods exist. The checkSymbolTable() is the first of such methods to check one of the Mach-O file tables. This method initially will used in llvm-objdump’s DisassembleMachO() routine before it gets the section and symbol information. As if there are problems with the symbol table currently the error is first encountered by the bool operator() in the SymbolSorter() struct which passed to std::sort(). In this case there is no context as to the file name the symbol which results a poor error message: LLVM ERROR: truncated or malformed object (bad string index: 22 for symbol at index 1) with the added call to the checkSymbolTable() method the error message includes the tool name and file name: llvm-objdump: 'macho-invalid-symbol-strx': truncated or malformed object (bad string table index: 22 past the end of string table, for symbol at index 1) git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@286887 91177308-0d34-0410-b5e6-96231b3b80d8		2016-11-14 20:57:04 +00:00
..
CMakeLists.txt	Add an c++ itanium demangler to llvm.	2016-09-06 19:16:48 +00:00
COFFDump.cpp	[llvm-objdump] Switch to a range loop. NFCI.	2016-09-30 23:22:42 +00:00
ELFDump.cpp	Replace a report_fatal_error with an ErrorOr.	2016-11-03 17:28:33 +00:00
llvm-objdump.cpp	Make the Error class constructor protected	2016-11-11 04:28:40 +00:00
llvm-objdump.h	llvm-objdump: add coff import library symbol listing support	2016-08-18 16:39:19 +00:00
LLVMBuild.txt	Add an c++ itanium demangler to llvm.	2016-09-06 19:16:48 +00:00
MachODump.cpp	Add a checkSymbolTable() method to the MachOObjectFile class.	2016-11-14 20:57:04 +00:00