mirror of
https://github.com/RPCSX/llvm.git
synced 2025-01-31 17:42:40 +00:00
e942cf87e8
sanitizer issue. The PredicatedScalarEvolution's copy constructor wasn't copying the Generation value, and was leaving it un-initialized. Original commit message: [SCEV][LAA] Add no wrap SCEV predicates and use use them to improve strided pointer detection Summary: This change adds no wrap SCEV predicates with: - support for runtime checking - support for expression rewriting: (sext ({x,+,y}) -> {sext(x),+,sext(y)} (zext ({x,+,y}) -> {zext(x),+,sext(y)} Note that we are sign extending the increment of the SCEV, even for the zext case. This is needed to cover the fairly common case where y would be a (small) negative integer. In order to do this, this change adds two new flags: nusw and nssw that are applicable to AddRecExprs and permit the transformations above. We also change isStridedPtr in LAA to be able to make use of these predicates. With this feature we should now always be able to work around overflow issues in the dependence analysis. Reviewers: mzolotukhin, sanjoy, anemet Subscribers: mzolotukhin, sanjoy, llvm-commits, rengolin, jmolloy, hfinkel Differential Revision: http://reviews.llvm.org/D15412 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@260112 91177308-0d34-0410-b5e6-96231b3b80d8
221 lines
8.2 KiB
C++
221 lines
8.2 KiB
C++
//===- LoopVersioning.cpp - Utility to version a loop ---------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines a utility class to perform loop versioning. The versioned
|
|
// loop speculates that otherwise may-aliasing memory accesses don't overlap and
|
|
// emits checks to prove this.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/Transforms/Utils/LoopVersioning.h"
|
|
#include "llvm/Analysis/LoopAccessAnalysis.h"
|
|
#include "llvm/Analysis/LoopInfo.h"
|
|
#include "llvm/Analysis/ScalarEvolutionExpander.h"
|
|
#include "llvm/IR/Dominators.h"
|
|
#include "llvm/Transforms/Utils/BasicBlockUtils.h"
|
|
#include "llvm/Transforms/Utils/Cloning.h"
|
|
|
|
using namespace llvm;
|
|
|
|
LoopVersioning::LoopVersioning(const LoopAccessInfo &LAI, Loop *L, LoopInfo *LI,
|
|
DominatorTree *DT, ScalarEvolution *SE,
|
|
bool UseLAIChecks)
|
|
: VersionedLoop(L), NonVersionedLoop(nullptr), LAI(LAI), LI(LI), DT(DT),
|
|
SE(SE) {
|
|
assert(L->getExitBlock() && "No single exit block");
|
|
assert(L->getLoopPreheader() && "No preheader");
|
|
if (UseLAIChecks) {
|
|
setAliasChecks(LAI.getRuntimePointerChecking()->getChecks());
|
|
setSCEVChecks(LAI.PSE.getUnionPredicate());
|
|
}
|
|
}
|
|
|
|
void LoopVersioning::setAliasChecks(
|
|
const SmallVector<RuntimePointerChecking::PointerCheck, 4> Checks) {
|
|
AliasChecks = std::move(Checks);
|
|
}
|
|
|
|
void LoopVersioning::setSCEVChecks(SCEVUnionPredicate Check) {
|
|
Preds = std::move(Check);
|
|
}
|
|
|
|
void LoopVersioning::versionLoop(
|
|
const SmallVectorImpl<Instruction *> &DefsUsedOutside) {
|
|
Instruction *FirstCheckInst;
|
|
Instruction *MemRuntimeCheck;
|
|
Value *SCEVRuntimeCheck;
|
|
Value *RuntimeCheck = nullptr;
|
|
|
|
// Add the memcheck in the original preheader (this is empty initially).
|
|
BasicBlock *RuntimeCheckBB = VersionedLoop->getLoopPreheader();
|
|
std::tie(FirstCheckInst, MemRuntimeCheck) =
|
|
LAI.addRuntimeChecks(RuntimeCheckBB->getTerminator(), AliasChecks);
|
|
|
|
const SCEVUnionPredicate &Pred = LAI.PSE.getUnionPredicate();
|
|
SCEVExpander Exp(*SE, RuntimeCheckBB->getModule()->getDataLayout(),
|
|
"scev.check");
|
|
SCEVRuntimeCheck =
|
|
Exp.expandCodeForPredicate(&Pred, RuntimeCheckBB->getTerminator());
|
|
auto *CI = dyn_cast<ConstantInt>(SCEVRuntimeCheck);
|
|
|
|
// Discard the SCEV runtime check if it is always true.
|
|
if (CI && CI->isZero())
|
|
SCEVRuntimeCheck = nullptr;
|
|
|
|
if (MemRuntimeCheck && SCEVRuntimeCheck) {
|
|
RuntimeCheck = BinaryOperator::Create(Instruction::Or, MemRuntimeCheck,
|
|
SCEVRuntimeCheck, "ldist.safe");
|
|
if (auto *I = dyn_cast<Instruction>(RuntimeCheck))
|
|
I->insertBefore(RuntimeCheckBB->getTerminator());
|
|
} else
|
|
RuntimeCheck = MemRuntimeCheck ? MemRuntimeCheck : SCEVRuntimeCheck;
|
|
|
|
assert(RuntimeCheck && "called even though we don't need "
|
|
"any runtime checks");
|
|
|
|
// Rename the block to make the IR more readable.
|
|
RuntimeCheckBB->setName(VersionedLoop->getHeader()->getName() +
|
|
".lver.check");
|
|
|
|
// Create empty preheader for the loop (and after cloning for the
|
|
// non-versioned loop).
|
|
BasicBlock *PH =
|
|
SplitBlock(RuntimeCheckBB, RuntimeCheckBB->getTerminator(), DT, LI);
|
|
PH->setName(VersionedLoop->getHeader()->getName() + ".ph");
|
|
|
|
// Clone the loop including the preheader.
|
|
//
|
|
// FIXME: This does not currently preserve SimplifyLoop because the exit
|
|
// block is a join between the two loops.
|
|
SmallVector<BasicBlock *, 8> NonVersionedLoopBlocks;
|
|
NonVersionedLoop =
|
|
cloneLoopWithPreheader(PH, RuntimeCheckBB, VersionedLoop, VMap,
|
|
".lver.orig", LI, DT, NonVersionedLoopBlocks);
|
|
remapInstructionsInBlocks(NonVersionedLoopBlocks, VMap);
|
|
|
|
// Insert the conditional branch based on the result of the memchecks.
|
|
Instruction *OrigTerm = RuntimeCheckBB->getTerminator();
|
|
BranchInst::Create(NonVersionedLoop->getLoopPreheader(),
|
|
VersionedLoop->getLoopPreheader(), RuntimeCheck, OrigTerm);
|
|
OrigTerm->eraseFromParent();
|
|
|
|
// The loops merge in the original exit block. This is now dominated by the
|
|
// memchecking block.
|
|
DT->changeImmediateDominator(VersionedLoop->getExitBlock(), RuntimeCheckBB);
|
|
|
|
// Adds the necessary PHI nodes for the versioned loops based on the
|
|
// loop-defined values used outside of the loop.
|
|
addPHINodes(DefsUsedOutside);
|
|
}
|
|
|
|
void LoopVersioning::addPHINodes(
|
|
const SmallVectorImpl<Instruction *> &DefsUsedOutside) {
|
|
BasicBlock *PHIBlock = VersionedLoop->getExitBlock();
|
|
assert(PHIBlock && "No single successor to loop exit block");
|
|
|
|
for (auto *Inst : DefsUsedOutside) {
|
|
auto *NonVersionedLoopInst = cast<Instruction>(VMap[Inst]);
|
|
PHINode *PN;
|
|
|
|
// First see if we have a single-operand PHI with the value defined by the
|
|
// original loop.
|
|
for (auto I = PHIBlock->begin(); (PN = dyn_cast<PHINode>(I)); ++I) {
|
|
assert(PN->getNumOperands() == 1 &&
|
|
"Exit block should only have on predecessor");
|
|
if (PN->getIncomingValue(0) == Inst)
|
|
break;
|
|
}
|
|
// If not create it.
|
|
if (!PN) {
|
|
PN = PHINode::Create(Inst->getType(), 2, Inst->getName() + ".lver",
|
|
&PHIBlock->front());
|
|
for (auto *User : Inst->users())
|
|
if (!VersionedLoop->contains(cast<Instruction>(User)->getParent()))
|
|
User->replaceUsesOfWith(Inst, PN);
|
|
PN->addIncoming(Inst, VersionedLoop->getExitingBlock());
|
|
}
|
|
// Add the new incoming value from the non-versioned loop.
|
|
PN->addIncoming(NonVersionedLoopInst, NonVersionedLoop->getExitingBlock());
|
|
}
|
|
}
|
|
|
|
namespace {
|
|
/// \brief Also expose this is a pass. Currently this is only used for
|
|
/// unit-testing. It adds all memchecks necessary to remove all may-aliasing
|
|
/// array accesses from the loop.
|
|
class LoopVersioningPass : public FunctionPass {
|
|
public:
|
|
LoopVersioningPass() : FunctionPass(ID) {
|
|
initializeLoopVersioningPassPass(*PassRegistry::getPassRegistry());
|
|
}
|
|
|
|
bool runOnFunction(Function &F) override {
|
|
auto *LI = &getAnalysis<LoopInfoWrapperPass>().getLoopInfo();
|
|
auto *LAA = &getAnalysis<LoopAccessAnalysis>();
|
|
auto *DT = &getAnalysis<DominatorTreeWrapperPass>().getDomTree();
|
|
auto *SE = &getAnalysis<ScalarEvolutionWrapperPass>().getSE();
|
|
|
|
// Build up a worklist of inner-loops to version. This is necessary as the
|
|
// act of versioning a loop creates new loops and can invalidate iterators
|
|
// across the loops.
|
|
SmallVector<Loop *, 8> Worklist;
|
|
|
|
for (Loop *TopLevelLoop : *LI)
|
|
for (Loop *L : depth_first(TopLevelLoop))
|
|
// We only handle inner-most loops.
|
|
if (L->empty())
|
|
Worklist.push_back(L);
|
|
|
|
// Now walk the identified inner loops.
|
|
bool Changed = false;
|
|
for (Loop *L : Worklist) {
|
|
const LoopAccessInfo &LAI = LAA->getInfo(L, ValueToValueMap());
|
|
if (LAI.getNumRuntimePointerChecks() ||
|
|
!LAI.PSE.getUnionPredicate().isAlwaysTrue()) {
|
|
LoopVersioning LVer(LAI, L, LI, DT, SE);
|
|
LVer.versionLoop();
|
|
Changed = true;
|
|
}
|
|
}
|
|
|
|
return Changed;
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.addRequired<LoopInfoWrapperPass>();
|
|
AU.addPreserved<LoopInfoWrapperPass>();
|
|
AU.addRequired<LoopAccessAnalysis>();
|
|
AU.addRequired<DominatorTreeWrapperPass>();
|
|
AU.addPreserved<DominatorTreeWrapperPass>();
|
|
AU.addRequired<ScalarEvolutionWrapperPass>();
|
|
}
|
|
|
|
static char ID;
|
|
};
|
|
}
|
|
|
|
#define LVER_OPTION "loop-versioning"
|
|
#define DEBUG_TYPE LVER_OPTION
|
|
|
|
char LoopVersioningPass::ID;
|
|
static const char LVer_name[] = "Loop Versioning";
|
|
|
|
INITIALIZE_PASS_BEGIN(LoopVersioningPass, LVER_OPTION, LVer_name, false, false)
|
|
INITIALIZE_PASS_DEPENDENCY(LoopInfoWrapperPass)
|
|
INITIALIZE_PASS_DEPENDENCY(LoopAccessAnalysis)
|
|
INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
|
|
INITIALIZE_PASS_DEPENDENCY(ScalarEvolutionWrapperPass)
|
|
INITIALIZE_PASS_END(LoopVersioningPass, LVER_OPTION, LVer_name, false, false)
|
|
|
|
namespace llvm {
|
|
FunctionPass *createLoopVersioningPass() {
|
|
return new LoopVersioningPass();
|
|
}
|
|
}
|