mirror of
https://github.com/RPCSX/llvm.git
synced 2024-11-28 14:10:41 +00:00
77b9fc127b
The subtarget information is the ultimate source of truth for the feature set that is enabled at this point. We would previously not propagate the feature information to the subtarget. While this worked for the most part (features would be enabled/disabled as requested), if another operation that changed the feature bits was encountered (such as a mode switch via a .arm or .thumb directive), we would end up resetting the behaviour of the architectural extensions. Handling this properly requires a slightly more complicated handling. We need to check if the feature is now being toggled. If so, only then do we toggle the features. In return, we no longer have to calculate the feature bits ourselves. The test changes are mostly to the diagnosis, which is now more uniform (a nice side effect!). Add an additional test to ensure that we handle this case properly. Thanks to Nico Weber for alerting me to this issue! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214057 91177308-0d34-0410-b5e6-96231b3b80d8
54 lines
2.5 KiB
ArmAsm
54 lines
2.5 KiB
ArmAsm
@ RUN: not llvm-mc -triple armv6-eabi -filetype asm -o /dev/null 2>&1 %s \
|
|
@ RUN: | FileCheck %s -check-prefix CHECK-ARMv6 -check-prefix CHECK-V6
|
|
@ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
|
|
@ RUN: | FileCheck %s -check-prefix CHECK-ARMv7 -check-prefix CHECK-V7
|
|
@ RUN: not llvm-mc -triple armv7m-eabi -filetype asm -o /dev/null 2>&1 %s \
|
|
@ RUN: | FileCheck %s -check-prefix CHECK-ARMv7M -check-prefix CHECK-V7M
|
|
@ RUN: not llvm-mc -triple thumbv6-eabi -filetype asm -o /dev/null 2>&1 %s \
|
|
@ RUN: | FileCheck %s -check-prefix CHECK-THUMBv6 -check-prefix CHECK-V6
|
|
@ RUN: not llvm-mc -triple thumbv7-eabi -filetype asm -o /dev/null 2>&1 %s \
|
|
@ RUN: | FileCheck %s -check-prefix CHECK-THUMBv7 -check-prefix CHECK-V7
|
|
@ RUN: not llvm-mc -triple thumbv7m-eabi -filetype asm -o /dev/null 2>&1 %s \
|
|
@ RUN: | FileCheck %s -check-prefix CHECK-THUMBv7M -check-prefix CHECK-V7M
|
|
|
|
.syntax unified
|
|
|
|
.arch_extension idiv
|
|
@ CHECK-V6: error: architectural extension 'idiv' is not allowed for the current base architecture
|
|
@ CHECK-V6-NEXT: .arch_extension idiv
|
|
@ CHECK-V6-NEXT: ^
|
|
@ CHECK-V7M: error: architectural extension 'idiv' is not allowed for the current base architecture
|
|
@ CHECK-V7M-NEXT: .arch_extension idiv
|
|
@ CHECK-V7M-NEXT: ^
|
|
|
|
.type idiv,%function
|
|
idiv:
|
|
udiv r0, r1, r2
|
|
@ CHECK-ARMv6: error: instruction requires: divide in ARM
|
|
@ CHECK-THUMBv6: error: instruction requires: divide in ARM arm-mode
|
|
sdiv r0, r1, r2
|
|
@ CHECK-ARMv6: error: instruction requires: divide in ARM
|
|
@ CHECK-THUMBv6: error: instruction requires: divide in ARM arm-mode
|
|
|
|
.arch_extension noidiv
|
|
@ CHECK-V6: error: architectural extension 'idiv' is not allowed for the current base architecture
|
|
@ CHECK-V6-NEXT: .arch_extension noidiv
|
|
@ CHECK-V6-NEXT: ^
|
|
@ CHECK-V7M: error: architectural extension 'idiv' is not allowed for the current base architecture
|
|
@ CHECK-V7M-NEXT: .arch_extension noidiv
|
|
@ CHECK-V7M-NEXT: ^
|
|
|
|
.type noidiv,%function
|
|
noidiv:
|
|
udiv r0, r1, r2
|
|
@ CHECK-ARMv6: error: instruction requires: divide in ARM
|
|
@ CHECK-THUMBv6: error: instruction requires: divide in ARM arm-mode
|
|
@ CHECK-ARMv7: error: instruction requires: divide in ARM
|
|
@ CHECK-THUMBv7: error: instruction requires: divide in THUMB
|
|
sdiv r0, r1, r2
|
|
@ CHECK-ARMv6: error: instruction requires: divide in ARM
|
|
@ CHECK-THUMBv6: error: instruction requires: divide in ARM arm-mode
|
|
@ CHECK-ARMv7: error: instruction requires: divide in ARM
|
|
@ CHECK-THUMBv7: error: instruction requires: divide in THUMB
|
|
|