mirror of
https://github.com/RPCSX/llvm.git
synced 2024-11-28 14:10:41 +00:00
dff57f19a1
Short description. This issue is about case of treating pointers as integers. We treat pointers as different if they references different address space. At the same time, we treat pointers equal to integers (with machine address width). It was a point of false-positive. Consider next case on 32bit machine: void foo0(i32 addrespace(1)* %p) void foo1(i32 addrespace(2)* %p) void foo2(i32 %p) foo0 != foo1, while foo1 == foo2 and foo0 == foo2. As you can see it breaks transitivity. That means that result depends on order of how functions are presented in module. Next order causes merging of foo0 and foo1: foo2, foo0, foo1 First foo0 will be merged with foo2, foo0 will be erased. Second foo1 will be merged with foo2. Depending on order, things could be merged we don't expect to. The fix: Forbid to treat any pointer as integer, except for those, who belong to address space 0. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195769 91177308-0d34-0410-b5e6-96231b3b80d8
26 lines
587 B
LLVM
26 lines
587 B
LLVM
; RUN: opt -S -mergefunc < %s | FileCheck %s
|
|
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
|
|
|
|
declare void @stuff()
|
|
|
|
define void @f0(i64 %p0) {
|
|
entry:
|
|
call void @stuff()
|
|
call void @stuff()
|
|
call void @stuff()
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: @f0
|
|
; CHECK: %2 = ptrtoint i64* %0 to i64
|
|
; CHECK: tail call void @f0(i64 %2)
|
|
; CHECK: ret void
|
|
define void @f1(i64 addrspace(0)* %p0) {
|
|
entry:
|
|
call void @stuff()
|
|
call void @stuff()
|
|
call void @stuff()
|
|
ret void
|
|
}
|
|
|