mirror of
https://github.com/RPCSX/llvm.git
synced 2024-12-14 23:48:49 +00:00
79b9222927
Summary: Before this change, SCEV Normalization would incorrectly normalize non-affine add recurrences. To work around this there was (still is) a check in place to make sure we only tried to normalize affine add recurrences. We recently found a bug in aforementioned check to bail out of normalizing non-affine add recurrences. However, instead of fixing the bailout, I have decided to teach SCEV normalization to work correctly with non-affine add recurrences, making the bailout unnecessary (I'll remove it in a subsequent change). I've also added some unit tests (which would have failed before this change). Reviewers: atrick, sunfish, efriedma Reviewed By: atrick Subscribers: mcrosier, mzolotukhin, llvm-commits Differential Revision: https://reviews.llvm.org/D32104 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@301281 91177308-0d34-0410-b5e6-96231b3b80d8
119 lines
4.6 KiB
C++
119 lines
4.6 KiB
C++
//===- ScalarEvolutionNormalization.cpp - See below -----------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file implements utilities for working with "normalized" expressions.
|
|
// See the comments at the top of ScalarEvolutionNormalization.h for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/Analysis/LoopInfo.h"
|
|
#include "llvm/Analysis/ScalarEvolutionExpressions.h"
|
|
#include "llvm/Analysis/ScalarEvolutionNormalization.h"
|
|
using namespace llvm;
|
|
|
|
/// TransformKind - Different types of transformations that
|
|
/// TransformForPostIncUse can do.
|
|
enum TransformKind {
|
|
/// Normalize - Normalize according to the given loops.
|
|
Normalize,
|
|
/// Denormalize - Perform the inverse transform on the expression with the
|
|
/// given loop set.
|
|
Denormalize
|
|
};
|
|
|
|
namespace {
|
|
struct NormalizeDenormalizeRewriter
|
|
: public SCEVRewriteVisitor<NormalizeDenormalizeRewriter> {
|
|
const TransformKind Kind;
|
|
|
|
// NB! Pred is a function_ref. Storing it here is okay only because
|
|
// we're careful about the lifetime of NormalizeDenormalizeRewriter.
|
|
const NormalizePredTy Pred;
|
|
|
|
NormalizeDenormalizeRewriter(TransformKind Kind, NormalizePredTy Pred,
|
|
ScalarEvolution &SE)
|
|
: SCEVRewriteVisitor<NormalizeDenormalizeRewriter>(SE), Kind(Kind),
|
|
Pred(Pred) {}
|
|
const SCEV *visitAddRecExpr(const SCEVAddRecExpr *Expr);
|
|
};
|
|
} // namespace
|
|
|
|
const SCEV *
|
|
NormalizeDenormalizeRewriter::visitAddRecExpr(const SCEVAddRecExpr *AR) {
|
|
SmallVector<const SCEV *, 8> Operands;
|
|
|
|
transform(AR->operands(), std::back_inserter(Operands),
|
|
[&](const SCEV *Op) { return visit(Op); });
|
|
|
|
if (!Pred(AR))
|
|
return SE.getAddRecExpr(Operands, AR->getLoop(), SCEV::FlagAnyWrap);
|
|
|
|
// Normalization and denormalization are fancy names for decrementing and
|
|
// incrementing a SCEV expression with respect to a set of loops. Since
|
|
// Pred(AR) has returned true, we know we need to normalize or denormalize AR
|
|
// with respect to its loop.
|
|
|
|
if (Kind == Denormalize) {
|
|
// Denormalization / "partial increment" is essentially the same as \c
|
|
// SCEVAddRecExpr::getPostIncExpr. Here we use an explicit loop to make the
|
|
// symmetry with Normalization clear.
|
|
for (int i = 0, e = Operands.size() - 1; i < e; i++)
|
|
Operands[i] = SE.getAddExpr(Operands[i], Operands[i + 1]);
|
|
} else {
|
|
assert(Kind == Normalize && "Only two possibilities!");
|
|
|
|
// Normalization / "partial decrement" is a bit more subtle. Since
|
|
// incrementing a SCEV expression (in general) changes the step of the SCEV
|
|
// expression as well, we cannot use the step of the current expression.
|
|
// Instead, we have to use the step of the very expression we're trying to
|
|
// compute!
|
|
//
|
|
// We solve the issue by recursively building up the result, starting from
|
|
// the "least significant" operand in the add recurrence:
|
|
//
|
|
// Base case:
|
|
// Single operand add recurrence. It's its own normalization.
|
|
//
|
|
// N-operand case:
|
|
// {S_{N-1},+,S_{N-2},+,...,+,S_0} = S
|
|
//
|
|
// Since the step recurrence of S is {S_{N-2},+,...,+,S_0}, we know its
|
|
// normalization by induction. We subtract the normalized step
|
|
// recurrence from S_{N-1} to get the normalization of S.
|
|
|
|
for (int i = Operands.size() - 2; i >= 0; i--)
|
|
Operands[i] = SE.getMinusSCEV(Operands[i], Operands[i + 1]);
|
|
}
|
|
|
|
return SE.getAddRecExpr(Operands, AR->getLoop(), SCEV::FlagAnyWrap);
|
|
}
|
|
|
|
const SCEV *llvm::normalizeForPostIncUse(const SCEV *S,
|
|
const PostIncLoopSet &Loops,
|
|
ScalarEvolution &SE) {
|
|
auto Pred = [&](const SCEVAddRecExpr *AR) {
|
|
return Loops.count(AR->getLoop());
|
|
};
|
|
return NormalizeDenormalizeRewriter(Normalize, Pred, SE).visit(S);
|
|
}
|
|
|
|
const SCEV *llvm::normalizeForPostIncUseIf(const SCEV *S, NormalizePredTy Pred,
|
|
ScalarEvolution &SE) {
|
|
return NormalizeDenormalizeRewriter(Normalize, Pred, SE).visit(S);
|
|
}
|
|
|
|
const SCEV *llvm::denormalizeForPostIncUse(const SCEV *S,
|
|
const PostIncLoopSet &Loops,
|
|
ScalarEvolution &SE) {
|
|
auto Pred = [&](const SCEVAddRecExpr *AR) {
|
|
return Loops.count(AR->getLoop());
|
|
};
|
|
return NormalizeDenormalizeRewriter(Denormalize, Pred, SE).visit(S);
|
|
}
|