mirror of
https://github.com/RPCSX/llvm.git
synced 2024-11-28 14:10:41 +00:00
016f651f8d
Fix for LLI failure on Windows\X86: http://llvm.org/PR5053 LLI.exe crashes on Windows\X86 when single precession floating point intrinsics like the following are used: acos, asin, atan, atan2, ceil, copysign, cos, cosh, exp, floor, fmin, fmax, fmod, log, pow, sin, sinh, sqrt, tan, tanh The above intrinsics are defined as inline-expansions in math.h, and are not exported by msvcr120.dll (Win32 API GetProcAddress returns null). For an FREM instruction, the JIT compiler generates a call to a stub for the fmodf() intrinsic, and adds a relocation to fixup at load time. The loader searches the libraries for the function, but fails because the symbol is not exported. So, the call target remains NULL and the execution crashes. Since the math functions are loaded at JIT/runtime, the JIT can patch CALL instruction directly instead of the searching the libraries' exported symbols. However, this fix caused build failures due to unresolved symbols like _fmodf at link time. Therefore, the current fix defines helper functions in the Runtime link/load library to perform the above operations. The address of these helper functions are used to patch up the CALL instruction at load time. Reviewers: lhames, rnk Reviewed By: rnk Differential Revision: http://reviews.llvm.org/D5387 Patch by Swaroop Sridhar! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@221947 91177308-0d34-0410-b5e6-96231b3b80d8
21 lines
619 B
LLVM
21 lines
619 B
LLVM
; LLI.exe used to crash on Windows\X86 when certain single precession
|
|
; floating point intrinsics (defined as macros) are used.
|
|
; This unit test guards against the failure.
|
|
;
|
|
; RUN: %lli %s | FileCheck %s
|
|
|
|
@flt = internal global float 12.0e+0
|
|
@str = internal constant [18 x i8] c"Double value: %f\0A\00"
|
|
|
|
declare i32 @printf(i8* nocapture, ...) nounwind
|
|
|
|
define i32 @main() {
|
|
%flt = load float* @flt
|
|
%float2 = frem float %flt, 5.0
|
|
%double1 = fpext float %float2 to double
|
|
call i32 (i8*, ...)* @printf(i8* getelementptr ([18 x i8]* @str, i32 0, i64 0), double %double1)
|
|
ret i32 0
|
|
}
|
|
|
|
; CHECK: Double value: 2.0
|