mirror of
https://github.com/RPCSX/llvm.git
synced 2024-12-13 14:46:53 +00:00
8cec2f2816
While we have successfully implemented a funclet-oriented EH scheme on top of LLVM IR, our scheme has some notable deficiencies: - catchendpad and cleanupendpad are necessary in the current design but they are difficult to explain to others, even to seasoned LLVM experts. - catchendpad and cleanupendpad are optimization barriers. They cannot be split and force all potentially throwing call-sites to be invokes. This has a noticable effect on the quality of our code generation. - catchpad, while similar in some aspects to invoke, is fairly awkward. It is unsplittable, starts a funclet, and has control flow to other funclets. - The nesting relationship between funclets is currently a property of control flow edges. Because of this, we are forced to carefully analyze the flow graph to see if there might potentially exist illegal nesting among funclets. While we have logic to clone funclets when they are illegally nested, it would be nicer if we had a representation which forbade them upfront. Let's clean this up a bit by doing the following: - Instead, make catchpad more like cleanuppad and landingpad: no control flow, just a bunch of simple operands; catchpad would be splittable. - Introduce catchswitch, a control flow instruction designed to model the constraints of funclet oriented EH. - Make funclet scoping explicit by having funclet instructions consume the token produced by the funclet which contains them. - Remove catchendpad and cleanupendpad. Their presence can be inferred implicitly using coloring information. N.B. The state numbering code for the CLR has been updated but the veracity of it's output cannot be spoken for. An expert should take a look to make sure the results are reasonable. Reviewers: rnk, JosephTremoulet, andrew.w.kaylor Differential Revision: http://reviews.llvm.org/D15139 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@255422 91177308-0d34-0410-b5e6-96231b3b80d8
63 lines
1.9 KiB
LLVM
63 lines
1.9 KiB
LLVM
; RUN: sed -e s/.Cxx:// %s | opt -mtriple=x86-pc-windows-msvc -S -x86-winehstate | FileCheck %s
|
|
; RUN: sed -e s/.SEH:// %s | opt -mtriple=x86-pc-windows-msvc -S -x86-winehstate | FileCheck %s
|
|
|
|
declare i32 @__CxxFrameHandler3(...)
|
|
declare i32 @_except_handler3(...)
|
|
declare void @dummy_filter()
|
|
|
|
declare void @f(i32)
|
|
|
|
; CHECK-LABEL: define void @test2(
|
|
;Cxx: define void @test2(i1 %b) personality i32 (...)* @__CxxFrameHandler3 {
|
|
;SEH: define void @test2(i1 %b) personality i32 (...)* @_except_handler3 {
|
|
entry:
|
|
; CHECK: entry:
|
|
; CHECK: store i32 1
|
|
; CHECK: invoke void @f(i32 1)
|
|
invoke void @f(i32 1)
|
|
to label %exit unwind label %cleanup.pad
|
|
cleanup.pad:
|
|
%cleanup = cleanuppad within none []
|
|
br i1 %b, label %left, label %right
|
|
left:
|
|
cleanupret from %cleanup unwind label %catch.pad
|
|
right:
|
|
cleanupret from %cleanup unwind label %catch.pad
|
|
catch.pad:
|
|
%cs1 = catchswitch within none [label %catch.body] unwind to caller
|
|
catch.body:
|
|
;Cxx: %catch = catchpad within %cs1 [i8* null, i32 u0x40, i8* null]
|
|
;SEH: %catch = catchpad within %cs1 [void ()* @dummy_filter]
|
|
catchret from %catch to label %exit
|
|
exit:
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: define void @test3(
|
|
;Cxx: define void @test3() personality i32 (...)* @__CxxFrameHandler3 {
|
|
;SEH: define void @test3() personality i32 (...)* @_except_handler3 {
|
|
entry:
|
|
; CHECK: entry:
|
|
; CHECK: store i32 0
|
|
; CHECK: invoke void @f(i32 1)
|
|
invoke void @f(i32 1)
|
|
to label %exit unwind label %cleanup.pad
|
|
cleanup.pad:
|
|
; CHECK: cleanup.pad:
|
|
; CHECK: store i32 1
|
|
; CHECK: invoke void @f(i32 0)
|
|
%cleanup = cleanuppad within none []
|
|
invoke void @f(i32 0)
|
|
to label %unreachable unwind label %catch.pad
|
|
unreachable:
|
|
unreachable
|
|
catch.pad:
|
|
%cs1 = catchswitch within none [label %catch.body] unwind to caller
|
|
catch.body:
|
|
;Cxx: %catch = catchpad within %cs1 [i8* null, i32 u0x40, i8* null]
|
|
;SEH: %catch = catchpad within %cs1 [void ()* @dummy_filter]
|
|
catchret from %catch to label %exit
|
|
exit:
|
|
ret void
|
|
}
|