mirror of
https://github.com/RPCSX/llvm.git
synced 2024-12-11 13:46:13 +00:00
d18725e897
This fixes PR32471. As comment 10 on that bug report highlights (https://bugs.llvm.org//show_bug.cgi?id=32471#c10), there are quite a few different defendable design tradeoffs that could be made, including not representing pointers at all in LLT. I decided to go for representing vector-of-pointer as a concept in LLT, while keeping the size of the LLT type 64 bits (this is an increase from 48 bits before). My rationale for keeping pointers explicit is that on some targets probably it's very handy to have the distinction between pointer and non-pointer (e.g. 68K has a different register bank for pointers IIRC). If we keep a scalar pointer, it probably is easiest to also have a vector-of-pointers to keep LLT relatively conceptually clean and orthogonal, while we don't have a very strong reason to break that orthogonality. Once we gain more experience on the use of LLT, we can of course reconsider this direction. Rejecting vector-of-pointer types in the IRTranslator is also an option to avoid the crash reported in PR32471, but that is only a very short-term solution; also needs quite a bit of code tweaks in places, and is probably fragile. Therefore I didn't consider this the best option. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@300535 91177308-0d34-0410-b5e6-96231b3b80d8
39 lines
1.4 KiB
C++
39 lines
1.4 KiB
C++
//===-- llvm/CodeGen/LowLevelType.cpp -------------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
/// \file This file implements the more header-heavy bits of the LLT class to
|
|
/// avoid polluting users' namespaces.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/CodeGen/LowLevelType.h"
|
|
#include "llvm/IR/DataLayout.h"
|
|
#include "llvm/IR/DerivedTypes.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
using namespace llvm;
|
|
|
|
LLT llvm::getLLTForType(Type &Ty, const DataLayout &DL) {
|
|
if (auto VTy = dyn_cast<VectorType>(&Ty)) {
|
|
auto NumElements = VTy->getNumElements();
|
|
LLT ScalarTy = getLLTForType(*VTy->getElementType(), DL);
|
|
if (NumElements == 1)
|
|
return ScalarTy;
|
|
return LLT::vector(NumElements, ScalarTy);
|
|
} else if (auto PTy = dyn_cast<PointerType>(&Ty)) {
|
|
return LLT::pointer(PTy->getAddressSpace(), DL.getTypeSizeInBits(&Ty));
|
|
} else if (Ty.isSized()) {
|
|
// Aggregates are no different from real scalars as far as GlobalISel is
|
|
// concerned.
|
|
auto SizeInBits = DL.getTypeSizeInBits(&Ty);
|
|
assert(SizeInBits != 0 && "invalid zero-sized type");
|
|
return LLT::scalar(SizeInBits);
|
|
}
|
|
return LLT();
|
|
}
|