mirror of
https://github.com/RPCSX/llvm.git
synced 2024-11-23 19:59:57 +00:00
ed5107d663
On SparcV8, it was previously the case that a variable-sized alloca might overlap by 4-bytes the last fixed stack variable, effectively because 92 (the number of bytes reserved for the register spill area) != 96 (the offset added to SP for where to start a DYNAMIC_STACKALLOC). It's not as simple as changing 96 to 92, because variables that should be 8-byte aligned would then be misaligned. For now, simply increase the allocation size by 8 bytes for each dynamic allocation -- wastes space, but at least doesn't overlap. As the large comment says, doing this more efficiently will require larger changes in llvm. Also adds some test cases showing that we continue to not support dynamic stack allocation and over-alignment in the same function. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@285131 91177308-0d34-0410-b5e6-96231b3b80d8
24 lines
775 B
LLVM
24 lines
775 B
LLVM
;; Sparc backend can't currently handle variable allocas with
|
|
;; alignment greater than the stack alignment. This code ought to
|
|
;; compile, but doesn't currently.
|
|
|
|
;; RUN: not llc -march=sparc < %s 2>&1 | FileCheck %s
|
|
;; RUN: not llc -march=sparcv9 < %s 2>&1 | FileCheck %s
|
|
;; CHECK: ERROR: Function {{.*}} required stack re-alignment
|
|
|
|
define void @variable_alloca_with_overalignment(i32 %num) {
|
|
%aligned = alloca i32, align 64
|
|
%var_size = alloca i8, i32 %num, align 4
|
|
call void @foo(i32* %aligned, i8* %var_size)
|
|
ret void
|
|
}
|
|
|
|
;; Same but with the alloca itself overaligned
|
|
define void @variable_alloca_with_overalignment_2(i32 %num) {
|
|
%var_size = alloca i8, i32 %num, align 64
|
|
call void @foo(i32* null, i8* %var_size)
|
|
ret void
|
|
}
|
|
|
|
declare void @foo(i32*, i8*);
|