llvm/lib/Target/WebAssembly
Serge Pavlov 1f4a80fdc1 Add extra operand to CALLSEQ_START to keep frame part set up previously
Using arguments with attribute inalloca creates problems for verification
of machine representation. This attribute instructs the backend that the
argument is prepared in stack prior to  CALLSEQ_START..CALLSEQ_END
sequence (see http://llvm.org/docs/InAlloca.htm for details). Frame size
stored in CALLSEQ_START in this case does not count the size of this
argument. However CALLSEQ_END still keeps total frame size, as caller can
be responsible for cleanup of entire frame. So CALLSEQ_START and
CALLSEQ_END keep different frame size and the difference is treated by
MachineVerifier as stack error. Currently there is no way to distinguish
this case from actual errors.

This patch adds additional argument to CALLSEQ_START and its
target-specific counterparts to keep size of stack that is set up prior to
the call frame sequence. This argument allows MachineVerifier to calculate
actual frame size associated with frame setup instruction and correctly
process the case of inalloca arguments.

The changes made by the patch are:
- Frame setup instructions get the second mandatory argument. It
  affects all targets that use frame pseudo instructions and touched many
  files although the changes are uniform.
- Access to frame properties are implemented using special instructions
  rather than calls getOperand(N).getImm(). For X86 and ARM such
  replacement was made previously.
- Changes that reflect appearance of additional argument of frame setup
  instruction. These involve proper instruction initialization and
  methods that access instruction arguments.
- MachineVerifier retrieves frame size using method, which reports sum of
  frame parts initialized inside frame instruction pair and outside it.

The patch implements approach proposed by Quentin Colombet in
https://bugs.llvm.org/show_bug.cgi?id=27481#c1.
It fixes 9 tests failed with machine verifier enabled and listed
in PR27481.

Differential Revision: https://reviews.llvm.org/D32394


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@302527 91177308-0d34-0410-b5e6-96231b3b80d8
2017-05-09 13:35:13 +00:00
..
Disassembler [WebAssembly] Remove old experimental disassemler code. 2017-02-11 00:02:23 +00:00
InstPrinter [WebAssembly] Fix -Wcovered-switch-default warning 2017-04-06 23:52:01 +00:00
MCTargetDesc [WebAssembly] Encode block signatures as SLEB instead of ULEB 2017-04-17 20:28:28 +00:00
TargetInfo Fix WebAssembly build after r283702. 2016-10-10 06:49:55 +00:00
CMakeLists.txt [WebAssembly] Split CFG-sorting into its own pass. NFC. 2017-02-27 22:38:58 +00:00
known_gcc_test_failures.txt [WebAssembly] Add known failures for wasm object file backend 2017-04-20 17:18:15 +00:00
LLVMBuild.txt Add asm.js-style setjmp/longjmp handling for wasm 2016-08-31 22:40:34 +00:00
README.txt [WebAssembly] Convert the remaining unit tests to the new wasm-object-file target. 2017-02-28 23:37:04 +00:00
WebAssembly.h [WebAssembly] Split CFG-sorting into its own pass. NFC. 2017-02-27 22:38:58 +00:00
WebAssembly.td [WebAssembly] Initial SIMD128 support. 2016-08-02 23:16:09 +00:00
WebAssemblyArgumentMove.cpp [WebAssembly] Add an option to make get_local/set_local explicit. 2016-10-24 19:49:43 +00:00
WebAssemblyAsmPrinter.cpp Move value type list from TargetRegisterClass to TargetRegisterInfo 2017-04-24 19:51:12 +00:00
WebAssemblyAsmPrinter.h [WebAssembly] Basic support for Wasm object file encoding. 2017-02-24 23:18:00 +00:00
WebAssemblyCallIndirectFixup.cpp [WebAssembly] Basic support for Wasm object file encoding. 2017-02-24 23:18:00 +00:00
WebAssemblyCFGSort.cpp [WebAssembly] Split CFG-sorting into its own pass. NFC. 2017-02-27 22:38:58 +00:00
WebAssemblyCFGStackify.cpp [WebAssembly] Split CFG-sorting into its own pass. NFC. 2017-02-27 22:38:58 +00:00
WebAssemblyExplicitLocals.cpp [WebAssembly] Convert the remaining unit tests to the new wasm-object-file target. 2017-02-28 23:37:04 +00:00
WebAssemblyFastISel.cpp [IR] Make getParamAttributes take argument numbers, not ArgNo+1 2017-04-13 23:12:13 +00:00
WebAssemblyFixFunctionBitcasts.cpp [WebAssembly] Add some comments and tidy up whitespace. 2017-02-27 22:41:39 +00:00
WebAssemblyFixIrreducibleControlFlow.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyFrameLowering.cpp [WebAssembly] Initial linking metadata support 2017-03-30 23:58:19 +00:00
WebAssemblyFrameLowering.h [WebAssembly] Emit a BasePointer when we have overly-aligned stack objects 2016-11-07 22:00:48 +00:00
WebAssemblyInstrAtomics.td
WebAssemblyInstrCall.td Add extra operand to CALLSEQ_START to keep frame part set up previously 2017-05-09 13:35:13 +00:00
WebAssemblyInstrControl.td [WebAssembly] Basic support for Wasm object file encoding. 2017-02-24 23:18:00 +00:00
WebAssemblyInstrConv.td [WebAssembly] Update opcode values according to recent spec changes. 2016-10-24 20:21:49 +00:00
WebAssemblyInstrFloat.td [WebAssembly] Fix the opcode numbers for floating-point le and gt. 2017-03-09 23:08:21 +00:00
WebAssemblyInstrFormats.td [WebAssembly] Add binary-encoding opcode values to instruction descriptions. 2016-10-05 21:24:08 +00:00
WebAssemblyInstrInfo.cpp [CodeGen] Rename MachineInstrBuilder::addOperand. NFC 2017-01-13 09:58:52 +00:00
WebAssemblyInstrInfo.h Finish renaming remaining analyzeBranch functions 2016-09-14 20:43:16 +00:00
WebAssemblyInstrInfo.td Add extra operand to CALLSEQ_START to keep frame part set up previously 2017-05-09 13:35:13 +00:00
WebAssemblyInstrInteger.td [WebAssembly] Fix the opcode values for i64.eq and i64.ne. 2017-01-09 06:21:28 +00:00
WebAssemblyInstrMemory.td [WebAssembly] Fix use of SDNodeFlags after API change in r301803 2017-05-01 16:49:39 +00:00
WebAssemblyInstrSIMD.td [WebAssembly] Initial SIMD128 support. 2016-08-02 23:16:09 +00:00
WebAssemblyISD.def
WebAssemblyISelDAGToDAG.cpp [WebAssembly] Update calls to computeKnownBits after the changes from r301620. 2017-04-28 08:15:33 +00:00
WebAssemblyISelLowering.cpp Rename AttributeSet to AttributeList 2017-03-21 16:57:19 +00:00
WebAssemblyISelLowering.h Rename AttributeSet to AttributeList 2017-03-21 16:57:19 +00:00
WebAssemblyLowerBrUnless.cpp [CodeGen] Rename MachineInstrBuilder::addOperand. NFC 2017-01-13 09:58:52 +00:00
WebAssemblyLowerEmscriptenEHSjLj.cpp [IR] Make getParamAttributes take argument numbers, not ArgNo+1 2017-04-13 23:12:13 +00:00
WebAssemblyMachineFunctionInfo.cpp [WebAssemby] Implement block signatures. 2016-10-06 22:29:32 +00:00
WebAssemblyMachineFunctionInfo.h [WebAssembly] Basic support for Wasm object file encoding. 2017-02-24 23:18:00 +00:00
WebAssemblyMCInstLower.cpp [WebAssembly] Use LEB encoding for value types 2017-03-14 20:23:22 +00:00
WebAssemblyMCInstLower.h [WebAssembly] Basic support for Wasm object file encoding. 2017-02-24 23:18:00 +00:00
WebAssemblyOptimizeLiveIntervals.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyOptimizeReturned.cpp [WebAssembly] Fix WebAssemblyOptimizeReturned after r300367 2017-04-17 21:40:28 +00:00
WebAssemblyPeephole.cpp [WebAssembly] Basic support for Wasm object file encoding. 2017-02-24 23:18:00 +00:00
WebAssemblyPrepareForLiveIntervals.cpp [WebAssembly] Add an option to make get_local/set_local explicit. 2016-10-24 19:49:43 +00:00
WebAssemblyRegColoring.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyRegisterInfo.cpp [WebAssembly] Remove the output operand from stores. 2016-10-06 22:08:28 +00:00
WebAssemblyRegisterInfo.h
WebAssemblyRegisterInfo.td [WebAssembly] Update to more stack-machine-oriented terminology. 2016-10-03 22:43:53 +00:00
WebAssemblyRegNumbering.cpp [WebAssembly] Add an option to make get_local/set_local explicit. 2016-10-24 19:49:43 +00:00
WebAssemblyRegStackify.cpp [WebAssembly] Add support for using a wasm global for the stack pointer. 2017-02-24 23:46:05 +00:00
WebAssemblyReplacePhysRegs.cpp [WebAssembly] Update to more stack-machine-oriented terminology. 2016-10-03 22:43:53 +00:00
WebAssemblyRuntimeLibcallSignatures.cpp [WebAssembly] Use LEB encoding for value types 2017-03-14 20:23:22 +00:00
WebAssemblyRuntimeLibcallSignatures.h [WebAssembly] Use LEB encoding for value types 2017-03-14 20:23:22 +00:00
WebAssemblySelectionDAGInfo.cpp
WebAssemblySelectionDAGInfo.h
WebAssemblySetP2AlignOperands.cpp [WebAssembly] Remove the output operand from stores. 2016-10-06 22:08:28 +00:00
WebAssemblyStoreResults.cpp [WebAssembly] Update LibFunc::Func -> LibFunc 2017-01-24 00:01:18 +00:00
WebAssemblySubtarget.cpp
WebAssemblySubtarget.h
WebAssemblyTargetMachine.cpp [WebAssembly] Split CFG-sorting into its own pass. NFC. 2017-02-27 22:38:58 +00:00
WebAssemblyTargetMachine.h
WebAssemblyTargetObjectFile.cpp [WebAssembly] Add skeleton MC support for the Wasm container format 2017-02-22 01:23:18 +00:00
WebAssemblyTargetObjectFile.h [WebAssembly] Add skeleton MC support for the Wasm container format 2017-02-22 01:23:18 +00:00
WebAssemblyTargetTransformInfo.cpp [X86] updating TTI costs for arithmetic instructions on X86\SLM arch. 2017-01-11 08:23:37 +00:00
WebAssemblyTargetTransformInfo.h [X86] updating TTI costs for arithmetic instructions on X86\SLM arch. 2017-01-11 08:23:37 +00:00
WebAssemblyUtilities.cpp [WebAssembly] Split CFG-sorting into its own pass. NFC. 2017-02-27 22:38:58 +00:00
WebAssemblyUtilities.h [WebAssembly] Split CFG-sorting into its own pass. NFC. 2017-02-27 22:38:58 +00:00

//===-- README.txt - Notes for WebAssembly code gen -----------------------===//

This WebAssembly backend is presently under development.

Currently the easiest way to use it is through Emscripten, which provides a
compilation environment that includes standard libraries, tools, and packaging
for producing WebAssembly applications that can run in browsers and other
environments. For more information, see the Emscripten documentation in
general, and this page in particular:
  * https://github.com/kripken/emscripten/wiki/New-WebAssembly-Backend

Other ways of using this backend, such as via a standalone "clang", are also
under development, though they are not generally usable yet.

For more information on WebAssembly itself, see the home page:
  * https://webassembly.github.io/

The following documents contain some information on the semantics and binary
encoding of WebAssembly itself:
  * https://github.com/WebAssembly/design/blob/master/Semantics.md
  * https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md

The backend is built, tested and archived on the following waterfall:
  https://wasm-stat.us

The backend's bringup is done in part by using the GCC torture test suite, since
it doesn't require C library support. Current known failures are in
known_gcc_test_failures.txt, all other tests should pass. The waterfall will
turn red if not. Once most of these pass, further testing will use LLVM's own
test suite. The tests can be run locally using:
  https://github.com/WebAssembly/waterfall/blob/master/src/compile_torture_tests.py

//===---------------------------------------------------------------------===//

Br, br_if, and br_table instructions can support having a value on the value
stack across the jump (sometimes). We should (a) model this, and (b) extend
the stackifier to utilize it.

//===---------------------------------------------------------------------===//

The min/max instructions aren't exactly a<b?a:b because of NaN and negative zero
behavior. The ARM target has the same kind of min/max instructions and has
implemented optimizations for them; we should do similar optimizations for
WebAssembly.

//===---------------------------------------------------------------------===//

AArch64 runs SeparateConstOffsetFromGEPPass, followed by EarlyCSE and LICM.
Would these be useful to run for WebAssembly too? Also, it has an option to
run SimplifyCFG after running the AtomicExpand pass. Would this be useful for
us too?

//===---------------------------------------------------------------------===//

Register stackification uses the VALUE_STACK physical register to impose
ordering dependencies on instructions with stack operands. This is pessimistic;
we should consider alternate ways to model stack dependencies.

//===---------------------------------------------------------------------===//

Lots of things could be done in WebAssemblyTargetTransformInfo.cpp. Similarly,
there are numerous optimization-related hooks that can be overridden in
WebAssemblyTargetLowering.

//===---------------------------------------------------------------------===//

Instead of the OptimizeReturned pass, which should consider preserving the
"returned" attribute through to MachineInstrs and extending the StoreResults
pass to do this optimization on calls too. That would also let the
WebAssemblyPeephole pass clean up dead defs for such calls, as it does for
stores.

//===---------------------------------------------------------------------===//

Consider implementing optimizeSelect, optimizeCompareInstr, optimizeCondBranch,
optimizeLoadInstr, and/or getMachineCombinerPatterns.

//===---------------------------------------------------------------------===//

Find a clean way to fix the problem which leads to the Shrink Wrapping pass
being run after the WebAssembly PEI pass.

//===---------------------------------------------------------------------===//

When setting multiple local variables to the same constant, we currently get
code like this:

    i32.const   $4=, 0
    i32.const   $3=, 0

It could be done with a smaller encoding like this:

    i32.const   $push5=, 0
    tee_local   $push6=, $4=, $pop5
    copy_local  $3=, $pop6

//===---------------------------------------------------------------------===//

WebAssembly registers are implicitly initialized to zero. Explicit zeroing is
therefore often redundant and could be optimized away.

//===---------------------------------------------------------------------===//

Small indices may use smaller encodings than large indices.
WebAssemblyRegColoring and/or WebAssemblyRegRenumbering should sort registers
according to their usage frequency to maximize the usage of smaller encodings.

//===---------------------------------------------------------------------===//

Many cases of irreducible control flow could be transformed more optimally
than via the transform in WebAssemblyFixIrreducibleControlFlow.cpp.

It may also be worthwhile to do transforms before register coloring,
particularly when duplicating code, to allow register coloring to be aware of
the duplication.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify could use AliasAnalysis to reorder loads and stores more
aggressively.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify is currently a greedy algorithm. This means that, for
example, a binary operator will stackify with its user before its operands.
However, if moving the binary operator to its user moves it to a place where
its operands can't be moved to, it would be better to leave it in place, or
perhaps move it up, so that it can stackify its operands. A binary operator
has two operands and one result, so in such cases there could be a net win by
prefering the operands.

//===---------------------------------------------------------------------===//

Instruction ordering has a significant influence on register stackification and
coloring. Consider experimenting with the MachineScheduler (enable via
enableMachineScheduler) and determine if it can be configured to schedule
instructions advantageously for this purpose.

//===---------------------------------------------------------------------===//

WebAssembly is now officially a stack machine, rather than an AST, and this
comes with additional opportunities for WebAssemblyRegStackify. Specifically,
the stack doesn't need to be empty after an instruction with no return values.
WebAssemblyRegStackify could be extended, or possibly rewritten, to take
advantage of the new opportunities.

//===---------------------------------------------------------------------===//

Add support for mergeable sections in the Wasm writer, such as for strings and
floating-point constants.

//===---------------------------------------------------------------------===//

The function @dynamic_alloca_redzone in test/CodeGen/WebAssembly/userstack.ll
ends up with a tee_local in its prolog which has an unused result, requiring
an extra drop:

    get_global  $push8=, 0
    tee_local   $push9=, 1, $pop8
    drop        $pop9
    [...]

The prologue code initially thinks it needs an FP register, but later it
turns out to be unneeded, so one could either approach this by being more
clever about not inserting code for an FP in the first place, or optimizing
away the copy later.

//===---------------------------------------------------------------------===//