Chandler Carruth cf88e9244e [AA] Hoist the logic to reformulate various AA queries in terms of other ... parts of the AA interface out of the base class of every single AA result object. Because this logic reformulates the query in terms of some other aspect of the API, it would easily cause O(n^2) query patterns in alias analysis. These could in turn be magnified further based on the number of call arguments, and then further based on the number of AA queries made for a particular call. This ended up causing problems for Rust that were actually noticable enough to get a bug (PR26564) and probably other places as well. When originally re-working the AA infrastructure, the desire was to regularize the pattern of refinement without losing any generality. While I think it was successful, that is clearly proving to be too costly. And the cost is needless: we gain no actual improvement for this generality of making a direct query to tbaa actually be able to re-use some other alias analysis's refinement logic for one of the other APIs, or some such. In short, this is entirely wasted work. To the extent possible, delegation to other API surfaces should be done at the aggregation layer so that we can avoid re-walking the aggregation. In fact, this significantly simplifies the logic as we no longer need to smuggle the aggregation layer into each alias analysis (or the TargetLibraryInfo into each alias analysis just so we can form argument memory locations!). However, we also have some delegation logic inside of BasicAA and some of it even makes sense. When the delegation logic is baking in specific knowledge of aliasing properties of the LLVM IR, as opposed to simply reformulating the query to utilize a different alias analysis interface entry point, it makes a lot of sense to restrict that logic to a different layer such as BasicAA. So one aspect of the delegation that was in every AA base class is that when we don't have operand bundles, we re-use function AA results as a fallback for callsite alias results. This relies on the IR properties of calls and functions w.r.t. aliasing, and so seems a better fit to BasicAA. I've lifted the logic up to that point where it seems to be a natural fit. This still does a bit of redundant work (we query function attributes twice, once via the callsite and once via the function AA query) but it is *exactly* twice here, no more. The end result is that all of the delegation logic is hoisted out of the base class and into either the aggregation layer when it is a pure retargeting to a different API surface, or into BasicAA when it relies on the IR's aliasing properties. This should fix the quadratic query pattern reported in PR26564, although I don't have a stand-alone test case to reproduce it. It also seems general goodness. Now the numerous AAs that don't need target library info don't carry it around and depend on it. I think I can even rip out the general access to the aggregation layer and only expose that in BasicAA as it is the only place where we re-query in that manner. However, this is a non-trivial change to the AA infrastructure so I want to get some additional eyes on this before it lands. Sadly, it can't wait long because we should really cherry pick this into 3.8 if we're going to go this route. Differential Revision: http://reviews.llvm.org/D17329 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@262490 91177308-0d34-0410-b5e6-96231b3b80d8		2016-03-02 15:56:53 +00:00
..
AliasAnalysisTest.cpp	[AA] Hoist the logic to reformulate various AA queries in terms of other	2016-03-02 15:56:53 +00:00
CallGraphTest.cpp	CallGraphTest.cpp: Remove invalid tests. ++S might step over F if S == F.	2014-11-18 12:23:19 +00:00
CFGTest.cpp	unittests: Remove implicit ilist iterator conversions, NFC	2015-10-20 18:30:20 +00:00
CGSCCPassManagerTest.cpp	[PM] Remove an overly aggressive assert now that I can actually test the	2016-02-23 10:47:57 +00:00
CMakeLists.txt	PM: Implement a basic loop pass manager	2016-02-25 07:23:08 +00:00
LazyCallGraphTest.cpp	[LCG] Construct an actual call graph with call-edge SCCs nested inside	2016-02-17 00:18:16 +00:00
LoopPassManagerTest.cpp	PM: Implement a basic loop pass manager	2016-02-25 07:23:08 +00:00
MixedTBAATest.cpp	[PM/AA] Port alias analysis evaluator to the new pass manager, and use	2016-02-20 03:46:03 +00:00
ScalarEvolutionTest.cpp	Use EXPECT_EQ in the unittests instead of plain assert	2016-02-22 07:20:40 +00:00
UnrollAnalyzer.cpp	[LoopUnrollAnalyzer] Check that we're using SCEV for the same loop we're simulating.	2016-02-26 02:57:05 +00:00
ValueTrackingTest.cpp	[ValueTracking] Minor comment change in test	2015-09-02 17:29:54 +00:00