llvm/lib/Support
Justin Lebar 3026bc6138 Fix a race condition in support library ThreadPool.
By running TSAN on the ThreadPool unit tests it was discovered that the
threads in the pool can pop tasks off the queue at the same time the
"wait" routine is trying to check if the task queue is empty. This patch
fixes this problem by checking for active threads in the waiter before
checking whether the queue is empty.

Patch by Jason Henline.

Differential Revision: http://reviews.llvm.org/D18811

Reviewers: joker.eph, jlebar

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@265618 91177308-0d34-0410-b5e6-96231b3b80d8
2016-04-06 23:46:40 +00:00
..
Unix Revert "Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes." 2016-04-05 20:45:04 +00:00
Windows Fix Windows build (typo in disk_space() implementation) 2016-04-01 00:52:05 +00:00
Allocator.cpp
APFloat.cpp Revert "Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes." 2016-04-05 20:45:04 +00:00
APInt.cpp Implement constant folding for bitreverse 2016-03-21 15:00:35 +00:00
APSInt.cpp
ARMBuildAttrs.cpp [ARM] Add DSP build attribute and extension targeting 2016-01-25 11:26:11 +00:00
ARMWinEH.cpp
Atomic.cpp
BlockFrequency.cpp
BranchProbability.cpp Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192 post commit comment. 2016-01-29 20:50:44 +00:00
CachePruning.cpp Add Cache Pruning support 2016-04-02 03:28:26 +00:00
circular_raw_ostream.cpp
CMakeLists.txt Add Cache Pruning support 2016-04-02 03:28:26 +00:00
COM.cpp
CommandLine.cpp [CMake] Add PACKAGE_VENDOR for customizing version output 2016-03-15 18:07:46 +00:00
Compression.cpp
ConvertUTF.c
ConvertUTFWrapper.cpp More UTF string conversion wrappers 2016-03-11 15:59:32 +00:00
COPYRIGHT.regex
CrashRecoveryContext.cpp Revert "Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes." 2016-04-05 20:45:04 +00:00
DAGDeltaAlgorithm.cpp
DataExtractor.cpp
DataStream.cpp
Debug.cpp The --debug-only option now takes a comma separated list of debug types. 2016-01-12 10:23:13 +00:00
DeltaAlgorithm.cpp
Dwarf.cpp
DynamicLibrary.cpp
Errno.cpp Revert "Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes." 2016-04-05 20:45:04 +00:00
Error.cpp Try to fix ODR violation of ErrorInfo::ID 2016-03-24 23:49:34 +00:00
ErrorHandling.cpp [Support] Make all Errors convertible to std::error_code. 2016-03-23 23:57:28 +00:00
FileOutputBuffer.cpp
FileUtilities.cpp Remove uses of builtin comma operator. 2016-02-18 22:09:30 +00:00
FoldingSet.cpp
FormattedStream.cpp
GraphWriter.cpp
Hashing.cpp
Host.cpp Revert "Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes." 2016-04-05 20:45:04 +00:00
IntEqClasses.cpp Remove uses of builtin comma operator. 2016-02-18 22:09:30 +00:00
IntervalMap.cpp
IntrusiveRefCntPtr.cpp
JamCRC.cpp
LEB128.cpp
LineIterator.cpp
LLVMBuild.txt
Locale.cpp
LockFileManager.cpp
ManagedStatic.cpp
MathExtras.cpp Revert "Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes." 2016-04-05 20:45:04 +00:00
MD5.cpp
Memory.cpp
MemoryBuffer.cpp Fix undefined behavior when compiling in C++14 mode (with sized deletion 2016-02-04 01:21:16 +00:00
MemoryObject.cpp
Mutex.cpp Revert "Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes." 2016-04-05 20:45:04 +00:00
Options.cpp
Path.cpp Fix identify_magic() to check that a file that starts with MH_MAGIC is 2016-01-26 23:43:37 +00:00
PluginLoader.cpp
PrettyStackTrace.cpp Reorganize the C API headers to improve build times. 2015-12-18 01:46:52 +00:00
Process.cpp
Program.cpp
RandomNumberGenerator.cpp
raw_os_ostream.cpp
raw_ostream.cpp C++11 is required, remove some preprocessor checks for it 2016-03-28 11:13:03 +00:00
README.txt.system
regcclass.h
regcname.h
regcomp.c
regengine.inc
regerror.c
regex2.h
regex_impl.h
Regex.cpp
regexec.c
regfree.c
regstrlcpy.c
regutils.h
RWMutex.cpp Revert "Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes." 2016-04-05 20:45:04 +00:00
ScaledNumber.cpp
SearchForAddressOfSpecialSymbol.cpp Revert "Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes." 2016-04-05 20:45:04 +00:00
SHA1.cpp Revert "Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes." 2016-04-05 20:45:04 +00:00
Signals.cpp
SmallPtrSet.cpp SmallPtrSet: Avoid initializing Array in the small case. 2016-02-15 21:38:42 +00:00
SmallVector.cpp
SourceMgr.cpp
SpecialCaseList.cpp
Statistic.cpp
StreamingMemoryObject.cpp Support: Implement StreamingMemoryObject::getPointer 2016-03-27 23:00:59 +00:00
StringExtras.cpp
StringMap.cpp Adjust initial size in StringMap constructor to guarantee no grow() 2016-03-25 05:57:57 +00:00
StringPool.cpp
StringRef.cpp [MCParser] Accept uppercase radix variants 0X and 0B 2016-03-18 18:22:07 +00:00
StringSaver.cpp
SystemUtils.cpp
TargetParser.cpp Support: catch invalid accesses 2016-03-05 20:00:44 +00:00
TargetRegistry.cpp Don't mention a command line option in an error. 2016-01-28 22:55:45 +00:00
Threading.cpp
ThreadLocal.cpp
ThreadPool.cpp Fix a race condition in support library ThreadPool. 2016-04-06 23:46:40 +00:00
Timer.cpp [Support] Allow multiple paired calls to {start,stop}Timer() 2015-12-22 17:36:17 +00:00
TimeValue.cpp
ToolOutputFile.cpp
Triple.cpp Add AMDGPU related triple vendors/OSes 2016-02-13 01:56:21 +00:00
Twine.cpp Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192 post commit comment. 2016-01-29 20:50:44 +00:00
Unicode.cpp
Valgrind.cpp
Watchdog.cpp
YAMLParser.cpp Simplify users of StringRef::{l,r}trim (NFC) 2016-02-16 02:06:01 +00:00
YAMLTraits.cpp

Design Of lib/System
====================

The software in this directory is designed to completely shield LLVM from any
and all operating system specific functionality. It is not intended to be a
complete operating system wrapper (such as ACE), but only to provide the
functionality necessary to support LLVM.

The software located here, of necessity, has very specific and stringent design
rules. Violation of these rules means that cracks in the shield could form and
the primary goal of the library is defeated. By consistently using this library,
LLVM becomes more easily ported to new platforms since the only thing requiring
porting is this library.

Complete documentation for the library can be found in the file:
  llvm/docs/SystemLibrary.html
or at this URL:
  http://llvm.org/docs/SystemLibrary.html

While we recommend that you read the more detailed documentation, for the
impatient, here's a high level summary of the library's requirements.

 1. No system header files are to be exposed through the interface.
 2. Std C++ and Std C header files are okay to be exposed through the interface.
 3. No exposed system-specific functions.
 4. No exposed system-specific data.
 5. Data in lib/System classes must use only simple C++ intrinsic types.
 6. Errors are handled by returning "true" and setting an optional std::string
 7. Library must not throw any exceptions, period.
 8. Interface functions must not have throw() specifications.
 9. No duplicate function impementations are permitted within an operating
    system class.

To accomplish these requirements, the library has numerous design criteria that
must be satisfied. Here's a high level summary of the library's design criteria:

 1. No unused functionality (only what LLVM needs)
 2. High-Level Interfaces
 3. Use Opaque Classes
 4. Common Implementations
 5. Multiple Implementations
 6. Minimize Memory Allocation
 7. No Virtual Methods