mirror of
https://github.com/RPCSX/llvm.git
synced 2024-12-15 07:59:50 +00:00
52f83a9ab3
The main issue being fixed here is that APCS targets handling a "byval align N" parameter with N > 4 were miscounting what objects were where on the stack, leading to FrameLowering setting the frame pointer incorrectly and clobbering the stack. But byval handling had grown over many years, and had multiple layers of cruft trying to compensate for each other and calculate padding correctly. This only really needs to be done once, in the HandleByVal function. Elsewhere should just do what it's told by that call. I also stripped out unnecessary APCS/AAPCS distinctions (now that Clang emits byvals with the correct C ABI alignment), which simplified HandleByVal. rdar://20095672 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@231959 91177308-0d34-0410-b5e6-96231b3b80d8
32 lines
1.1 KiB
LLVM
32 lines
1.1 KiB
LLVM
; RUN: llc < %s -mtriple=arm-nacl-gnueabi | FileCheck %s
|
|
|
|
declare void @llvm.va_start(i8*)
|
|
declare void @external_func(i8*)
|
|
|
|
@va_list = external global i8*
|
|
|
|
; On ARM, varargs arguments are passed in r0-r3 with the rest on the
|
|
; stack. A varargs function must therefore spill rN-r3 just below the
|
|
; function's initial stack pointer.
|
|
;
|
|
; This test checks for a bug in which a gap was left between the spill
|
|
; area and varargs arguments on the stack when using 16 byte stack
|
|
; alignment.
|
|
|
|
define void @varargs_func(i32 %arg1, ...) {
|
|
call void @llvm.va_start(i8* bitcast (i8** @va_list to i8*))
|
|
call void @external_func(i8* bitcast (i8** @va_list to i8*))
|
|
ret void
|
|
}
|
|
; CHECK-LABEL: varargs_func:
|
|
; Reserve space for the varargs save area. This currently reserves
|
|
; more than enough (16 bytes rather than the 12 bytes needed).
|
|
; CHECK: sub sp, sp, #12
|
|
; CHECK: push {r11, lr}
|
|
; Align the stack pointer to a multiple of 16.
|
|
; CHECK: sub sp, sp, #12
|
|
; Calculate the address of the varargs save area and save varargs
|
|
; arguments into it.
|
|
; CHECK-NEXT: add r0, sp, #20
|
|
; CHECK-NEXT: stm r0, {r1, r2, r3}
|