From 1fddd44a4bf5a77836be27f61c3d1d86f59ef54f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B6nke=20Holz?= Date: Fri, 10 Jul 2026 21:53:45 +0200 Subject: [PATCH] Kernel/x86: Remove unused IRQController::get_irr() function This unused function is only implemented by the PIC. --- Kernel/Arch/x86_64/IRQController.h | 1 - Kernel/Arch/x86_64/Interrupts/IOAPIC.cpp | 6 ------ Kernel/Arch/x86_64/Interrupts/IOAPIC.h | 1 - Kernel/Arch/x86_64/Interrupts/PIC.cpp | 8 -------- Kernel/Arch/x86_64/Interrupts/PIC.h | 1 - 5 files changed, 17 deletions(-) diff --git a/Kernel/Arch/x86_64/IRQController.h b/Kernel/Arch/x86_64/IRQController.h index 311720f6b6a..79f19dec31a 100644 --- a/Kernel/Arch/x86_64/IRQController.h +++ b/Kernel/Arch/x86_64/IRQController.h @@ -34,7 +34,6 @@ public: virtual void spurious_eoi(GenericInterruptHandler const&) const = 0; virtual size_t interrupt_vectors_count() const = 0; virtual u32 gsi_base() const = 0; - virtual u16 get_irr() const = 0; virtual StringView model() const = 0; virtual IRQControllerType type() const = 0; diff --git a/Kernel/Arch/x86_64/Interrupts/IOAPIC.cpp b/Kernel/Arch/x86_64/Interrupts/IOAPIC.cpp index 4f453c65791..cb1bc2c7e70 100644 --- a/Kernel/Arch/x86_64/Interrupts/IOAPIC.cpp +++ b/Kernel/Arch/x86_64/Interrupts/IOAPIC.cpp @@ -236,12 +236,6 @@ void IOAPIC::eoi(GenericInterruptHandler const& handler) const APIC::the().eoi(); } -u16 IOAPIC::get_irr() const -{ - InterruptDisabler disabler; - VERIFY_NOT_REACHED(); -} - void IOAPIC::write_register(u32 index, u32 value) const { InterruptDisabler disabler; diff --git a/Kernel/Arch/x86_64/Interrupts/IOAPIC.h b/Kernel/Arch/x86_64/Interrupts/IOAPIC.h index d823435dbd4..72e41adef1f 100644 --- a/Kernel/Arch/x86_64/Interrupts/IOAPIC.h +++ b/Kernel/Arch/x86_64/Interrupts/IOAPIC.h @@ -47,7 +47,6 @@ public: virtual void spurious_eoi(GenericInterruptHandler const&) const override; virtual bool is_vector_enabled(InterruptNumber number) const override; virtual bool is_enabled() const override; - virtual u16 get_irr() const override; virtual u32 gsi_base() const override { return m_gsi_base; } virtual size_t interrupt_vectors_count() const override { return m_redirection_entries_count; } virtual StringView model() const override { return "IOAPIC"sv; } diff --git a/Kernel/Arch/x86_64/Interrupts/PIC.cpp b/Kernel/Arch/x86_64/Interrupts/PIC.cpp index 0df005a56c5..05b1489e1ce 100644 --- a/Kernel/Arch/x86_64/Interrupts/PIC.cpp +++ b/Kernel/Arch/x86_64/Interrupts/PIC.cpp @@ -219,12 +219,4 @@ u16 PIC::get_isr() const return (isr1 << 8) | isr0; } -u16 PIC::get_irr() const -{ - IO::out8(PIC0_CTL, 0x0a); - IO::out8(PIC1_CTL, 0x0a); - u8 irr0 = IO::in8(PIC0_CTL); - u8 irr1 = IO::in8(PIC1_CTL); - return (irr1 << 8) | irr0; -} } diff --git a/Kernel/Arch/x86_64/Interrupts/PIC.h b/Kernel/Arch/x86_64/Interrupts/PIC.h index c1657643ad3..2805868801e 100644 --- a/Kernel/Arch/x86_64/Interrupts/PIC.h +++ b/Kernel/Arch/x86_64/Interrupts/PIC.h @@ -25,7 +25,6 @@ public: virtual bool is_vector_enabled(InterruptNumber number) const override; virtual bool is_enabled() const override; virtual void spurious_eoi(GenericInterruptHandler const&) const override; - virtual u16 get_irr() const override; virtual u32 gsi_base() const override { return 0; } virtual size_t interrupt_vectors_count() const override { return 16; } virtual StringView model() const override { return "Dual i8259"sv; }