SerenityOS/serenity
1
0 Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2026-11-07 04:29:30 -10:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Use release_as in TestAML

Browse Source 
This avoids copies.
This commit is contained in:
Undefine authored and Sönke Holz committed 2026-11-07 13:27:30 +01:00
1 parent 2e0c8483fc
commit d191b2f5d0
1 file changed
+6 -6
Download Patch File Download Diff File Expand all files Collapse all files
Tests/LibACPI/TestAML.cpp
+6 -6
View File
@@ -32,11 +32,11 @@ TEST_CASE(scope_and_name)
auto num1 = TRY_OR_FAIL(interpreter->evaluate("\\_SB_.NUM1"sv)); auto num1 = TRY_OR_FAIL(interpreter->evaluate("\\_SB_.NUM1"sv));
EXPECT(num1.is<u64>()); EXPECT(num1.is<u64>());
EXPECT_EQ(MUST(num1.as<u64>()), 0x1234ul); EXPECT_EQ(MUST(num1.release_as<u64>()), 0x1234ul);
auto num2 = TRY_OR_FAIL(interpreter->evaluate("\\_SB_.NUM2"sv)); auto num2 = TRY_OR_FAIL(interpreter->evaluate("\\_SB_.NUM2"sv));
EXPECT(num2.is<u64>()); EXPECT(num2.is<u64>());
EXPECT_EQ(MUST(num2.as<u64>()), 42ul); EXPECT_EQ(MUST(num2.release_as<u64>()), 42ul);
} }
TEST_CASE(data_objects_and_named_objects) TEST_CASE(data_objects_and_named_objects)
@@ -45,12 +45,12 @@ TEST_CASE(data_objects_and_named_objects)
auto string = TRY_OR_FAIL(interpreter->evaluate("\\STR0"sv)); auto string = TRY_OR_FAIL(interpreter->evaluate("\\STR0"sv));
EXPECT(string.is<ACPI::AML::String>()); EXPECT(string.is<ACPI::AML::String>());
auto string_data = MUST(string.as<ACPI::AML::String>()); auto string_data = MUST(string.release_as<ACPI::AML::String>());
EXPECT_EQ(StringView(string_data.buffer()), "hello"sv); EXPECT_EQ(StringView(string_data.buffer()), "hello"sv);
auto buffer = TRY_OR_FAIL(interpreter->evaluate("\\BUF0"sv)); auto buffer = TRY_OR_FAIL(interpreter->evaluate("\\BUF0"sv));
EXPECT(buffer.is<ACPI::AML::Buffer>()); EXPECT(buffer.is<ACPI::AML::Buffer>());
auto buffer_data = MUST(buffer.as<ACPI::AML::Buffer>()); auto buffer_data = MUST(buffer.release_as<ACPI::AML::Buffer>());
EXPECT_EQ(buffer_data.buffer().size(), 8u); EXPECT_EQ(buffer_data.buffer().size(), 8u);
EXPECT_EQ(buffer_data.buffer()[0], 0x12u); EXPECT_EQ(buffer_data.buffer()[0], 0x12u);
EXPECT_EQ(buffer_data.buffer()[3], 0x78u); EXPECT_EQ(buffer_data.buffer()[3], 0x78u);
@@ -58,7 +58,7 @@ TEST_CASE(data_objects_and_named_objects)
auto package = TRY_OR_FAIL(interpreter->evaluate("\\PKG0"sv)); auto package = TRY_OR_FAIL(interpreter->evaluate("\\PKG0"sv));
EXPECT(package.is<ACPI::AML::Package>()); EXPECT(package.is<ACPI::AML::Package>());
auto package_data = MUST(package.as<ACPI::AML::Package>()); auto package_data = MUST(package.release_as<ACPI::AML::Package>());
EXPECT_EQ(package_data.package().size(), 3u); EXPECT_EQ(package_data.package().size(), 3u);
EXPECT_EQ(MUST(package_data.package()[0].as<u64>()), 0ul); EXPECT_EQ(MUST(package_data.package()[0].as<u64>()), 0ul);
EXPECT_EQ(MUST(package_data.package()[1].as<u64>()), 1ul); EXPECT_EQ(MUST(package_data.package()[1].as<u64>()), 1ul);
@@ -85,6 +85,6 @@ TEST_CASE(predefined_objects)
auto os_name = TRY_OR_FAIL(interpreter->evaluate("\\_OS_"sv)); auto os_name = TRY_OR_FAIL(interpreter->evaluate("\\_OS_"sv));
EXPECT(os_name.is<ACPI::AML::String>()); EXPECT(os_name.is<ACPI::AML::String>());
auto os_name_data = MUST(os_name.as<ACPI::AML::String>()); auto os_name_data = MUST(os_name.release_as<ACPI::AML::String>());
EXPECT_EQ(StringView(os_name_data.buffer()), "Microsoft Windows NT"sv); EXPECT_EQ(StringView(os_name_data.buffer()), "Microsoft Windows NT"sv);
} }