3 Commits

Include renames

Author	SHA1	Message	Date
KRATOS	6e0a665118	fix(auth): propagate credentials to every provider-build surface and pin children to the live provider (#366) ... * fix(auth): propagate credentials to every provider-build surface and pin children to the live provider Sub-agents, swarm members, ACP sessions, and mid-run escalation switches could build providers without the credentials the parent was running with. This consolidates credential resolution so every surface gets the same auth: - Wrap deps.newProvider once in fillAppDeps to fold the stored API key in centrally; ACP, exec escalation, and buildProvider no longer patch it per call site (an apiKeyStored profile previously went out keyless on those paths and 401'd). - Export ZERO_PROVIDER at startup (buildProvider) and keep exporting on every runtime switch (wizard, onboarding, /model, /provider), so spawned children resolve the parent's live provider instead of whatever another process last persisted to config.json. Injected via appDeps so tests never mutate the process environment. - Share one OAuth login selection end to end: ProviderProfile. OAuthLoginCandidates (name, then catalog-ID fallback; nothing for a profile with its own configured credential) + oauth.FirstStored resolve the login ONCE, and the bound store key is threaded through providers.Options.OAuthLoginKey so the Codex account-id header always reads the same login that issued the bearer token. A renamed profile (name != catalog ID) now finds its login; an explicit API key is never silently overridden by a same-name or catalog-shared OAuth login. - Export ProviderProfile.HasConfiguredCredential as the single "profile is key-authed" predicate (cli/tui/config previously had three copies). - applyProviderWizard commits live state (provider, profile, name, env export) only after BOTH the build and the config persist succeed, so a persist failure no longer leaves the chat running on a provider the status line and children disagree with. Covered by red-green tests for each path: stored-key wrap, escalation switch, catalog-ID fallback (incl. case-variant names), explicit-key protection, same-login account selection, wizard persist-failure rollback, onboarding/startup env export. * test: isolate OAuth/config test storage and fix the flaky MCP response-id test Review + CI fixes, all test-only: - factory/cli OAuth tests: pin ZERO_OAUTH_STORAGE=file next to the temp ZERO_OAUTH_TOKENS_PATH — an inherited "keyring" value sends NewStore to the OS keychain and ignores the temp path entirely, so the tests could read (or clobber) the developer's real logins. newOAuthStoreForTest now owns both pins so a future call site can't forget them. - TestApplyProviderWizardExportsActiveProviderEnv: point m.userConfigPath at a temp config and stub newProvider, so the SUCCESS path exercises the full build+persist+commit sequence in isolation (the default empty path silently skipped persist; a changed default must never reach the real user config). - TestClientRequestWaitsForMatchingResponseID (ubuntu smoke flake): the responses were pre-loaded into a bytes.Buffer, so the client's reader goroutine could consume the matching response — and hit EOF — before request() registered its pending id, failing with "request() error = EOF" on fast runners. The fake server now sits on pipes and responds only after reading the outgoing request, matching production ordering; survives -race -count=50.	2026-07-02 12:21:27 +05:30
Anandan	f1502f0bfe	Add local control browser and terminal tools (#319) ... * Add local control browser and terminal tools Add configurable local browser, desktop, and terminal control helpers with packaged helper discovery for install and release flows. Improve sandbox scope classification for local control commands and shared temporary paths. Add structured browser actions, terminal session line input/key normalization/read support, and artifact capture for local-control outputs. Tested: GOCACHE=/tmp/zero-go-cache go test ./internal/localcontrol ./internal/tools ./internal/cli ./internal/config -run 'Test.*LocalControl|TestTerminal|TestBrowser|TestDesktop|TestCapture' Tested: GOCACHE=/tmp/zero-go-cache go test ./internal/localcontrol ./internal/tools ./internal/cli ./internal/config ./internal/agent Tested: tuistory smoke launched bash, sent interactive input, waited for expected output, and captured a no-cursor snapshot Tested: git diff --cached --check * Fix npm wrapper helper manifest test on macOS Canonicalize expected helper paths in the npm wrapper manifest test so macOS /var and /private/var temp path aliases compare correctly. Tested: GOCACHE=/tmp/zero-go-cache go test ./internal/npmwrapper Tested: git diff --check * Harden local control review fixes Respect resolved local-control config before tool listing and filter validation while preserving stream-json usage error ordering. Harden browser, desktop, and artifact tool validation; guard Linux-only app launch behavior; clear stale helper manifests from the npm wrapper. Make helper packaging lockfile-based with npm ci and add installer/package tests for helper staging. Tested: focused local-control/tool/CLI/release/install/sandbox suite Tested: isolated full go test ./... Tested: macOS and Windows compile-only checks for touched packages	2026-06-26 08:22:56 +05:30
KRATOS	5b348056a4	feat(acp): Agent Client Protocol surface — drive ZERO as an editor backend (#288) ... * feat(acp): JSON-RPC 2.0 ndjson transport for the ACP surface Bidirectional JSON-RPC 2.0 peer over stdio (newline-delimited JSON): serves inbound requests/notifications via registered handlers and issues outbound requests/notifications. Handlers run on their own goroutines so a long-running request (session/prompt) never blocks delivery of session/cancel or a permission response. Stdlib-only, no new dependencies. Derived solely from the public JSON-RPC 2.0 + ACP specs. * feat(acp): ACP wire types derived from the public spec Protocol message types for initialize, session/{new,load,prompt,cancel,update, set_mode,set_config_option}, request_permission, content blocks, tool-call updates, plan entries, permission options, and session modes — method names and field shapes taken from the public ACP spec (agentclientprotocol.com schema/v1). Model selection is exposed both via the spec's session/set_config_option and a vendor _zero/set_model alias for clients that prefer it. * feat(acp): translate ZERO agent events to ACP session/update payloads Pure mappers (unit-tested) from ZERO's agent callbacks to ACP updates: text-> agent_message_chunk, reasoning->agent_thought_chunk, tool call->tool_call(in_progress), tool result->tool_call_update(completed/failed) with content + changed-file locations, and plan items->plan entries. A notifier wires the mappers to a live connection per session. * feat(acp): map ZERO permission prompts to ACP session/request_permission Translate ZERO's permission decisions into ACP PermissionOptions (optionId carries the ZERO action verbatim for a lossless round trip) and map the client's outcome back to a ZERO PermissionDecision: cancelled->cancel, selected->the chosen action, anything unrecognized fails closed to deny. Builds the embedded toolCall too. * feat(acp): ACP Agent server driving ZERO's core Implements the ACP methods over the JSON-RPC peer: initialize (capability + version negotiation), session/new, session/load (with history replay for resume), session/prompt (drives the real agent.Run with streaming callbacks -> session/update, and an OnPermissionRequest that round-trips through session/request_permission), session/cancel, session/set_mode (permission/autonomy mode), and model selection via session/set_config_option plus the vendor _zero/set_model alias. Dependencies are injected so the editor only hosts the thread while ZERO keeps auth/model/keys (BYOK). Includes an end-to-end test (initialize+new+prompt over stdio pipes through agent.Run with a fake provider) asserting the streamed updates. * feat(acp): wire the 'zero acp' subcommand Add 'zero acp', which serves ACP over stdio so editors (Zed, JetBrains, Neovim, ...) can drive ZERO as a backend. Reuses ZERO's real deps — config resolution, provider construction, the core tool registry, and the session store — so provider/model/keys stay owned by ZERO (BYOK). Registered in the command dispatch and the help listing. * fix(acp): drain in-flight handlers on stream close On stdin EOF the read loop returned before the dispatch goroutines flushed their responses, so piped/finite ndjson input (and editors that close the stream right after a request) dropped the reply. Serve now cancels in-flight handlers (so any blocked outbound Call unblocks via ctx) and waits for them before returning. * fix(acp): address review — sandbox confinement, mode/cwd/transport hardening Blockers: - Confine shell/file tools: runTurn now builds a SCOPED registry + sandbox engine per session (BuildWorkspace mirrors exec's buildExecSandboxEngine + NewScope) and passes Options.Sandbox — ACP no longer runs bash/exec_command unconfined. - Reject PermissionModeUnsafe over ACP (set_mode + advertised modes are auto/ask only); Unsafe stays gated to the operator, so a client can't self-grant no-prompt host access. - Fix data race on acpSession.history: registerSession sets history before publishing the session and reuses an already-live session instead of overwriting. - deliver() now deletes the pending entry and sends non-blocking, so a duplicate/ late response frame can't wedge the read loop. Should-fix: - Serialize prompt turns per session (turnMu) so concurrent prompts can't interleave history or clobber the cancel slot. - Validate client cwd (ResolveWorkspaceRoot mirrors exec; rejects filesystem root + home) before it becomes the file-tool confinement root. - Malformed JSON no longer tears down the connection: framing is per-line; a bad line replies -32700 (id null) and the loop continues. Also validate jsonrpc:"2.0". - Permission outcome binds to the offered set only (dropped the isKnownDecision fallback) — a client can't return a broader grant than was presented; fail closed. - Drop the non-conformant SessionCapabilities advertisement (no resume handler) and the non-conformant SessionConfigOption model selector; model switching stays available via the vendor _zero/set_model. Adds regression tests: sandbox+scoped-registry wiring, invalid-cwd rejection, Unsafe-mode rejection, and malformed-line resilience. Full go test ./... -race green.	2026-06-21 17:55:44 +05:30