2 Commits

Include renames

Author	SHA1	Message	Date
euxaristiaandClaude Sonnet 5	97ef90d27a	chore: remove code unreachable on every supported platform (#706) ... * chore: remove code unreachable on every supported platform The Security and code health job's advisory deadcode step reports 152 unreachable functions on main. Running the same check under GOOS=linux, windows, and darwin shows 13 of those are false positives whose callers live in windows build-tagged files, so only functions unreachable on all three platforms are touched. Functions with no references anywhere are deleted, including the internal/reasoning package, which nothing imports. Functions that only tests reference move into per-package export_test.go files so tests keep their seams while the production binary sheds the code. Test call sites of deleted convenience wrappers are ported to the live APIs (scoped tool constructors, tools.DeferredSource, FinishReason checks). Kept despite the report: cron.Store.Runs (only reader of runs.jsonl, which production writes), and agenteval.TraceEventKeys and MissingTraceEvents (used across packages by the trace contract test). * docs(config): correct ValidateFile's errors.As claim Message is a flattened string (.Error() already called on the parse error), not a wrapped error, so callers can't recover the concrete json error type via errors.As. Fix the comment to match. Co-Authored-By: Claude Sonnet 5 <[email protected]> * chore(trace,skills): drop obsolete Sink adapters and fix stale doc references The dead-code pass removed the Emit methods but left Sink, NDJSONSink, and TextSink exported with a contract nothing implements; remove the types with their contract. Also remove the stray blank line at EOF of trace.go flagged by gofmt, and update skills package docs and HOW_ZERO_WORKS.md to stop directing callers to DiscoveryRoots/Duplicates, which are now test seams. Co-Authored-By: Claude Fable 5 <[email protected]> * chore: clean up remaining review nits on dead code removal Replace a pointless fmt.Errorf(...%w...).Error() with fmt.Sprintf using %v, since the wrapped error was discarded immediately anyway. Remove a comment block that was duplicated verbatim. * docs(skills): drop remaining references to test-only List/Get Load and MergedSkills comments still named List/Get as production entry points after they moved to export_test.go. Point callers at Load and ListFromRoots instead. * chore: remove now-unreferenced export_test.go seams execSessionManager.len() and likelySandboxDenied/sandboxDenialKind had no remaining callers after the sandbox unify-command-execution rebase; the production code they wrapped for tests no longer exists. --------- Co-authored-by: Claude Sonnet 5 <[email protected]>	2026-07-24 09:04:41 +08:00
KRATOS	0e7318ff72	feat(tui): clickable plan-step detail + plan/sidebar UX & rendering polish (#315) ... * fix(tui): plan panel reflects live progress + prompt cadence The plan panel could read as stuck mid-task even while work continued. Three fixes: - Header showed steps[0] forever, so the title never advanced as the plan progressed; show the current step (in_progress, else first incomplete). - updateFromItems matched steps by content only, so an in-place reword reset a step's elapsed timer to zero; add positional carry-over when the step count is unchanged. - Prompt: tell the model to mark each step completed + the next in_progress before starting it, so the plan tracks real progress instead of jumping at the end. Regression tests included. * feat(tui): click a plan step to see what was built for it Each plan step now records the file mutations (write_file/edit_file/apply_patch) made while it was in_progress, captured from tool-result rows. Clicking a step row in the context sidebar drops a transcript card listing those changes — the implementation for that step. Step->line mapping mirrors sidebarAgentSelectables' offset accounting (one line per step); capture is keyed to the active step and cleared per run. Read-only and additive. Tests cover the offset math + capture. * feat(tui): plan-step detail shows diffs + commands Extend the clickable plan-step detail: capture bash/exec_command runs in addition to file mutations, store each tool's full output (the diff for edit/apply_patch, stdout/stderr for commands), and render the card grouped into Changes and Commands with a short truncated excerpt of each item's diff/output. * fix(tui): plan-step detail toggles instead of stacking duplicates Re-clicking a plan step now hides its card (a stable transcript id + drop-by-id), and clicking a different step replaces it, so at most one detail card is shown. Previously each click appended a fresh card and they piled up. * feat(tui): elaborate plan-step detail by status (what we did / will do) * feat(tui): plan-step card leads with a prose explanation (agent's own narration) * feat(tui): write plan-step explanations with the model on click Clicking a PLAN step now shows a fresh, plain-English write-up of that step, generated on demand by the active model: - past tense ('what we did') for completed/failed steps, future tense ('what we'll do') for pending/in_progress steps - immediate feedback: the card drops in showing 'Writing explanation…' and updates in place (by stable row id) when the text returns - cached per step (content+status) so re-clicking is instant with no second model call; re-clicking still toggles the card closed - the prompt is built from already-captured local data (step text, status, notes, plus a compact digest of file edits, commands, and the agent's narration) and asks for short, non-technical prose - reuses the TUI's existing provider via a one-shot StreamCompletion; no new client, no hardcoded provider. Falls back to the local summary when no provider is configured or the request fails. * fix(tui): minimal plan-step card styling (dim border, status-tinted title) * feat(tui): auto-hide context sidebar when it has no agents or plan * feat(tui): widen chat reading column to fill wide terminals with breathing room * fix(tui): toggle context sidebar silently (no transcript notice) * fix(tui): mark plan complete when a finished task forgot the final update_plan * fix(tui): remove the lime streaming-text glow (render responses in static ink) * fix(tui): remove the shaded panel band behind tool-result cards * fix(tui): Ctrl+B hides the plan entirely (no pinned-panel fallback) * style(tui): gofmt-align model struct fields * feat: narrate the build as a clean story (hide plumbing cards, live plan progress, narration prompt, write_file line counts) * feat(tui): render agent narration bright (ink) so the build reads as a story * feat(agent): demand an elaborate, structured closing summary (not a single line) * feat(tui): mark agent narration with a leading bullet (selection-aligned) * feat: post-turn recap line (※ recap:) with /config recaps on|off toggle * feat(tui): show 'still generating…' during quiet stretches + count tool-call streaming * feat(tui): ACTIVITY panel under PLAN + push the model to step the plan per file * fix(tui): show the quiet 'still generating' hint only when the sidebar is hidden * feat(tui): code preview in write/edit/apply cards (card-only, no model token cost) * fix(tui): address CodeRabbit review — stale plan timestamps, stale explanation, Ctrl+B persistence, UTF-8 truncation * fix: address CodeRabbit re-review round 2 (7 actionable + 2 nitpicks) * chore: drop accidentally-committed WIP internal/cli/dryrun_test.go It is an unrelated, pre-existing dry-run test that does not compile (references a non-existent agent.Options.DryRun field, an unused import, and out-of-scope sandbox symbols). It was swept into the prior commit by 'git add -A' and is not part of this PR's scope.	2026-06-25 20:23:29 +05:30