package cli import ( "bytes" "context" "encoding/json" "errors" "io" "net/http" "net/http/httptest" "os" "path/filepath" "slices" "strings" "testing" "github.com/Gitlawb/zero/internal/agent" "github.com/Gitlawb/zero/internal/config" "github.com/Gitlawb/zero/internal/modelregistry" "github.com/Gitlawb/zero/internal/zeroruntime" ) func TestRunExecHelpDocumentsM1Flags(t *testing.T) { for _, args := range [][]string{ {"exec", "--help"}, {"exec", "--help", "--model", "m1"}, } { t.Run(strings.Join(args, " "), func(t *testing.T) { var stdout bytes.Buffer var stderr bytes.Buffer exitCode := Run(args, &stdout, &stderr) if exitCode != 0 { t.Fatalf("expected exit code 0, got %d", exitCode) } for _, want := range []string{ "-f, --file", "--mode ", "-m, --model", "--max-turns", "--profile ", "-r, --reasoning-effort ", "-C, --cwd", "-o, --output-format text|json", "--prompt", "--skip-permissions-unsafe", } { if !strings.Contains(stdout.String(), want) { t.Fatalf("expected exec help to contain %q, got %q", want, stdout.String()) } } if stderr.Len() != 0 { t.Fatalf("expected empty stderr, got %q", stderr.String()) } }) } } func TestRunExecRejectsInvalidMaxTurnsBeforeRuntime(t *testing.T) { for _, tc := range []struct { value string want string }{ {value: "nope", want: "invalid --max-turns"}, {value: "-1", want: "invalid --max-turns"}, {value: "0", want: "invalid --max-turns"}, } { t.Run(tc.value, func(t *testing.T) { var stdout bytes.Buffer var stderr bytes.Buffer exitCode := Run([]string{"exec", "--max-turns", tc.value, "hello"}, &stdout, &stderr) if exitCode != exitUsage { t.Fatalf("expected exit code %d, got %d", exitUsage, exitCode) } if stdout.Len() != 0 { t.Fatalf("expected empty stdout before runtime, got %q", stdout.String()) } if got := stderr.String(); !strings.Contains(got, tc.want) { t.Fatalf("expected max-turns validation error containing %q, got %q", tc.want, got) } }) } t.Run("equals-empty", func(t *testing.T) { var stdout bytes.Buffer var stderr bytes.Buffer exitCode := Run([]string{"exec", "--max-turns=", "hello"}, &stdout, &stderr) if exitCode != exitUsage { t.Fatalf("expected exit code %d, got %d", exitUsage, exitCode) } if stdout.Len() != 0 { t.Fatalf("expected empty stdout before runtime, got %q", stdout.String()) } if got := stderr.String(); !strings.Contains(got, "--max-turns requires a value") { t.Fatalf("expected empty max-turns validation error, got %q", got) } }) } func TestRunExecMaxTurnsReachesConfigOverrides(t *testing.T) { cwd := t.TempDir() var gotMaxTurns int var stdout bytes.Buffer var stderr bytes.Buffer exitCode := runWithDeps([]string{"exec", "--max-turns", "7", "hello"}, &stdout, &stderr, appDeps{ getwd: func() (string, error) { return cwd, nil }, resolveConfig: func(_ string, overrides config.Overrides) (config.ResolvedConfig, error) { gotMaxTurns = overrides.MaxTurns return config.ResolvedConfig{}, errors.New("stop before provider") }, }) if exitCode != exitProvider { t.Fatalf("expected provider exit %d, got %d", exitProvider, exitCode) } if gotMaxTurns != 7 { t.Fatalf("overrides.MaxTurns = %d, want 7", gotMaxTurns) } } func TestRunExecModeSeedsModelAndTurnOverrides(t *testing.T) { cwd := t.TempDir() var gotModel string var gotMaxTurns int var stdout bytes.Buffer var stderr bytes.Buffer exitCode := runWithDeps([]string{"exec", "--mode", "deep", "hello"}, &stdout, &stderr, appDeps{ getwd: func() (string, error) { return cwd, nil }, resolveConfig: func(_ string, overrides config.Overrides) (config.ResolvedConfig, error) { gotModel = overrides.Provider.Model gotMaxTurns = overrides.MaxTurns return config.ResolvedConfig{}, errors.New("stop before provider") }, }) if exitCode != exitProvider { t.Fatalf("expected provider exit %d, got %d", exitProvider, exitCode) } if gotModel != "claude-opus-4.1" { t.Fatalf("overrides.Provider.Model = %q, want claude-opus-4.1", gotModel) } if gotMaxTurns != 50 { t.Fatalf("overrides.MaxTurns = %d, want 50", gotMaxTurns) } } func TestRunExecExplicitModelOverridesMode(t *testing.T) { cwd := t.TempDir() var gotModel string var stdout bytes.Buffer var stderr bytes.Buffer exitCode := runWithDeps([]string{"exec", "--mode", "deep", "--model", "gpt-4.1", "hello"}, &stdout, &stderr, appDeps{ getwd: func() (string, error) { return cwd, nil }, resolveConfig: func(_ string, overrides config.Overrides) (config.ResolvedConfig, error) { gotModel = overrides.Provider.Model return config.ResolvedConfig{}, errors.New("stop before provider") }, }) if exitCode != exitProvider { t.Fatalf("expected provider exit %d, got %d", exitProvider, exitCode) } if gotModel != "gpt-4.1" { t.Fatalf("explicit --model should override mode: got %q, want gpt-4.1", gotModel) } } func TestRunExecModeRoutesModelThroughRegistry(t *testing.T) { cwd := t.TempDir() var gotModel string var stdout bytes.Buffer var stderr bytes.Buffer // "smart" maps to claude-sonnet-4.5; the mode's model must be routed through // the registry (Resolve) so the canonical id reaches the overrides. exitCode := runWithDeps([]string{"exec", "--mode", "smart", "hi"}, &stdout, &stderr, appDeps{ getwd: func() (string, error) { return cwd, nil }, resolveConfig: func(_ string, overrides config.Overrides) (config.ResolvedConfig, error) { gotModel = overrides.Provider.Model return config.ResolvedConfig{}, errors.New("stop before provider") }, }) if exitCode != exitProvider { t.Fatalf("expected provider exit %d, got %d", exitProvider, exitCode) } if gotModel != "claude-sonnet-4.5" { t.Fatalf("expected mode smart to select claude-sonnet-4.5, got %q", gotModel) } } func TestRunExecUnknownModeErrors(t *testing.T) { var stdout bytes.Buffer var stderr bytes.Buffer exitCode := Run([]string{"exec", "--mode", "turbo", "hello"}, &stdout, &stderr) if exitCode != exitUsage { t.Fatalf("expected usage exit %d, got %d", exitUsage, exitCode) } if !strings.Contains(stderr.String(), "unknown mode") { t.Fatalf("expected unknown mode error, got %q", stderr.String()) } for _, want := range []string{"smart", "deep", "fast", "large", "precise"} { if !strings.Contains(stderr.String(), want) { t.Fatalf("expected error to list valid mode %q, got %q", want, stderr.String()) } } } func TestApplyExecModeLeavesRawModelForSharedResolution(t *testing.T) { // applyExecMode must NOT pre-resolve the mode's model: leaving the raw id/alias // lets the shared --model resolution path resolve it AND surface any deprecation // notice on stderr (the bug was that applyExecMode resolved it and discarded the // notice). The raw alias must be the preset's exact Model value. mode, ok := modelregistry.LookupMode("deep") if !ok { t.Fatal("expected built-in mode deep") } options := execOptions{mode: "deep"} if err := applyExecMode(&options); err != nil { t.Fatalf("applyExecMode returned error: %v", err) } if options.model != mode.Model { t.Fatalf("options.model = %q, want raw mode model %q (resolution must be delegated)", options.model, mode.Model) } } func TestRunExecModeModelSurfacesDeprecationNoticeViaSharedPath(t *testing.T) { // A mode-supplied model must flow through the same resolution path as an // explicit --model, so a deprecated id redirects AND prints a notice. No // built-in mode references a deprecated model, so emulate one by setting the // raw mode model directly through applyExecMode and threading it through the // shared resolver, exactly as runExec does after the reorder. options := execOptions{mode: "smart"} if err := applyExecMode(&options); err != nil { t.Fatalf("applyExecMode returned error: %v", err) } // Sanity: the shared resolver surfaces a notice + redirect for a deprecated id, // which is the path the mode model now feeds into. registry, err := modelregistry.DefaultRegistry() if err != nil { t.Fatalf("DefaultRegistry: %v", err) } resolved, notice := resolveSelectedModel(registry, "gpt-4-turbo") if resolved != "gpt-4.1" { t.Fatalf("expected deprecated model to redirect to gpt-4.1, got %q", resolved) } if !strings.Contains(notice, "deprecated") { t.Fatalf("expected shared resolver to surface a deprecation notice, got %q", notice) } } func TestRunExecListToolsAppliesModeBeforeListing(t *testing.T) { // applyExecMode now runs before tool-filter validation and the --list-tools // branch, so a --mode preset is expanded for --list-tools. Combining a mode // with --list-tools must still succeed and never resolve a provider. cwd := t.TempDir() var stdout bytes.Buffer var stderr bytes.Buffer exitCode := runWithDeps([]string{"exec", "--list-tools", "--mode", "deep"}, &stdout, &stderr, appDeps{ getwd: func() (string, error) { return cwd, nil }, resolveConfig: func(string, config.Overrides) (config.ResolvedConfig, error) { return config.ResolvedConfig{}, errors.New("provider should not be resolved for --list-tools") }, }) if exitCode != exitSuccess { t.Fatalf("expected exit code %d, got %d: %s", exitSuccess, exitCode, stderr.String()) } if !strings.Contains(stdout.String(), "Tools visible to model") { t.Fatalf("expected --list-tools --mode to list tools, got %q", stdout.String()) } } func TestRunExecModeToolFilterReflectedInListTools(t *testing.T) { // The reorder also means a mode-injected tool filter would be reflected in // --list-tools. No built-in mode ships a tool filter, so drive the equivalent // surface through applyExecMode + formatExecToolList: a filter seeded onto the // options before the listing must narrow the tools the model can see. options := execOptions{enabledTools: []string{"read_file", "grep"}} registry := newCoreRegistry(t.TempDir()) list := formatExecToolList(registry, options, agent.PermissionModeAuto) for _, want := range []string{"read_file", "grep"} { if !strings.Contains(list, want) { t.Fatalf("expected tool list to contain %q, got %q", want, list) } } if strings.Contains(list, "bash") { t.Fatalf("expected mode-style tool filter to hide bash, got %q", list) } } func TestRunExecAcceptsLegacyModelProfileFlags(t *testing.T) { exitCode, stdout, stderr := runExecWithEcho(t, []string{ "exec", "--profile", "fast", "--reasoning-effort", "low", "hello", }) if exitCode != exitSuccess { t.Fatalf("expected exit code %d, got %d: %s", exitSuccess, exitCode, stderr) } if !strings.Contains(stdout, "hello") { t.Fatalf("expected prompt output, got %q", stdout) } if stderr != "" { t.Fatalf("expected empty stderr, got %q", stderr) } } func TestRunExecJSONRunStartWriteFailureSkipsAgent(t *testing.T) { cwd := t.TempDir() called := false exitCode := runWithDeps([]string{"exec", "-o", "json", "hello"}, failingWriter{}, io.Discard, appDeps{ getwd: func() (string, error) { return cwd, nil }, resolveConfig: func(_ string, _ config.Overrides) (config.ResolvedConfig, error) { return execResolvedConfig(), nil }, newProvider: func(config.ProviderProfile) (zeroruntime.Provider, error) { return recordingExecProvider{called: &called}, nil }, }) if exitCode != exitCrash { t.Fatalf("expected exit code %d, got %d", exitCrash, exitCode) } if called { t.Fatal("expected agent provider not to run after run_start write failure") } } func TestRunExecUnsafeWarningWriteFailureSkipsAgent(t *testing.T) { cwd := t.TempDir() called := false exitCode := runWithDeps([]string{"exec", "--skip-permissions-unsafe", "hello"}, io.Discard, failingWriter{}, appDeps{ getwd: func() (string, error) { return cwd, nil }, resolveConfig: func(_ string, _ config.Overrides) (config.ResolvedConfig, error) { return execResolvedConfig(), nil }, newProvider: func(config.ProviderProfile) (zeroruntime.Provider, error) { return recordingExecProvider{called: &called}, nil }, }) if exitCode != exitCrash { t.Fatalf("expected exit code %d, got %d", exitCrash, exitCode) } if called { t.Fatal("expected agent provider not to run after warning write failure") } } func TestRunExecJSONProviderErrorWriteFailureReturnsCrash(t *testing.T) { cwd := t.TempDir() exitCode := runWithDeps([]string{"exec", "-o", "json", "hello"}, failingWriter{}, io.Discard, appDeps{ getwd: func() (string, error) { return cwd, nil }, resolveConfig: func(_ string, _ config.Overrides) (config.ResolvedConfig, error) { return config.ResolvedConfig{}, errors.New("provider config failed") }, }) if exitCode != exitCrash { t.Fatalf("expected exit code %d, got %d", exitCrash, exitCode) } } func execResolvedConfig() config.ResolvedConfig { return config.ResolvedConfig{ ActiveProvider: "echo", Provider: config.ProviderProfile{ Name: "echo", ProviderKind: config.ProviderKindOpenAICompatible, BaseURL: "http://127.0.0.1/v1", Model: "echo-model", }, } } type recordingExecProvider struct { called *bool } func (provider recordingExecProvider) StreamCompletion(context.Context, zeroruntime.CompletionRequest) (<-chan zeroruntime.StreamEvent, error) { *provider.called = true return nil, errors.New("provider should not run") } func TestRunPromptFlagRoutesToExecRunner(t *testing.T) { execExitCode, execStdout, execStderr := runExecWithEcho(t, []string{"exec", "hello zero"}) for _, args := range [][]string{ {"-p", "hello zero"}, {"--prompt", "hello zero"}, } { t.Run(args[0], func(t *testing.T) { exitCode, stdout, stderr := runExecWithEcho(t, args) if exitCode != execExitCode { t.Fatalf("expected exit code %d, got %d", execExitCode, exitCode) } if stdout != execStdout { t.Fatalf("expected stdout %q, got %q", execStdout, stdout) } if stderr != execStderr { t.Fatalf("expected stderr %q, got %q", execStderr, stderr) } }) } } func TestRunExecAssemblesInlineAndFilePromptRelativeToCwd(t *testing.T) { root := t.TempDir() if err := os.WriteFile(filepath.Join(root, "prompt.txt"), []byte("file prompt\n"), 0o600); err != nil { t.Fatal(err) } exitCode, stdout, stderr := runExecWithEcho(t, []string{"exec", "--cwd", root, "--file", "prompt.txt", "inline prompt"}) if exitCode != 0 { t.Fatalf("expected exit code 0, got %d: %s", exitCode, stderr) } if !strings.Contains(stdout, "inline prompt\n\nfile prompt") { t.Fatalf("expected inline and file prompt joined by blank line, got %q", stdout) } if stderr != "" { t.Fatalf("expected empty stderr, got %q", stderr) } } func TestRunExecAcceptsFileOnlyPrompt(t *testing.T) { root := t.TempDir() if err := os.WriteFile(filepath.Join(root, "prompt.txt"), []byte("file only prompt\n"), 0o600); err != nil { t.Fatal(err) } exitCode, stdout, stderr := runExecWithEcho(t, []string{"exec", "-C", root, "-f", "prompt.txt"}) if exitCode != 0 { t.Fatalf("expected exit code 0, got %d: %s", exitCode, stderr) } if !strings.Contains(stdout, "file only prompt") { t.Fatalf("expected file prompt output, got %q", stdout) } if stderr != "" { t.Fatalf("expected empty stderr, got %q", stderr) } } func TestRunExecRejectsInvalidCwdBeforeRuntime(t *testing.T) { root := t.TempDir() filePath := filepath.Join(root, "not-a-directory.txt") if err := os.WriteFile(filePath, []byte("nope"), 0o600); err != nil { t.Fatal(err) } for _, tc := range []struct { name string cwd string }{ {name: "missing", cwd: filepath.Join(root, "missing")}, {name: "file", cwd: filePath}, } { t.Run(tc.name, func(t *testing.T) { var stdout bytes.Buffer var stderr bytes.Buffer exitCode := Run([]string{"exec", "--cwd", tc.cwd, "hello"}, &stdout, &stderr) if exitCode != 2 { t.Fatalf("expected exit code 2, got %d", exitCode) } if stdout.Len() != 0 { t.Fatalf("expected empty stdout before runtime, got %q", stdout.String()) } if got := stderr.String(); !strings.Contains(got, "cwd must be an existing directory") { t.Fatalf("expected cwd validation error, got %q", got) } if strings.Contains(stdout.String()+stderr.String(), "Go agent runtime ready") { t.Fatalf("expected validation before runtime, got stdout %q stderr %q", stdout.String(), stderr.String()) } }) } } func TestRunExecRejectsInvalidOutputFormatBeforeRuntime(t *testing.T) { var stdout bytes.Buffer var stderr bytes.Buffer exitCode := Run([]string{"exec", "-o", "yaml", "hello"}, &stdout, &stderr) if exitCode != 2 { t.Fatalf("expected exit code 2, got %d", exitCode) } if stdout.Len() != 0 { t.Fatalf("expected empty stdout before runtime, got %q", stdout.String()) } if got := stderr.String(); !strings.Contains(got, `invalid output format "yaml"`) { t.Fatalf("expected output format validation error, got %q", got) } if strings.Contains(stdout.String()+stderr.String(), "Go agent runtime ready") { t.Fatalf("expected validation before runtime, got stdout %q stderr %q", stdout.String(), stderr.String()) } } func TestRunExecUnsafeTextModeWarns(t *testing.T) { exitCode, stdout, stderr := runExecWithEcho(t, []string{"exec", "--skip-permissions-unsafe", "hello"}) if exitCode != 0 { t.Fatalf("expected exit code 0, got %d: %s", exitCode, stderr) } if !strings.Contains(stdout, "hello") { t.Fatalf("expected prompt in stdout, got %q", stdout) } if got := stderr; !strings.Contains(got, "WARNING") || !strings.Contains(got, "--skip-permissions-unsafe") { t.Fatalf("expected unsafe warning, got %q", got) } } func TestRunExecJSONOutputsNDJSONEvents(t *testing.T) { root := t.TempDir() exitCode, stdout, stderr := runExecWithEcho(t, []string{"exec", "--cwd", root, "-m", "m1-test", "-o", "json", "hello json"}) if exitCode != 0 { t.Fatalf("expected exit code 0, got %d: %s", exitCode, stderr) } if stderr != "" { t.Fatalf("expected empty stderr, got %q", stderr) } events := decodeJSONLines(t, stdout) eventTypes := jsonEventTypes(events) for _, want := range []string{"run_start", "text", "final", "done"} { if !slices.Contains(eventTypes, want) { t.Fatalf("expected JSON event %q in %v; output %q", want, eventTypes, stdout) } } if got := events[0]["type"]; got != "run_start" { t.Fatalf("expected first event run_start, got %v", got) } if got := events[0]["model"]; got != "m1-test" { t.Fatalf("expected run_start model m1-test, got %v", got) } if got := events[0]["cwd"]; got != root { t.Fatalf("expected run_start cwd %q, got %v", root, got) } if got := events[0]["permission_mode"]; got != "auto" { t.Fatalf("expected default permission_mode auto, got %v", got) } } func TestRunExecResolvesCanonicalModelAlias(t *testing.T) { root := t.TempDir() // "openai:gpt-4.1" is a registry alias for the canonical gpt-4.1 id; the // selection boundary should normalize it before the provider sees it. exitCode, stdout, stderr := runExecWithEcho(t, []string{"exec", "--cwd", root, "-m", "openai:gpt-4.1", "-o", "json", "hi"}) if exitCode != 0 { t.Fatalf("expected exit code 0, got %d: %s", exitCode, stderr) } if stderr != "" { t.Fatalf("expected empty stderr for active model, got %q", stderr) } events := decodeJSONLines(t, stdout) if got := events[0]["model"]; got != "gpt-4.1" { t.Fatalf("expected alias to resolve to gpt-4.1, got %v", got) } } func TestRunExecRedirectsDeprecatedModelWithNotice(t *testing.T) { root := t.TempDir() exitCode, stdout, stderr := runExecWithEcho(t, []string{"exec", "--cwd", root, "-m", "gpt-4-turbo", "-o", "json", "hi"}) if exitCode != 0 { t.Fatalf("expected exit code 0, got %d: %s", exitCode, stderr) } if !strings.Contains(stderr, "deprecated") || !strings.Contains(stderr, "gpt-4.1") { t.Fatalf("expected deprecation notice on stderr, got %q", stderr) } events := decodeJSONLines(t, stdout) if got := events[0]["model"]; got != "gpt-4.1" { t.Fatalf("expected deprecated model to redirect to gpt-4.1, got %v", got) } } func TestRunExecReasoningEffortNoticeForNonReasoningModel(t *testing.T) { root := t.TempDir() exitCode, stdout, stderr := runExecWithEcho(t, []string{"exec", "--cwd", root, "-m", "gpt-4.1", "-r", "high", "-o", "json", "hi"}) if exitCode != 0 { t.Fatalf("expected exit code 0, got %d: %s", exitCode, stderr) } if !strings.Contains(stderr, "does not support reasoning effort") { t.Fatalf("expected non-reasoning effort notice on stderr, got %q", stderr) } if stdout == "" { t.Fatal("expected run output on stdout") } } func TestReasoningEffortNoticeCoercesUnsupportedEffort(t *testing.T) { registry, err := modelregistry.DefaultRegistry() if err != nil { t.Fatalf("DefaultRegistry: %v", err) } // claude-sonnet-4.5 supports low/medium/high with a medium default; xhigh is // unsupported and should be coerced to the model default. notice := reasoningEffortNotice(registry, "claude-sonnet-4.5", "xhigh") if !strings.Contains(notice, "not supported") || !strings.Contains(notice, "medium") { t.Fatalf("expected coercion notice to default medium, got %q", notice) } if got := reasoningEffortNotice(registry, "claude-sonnet-4.5", "high"); got != "" { t.Fatalf("expected no notice for a supported effort, got %q", got) } if got := reasoningEffortNotice(registry, "gpt-4.1", "high"); !strings.Contains(got, "does not support") { t.Fatalf("expected unsupported-model notice, got %q", got) } } func TestRunExecJSONUnsafeOutputsWarningEvent(t *testing.T) { exitCode, stdout, stderr := runExecWithEcho(t, []string{"exec", "--skip-permissions-unsafe", "-o", "json", "hello"}) if exitCode != 0 { t.Fatalf("expected exit code 0, got %d: %s", exitCode, stderr) } if stderr != "" { t.Fatalf("expected empty stderr, got %q", stderr) } events := decodeJSONLines(t, stdout) eventTypes := jsonEventTypes(events) if !slices.Contains(eventTypes, "warning") { t.Fatalf("expected JSON warning event in %v; output %q", eventTypes, stdout) } if got := events[0]["permission_mode"]; got != "unsafe" { t.Fatalf("expected run_start permission_mode unsafe, got %v", got) } } func TestRunExecUsesProjectConfigAndOpenAICompatibleProvider(t *testing.T) { clearProviderEnv(t) root := t.TempDir() configDir := filepath.Join(root, ".zero") if err := os.MkdirAll(configDir, 0o700); err != nil { t.Fatal(err) } var gotAuth string var gotMethod string var gotPath string var gotBody map[string]any server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { gotMethod = r.Method gotPath = r.URL.Path gotAuth = r.Header.Get("Authorization") if err := json.NewDecoder(r.Body).Decode(&gotBody); err != nil { t.Fatalf("decode provider request: %v", err) } _, _ = io.WriteString(w, "data: {\"choices\":[{\"delta\":{\"content\":\"provider ok\"}}]}\n\n") _, _ = io.WriteString(w, "data: [DONE]\n\n") })) defer server.Close() writeConfig := `{ "activeProvider": "local", "providers": [{ "name": "local", "provider_kind": "openai-compatible", "base_url": "` + server.URL + `", "api_key": "sk-local", "model": "local-model" }] }` if err := os.WriteFile(filepath.Join(configDir, "config.json"), []byte(writeConfig), 0o600); err != nil { t.Fatal(err) } var stdout bytes.Buffer var stderr bytes.Buffer exitCode := Run([]string{"exec", "--cwd", root, "hello provider"}, &stdout, &stderr) if exitCode != 0 { t.Fatalf("expected exit code 0, got %d: %s", exitCode, stderr.String()) } if strings.TrimSpace(stdout.String()) != "provider ok" { t.Fatalf("stdout = %q, want provider response", stdout.String()) } if stderr.Len() != 0 { t.Fatalf("expected empty stderr, got %q", stderr.String()) } if gotAuth != "Bearer sk-local" { t.Fatalf("Authorization = %q, want project config token", gotAuth) } if gotMethod != http.MethodPost { t.Fatalf("method = %q, want %q", gotMethod, http.MethodPost) } if !strings.HasSuffix(gotPath, "/chat/completions") { t.Fatalf("path = %q, want suffix /chat/completions", gotPath) } if gotBody["model"] != "local-model" { t.Fatalf("provider model = %v, want local-model", gotBody["model"]) } messages, ok := gotBody["messages"].([]any) if !ok || len(messages) == 0 { t.Fatalf("messages = %#v, want non-empty []any", gotBody["messages"]) } lastMessage, ok := messages[len(messages)-1].(map[string]any) if !ok { t.Fatalf("last message = %#v, want map[string]any", messages[len(messages)-1]) } if lastMessage["content"] != "hello provider" { t.Fatalf("last provider message = %#v, want prompt", lastMessage) } } func runExecWithEcho(t *testing.T, args []string) (int, string, string) { t.Helper() var stdout bytes.Buffer var stderr bytes.Buffer cwd := t.TempDir() exitCode := runWithDeps(args, &stdout, &stderr, appDeps{ getwd: func() (string, error) { return cwd, nil }, resolveConfig: func(_ string, overrides config.Overrides) (config.ResolvedConfig, error) { model := "echo-model" if overrides.Provider.Model != "" { model = overrides.Provider.Model } return config.ResolvedConfig{ ActiveProvider: "echo", Provider: config.ProviderProfile{ Name: "echo", ProviderKind: config.ProviderKindOpenAICompatible, BaseURL: "http://127.0.0.1/v1", Model: model, }, MaxTurns: 3, }, nil }, newProvider: func(config.ProviderProfile) (zeroruntime.Provider, error) { return echoExecProvider{}, nil }, }) return exitCode, stdout.String(), stderr.String() } type echoExecProvider struct{} func (echoExecProvider) StreamCompletion(ctx context.Context, request zeroruntime.CompletionRequest) (<-chan zeroruntime.StreamEvent, error) { prompt := "" for index := len(request.Messages) - 1; index >= 0; index-- { if request.Messages[index].Role == zeroruntime.MessageRoleUser { prompt = request.Messages[index].Content break } } ch := make(chan zeroruntime.StreamEvent, 2) select { case <-ctx.Done(): close(ch) return ch, ctx.Err() case ch <- zeroruntime.StreamEvent{Type: zeroruntime.StreamEventText, Content: prompt}: } ch <- zeroruntime.StreamEvent{Type: zeroruntime.StreamEventDone} close(ch) return ch, nil } func clearProviderEnv(t *testing.T) { t.Helper() for _, key := range []string{ "ZERO_PROVIDER_COMMAND", "ZERO_PROVIDER", "OPENAI_API_KEY", "OPENAI_BASE_URL", "OPENAI_MODEL", } { t.Setenv(key, "") } } func decodeJSONLines(t *testing.T, output string) []map[string]any { t.Helper() lines := strings.Split(strings.TrimSpace(output), "\n") if len(lines) == 0 || lines[0] == "" { t.Fatalf("expected JSON lines, got %q", output) } events := make([]map[string]any, 0, len(lines)) for _, line := range lines { var event map[string]any if err := json.Unmarshal([]byte(line), &event); err != nil { t.Fatalf("expected JSON object line, got %q: %v", line, err) } events = append(events, event) } return events } func jsonEventTypes(events []map[string]any) []string { types := make([]string, 0, len(events)) for _, event := range events { eventType, _ := event["type"].(string) types = append(types, eventType) } return types } // runExecWithEffectiveModel runs exec with the echo provider but forces the // resolved (effective) model regardless of any --model flag, so tests can // exercise behavior that depends on the effective model rather than the // override-supplied one. func runExecWithEffectiveModel(t *testing.T, effectiveModel string, args []string) (int, string, string) { t.Helper() var stdout bytes.Buffer var stderr bytes.Buffer cwd := t.TempDir() exitCode := runWithDeps(args, &stdout, &stderr, appDeps{ getwd: func() (string, error) { return cwd, nil }, resolveConfig: func(_ string, _ config.Overrides) (config.ResolvedConfig, error) { return config.ResolvedConfig{ ActiveProvider: "echo", Provider: config.ProviderProfile{ Name: "echo", ProviderKind: config.ProviderKindOpenAICompatible, BaseURL: "http://127.0.0.1/v1", Model: effectiveModel, }, MaxTurns: 3, }, nil }, newProvider: func(config.ProviderProfile) (zeroruntime.Provider, error) { return echoExecProvider{}, nil }, }) return exitCode, stdout.String(), stderr.String() } // TestRunExecReasoningEffortNoticeUsesEffectiveModel asserts that // --reasoning-effort is validated against the EFFECTIVE (resolved) model even // when --model is omitted, so the advisory notice still surfaces. func TestRunExecReasoningEffortNoticeUsesEffectiveModel(t *testing.T) { // gpt-4.1 is a registry-known non-reasoning model. With no --model the // override model is empty, so the notice must be evaluated against the // effective model resolved by resolveConfig. exitCode, stdout, stderr := runExecWithEffectiveModel(t, "gpt-4.1", []string{ "exec", "-r", "high", "hi", }) if exitCode != exitSuccess { t.Fatalf("expected exit code %d, got %d: %s", exitSuccess, exitCode, stderr) } if !strings.Contains(stderr, "does not support reasoning effort") { t.Fatalf("expected effort notice for effective model on stderr, got %q", stderr) } if stdout == "" { t.Fatal("expected run output on stdout") } } // TestRunExecAutoHighEmitsUnsafeWarning asserts that --auto high (which resolves // to PermissionModeUnsafe) surfaces the same unsafe warning as // --skip-permissions-unsafe. func TestRunExecAutoHighEmitsUnsafeWarning(t *testing.T) { exitCode, stdout, stderr := runExecWithEcho(t, []string{ "exec", "--auto", "high", "-o", "json", "hello", }) if exitCode != exitSuccess { t.Fatalf("expected exit code %d, got %d: %s", exitSuccess, exitCode, stderr) } if stderr != "" { t.Fatalf("expected empty stderr, got %q", stderr) } events := decodeJSONLines(t, stdout) if !slices.Contains(jsonEventTypes(events), "warning") { t.Fatalf("expected JSON warning event for --auto high, got %v; output %q", jsonEventTypes(events), stdout) } if got := events[0]["permission_mode"]; got != "unsafe" { t.Fatalf("expected run_start permission_mode unsafe, got %v", got) } } // TestRunExecInvalidAutoValidatedWithSkipPermissions asserts that an invalid // --auto value is still rejected even when --skip-permissions-unsafe is also // passed (the unsafe path must not short-circuit --auto validation). func TestRunExecInvalidAutoValidatedWithSkipPermissions(t *testing.T) { var stdout bytes.Buffer var stderr bytes.Buffer exitCode := Run([]string{"exec", "--auto", "bogus", "--skip-permissions-unsafe", "hello"}, &stdout, &stderr) if exitCode != exitUsage { t.Fatalf("expected exit code %d, got %d", exitUsage, exitCode) } if got := stderr.String(); !strings.Contains(got, "Invalid autonomy level") { t.Fatalf("expected autonomy validation error, got %q", got) } }