mirror of
https://github.com/Twigpine/zero.git
synced 2026-11-12 08:41:32 -10:00
gnanam1990
dbdc04db61
On timeout the context cancelled only the shell, leaving backgrounded children (e.g. 'sleep 3 & wait') orphaned. Worse, those children inherited the stdout/stderr pipes, so Run() blocked until they exited — far past the timeout. Set Setpgid and a Cancel that SIGKILLs the whole process group on POSIX, plus a WaitDelay backstop so a lingering child can't hang Wait. On Windows, set WaitDelay only (no process groups).
23 lines
759 B
Go
23 lines
759 B
Go
//go:build windows
|
|
|
|
package tools
|
|
|
|
import (
|
|
"os/exec"
|
|
"time"
|
|
)
|
|
|
|
// bashWaitDelay bounds how long Wait blocks for the I/O pipes to drain after the
|
|
// process has exited or the context's Cancel has run, so a backgrounded child
|
|
// holding the pipes cannot make Run() hang past the timeout. Var (not const) so
|
|
// tests can shorten it.
|
|
var bashWaitDelay = 2 * time.Second
|
|
|
|
// hardenProcessLifetime sets WaitDelay so a leaked child cannot block Wait
|
|
// indefinitely. Windows lacks POSIX process groups; tree-killing the shell's
|
|
// descendants (taskkill /T) is not wired for the synchronous bash path, so the
|
|
// default Cancel (Process.Kill on the shell) plus WaitDelay is used.
|
|
func hardenProcessLifetime(command *exec.Cmd) {
|
|
command.WaitDelay = bashWaitDelay
|
|
}
|