Twigpine/zero

0 Fork 0

mirror of https://github.com/Twigpine/zero.git synced 2026-11-11 05:01:36 -10:00

Files

T

PierrunoYTandClaude Sonnet 5 0125e70d0f Fix pinned Go quality tools on Go 1.26 (#689 )

* fix pinned Go quality toolchain

* fix(make): use a POSIX GOTOOLCHAIN prefix for pinned tool targets

The Windows_NT branch used cmd.exe syntax (set "..." &&), but GNU Make
runs recipes through sh even on Windows (MSYS/Git Bash), where that
form fails and breaks make lint-static/deadcode/vulncheck. A plain
GOTOOLCHAIN=... prefix works everywhere, so the OS check is gone.

Also switch GO_VERSION/GO_TOOLCHAIN to recursive expansion so
'go list -m' only runs when a tool target actually needs it, instead
of at parse time for every target. Addresses PR review from CodeRabbit
and Copilot.

Co-Authored-By: Claude Fable 5 <[email protected]>

* fix(build): make pinned-tool targets shell-neutral, fix README drift

Address code review on PR #689:

- lint-static/deadcode/vulncheck previously set GOTOOLCHAIN via a
  POSIX `VAR=value cmd` recipe prefix. GNU Make on Windows runs
  recipes through whatever SHELL is configured, and under a native
  cmd.exe setup that syntax is invalid — cmd.exe treats the whole
  "GOTOOLCHAIN=go1.26.5" token as the program to run and fails before
  go ever executes (reproduced locally: cmd.exe errors with
  "'MYVAR' is not recognized..." for the equivalent pattern). Switched
  to a target-specific `export`, which sets the variable in the child
  process environment via Make itself, before  is invoked —
  works under sh, cmd.exe, and PowerShell alike (verified against all
  three targets with SHELL := cmd.exe).

- README.md's Code Quality and Security Checks section still told
  contributors to run the raw `go run ...@version` commands this PR
  identifies as selecting the wrong (older) toolchain and failing to
  load this Go 1.26.5 module — only CI and AGENTS.md had been updated
  to the new make targets. Points steps 3-4 at `make lint-static` /
  `make vulncheck` instead, matching AGENTS.md.

Verified end-to-end: `make vulncheck`, `make deadcode`, and `make
lint-static` all run successfully and reach their tools (deadcode's
advisory report and lint-static's 35 pre-existing findings match the
PR's documented baseline).

Co-Authored-By: Claude Sonnet 5 <[email protected]>

* fix(build): support stock macOS make

---------

Co-authored-by: Claude Fable 5 <[email protected]>

2026-07-27 12:09:37 +08:00

3.6 KiB

Raw Permalink Blame History

Repository Guidelines for Zero

These instructions apply to all work in this repository. For the user-facing guide to extending Zero with specialists, hooks, plugins, MCP, and skills, see docs/EXTENDING.md.

1. Contribution and Pull Request Rules

Before opening any pull request, all contributors—including maintainers, community contributors, and coding agents—must read and follow CONTRIBUTING.md.
Community pull requests require an existing parent issue with the issue-approved label. Team members may open pull requests through the internal development process described in CONTRIBUTING.md.
Keep each change focused on the approved or assigned scope. Do not include unrelated fixes, refactors, formatting churn, generated output, or existing local changes in the same commit or pull request.
Discuss new implementation languages, runtimes, major dependency changes, and broad architectural rewrites with maintainers before implementation.
Pull request descriptions must explain what changed and why, link the parent issue when required, and list the tests or verification performed. Include screenshots or a short recording for user-visible UI changes when practical.

2. Repository and Implementation Conventions

Use the Go version declared in go.mod. Do not hardcode a different local toolchain version in scripts or documentation.
Use the repository build and release commands (make and go run ./cmd/zero-release ...) instead of inventing parallel build flows.
Keep tests beside their source files (foo_test.go next to foo.go). Add a regression test for behavior changes and run affected concurrent code under the race detector.
Never edit files under third_party/; they are vendored.
Prefer one cross-platform function with small conditional checks over duplicated platform-specific helpers when the behavior can remain unified.
Do not commit generated benchmark reports from internal/perfbench/reports/*.json; reports are configuration-specific evidence, not repository state.
Preserve the user's working tree. Do not overwrite, delete, stage, or commit unrelated tracked or untracked files.

3. Required Validation

Run validation from the repository root before committing, opening a pull request, or completing an implementation task:

Formatting check: make fmt-check. If it fails, format with go fmt ./... (or make fmt) and run the check again.
Vet: go vet ./... (or make vet).
Tests: go test ./.... Use make test for the full race-enabled suite, or run focused tests with -race, when concurrency is affected.
Build: go run ./cmd/zero-release build.
Smoke test: go run ./cmd/zero-release smoke.
Advisory lint: make lint-static.
Security: make vulncheck.
Diff hygiene: git diff HEAD --check (covers staged and unstaged tracked changes).

make lint currently runs the formatting check and go vet; it does not run golangci-lint. The pinned golangci-lint job is advisory in CI while the existing repository-wide backlog is cleaned up. Fix findings introduced by or related to the current change. Unrelated pre-existing advisory findings do not justify expanding a focused pull request; report them separately.

Formatting, vet, tests, build, smoke, diff hygiene, and govulncheck are hard requirements. If a related check fails, fix it. If a required check cannot run because of the environment or fails for an unrelated external reason, report the exact failure and obtain maintainer direction rather than silently ignoring it.

3.6 KiB Raw Permalink Blame History

Repository Guidelines for Zero

1. Contribution and Pull Request Rules

2. Repository and Implementation Conventions

3. Required Validation

3.6 KiB

Raw Permalink Blame History