Files
zero/internal/agent/command_prefix.go
euxaristiaandClaude Sonnet 5 97ef90d27a chore: remove code unreachable on every supported platform (#706)
* chore: remove code unreachable on every supported platform

The Security and code health job's advisory deadcode step reports 152
unreachable functions on main. Running the same check under GOOS=linux,
windows, and darwin shows 13 of those are false positives whose callers
live in windows build-tagged files, so only functions unreachable on all
three platforms are touched.

Functions with no references anywhere are deleted, including the
internal/reasoning package, which nothing imports. Functions that only
tests reference move into per-package export_test.go files so tests keep
their seams while the production binary sheds the code. Test call sites
of deleted convenience wrappers are ported to the live APIs (scoped tool
constructors, tools.DeferredSource, FinishReason checks).

Kept despite the report: cron.Store.Runs (only reader of runs.jsonl,
which production writes), and agenteval.TraceEventKeys and
MissingTraceEvents (used across packages by the trace contract test).

* docs(config): correct ValidateFile's errors.As claim

Message is a flattened string (.Error() already called on the parse
error), not a wrapped error, so callers can't recover the concrete
json error type via errors.As. Fix the comment to match.

Co-Authored-By: Claude Sonnet 5 <[email protected]>

* chore(trace,skills): drop obsolete Sink adapters and fix stale doc references

The dead-code pass removed the Emit methods but left Sink, NDJSONSink, and
TextSink exported with a contract nothing implements; remove the types with
their contract. Also remove the stray blank line at EOF of trace.go flagged
by gofmt, and update skills package docs and HOW_ZERO_WORKS.md to stop
directing callers to DiscoveryRoots/Duplicates, which are now test seams.

Co-Authored-By: Claude Fable 5 <[email protected]>

* chore: clean up remaining review nits on dead code removal

Replace a pointless fmt.Errorf(...%w...).Error() with fmt.Sprintf
using %v, since the wrapped error was discarded immediately anyway.
Remove a comment block that was duplicated verbatim.

* docs(skills): drop remaining references to test-only List/Get

Load and MergedSkills comments still named List/Get as production
entry points after they moved to export_test.go. Point callers at
Load and ListFromRoots instead.

* chore: remove now-unreferenced export_test.go seams

execSessionManager.len() and likelySandboxDenied/sandboxDenialKind had
no remaining callers after the sandbox unify-command-execution rebase;
the production code they wrapped for tests no longer exists.

---------

Co-authored-by: Claude Sonnet 5 <[email protected]>
2026-07-24 09:04:41 +08:00

504 lines
12 KiB
Go

package agent
import (
"fmt"
"runtime"
"strings"
"github.com/Gitlawb/zero/internal/sandbox"
"github.com/Gitlawb/zero/internal/tools"
"mvdan.cc/sh/v3/syntax"
)
func proposedCommandPrefix(toolName string, args map[string]any) []string {
if !isShellCommandTool(toolName) {
return nil
}
command, ok := firstStringArg(args, "command", "cmd", "script", "shell")
if !ok {
return nil
}
segments, ok := safeShellCommandSegments(command)
if !ok {
return nil
}
if requested, ok := requestedPrefixRule(args); ok {
if safeRequestedPrefixForSegments(requested, segments) {
return requested
}
return nil
}
// Only propose approving a prefix of one segment when every other segment
// in the command is independently known-safe. Once a prefix is approved,
// shellExecutionArgsForApproval escalates the whole command (every
// segment, not just the approved one) to bypass the sandbox, so offering a
// prefix that leaves an MSYS-prone (or otherwise unsafe) segment uncovered
// would let that segment run unsandboxed without ever being reviewed.
for index, tokens := range segments {
if knownSafeCommandSegment(tokens) {
continue
}
if !sandbox.ValidCommandPrefix(tokens) || !otherSegmentsKnownSafe(segments, index) {
return nil
}
return append([]string(nil), tokens...)
}
if len(segments) == 0 || !sandbox.ValidCommandPrefix(segments[0]) {
return nil
}
return append([]string(nil), segments[0]...)
}
// otherSegmentsKnownSafe reports whether every segment other than the one at
// skip is known-safe on its own.
func otherSegmentsKnownSafe(segments [][]string, skip int) bool {
for index, tokens := range segments {
if index == skip {
continue
}
if !knownSafeCommandSegment(tokens) {
return false
}
}
return true
}
func matchCommandPrefix(toolName string, args map[string]any, options Options) (sandbox.CommandPrefixGrant, bool, bool) {
if !isShellCommandTool(toolName) || options.Sandbox == nil {
return sandbox.CommandPrefixGrant{}, false, false
}
if shellCommandAdditionalPermissionsRequested(args) {
return sandbox.CommandPrefixGrant{}, false, false
}
command, ok := firstStringArg(args, "command", "cmd", "script", "shell")
if !ok {
return sandbox.CommandPrefixGrant{}, false, false
}
segments, ok := safeShellCommandSegments(command)
if !ok {
return sandbox.CommandPrefixGrant{}, false, false
}
var matched sandbox.CommandPrefixGrant
matchedAny := false
matchedSession := false
for _, tokens := range segments {
if grant, ok := options.Sandbox.LookupCommandPrefix(toolName, tokens); ok {
if !matchedAny {
matched = grant
}
matchedAny = true
continue
}
if grant, ok := options.Sandbox.LookupCommandPrefixForSession(toolName, tokens); ok {
if !matchedAny {
matched = grant
}
matchedAny = true
matchedSession = true
continue
}
if knownSafeCommandSegment(tokens) {
continue
}
return sandbox.CommandPrefixGrant{}, false, false
}
if matchedAny {
return matched, true, matchedSession
}
return sandbox.CommandPrefixGrant{}, false, false
}
func shellExecutionArgsForApproval(toolName string, args map[string]any, action PermissionDecisionAction, options Options) map[string]any {
if !isShellCommandTool(toolName) || !shellPrefixApprovalBypassesSandbox(action) {
return args
}
if options.Sandbox == nil || !options.Sandbox.UnsandboxedExecutionAllowed() {
return args
}
if shellCommandAdditionalPermissionsRequested(args) || shellCommandRequiresEscalated(args) {
return args
}
planned := cloneArgs(args)
if planned == nil {
planned = map[string]any{}
}
planned["sandbox_permissions"] = string(tools.SandboxPermissionsRequireEscalated)
return planned
}
func shellPrefixApprovalBypassesSandbox(action PermissionDecisionAction) bool {
return action == PermissionDecisionAllowPrefix || action == PermissionDecisionAlwaysAllowPrefix
}
func shellCommandRequiresEscalated(args map[string]any) bool {
raw, ok := args["sandbox_permissions"]
if !ok || raw == nil {
return false
}
value, ok := raw.(string)
if !ok {
value = fmt.Sprint(raw)
}
return strings.TrimSpace(value) == string(tools.SandboxPermissionsRequireEscalated)
}
func isShellCommandTool(toolName string) bool {
return toolName == "bash" || toolName == "exec_command"
}
func firstStringArg(args map[string]any, names ...string) (string, bool) {
for _, name := range names {
if raw, ok := args[name].(string); ok {
value := strings.TrimSpace(raw)
if value != "" {
return value, true
}
}
}
return "", false
}
func requestedPrefixRule(args map[string]any) ([]string, bool) {
raw, ok := args["prefix_rule"]
if !ok {
return nil, false
}
switch value := raw.(type) {
case []string:
return cleanPrefixRule(value), true
case []any:
out := make([]string, 0, len(value))
for _, item := range value {
part, ok := item.(string)
if !ok {
return nil, true
}
out = append(out, part)
}
return cleanPrefixRule(out), true
default:
return nil, true
}
}
func cleanPrefixRule(prefix []string) []string {
cleaned := make([]string, 0, len(prefix))
for _, part := range prefix {
part = strings.TrimSpace(part)
if part == "" {
return nil
}
cleaned = append(cleaned, part)
}
return cleaned
}
func safeRequestedPrefixForSegments(prefix []string, segments [][]string) bool {
if len(prefix) == 0 || !sandbox.ValidCommandPrefix(prefix) {
return false
}
matched := false
for _, command := range segments {
if len(prefix) > len(command) {
if knownSafeCommandSegment(command) {
continue
}
return false
}
if hasStringPrefix(command, prefix) {
matched = true
continue
}
if knownSafeCommandSegment(command) {
continue
}
return false
}
return matched
}
func safeShellCommandSegments(command string) ([][]string, bool) {
command = strings.TrimSpace(command)
if command == "" {
return nil, false
}
file, err := syntax.NewParser().Parse(strings.NewReader(command), "")
if err != nil || len(file.Stmts) == 0 {
return nil, false
}
segments := make([][]string, 0, len(file.Stmts))
for _, stmt := range file.Stmts {
if !collectSafeShellStatement(stmt, &segments) {
return nil, false
}
}
if len(segments) == 0 {
return nil, false
}
return segments, true
}
func collectSafeShellStatement(stmt *syntax.Stmt, segments *[][]string) bool {
if stmt == nil || stmt.Negated || stmt.Background || stmt.Coprocess || stmt.Disown || len(stmt.Redirs) > 0 {
return false
}
return collectSafeShellCommand(stmt.Cmd, segments)
}
func collectSafeShellCommand(cmd syntax.Command, segments *[][]string) bool {
switch node := cmd.(type) {
case *syntax.CallExpr:
tokens, ok := literalCallTokens(node)
if !ok {
return false
}
*segments = append(*segments, tokens)
return true
case *syntax.BinaryCmd:
switch node.Op {
case syntax.AndStmt, syntax.OrStmt, syntax.Pipe:
default:
return false
}
return collectSafeShellStatement(node.X, segments) && collectSafeShellStatement(node.Y, segments)
default:
return false
}
}
func literalCallTokens(call *syntax.CallExpr) ([]string, bool) {
if call == nil || len(call.Assigns) > 0 || len(call.Args) == 0 {
return nil, false
}
tokens := make([]string, 0, len(call.Args))
for _, word := range call.Args {
if len(word.Parts) != 1 {
return nil, false
}
lit, ok := word.Parts[0].(*syntax.Lit)
if !ok || strings.ContainsAny(lit.Value, "*?[]{}") {
return nil, false
}
tokens = append(tokens, lit.Value)
}
return tokens, true
}
func knownSafeCommandSegment(command []string) bool {
if len(command) == 0 {
return false
}
name := commandName(command[0])
if runtime.GOOS == "windows" && tools.MsysProneCommandName(name) {
return false
}
switch name {
case "cat", "cd", "cut", "echo", "expr", "false", "grep", "head", "id",
"ls", "nl", "paste", "pwd", "rev", "seq", "stat", "tail", "tr",
"true", "uname", "uniq", "wc", "which", "whoami":
return true
case "base64":
return safeBase64Command(command[1:])
case "find":
return safeFindCommand(command[1:])
case "rg":
return safeRipgrepCommand(command[1:])
case "sed":
return safeSedCommand(command[1:])
case "git":
return safeGitCommand(command)
default:
return false
}
}
func safeBase64Command(args []string) bool {
for _, arg := range args {
if arg == "-o" || arg == "--output" || strings.HasPrefix(arg, "--output=") || (strings.HasPrefix(arg, "-o") && arg != "-o") {
return false
}
}
return true
}
func safeFindCommand(args []string) bool {
unsafe := map[string]bool{
"-exec": true, "-execdir": true, "-ok": true, "-okdir": true,
"-delete": true,
"-fls": true, "-fprint": true, "-fprint0": true, "-fprintf": true,
}
for _, arg := range args {
if unsafe[arg] {
return false
}
}
return true
}
func safeRipgrepCommand(args []string) bool {
for _, arg := range args {
if arg == "--search-zip" || arg == "-z" || arg == "--pre" || arg == "--hostname-bin" ||
strings.HasPrefix(arg, "--pre=") || strings.HasPrefix(arg, "--hostname-bin=") {
return false
}
}
return true
}
func safeSedCommand(args []string) bool {
if len(args) < 2 || len(args) > 3 || args[0] != "-n" {
return false
}
return validSedPrintArg(args[1])
}
func validSedPrintArg(arg string) bool {
if !strings.HasSuffix(arg, "p") {
return false
}
body := strings.TrimSuffix(arg, "p")
if body == "" {
return false
}
for _, part := range strings.Split(body, ",") {
if part == "" {
return false
}
for _, r := range part {
if r < '0' || r > '9' {
return false
}
}
}
return true
}
func safeGitCommand(command []string) bool {
subIndex, subcommand, ok := gitSubcommand(command)
if !ok {
return false
}
if gitHasUnsafeGlobalOption(command[1:subIndex]) {
return false
}
args := command[subIndex+1:]
switch subcommand {
case "status", "log", "diff", "show":
return gitArgsReadOnly(args)
case "branch":
return gitArgsReadOnly(args) && gitBranchReadOnly(args)
default:
return false
}
}
func gitSubcommand(command []string) (int, string, bool) {
for index := 1; index < len(command); index++ {
arg := command[index]
if gitOptionConsumesValue(arg) {
index++
continue
}
if gitOptionHasInlineValue(arg) || arg == "--" || strings.HasPrefix(arg, "-") {
continue
}
switch arg {
case "status", "log", "diff", "show", "branch":
return index, arg, true
default:
return 0, "", false
}
}
return 0, "", false
}
func gitOptionConsumesValue(arg string) bool {
switch arg {
case "-C", "-c", "--config-env", "--exec-path", "--git-dir", "--namespace", "--super-prefix", "--work-tree":
return true
default:
return false
}
}
func gitOptionHasInlineValue(arg string) bool {
return strings.HasPrefix(arg, "--config-env=") ||
strings.HasPrefix(arg, "--exec-path=") ||
strings.HasPrefix(arg, "--git-dir=") ||
strings.HasPrefix(arg, "--namespace=") ||
strings.HasPrefix(arg, "--super-prefix=") ||
strings.HasPrefix(arg, "--work-tree=") ||
((strings.HasPrefix(arg, "-C") || strings.HasPrefix(arg, "-c")) && len(arg) > 2)
}
func gitHasUnsafeGlobalOption(args []string) bool {
for index := 0; index < len(args); index++ {
arg := args[index]
switch {
case strings.HasPrefix(arg, "--upload-pack"):
return true
case arg == "-C" || strings.HasPrefix(arg, "-C"):
return true
case gitOptionConsumesValue(arg):
index++
}
}
return false
}
func gitArgsReadOnly(args []string) bool {
for _, arg := range args {
switch {
case strings.HasPrefix(arg, "--output="), strings.HasPrefix(arg, "--exec="):
return false
case arg == "--output", arg == "--exec":
return false
}
}
return true
}
func gitBranchReadOnly(args []string) bool {
if len(args) == 0 {
return true
}
for _, arg := range args {
if strings.HasPrefix(arg, "--format=") {
continue
}
switch arg {
case "--list", "-l", "--show-current", "-a", "--all", "-r", "--remotes", "-v", "-vv", "--verbose":
continue
default:
return false
}
}
return true
}
func commandName(raw string) string {
name := strings.TrimSpace(raw)
if index := strings.LastIndexAny(name, `/\`); index >= 0 {
name = name[index+1:]
}
name = strings.ToLower(name)
for _, suffix := range []string{".exe", ".cmd", ".bat", ".com"} {
if strings.HasSuffix(name, suffix) {
return strings.TrimSuffix(name, suffix)
}
}
return name
}
func hasStringPrefix(values []string, prefix []string) bool {
if len(prefix) == 0 || len(prefix) > len(values) {
return false
}
for index := range prefix {
if values[index] != prefix[index] {
return false
}
}
return true
}