Files
zero/internal/agenteval/agent_command.go
euxaristiaandClaude Sonnet 5 97ef90d27a chore: remove code unreachable on every supported platform (#706)
* chore: remove code unreachable on every supported platform

The Security and code health job's advisory deadcode step reports 152
unreachable functions on main. Running the same check under GOOS=linux,
windows, and darwin shows 13 of those are false positives whose callers
live in windows build-tagged files, so only functions unreachable on all
three platforms are touched.

Functions with no references anywhere are deleted, including the
internal/reasoning package, which nothing imports. Functions that only
tests reference move into per-package export_test.go files so tests keep
their seams while the production binary sheds the code. Test call sites
of deleted convenience wrappers are ported to the live APIs (scoped tool
constructors, tools.DeferredSource, FinishReason checks).

Kept despite the report: cron.Store.Runs (only reader of runs.jsonl,
which production writes), and agenteval.TraceEventKeys and
MissingTraceEvents (used across packages by the trace contract test).

* docs(config): correct ValidateFile's errors.As claim

Message is a flattened string (.Error() already called on the parse
error), not a wrapped error, so callers can't recover the concrete
json error type via errors.As. Fix the comment to match.

Co-Authored-By: Claude Sonnet 5 <[email protected]>

* chore(trace,skills): drop obsolete Sink adapters and fix stale doc references

The dead-code pass removed the Emit methods but left Sink, NDJSONSink, and
TextSink exported with a contract nothing implements; remove the types with
their contract. Also remove the stray blank line at EOF of trace.go flagged
by gofmt, and update skills package docs and HOW_ZERO_WORKS.md to stop
directing callers to DiscoveryRoots/Duplicates, which are now test seams.

Co-Authored-By: Claude Fable 5 <[email protected]>

* chore: clean up remaining review nits on dead code removal

Replace a pointless fmt.Errorf(...%w...).Error() with fmt.Sprintf
using %v, since the wrapped error was discarded immediately anyway.
Remove a comment block that was duplicated verbatim.

* docs(skills): drop remaining references to test-only List/Get

Load and MergedSkills comments still named List/Get as production
entry points after they moved to export_test.go. Point callers at
Load and ListFromRoots instead.

* chore: remove now-unreferenced export_test.go seams

execSessionManager.len() and likelySandboxDenied/sandboxDenialKind had
no remaining callers after the sandbox unify-command-execution rebase;
the production code they wrapped for tests no longer exists.

---------

Co-authored-by: Claude Sonnet 5 <[email protected]>
2026-07-24 09:04:41 +08:00

136 lines
3.6 KiB
Go

package agenteval
import (
"bytes"
"context"
"errors"
"os/exec"
"strings"
)
type AgentRunInput struct {
TaskID string
Prompt string
WorkspacePath string
Model string
}
type AgentRunResult struct {
ExitCode int `json:"exitCode"`
Stdout string `json:"stdout,omitempty"`
Stderr string `json:"stderr,omitempty"`
Error string `json:"error,omitempty"`
// Truncated is set when captured stdout/stderr exceeded the runner's
// OutputLimit and some output was dropped.
Truncated bool `json:"truncated,omitempty"`
}
type AgentRunner interface {
Run(context.Context, AgentRunInput) AgentRunResult
}
type AgentRunnerFunc func(context.Context, AgentRunInput) AgentRunResult
// defaultAgentOutputLimit caps captured stdout/stderr per stream so a chatty or
// runaway agent cannot exhaust memory or bloat the benchmark report.
const defaultAgentOutputLimit = 1 << 20 // 1 MiB per stream
type CommandAgentRunner struct {
Command []string
// OutputLimit caps captured stdout/stderr per stream in bytes. Zero applies
// defaultAgentOutputLimit; a negative value disables the cap.
OutputLimit int
}
func (runner CommandAgentRunner) Run(ctx context.Context, input AgentRunInput) AgentRunResult {
result := AgentRunResult{ExitCode: -1}
if len(runner.Command) == 0 || strings.TrimSpace(runner.Command[0]) == "" {
result.Error = "agent command is required"
return result
}
if strings.TrimSpace(input.WorkspacePath) == "" {
result.Error = "workspace path is required"
return result
}
if ctx == nil {
ctx = context.Background()
}
limit := runner.OutputLimit
if limit == 0 {
limit = defaultAgentOutputLimit
}
command := expandAgentCommand(runner.Command, input)
cmd := exec.CommandContext(ctx, command[0], command[1:]...)
cmd.Dir = input.WorkspacePath
stdout := &capWriter{limit: limit}
stderr := &capWriter{limit: limit}
cmd.Stdout = stdout
cmd.Stderr = stderr
err := cmd.Run()
result.Stdout = stdout.buf.String()
result.Stderr = stderr.buf.String()
result.Truncated = stdout.truncated || stderr.truncated
if err == nil {
result.ExitCode = 0
return result
}
// A canceled or timed-out context kills the process, surfacing as a signal
// exit; report the context error explicitly instead of "exited with code -1".
if ctxErr := ctx.Err(); ctxErr != nil {
result.Error = ctxErr.Error()
return result
}
var exitErr *exec.ExitError
if errors.As(err, &exitErr) {
result.ExitCode = exitErr.ExitCode()
return result
}
result.Error = err.Error()
return result
}
func expandAgentCommand(command []string, input AgentRunInput) []string {
// strings.NewReplacer performs a single left-to-right pass and never
// re-scans replaced text, so a placeholder value that itself contains
// "{workspace}"/"{task_id}"/"{model}" is not re-expanded.
replacer := strings.NewReplacer(
"{prompt}", input.Prompt,
"{workspace}", input.WorkspacePath,
"{task_id}", input.TaskID,
"{model}", input.Model,
)
expanded := make([]string, len(command))
for i, arg := range command {
expanded[i] = replacer.Replace(arg)
}
return expanded
}
// capWriter buffers writes up to limit bytes and records whether any data was
// dropped. A non-positive limit means unbounded.
type capWriter struct {
buf bytes.Buffer
limit int
truncated bool
}
func (w *capWriter) Write(p []byte) (int, error) {
if w.limit <= 0 {
return w.buf.Write(p)
}
remaining := w.limit - w.buf.Len()
if remaining <= 0 {
w.truncated = true
return len(p), nil
}
if len(p) > remaining {
if _, err := w.buf.Write(p[:remaining]); err != nil {
return 0, err
}
w.truncated = true
return len(p), nil
}
return w.buf.Write(p)
}