mirror of
https://github.com/Twigpine/zero.git
synced 2026-11-09 05:19:33 -10:00
Pujitha PaladuguandPujitha Paladugu
d76f7f6931
Motivation: scripts/action-summary.mjs is invoked by the composite action in action.yml on every action run, and ships with a 12-test suite in scripts/action-summary.test.mjs. Neither the action-smoke workflow nor the main Go-focused ci.yml executed that suite, and the action-smoke workflow's paths filters did not even include those two script files, so a change to the helper or its tests triggered no CI job at all. Approach: add scripts/action-summary.mjs and scripts/action-summary.test.mjs to both the pull_request and push paths filters in .github/workflows/zero-action-smoke.yml, and add a Setup Node (actions/setup-node, node-version 24, matching the pin already used in release-artifacts.yml) step followed by a `node --test scripts/action-summary.test.mjs` step in the validate job, ahead of the existing action.yml validation steps. Validation: - `node --test scripts/action-summary.test.mjs` passes locally: 12/12 tests pass (Node v22.23.1; repo engines field requires >=18, CI pins 24). - Broke an assertion in a scratch copy of the test file outside the repo and reran `node --test`: 1 test failed and the process exited non-zero, confirming the new CI step actually gates on failures as the issue requires. - `python3 -c "import yaml; yaml.safe_load(...)"` confirms the edited workflow YAML still parses. - Confirmed .github/workflows/ci.yml has no Node step (Go-only pipeline), so zero-action-smoke.yml is the correct integration point. - Base branch CI (upstream/main) is currently green. Report: https://github.com/Gitlawb/zero/issues/1030 Assisted-by: claude-sonnet-5 (via Claude Code) Signed-off-by: Pujitha Paladugu <[email protected]> Co-authored-by: Pujitha Paladugu <[email protected]>