mirror of
https://github.com/Twigpine/zero.git
synced 2026-11-10 05:01:28 -10:00
PierrunoYTandClaude Sonnet 5
9043baedcf
* fix(sandbox): scrub dynamic credential env vars * fix(sandbox): tolerate env assignments in configured sensitive keys A config value mistakenly given as a full assignment (e.g. "COMPANY_LLM_SECRET=...") would never match the real env key during scrubbing, silently re-exposing the credential to sandboxed commands. normalizeSensitiveEnvKeys now keeps only the name part before '=' and re-trims it, per PR review. Co-Authored-By: Claude Fable 5 <[email protected]> * fix(sandbox): scrub credentials on direct/degraded command plans directCommandPlan (used when the native sandbox backend is unavailable, disabled, or not required, including the EnforcementDegraded fallback) left Env nil whenever spec.Env was nil, so exec.Cmd inherited the full caller environment unscrubbed. Configured apiKeyEnv credentials and dynamically named ZERO_OAUTH_<NAME>_CLIENT_SECRET variables leaked through that path even though the wrapped sandbox plans already scrubbed them. Route direct plans through scrubSensitiveEnv the same way wrapped plans do, snapshotting os.Environ() when spec.Env is nil so scrubbing still applies. Adds a regression test covering the degraded-fallback path with both a configured and a dynamically named secret. Co-Authored-By: Claude Sonnet 5 <[email protected]> --------- Co-authored-by: Claude Fable 5 <[email protected]>
24 lines
675 B
Go
24 lines
675 B
Go
package cli
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/Gitlawb/zero/internal/config"
|
|
)
|
|
|
|
func TestProviderSensitiveEnvKeys(t *testing.T) {
|
|
resolved := config.ResolvedConfig{
|
|
Providers: []config.ProviderProfile{
|
|
{Name: "custom", APIKeyEnv: " COMPANY_LLM_SECRET "},
|
|
{Name: "catalog", APIKeyEnv: "OPENAI_API_KEY"},
|
|
{Name: "inline"},
|
|
},
|
|
Provider: config.ProviderProfile{Name: "active", APIKeyEnv: "ACTIVE_PROVIDER_SECRET"},
|
|
}
|
|
want := []string{"COMPANY_LLM_SECRET", "OPENAI_API_KEY", "ACTIVE_PROVIDER_SECRET"}
|
|
if got := providerSensitiveEnvKeys(resolved); !reflect.DeepEqual(got, want) {
|
|
t.Fatalf("providerSensitiveEnvKeys() = %v, want %v", got, want)
|
|
}
|
|
}
|