zero/internal/tools/argtolerance_test.go

package tools

import (
	"context"
	"math"
	"os"
	"path/filepath"
	"strings"
	"testing"
)

// --- shared helper unit tests -------------------------------------------------

func TestAliasedStringArgPrefersPrimaryThenAliases(t *testing.T) {
	// primary present wins over aliases.
	got, err := aliasedStringArg(map[string]any{"path": "primary", "file": "alias"}, []string{"path", "file"}, "", true, false)
	if err != nil {
		t.Fatalf("unexpected error: %v", err)
	}
	if got != "primary" {
		t.Fatalf("expected primary value, got %q", got)
	}

	// primary missing -> first present alias is used.
	got, err = aliasedStringArg(map[string]any{"file": "alias"}, []string{"path", "file", "file_path"}, "", true, false)
	if err != nil {
		t.Fatalf("unexpected error: %v", err)
	}
	if got != "alias" {
		t.Fatalf("expected alias value, got %q", got)
	}

	// alias order is respected: first matching alias in the list wins.
	got, err = aliasedStringArg(map[string]any{"filename": "second", "file": "first"}, []string{"path", "file", "filename"}, "", true, false)
	if err != nil {
		t.Fatalf("unexpected error: %v", err)
	}
	if got != "first" {
		t.Fatalf("expected first alias by list order, got %q", got)
	}
}

func TestAliasedStringArgMissingRequiredUsesPrimaryKeyInError(t *testing.T) {
	_, err := aliasedStringArg(map[string]any{}, []string{"path", "file"}, "", true, false)
	if err == nil || err.Error() != "path is required" {
		t.Fatalf("expected \"path is required\", got %v", err)
	}
}

func TestAliasedStringArgMissingOptionalUsesFallback(t *testing.T) {
	got, err := aliasedStringArg(map[string]any{}, []string{"cwd", "dir"}, ".", false, false)
	if err != nil {
		t.Fatalf("unexpected error: %v", err)
	}
	if got != "." {
		t.Fatalf("expected fallback, got %q", got)
	}
}

func TestAliasedStringArgPresentNonStringErrorsWithPrimaryKey(t *testing.T) {
	// Type-strictness is preserved: a present-but-non-string under ANY matched key
	// errors using the PRIMARY key name, not the alias.
	_, err := aliasedStringArg(map[string]any{"file": 42}, []string{"path", "file"}, "", true, false)
	if err == nil || err.Error() != "path must be a string" {
		t.Fatalf("expected \"path must be a string\", got %v", err)
	}
}

func TestAliasedStringArgEmptySemantics(t *testing.T) {
	// allowEmpty=false rejects an empty string.
	_, err := aliasedStringArg(map[string]any{"path": ""}, []string{"path"}, "", true, false)
	if err == nil || err.Error() != "path must be a non-empty string" {
		t.Fatalf("expected non-empty error, got %v", err)
	}
	// allowEmpty=true accepts an empty string.
	got, err := aliasedStringArg(map[string]any{"path": ""}, []string{"path"}, "fallback", true, true)
	if err != nil {
		t.Fatalf("unexpected error: %v", err)
	}
	if got != "" {
		t.Fatalf("expected empty string preserved, got %q", got)
	}
}

func TestAliasedStringArgAllowEmptySkipsEmptyPrimaryForPopulatedAlias(t *testing.T) {
	// allowEmpty=true: an empty PRIMARY value must NOT mask a populated alias.
	// {"content":"","text":"hi"} -> "hi" (write_file content/text data loss).
	got, err := aliasedStringArg(map[string]any{"content": "", "text": "hi"}, []string{"content", "contents", "text", "body", "data", "file_content"}, "", true, true)
	if err != nil {
		t.Fatalf("unexpected error: %v", err)
	}
	if got != "hi" {
		t.Fatalf("expected populated alias to win over empty primary, got %q", got)
	}

	// {"path":"","file":"x"} -> "x" (list_directory/glob wrong dir).
	got, err = aliasedStringArg(map[string]any{"path": "", "file": "x"}, []string{"path", "file", "file_path"}, ".", false, true)
	if err != nil {
		t.Fatalf("unexpected error: %v", err)
	}
	if got != "x" {
		t.Fatalf("expected populated alias to win over empty primary, got %q", got)
	}

	// allowEmpty=true: when EVERY key is present-but-empty, return "" (preserving
	// the existing empty-string-preserved contract, NOT the fallback).
	got, err = aliasedStringArg(map[string]any{"path": "", "file": ""}, []string{"path", "file"}, "fallback", false, true)
	if err != nil {
		t.Fatalf("unexpected error: %v", err)
	}
	if got != "" {
		t.Fatalf("expected empty when all keys empty, got %q", got)
	}

	// allowEmpty=true, required=true: all keys present-but-empty still returns ""
	// (must not regress TestAliasedStringArgEmptySemantics).
	got, err = aliasedStringArg(map[string]any{"path": ""}, []string{"path"}, "fallback", true, true)
	if err != nil {
		t.Fatalf("unexpected error: %v", err)
	}
	if got != "" {
		t.Fatalf("expected empty preserved for sole empty key, got %q", got)
	}
}

func TestCoerceStringSliceShapes(t *testing.T) {
	// []string passes through.
	if got := coerceStringSlice([]string{"a", "b"}); len(got) != 2 || got[0] != "a" || got[1] != "b" {
		t.Fatalf("[]string = %v", got)
	}
	// []any of strings/scalars/objects.
	got := coerceStringSlice([]any{
		"plain",
		42.0,
		map[string]any{"label": "Modern"},
		map[string]any{"value": "Classic"},
	})
	if len(got) != 4 || got[0] != "plain" || got[1] != "42" || got[2] != "Modern" || got[3] != "Classic" {
		t.Fatalf("[]any = %v", got)
	}
	// newline-delimited string.
	if got := coerceStringSlice("A\r\nB\n\nC"); len(got) != 3 || got[0] != "A" || got[1] != "B" || got[2] != "C" {
		t.Fatalf("string = %v", got)
	}
	// nil -> nil, never errors.
	if got := coerceStringSlice(nil); got != nil {
		t.Fatalf("nil = %v", got)
	}
}

// --- per-tool alias acceptance tests -----------------------------------------

func TestReadFileToolAcceptsPathAliases(t *testing.T) {
	root := t.TempDir()
	writeTestFile(t, filepath.Join(root, "notes.txt"), "alpha\nbeta")
	for _, key := range []string{"file", "file_path", "filepath", "filename"} {
		res := NewReadFileTool(root).Run(context.Background(), map[string]any{key: "notes.txt"})
		if res.Status != StatusOK {
			t.Fatalf("alias %q: expected ok, got %s: %s", key, res.Status, res.Output)
		}
		if !strings.Contains(res.Output, "alpha") {
			t.Fatalf("alias %q: expected file contents, got %q", key, res.Output)
		}
	}
}

func TestListDirectoryToolAcceptsDirAliases(t *testing.T) {
	root := t.TempDir()
	writeTestFile(t, filepath.Join(root, "sub", "x.txt"), "data")
	for _, key := range []string{"directory", "dir"} {
		res := NewListDirectoryTool(root).Run(context.Background(), map[string]any{key: "sub"})
		if res.Status != StatusOK {
			t.Fatalf("alias %q: expected ok, got %s: %s", key, res.Status, res.Output)
		}
		if !strings.Contains(res.Output, "x.txt") {
			t.Fatalf("alias %q: expected listing, got %q", key, res.Output)
		}
	}
}

func TestGlobToolAcceptsPatternAndCwdAliases(t *testing.T) {
	root := t.TempDir()
	writeTestFile(t, filepath.Join(root, "sub", "a.go"), "package sub")
	// pattern aliases
	for _, key := range []string{"glob", "match", "query", "expression"} {
		res := NewGlobTool(root).Run(context.Background(), map[string]any{key: "**/*.go"})
		if res.Status != StatusOK {
			t.Fatalf("pattern alias %q: expected ok, got %s: %s", key, res.Status, res.Output)
		}
		if !strings.Contains(res.Output, "sub/a.go") {
			t.Fatalf("pattern alias %q: expected match, got %q", key, res.Output)
		}
	}
	// cwd aliases (scope the scan to sub/)
	for _, key := range []string{"dir", "directory", "path"} {
		res := NewGlobTool(root).Run(context.Background(), map[string]any{"pattern": "*.go", key: "sub"})
		if res.Status != StatusOK {
			t.Fatalf("cwd alias %q: expected ok, got %s: %s", key, res.Status, res.Output)
		}
		if strings.TrimSpace(res.Output) != "a.go" {
			t.Fatalf("cwd alias %q: expected a.go scoped match, got %q", key, res.Output)
		}
	}
}

func TestGrepToolAcceptsPatternAndPathAliases(t *testing.T) {
	root := t.TempDir()
	writeTestFile(t, filepath.Join(root, "sub", "main.go"), "func main() {}\n")
	for _, key := range []string{"query", "regex", "search", "expression"} {
		res := NewGrepTool(root).Run(context.Background(), map[string]any{key: "func main"})
		if res.Status != StatusOK {
			t.Fatalf("pattern alias %q: expected ok, got %s: %s", key, res.Status, res.Output)
		}
		if !strings.Contains(res.Output, "func main") {
			t.Fatalf("pattern alias %q: expected hit, got %q", key, res.Output)
		}
	}
	for _, key := range []string{"dir", "directory"} {
		res := NewGrepTool(root).Run(context.Background(), map[string]any{"pattern": "func main", key: "sub"})
		if res.Status != StatusOK {
			t.Fatalf("path alias %q: expected ok, got %s: %s", key, res.Status, res.Output)
		}
		if !strings.Contains(res.Output, "main.go") {
			t.Fatalf("path alias %q: expected hit, got %q", key, res.Output)
		}
	}
}

func TestOptionalPathArgsTreatEmptyAsDefault(t *testing.T) {
	// Weak models sometimes send an explicit empty path/cwd. These optional
	// path args should fall back to "." (workspace root) just as if the key
	// were absent, rather than erroring with "must be a non-empty string".
	root := t.TempDir()
	writeTestFile(t, filepath.Join(root, "main.go"), "func main() {}\n")

	grepRes := NewGrepTool(root).Run(context.Background(), map[string]any{"pattern": "func main", "path": ""})
	if grepRes.Status != StatusOK {
		t.Fatalf("grep path:\"\" expected ok, got %s: %s", grepRes.Status, grepRes.Output)
	}
	if !strings.Contains(grepRes.Output, "main.go") {
		t.Fatalf("grep path:\"\" expected hit, got %q", grepRes.Output)
	}

	globRes := NewGlobTool(root).Run(context.Background(), map[string]any{"pattern": "**/*.go", "cwd": ""})
	if globRes.Status != StatusOK {
		t.Fatalf("glob cwd:\"\" expected ok, got %s: %s", globRes.Status, globRes.Output)
	}
	if !strings.Contains(globRes.Output, "main.go") {
		t.Fatalf("glob cwd:\"\" expected match, got %q", globRes.Output)
	}

	listRes := NewListDirectoryTool(root).Run(context.Background(), map[string]any{"path": ""})
	if listRes.Status != StatusOK {
		t.Fatalf("list_directory path:\"\" expected ok, got %s: %s", listRes.Status, listRes.Output)
	}
	if !strings.Contains(listRes.Output, "main.go") {
		t.Fatalf("list_directory path:\"\" expected listing, got %q", listRes.Output)
	}
}

func TestWriteFileToolAcceptsPathAliases(t *testing.T) {
	root := t.TempDir()
	for _, key := range []string{"file", "file_path", "filename"} {
		res := NewWriteFileTool(root).Run(context.Background(), map[string]any{key: key + ".txt", "content": "x"})
		if res.Status != StatusOK {
			t.Fatalf("path alias %q: expected ok, got %s: %s", key, res.Status, res.Output)
		}
		if _, err := os.Stat(filepath.Join(root, key+".txt")); err != nil {
			t.Fatalf("path alias %q: expected file written: %v", key, err)
		}
	}
}

func TestEditFileToolAcceptsAliases(t *testing.T) {
	root := t.TempDir()
	path := filepath.Join(root, "code.go")
	writeTestFile(t, path, "const a = 1\n")
	// path/old/new aliases all at once.
	res := NewEditFileTool(root).Run(context.Background(), map[string]any{
		"file": "code.go",
		"old":  "const a = 1",
		"new":  "const a = 2",
	})
	if res.Status != StatusOK {
		t.Fatalf("expected ok, got %s: %s", res.Status, res.Output)
	}
	got, _ := os.ReadFile(path)
	if string(got) != "const a = 2\n" {
		t.Fatalf("edit via aliases = %q", got)
	}

	// other alias spellings for old_string/new_string.
	writeTestFile(t, path, "const a = 1\n")
	res = NewEditFileTool(root).Run(context.Background(), map[string]any{
		"file_path": "code.go",
		"search":    "const a = 1",
		"replace":   "const a = 3",
	})
	if res.Status != StatusOK {
		t.Fatalf("expected ok, got %s: %s", res.Status, res.Output)
	}
	got, _ = os.ReadFile(path)
	if string(got) != "const a = 3\n" {
		t.Fatalf("edit via search/replace aliases = %q", got)
	}
}

func TestApplyPatchToolAcceptsDiffAlias(t *testing.T) {
	root := t.TempDir()
	writeTestFile(t, filepath.Join(root, "hello.txt"), "hello\nold\n")
	patch := strings.Join([]string{
		"diff --git a/hello.txt b/hello.txt",
		"--- a/hello.txt",
		"+++ b/hello.txt",
		"@@ -1,2 +1,2 @@",
		" hello",
		"-old",
		"+new",
		"",
	}, "\n")
	res := NewApplyPatchTool(root).Run(context.Background(), map[string]any{"diff": patch})
	if res.Status != StatusOK {
		if gitApplyUnavailable(res.Output) {
			t.Skipf("git binary unavailable: %s", res.Output)
		}
		t.Fatalf("apply_patch via diff alias failed (possible regression): %s", res.Output)
	}
	got, _ := os.ReadFile(filepath.Join(root, "hello.txt"))
	if strings.ReplaceAll(string(got), "\r\n", "\n") != "hello\nnew\n" {
		t.Fatalf("diff alias patched content = %q", got)
	}
}

func TestBashToolAcceptsCommandAliases(t *testing.T) {
	root := t.TempDir()
	for _, key := range []string{"cmd", "script", "shell"} {
		res := NewBashTool(root).Run(context.Background(), map[string]any{key: "echo hi"})
		if res.Status != StatusOK {
			t.Fatalf("command alias %q: expected ok, got %s: %s", key, res.Status, res.Output)
		}
		if !strings.Contains(res.Output, "hi") {
			t.Fatalf("command alias %q: expected echo output, got %q", key, res.Output)
		}
	}
}

func TestBoolArgCoercesModelVariants(t *testing.T) {
	tru := []any{true, "true", "True", "yes", "on", "1", 1.0, 1}
	for _, v := range tru {
		if got, err := boolArg(map[string]any{"overwrite": v}, "overwrite", false); err != nil || !got {
			t.Errorf("boolArg(%v=%T) = %v,%v; want true", v, v, got, err)
		}
	}
	fal := []any{false, "false", "no", "off", "0", 0.0}
	for _, v := range fal {
		if got, err := boolArg(map[string]any{"overwrite": v}, "overwrite", true); err != nil || got {
			t.Errorf("boolArg(%v=%T) = %v,%v; want false", v, v, got, err)
		}
	}
	// genuinely uncoercible still errors
	if _, err := boolArg(map[string]any{"overwrite": []any{1}}, "overwrite", false); err == nil {
		t.Error("array should not coerce to bool")
	}
}

func TestIntArgCoercesStringNumbers(t *testing.T) {
	if got, err := intArg(map[string]any{"n": "5"}, "n", 0, 1, 0); err != nil || got != 5 {
		t.Fatalf("intArg(\"5\") = %d,%v; want 5", got, err)
	}
	if got, err := intArg(map[string]any{"n": "7.0"}, "n", 0, 1, 0); err != nil || got != 7 {
		t.Fatalf("intArg(\"7.0\") = %d,%v; want 7", got, err)
	}
	if _, err := intArg(map[string]any{"n": "abc"}, "n", 0, 1, 0); err == nil {
		t.Error("non-numeric string should error")
	}
	// Fail closed on non-finite / non-integral floats (and their string forms)
	// before an implementation-defined cast.
	if _, err := intArg(map[string]any{"n": math.NaN()}, "n", 0, 0, 0); err == nil {
		t.Error("NaN float should error")
	}
	if _, err := intArg(map[string]any{"n": math.Inf(1)}, "n", 0, 0, 0); err == nil {
		t.Error("+Inf float should error")
	}
	if _, err := intArg(map[string]any{"n": "NaN"}, "n", 0, 0, 0); err == nil {
		t.Error("NaN string should error")
	}
	if _, err := intArg(map[string]any{"n": 5.5}, "n", 0, 0, 0); err == nil {
		t.Error("non-integral float should error")
	}
	// Exactly 2^63 is out of int64 range: float64(MaxInt) rounds up to it, so the
	// guard must reject it (float and string forms) rather than cast.
	if _, err := intArg(map[string]any{"n": 9223372036854775808.0}, "n", 0, 0, 0); err == nil {
		t.Error("2^63 float should error (out of int64 range)")
	}
	if _, err := intArg(map[string]any{"n": "9223372036854775808"}, "n", 0, 0, 0); err == nil {
		t.Error("2^63 string should error (out of int64 range)")
	}
}

func TestWriteFileAcceptsStringOverwrite(t *testing.T) {
	root := t.TempDir()
	if err := os.WriteFile(filepath.Join(root, "shop.html"), []byte("old"), 0o644); err != nil {
		t.Fatal(err)
	}
	// minimax-style: overwrite as the string "true".
	res := NewWriteFileTool(root).Run(context.Background(), map[string]any{
		"path": "shop.html", "content": "new", "overwrite": "true",
	})
	if res.Status != StatusOK {
		t.Fatalf("string overwrite should be accepted, got %s: %s", res.Status, res.Output)
	}
	got, _ := os.ReadFile(filepath.Join(root, "shop.html"))
	if string(got) != "new" {
		t.Fatalf("expected overwrite to replace content, got %q", got)
	}
}