zero/internal/cli/setup_verify_test.go

package cli

import (
	"bytes"
	"context"
	"path/filepath"
	"strings"
	"testing"

	"github.com/Twigpine/zero/internal/config"
	"github.com/Twigpine/zero/internal/providerhealth"
	"github.com/Twigpine/zero/internal/tui"
)

func TestFormatSetupCompleteIncludesTryThisExample(t *testing.T) {
	out := formatSetupComplete(tui.SetupResult{
		ConfigPath: "/home/u/.config/zero/config.json",
		Provider: config.ProviderProfile{
			Name:         "openai",
			ProviderKind: config.ProviderKindOpenAI,
			APIKey:       "sk-x",
			Model:        "gpt-4.1",
		},
	})
	if !strings.Contains(out, "Zero setup complete") {
		t.Fatalf("missing completion header: %q", out)
	}
	// The working-state confirmation must include a concrete one-line "try this"
	// example so the user can immediately verify a real run.
	if !strings.Contains(out, `zero exec "`) || !strings.Contains(out, "--model gpt-4.1") {
		t.Fatalf("missing try-this exec example: %q", out)
	}
}

func TestRunSetupVerifyReportsClassifiedProbeFailure(t *testing.T) {
	t.Setenv("OPENAI_API_KEY", "sk-test") // a key is present, so --verify reaches the probe (not the no-key short-circuit)
	var stdout, stderr bytes.Buffer
	configPath := filepath.Join(t.TempDir(), "config.json")
	probed := false
	deps := appDeps{
		userConfigPath: func() (string, error) { return configPath, nil },
		probeProviderHealth: func(_ context.Context, options providerhealth.Options) providerhealth.Result {
			probed = true
			if !options.Connectivity {
				t.Fatalf("setup --verify must request a connectivity probe")
			}
			return providerhealth.Result{
				Status: providerhealth.StatusFail,
				Checks: []providerhealth.Check{
					{ID: "provider.connectivity", Status: providerhealth.StatusFail, Category: providerhealth.CategoryAuth, Message: "Provider endpoint returned 401: invalid api key"},
				},
			}
		},
	}

	exitCode := runWithDeps([]string{"setup", "openai", "--api-key-env", "OPENAI_API_KEY", "--verify"}, &stdout, &stderr, deps)

	if !probed {
		t.Fatalf("expected setup --verify to run a probe")
	}
	if exitCode != exitProvider {
		t.Fatalf("exit code = %d, want %d (a failed probe is a provider error)", exitCode, exitProvider)
	}
	output := stderr.String()
	// The failure must be specific and fixable, not a stack trace.
	if !strings.Contains(strings.ToLower(output), "api key") {
		t.Fatalf("expected a fixable auth remedy on stderr, got %q", output)
	}
}

func TestRunSetupVerifySucceedsAndConfirmsWorking(t *testing.T) {
	t.Setenv("OPENAI_API_KEY", "sk-test") // a key is present, so --verify reaches the probe (not the no-key short-circuit)
	var stdout, stderr bytes.Buffer
	configPath := filepath.Join(t.TempDir(), "config.json")
	deps := appDeps{
		userConfigPath: func() (string, error) { return configPath, nil },
		probeProviderHealth: func(context.Context, providerhealth.Options) providerhealth.Result {
			return providerhealth.Result{
				Status: providerhealth.StatusPass,
				Checks: []providerhealth.Check{
					{ID: "provider.connectivity", Status: providerhealth.StatusPass, Message: "reachable"},
				},
			}
		},
	}

	exitCode := runWithDeps([]string{"setup", "openai", "--api-key-env", "OPENAI_API_KEY", "--verify"}, &stdout, &stderr, deps)

	if exitCode != exitSuccess {
		t.Fatalf("exit code = %d, want %d: %s", exitCode, exitSuccess, stderr.String())
	}
	out := stdout.String()
	if !strings.Contains(out, "Zero setup complete") {
		t.Fatalf("missing completion header: %q", out)
	}
	if !strings.Contains(strings.ToLower(out), "verified") && !strings.Contains(strings.ToLower(out), "reachable") {
		t.Fatalf("a passing probe should confirm the provider is verified/reachable, got %q", out)
	}
}

func TestVerifySetupProviderWithoutProbeIsNotVerified(t *testing.T) {
	// When no probe is wired, the verification did not run. It must report Ran=false
	// (and not OK=true), so the caller never claims the provider is verified.
	verification, err := verifySetupProvider(appDeps{probeProviderHealth: nil}, config.ProviderProfile{Name: "openai"})
	if err != nil {
		t.Fatalf("verifySetupProvider returned error: %v", err)
	}
	if verification.Ran {
		t.Fatalf("a skipped probe must report Ran=false, got Ran=true")
	}
	if verification.OK {
		t.Fatalf("a skipped probe must not report OK=true, got OK=true")
	}
}

func TestSetupJSONPayloadGatesVerifiedOnRan(t *testing.T) {
	// A verification that did not run must not emit a "verified" flag at all, so a
	// machine consumer never reads a skipped probe as a passing verification.
	payload := setupJSONPayload(tui.SetupResult{Provider: config.ProviderProfile{Name: "openai", Model: "gpt-4.1"}}, &setupVerification{Ran: false, OK: false, Summary: "probe unavailable; skipped"})
	if _, present := payload["verified"]; present {
		t.Fatalf("a probe that did not run must not emit a verified flag, got %#v", payload["verified"])
	}

	ranPayload := setupJSONPayload(tui.SetupResult{Provider: config.ProviderProfile{Name: "openai"}}, &setupVerification{Ran: true, OK: true, Summary: "reachable"})
	if got, present := ranPayload["verified"]; !present || got != true {
		t.Fatalf("a probe that ran and passed must emit verified=true, got present=%v value=%#v", present, got)
	}
}

func TestRunSetupWithoutVerifyDoesNotProbe(t *testing.T) {
	var stdout, stderr bytes.Buffer
	configPath := filepath.Join(t.TempDir(), "config.json")
	deps := appDeps{
		userConfigPath: func() (string, error) { return configPath, nil },
		probeProviderHealth: func(context.Context, providerhealth.Options) providerhealth.Result {
			t.Fatal("setup without --verify must not probe")
			return providerhealth.Result{}
		},
	}

	exitCode := runWithDeps([]string{"setup", "ollama"}, &stdout, &stderr, deps)
	if exitCode != exitSuccess {
		t.Fatalf("exit code = %d, want %d: %s", exitCode, exitSuccess, stderr.String())
	}
}