mirror of
https://github.com/Twigpine/zero.git
synced 2026-11-11 23:40:28 -10:00
KRATOSandClaude Opus 4.8
2ee03ac854
cli: --reasoning-effort notice evaluates the EFFECTIVE model (works without --model) (MED); unsafe warning fires for --auto high too (MED); --auto value validated even with --skip-permissions-unsafe (LOW); DefaultRegistry built once per exec, not 3x (LOW); --profile kept as intentional legacy-compat accept-and-ignore (contested finding resolved, doc-commented). modelregistry: removed dead FallbackFor. tools: removed dead TaskNonInteractiveMessage + dead OnSandboxDecision hook (no setter anywhere); fixed the now-stale loop.go comment. TDD where behavioral; build/vet/full-suite green. Refs #102 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
105 lines
3.2 KiB
Go
105 lines
3.2 KiB
Go
package cli
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"regexp"
|
|
"sort"
|
|
"strings"
|
|
|
|
"github.com/Gitlawb/zero/internal/agent"
|
|
"github.com/Gitlawb/zero/internal/tools"
|
|
)
|
|
|
|
var toolNamePattern = regexp.MustCompile(`^[A-Za-z0-9_-]+$`)
|
|
|
|
func parseToolList(value string) []string {
|
|
seen := map[string]bool{}
|
|
tools := []string{}
|
|
for _, name := range strings.FieldsFunc(value, func(char rune) bool {
|
|
return char == ',' || char == ' ' || char == '\t' || char == '\n' || char == '\r'
|
|
}) {
|
|
name = strings.TrimSpace(name)
|
|
if name == "" || seen[name] {
|
|
continue
|
|
}
|
|
seen[name] = true
|
|
tools = append(tools, name)
|
|
}
|
|
return tools
|
|
}
|
|
|
|
func validateExecToolFilters(options execOptions, registry *tools.Registry) error {
|
|
for _, name := range append(append([]string{}, options.enabledTools...), options.disabledTools...) {
|
|
if !toolNamePattern.MatchString(name) {
|
|
return execUsageError{fmt.Sprintf("Invalid tool name %q.", name)}
|
|
}
|
|
if _, ok := registry.Get(name); !ok {
|
|
return execUsageError{fmt.Sprintf("Unknown tool: %s", name)}
|
|
}
|
|
}
|
|
disabled := map[string]bool{}
|
|
for _, name := range options.disabledTools {
|
|
disabled[name] = true
|
|
}
|
|
for _, name := range options.enabledTools {
|
|
if disabled[name] {
|
|
return execUsageError{fmt.Sprintf("Tool cannot be both enabled and disabled: %s", name)}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func resolveExecPermissionMode(options execOptions) (agent.PermissionMode, error) {
|
|
// Validate --auto first, regardless of --skip-permissions-unsafe, so an
|
|
// invalid autonomy value is always rejected. (Previously the unsafe path
|
|
// short-circuited before validation, letting "--auto bogus" slip through
|
|
// whenever --skip-permissions-unsafe was also set.)
|
|
var mode agent.PermissionMode
|
|
switch strings.ToLower(strings.TrimSpace(options.autonomy)) {
|
|
case "", "low", "medium":
|
|
mode = agent.PermissionModeAuto
|
|
case "high":
|
|
mode = agent.PermissionModeUnsafe
|
|
default:
|
|
return "", execUsageError{fmt.Sprintf("Invalid autonomy level %q. Expected low, medium, or high.", options.autonomy)}
|
|
}
|
|
if options.skipPermissionsUnsafe {
|
|
return agent.PermissionModeUnsafe, nil
|
|
}
|
|
return mode, nil
|
|
}
|
|
|
|
func writeExecToolList(w io.Writer, registry *tools.Registry, options execOptions, permissionMode agent.PermissionMode) error {
|
|
_, err := fmt.Fprintln(w, formatExecToolList(registry, options, permissionMode))
|
|
return err
|
|
}
|
|
|
|
func formatExecToolList(registry *tools.Registry, options execOptions, permissionMode agent.PermissionMode) string {
|
|
visible := visibleExecTools(registry, options, permissionMode)
|
|
lines := []string{"Tools visible to model:"}
|
|
for _, tool := range visible {
|
|
safety := tool.Safety()
|
|
lines = append(lines, fmt.Sprintf(" %s [%s/%s] - %s", tool.Name(), safety.SideEffect, safety.Permission, tool.Description()))
|
|
}
|
|
if len(visible) == 0 {
|
|
lines = append(lines, " (none)")
|
|
}
|
|
return strings.Join(lines, "\n")
|
|
}
|
|
|
|
func visibleExecTools(registry *tools.Registry, options execOptions, permissionMode agent.PermissionMode) []tools.Tool {
|
|
all := registry.All()
|
|
visible := []tools.Tool{}
|
|
for _, tool := range all {
|
|
if !agent.ToolVisible(tool, permissionMode, options.enabledTools, options.disabledTools) {
|
|
continue
|
|
}
|
|
visible = append(visible, tool)
|
|
}
|
|
sort.Slice(visible, func(i, j int) bool {
|
|
return visible[i].Name() < visible[j].Name()
|
|
})
|
|
return visible
|
|
}
|