euxaristia 8c6c49ad52 chore: fix golangci-lint findings (dead code, ineffassign, staticcheck) (#527) ...

- Remove unused safeRequestedPrefix, safeShellCommandTokens
  (internal/agent/command_prefix.go), and truncateHeadTail
  (internal/tools/bash.go): each was a thin wrapper with no remaining
  callers.
- Drop an ineffectual assignment in stringListArgWebSearch: every
  return path after it already sets the named return explicitly.
- Simplify a negated-and condition in
  partition_cache_stable_test.go via De Morgan's law.
- Use strings.Contains instead of strings.Index(...) < 0 in
  edit_replacers.go.
- Fix error string style (ST1005): lowercase "unsafe redirect URL"
  and drop the trailing period from webFetchPublicOnlyHint.

Skipped the errcheck findings on this pass (unchecked defer
Close()/Write() errors): those are stylistic, not correctness bugs,
and this repo's CI only runs go vet, not golangci-lint.

2026-07-06 08:09:32 +08:00

..

apply_patch_paths_test.go

Audit tail: remaining medium/low correctness fixes (CLI, config, OAuth, tools, LSP, TUI) (#275)

2026-06-20 22:21:48 +05:30

apply_patch.go

feat(tui): clickable plan-step detail + plan/sidebar UX & rendering polish (#315)

2026-06-25 20:23:29 +05:30

args.go

fix(sandbox): retry approved network shell commands (#301)

2026-06-23 17:44:46 +05:30

argtolerance_test.go

Tools: arg-tolerance, ask_user, secret scrubbing, structured results, hardening (#119)

2026-06-07 17:13:27 +05:30

argtolerance.go

Tools: arg-tolerance, ask_user, secret scrubbing, structured results, hardening (#119)

2026-06-07 17:13:27 +05:30

ask_user_format_test.go

polish v2: smoothness & delight (#484)

2026-07-05 13:15:14 +05:30

ask_user_test.go

feat(tui): ask_user suggested answers with a recommended default (#326)

2026-06-27 14:12:41 +05:30

ask_user.go

polish v2: smoothness & delight (#484)

2026-07-05 13:15:14 +05:30

bash_auto_allow_test.go

fix(sandbox): retry approved network shell commands (#301)

2026-06-23 17:44:46 +05:30

bash_budget_test.go

perf: universal tool-output ceiling with spill + async post-edit diagnostics (#518)

2026-07-05 23:50:31 +08:00

bash_proc_unix.go

fix(tools): fix cmd.exe /S/C corrupting commands with embedded quotes (#465)

2026-07-05 11:36:00 +08:00

bash_proc_windows.go

fix(tools): fix cmd.exe /S/C corrupting commands with embedded quotes (#465)

2026-07-05 11:36:00 +08:00

bash_secrets_test.go

Tool quality: per-tool denial categorization + secret scanning (#137)

2026-06-08 09:08:51 +05:30

bash_tool_test.go

fix(tools): Block MSYS coreutils under Windows sandbox (#476)

2026-07-06 08:03:32 +08:00

bash.go

fix(tools): Block MSYS coreutils under Windows sandbox (#476)

2026-07-06 08:03:32 +08:00

deferred_test.go

Move deferred tool discovery into tool search (#324)

2026-06-27 13:02:09 +05:30

deferred.go

Move deferred tool discovery into tool search (#324)

2026-06-27 13:02:09 +05:30

diff_preview.go

feat(tools): show red/green diff preview on write_file and edit_file (#318)

2026-06-25 19:24:27 +05:30

edit_file.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

edit_replacers_test.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

edit_replacers.go

chore: fix golangci-lint findings (dead code, ineffassign, staticcheck) (#527)

2026-07-06 08:09:32 +08:00

escalate_model_test.go

Mid-run model escalation: escalate_model tool + --allow-escalation (#146)

2026-06-08 20:50:32 +05:30

escalate_model.go

Mid-run model escalation: escalate_model tool + --allow-escalation (#146)

2026-06-08 20:50:32 +05:30

exec_command_test.go

fix(tools): Block MSYS coreutils under Windows sandbox (#476)

2026-07-06 08:03:32 +08:00

exec_command.go

fix(tools): Block MSYS coreutils under Windows sandbox (#476)

2026-07-06 08:03:32 +08:00

exec_pty_fallback.go

Add managed background terminals (#270)

2026-06-20 20:30:39 +05:30

exec_pty_linux.go

fix: resolve 15 findings from the 2026-06-20 deep audit (#281)

2026-06-21 00:44:23 +05:30

exec_transport.go

Add managed background terminals (#270)

2026-06-20 20:30:39 +05:30

file_safety_test.go

Edit safety: file read/write tracking, external-modification detection, post-apply hooks (#172)

2026-06-11 20:34:35 +05:30

file_tools_test.go

Fix shared temp roots in sandbox scope (#314)

2026-06-25 09:47:55 +05:30

file_tracker_test.go

Edit safety: file read/write tracking, external-modification detection, post-apply hooks (#172)

2026-06-11 20:34:35 +05:30

file_tracker.go

Edit safety: file read/write tracking, external-modification detection, post-apply hooks (#172)

2026-06-11 20:34:35 +05:30

format_on_write_test.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

format_on_write.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

glob.go

fix(tools): make grep and glob respect run cancellation (#464)

2026-07-05 11:35:01 +08:00

grep.go

fix(tools): make grep and glob respect run cancellation (#464)

2026-07-05 11:35:01 +08:00

inline_diagnostics_test.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

inline_diagnostics.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

list_directory.go

Fix token accounting and usage display (#304)

2026-06-24 08:18:34 +05:30

local_browser_test.go

Add local control browser and terminal tools (#319)

2026-06-26 08:22:56 +05:30

local_browser.go

Add local control browser and terminal tools (#319)

2026-06-26 08:22:56 +05:30

local_capture_test.go

Add local control browser and terminal tools (#319)

2026-06-26 08:22:56 +05:30

local_capture.go

Add local control browser and terminal tools (#319)

2026-06-26 08:22:56 +05:30

local_desktop_terminal_test.go

Add local control browser and terminal tools (#319)

2026-06-26 08:22:56 +05:30

local_desktop.go

Add local control browser and terminal tools (#319)

2026-06-26 08:22:56 +05:30

local_terminal.go

Add local control browser and terminal tools (#319)

2026-06-26 08:22:56 +05:30

lsp_navigate_test.go

feat: five capability features from the reference-agent comparison (#276)

2026-06-20 23:12:15 +05:30

lsp_navigate.go

feat: five capability features from the reference-agent comparison (#276)

2026-06-20 23:12:15 +05:30

mutation_targets_test.go

Tools: arg-tolerance, ask_user, secret scrubbing, structured results, hardening (#119)

2026-06-07 17:13:27 +05:30

mutation_targets.go

Tools: arg-tolerance, ask_user, secret scrubbing, structured results, hardening (#119)

2026-06-07 17:13:27 +05:30

output_budget.go

Fix token accounting and usage display (#304)

2026-06-24 08:18:34 +05:30

output_ceiling_test.go

perf: universal tool-output ceiling with spill + async post-edit diagnostics (#518)

2026-07-05 23:50:31 +08:00

output_ceiling.go

perf: universal tool-output ceiling with spill + async post-edit diagnostics (#518)

2026-07-05 23:50:31 +08:00

plan_tool_test.go

fix: behavioral-audit follow-ups (exec -p, cron/version/specialist UX, update_plan coercion, Makefile) (#286)

2026-06-21 15:57:38 +05:30

preview_test.go

feat(tui): clickable plan-step detail + plan/sidebar UX & rendering polish (#315)

2026-06-25 20:23:29 +05:30

preview.go

feat(tui): clickable plan-step detail + plan/sidebar UX & rendering polish (#315)

2026-06-25 20:23:29 +05:30

read_exclusions_test.go

feat(sandbox): harden internal/sandbox — re-entrancy guard, SOCKS5 egress, sandbox-aware search, fine-grained path lists (#199)

2026-06-14 17:37:40 +05:30

read_exclusions.go

feat(sandbox): harden internal/sandbox — re-entrancy guard, SOCKS5 egress, sandbox-aware search, fine-grained path lists (#199)

2026-06-14 17:37:40 +05:30

read_file.go

Fix token accounting and usage display (#304)

2026-06-24 08:18:34 +05:30

read_minified_file_test.go

Fix token accounting and usage display (#304)

2026-06-24 08:18:34 +05:30

read_minified_file.go

Fix token accounting and usage display (#304)

2026-06-24 08:18:34 +05:30

registry_test.go

fix(tools): require permission before web_search requests (#382)

2026-07-02 22:14:58 +08:00

registry.go

perf: universal tool-output ceiling with spill + async post-edit diagnostics (#518)

2026-07-05 23:50:31 +08:00

request_permissions.go

Add request permissions flow (#248)

2026-06-18 20:00:35 +05:30

sandbox_denial_test.go

fix(sandbox): retry approved network shell commands (#301)

2026-06-23 17:44:46 +05:30

sandbox_denial.go

fix(sandbox): retry approved network shell commands (#301)

2026-06-23 17:44:46 +05:30

scaffold_test.go

wedge stage 10: distribution (skill/plugin install, tools make) (#184)

2026-06-13 10:43:31 +05:30

scaffold.go

wedge stage 10: distribution (skill/plugin install, tools make) (#184)

2026-06-13 10:43:31 +05:30

search_cancel.go

fix(tools): make grep and glob respect run cancellation (#464)

2026-07-05 11:35:01 +08:00

search_cancellation_test.go

fix(tools): make grep and glob respect run cancellation (#464)

2026-07-05 11:35:01 +08:00

shell_runtime_test.go

fix(tools): Block MSYS coreutils under Windows sandbox (#476)

2026-07-06 08:03:32 +08:00

shell_runtime.go

fix(tools): Block MSYS coreutils under Windows sandbox (#476)

2026-07-06 08:03:32 +08:00

skill_test.go

Skills & plugins: skill tool, skills loader, plugin manifests (#123)

2026-06-07 21:35:11 +05:30

skill.go

Skills & plugins: skill tool, skills loader, plugin manifests (#123)

2026-06-07 21:35:11 +05:30

spill_hardening_test.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

spill_owner_unix.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

spill_owner_windows.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

spill_test.go

perf: universal tool-output ceiling with spill + async post-edit diagnostics (#518)

2026-07-05 23:50:31 +08:00

spill.go

perf: universal tool-output ceiling with spill + async post-edit diagnostics (#518)

2026-07-05 23:50:31 +08:00

tool_search_eager_test.go

tools: tool_search redirects eager-tool lookups instead of "no tools matched" (#259)

2026-06-19 20:02:48 +05:30

tool_search_test.go

polish v2: smoothness & delight (#484)

2026-07-05 13:15:14 +05:30

tool_search.go

polish v2: smoothness & delight (#484)

2026-07-05 13:15:14 +05:30

types_test.go

Add local control browser and terminal tools (#319)

2026-06-26 08:22:56 +05:30

types.go

Add local control browser and terminal tools (#319)

2026-06-26 08:22:56 +05:30

update_plan.go

fix: behavioral-audit follow-ups (exec -p, cron/version/specialist UX, update_plan coercion, Makefile) (#286)

2026-06-21 15:57:38 +05:30

web_fetch_markdown_test.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

web_fetch_markdown.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

web_fetch_test.go

chore: fix golangci-lint findings (dead code, ineffassign, staticcheck) (#527)

2026-07-06 08:09:32 +08:00

web_fetch.go

chore: fix golangci-lint findings (dead code, ineffassign, staticcheck) (#527)

2026-07-06 08:09:32 +08:00

web_search_searxng_test.go

tools: defer swarm tool schemas + keyless SearXNG web_search backend (#258)

2026-06-19 20:02:26 +05:30

web_search_test.go

fix(tools): require permission before web_search requests (#382)

2026-07-02 22:14:58 +08:00

web_search.go

chore: fix golangci-lint findings (dead code, ineffassign, staticcheck) (#527)

2026-07-06 08:09:32 +08:00

workspace.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

write_file.go

feat: agent quality, caching, retry, and tooling upgrades (#506)

2026-07-05 17:25:26 +08:00

write_tools_test.go

fix(tools): CRLF line ending mismatch in edit_file tool on Windows (#378)

2026-07-02 22:07:26 +08:00