Files
Victor M. Alvarez 0cdff36723 fix: validate arena buffer count
Ensure `YR_ARENA` objects are created, loaded, and accessed with a valid number of buffers. This prevents out-of-bounds memory access and improves robustness against corrupted arena data or incorrect API usage.

Closes #2238.
2026-08-25 10:29:10 +02:00

630 lines
16 KiB
C

/*
Copyright (c) 2013. The YARA Authors. All Rights Reserved.
Redistribution and use in source and binary forms, with or without modification,
are permitted provided that the following conditions are met:
1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation and/or
other materials provided with the distribution.
3. Neither the name of the copyright holder nor the names of its contributors
may be used to endorse or promote products derived from this software without
specific prior written permission.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include <assert.h>
#include <ctype.h>
#include <string.h>
#include <yara/compiler.h>
#include <yara/error.h>
#include <yara/filemap.h>
#include <yara/globals.h>
#include <yara/mem.h>
#include <yara/proc.h>
#include <yara/rules.h>
#include <yara/scan.h>
#include <yara/scanner.h>
#include <yara/utils.h>
YR_API int yr_rules_define_integer_variable(
YR_RULES* rules,
const char* identifier,
int64_t value)
{
YR_EXTERNAL_VARIABLE* external;
if (identifier == NULL)
return ERROR_INVALID_ARGUMENT;
external = rules->ext_vars_table;
while (!EXTERNAL_VARIABLE_IS_NULL(external))
{
if (strcmp(external->identifier, identifier) == 0)
{
if (external->type != EXTERNAL_VARIABLE_TYPE_INTEGER)
return ERROR_INVALID_EXTERNAL_VARIABLE_TYPE;
external->value.i = value;
return ERROR_SUCCESS;
}
external++;
}
return ERROR_INVALID_ARGUMENT;
}
YR_API int yr_rules_define_boolean_variable(
YR_RULES* rules,
const char* identifier,
int value)
{
YR_EXTERNAL_VARIABLE* external;
if (identifier == NULL)
return ERROR_INVALID_ARGUMENT;
external = rules->ext_vars_table;
while (!EXTERNAL_VARIABLE_IS_NULL(external))
{
if (strcmp(external->identifier, identifier) == 0)
{
if (external->type != EXTERNAL_VARIABLE_TYPE_BOOLEAN)
return ERROR_INVALID_EXTERNAL_VARIABLE_TYPE;
external->value.i = value;
return ERROR_SUCCESS;
}
external++;
}
return ERROR_INVALID_ARGUMENT;
}
YR_API int yr_rules_define_float_variable(
YR_RULES* rules,
const char* identifier,
double value)
{
YR_EXTERNAL_VARIABLE* external;
if (identifier == NULL)
return ERROR_INVALID_ARGUMENT;
external = rules->ext_vars_table;
while (!EXTERNAL_VARIABLE_IS_NULL(external))
{
if (strcmp(external->identifier, identifier) == 0)
{
if (external->type != EXTERNAL_VARIABLE_TYPE_FLOAT)
return ERROR_INVALID_EXTERNAL_VARIABLE_TYPE;
external->value.f = value;
return ERROR_SUCCESS;
}
external++;
}
return ERROR_INVALID_ARGUMENT;
}
YR_API int yr_rules_define_string_variable(
YR_RULES* rules,
const char* identifier,
const char* value)
{
YR_EXTERNAL_VARIABLE* external;
if (identifier == NULL || value == NULL)
return ERROR_INVALID_ARGUMENT;
external = rules->ext_vars_table;
while (!EXTERNAL_VARIABLE_IS_NULL(external))
{
if (strcmp(external->identifier, identifier) == 0)
{
if (external->type != EXTERNAL_VARIABLE_TYPE_STRING &&
external->type != EXTERNAL_VARIABLE_TYPE_MALLOC_STRING)
return ERROR_INVALID_EXTERNAL_VARIABLE_TYPE;
if (external->type == EXTERNAL_VARIABLE_TYPE_MALLOC_STRING &&
external->value.s != NULL)
{
yr_free(external->value.s);
}
external->type = EXTERNAL_VARIABLE_TYPE_MALLOC_STRING;
external->value.s = yr_strdup(value);
if (external->value.s == NULL)
return ERROR_INSUFFICIENT_MEMORY;
else
return ERROR_SUCCESS;
}
external++;
}
return ERROR_INVALID_ARGUMENT;
}
YR_API int yr_rules_scan_mem_blocks(
YR_RULES* rules,
YR_MEMORY_BLOCK_ITERATOR* iterator,
int flags,
YR_CALLBACK_FUNC callback,
void* user_data,
int timeout)
{
YR_SCANNER* scanner;
int result;
FAIL_ON_ERROR(yr_scanner_create(rules, &scanner));
yr_scanner_set_callback(scanner, callback, user_data);
yr_scanner_set_timeout(scanner, timeout);
yr_scanner_set_flags(scanner, flags);
result = yr_scanner_scan_mem_blocks(scanner, iterator);
yr_scanner_destroy(scanner);
return result;
}
YR_API int yr_rules_scan_mem(
YR_RULES* rules,
const uint8_t* buffer,
size_t buffer_size,
int flags,
YR_CALLBACK_FUNC callback,
void* user_data,
int timeout)
{
YR_DEBUG_FPRINTF(
2,
stderr,
"+ %s(buffer=%p buffer_size=%zu timeout=%d) {\n",
__FUNCTION__,
buffer,
buffer_size,
timeout);
YR_SCANNER* scanner;
int result = ERROR_INTERNAL_FATAL_ERROR;
GOTO_EXIT_ON_ERROR(yr_scanner_create(rules, &scanner));
yr_scanner_set_callback(scanner, callback, user_data);
yr_scanner_set_timeout(scanner, timeout);
yr_scanner_set_flags(scanner, flags);
result = yr_scanner_scan_mem(scanner, buffer, buffer_size);
yr_scanner_destroy(scanner);
_exit:
YR_DEBUG_FPRINTF(
2,
stderr,
""
"} = %d AKA %s // %s()\n",
result,
yr_debug_error_as_string(result),
__FUNCTION__);
return result;
}
YR_API int yr_rules_scan_file(
YR_RULES* rules,
const char* filename,
int flags,
YR_CALLBACK_FUNC callback,
void* user_data,
int timeout)
{
YR_MAPPED_FILE mfile;
int result = yr_filemap_map(filename, &mfile);
if (result == ERROR_SUCCESS)
{
result = yr_rules_scan_mem(
rules, mfile.data, mfile.size, flags, callback, user_data, timeout);
yr_filemap_unmap(&mfile);
}
return result;
}
YR_API int yr_rules_scan_fd(
YR_RULES* rules,
YR_FILE_DESCRIPTOR fd,
int flags,
YR_CALLBACK_FUNC callback,
void* user_data,
int timeout)
{
YR_MAPPED_FILE mfile;
int result = yr_filemap_map_fd(fd, 0, 0, &mfile);
if (result == ERROR_SUCCESS)
{
result = yr_rules_scan_mem(
rules, mfile.data, mfile.size, flags, callback, user_data, timeout);
yr_filemap_unmap_fd(&mfile);
}
return result;
}
YR_API int yr_rules_scan_proc(
YR_RULES* rules,
int pid,
int flags,
YR_CALLBACK_FUNC callback,
void* user_data,
int timeout)
{
YR_DEBUG_FPRINTF(
2, stderr, "+ %s(pid=%d timeout=%d) {\n", __FUNCTION__, pid, timeout);
YR_MEMORY_BLOCK_ITERATOR iterator;
int result = yr_process_open_iterator(pid, &iterator);
if (result == ERROR_SUCCESS)
{
result = yr_rules_scan_mem_blocks(
rules,
&iterator,
flags | SCAN_FLAGS_PROCESS_MEMORY,
callback,
user_data,
timeout);
yr_process_close_iterator(&iterator);
}
YR_DEBUG_FPRINTF(
2,
stderr,
"} = %d AKA %s // %s()\n",
result,
yr_debug_error_as_string(result),
__FUNCTION__);
return result;
}
int yr_rules_from_arena(YR_ARENA* arena, YR_RULES** rules)
{
if (arena->num_buffers < YR_NUM_SECTIONS)
return ERROR_CORRUPT_FILE;
YR_SUMMARY* summary = (YR_SUMMARY*) yr_arena_get_ptr(
arena, YR_SUMMARY_SECTION, 0);
if (summary == NULL)
return ERROR_CORRUPT_FILE;
// The rule, string and namespace counts are taken verbatim from the loaded
// summary. Reject any count that doesn't fit the table it indexes, otherwise
// the rules_table walk below (and the string/namespace tables the scanner
// indexes with these counts) run past the end of the loaded buffers.
if ((uint64_t) summary->num_rules * sizeof(YR_RULE) >
yr_arena_get_current_offset(arena, YR_RULES_TABLE) ||
(uint64_t) summary->num_strings * sizeof(YR_STRING) >
yr_arena_get_current_offset(arena, YR_STRINGS_TABLE) ||
(uint64_t) summary->num_namespaces * sizeof(YR_NAMESPACE) >
yr_arena_get_current_offset(arena, YR_NAMESPACES_TABLE))
{
return ERROR_CORRUPT_FILE;
}
// The Aho-Corasick transition and match tables are read verbatim from the
// loaded file and drive the per-byte scan loop in _yr_scanner_scan_mem_block,
// which reads transition_table[state + b] (b is a scanned byte, so the offset
// is 1..256), match_table[state] and ac_match_pool[match_table[state] - 1]
// with state taken from the tables themselves. Reject a file whose tables are
// too small or whose next-state / match-pool indexes fall outside them,
// otherwise those reads run out of bounds while scanning.
YR_AC_TRANSITION* transition_table = yr_arena_get_ptr(
arena, YR_AC_TRANSITION_TABLE, 0);
uint32_t* match_table = yr_arena_get_ptr(arena, YR_AC_STATE_MATCHES_TABLE, 0);
uint32_t transition_table_size = yr_arena_get_current_offset(
arena, YR_AC_TRANSITION_TABLE) /
sizeof(YR_AC_TRANSITION);
uint32_t match_table_size = yr_arena_get_current_offset(
arena, YR_AC_STATE_MATCHES_TABLE) /
sizeof(uint32_t);
uint32_t match_pool_size = yr_arena_get_current_offset(
arena, YR_AC_STATE_MATCHES_POOL) /
sizeof(YR_AC_MATCH);
// Every state leaves room for the 256 input offsets read after it, so a valid
// table always has at least 257 slots and the match table is never shorter.
if (transition_table_size < 257 || match_table_size < transition_table_size)
return ERROR_CORRUPT_FILE;
for (uint32_t i = 0; i < transition_table_size; i++)
{
if (YR_AC_NEXT_STATE(transition_table[i]) + 256 >= transition_table_size)
return ERROR_CORRUPT_FILE;
if (match_table[i] > match_pool_size)
return ERROR_CORRUPT_FILE;
}
YR_RULES* new_rules = (YR_RULES*) yr_malloc(sizeof(YR_RULES));
if (new_rules == NULL)
return ERROR_INSUFFICIENT_MEMORY;
new_rules->no_required_strings = (YR_BITMASK*) yr_calloc(
sizeof(YR_BITMASK), YR_BITMASK_SIZE(summary->num_rules));
if (new_rules->no_required_strings == NULL)
{
yr_free(new_rules);
return ERROR_INSUFFICIENT_MEMORY;
}
// Now YR_RULES relies on this arena, let's increment the arena's
// reference count so that if the original owner of the arena calls
// yr_arena_destroy the arena is not destroyed.
yr_arena_acquire(arena);
new_rules->arena = arena;
new_rules->num_rules = summary->num_rules;
new_rules->num_strings = summary->num_strings;
new_rules->num_namespaces = summary->num_namespaces;
new_rules->rules_table = yr_arena_get_ptr(arena, YR_RULES_TABLE, 0);
new_rules->strings_table = yr_arena_get_ptr(arena, YR_STRINGS_TABLE, 0);
new_rules->ext_vars_table = yr_arena_get_ptr(
arena, YR_EXTERNAL_VARIABLES_TABLE, 0);
new_rules->ac_transition_table = yr_arena_get_ptr(
arena, YR_AC_TRANSITION_TABLE, 0);
new_rules->ac_match_table = yr_arena_get_ptr(
arena, YR_AC_STATE_MATCHES_TABLE, 0);
new_rules->ac_match_pool = yr_arena_get_ptr(
arena, YR_AC_STATE_MATCHES_POOL, 0);
new_rules->code_start = yr_arena_get_ptr(arena, YR_CODE_SECTION, 0);
// If a rule has no required_strings, this means that the condition might
// evaluate to true without any matching strings, and we therefore have to
// mark it as "to be evaluated" from the beginning.
for (int i = 0; i < new_rules->num_rules; i++)
{
if (new_rules->rules_table[i].required_strings == 0)
yr_bitmask_set(new_rules->no_required_strings, i);
}
*rules = new_rules;
return ERROR_SUCCESS;
}
YR_API int yr_rules_load_stream(YR_STREAM* stream, YR_RULES** rules)
{
YR_ARENA* arena;
// Load the arena's data the stream. We are the owners of the arena.
FAIL_ON_ERROR(yr_arena_load_stream(stream, &arena));
// Create the YR_RULES object from the arena, this makes YR_RULES owner
// of the arena too.
int result = yr_rules_from_arena(arena, rules);
// Release our ownership so that YR_RULES is the single owner. This way the
// arena is destroyed when YR_RULES is destroyed.
yr_arena_release(arena);
return result;
}
YR_API int yr_rules_load(const char* filename, YR_RULES** rules)
{
int result;
YR_STREAM stream;
FILE* fh = fopen(filename, "rb");
if (fh == NULL)
return ERROR_COULD_NOT_OPEN_FILE;
stream.user_data = fh;
stream.read = (YR_STREAM_READ_FUNC) fread;
result = yr_rules_load_stream(&stream, rules);
fclose(fh);
return result;
}
YR_API int yr_rules_save_stream(YR_RULES* rules, YR_STREAM* stream)
{
return yr_arena_save_stream(rules->arena, stream);
}
YR_API int yr_rules_save(YR_RULES* rules, const char* filename)
{
int result;
YR_STREAM stream;
FILE* fh = fopen(filename, "wb");
if (fh == NULL)
return ERROR_COULD_NOT_OPEN_FILE;
stream.user_data = fh;
stream.write = (YR_STREAM_WRITE_FUNC) fwrite;
result = yr_rules_save_stream(rules, &stream);
fclose(fh);
return result;
}
static int _uint32_cmp(const void* a, const void* b)
{
return (*(uint32_t*) a - *(uint32_t*) b);
}
YR_API int yr_rules_get_stats(YR_RULES* rules, YR_RULES_STATS* stats)
{
memset(stats, 0, sizeof(YR_RULES_STATS));
stats->ac_tables_size = yr_arena_get_current_offset(
rules->arena, YR_AC_TRANSITION_TABLE) /
sizeof(YR_AC_TRANSITION);
uint32_t* match_list_lengths = (uint32_t*) yr_malloc(
sizeof(uint32_t) * stats->ac_tables_size);
if (match_list_lengths == NULL)
return ERROR_INSUFFICIENT_MEMORY;
stats->num_rules = rules->num_rules;
stats->num_strings = rules->num_strings;
float match_list_length_sum = 0;
int c = 0;
for (uint32_t i = 0; i < stats->ac_tables_size; i++)
{
int match_list_length = 0;
if (rules->ac_match_table[i] != 0)
{
YR_AC_MATCH* m = &rules->ac_match_pool[rules->ac_match_table[i] - 1];
while (m != NULL)
{
match_list_length++;
stats->ac_matches++;
m = m->next;
}
}
if (i == 0)
stats->ac_root_match_list_length = match_list_length;
match_list_length_sum += match_list_length;
if (match_list_length > 0)
{
match_list_lengths[c] = match_list_length;
c++;
}
}
if (c == 0)
{
yr_free(match_list_lengths);
return ERROR_SUCCESS;
}
// sort match_list_lengths in increasing order for computing percentiles.
qsort(match_list_lengths, c, sizeof(match_list_lengths[0]), _uint32_cmp);
for (int i = 0; i < 100; i++)
{
if (i < c)
stats->top_ac_match_list_lengths[i] = match_list_lengths[c - i - 1];
else
stats->top_ac_match_list_lengths[i] = 0;
}
stats->ac_average_match_list_length = match_list_length_sum / c;
stats->ac_match_list_length_pctls[0] = match_list_lengths[0];
stats->ac_match_list_length_pctls[100] = match_list_lengths[c - 1];
for (int i = 1; i < 100; i++)
stats->ac_match_list_length_pctls[i] = match_list_lengths[(c * i) / 100];
yr_free(match_list_lengths);
return ERROR_SUCCESS;
}
YR_API int yr_rules_destroy(YR_RULES* rules)
{
YR_EXTERNAL_VARIABLE* external = rules->ext_vars_table;
while (!EXTERNAL_VARIABLE_IS_NULL(external))
{
if (external->type == EXTERNAL_VARIABLE_TYPE_MALLOC_STRING)
yr_free(external->value.s);
external++;
}
yr_free(rules->no_required_strings);
yr_arena_release(rules->arena);
yr_free(rules);
return ERROR_SUCCESS;
}
YR_API void yr_rule_disable(YR_RULE* rule)
{
YR_STRING* string;
rule->flags |= RULE_FLAGS_DISABLED;
yr_rule_strings_foreach(rule, string)
{
string->flags |= STRING_FLAGS_DISABLED;
}
}
YR_API void yr_rule_enable(YR_RULE* rule)
{
YR_STRING* string;
rule->flags &= ~RULE_FLAGS_DISABLED;
yr_rule_strings_foreach(rule, string)
{
string->flags &= ~STRING_FLAGS_DISABLED;
}
}