From 9018aa700ac1ec91d0d73e1f44fda6d1350cf03e Mon Sep 17 00:00:00 2001
From: rekram1-node <rekram1-node@users.noreply.github.com>
Date: Sun, 23 Aug 2026 18:02:38 +0000
Subject: [PATCH] fix(core): preserve shell list metadata

---
 packages/app/src/settings/general/behavior.ts         | 4 ++--
 packages/app/src/settings/general/controllers.test.ts | 6 +++---
 packages/core/src/shell/select.ts                     | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/packages/app/src/settings/general/behavior.ts b/packages/app/src/settings/general/behavior.ts
index d6d782b6b1a..64bd4c11875 100644
--- a/packages/app/src/settings/general/behavior.ts
+++ b/packages/app/src/settings/general/behavior.ts
@@ -3,7 +3,7 @@ import { onCleanup } from "solid-js"
 export type ShellOption = {
   path: string
   name: string
-  compatible: boolean
+  acceptable: boolean
 }
 
 export type ShellSelectOption = {
@@ -27,7 +27,7 @@ export function createShellOptions(input: { shells: ShellOption[]; current: stri
         id: shell.path,
         value: ambiguous ? shell.path : shell.name,
         name,
-        terminalOnly: !shell.compatible,
+        terminalOnly: !shell.acceptable,
       }
     }),
   ]
diff --git a/packages/app/src/settings/general/controllers.test.ts b/packages/app/src/settings/general/controllers.test.ts
index f6e3b6f29c4..36d4fc58c54 100644
--- a/packages/app/src/settings/general/controllers.test.ts
+++ b/packages/app/src/settings/general/controllers.test.ts
@@ -7,9 +7,9 @@ describe("settings controllers", () => {
     expect(
       createShellOptions({
         shells: [
-          { path: "/bin/bash", name: "bash", compatible: true },
-          { path: "/opt/bash", name: "bash", compatible: false },
-          { path: "/bin/zsh", name: "zsh", compatible: true },
+          { path: "/bin/bash", name: "bash", acceptable: true },
+          { path: "/opt/bash", name: "bash", acceptable: false },
+          { path: "/bin/zsh", name: "zsh", acceptable: true },
         ],
         current: "fish",
       }),
diff --git a/packages/core/src/shell/select.ts b/packages/core/src/shell/select.ts
index d02aa82b24e..fc1da697055 100644
--- a/packages/core/src/shell/select.ts
+++ b/packages/core/src/shell/select.ts
@@ -25,7 +25,7 @@ const META: Record<string, { deny?: boolean; login?: boolean; ps?: boolean }> =
 export type Item = {
   path: string
   name: string
-  compatible: boolean
+  acceptable: boolean
 }
 
 export const Options = Schema.Struct({
@@ -156,7 +156,7 @@ function info(file: string, options?: Options, bin?: string): Item {
   return {
     path: item,
     name: executable(n, options, bin) ? n : item,
-    compatible: compatible(item),
+    acceptable: compatible(item),
   }
 }