Compare commits

..

3 Commits

Author SHA1 Message Date
Kit Langton f5291d5ff5 fix(core): authorize mutations before locking 2026-08-08 20:20:03 -04:00
Kit Langton ea1c3b9a97 test(core): simplify mutation lock coverage 2026-08-08 20:20:03 -04:00
Kit Langton e7bd4f17c0 fix(core): unify file mutation transaction locks 2026-08-08 20:20:03 -04:00
60 changed files with 1111 additions and 1830 deletions
@@ -0,0 +1,71 @@
import { AuthOptions, type ProviderAuthOption } from "../route/auth-options"
import type { RouteDefaultsInput } from "../route/client"
import { ProviderID, type ModelID } from "../schema"
import * as OpenAIChat from "../protocols/openai-chat"
import * as OpenAIResponses from "../protocols/openai-responses"
import { withOpenAIOptions, type OpenAIProviderOptionsInput } from "./openai-options"
export const id = ProviderID.make("github-copilot")
// GitHub Copilot has no canonical public URL — callers (opencode, etc.) must
// supply `baseURL` explicitly.
export type LanguageModelOptions = Omit<RouteDefaultsInput, "providerOptions"> &
ProviderAuthOption<"optional"> & {
readonly baseURL: string
readonly endpoint?: "chat" | "responses"
readonly providerOptions?: OpenAIProviderOptionsInput
}
export const shouldUseResponsesApi = (modelID: string | ModelID, endpoint?: LanguageModelOptions["endpoint"]) => {
if (endpoint) return endpoint === "responses"
const model = String(modelID)
const match = /^gpt-(\d+)/.exec(model)
if (!match) return false
return Number(match[1]) >= 5 && !model.startsWith("gpt-5-mini")
}
export const routes = [OpenAIResponses.route, OpenAIChat.route]
const chatRoute = OpenAIChat.route.with({ provider: id })
const responsesRoute = OpenAIResponses.route.with({ provider: id })
const defaults = (options: LanguageModelOptions) => {
const { apiKey: _, auth: _auth, baseURL: _baseURL, endpoint: _endpoint, ...rest } = options
return rest
}
const configuredResponsesRoute = (options: LanguageModelOptions) =>
responsesRoute.with({
endpoint: { baseURL: options.baseURL },
auth: AuthOptions.bearer(options, []),
})
const configuredChatRoute = (options: LanguageModelOptions) =>
chatRoute.with({
endpoint: { baseURL: options.baseURL },
auth: AuthOptions.bearer(options, []),
})
export const configure = (options: LanguageModelOptions) => {
const responsesRoute = configuredResponsesRoute(options)
const chatRoute = configuredChatRoute(options)
const responses = (modelID: string | ModelID) =>
responsesRoute
.with(withOpenAIOptions(modelID, defaults(options)))
.model<OpenAIProviderOptionsInput>({ id: modelID })
const chat = (modelID: string | ModelID) =>
chatRoute.with(withOpenAIOptions(modelID, defaults(options))).model<OpenAIProviderOptionsInput>({ id: modelID })
return {
id,
model: (modelID: string | ModelID) =>
shouldUseResponsesApi(modelID, options.endpoint) ? responses(modelID) : chat(modelID),
responses,
chat,
configure,
}
}
export const provider = {
id,
configure,
}
+1
View File
@@ -5,6 +5,7 @@ export * as AmazonBedrockMantle from "./amazon-bedrock-mantle"
export * as Azure from "./azure" export * as Azure from "./azure"
export * as Cloudflare from "./cloudflare" export * as Cloudflare from "./cloudflare"
export { CloudflareAIGateway, CloudflareWorkersAI } from "./cloudflare" export { CloudflareAIGateway, CloudflareWorkersAI } from "./cloudflare"
export * as GitHubCopilot from "./github-copilot"
export * as Google from "./google" export * as Google from "./google"
export * as GoogleVertex from "./google-vertex" export * as GoogleVertex from "./google-vertex"
export * as GoogleVertexChat from "./google-vertex-chat" export * as GoogleVertexChat from "./google-vertex-chat"
+5
View File
@@ -7,6 +7,7 @@ import * as Anthropic from "../src/providers/anthropic"
import * as AnthropicCompatible from "../src/providers/anthropic-compatible" import * as AnthropicCompatible from "../src/providers/anthropic-compatible"
import * as Azure from "../src/providers/azure" import * as Azure from "../src/providers/azure"
import * as Cloudflare from "../src/providers/cloudflare" import * as Cloudflare from "../src/providers/cloudflare"
import * as GitHubCopilot from "../src/providers/github-copilot"
import * as Google from "../src/providers/google" import * as Google from "../src/providers/google"
import * as GoogleVertex from "../src/providers/google-vertex" import * as GoogleVertex from "../src/providers/google-vertex"
import * as GoogleVertexChat from "../src/providers/google-vertex-chat" import * as GoogleVertexChat from "../src/providers/google-vertex-chat"
@@ -269,3 +270,7 @@ OpenAICompatible.deepseek.configure({ apiKey: "deepseek-key" }).model("deepseek-
Cloudflare.CloudflareWorkersAI.configure({ accountId: "account", apiKey: "cf-key" }).model("@cf/meta/llama") Cloudflare.CloudflareWorkersAI.configure({ accountId: "account", apiKey: "cf-key" }).model("@cf/meta/llama")
// @ts-expect-error Cloudflare Workers AI model selectors only accept model ids. // @ts-expect-error Cloudflare Workers AI model selectors only accept model ids.
Cloudflare.CloudflareWorkersAI.configure({ accountId: "account", apiKey: "cf-key" }).model("@cf/meta/llama", {}) Cloudflare.CloudflareWorkersAI.configure({ accountId: "account", apiKey: "cf-key" }).model("@cf/meta/llama", {})
GitHubCopilot.configure({ baseURL: "https://copilot.test", apiKey: "copilot-key" }).model("gpt-4.1")
// @ts-expect-error GitHub Copilot model selectors only accept model ids.
GitHubCopilot.configure({ baseURL: "https://copilot.test", apiKey: "copilot-key" }).model("gpt-4.1", {})
+18
View File
@@ -10,6 +10,7 @@ import {
OpenRouter, OpenRouter,
XAI, XAI,
} from "@opencode-ai/ai/providers" } from "@opencode-ai/ai/providers"
import * as GitHubCopilot from "@opencode-ai/ai/providers/github-copilot"
import { import {
OpenAIChat, OpenAIChat,
OpenAICompatibleChat, OpenAICompatibleChat,
@@ -59,6 +60,23 @@ describe("public exports", () => {
expect(XAI.provider.chat).toBe(XAI.chat) expect(XAI.provider.chat).toBe(XAI.chat)
expect(XAI.configure({ apiKey: "fixture" }).responses("grok-4.3").route.id).toBe("openai-responses") expect(XAI.configure({ apiKey: "fixture" }).responses("grok-4.3").route.id).toBe("openai-responses")
expect(XAI.configure({ apiKey: "fixture" }).chat("grok-4.3").route.id).toBe("openai-compatible-chat") expect(XAI.configure({ apiKey: "fixture" }).chat("grok-4.3").route.id).toBe("openai-compatible-chat")
expect(
GitHubCopilot.configure({ baseURL: "https://api.githubcopilot.test", apiKey: "fixture" }).model,
).toBeFunction()
expect(
GitHubCopilot.configure({
baseURL: "https://api.githubcopilot.test",
apiKey: "fixture",
endpoint: "responses",
}).model("mai-code-1-flash-picker").route.id,
).toBe("openai-responses")
expect(
GitHubCopilot.configure({
baseURL: "https://api.githubcopilot.test",
apiKey: "fixture",
endpoint: "chat",
}).model("gpt-5").route.id,
).toBe("openai-chat")
}) })
test("protocol barrels expose supported low-level routes", () => { test("protocol barrels expose supported low-level routes", () => {
@@ -0,0 +1,13 @@
import { LLM } from "../../src"
import { GitHubCopilot } from "../../src/providers"
const model = GitHubCopilot.configure({ baseURL: "https://example.com" }).model("gpt-5")
LLM.request({ model, prompt: "Hello", providerOptions: { openai: { reasoningSummary: "auto" } } })
LLM.request({
model,
prompt: "Hello",
// @ts-expect-error Copilot reasoning summaries use the OpenAI union.
providerOptions: { openai: { reasoningSummary: "full" } },
})
@@ -1,4 +1,4 @@
import type { FormAnswer, IntegrationMethod, IntegrationOauthConnectOutput } from "@opencode-ai/client/promise" import type { IntegrationMethod, IntegrationOauthConnectOutput } from "@opencode-ai/client/promise"
import { Button } from "@opencode-ai/ui/button" import { Button } from "@opencode-ai/ui/button"
import { useDialog } from "@opencode-ai/ui/context/dialog" import { useDialog } from "@opencode-ai/ui/context/dialog"
import { Dialog } from "@opencode-ai/ui/dialog" import { Dialog } from "@opencode-ai/ui/dialog"
@@ -40,8 +40,6 @@ import { decode64 } from "@/utils/base64"
const CUSTOM_ID = "_custom" const CUSTOM_ID = "_custom"
type ConnectMethod = Extract<IntegrationMethod, { type: "key" | "oauth" }> type ConnectMethod = Extract<IntegrationMethod, { type: "key" | "oauth" }>
type IntegrationForm = NonNullable<ConnectMethod["form"]>[number]
type StringForm = Extract<IntegrationForm, { type: "string" }>
export function useProviderConnectController(options: { onBack?: () => void } = {}) { export function useProviderConnectController(options: { onBack?: () => void } = {}) {
const [store, setStore] = createStore({ selected: undefined as string | undefined }) const [store, setStore] = createStore({ selected: undefined as string | undefined })
@@ -436,16 +434,16 @@ function ProviderConnection(props: {
const [store, setStore] = createStore({ const [store, setStore] = createStore({
methodIndex: undefined as undefined | number, methodIndex: undefined as undefined | number,
authorization: undefined as undefined | IntegrationOauthConnectOutput["data"], authorization: undefined as undefined | IntegrationOauthConnectOutput["data"],
formAnswer: undefined as FormAnswer | undefined, promptInputs: undefined as undefined | Record<string, string>,
state: "pending" as undefined | "pending" | "complete" | "error" | "form", state: "pending" as undefined | "pending" | "complete" | "error" | "prompt",
error: undefined as string | undefined, error: undefined as string | undefined,
}) })
type Action = type Action =
| { type: "method.select"; index: number } | { type: "method.select"; index: number }
| { type: "method.reset" } | { type: "method.reset" }
| { type: "auth.form" } | { type: "auth.prompt" }
| { type: "auth.answer"; answer: FormAnswer | undefined } | { type: "auth.inputs"; inputs: Record<string, string> }
| { type: "auth.pending" } | { type: "auth.pending" }
| { type: "auth.complete"; authorization: IntegrationOauthConnectOutput["data"] } | { type: "auth.complete"; authorization: IntegrationOauthConnectOutput["data"] }
| { type: "auth.error"; error: string } | { type: "auth.error"; error: string }
@@ -456,7 +454,7 @@ function ProviderConnection(props: {
if (action.type === "method.select") { if (action.type === "method.select") {
draft.methodIndex = action.index draft.methodIndex = action.index
draft.authorization = undefined draft.authorization = undefined
draft.formAnswer = undefined draft.promptInputs = undefined
draft.state = undefined draft.state = undefined
draft.error = undefined draft.error = undefined
return return
@@ -464,18 +462,18 @@ function ProviderConnection(props: {
if (action.type === "method.reset") { if (action.type === "method.reset") {
draft.methodIndex = undefined draft.methodIndex = undefined
draft.authorization = undefined draft.authorization = undefined
draft.formAnswer = undefined draft.promptInputs = undefined
draft.state = undefined draft.state = undefined
draft.error = undefined draft.error = undefined
return return
} }
if (action.type === "auth.form") { if (action.type === "auth.prompt") {
draft.state = "form" draft.state = "prompt"
draft.error = undefined draft.error = undefined
return return
} }
if (action.type === "auth.answer") { if (action.type === "auth.inputs") {
draft.formAnswer = action.answer draft.promptInputs = action.inputs
draft.state = undefined draft.state = undefined
draft.error = undefined draft.error = undefined
return return
@@ -533,7 +531,7 @@ function ProviderConnection(props: {
return fallback return fallback
} }
async function selectMethod(index: number, answer?: FormAnswer) { async function selectMethod(index: number, inputs?: Record<string, string>) {
if (timer.current !== undefined) { if (timer.current !== undefined) {
clearTimeout(timer.current) clearTimeout(timer.current)
timer.current = undefined timer.current = undefined
@@ -542,17 +540,9 @@ function ProviderConnection(props: {
const method = methods()[index] const method = methods()[index]
dispatch({ type: "method.select", index }) dispatch({ type: "method.select", index })
if (method.form?.length && !answer) {
dispatch({ type: "auth.form" })
return
}
if (method.type === "key") {
dispatch({ type: "auth.answer", answer })
return
}
if (method.type === "oauth") { if (method.type === "oauth") {
if (method.form?.some((field) => field.type !== "string")) { if (method.prompts?.length && !inputs) {
dispatch({ type: "auth.error", error: "This authentication form contains unsupported fields" }) dispatch({ type: "auth.prompt" })
return return
} }
dispatch({ type: "auth.pending" }) dispatch({ type: "auth.pending" })
@@ -560,7 +550,7 @@ function ProviderConnection(props: {
.api.integration.oauth.connect({ .api.integration.oauth.connect({
integrationID: props.provider, integrationID: props.provider,
methodID: method.id, methodID: method.id,
...(answer ? { answer } : {}), inputs: inputs ?? {},
location: location(), location: location(),
}) })
.then((x) => { .then((x) => {
@@ -574,42 +564,41 @@ function ProviderConnection(props: {
} }
} }
function AuthFormView() { function AuthPromptsView() {
const [formStore, setFormStore] = createStore({ const [formStore, setFormStore] = createStore({
value: {} as Record<string, string>, value: {} as Record<string, string>,
index: 0, index: 0,
}) })
const fields = createMemo<StringForm[]>(() => { const prompts = createMemo(() => {
const value = method() const value = method()
return (value?.form ?? []).flatMap((field) => (field.type === "string" ? [field] : [])) return value?.type === "oauth" ? (value.prompts ?? []) : []
}) })
const matches = (field: StringForm, value: Record<string, string>) => { const matches = (prompt: NonNullable<ReturnType<typeof prompts>[number]>, value: Record<string, string>) => {
return (field.when ?? []).every((condition) => { if (!prompt.when) return true
const actual = value[condition.key] const actual = value[prompt.when.key]
if (actual === undefined) return false if (actual === undefined) return false
return condition.op === "eq" ? actual === condition.value : actual !== condition.value return prompt.when.op === "eq" ? actual === prompt.when.value : actual !== prompt.when.value
})
} }
const current = createMemo(() => { const current = createMemo(() => {
const all = fields() const all = prompts()
const index = all.findIndex((field, index) => index >= formStore.index && matches(field, formStore.value)) const index = all.findIndex((prompt, index) => index >= formStore.index && matches(prompt, formStore.value))
if (index === -1) return if (index === -1) return
return { return {
index, index,
field: all[index], prompt: all[index],
} }
}) })
const valid = createMemo(() => { const valid = createMemo(() => {
const item = current() const item = current()
if (!item || item.field.options) return false if (!item || item.prompt.type !== "text") return false
if (!item.field.required) return true const value = formStore.value[item.prompt.key] ?? ""
return (formStore.value[item.field.key] ?? "").trim().length > 0 return value.trim().length > 0
}) })
async function next(index: number, value: Record<string, string>) { async function next(index: number, value: Record<string, string>) {
if (store.methodIndex === undefined) return if (store.methodIndex === undefined) return
const next = fields().findIndex((field, i) => i > index && matches(field, value)) const next = prompts().findIndex((prompt, i) => i > index && matches(prompt, value))
if (next !== -1) { if (next !== -1) {
setFormStore("index", next) setFormStore("index", next)
return return
@@ -620,60 +609,60 @@ function ProviderConnection(props: {
async function handleSubmit(e: SubmitEvent) { async function handleSubmit(e: SubmitEvent) {
e.preventDefault() e.preventDefault()
const item = current() const item = current()
if (!item || item.field.options) return if (!item || item.prompt.type !== "text") return
if (!valid()) return if (!valid()) return
await next(item.index, formStore.value) await next(item.index, formStore.value)
} }
const item = () => current() const item = () => current()
const text = createMemo(() => { const text = createMemo(() => {
const field = item()?.field const prompt = item()?.prompt
if (!field || field.options) return if (!prompt || prompt.type !== "text") return
return field return prompt
}) })
const select = createMemo(() => { const select = createMemo(() => {
const field = item()?.field const prompt = item()?.prompt
if (!field?.options) return if (!prompt || prompt.type !== "select") return
return field return prompt
}) })
return ( return (
<form onSubmit={handleSubmit} class="flex flex-col items-start gap-4"> <form onSubmit={handleSubmit} class="flex flex-col items-start gap-4">
<Switch> <Switch>
<Match when={item()?.field.options === undefined}> <Match when={item()?.prompt.type === "text"}>
<TextField <TextField
type="text" type="text"
label={text()?.title ?? ""} label={text()?.message ?? ""}
placeholder={text()?.placeholder} placeholder={text()?.placeholder}
value={text() ? (formStore.value[text()!.key] ?? "") : ""} value={text() ? (formStore.value[text()!.key] ?? "") : ""}
onChange={(value) => { onChange={(value) => {
const field = text() const prompt = text()
if (!field) return if (!prompt) return
setFormStore("value", field.key, value) setFormStore("value", prompt.key, value)
}} }}
/> />
<Button class="w-auto" type="submit" size="large" variant="primary" disabled={!valid()}> <Button class="w-auto" type="submit" size="large" variant="primary" disabled={!valid()}>
{language.t("common.continue")} {language.t("common.continue")}
</Button> </Button>
</Match> </Match>
<Match when={item()?.field.options !== undefined}> <Match when={item()?.prompt.type === "select"}>
<div class="w-full flex flex-col gap-1.5"> <div class="w-full flex flex-col gap-1.5">
<div class="text-14-regular text-text-base">{select()?.title}</div> <div class="text-14-regular text-text-base">{select()?.message}</div>
<div> <div>
<List <List
class="px-3" class="px-3"
items={select()?.options ?? []} items={select()?.options ?? []}
key={(x) => x.value} key={(x) => x.value}
current={select()?.options?.find((x) => x.value === formStore.value[select()!.key])} current={select()?.options.find((x) => x.value === formStore.value[select()!.key])}
onSelect={(value) => { onSelect={(value) => {
if (!value) return if (!value) return
const field = select() const prompt = select()
if (!field) return if (!prompt) return
const nextValue = { const nextValue = {
...formStore.value, ...formStore.value,
[field.key]: value.value, [prompt.key]: value.value,
} }
setFormStore("value", field.key, value.value) setFormStore("value", prompt.key, value.value)
void next(item()!.index, nextValue) void next(item()!.index, nextValue)
}} }}
> >
@@ -683,7 +672,7 @@ function ProviderConnection(props: {
<div class="w-2.5 h-0.5 ml-0 bg-icon-strong-base hidden" data-slot="list-item-extra-icon" /> <div class="w-2.5 h-0.5 ml-0 bg-icon-strong-base hidden" data-slot="list-item-extra-icon" />
</div> </div>
<span>{option.label}</span> <span>{option.label}</span>
<span class="text-14-regular text-text-weak">{option.description}</span> <span class="text-14-regular text-text-weak">{option.hint}</span>
</div> </div>
)} )}
</List> </List>
@@ -831,7 +820,6 @@ function ProviderConnection(props: {
integrationID: props.provider, integrationID: props.provider,
location: location(), location: location(),
key: apiKey, key: apiKey,
...(store.formAnswer ? { answer: store.formAnswer } : {}),
}) })
await complete() await complete()
} }
@@ -1155,8 +1143,8 @@ function ProviderConnection(props: {
</div> </div>
</div> </div>
</Match> </Match>
<Match when={store.state === "form"}> <Match when={store.state === "prompt"}>
<AuthFormView /> <AuthPromptsView />
</Match> </Match>
<Match when={store.state === "error"}> <Match when={store.state === "error"}>
<div class="text-14-regular text-text-base"> <div class="text-14-regular text-text-base">
+2 -1
View File
@@ -662,12 +662,13 @@ export function createServerSyncContextInner(serverSDK: ServerSDK) {
integrationID: server.integrationID, integrationID: server.integrationID,
location: { directory: key }, location: { directory: key },
}) })
const method = integration.data?.methods.find((item) => item.type === "oauth" && !item.form?.length) const method = integration.data?.methods.find((item) => item.type === "oauth" && !item.prompts?.length)
if (!method || method.type !== "oauth") if (!method || method.type !== "oauth")
throw new Error(`MCP server ${name} requires an interactive authentication form`) throw new Error(`MCP server ${name} requires an interactive authentication form`)
const attempt = await serverSDK.api.integration.oauth.connect({ const attempt = await serverSDK.api.integration.oauth.connect({
integrationID: server.integrationID, integrationID: server.integrationID,
methodID: method.id, methodID: method.id,
inputs: {},
location: { directory: key }, location: { directory: key },
}) })
platform.openLink(attempt.data.url) platform.openLink(attempt.data.url)
+6 -65
View File
@@ -1,7 +1,5 @@
import type { AgentSideConnection, PermissionOption, ToolCallContent, ToolCallLocation } from "@agentclientprotocol/sdk" import type { AgentSideConnection, PermissionOption, ToolCallLocation } from "@agentclientprotocol/sdk"
import type { EventSubscribeOutput, OpenCodeClient } from "@opencode-ai/client/promise" import type { EventSubscribeOutput, OpenCodeClient } from "@opencode-ai/client/promise"
import { Patch } from "@opencode-ai/util/patch"
import { Result } from "effect"
import { isAbsolute, resolve } from "node:path" import { isAbsolute, resolve } from "node:path"
import { pendingToolCall, stringValue, toLocations, toToolKind, type ToolInput } from "./tool" import { pendingToolCall, stringValue, toLocations, toToolKind, type ToolInput } from "./tool"
@@ -28,9 +26,8 @@ export async function replyPermission(input: {
}) { }) {
const toolName = input.tool?.name ?? input.event.data.action const toolName = input.tool?.name ?? input.event.data.action
const toolInput = { ...input.event.data.metadata, ...input.tool?.input } const toolInput = { ...input.event.data.metadata, ...input.tool?.input }
const previews = await permissionPreviews(toolName, toolInput, input.cwd)
const toolCallID = input.event.data.source?.id ?? input.event.data.id const toolCallID = input.event.data.source?.id ?? input.event.data.id
const title = permissionTitle(toolName, toolInput, previews) const title = permissionTitle(toolName, toolInput, input.event.data.resources)
const result = await input.connection const result = await input.connection
.requestPermission({ .requestPermission({
sessionId: input.clientSessionID ?? input.sessionID, sessionId: input.clientSessionID ?? input.sessionID,
@@ -44,8 +41,7 @@ export async function replyPermission(input: {
}, },
cwd: input.cwd, cwd: input.cwd,
}), }),
locations: permissionLocations(toolName, toolInput, input.event.data.resources, input.cwd, previews), locations: permissionLocations(toolName, toolInput, input.event.data.resources, input.cwd),
...(previews.length > 0 ? { content: previews } : {}),
}, },
options, options,
}) })
@@ -94,54 +90,8 @@ export async function syncEditedFiles(input: {
) )
} }
async function permissionPreviews(toolName: string, input: ToolInput, cwd: string): Promise<ToolCallContent[]> { function permissionTitle(toolName: string, input: ToolInput, resources: ReadonlyArray<string>) {
const tool = toolName.toLocaleLowerCase() if (toToolKind(toolName) === "edit" && resources.length > 1) return `${resources.length} files`
if (tool === "patch" || tool === "apply_patch") return patchPreviews(input, cwd)
const path = filePath(input)
if (!path) return []
const oldText = await readText(path, cwd)
if (tool === "write") {
const content = stringValue(input.content)
return content === undefined ? [] : [{ type: "diff", path, oldText, newText: content }]
}
if (tool !== "edit") return []
const oldString = stringValue(input.oldString)
const newString = stringValue(input.newString)
if (oldString === undefined || newString === undefined) return []
const newText =
input.replaceAll === true ? oldText.replaceAll(oldString, newString) : oldText.replace(oldString, newString)
return [{ type: "diff", path, oldText, newText }]
}
async function patchPreviews(input: ToolInput, cwd: string): Promise<ToolCallContent[]> {
const patchText = stringValue(input.patchText)
if (!patchText) return []
try {
const parsed = Patch.parse(patchText)
if (Result.isFailure(parsed)) return []
return await Promise.all(
parsed.success.map(async (hunk): Promise<ToolCallContent> => {
const oldText = hunk.type === "add" ? "" : await readText(hunk.path, cwd)
if (hunk.type === "add") {
const newText = hunk.contents.endsWith("\n") || hunk.contents === "" ? hunk.contents : `${hunk.contents}\n`
return { type: "diff", path: hunk.path, oldText, newText }
}
if (hunk.type === "delete") return { type: "diff", path: hunk.path, oldText, newText: "" }
return {
type: "diff",
path: hunk.movePath ?? hunk.path,
oldText,
newText: Patch.derive(hunk.path, hunk.chunks, oldText).content,
}
}),
)
} catch {
return []
}
}
function permissionTitle(toolName: string, input: ToolInput, previews: ReadonlyArray<ToolCallContent>) {
if (previews.length > 1) return `${previews.length} files`
switch (toolName.toLocaleLowerCase()) { switch (toolName.toLocaleLowerCase()) {
case "external_directory": case "external_directory":
return stringValue(input.description) ?? stringValue(input.command) ?? stringValue(input.parentDir) return stringValue(input.description) ?? stringValue(input.command) ?? stringValue(input.parentDir)
@@ -157,7 +107,7 @@ function permissionTitle(toolName: string, input: ToolInput, previews: ReadonlyA
case "write": case "write":
case "patch": case "patch":
case "apply_patch": case "apply_patch":
return filePath(input) ?? (previews[0]?.type === "diff" ? previews[0].path : undefined) return filePath(input)
default: default:
return undefined return undefined
} }
@@ -168,21 +118,12 @@ function permissionLocations(
input: ToolInput, input: ToolInput,
resources: ReadonlyArray<string>, resources: ReadonlyArray<string>,
cwd: string, cwd: string,
previews: ReadonlyArray<ToolCallContent>,
): ToolCallLocation[] { ): ToolCallLocation[] {
const paths = previews.flatMap((preview) => (preview.type === "diff" ? [preview.path] : []))
if (paths.length > 0) return [...new Set(paths)].map((path) => ({ path }))
const locations = toLocations(toolName, input, cwd) const locations = toLocations(toolName, input, cwd)
if (locations.length > 0) return locations if (locations.length > 0) return locations
return resources.filter((resource) => resource !== "*").map((path) => ({ path })) return resources.filter((resource) => resource !== "*").map((path) => ({ path }))
} }
function readText(path: string, cwd: string) {
return Bun.file(resolvePath(path, cwd))
.text()
.catch(() => "")
}
function filePath(input: ToolInput) { function filePath(input: ToolInput) {
return stringValue(input.path) ?? stringValue(input.filePath) ?? stringValue(input.filepath) return stringValue(input.path) ?? stringValue(input.filePath) ?? stringValue(input.filepath)
} }
@@ -50,7 +50,7 @@ const login = Effect.fn("cli.console.login.run")(function* (timeline: TimelineHo
{ {
integrationID, integrationID,
methodID: method.id, methodID: method.id,
...(server ? { answer: { server } } : {}), inputs: server ? { server } : {},
location, location,
}, },
{ signal }, { signal },
@@ -32,7 +32,7 @@ export default Runtime.handler(
return yield* Effect.fail(new Error(`MCP server "${input.name}" is not an OAuth-capable remote server`)) return yield* Effect.fail(new Error(`MCP server "${input.name}" is not an OAuth-capable remote server`))
const started = yield* Effect.promise(() => const started = yield* Effect.promise(() =>
client.integration.oauth.connect({ integrationID: integration.id, methodID: method.id, location }), client.integration.oauth.connect({ integrationID: integration.id, methodID: method.id, inputs: {}, location }),
) )
const attempt = started.data const attempt = started.data
if (attempt.mode === "code") if (attempt.mode === "code")
@@ -211,7 +211,7 @@ describe("acp permission behavior", () => {
} }
}) })
test("previews edits during approval and syncs the completed file", async () => { test("authorizes edit resources and syncs the completed file", async () => {
const cwd = await fs.mkdtemp(path.join(os.tmpdir(), "opencode-acp-permission-")) const cwd = await fs.mkdtemp(path.join(os.tmpdir(), "opencode-acp-permission-"))
const file = path.join(cwd, "file.ts") const file = path.join(cwd, "file.ts")
await fs.writeFile(file, "before") await fs.writeFile(file, "before")
@@ -240,6 +240,7 @@ describe("acp permission behavior", () => {
send( send(
permissionAsked("ses_edit", "perm_edit", { permissionAsked("ses_edit", "perm_edit", {
action: "edit", action: "edit",
resources: ["file.ts"],
source: { type: "tool", messageID: "msg_edit", id: "call_edit" }, source: { type: "tool", messageID: "msg_edit", id: "call_edit" },
}), }),
) )
@@ -278,8 +279,8 @@ describe("acp permission behavior", () => {
title: "file.ts", title: "file.ts",
kind: "edit", kind: "edit",
locations: [{ path: "file.ts" }], locations: [{ path: "file.ts" }],
content: [{ type: "diff", path: "file.ts", oldText: "before", newText: "after" }],
}) })
expect(permissionRequests[0]?.toolCall.content).toBeUndefined()
expect(writes).toEqual([{ sessionId: "ses_edit", path: file, content: "after" }]) expect(writes).toEqual([{ sessionId: "ses_edit", path: file, content: "after" }])
} finally { } finally {
await fixture.stop() await fixture.stop()
@@ -287,7 +288,7 @@ describe("acp permission behavior", () => {
} }
}) })
test("previews and syncs each file in a patch", async () => { test("authorizes and syncs each file in a patch", async () => {
const cwd = await fs.mkdtemp(path.join(os.tmpdir(), "opencode-acp-patch-permission-")) const cwd = await fs.mkdtemp(path.join(os.tmpdir(), "opencode-acp-patch-permission-"))
await Promise.all([ await Promise.all([
fs.writeFile(path.join(cwd, "first.ts"), "one\n"), fs.writeFile(path.join(cwd, "first.ts"), "one\n"),
@@ -330,6 +331,7 @@ describe("acp permission behavior", () => {
send( send(
permissionAsked("ses_patch", "perm_patch", { permissionAsked("ses_patch", "perm_patch", {
action: "edit", action: "edit",
resources: ["first.ts", "second.ts"],
source: { type: "tool", messageID: "msg_patch", id: "call_patch" }, source: { type: "tool", messageID: "msg_patch", id: "call_patch" },
}), }),
) )
@@ -371,11 +373,8 @@ describe("acp permission behavior", () => {
title: "2 files", title: "2 files",
kind: "edit", kind: "edit",
locations: [{ path: "first.ts" }, { path: "second.ts" }], locations: [{ path: "first.ts" }, { path: "second.ts" }],
content: [
{ type: "diff", path: "first.ts", oldText: "one\n", newText: "two\n" },
{ type: "diff", path: "second.ts", oldText: "alpha\n", newText: "beta\n" },
],
}) })
expect(permissionRequests[0]?.toolCall.content).toBeUndefined()
expect(writes.toSorted((a, b) => a.path.localeCompare(b.path))).toEqual([ expect(writes.toSorted((a, b) => a.path.localeCompare(b.path))).toEqual([
{ sessionId: "ses_patch", path: path.join(cwd, "first.ts"), content: "two\n" }, { sessionId: "ses_patch", path: path.join(cwd, "first.ts"), content: "two\n" },
{ sessionId: "ses_patch", path: path.join(cwd, "second.ts"), content: "beta\n" }, { sessionId: "ses_patch", path: path.join(cwd, "second.ts"), content: "beta\n" },
@@ -556,6 +555,7 @@ function permissionAsked(
id: string, id: string,
input: { input: {
readonly action?: string readonly action?: string
readonly resources?: ReadonlyArray<string>
readonly metadata?: Record<string, unknown> readonly metadata?: Record<string, unknown>
readonly source?: { readonly type: "tool"; readonly messageID: string; readonly id: string } readonly source?: { readonly type: "tool"; readonly messageID: string; readonly id: string }
} = {}, } = {},
@@ -564,7 +564,7 @@ function permissionAsked(
id, id,
sessionID, sessionID,
action: input.action ?? "shell", action: input.action ?? "shell",
resources: ["*"], resources: [...(input.resources ?? ["*"])],
metadata: input.metadata ?? { command: "printf hello" }, metadata: input.metadata ?? { command: "printf hello" },
...(input.source ? { source: input.source } : {}), ...(input.source ? { source: input.source } : {}),
}) })
+2 -3
View File
@@ -23,9 +23,9 @@ import type { Shell } from "@opencode-ai/schema/shell"
import type { DateTime } from "effect" import type { DateTime } from "effect"
import type { Provider } from "@opencode-ai/schema/provider" import type { Provider } from "@opencode-ai/schema/provider"
import type { Integration } from "@opencode-ai/schema/integration" import type { Integration } from "@opencode-ai/schema/integration"
import type { Form } from "@opencode-ai/schema/form"
import type { Mcp } from "@opencode-ai/schema/mcp" import type { Mcp } from "@opencode-ai/schema/mcp"
import type { Credential } from "@opencode-ai/schema/credential" import type { Credential } from "@opencode-ai/schema/credential"
import type { Form } from "@opencode-ai/schema/form"
import type { Permission } from "@opencode-ai/schema/permission" import type { Permission } from "@opencode-ai/schema/permission"
import type { PermissionSaved } from "@opencode-ai/schema/permission-saved" import type { PermissionSaved } from "@opencode-ai/schema/permission-saved"
import type { FileSystem } from "@opencode-ai/schema/filesystem" import type { FileSystem } from "@opencode-ai/schema/filesystem"
@@ -1054,7 +1054,6 @@ export type Endpoint10_3Input = {
readonly integrationID: Integration.ID readonly integrationID: Integration.ID
readonly location?: { readonly directory?: string | undefined; readonly workspace?: string | undefined } | undefined readonly location?: { readonly directory?: string | undefined; readonly workspace?: string | undefined } | undefined
readonly key: string readonly key: string
readonly answer?: Form.Answer | undefined
readonly label?: string | undefined readonly label?: string | undefined
} }
export type Endpoint10_3Output = void export type Endpoint10_3Output = void
@@ -1066,7 +1065,7 @@ export type Endpoint10_4Input = {
readonly integrationID: Integration.ID readonly integrationID: Integration.ID
readonly location?: { readonly directory?: string | undefined; readonly workspace?: string | undefined } | undefined readonly location?: { readonly directory?: string | undefined; readonly workspace?: string | undefined } | undefined
readonly methodID: Integration.MethodID readonly methodID: Integration.MethodID
readonly answer?: Form.Answer | undefined readonly inputs: { readonly [x: string]: string }
readonly label?: string | undefined readonly label?: string | undefined
} }
export type Endpoint10_4Output = { readonly location: Location.Info; readonly data: Integration.Attempt } export type Endpoint10_4Output = { readonly location: Location.Info; readonly data: Integration.Attempt }
@@ -717,7 +717,7 @@ const Endpoint10_3 = (raw: RawClient["server.integration"]) => (input: Endpoint1
raw["integration.connect.key"]({ raw["integration.connect.key"]({
params: { integrationID: input["integrationID"] }, params: { integrationID: input["integrationID"] },
query: { location: input["location"] }, query: { location: input["location"] },
payload: { key: input["key"], answer: input["answer"], label: input["label"] }, payload: { key: input["key"], label: input["label"] },
}).pipe(Effect.mapError(mapClientError)), }).pipe(Effect.mapError(mapClientError)),
) )
@@ -726,7 +726,7 @@ const Endpoint10_4 = (raw: RawClient["server.integration"]) => (input: Endpoint1
raw["integration.oauth.connect"]({ raw["integration.oauth.connect"]({
params: { integrationID: input["integrationID"] }, params: { integrationID: input["integrationID"] },
query: { location: input["location"] }, query: { location: input["location"] },
payload: { methodID: input["methodID"], answer: input["answer"], label: input["label"] }, payload: { methodID: input["methodID"], inputs: input["inputs"], label: input["label"] },
}).pipe(Effect.mapError(mapClientError)), }).pipe(Effect.mapError(mapClientError)),
) )
@@ -1032,7 +1032,7 @@ export function make(options: ClientOptions) {
method: "POST", method: "POST",
path: `/api/integration/${encodeURIComponent(input.integrationID)}/connect/key`, path: `/api/integration/${encodeURIComponent(input.integrationID)}/connect/key`,
query: { location: input["location"] }, query: { location: input["location"] },
body: { key: input["key"], answer: input["answer"], label: input["label"] }, body: { key: input["key"], label: input["label"] },
successStatus: 204, successStatus: 204,
declaredStatuses: [400, 401], declaredStatuses: [400, 401],
empty: true, empty: true,
@@ -1047,7 +1047,7 @@ export function make(options: ClientOptions) {
method: "POST", method: "POST",
path: `/api/integration/${encodeURIComponent(input.integrationID)}/connect/oauth`, path: `/api/integration/${encodeURIComponent(input.integrationID)}/connect/oauth`,
query: { location: input["location"] }, query: { location: input["location"] },
body: { methodID: input["methodID"], answer: input["answer"], label: input["label"] }, body: { methodID: input["methodID"], inputs: input["inputs"], label: input["label"] },
successStatus: 200, successStatus: 200,
declaredStatuses: [400, 401], declaredStatuses: [400, 401],
empty: false, empty: false,
+80 -70
View File
@@ -195,18 +195,12 @@ export type ProviderInfo = {
body?: { [x: string]: any } body?: { [x: string]: any }
} }
export type FormWhen = { export type IntegrationWhen = { key: string; op: "eq" | "neq"; value: string }
key: string
op: "eq" | "neq"
value: string | number | "Infinity" | "-Infinity" | "NaN" | boolean
}
export type FormOption = { value: string; label: string; description?: string }
export type FormExternalField = { key: string; type: "external"; url: string; title?: string; description?: string }
export type IntegrationCommandMethod = { id: string; type: "command"; label: string; command: Array<string> } export type IntegrationCommandMethod = { id: string; type: "command"; label: string; command: Array<string> }
export type IntegrationKeyMethod = { type: "key"; label?: string }
export type IntegrationEnvMethod = { type: "env"; names: Array<string> } export type IntegrationEnvMethod = { type: "env"; names: Array<string> }
export type ConnectionCredentialInfo = { type: "credential"; id: string; label: string } export type ConnectionCredentialInfo = { type: "credential"; id: string; label: string }
@@ -291,6 +285,16 @@ export type ProjectDirectory = { directory: string; strategy?: string }
export type FormMetadata = { [x: string]: JsonValue } export type FormMetadata = { [x: string]: JsonValue }
export type FormWhen = {
key: string
op: "eq" | "neq"
value: string | number | "Infinity" | "-Infinity" | "NaN" | boolean
}
export type FormOption = { value: string; label: string; description?: string }
export type FormExternalField = { key: string; type: "external"; url: string; title?: string; description?: string }
export type FormValue = string | number | boolean | Array<string> export type FormValue = string | number | boolean | Array<string>
export type PermissionSource = { type: "tool"; messageID: string; id: string } export type PermissionSource = { type: "tool"; messageID: string; id: string }
@@ -1273,6 +1277,45 @@ export type ModelCost = {
cache: { read: MoneyUSDPerMillionTokens; write: MoneyUSDPerMillionTokens } cache: { read: MoneyUSDPerMillionTokens; write: MoneyUSDPerMillionTokens }
} }
export type IntegrationTextPrompt = {
type: "text"
key: string
message: string
placeholder?: string
when?: IntegrationWhen
}
export type IntegrationSelectPrompt = {
type: "select"
key: string
message: string
options: Array<{ label: string; value: string; hint?: string }>
when?: IntegrationWhen
}
export type ConnectionInfo = ConnectionCredentialInfo | ConnectionEnvInfo
export type McpServer = {
name: string
status: McpStatusConnected | McpStatusPending | McpStatusDisabled | McpStatusFailed | McpStatusNeedsAuth
integrationID?: string
}
export type McpResourceCatalog = { resources: Array<McpResource>; templates: Array<McpResourceTemplate> }
export type Project = {
id: string
canonical: string
vcs?: ProjectVcs
name?: string
icon?: ProjectIcon
commands?: ProjectCommands
time: ProjectTime
sandboxes: Array<string>
}
export type ProjectDirectories = Array<ProjectDirectory>
export type FormNumberField = { export type FormNumberField = {
key: string key: string
title?: string title?: string
@@ -1338,29 +1381,6 @@ export type FormMultiselectField = {
default?: Array<string> default?: Array<string>
} }
export type ConnectionInfo = ConnectionCredentialInfo | ConnectionEnvInfo
export type McpServer = {
name: string
status: McpStatusConnected | McpStatusPending | McpStatusDisabled | McpStatusFailed | McpStatusNeedsAuth
integrationID?: string
}
export type McpResourceCatalog = { resources: Array<McpResource>; templates: Array<McpResourceTemplate> }
export type Project = {
id: string
canonical: string
vcs?: ProjectVcs
name?: string
icon?: ProjectIcon
commands?: ProjectCommands
time: ProjectTime
sandboxes: Array<string>
}
export type ProjectDirectories = Array<ProjectDirectory>
export type FormAnswer = { [x: string]: FormValue } export type FormAnswer = { [x: string]: FormValue }
export type PermissionRequest = { export type PermissionRequest = {
@@ -1644,6 +1664,13 @@ export type ModelInfo = {
limit: { context: number; input?: number; output: number } limit: { context: number; input?: number; output: number }
} }
export type IntegrationOAuthMethod = {
id: string
type: "oauth"
label: string
prompts?: Array<IntegrationTextPrompt | IntegrationSelectPrompt>
}
export type FormField = export type FormField =
| FormStringField | FormStringField
| FormNumberField | FormNumberField
@@ -1897,9 +1924,15 @@ export type SessionMessageAssistantTool = {
time: { created: number; ran?: number; completed?: number } time: { created: number; ran?: number; completed?: number }
} }
export type IntegrationMethod =
| IntegrationOAuthMethod
| IntegrationCommandMethod
| IntegrationKeyMethod
| IntegrationEnvMethod
export type FormFields = [FormField, ...Array<FormField>] export type FormFields = [FormField, ...Array<FormField>]
export type FormFields3 = [FormField1, ...Array<FormField1>] export type FormFields1 = [FormField1, ...Array<FormField1>]
export type SessionPendingInfo = SessionPendingUser | SessionPendingSynthetic | SessionPendingCompaction export type SessionPendingInfo = SessionPendingUser | SessionPendingSynthetic | SessionPendingCompaction
@@ -1921,13 +1954,16 @@ export type SessionMessageAssistant = {
retry?: SessionMessageAssistantRetry retry?: SessionMessageAssistantRetry
} }
export type IntegrationOAuthMethod = { id: string; type: "oauth"; label: string; form?: FormFields } export type IntegrationInfo = {
id: string
export type IntegrationKeyMethod = { type: "key"; label?: string; form?: FormFields } name: string
methods: Array<IntegrationMethod>
connections: Array<ConnectionInfo>
}
export type FormInfo = { id: string; sessionID: string; title: string; metadata?: FormMetadata; fields: FormFields } export type FormInfo = { id: string; sessionID: string; title: string; metadata?: FormMetadata; fields: FormFields }
export type FormInfo1 = { id: string; sessionID: string; title: string; metadata?: FormMetadata1; fields: FormFields3 } export type FormInfo1 = { id: string; sessionID: string; title: string; metadata?: FormMetadata1; fields: FormFields1 }
export type SessionInputAdmitted = { export type SessionInputAdmitted = {
id: string id: string
@@ -1950,12 +1986,6 @@ export type SessionMessageInfo =
| SessionMessageAssistant | SessionMessageAssistant
| SessionMessageCompaction | SessionMessageCompaction
export type IntegrationMethod =
| IntegrationOAuthMethod
| IntegrationCommandMethod
| IntegrationKeyMethod
| IntegrationEnvMethod
export type FormCreated = { export type FormCreated = {
id: string id: string
created: number created: number
@@ -2016,13 +2046,6 @@ export type SessionMessagesResponse = {
cursor: { previous?: string | null; next?: string | null } cursor: { previous?: string | null; next?: string | null }
} }
export type IntegrationInfo = {
id: string
name: string
methods: Array<IntegrationMethod>
connections: Array<ConnectionInfo>
}
export type V2Event = export type V2Event =
| ModelsDevRefreshed | ModelsDevRefreshed
| IntegrationUpdated | IntegrationUpdated
@@ -4022,21 +4045,8 @@ export type IntegrationConnectKeyInput = {
readonly location?: { readonly location?: {
readonly location?: { readonly directory?: string | undefined; readonly workspace?: string | undefined } | undefined readonly location?: { readonly directory?: string | undefined; readonly workspace?: string | undefined } | undefined
}["location"] }["location"]
readonly key: { readonly key: { readonly key: string; readonly label?: string | undefined }["key"]
readonly key: string readonly label?: { readonly key: string; readonly label?: string | undefined }["label"]
readonly answer?: { readonly [x: string]: string | number | boolean | ReadonlyArray<string> } | undefined
readonly label?: string | undefined
}["key"]
readonly answer?: {
readonly key: string
readonly answer?: { readonly [x: string]: string | number | boolean | ReadonlyArray<string> } | undefined
readonly label?: string | undefined
}["answer"]
readonly label?: {
readonly key: string
readonly answer?: { readonly [x: string]: string | number | boolean | ReadonlyArray<string> } | undefined
readonly label?: string | undefined
}["label"]
} }
export type IntegrationConnectKeyOutput = void export type IntegrationConnectKeyOutput = void
@@ -4048,17 +4058,17 @@ export type IntegrationOauthConnectInput = {
}["location"] }["location"]
readonly methodID: { readonly methodID: {
readonly methodID: string readonly methodID: string
readonly answer?: { readonly [x: string]: string | number | boolean | ReadonlyArray<string> } | undefined readonly inputs: { readonly [x: string]: string }
readonly label?: string | undefined readonly label?: string | undefined
}["methodID"] }["methodID"]
readonly answer?: { readonly inputs: {
readonly methodID: string readonly methodID: string
readonly answer?: { readonly [x: string]: string | number | boolean | ReadonlyArray<string> } | undefined readonly inputs: { readonly [x: string]: string }
readonly label?: string | undefined readonly label?: string | undefined
}["answer"] }["inputs"]
readonly label?: { readonly label?: {
readonly methodID: string readonly methodID: string
readonly answer?: { readonly [x: string]: string | number | boolean | ReadonlyArray<string> } | undefined readonly inputs: { readonly [x: string]: string }
readonly label?: string | undefined readonly label?: string | undefined
}["label"] }["label"]
} }
-43
View File
@@ -148,49 +148,6 @@ test("experimental wellknown integration add uses the public HTTP contract", asy
expect(await request?.json()).toEqual({ url: "https://example.com" }) expect(await request?.json()).toEqual({ url: "https://example.com" })
}) })
test("integration connections optionally submit a form answer", async () => {
const requests: Request[] = []
const client = OpenCode.make({
baseUrl: "http://localhost:3000",
fetch: async (input, init) => {
const request = input instanceof Request ? input : new Request(input, init)
requests.push(request)
if (request.url.endsWith("/connect/key")) return new Response(null, { status: 204 })
return Response.json({
location: { directory: "/tmp/project", project: { id: "proj_test", directory: "/tmp/project" } },
data: {
attemptID: "con_test",
url: "https://example.com/authorize",
instructions: "Authorize",
mode: "auto",
time: { created: 1, expires: 2 },
},
})
},
})
await client.integration.connect.key({
integrationID: "cloudflare-workers-ai",
key: "secret",
answer: { accountId: "account" },
})
await client.integration.oauth.connect({
integrationID: "github-copilot",
methodID: "device",
answer: { deploymentType: "enterprise", enabled: true, scopes: ["read:user"] },
})
await client.integration.connect.key({ integrationID: "openai", key: "secret" })
await client.integration.oauth.connect({ integrationID: "openai", methodID: "device" })
expect(await requests[0].json()).toEqual({ key: "secret", answer: { accountId: "account" } })
expect(await requests[1].json()).toEqual({
methodID: "device",
answer: { deploymentType: "enterprise", enabled: true, scopes: ["read:user"] },
})
expect(await requests[2].json()).toEqual({ key: "secret" })
expect(await requests[3].json()).toEqual({ methodID: "device" })
})
test("health.stop sends exact replacement identity", async () => { test("health.stop sends exact replacement identity", async () => {
let request: Request | undefined let request: Request | undefined
const client = OpenCode.make({ const client = OpenCode.make({
+30 -41
View File
@@ -48,15 +48,13 @@ export const readText = Effect.fn("FileMutation.readText")(function* (files: Fil
return Bom.decodeBytes((yield* files.read(target)).bytes) return Bom.decodeBytes((yield* files.read(target)).bytes)
}) })
export const syncTextBom = Effect.fn("FileMutation.syncTextBom")(function* ( export const syncTextBom = Effect.fn("FileMutation.syncTextBom")((files: Files, target: string, bom: boolean) =>
files: Files, Effect.gen(function* () {
target: string, const synced = Bom.syncBytes((yield* files.read(target)).bytes, bom)
bom: boolean, if (synced.bytes) yield* files.write(target, synced.bytes)
) { return synced.text
const synced = Bom.syncBytes((yield* files.read(target)).bytes, bom) }).pipe(Effect.uninterruptible),
if (synced.bytes) yield* files.write(target, synced.bytes) )
return synced.text
})
/** Share transaction locks across Location graphs that address the same file. */ /** Share transaction locks across Location graphs that address the same file. */
const transactionLocks = KeyedMutex.makeUnsafe<string>() const transactionLocks = KeyedMutex.makeUnsafe<string>()
@@ -70,15 +68,10 @@ const layer = Layer.effect(
Service, Service,
Effect.gen(function* () { Effect.gen(function* () {
const environment = yield* Environment.Service const environment = yield* Environment.Service
const locks = KeyedMutex.makeUnsafe<string>()
const withLock: Interface["withLock"] = (targets) => (effect) => const withLock: Interface["withLock"] = (targets) => (effect) =>
[...new Set(targets.map(FSUtil.resolve))] [...new Set(targets.map(FSUtil.resolve))]
.sort() .sort()
.reduceRight((result, target) => transactionLocks.withLock(target)(result), effect) .reduceRight((result, target) => transactionLocks.withLock(target)(result), effect)
const withTargetLock =
(target: Target) =>
<A, E, R>(effect: Effect.Effect<A, E, R>) =>
locks.withLock(target.absolute)(Effect.uninterruptible(effect))
const writeResult = (target: Target, existed: boolean): WriteResult => ({ const writeResult = (target: Target, existed: boolean): WriteResult => ({
operation: "write", operation: "write",
@@ -88,36 +81,32 @@ const layer = Layer.effect(
}) })
const write = Effect.fn("FileMutation.write")((input: WriteInput) => const write = Effect.fn("FileMutation.write")((input: WriteInput) =>
withTargetLock(input.target)( Effect.gen(function* () {
Effect.gen(function* () { const existed = yield* environment.files.stat(input.target.absolute).pipe(
const existed = yield* environment.files.stat(input.target.absolute).pipe( Effect.as(true),
Effect.as(true), Effect.catchTag("Environment.NotFound", () => Effect.succeed(false)),
Effect.catchTag("Environment.NotFound", () => Effect.succeed(false)), )
) yield* environment.files.write(
yield* environment.files.write( input.target.absolute,
input.target.absolute, typeof input.content === "string" ? new TextEncoder().encode(input.content) : input.content,
typeof input.content === "string" ? new TextEncoder().encode(input.content) : input.content, )
) return writeResult(input.target, existed)
return writeResult(input.target, existed) }).pipe(Effect.uninterruptible),
}),
),
) )
const writeTextPreservingBom = Effect.fn("FileMutation.writeTextPreservingBom")((input: TextWriteInput) => const writeTextPreservingBom = Effect.fn("FileMutation.writeTextPreservingBom")((input: TextWriteInput) =>
withTargetLock(input.target)( Effect.gen(function* () {
Effect.gen(function* () { const next = Bom.split(input.content)
const next = Bom.split(input.content) const current = yield* environment.files.read(input.target.absolute, { offset: 0, length: 3 }).pipe(
const current = yield* environment.files.read(input.target.absolute, { offset: 0, length: 3 }).pipe( Effect.map((result) => result.bytes),
Effect.map((result) => result.bytes), Effect.catchTag("Environment.NotFound", () => Effect.succeed(undefined)),
Effect.catchTag("Environment.NotFound", () => Effect.succeed(undefined)), )
) yield* environment.files.write(
yield* environment.files.write( input.target.absolute,
input.target.absolute, new TextEncoder().encode(Bom.join(next.text, Boolean(current && Bom.has(current)) || next.bom)),
new TextEncoder().encode(Bom.join(next.text, Boolean(current && Bom.has(current)) || next.bom)), )
) return writeResult(input.target, current !== undefined)
return writeResult(input.target, current !== undefined) }).pipe(Effect.uninterruptible),
}),
),
) )
return Service.of({ withLock, write, writeTextPreservingBom }) return Service.of({ withLock, write, writeTextPreservingBom })
+5 -5
View File
@@ -180,7 +180,7 @@ export const layer = Layer.effect(
Effect.gen(function* () { Effect.gen(function* () {
const entry = yield* find(input.id) const entry = yield* find(input.id)
if (entry.state.status !== "pending") return yield* new AlreadySettledError({ id: input.id }) if (entry.state.status !== "pending") return yield* new AlreadySettledError({ id: input.id })
const invalid = validateAnswer(entry.form.fields, input.answer) const invalid = validateAnswer(entry.form, input.answer)
if (invalid) return yield* new InvalidAnswerError({ id: input.id, message: invalid }) if (invalid) return yield* new InvalidAnswerError({ id: input.id, message: invalid })
const next: TerminalState = { status: "answered", answer: input.answer } const next: TerminalState = { status: "answered", answer: input.answer }
yield* bus.publish(Form.Event.Replied, { yield* bus.publish(Form.Event.Replied, {
@@ -227,12 +227,12 @@ export const locationLayer = layer
export const node = makeLocationNode({ service: Service, layer, deps: [Bus.node] }) export const node = makeLocationNode({ service: Service, layer, deps: [Bus.node] })
export function validateAnswer(form: ReadonlyArray<Form.Field>, answer: Answer) { function validateAnswer(form: Info, answer: Answer) {
const fields = new Map(form.map((field) => [field.key, field] as const)) const fields = new Map(form.fields.map((field) => [field.key, field] as const))
for (const key of Object.keys(answer)) { for (const key of Object.keys(answer)) {
if (!fields.has(key)) return `Unknown form field: ${key}` if (!fields.has(key)) return `Unknown form field: ${key}`
} }
for (const field of form) { for (const field of form.fields) {
const value = answer[field.key] const value = answer[field.key]
if (field.type === "external") { if (field.type === "external") {
if (value !== true) return `External form field must be acknowledged: ${field.key}` if (value !== true) return `External form field must be acknowledged: ${field.key}`
@@ -268,7 +268,7 @@ function matches(when: Form.When, value: Form.Value | undefined) {
// carry a value matching that field's type, and use a declared option when the field's options // carry a value matching that field's type, and use a declared option when the field's options
// are closed. Rejecting these at creation surfaces authoring mistakes to the caller instead of // are closed. Rejecting these at creation surfaces authoring mistakes to the caller instead of
// silently never matching. // silently never matching.
export function validateFields(fields: ReadonlyArray<Form.Field>) { function validateFields(fields: ReadonlyArray<Form.Field>) {
if (fields.length === 0) return "Form must have at least one field" if (fields.length === 0) return "Form must have at least one field"
const earlier = new Map<string, InputField>() const earlier = new Map<string, InputField>()
const keys = new Set<string>() const keys = new Set<string>()
@@ -127,7 +127,7 @@ export async function convertToOpenAIResponsesInput({
input.push({ input.push({
role: "assistant", role: "assistant",
content: [{ type: "output_text", text: part.text }], content: [{ type: "output_text", text: part.text }],
id: store ? ((part.providerOptions?.copilot?.itemId as string) ?? undefined) : undefined, id: (part.providerOptions?.copilot?.itemId as string) ?? undefined,
}) })
break break
} }
@@ -143,7 +143,7 @@ export async function convertToOpenAIResponsesInput({
input.push({ input.push({
type: "local_shell_call", type: "local_shell_call",
call_id: part.toolCallId, call_id: part.toolCallId,
id: store ? ((part.providerOptions?.copilot?.itemId as string) ?? undefined) : undefined, id: (part.providerOptions?.copilot?.itemId as string) ?? undefined,
action: { action: {
type: "exec", type: "exec",
command: parsedInput.action.command, command: parsedInput.action.command,
@@ -162,7 +162,7 @@ export async function convertToOpenAIResponsesInput({
call_id: part.toolCallId, call_id: part.toolCallId,
name: part.toolName, name: part.toolName,
arguments: JSON.stringify(part.input), arguments: JSON.stringify(part.input),
id: store ? ((part.providerOptions?.copilot?.itemId as string) ?? undefined) : undefined, id: (part.providerOptions?.copilot?.itemId as string) ?? undefined,
}) })
break break
} }
@@ -206,14 +206,35 @@ export async function convertToOpenAIResponsesInput({
summary: [], summary: [],
} }
} }
} else if (providerOptions?.reasoningEncryptedContent != null && reasoningMessage === undefined) { } else {
reasoningMessages[reasoningId] = { const summaryParts: Array<{
type: "reasoning", type: "summary_text"
id: reasoningId, text: string
encrypted_content: providerOptions.reasoningEncryptedContent, }> = []
summary: [],
if (part.text.length > 0) {
summaryParts.push({
type: "summary_text",
text: part.text,
})
} else if (reasoningMessage !== undefined) {
warnings.push({
type: "other",
message: `Cannot append empty reasoning part to existing reasoning sequence. Skipping reasoning part: ${JSON.stringify(part)}.`,
})
}
if (reasoningMessage === undefined) {
reasoningMessages[reasoningId] = {
type: "reasoning",
id: reasoningId,
encrypted_content: providerOptions?.reasoningEncryptedContent,
summary: summaryParts,
}
input.push(reasoningMessages[reasoningId])
} else {
reasoningMessage.summary.push(...summaryParts)
} }
input.push(reasoningMessages[reasoningId])
} }
} else { } else {
warnings.push({ warnings.push({
@@ -71,7 +71,7 @@ export type OpenAIResponsesComputerCall = {
export type OpenAIResponsesLocalShellCall = { export type OpenAIResponsesLocalShellCall = {
type: "local_shell_call" type: "local_shell_call"
id?: string id: string
call_id: string call_id: string
action: { action: {
type: "exec" type: "exec"
@@ -198,13 +198,12 @@ export class OpenAIResponsesLanguageModel implements LanguageModelV3 {
providerOptions, providerOptions,
schema: openaiResponsesProviderOptionsSchema, schema: openaiResponsesProviderOptionsSchema,
}) })
const store = openaiOptions?.store ?? false
const { input, warnings: inputWarnings } = await convertToOpenAIResponsesInput({ const { input, warnings: inputWarnings } = await convertToOpenAIResponsesInput({
prompt, prompt,
systemMessageMode: modelConfig.systemMessageMode, systemMessageMode: modelConfig.systemMessageMode,
fileIdPrefixes: this.config.fileIdPrefixes, fileIdPrefixes: this.config.fileIdPrefixes,
store, store: openaiOptions?.store ?? true,
hasLocalShellTool: hasOpenAITool("openai.local_shell"), hasLocalShellTool: hasOpenAITool("openai.local_shell"),
}) })
@@ -215,12 +214,9 @@ export class OpenAIResponsesLanguageModel implements LanguageModelV3 {
let include: OpenAIResponsesIncludeOptions = openaiOptions?.include let include: OpenAIResponsesIncludeOptions = openaiOptions?.include
function addInclude(key: OpenAIResponsesIncludeValue) { function addInclude(key: OpenAIResponsesIncludeValue) {
if (include?.includes(key)) return
include = include != null ? [...include, key] : [key] include = include != null ? [...include, key] : [key]
} }
addInclude("reasoning.encrypted_content")
function hasOpenAITool(id: string) { function hasOpenAITool(id: string) {
return tools?.find((tool) => tool.type === "provider" && tool.id === id) != null return tools?.find((tool) => tool.type === "provider" && tool.id === id) != null
} }
@@ -286,7 +282,7 @@ export class OpenAIResponsesLanguageModel implements LanguageModelV3 {
metadata: openaiOptions?.metadata, metadata: openaiOptions?.metadata,
parallel_tool_calls: openaiOptions?.parallelToolCalls, parallel_tool_calls: openaiOptions?.parallelToolCalls,
previous_response_id: openaiOptions?.previousResponseId, previous_response_id: openaiOptions?.previousResponseId,
store, store: openaiOptions?.store,
user: openaiOptions?.user, user: openaiOptions?.user,
instructions: openaiOptions?.instructions, instructions: openaiOptions?.instructions,
service_tier: openaiOptions?.serviceTier, service_tier: openaiOptions?.serviceTier,
@@ -844,7 +840,7 @@ export class OpenAIResponsesLanguageModel implements LanguageModelV3 {
{ {
canonicalId: string // the item.id from output_item.added canonicalId: string // the item.id from output_item.added
encryptedContent?: string | null encryptedContent?: string | null
summaryParts: Record<number, "active" | "can-conclude" | "concluded"> summaryParts: number[]
} }
> = {} > = {}
@@ -964,14 +960,10 @@ export class OpenAIResponsesLanguageModel implements LanguageModelV3 {
}, },
}) })
} else if (isResponseOutputItemAddedReasoningChunk(value)) { } else if (isResponseOutputItemAddedReasoningChunk(value)) {
if (activeReasoning[value.output_index]) {
currentReasoningOutputIndex = value.output_index
return
}
activeReasoning[value.output_index] = { activeReasoning[value.output_index] = {
canonicalId: value.item.id, canonicalId: value.item.id,
encryptedContent: value.item.encrypted_content, encryptedContent: value.item.encrypted_content,
summaryParts: { 0: "active" }, summaryParts: [0],
} }
currentReasoningOutputIndex = value.output_index currentReasoningOutputIndex = value.output_index
@@ -1125,14 +1117,13 @@ export class OpenAIResponsesLanguageModel implements LanguageModelV3 {
} else if (isResponseOutputItemDoneReasoningChunk(value)) { } else if (isResponseOutputItemDoneReasoningChunk(value)) {
const activeReasoningPart = activeReasoning[value.output_index] const activeReasoningPart = activeReasoning[value.output_index]
if (activeReasoningPart) { if (activeReasoningPart) {
for (const [summaryIndex, status] of Object.entries(activeReasoningPart.summaryParts)) { for (const summaryIndex of activeReasoningPart.summaryParts) {
if (status === "concluded") continue
controller.enqueue({ controller.enqueue({
type: "reasoning-end", type: "reasoning-end",
id: `${activeReasoningPart.canonicalId}:${summaryIndex}`, id: `${activeReasoningPart.canonicalId}:${summaryIndex}`,
providerMetadata: { providerMetadata: {
copilot: { copilot: {
itemId: value.item.id, itemId: activeReasoningPart.canonicalId,
reasoningEncryptedContent: value.item.encrypted_content ?? null, reasoningEncryptedContent: value.item.encrypted_content ?? null,
}, },
}, },
@@ -1237,19 +1228,8 @@ export class OpenAIResponsesLanguageModel implements LanguageModelV3 {
currentReasoningOutputIndex !== null ? activeReasoning[currentReasoningOutputIndex] : null currentReasoningOutputIndex !== null ? activeReasoning[currentReasoningOutputIndex] : null
// the first reasoning start is pushed in isResponseOutputItemAddedReasoningChunk. // the first reasoning start is pushed in isResponseOutputItemAddedReasoningChunk.
if (activeItem && value.summary_index > 0 && activeItem.summaryParts[value.summary_index] === undefined) { if (activeItem && value.summary_index > 0) {
for (const [summaryIndex, status] of Object.entries(activeItem.summaryParts)) { activeItem.summaryParts.push(value.summary_index)
if (status !== "can-conclude") continue
controller.enqueue({
type: "reasoning-end",
id: `${activeItem.canonicalId}:${summaryIndex}`,
providerMetadata: {
copilot: { itemId: activeItem.canonicalId },
},
})
activeItem.summaryParts[Number(summaryIndex)] = "concluded"
}
activeItem.summaryParts[value.summary_index] = "active"
controller.enqueue({ controller.enqueue({
type: "reasoning-start", type: "reasoning-start",
@@ -1262,22 +1242,6 @@ export class OpenAIResponsesLanguageModel implements LanguageModelV3 {
}, },
}) })
} }
} else if (isResponseReasoningSummaryPartDoneChunk(value)) {
const activeItem =
currentReasoningOutputIndex !== null ? activeReasoning[currentReasoningOutputIndex] : null
if (!activeItem || activeItem.summaryParts[value.summary_index] !== "active") return
if (body.store === false) {
activeItem.summaryParts[value.summary_index] = "can-conclude"
return
}
controller.enqueue({
type: "reasoning-end",
id: `${activeItem.canonicalId}:${value.summary_index}`,
providerMetadata: {
copilot: { itemId: activeItem.canonicalId },
},
})
activeItem.summaryParts[value.summary_index] = "concluded"
} else if (isResponseReasoningSummaryTextDeltaChunk(value)) { } else if (isResponseReasoningSummaryTextDeltaChunk(value)) {
const activeItem = const activeItem =
currentReasoningOutputIndex !== null ? activeReasoning[currentReasoningOutputIndex] : null currentReasoningOutputIndex !== null ? activeReasoning[currentReasoningOutputIndex] : null
@@ -1340,16 +1304,6 @@ export class OpenAIResponsesLanguageModel implements LanguageModelV3 {
controller.enqueue({ type: "text-end", id: currentTextId }) controller.enqueue({ type: "text-end", id: currentTextId })
currentTextId = null currentTextId = null
} }
for (const activeItem of Object.values(activeReasoning)) {
for (const [summaryIndex, status] of Object.entries(activeItem.summaryParts)) {
if (status === "concluded") continue
controller.enqueue({
type: "reasoning-end",
id: `${activeItem.canonicalId}:${summaryIndex}`,
providerMetadata: { copilot: { itemId: activeItem.canonicalId } },
})
}
}
const providerMetadata: SharedV3ProviderMetadata = { const providerMetadata: SharedV3ProviderMetadata = {
copilot: { copilot: {
@@ -1598,12 +1552,6 @@ const responseReasoningSummaryTextDeltaSchema = z.object({
delta: z.string(), delta: z.string(),
}) })
const responseReasoningSummaryPartDoneSchema = z.object({
type: z.literal("response.reasoning_summary_part.done"),
item_id: z.string(),
summary_index: z.number(),
})
const openaiResponsesChunkSchema = z.union([ const openaiResponsesChunkSchema = z.union([
textDeltaChunkSchema, textDeltaChunkSchema,
responseFinishedChunkSchema, responseFinishedChunkSchema,
@@ -1616,7 +1564,6 @@ const openaiResponsesChunkSchema = z.union([
responseCodeInterpreterCallCodeDoneSchema, responseCodeInterpreterCallCodeDoneSchema,
responseAnnotationAddedSchema, responseAnnotationAddedSchema,
responseReasoningSummaryPartAddedSchema, responseReasoningSummaryPartAddedSchema,
responseReasoningSummaryPartDoneSchema,
responseReasoningSummaryTextDeltaSchema, responseReasoningSummaryTextDeltaSchema,
errorChunkSchema, errorChunkSchema,
z.object({ type: z.string() }).loose(), // fallback for unknown chunks z.object({ type: z.string() }).loose(), // fallback for unknown chunks
@@ -1705,12 +1652,6 @@ function isResponseReasoningSummaryPartAddedChunk(
return chunk.type === "response.reasoning_summary_part.added" return chunk.type === "response.reasoning_summary_part.added"
} }
function isResponseReasoningSummaryPartDoneChunk(
chunk: z.infer<typeof openaiResponsesChunkSchema>,
): chunk is z.infer<typeof responseReasoningSummaryPartDoneSchema> {
return chunk.type === "response.reasoning_summary_part.done"
}
function isResponseReasoningSummaryTextDeltaChunk( function isResponseReasoningSummaryTextDeltaChunk(
chunk: z.infer<typeof openaiResponsesChunkSchema>, chunk: z.infer<typeof openaiResponsesChunkSchema>,
): chunk is z.infer<typeof responseReasoningSummaryTextDeltaSchema> { ): chunk is z.infer<typeof responseReasoningSummaryTextDeltaSchema> {
+22 -27
View File
@@ -24,7 +24,6 @@ import { Bus } from "./bus"
import { IntegrationConnection } from "./integration/connection" import { IntegrationConnection } from "./integration/connection"
import { AppProcess } from "@opencode-ai/util/process" import { AppProcess } from "@opencode-ai/util/process"
import { ChildProcess } from "effect/unstable/process" import { ChildProcess } from "effect/unstable/process"
import { Form } from "./form"
export const ID = Integration.ID export const ID = Integration.ID
export type ID = Integration.ID export type ID = Integration.ID
@@ -35,6 +34,18 @@ export type MethodID = Integration.MethodID
export const AttemptID = Integration.AttemptID export const AttemptID = Integration.AttemptID
export type AttemptID = typeof AttemptID.Type export type AttemptID = typeof AttemptID.Type
export const When = Integration.When
export type When = Integration.When
export const TextPrompt = Integration.TextPrompt
export type TextPrompt = Integration.TextPrompt
export const SelectPrompt = Integration.SelectPrompt
export type SelectPrompt = Integration.SelectPrompt
export const Prompt = Integration.Prompt
export type Prompt = Integration.Prompt
export const OAuthMethod = Integration.OAuthMethod export const OAuthMethod = Integration.OAuthMethod
export type OAuthMethod = Integration.OAuthMethod export type OAuthMethod = Integration.OAuthMethod
@@ -53,6 +64,9 @@ export type Method = Integration.Method
export const Info = Integration.Info export const Info = Integration.Info
export type Info = Integration.Info export type Info = Integration.Info
export const Inputs = Integration.Inputs
export type Inputs = Integration.Inputs
export type OAuthAuthorization = { export type OAuthAuthorization = {
readonly url: string readonly url: string
readonly instructions: string readonly instructions: string
@@ -71,7 +85,7 @@ export type OAuthAuthorization = {
export interface OAuthImplementation { export interface OAuthImplementation {
readonly integrationID: ID readonly integrationID: ID
readonly method: OAuthMethod readonly method: OAuthMethod
readonly authorize: (answer: Form.Answer) => Effect.Effect<OAuthAuthorization, unknown, Scope.Scope> readonly authorize: (inputs: Inputs) => Effect.Effect<OAuthAuthorization, unknown, Scope.Scope>
readonly refresh?: (credential: Credential.OAuth) => Effect.Effect<Credential.OAuth, unknown> readonly refresh?: (credential: Credential.OAuth) => Effect.Effect<Credential.OAuth, unknown>
readonly label?: (credential: Credential.OAuth) => string | undefined readonly label?: (credential: Credential.OAuth) => string | undefined
} }
@@ -161,8 +175,6 @@ export interface Interface extends State.Transformable<Draft> {
readonly integrationID: ID readonly integrationID: ID
/** Secret entered by the user. */ /** Secret entered by the user. */
readonly key: string readonly key: string
/** Values collected from the method's form fields. */
readonly answer?: Form.Answer
/** User-facing label for the stored credential. */ /** User-facing label for the stored credential. */
readonly label?: string readonly label?: string
}) => Effect.Effect<void, AuthorizationError> }) => Effect.Effect<void, AuthorizationError>
@@ -179,7 +191,7 @@ export interface Interface extends State.Transformable<Draft> {
readonly connect: (input: { readonly connect: (input: {
readonly integrationID: ID readonly integrationID: ID
readonly methodID: MethodID readonly methodID: MethodID
readonly answer?: Form.Answer readonly inputs: Inputs
readonly label?: string readonly label?: string
}) => Effect.Effect<Attempt, AuthorizationError> }) => Effect.Effect<Attempt, AuthorizationError>
/** Returns the current state of an OAuth attempt. */ /** Returns the current state of an OAuth attempt. */
@@ -344,7 +356,7 @@ const layer = Layer.effect(
return [...credentials, ...env] return [...credentials, ...env]
} }
const project = (entry: Entry, connections: IntegrationConnection.Info[]): Info => const project = (entry: Entry, connections: IntegrationConnection.Info[]) =>
Info.make({ Info.make({
id: entry.ref.id, id: entry.ref.id,
name: entry.ref.name, name: entry.ref.name,
@@ -535,20 +547,15 @@ const layer = Layer.effect(
const connectOAuth = Effect.fn("Integration.oauth.connect")(function* (input: { const connectOAuth = Effect.fn("Integration.oauth.connect")(function* (input: {
readonly integrationID: ID readonly integrationID: ID
readonly methodID: MethodID readonly methodID: MethodID
readonly answer?: Form.Answer readonly inputs: Inputs
readonly label?: string readonly label?: string
}) { }) {
const method = state.get().integrations.get(input.integrationID)?.implementations.get(input.methodID) const method = state.get().integrations.get(input.integrationID)?.implementations.get(input.methodID)
if (!method) { if (!method) {
return yield* Effect.die(new Error(`OAuth method not found: ${input.integrationID}/${input.methodID}`)) return yield* Effect.die(new Error(`OAuth method not found: ${input.integrationID}/${input.methodID}`))
} }
const answer = input.answer ?? {}
if (method.method.form) {
const invalid = Form.validateFields(method.method.form) ?? Form.validateAnswer(method.method.form, answer)
if (invalid) return yield* new AuthorizationError({ cause: new Error(invalid) })
}
const attemptScope = yield* Scope.fork(scope) const attemptScope = yield* Scope.fork(scope)
const authorization = yield* authorize(method.authorize(answer)).pipe( const authorization = yield* authorize(method.authorize(input.inputs)).pipe(
Scope.provide(attemptScope), Scope.provide(attemptScope),
Effect.onExit((exit) => (Exit.isFailure(exit) ? Scope.close(attemptScope, exit) : Effect.void)), Effect.onExit((exit) => (Exit.isFailure(exit) ? Scope.close(attemptScope, exit) : Effect.void)),
) )
@@ -692,24 +699,12 @@ const layer = Layer.effect(
const method = state const method = state
.get() .get()
.integrations.get(input.integrationID) .integrations.get(input.integrationID)
?.methods.find((method) => method.type === "key") ?.methods.some((method) => method.type === "key")
if (!method) return yield* Effect.die(new Error(`Key method not found: ${input.integrationID}`)) if (!method) return yield* Effect.die(new Error(`Key method not found: ${input.integrationID}`))
const answer = input.answer ?? {}
if (method.type === "key" && method.form) {
const invalid = Form.validateFields(method.form) ?? Form.validateAnswer(method.form, answer)
if (invalid) return yield* new AuthorizationError({ cause: new Error(invalid) })
}
if (method.type === "key" && !method.form && Object.keys(answer).length > 0) {
return yield* new AuthorizationError({ cause: new Error("Key method does not accept a form answer") })
}
yield* credentials.create({ yield* credentials.create({
integrationID: input.integrationID, integrationID: input.integrationID,
label: input.label, label: input.label,
value: Credential.Key.make({ value: Credential.Key.make({ type: "key", key: input.key }),
type: "key",
key: input.key,
...(Object.keys(answer).length > 0 ? { configuration: answer } : {}),
}),
}) })
yield* bus.publish(Integration.Event.ConnectionUpdated, { integrationID: input.integrationID }) yield* bus.publish(Integration.Event.ConnectionUpdated, { integrationID: input.integrationID })
yield* bus.publish(Integration.Event.Updated, {}) yield* bus.publish(Integration.Event.Updated, {})
+1 -3
View File
@@ -149,7 +149,6 @@ export const fromCatalogModel = (
}) })
const packageName = Provider.packageName(resolved.package) const packageName = Provider.packageName(resolved.package)
const key = apiKey(resolved, credential) const key = apiKey(resolved, credential)
const configuration = credential?.type === "key" ? credential.configuration : undefined
if (Provider.isAISDK(resolved.package) && packageName === "@ai-sdk/openai") { if (Provider.isAISDK(resolved.package) && packageName === "@ai-sdk/openai") {
return Effect.succeed( return Effect.succeed(
@@ -176,7 +175,7 @@ export const fromCatalogModel = (
.model({ id: resolved.modelID ?? resolved.id, compatibility: resolved.compatibility }), .model({ id: resolved.modelID ?? resolved.id, compatibility: resolved.compatibility }),
) )
} }
const configured = { ...resolved.settings, ...credential?.metadata, ...configuration } const configured = { ...resolved.settings, ...credential?.metadata }
const mapping = Provider.isAISDK(resolved.package) const mapping = Provider.isAISDK(resolved.package)
? AISDKNative.map({ ? AISDKNative.map({
packageName, packageName,
@@ -191,7 +190,6 @@ export const fromCatalogModel = (
draft.settings = Provider.mergeOverlay(draft.settings, { draft.settings = Provider.mergeOverlay(draft.settings, {
...nativeCredentialSettings(resolved.package ?? "", credential), ...nativeCredentialSettings(resolved.package ?? "", credential),
...credential?.metadata, ...credential?.metadata,
...configuration,
}) })
}) })
return dependencies.loadAISDK(runtime).pipe(Effect.mapError(() => unsupported(resolved))) return dependencies.loadAISDK(runtime).pipe(Effect.mapError(() => unsupported(resolved)))
+7 -8
View File
@@ -190,7 +190,6 @@ export const make = Effect.fn("PluginHost.make")(function* (plugin: import("../p
integration.connection.key({ integration.connection.key({
integrationID: Integration.ID.make(input.integrationID), integrationID: Integration.ID.make(input.integrationID),
key: input.key, key: input.key,
answer: input.answer,
label: input.label, label: input.label,
}), }),
}, },
@@ -200,7 +199,7 @@ export const make = Effect.fn("PluginHost.make")(function* (plugin: import("../p
integration.oauth.connect({ integration.oauth.connect({
integrationID: Integration.ID.make(input.integrationID), integrationID: Integration.ID.make(input.integrationID),
methodID: Integration.MethodID.make(input.methodID), methodID: Integration.MethodID.make(input.methodID),
answer: input.answer, inputs: input.inputs,
label: input.label, label: input.label,
}), }),
), ),
@@ -261,7 +260,7 @@ export const make = Effect.fn("PluginHost.make")(function* (plugin: import("../p
update: (id, update) => draft.update(Integration.ID.make(id), update), update: (id, update) => draft.update(Integration.ID.make(id), update),
remove: (id) => draft.remove(Integration.ID.make(id)), remove: (id) => draft.remove(Integration.ID.make(id)),
method: { method: {
list: (id) => draft.method.list(Integration.ID.make(id)), list: (id) => mutable(draft.method.list(Integration.ID.make(id))),
update: (input) => draft.method.update(methodImplementation(input)), update: (input) => draft.method.update(methodImplementation(input)),
remove: (id, method) => remove: (id, method) =>
draft.method.remove(Integration.ID.make(id), Schema.decodeUnknownSync(Integration.Method)(method)), draft.method.remove(Integration.ID.make(id), Schema.decodeUnknownSync(Integration.Method)(method)),
@@ -364,8 +363,8 @@ function methodImplementation(input: IntegrationMethodRegistration): Integration
return { return {
integrationID: Integration.ID.make(input.integrationID), integrationID: Integration.ID.make(input.integrationID),
method: { ...input.method, id: Integration.MethodID.make(input.method.id) }, method: { ...input.method, id: Integration.MethodID.make(input.method.id) },
authorize: (answer) => authorize: (inputs) =>
input.authorize(answer).pipe( input.authorize(inputs).pipe(
Effect.map((authorization) => { Effect.map((authorization) => {
if (authorization.mode === "auto") { if (authorization.mode === "auto") {
return { return {
@@ -386,18 +385,18 @@ function methodImplementation(input: IntegrationMethodRegistration): Integration
if (input.method.type === "env") { if (input.method.type === "env") {
return { return {
integrationID: Integration.ID.make(input.integrationID), integrationID: Integration.ID.make(input.integrationID),
method: input.method, method: { type: "env", names: input.method.names },
} }
} }
if (input.method.type === "command") { if (input.method.type === "command") {
return { return {
integrationID: Integration.ID.make(input.integrationID), integrationID: Integration.ID.make(input.integrationID),
method: { ...input.method, id: Integration.MethodID.make(input.method.id) }, method: Schema.decodeUnknownSync(Integration.CommandMethod)(input.method),
} }
} }
return { return {
integrationID: Integration.ID.make(input.integrationID), integrationID: Integration.ID.make(input.integrationID),
method: input.method, method: { type: "key", label: input.method.label },
} }
} }
+7 -13
View File
@@ -180,8 +180,8 @@ export function fromPromise(plugin: Plugin) {
const refresh = input.refresh const refresh = input.refresh
draft.method.update({ draft.method.update({
...input, ...input,
authorize: (answer) => authorize: (inputs) =>
Effect.promise(() => input.authorize(answer)).pipe( Effect.promise(() => input.authorize(inputs)).pipe(
Effect.map((authorization) => Effect.map((authorization) =>
authorization.mode === "auto" authorization.mode === "auto"
? { ? {
@@ -362,17 +362,11 @@ type Wire<Value> = unknown extends Value
? Value ? Value
: Value extends DateTime.DateTime : Value extends DateTime.DateTime
? number ? number
: Value extends readonly [infer Head, ...infer Tail] : Value extends ReadonlyArray<infer Item>
? [Wire<Head>, ...WireTuple<Tail>] ? Array<Wire<Item>>
: Value extends ReadonlyArray<infer Item> : Value extends object
? Array<Wire<Item>> ? { -readonly [Key in keyof Value]: Wire<Value[Key]> }
: Value extends object : Value
? { -readonly [Key in keyof Value]: Wire<Value[Key]> }
: Value
type WireTuple<Value extends ReadonlyArray<unknown>> = {
-readonly [Key in keyof Value]: Wire<Value[Key]>
}
function wire<Value>(value: Value): Wire<Value> function wire<Value>(value: Value): Wire<Value>
function wire(value: unknown): unknown { function wire(value: unknown): unknown {
@@ -1,9 +1,6 @@
import { Effect } from "effect" import { Effect } from "effect"
import { define } from "@opencode-ai/plugin/effect/plugin" import { define } from "@opencode-ai/plugin/effect/plugin"
import { Form } from "@opencode-ai/schema/form"
import { Provider } from "../../provider" import { Provider } from "../../provider"
import { iife } from "../../util/iife"
import { configuredSettings } from "./configured"
function selectLanguage(sdk: any, modelID: string, useChat: boolean) { function selectLanguage(sdk: any, modelID: string, useChat: boolean) {
if (useChat && sdk.chat) return sdk.chat(modelID) if (useChat && sdk.chat) return sdk.chat(modelID)
@@ -16,29 +13,6 @@ function selectLanguage(sdk: any, modelID: string, useChat: boolean) {
export const AzurePlugin = define({ export const AzurePlugin = define({
id: "opencode.provider.azure", id: "opencode.provider.azure",
effect: Effect.fn(function* (ctx) { effect: Effect.fn(function* (ctx) {
const configured = yield* configuredSettings(Provider.ID.azure)
const form = iife(() => {
if (resolveResourceName(configured) || typeof configured?.baseURL === "string") return
return Form.Fields.make([
{
type: "string",
key: "resourceName",
title: "Enter Azure Resource Name",
placeholder: "e.g. my-models",
required: true,
},
])
})
yield* ctx.integration.transform((draft) => {
draft.method.update({
integrationID: Provider.ID.azure,
method: {
type: "key",
label: "API key",
form,
},
})
})
yield* ctx.catalog.transform((evt) => { yield* ctx.catalog.transform((evt) => {
for (const item of evt.provider.list()) { for (const item of evt.provider.list()) {
if (item.provider.id !== Provider.ID.azure && Provider.packageName(item.provider.package) !== "@ai-sdk/azure") if (item.provider.id !== Provider.ID.azure && Provider.packageName(item.provider.package) !== "@ai-sdk/azure")
@@ -2,53 +2,10 @@ import os from "os"
import { App } from "../../app" import { App } from "../../app"
import { Effect, Option, Schema } from "effect" import { Effect, Option, Schema } from "effect"
import { define } from "@opencode-ai/plugin/effect/plugin" import { define } from "@opencode-ai/plugin/effect/plugin"
import { Form } from "@opencode-ai/schema/form"
import { Provider } from "../../provider"
import { iife } from "../../util/iife"
import { configuredSettings } from "./configured"
const providerID = Provider.ID.make("cloudflare-ai-gateway")
export const CloudflareAIGatewayPlugin = define({ export const CloudflareAIGatewayPlugin = define({
id: "opencode.provider.cloudflare-ai-gateway", id: "opencode.provider.cloudflare-ai-gateway",
effect: Effect.fn(function* (ctx) { effect: Effect.fn(function* (ctx) {
const configured = yield* configuredSettings(providerID)
const form = iife(() => {
if (typeof configured?.baseURL === "string") return
const accountId = process.env.CLOUDFLARE_ACCOUNT_ID || stringOption(configured ?? {}, "accountId")
const gatewayId =
process.env.CLOUDFLARE_GATEWAY_ID ||
stringOption(configured ?? {}, "gatewayId") ||
stringOption(configured ?? {}, "gateway")
if (accountId && gatewayId) return
const accountIdForm = Form.StringField.make({
type: "string",
key: "accountId",
title: "Enter your Cloudflare Account ID",
placeholder: "e.g. 1234567890abcdef1234567890abcdef",
required: true,
})
const gatewayIdForm = Form.StringField.make({
type: "string",
key: "gatewayId",
title: "Enter your Cloudflare AI Gateway ID",
placeholder: "e.g. my-gateway",
required: true,
})
if (accountId) return Form.Fields.make([gatewayIdForm])
if (gatewayId) return Form.Fields.make([accountIdForm])
return Form.Fields.make([accountIdForm, gatewayIdForm])
})
yield* ctx.integration.transform((draft) => {
draft.method.update({
integrationID: providerID,
method: {
type: "key",
label: "Gateway API token",
form,
},
})
})
yield* ctx.aisdk.hook( yield* ctx.aisdk.hook(
"sdk", "sdk",
Effect.fn(function* (evt) { Effect.fn(function* (evt) {
@@ -89,7 +46,7 @@ const decodeJson = Schema.decodeUnknownOption(Schema.UnknownFromJsonString)
function gatewayConfig(options: Record<string, unknown>): GatewayConfig | undefined { function gatewayConfig(options: Record<string, unknown>): GatewayConfig | undefined {
const accountId = process.env.CLOUDFLARE_ACCOUNT_ID ?? stringOption(options, "accountId") const accountId = process.env.CLOUDFLARE_ACCOUNT_ID ?? stringOption(options, "accountId")
// Credential projection copies key metadata into options. The form stores the // Credential projection copies key metadata into options. The prompt stores the
// gateway as gatewayId, while older config examples may use gateway. // gateway as gatewayId, while older config examples may use gateway.
const gatewayId = const gatewayId =
process.env.CLOUDFLARE_GATEWAY_ID ?? stringOption(options, "gatewayId") ?? stringOption(options, "gateway") process.env.CLOUDFLARE_GATEWAY_ID ?? stringOption(options, "gatewayId") ?? stringOption(options, "gateway")
@@ -2,39 +2,13 @@ import os from "os"
import { App } from "../../app" import { App } from "../../app"
import { Effect } from "effect" import { Effect } from "effect"
import { define } from "@opencode-ai/plugin/effect/plugin" import { define } from "@opencode-ai/plugin/effect/plugin"
import { Form } from "@opencode-ai/schema/form"
import { Provider } from "../../provider" import { Provider } from "../../provider"
import { iife } from "../../util/iife"
import { configuredSettings } from "./configured"
const providerID = Provider.ID.make("cloudflare-workers-ai") const providerID = Provider.ID.make("cloudflare-workers-ai")
export const CloudflareWorkersAIPlugin = define({ export const CloudflareWorkersAIPlugin = define({
id: "opencode.provider.cloudflare-workers-ai", id: "opencode.provider.cloudflare-workers-ai",
effect: Effect.fn(function* (ctx) { effect: Effect.fn(function* (ctx) {
const configured = yield* configuredSettings(providerID)
const form = iife(() => {
if (typeof configured?.baseURL === "string" || resolveAccountId(configured ?? {})) return
return Form.Fields.make([
{
type: "string",
key: "accountId",
title: "Enter your Cloudflare Account ID",
placeholder: "e.g. 1234567890abcdef1234567890abcdef",
required: true,
},
])
})
yield* ctx.integration.transform((draft) => {
draft.method.update({
integrationID: providerID,
method: {
type: "key",
label: "API key",
form,
},
})
})
yield* ctx.catalog.transform((evt) => { yield* ctx.catalog.transform((evt) => {
const item = evt.provider.get(providerID) const item = evt.provider.get(providerID)
if (!item) return if (!item) return
@@ -1,15 +0,0 @@
import { Effect, Option } from "effect"
import type { Document } from "@opencode-ai/schema/config"
import { Catalog } from "../../catalog"
import { Config } from "../../config"
import { Provider } from "../../provider"
export const configuredSettings = Effect.fn("ProviderPlugin.configuredSettings")(function* (id: Provider.ID) {
const catalog = yield* Catalog.Service
const current = (yield* catalog.provider.get(id))?.settings
const service = yield* Effect.serviceOption(Config.Service)
const entries = Option.isSome(service) ? yield* service.value.entries() : []
return entries
.filter((entry): entry is Document => entry.type === "document")
.reduce((settings, entry) => Provider.mergeOverlay(settings, entry.info.providers?.[id]?.settings), current)
})
@@ -1,4 +1,5 @@
import type { IntegrationOAuthMethodRegistration } from "@opencode-ai/plugin/effect/integration" import type { IntegrationOAuthMethodRegistration } from "@opencode-ai/plugin/effect/integration"
import { shouldUseResponsesApi } from "@opencode-ai/ai/providers/github-copilot"
import { Effect, Option, Schema, Semaphore, Stream } from "effect" import { Effect, Option, Schema, Semaphore, Stream } from "effect"
import { Catalog } from "../../catalog" import { Catalog } from "../../catalog"
import { Credential } from "../../credential" import { Credential } from "../../credential"
@@ -46,33 +47,30 @@ const oauth = (app: App.Info) =>
id: methodID, id: methodID,
type: "oauth", type: "oauth",
label: "Login with GitHub Copilot", label: "Login with GitHub Copilot",
form: [ prompts: [
{ {
type: "string", type: "select",
key: "deploymentType", key: "deploymentType",
title: "Select GitHub deployment type", message: "Select GitHub deployment type",
required: true,
options: [ options: [
{ label: "GitHub.com", value: "github.com", description: "Public" }, { label: "GitHub.com", value: "github.com", hint: "Public" },
{ label: "GitHub Enterprise", value: "enterprise", description: "Data residency or self-hosted" }, { label: "GitHub Enterprise", value: "enterprise", hint: "Data residency or self-hosted" },
], ],
}, },
{ {
type: "string", type: "text",
key: "enterpriseUrl", key: "enterpriseUrl",
title: "Enter your GitHub Enterprise URL or domain", message: "Enter your GitHub Enterprise URL or domain",
placeholder: "company.ghe.com or https://company.ghe.com", placeholder: "company.ghe.com or https://company.ghe.com",
required: true, when: { key: "deploymentType", op: "eq", value: "enterprise" },
when: [{ key: "deploymentType", op: "eq", value: "enterprise" }],
}, },
], ],
}, },
authorize: (answer) => authorize: (inputs) =>
Effect.gen(function* () { Effect.gen(function* () {
const enterprise = answer.deploymentType === "enterprise" const enterprise = inputs.deploymentType === "enterprise"
const enterpriseUrl = typeof answer.enterpriseUrl === "string" ? answer.enterpriseUrl : undefined if (enterprise && !inputs.enterpriseUrl) return yield* Effect.fail(new Error("Enterprise URL is required"))
if (enterprise && !enterpriseUrl) return yield* Effect.fail(new Error("Enterprise URL is required")) const domain = enterprise ? normalizeDomain(inputs.enterpriseUrl ?? "") : "github.com"
const domain = enterprise ? normalizeDomain(enterpriseUrl ?? "") : "github.com"
const urls = oauthURLs(domain) const urls = oauthURLs(domain)
const device = yield* request(urls.device, { const device = yield* request(urls.device, {
method: "POST", method: "POST",
@@ -190,7 +188,6 @@ export const GithubCopilotPlugin = define({
}) })
yield* ctx.integration.transform((draft) => { yield* ctx.integration.transform((draft) => {
draft.method.remove("github-copilot", { type: "key" })
draft.method.update(oauth(ctx.app)) draft.method.update(oauth(ctx.app))
}) })
yield* ctx.catalog.transform((evt) => { yield* ctx.catalog.transform((evt) => {
@@ -229,26 +226,26 @@ export const GithubCopilotPlugin = define({
"sdk", "sdk",
Effect.fn(function* (evt) { Effect.fn(function* (evt) {
if (evt.model.providerID !== Provider.ID.githubCopilot) return if (evt.model.providerID !== Provider.ID.githubCopilot) return
if (evt.package !== "@ai-sdk/github-copilot") return if (evt.package !== "@ai-sdk/github-copilot" && evt.package !== "@ai-sdk/anthropic") return
evt.options.fetch = copilotFetch( evt.options.fetch = copilotFetch(
typeof evt.options.apiKey === "string" ? evt.options.apiKey : undefined, typeof evt.options.apiKey === "string" ? evt.options.apiKey : undefined,
evt.options.fetch, evt.options.fetch,
evt.package === "@ai-sdk/anthropic",
ctx.app, ctx.app,
) )
if (evt.package === "@ai-sdk/anthropic") {
evt.options.headers = {
...evt.options.headers,
"anthropic-beta": "interleaved-thinking-2025-05-14",
}
const mod = yield* Effect.promise(() => import("@ai-sdk/anthropic"))
evt.sdk = mod.createAnthropic(evt.options)
return
}
const mod = yield* Effect.promise(() => import("../../github-copilot/copilot-provider")) const mod = yield* Effect.promise(() => import("../../github-copilot/copilot-provider"))
evt.sdk = mod.createOpenaiCompatible(evt.options) evt.sdk = mod.createOpenaiCompatible(evt.options)
}), }),
) )
yield* ctx.session.hook("http.request", (evt) =>
Effect.gen(function* () {
if (evt.model.providerID !== Provider.ID.githubCopilot) return
const token = evt.request.headers.get("x-api-key")
if (!token) return
const text = yield* Effect.promise(() => evt.request.clone().text())
const body = Option.getOrUndefined(decodeBody(text))
applyHeaders(evt.request.headers, token, ctx.app, requestMetadata(evt.request.url, body), true)
}),
)
yield* ctx.aisdk.hook( yield* ctx.aisdk.hook(
"language", "language",
Effect.fn(function* (evt) { Effect.fn(function* (evt) {
@@ -266,9 +263,7 @@ export const GithubCopilotPlugin = define({
return return
} }
const id = evt.model.modelID ?? evt.model.id const id = evt.model.modelID ?? evt.model.id
const match = /^gpt-(\d+)/.exec(id) evt.language = shouldUseResponsesApi(id) ? evt.sdk.responses(id) : evt.sdk.chat(id)
evt.language =
match && Number(match[1]) >= 5 && !id.startsWith("gpt-5-mini") ? evt.sdk.responses(id) : evt.sdk.chat(id)
}), }),
) )
}), }),
@@ -317,39 +312,34 @@ function request(url: string, init: RequestInit) {
type Fetch = (input: Parameters<typeof fetch>[0], init?: RequestInit) => Promise<Response> type Fetch = (input: Parameters<typeof fetch>[0], init?: RequestInit) => Promise<Response>
export function copilotFetch(token: string | undefined, upstream: Fetch | undefined, app: App.Info): Fetch { export function copilotFetch(
token: string | undefined,
upstream: Fetch | undefined,
anthropic: boolean,
app: App.Info,
): Fetch {
const send = upstream ?? fetch const send = upstream ?? fetch
return async (input, init) => { return async (input, init) => {
const requestHeaders = new Headers(init?.headers) const requestHeaders = new Headers(init?.headers)
if (token) {
requestHeaders.delete("authorization")
requestHeaders.delete("x-api-key")
requestHeaders.set("Authorization", `Bearer ${token}`)
}
requestHeaders.set("User-Agent", App.useragent(app))
requestHeaders.set("Openai-Intent", "conversation-edits")
requestHeaders.set("X-GitHub-Api-Version", apiVersion)
if (anthropic) requestHeaders.set("anthropic-beta", "interleaved-thinking-2025-05-14")
const url = input instanceof URL ? input.href : typeof input === "string" ? input : input.url const url = input instanceof URL ? input.href : typeof input === "string" ? input : input.url
const body = typeof init?.body === "string" ? Option.getOrUndefined(decodeBody(init.body)) : undefined const body = typeof init?.body === "string" ? Option.getOrUndefined(decodeBody(init.body)) : undefined
applyHeaders(requestHeaders, token, app, requestMetadata(url, body), false) const metadata = requestMetadata(url, body)
requestHeaders.set("x-initiator", metadata.agent ? "agent" : "user")
if (metadata.vision) requestHeaders.set("Copilot-Vision-Request", "true")
return send(input, { ...init, headers: requestHeaders }) return send(input, { ...init, headers: requestHeaders })
} }
} }
function applyHeaders(
headers: Headers,
token: string | undefined,
app: App.Info,
metadata: RequestMetadata,
anthropic: boolean,
) {
if (token) {
headers.delete("authorization")
headers.delete("x-api-key")
headers.set("Authorization", `Bearer ${token}`)
}
headers.set("User-Agent", App.useragent(app))
headers.set("Openai-Intent", "conversation-edits")
headers.set("X-GitHub-Api-Version", apiVersion)
headers.set("x-initiator", metadata.agent ? "agent" : "user")
if (metadata.vision) headers.set("Copilot-Vision-Request", "true")
if (anthropic) headers.set("anthropic-beta", "interleaved-thinking-2025-05-14")
}
type RequestMetadata = ReturnType<typeof requestMetadata>
function requestMetadata(url: string, body: unknown) { function requestMetadata(url: string, body: unknown) {
if (!record(body)) return { agent: false, vision: false } if (!record(body)) return { agent: false, vision: false }
if (Array.isArray(body.input)) { if (Array.isArray(body.input)) {
@@ -43,9 +43,9 @@ function oauth(http: HttpClient.HttpClient) {
type: "oauth", type: "oauth",
label: "OpenCode Console account", label: "OpenCode Console account",
}, },
authorize: (answer) => authorize: (inputs) =>
Effect.gen(function* () { Effect.gen(function* () {
const server = yield* normalizeServer(answer.server ?? defaultServer) const server = yield* normalizeServer(inputs.server ?? defaultServer)
const device = yield* post(http, `${server}/auth/device/code`, { client_id: clientID }, Device) const device = yield* post(http, `${server}/auth/device/code`, { client_id: clientID }, Device)
const verification = URL.canParse(device.verification_uri_complete) const verification = URL.canParse(device.verification_uri_complete)
? new URL(device.verification_uri_complete) ? new URL(device.verification_uri_complete)
@@ -226,10 +226,9 @@ function withoutCredentials(body: Readonly<Record<string, unknown>> | undefined)
return Object.fromEntries(Object.entries(body ?? {}).filter(([key]) => key !== "apiKey" && key !== "headers")) return Object.fromEntries(Object.entries(body ?? {}).filter(([key]) => key !== "apiKey" && key !== "headers"))
} }
function normalizeServer(input: unknown) { function normalizeServer(input: string) {
return Effect.try({ return Effect.try({
try: () => { try: () => {
if (typeof input !== "string") throw new Error("expected string")
const url = new URL(input) const url = new URL(input)
if (url.protocol !== "http:" && url.protocol !== "https:") throw new Error("expected HTTP(S)") if (url.protocol !== "http:" && url.protocol !== "https:") throw new Error("expected HTTP(S)")
return `${url.origin}${url.pathname.replace(/\/+$/, "")}` return `${url.origin}${url.pathname.replace(/\/+$/, "")}`
+55 -61
View File
@@ -11,11 +11,9 @@ import { ToolFailure } from "@opencode-ai/ai"
import { FileDiff } from "@opencode-ai/schema/file-diff" import { FileDiff } from "@opencode-ai/schema/file-diff"
import { Bom } from "@opencode-ai/util/bom" import { Bom } from "@opencode-ai/util/bom"
import { Effect, Schema } from "effect" import { Effect, Schema } from "effect"
import path from "path"
import { Environment } from "../../environment" import { Environment } from "../../environment"
import { FileMutation } from "../../file-mutation" import { FileMutation } from "../../file-mutation"
import { Formatter } from "../../formatter" import { Formatter } from "../../formatter"
import { Location } from "../../location"
import { LocationMutation } from "../../location-mutation" import { LocationMutation } from "../../location-mutation"
import { Permission } from "../../permission" import { Permission } from "../../permission"
import { fileDiff } from "./file-diff" import { fileDiff } from "./file-diff"
@@ -87,7 +85,7 @@ const findLineOccurrences = (content: string, search: string) => {
if ( if (
!actual.every( !actual.every(
(item, lineIndex) => (item, lineIndex) =>
normalizeForMatch(item.text.trimEnd()) === normalizeForMatch(expected[lineIndex]!.trimEnd()), normalizeForMatch(item.text.trimEnd()) === normalizeForMatch(expected[lineIndex].trimEnd()),
) )
) )
return [] return []
@@ -114,7 +112,6 @@ export const Plugin = {
const fileMutation = yield* FileMutation.Service const fileMutation = yield* FileMutation.Service
const environment = yield* Environment.Service const environment = yield* Environment.Service
const formatter = yield* Formatter.Service const formatter = yield* Formatter.Service
const location = yield* Location.Service
const permission = yield* Permission.Service const permission = yield* Permission.Service
yield* ctx.tool yield* ctx.tool
@@ -154,72 +151,69 @@ export const Plugin = {
source: permissionSource, source: permissionSource,
}) })
} }
const original = yield* FileMutation.readText(environment.files, target.absolute).pipe(
Effect.catchTag("Environment.NotFound", () =>
Effect.fail(new ToolFailure({ message: `File not found: ${input.path}` })),
),
Effect.catchTag("Environment.WrongKind", (error) =>
error.actual === "directory"
? Effect.fail(new ToolFailure({ message: `Path is a directory, not a file: ${input.path}` }))
: Effect.fail(new ToolFailure({ message: `Unable to edit ${input.path}`, error })),
),
)
const source = original.text
const ending = source.includes(crlf) ? crlf : "\n"
const oldString = input.oldString.replaceAll(crlf, "\n").replaceAll("\n", ending)
const newString = input.newString.replaceAll(crlf, "\n").replaceAll("\n", ending)
const exact = findOccurrences(source, oldString)
// These one-to-one mappings preserve offsets into the original source.
const unicode =
exact.length > 0 ? [] : findOccurrences(normalizeForMatch(source), normalizeForMatch(oldString))
const trailing = exact.length > 0 || unicode.length > 0 ? [] : findLineOccurrences(source, oldString)
const matches = exact.length > 0 ? exact : unicode.length > 0 ? unicode : trailing
const replacements = matches.length
const replaced = (input.replaceAll === true ? matches : matches.slice(0, 1))
.toReversed()
.reduce(
(content, match) => `${content.slice(0, match.start)}${newString}${content.slice(match.end)}`,
source,
)
const preview =
replacements > 0 && (replacements === 1 || input.replaceAll === true)
? fileDiff(target.resource, source, replaced)
: undefined
yield* permission.assert({ yield* permission.assert({
action: "edit", action: "edit",
resources: [target.resource], resources: [target.resource],
save: ["*"], save: ["*"],
metadata: preview ? { files: [preview] } : undefined,
sessionID: context.sessionID, sessionID: context.sessionID,
agent: context.agent, agent: context.agent,
source: permissionSource, source: permissionSource,
}) })
if (replacements === 0) { return yield* fileMutation.withLock([target.absolute])(
return yield* new ToolFailure({ Effect.gen(function* () {
message: `Could not find oldString in ${input.path}. It must match exactly, including whitespace and indentation.`, const original = yield* FileMutation.readText(environment.files, target.absolute).pipe(
}) Effect.catchTag("Environment.NotFound", () =>
} Effect.fail(new ToolFailure({ message: `File not found: ${input.path}` })),
if (replacements > 1 && input.replaceAll !== true) { ),
return yield* new ToolFailure({ Effect.catchTag("Environment.WrongKind", (error) =>
message: `Found ${replacements} matches for oldString, but expected exactly one. Add more surrounding context to make oldString unique, or set replaceAll to true to replace every occurrence.`, error.actual === "directory"
}) ? Effect.fail(new ToolFailure({ message: `Path is a directory, not a file: ${input.path}` }))
} : Effect.fail(new ToolFailure({ message: `Unable to edit ${input.path}`, error })),
const replacementBom = replaced.startsWith("\uFEFF") ),
const result = yield* fileMutation.write({ )
target, const source = original.text
content: Bom.join(replaced, original.bom || replacementBom), const ending = source.includes(crlf) ? crlf : "\n"
}) const oldString = input.oldString.replaceAll(crlf, "\n").replaceAll("\n", ending)
const bom = original.bom || replacementBom const newString = input.newString.replaceAll(crlf, "\n").replaceAll("\n", ending)
const formatted = (yield* formatter.file(target.absolute)) const exact = findOccurrences(source, oldString)
? yield* FileMutation.syncTextBom(environment.files, target.absolute, bom) // These one-to-one mappings preserve offsets into the original source.
: (yield* FileMutation.readText(environment.files, target.absolute)).text const unicode =
return { exact.length > 0 ? [] : findOccurrences(normalizeForMatch(source), normalizeForMatch(oldString))
files: [fileDiff(result.resource, source, formatted)], const trailing = exact.length > 0 || unicode.length > 0 ? [] : findLineOccurrences(source, oldString)
replacements, const matches = exact.length > 0 ? exact : unicode.length > 0 ? unicode : trailing
} satisfies Output const replacements = matches.length
const replaced = (input.replaceAll === true ? matches : matches.slice(0, 1))
.toReversed()
.reduce(
(content, match) => `${content.slice(0, match.start)}${newString}${content.slice(match.end)}`,
source,
)
if (replacements === 0) {
return yield* new ToolFailure({
message: `Could not find oldString in ${input.path}. It must match exactly, including whitespace and indentation.`,
})
}
if (replacements > 1 && input.replaceAll !== true) {
return yield* new ToolFailure({
message: `Found ${replacements} matches for oldString, but expected exactly one. Add more surrounding context to make oldString unique, or set replaceAll to true to replace every occurrence.`,
})
}
const replacementBom = replaced.startsWith("\uFEFF")
const result = yield* fileMutation.write({
target,
content: Bom.join(replaced, original.bom || replacementBom),
})
const bom = original.bom || replacementBom
const formatted = (yield* formatter.file(target.absolute))
? yield* FileMutation.syncTextBom(environment.files, target.absolute, bom)
: (yield* FileMutation.readText(environment.files, target.absolute)).text
return {
files: [fileDiff(result.resource, source, formatted)],
replacements,
} satisfies Output
}),
)
}).pipe( }).pipe(
fileMutation.withLock([path.resolve(location.directory, input.path)]),
Effect.map((output) => ({ Effect.map((output) => ({
output, output,
content: `Edited ${output.files[0]?.file} (${output.replacements} replacement${output.replacements === 1 ? "" : "s"})`, content: `Edited ${output.files[0]?.file} (${output.replacements} replacement${output.replacements === 1 ? "" : "s"})`,
+174 -186
View File
@@ -3,7 +3,7 @@ export * as PatchTool from "./patch"
import type { Context as PluginContext } from "@opencode-ai/plugin/effect/plugin" import type { Context as PluginContext } from "@opencode-ai/plugin/effect/plugin"
import { ToolFailure } from "@opencode-ai/ai" import { ToolFailure } from "@opencode-ai/ai"
import { FileDiff } from "@opencode-ai/schema/file-diff" import { FileDiff } from "@opencode-ai/schema/file-diff"
import { Effect, Result, Schema } from "effect" import { Effect, Schema } from "effect"
import path from "path" import path from "path"
import { Bom } from "@opencode-ai/util/bom" import { Bom } from "@opencode-ai/util/bom"
import { FSUtil } from "@opencode-ai/util/fs-util" import { FSUtil } from "@opencode-ai/util/fs-util"
@@ -93,12 +93,6 @@ export const Plugin = {
execute: (input, context) => { execute: (input, context) => {
const applied: Array<typeof Applied.Type> = [] const applied: Array<typeof Applied.Type> = []
const parsed = Patch.parse(input.patchText) const parsed = Patch.parse(input.patchText)
const lockTargets = Result.isSuccess(parsed)
? parsed.success.flatMap((hunk) => [
path.resolve(location.directory, hunk.path),
...(hunk.type === "update" && hunk.movePath ? [path.resolve(location.directory, hunk.movePath)] : []),
])
: []
const fail = (operation: string, error: unknown) => { const fail = (operation: string, error: unknown) => {
const completed = applied.map((item) => item.resource).join(", ") const completed = applied.map((item) => item.resource).join(", ")
return new ToolFailure({ return new ToolFailure({
@@ -118,202 +112,196 @@ export const Plugin = {
if (hunks.length === 0) { if (hunks.length === 0) {
return yield* new ToolFailure({ message: "patch rejected: empty patch" }) return yield* new ToolFailure({ message: "patch rejected: empty patch" })
} }
const prepared: Prepared[] = [] const plans = hunks.map((hunk) => ({
const targets: Target[] = [] hunk,
const updates = new Map<string, string>() target: resolveTarget(location, hunk.path),
for (const hunk of hunks) { moveTarget:
yield* Effect.gen(function* () { hunk.type === "update" && hunk.movePath ? resolveTarget(location, hunk.movePath) : undefined,
const target = resolveTarget(location, hunk.path) }))
targets.push(target) const targets = plans.flatMap((plan) => [plan.target, ...(plan.moveTarget ? [plan.moveTarget] : [])])
if (target.externalDirectory) { for (const target of targets) {
yield* permission.assert({ if (target.externalDirectory) {
action: "external_directory", yield* permission.assert({
resources: [target.externalDirectory.resource], action: "external_directory",
save: [target.externalDirectory.resource], resources: [target.externalDirectory.resource],
metadata: { save: [target.externalDirectory.resource],
filepath: target.absolute, metadata: {
parentDir: target.externalDirectory.directory, filepath: target.absolute,
}, parentDir: target.externalDirectory.directory,
sessionID: context.sessionID, },
agent: context.agent, sessionID: context.sessionID,
source, agent: context.agent,
}) source,
}
if (hunk.type === "add") {
const content =
hunk.contents.endsWith("\n") || hunk.contents === "" ? hunk.contents : `${hunk.contents}\n`
prepared.push({
...hunk,
target,
content,
before: "",
after: Bom.split(content).text,
})
return
}
if (hunk.type === "delete") {
const content = yield* FileMutation.readText(environment.files, target.absolute).pipe(
Effect.mapError(
(error) =>
new ToolFailure({
message: `patch verification failed: Failed to delete ${target.resource}: ${errorMessage(error)}`,
}),
),
)
prepared.push({ ...hunk, target, before: content.text, after: "" })
return
}
const previous = updates.get(target.absolute)
const original =
previous ??
(yield* Effect.gen(function* () {
const content = yield* FileMutation.readText(environment.files, target.absolute).pipe(
Effect.mapError(
(error) =>
new ToolFailure({
message: `patch verification failed: Failed to read file to update ${target.absolute}: ${errorMessage(error)}`,
}),
),
)
return Bom.join(content.text, content.bom)
}))
const before = Bom.split(original).text
const update = yield* Effect.try({
try: () => Patch.derive(hunk.path, hunk.chunks, original),
catch: (error) => new ToolFailure({ message: `patch verification failed: ${errorMessage(error)}` }),
}) })
const moveTarget = hunk.movePath ? resolveTarget(location, hunk.movePath) : undefined }
if (moveTarget) targets.push(moveTarget)
if (moveTarget?.externalDirectory) {
yield* permission.assert({
action: "external_directory",
resources: [moveTarget.externalDirectory.resource],
save: [moveTarget.externalDirectory.resource],
metadata: {
filepath: moveTarget.absolute,
parentDir: moveTarget.externalDirectory.directory,
},
sessionID: context.sessionID,
agent: context.agent,
source,
})
}
prepared.push({
...hunk,
target,
content: Patch.joinBom(update.content, update.bom),
before,
after: update.content,
moveTarget,
})
if (!moveTarget) updates.set(target.absolute, Patch.joinBom(update.content, update.bom))
}).pipe(
Effect.mapError((error) =>
error instanceof ToolFailure
? error
: new ToolFailure({ message: `Unable to prepare patch at ${hunk.path}`, error }),
),
)
} }
const patchFiles = prepared.map((change) => patchFile(change))
yield* permission.assert({ yield* permission.assert({
action: "edit", action: "edit",
resources: [...new Set(targets.map((target) => target.resource))], resources: [...new Set(targets.map((target) => target.resource))],
save: ["*"], save: ["*"],
metadata: {
filepath: targets.map((target) => target.resource).join(", "),
diff: patchFiles.map((file) => `${file.patch}\n`).join(""),
files: patchFiles,
},
sessionID: context.sessionID, sessionID: context.sessionID,
agent: context.agent, agent: context.agent,
source, source,
}) })
yield* Effect.forEach( return yield* mutation.withLock(targets.map((target) => target.absolute))(
prepared, Effect.gen(function* () {
(change) => const prepared: Prepared[] = []
Effect.gen(function* () { const updates = new Map<string, string>()
if (change.type === "add") { for (const plan of plans) {
yield* environment.files const hunk = plan.hunk
.write(change.target.absolute, new TextEncoder().encode(change.content)) const target = plan.target
.pipe(Effect.mapError((error) => fail(`Failed to write ${change.target.resource}`, error))) yield* Effect.gen(function* () {
applied.push({ if (hunk.type === "add") {
type: change.type, const content =
resource: change.target.resource, hunk.contents.endsWith("\n") || hunk.contents === "" ? hunk.contents : `${hunk.contents}\n`
target: change.target.absolute, prepared.push({
}) ...hunk,
return target,
} content,
if (change.type === "delete") { before: "",
yield* environment.files after: Bom.split(content).text,
.remove(change.target.absolute) })
.pipe(Effect.mapError((error) => fail(`Failed to delete ${change.target.resource}`, error))) return
applied.push({ }
type: change.type, if (hunk.type === "delete") {
resource: change.target.resource, const content = yield* FileMutation.readText(environment.files, target.absolute).pipe(
target: change.target.absolute, Effect.mapError(
}) (error) =>
return new ToolFailure({
} message: `patch verification failed: Failed to delete ${target.resource}: ${errorMessage(error)}`,
if (change.moveTarget) { }),
const moveTarget = change.moveTarget
yield* environment.files
.write(moveTarget.absolute, new TextEncoder().encode(change.content))
.pipe(Effect.mapError((error) => fail(`Failed to write ${moveTarget.resource}`, error)))
yield* environment.files
.remove(change.target.absolute)
.pipe(
Effect.mapError((error) =>
fail(`Wrote ${moveTarget.resource} but failed to remove ${change.target.resource}`, error),
), ),
) )
applied.push({ prepared.push({ ...hunk, target, before: content.text, after: "" })
type: change.type, return
resource: change.moveTarget.resource, }
target: change.moveTarget.absolute, const previous = updates.get(target.absolute)
}) const original =
return previous ??
} (yield* Effect.gen(function* () {
yield* environment.files const content = yield* FileMutation.readText(environment.files, target.absolute).pipe(
.write(change.target.absolute, new TextEncoder().encode(change.content)) Effect.mapError(
.pipe(Effect.mapError((error) => fail(`Failed to write ${change.target.resource}`, error))) (error) =>
applied.push({ new ToolFailure({
type: change.type, message: `patch verification failed: Failed to read file to update ${target.absolute}: ${errorMessage(error)}`,
resource: change.target.resource, }),
target: change.target.absolute, ),
})
}),
{ discard: true },
)
const formatted = new Map<string, string>()
yield* Effect.forEach(
[...new Set(applied.filter((item) => item.type !== "delete").map((item) => item.target))],
(target) =>
Effect.gen(function* () {
const current = yield* FileMutation.readText(environment.files, target).pipe(
Effect.mapError((error) => fail(`Failed to read ${target}`, error)),
)
formatted.set(
target,
(yield* formatter.file(target))
? yield* FileMutation.syncTextBom(environment.files, target, current.bom).pipe(
Effect.mapError((error) => fail(`Failed to sync ${target}`, error)),
) )
: current.text, return Bom.join(content.text, content.bom)
}))
const before = Bom.split(original).text
const update = yield* Effect.try({
try: () => Patch.derive(hunk.path, hunk.chunks, original),
catch: (error) =>
new ToolFailure({ message: `patch verification failed: ${errorMessage(error)}` }),
})
const moveTarget = plan.moveTarget
prepared.push({
...hunk,
target,
content: Patch.joinBom(update.content, update.bom),
before,
after: update.content,
moveTarget,
})
if (!moveTarget) updates.set(target.absolute, Patch.joinBom(update.content, update.bom))
}).pipe(
Effect.mapError((error) =>
error instanceof ToolFailure
? error
: new ToolFailure({ message: `Unable to prepare patch at ${hunk.path}`, error }),
),
) )
}), }
{ discard: true },
yield* Effect.forEach(
prepared,
(change) =>
Effect.gen(function* () {
if (change.type === "add") {
yield* environment.files
.write(change.target.absolute, new TextEncoder().encode(change.content))
.pipe(Effect.mapError((error) => fail(`Failed to write ${change.target.resource}`, error)))
applied.push({
type: change.type,
resource: change.target.resource,
target: change.target.absolute,
})
return
}
if (change.type === "delete") {
yield* environment.files
.remove(change.target.absolute)
.pipe(Effect.mapError((error) => fail(`Failed to delete ${change.target.resource}`, error)))
applied.push({
type: change.type,
resource: change.target.resource,
target: change.target.absolute,
})
return
}
if (change.moveTarget) {
const moveTarget = change.moveTarget
yield* environment.files
.write(moveTarget.absolute, new TextEncoder().encode(change.content))
.pipe(Effect.mapError((error) => fail(`Failed to write ${moveTarget.resource}`, error)))
yield* environment.files
.remove(change.target.absolute)
.pipe(
Effect.mapError((error) =>
fail(
`Wrote ${moveTarget.resource} but failed to remove ${change.target.resource}`,
error,
),
),
)
applied.push({
type: change.type,
resource: change.moveTarget.resource,
target: change.moveTarget.absolute,
})
return
}
yield* environment.files
.write(change.target.absolute, new TextEncoder().encode(change.content))
.pipe(Effect.mapError((error) => fail(`Failed to write ${change.target.resource}`, error)))
applied.push({
type: change.type,
resource: change.target.resource,
target: change.target.absolute,
})
}),
{ discard: true },
)
const formatted = new Map<string, string>()
yield* Effect.forEach(
[...new Set(applied.filter((item) => item.type !== "delete").map((item) => item.target))],
(target) =>
Effect.gen(function* () {
const current = yield* FileMutation.readText(environment.files, target).pipe(
Effect.mapError((error) => fail(`Failed to read ${target}`, error)),
)
formatted.set(
target,
(yield* formatter.file(target))
? yield* FileMutation.syncTextBom(environment.files, target, current.bom).pipe(
Effect.mapError((error) => fail(`Failed to sync ${target}`, error)),
)
: current.text,
)
}),
{ discard: true },
)
const files = yield* Effect.forEach(prepared, (change) => {
if (change.type === "delete") return Effect.succeed(patchFile(change))
const target = change.type === "update" && change.moveTarget ? change.moveTarget : change.target
return Effect.succeed(patchFile(change, formatted.get(target.absolute)))
})
return { applied, files }
}),
) )
const files = yield* Effect.forEach(prepared, (change) => {
if (change.type === "delete") return Effect.succeed(patchFile(change))
const target = change.type === "update" && change.moveTarget ? change.moveTarget : change.target
return Effect.succeed(patchFile(change, formatted.get(target.absolute)))
})
return { applied, files }
}).pipe( }).pipe(
mutation.withLock(lockTargets),
Effect.map((output) => ({ Effect.map((output) => ({
output, output,
content: toModelOutput(output), content: toModelOutput(output),
+10 -14
View File
@@ -9,13 +9,11 @@ export * as WriteTool from "./write"
import type { Context as PluginContext } from "@opencode-ai/plugin/effect/plugin" import type { Context as PluginContext } from "@opencode-ai/plugin/effect/plugin"
import { ToolFailure } from "@opencode-ai/ai" import { ToolFailure } from "@opencode-ai/ai"
import { Effect, Schema } from "effect" import { Effect, Schema } from "effect"
import { Bom } from "@opencode-ai/util/bom"
import { Environment } from "../../environment" import { Environment } from "../../environment"
import { FileMutation } from "../../file-mutation" import { FileMutation } from "../../file-mutation"
import { Formatter } from "../../formatter" import { Formatter } from "../../formatter"
import { LocationMutation } from "../../location-mutation" import { LocationMutation } from "../../location-mutation"
import { Permission } from "../../permission" import { Permission } from "../../permission"
import { fileDiff } from "./file-diff"
export const name = "write" export const name = "write"
@@ -77,26 +75,24 @@ export const Plugin = {
agent: context.agent, agent: context.agent,
source, source,
}) })
const current = yield* FileMutation.readText(environment.files, target.absolute).pipe(
Effect.catchTag("Environment.NotFound", () => Effect.succeed(undefined)),
)
const next = Bom.split(input.content)
const preview = fileDiff(target.resource, current?.text ?? "", next.text, current ? "modified" : "added")
yield* permission.assert({ yield* permission.assert({
action: "edit", action: "edit",
resources: [target.resource], resources: [target.resource],
save: ["*"], save: ["*"],
metadata: { files: [preview] },
sessionID: context.sessionID, sessionID: context.sessionID,
agent: context.agent, agent: context.agent,
source, source,
}) })
const result = yield* fileMutation.writeTextPreservingBom({ target, content: input.content }) return yield* fileMutation.withLock([target.absolute])(
const bom = (yield* FileMutation.readText(environment.files, target.absolute)).bom Effect.gen(function* () {
if (yield* formatter.file(target.absolute)) { const result = yield* fileMutation.writeTextPreservingBom({ target, content: input.content })
yield* FileMutation.syncTextBom(environment.files, target.absolute, bom) const bom = (yield* FileMutation.readText(environment.files, target.absolute)).bom
} if (yield* formatter.file(target.absolute)) {
return result yield* FileMutation.syncTextBom(environment.files, target.absolute, bom)
}
return result
}),
)
}).pipe( }).pipe(
Effect.map((output) => ({ output, content: toModelOutput(output) })), Effect.map((output) => ({ output, content: toModelOutput(output) })),
Effect.mapError((error) => new ToolFailure({ message: `Unable to write ${input.path}`, error })), Effect.mapError((error) => new ToolFailure({ message: `Unable to write ${input.path}`, error })),
-85
View File
@@ -110,49 +110,6 @@ describe("FileMutation", () => {
), ),
) )
it.live("serializes concurrent writes to the same absolute target", () =>
withTmp((directory) =>
Effect.gen(function* () {
const targetPath = path.join(directory, "shared.txt")
yield* Effect.promise(() => fs.writeFile(targetPath, "initial"))
const firstStarted = yield* Deferred.make<void>()
const releaseFirst = yield* Deferred.make<void>()
const secondStarted = yield* Deferred.make<void>()
let writes = 0
const filesystem = instrumentWrites((write) =>
Effect.gen(function* () {
writes++
if (writes === 1) {
yield* Deferred.succeed(firstStarted, undefined)
yield* Deferred.await(releaseFirst)
} else {
yield* Deferred.succeed(secondStarted, undefined)
}
yield* write
}),
)
yield* Effect.gen(function* () {
const mutation = yield* LocationMutation.Service
const files = yield* FileMutation.Service
const firstPlan = yield* mutation.resolve({ path: "shared.txt" })
const secondPlan = yield* mutation.resolve({ path: "shared.txt" })
const first = yield* files.write({ target: firstPlan, content: "first" }).pipe(Effect.forkChild)
yield* Deferred.await(firstStarted)
const second = yield* files.write({ target: secondPlan, content: "second" }).pipe(Effect.forkChild)
yield* Effect.yieldNow
expect(yield* Deferred.isDone(secondStarted)).toBe(false)
yield* Deferred.succeed(releaseFirst, undefined)
yield* Deferred.await(secondStarted)
yield* Fiber.join(first)
yield* Fiber.join(second)
expect(yield* Effect.promise(() => fs.readFile(targetPath, "utf8"))).toBe("second")
}).pipe(provide(directory, filesystem))
}),
),
)
it.live("shares transaction locks across Location service instances", () => it.live("shares transaction locks across Location service instances", () =>
withTmp((directory) => withTmp((directory) =>
Effect.gen(function* () { Effect.gen(function* () {
@@ -203,46 +160,4 @@ describe("FileMutation", () => {
}).pipe(provide(directory)), }).pipe(provide(directory)),
), ),
) )
it.live("allows distinct absolute targets to proceed independently", () =>
withTmp((directory) =>
Effect.gen(function* () {
const firstStarted = yield* Deferred.make<void>()
const releaseFirst = yield* Deferred.make<void>()
const secondFinished = yield* Deferred.make<void>()
const secondPath = path.join(directory, "second.txt")
let writes = 0
const filesystem = instrumentWrites((write) =>
++writes === 1
? Deferred.succeed(firstStarted, undefined).pipe(
Effect.andThen(Deferred.await(releaseFirst)),
Effect.andThen(write),
)
: write.pipe(Effect.andThen(Deferred.succeed(secondFinished, undefined))),
)
yield* Effect.gen(function* () {
const mutation = yield* LocationMutation.Service
const files = yield* FileMutation.Service
const firstPlan = yield* mutation.resolve({ path: "first.txt" })
const secondPlan = yield* mutation.resolve({ path: "second.txt" })
const first = yield* files.write({ target: firstPlan, content: "first" }).pipe(Effect.forkChild)
yield* Deferred.await(firstStarted)
const second = yield* files.write({ target: secondPlan, content: "second" }).pipe(Effect.forkChild)
yield* Deferred.await(secondFinished)
expect(yield* Effect.promise(() => fs.readFile(secondPath, "utf8"))).toBe("second")
yield* Deferred.succeed(releaseFirst, undefined)
yield* Fiber.join(first)
yield* Fiber.join(second)
}).pipe(provide(directory, filesystem))
}),
),
)
}) })
function instrumentWrites(
run: <E>(write: Effect.Effect<void, E>, target: string) => Effect.Effect<void, E>,
): EnvironmentFilesTransform {
return (files) => ({ write: (target, content) => run(files.write(target, content), target) })
}
@@ -1,7 +1,7 @@
import { OpenAIResponsesLanguageModel } from "@opencode-ai/core/github-copilot/responses/openai-responses-language-model" import { OpenAIResponsesLanguageModel } from "@opencode-ai/core/github-copilot/responses/openai-responses-language-model"
import { convertToOpenAIResponsesInput } from "@opencode-ai/core/github-copilot/responses/convert-to-openai-responses-input" import { convertToOpenAIResponsesInput } from "@opencode-ai/core/github-copilot/responses/convert-to-openai-responses-input"
import { describe, test, expect, mock } from "bun:test" import { describe, test, expect, mock } from "bun:test"
import type { LanguageModelV3Prompt, LanguageModelV3StreamPart } from "@ai-sdk/provider" import type { LanguageModelV3Prompt } from "@ai-sdk/provider"
const TEST_PROMPT: LanguageModelV3Prompt = [{ role: "user", content: [{ type: "text", text: "Hello" }] }] const TEST_PROMPT: LanguageModelV3Prompt = [{ role: "user", content: [{ type: "text", text: "Hello" }] }]
@@ -11,16 +11,6 @@ function createMockFetch(body: unknown) {
) )
} }
function createStreamFetch(events: ReadonlyArray<Record<string, unknown>>) {
return mock(
async () =>
new Response(events.map((event) => `data: ${JSON.stringify(event)}\n\n`).join(""), {
status: 200,
headers: { "Content-Type": "text/event-stream" },
}),
)
}
function createModel(fetchFn: ReturnType<typeof mock>) { function createModel(fetchFn: ReturnType<typeof mock>) {
return new OpenAIResponsesLanguageModel("test-model", { return new OpenAIResponsesLanguageModel("test-model", {
provider: "copilot", provider: "copilot",
@@ -87,173 +77,10 @@ describe("doGenerate", () => {
expect(providerMetadata?.copilot?.responseId).toBe("resp_1") expect(providerMetadata?.copilot?.responseId).toBe("resp_1")
expect(providerMetadata?.openai).toBeUndefined() expect(providerMetadata?.openai).toBeUndefined()
}) })
test("defaults to stateless encrypted reasoning and keeps previousResponseId opt-in", async () => {
const requests: Array<Record<string, unknown>> = []
const fetchFn = mock(async (_input: Parameters<typeof fetch>[0], init?: RequestInit) => {
requests.push(JSON.parse(init?.body as string))
return new Response(
JSON.stringify({
id: "resp_1",
created_at: 0,
model: "gpt-5.5",
output: [],
usage: { input_tokens: 1, output_tokens: 1 },
}),
{ status: 200, headers: { "Content-Type": "application/json" } },
)
})
const model = createModel(fetchFn)
await model.doGenerate({ prompt: TEST_PROMPT, includeRawChunks: false } as any)
await model.doGenerate({
prompt: TEST_PROMPT,
includeRawChunks: false,
providerOptions: { copilot: { previousResponseId: "resp_previous", store: false } },
} as any)
await model.doGenerate({
prompt: TEST_PROMPT,
includeRawChunks: false,
providerOptions: { copilot: { store: true } },
} as any)
expect(requests[0]?.previous_response_id).toBeUndefined()
expect(requests[0]?.store).toBe(false)
expect(requests[0]?.include).toEqual(["reasoning.encrypted_content"])
expect(requests[1]?.previous_response_id).toBe("resp_previous")
expect(requests[1]?.store).toBe(false)
expect(requests[1]?.include).toEqual(["reasoning.encrypted_content"])
expect(requests[2]?.store).toBe(true)
expect(requests[2]?.include).toEqual(["reasoning.encrypted_content"])
})
})
describe("doStream", () => {
test("streams sequential Copilot reasoning summary blocks", async () => {
const model = createModel(
createStreamFetch([
{
type: "response.output_item.added",
output_index: 0,
item: { type: "reasoning", id: "rs_1", encrypted_content: null },
},
{
type: "response.output_item.added",
output_index: 0,
item: { type: "reasoning", id: "rs_rotated", encrypted_content: null },
},
{ type: "response.reasoning_summary_part.added", item_id: "rs_1", summary_index: 0 },
{ type: "response.reasoning_summary_text.delta", item_id: "rs_1", summary_index: 0, delta: "First" },
{ type: "response.reasoning_summary_part.done", item_id: "rs_1", summary_index: 0 },
{ type: "response.reasoning_summary_part.added", item_id: "rs_1", summary_index: 1 },
{ type: "response.reasoning_summary_part.added", item_id: "rs_1", summary_index: 1 },
{ type: "response.reasoning_summary_text.delta", item_id: "rs_1", summary_index: 1, delta: "Second" },
{ type: "response.reasoning_summary_part.done", item_id: "rs_1", summary_index: 1 },
{
type: "response.output_item.done",
output_index: 0,
item: { type: "reasoning", id: "rs_rotated", encrypted_content: "encrypted-state" },
},
]),
)
const result = await model.doStream({
prompt: TEST_PROMPT,
includeRawChunks: false,
providerOptions: { copilot: { store: false } },
} as any)
const reader = result.stream.getReader()
const events: LanguageModelV3StreamPart[] = []
while (true) {
const item = await reader.read()
if (item.done) break
if (item.value.type.startsWith("reasoning-")) events.push(item.value)
}
expect(events).toMatchObject([
{
type: "reasoning-start",
id: "rs_1:0",
providerMetadata: { copilot: { itemId: "rs_1", reasoningEncryptedContent: null } },
},
{ type: "reasoning-delta", id: "rs_1:0", delta: "First" },
{ type: "reasoning-end", id: "rs_1:0", providerMetadata: { copilot: { itemId: "rs_1" } } },
{
type: "reasoning-start",
id: "rs_1:1",
providerMetadata: { copilot: { itemId: "rs_1", reasoningEncryptedContent: null } },
},
{ type: "reasoning-delta", id: "rs_1:1", delta: "Second" },
{
type: "reasoning-end",
id: "rs_1:1",
providerMetadata: { copilot: { itemId: "rs_rotated", reasoningEncryptedContent: "encrypted-state" } },
},
])
const deltas = new Map(
events.filter((event) => event.type === "reasoning-delta").map((event) => [event.id, event.delta] as const),
)
const { input } = await convertToOpenAIResponsesInput({
prompt: [
{
role: "assistant",
content: events
.filter((event) => event.type === "reasoning-end")
.map((event) => ({
type: "reasoning" as const,
text: deltas.get(event.id) ?? "",
providerOptions: event.providerMetadata,
})),
},
],
systemMessageMode: "system",
store: false,
})
expect(input).toEqual([
{
type: "reasoning",
id: "rs_rotated",
encrypted_content: "encrypted-state",
summary: [],
},
])
})
test("closes reasoning when a Copilot stream ends before output_item.done", async () => {
const model = createModel(
createStreamFetch([
{
type: "response.output_item.added",
output_index: 0,
item: { type: "reasoning", id: "rs_1", encrypted_content: null },
},
{ type: "response.reasoning_summary_text.delta", item_id: "rs_rotated", summary_index: 0, delta: "First" },
]),
)
const result = await model.doStream({
prompt: TEST_PROMPT,
includeRawChunks: false,
providerOptions: { copilot: { store: false } },
} as any)
const reader = result.stream.getReader()
const events: LanguageModelV3StreamPart[] = []
while (true) {
const item = await reader.read()
if (item.done) break
if (item.value.type.startsWith("reasoning-")) events.push(item.value)
}
expect(events.map((event) => event.type)).toEqual(["reasoning-start", "reasoning-delta", "reasoning-end"])
expect(events.at(-1)).toMatchObject({
type: "reasoning-end",
id: "rs_1:0",
providerMetadata: { copilot: { itemId: "rs_1" } },
})
})
}) })
describe("convertToOpenAIResponsesInput", () => { describe("convertToOpenAIResponsesInput", () => {
test("omits response item IDs from stateless function calls", async () => { test("echoes a stale tool-call itemId from the copilot namespace as the function_call id", async () => {
const { input } = await convertToOpenAIResponsesInput({ const { input } = await convertToOpenAIResponsesInput({
prompt: [ prompt: [
{ {
@@ -279,11 +106,12 @@ describe("convertToOpenAIResponsesInput", () => {
call_id: "call_1", call_id: "call_1",
name: "bash", name: "bash",
arguments: JSON.stringify({ command: "ls" }), arguments: JSON.stringify({ command: "ls" }),
id: "fc_999",
}, },
]) ])
}) })
test("preserves response item IDs for stored function calls", async () => { test("omits the function_call id once the stale copilot itemId has been stripped", async () => {
const { input } = await convertToOpenAIResponsesInput({ const { input } = await convertToOpenAIResponsesInput({
prompt: [ prompt: [
{ {
@@ -294,16 +122,16 @@ describe("convertToOpenAIResponsesInput", () => {
toolCallId: "call_1", toolCallId: "call_1",
toolName: "bash", toolName: "bash",
input: { command: "ls" }, input: { command: "ls" },
providerOptions: { copilot: { itemId: "fc_999" } }, providerOptions: {},
}, },
], ],
}, },
], ],
systemMessageMode: "system", systemMessageMode: "system",
store: true, store: false,
}) })
expect((input[0] as any).id).toBe("fc_999") expect((input[0] as any).id).toBeUndefined()
}) })
test("preserves reasoning items keyed by the copilot namespace instead of dropping them", async () => { test("preserves reasoning items keyed by the copilot namespace instead of dropping them", async () => {
@@ -330,34 +158,12 @@ describe("convertToOpenAIResponsesInput", () => {
type: "reasoning", type: "reasoning",
id: "rs_1", id: "rs_1",
encrypted_content: "enc_1", encrypted_content: "enc_1",
summary: [], summary: [{ type: "summary_text", text: "thinking..." }],
}, },
]) ])
}) })
test("drops encrypted reasoning with no completed copilot itemId", async () => { test("drops reasoning items with no copilot itemId and warns, as before", async () => {
const { input, warnings } = await convertToOpenAIResponsesInput({
prompt: [
{
role: "assistant",
content: [
{
type: "reasoning",
text: "thinking...",
providerOptions: { copilot: { reasoningEncryptedContent: "enc_1" } },
},
],
},
],
systemMessageMode: "system",
store: false,
})
expect(input).toEqual([])
expect(warnings).toHaveLength(1)
})
test("drops reasoning with neither a copilot itemId nor encrypted content", async () => {
const { input, warnings } = await convertToOpenAIResponsesInput({ const { input, warnings } = await convertToOpenAIResponsesInput({
prompt: [ prompt: [
{ {
+8 -19
View File
@@ -140,11 +140,7 @@ describe("Integration", () => {
yield* integrations.transform((editor) => yield* integrations.transform((editor) =>
editor.method.update({ editor.method.update({
integrationID, integrationID,
method: { method: { type: "key", label: "API key" },
type: "key",
label: "API key",
form: [{ type: "string", key: "accountId", title: "Account ID", required: true }],
},
}), }),
) )
const updated = yield* bus const updated = yield* bus
@@ -152,17 +148,9 @@ describe("Integration", () => {
.pipe(Stream.take(1), Stream.runCollect, Effect.forkScoped) .pipe(Stream.take(1), Stream.runCollect, Effect.forkScoped)
yield* Effect.yieldNow yield* Effect.yieldNow
expect(
yield* integrations.connection.key({ integrationID, key: "secret" }).pipe(
Effect.flip,
Effect.map((error) => error.cause),
),
).toEqual(expect.objectContaining({ message: "Missing required form field: accountId" }))
yield* integrations.connection.key({ yield* integrations.connection.key({
integrationID, integrationID,
key: "secret", key: "secret",
answer: { accountId: "account" },
label: "Work", label: "Work",
}) })
@@ -170,7 +158,7 @@ describe("Integration", () => {
expect.objectContaining({ expect.objectContaining({
integrationID, integrationID,
label: "Work", label: "Work",
value: Credential.Key.make({ type: "key", key: "secret", configuration: { accountId: "account" } }), value: Credential.Key.make({ type: "key", key: "secret" }),
}), }),
]) ])
expect((yield* Fiber.join(updated)).length).toBe(1) expect((yield* Fiber.join(updated)).length).toBe(1)
@@ -255,6 +243,7 @@ describe("Integration", () => {
const attempt = yield* integrations.oauth.connect({ const attempt = yield* integrations.oauth.connect({
integrationID, integrationID,
methodID, methodID,
inputs: {},
label: "Personal", label: "Personal",
}) })
expect(attempt.mode).toBe("code") expect(attempt.mode).toBe("code")
@@ -300,7 +289,7 @@ describe("Integration", () => {
}), }),
) )
const attempt = yield* integrations.oauth.connect({ integrationID, methodID }) const attempt = yield* integrations.oauth.connect({ integrationID, methodID, inputs: {} })
expect( expect(
yield* integrations.oauth.complete({ integrationID, attemptID: attempt.attemptID }).pipe(Effect.flip), yield* integrations.oauth.complete({ integrationID, attemptID: attempt.attemptID }).pipe(Effect.flip),
).toBeInstanceOf(Integration.CodeRequiredError) ).toBeInstanceOf(Integration.CodeRequiredError)
@@ -338,7 +327,7 @@ describe("Integration", () => {
}), }),
) )
const attempt = yield* integrations.oauth.connect({ integrationID, methodID }) const attempt = yield* integrations.oauth.connect({ integrationID, methodID, inputs: {} })
yield* Effect.yieldNow yield* Effect.yieldNow
expect(yield* integrations.oauth.status({ integrationID, attemptID: attempt.attemptID })).toEqual({ expect(yield* integrations.oauth.status({ integrationID, attemptID: attempt.attemptID })).toEqual({
status: "complete", status: "complete",
@@ -376,7 +365,7 @@ describe("Integration", () => {
}), }),
) )
const attempt = yield* integrations.oauth.connect({ integrationID, methodID }) const attempt = yield* integrations.oauth.connect({ integrationID, methodID, inputs: {} })
const exit = yield* integrations.oauth const exit = yield* integrations.oauth
.complete({ integrationID, attemptID: attempt.attemptID, code: "1234" }) .complete({ integrationID, attemptID: attempt.attemptID, code: "1234" })
.pipe(Effect.exit) .pipe(Effect.exit)
@@ -412,7 +401,7 @@ describe("Integration", () => {
}), }),
) )
const attempt = yield* integrations.oauth.connect({ integrationID, methodID }) const attempt = yield* integrations.oauth.connect({ integrationID, methodID, inputs: {} })
expect(attempt.time.expires - attempt.time.created).toBe(Duration.toMillis(Duration.minutes(10))) expect(attempt.time.expires - attempt.time.created).toBe(Duration.toMillis(Duration.minutes(10)))
yield* TestClock.adjust(Duration.minutes(10)) yield* TestClock.adjust(Duration.minutes(10))
yield* Effect.yieldNow yield* Effect.yieldNow
@@ -453,7 +442,7 @@ describe("Integration", () => {
}), }),
) )
const attempt = yield* integrations.oauth.connect({ integrationID, methodID }) const attempt = yield* integrations.oauth.connect({ integrationID, methodID, inputs: {} })
expect(attempt.time).toEqual({ created, expires: expiresAt }) expect(attempt.time).toEqual({ created, expires: expiresAt })
}) })
}) })
+2 -6
View File
@@ -736,11 +736,7 @@ describe("ModelResolver", () => {
headers: { "x-aisdk": "header" }, headers: { "x-aisdk": "header" },
body: { custom: true }, body: { custom: true },
}), }),
Credential.Key.make({ Credential.Key.make({ type: "key", key: "fallback-secret" }),
type: "key",
key: "fallback-secret",
configuration: { accountId: "account" },
}),
{ {
loadAISDK: (runtime) => loadAISDK: (runtime) =>
Effect.sync(() => { Effect.sync(() => {
@@ -749,7 +745,7 @@ describe("ModelResolver", () => {
modelID: "mistral-api-model", modelID: "mistral-api-model",
providerID: "test-provider", providerID: "test-provider",
package: Provider.aisdk("@ai-sdk/mistral"), package: Provider.aisdk("@ai-sdk/mistral"),
settings: { project: "test", apiKey: "fallback-secret", accountId: "account" }, settings: { project: "test", apiKey: "fallback-secret" },
headers: { "x-aisdk": "header" }, headers: { "x-aisdk": "header" },
body: { custom: true }, body: { custom: true },
}) })
+35 -9
View File
@@ -1,5 +1,5 @@
import { Plugin } from "@opencode-ai/plugin/effect" import { Plugin } from "@opencode-ai/plugin/effect"
import type { IntegrationMethod, IntegrationMethodRegistration } from "@opencode-ai/plugin/effect/integration" import type { IntegrationMethodRegistration } from "@opencode-ai/plugin/effect/integration"
import { Agent } from "@opencode-ai/core/agent" import { Agent } from "@opencode-ai/core/agent"
import { Catalog } from "@opencode-ai/core/catalog" import { Catalog } from "@opencode-ai/core/catalog"
import { Credential } from "@opencode-ai/core/credential" import { Credential } from "@opencode-ai/core/credential"
@@ -15,6 +15,7 @@ import { Effect, Stream } from "effect"
type Overrides = Partial<Omit<Plugin.Context, "options" | "session">> & { type Overrides = Partial<Omit<Plugin.Context, "options" | "session">> & {
readonly session?: Partial<Plugin.Context["session"]> readonly session?: Partial<Plugin.Context["session"]>
} }
export function host(overrides: Overrides = {}): Plugin.Context { export function host(overrides: Overrides = {}): Plugin.Context {
return { return {
app: overrides.app ?? { name: "test", version: "test", channel: "test" }, app: overrides.app ?? { name: "test", version: "test", channel: "test" },
@@ -277,7 +278,7 @@ export function integrationHost(integration: Integration.Interface): Plugin.Cont
update: (id, update) => draft.update(Integration.ID.make(id), update), update: (id, update) => draft.update(Integration.ID.make(id), update),
remove: (id) => draft.remove(Integration.ID.make(id)), remove: (id) => draft.remove(Integration.ID.make(id)),
method: { method: {
list: (id) => draft.method.list(Integration.ID.make(id)), list: (id) => draft.method.list(Integration.ID.make(id)).map(method),
update: (input) => { update: (input) => {
if ("authorize" in input) { if ("authorize" in input) {
const methodID = Integration.MethodID.make(input.method.id) const methodID = Integration.MethodID.make(input.method.id)
@@ -285,8 +286,8 @@ export function integrationHost(integration: Integration.Interface): Plugin.Cont
draft.method.update({ draft.method.update({
integrationID: Integration.ID.make(input.integrationID), integrationID: Integration.ID.make(input.integrationID),
method: { ...input.method, id: methodID }, method: { ...input.method, id: methodID },
authorize: (answer) => authorize: (inputs) =>
input.authorize(answer).pipe( input.authorize(inputs).pipe(
Effect.map((authorization) => { Effect.map((authorization) => {
if (authorization.mode === "auto") { if (authorization.mode === "auto") {
return { return {
@@ -335,7 +336,7 @@ export function integrationHost(integration: Integration.Interface): Plugin.Cont
if (input.method.type === "env") { if (input.method.type === "env") {
draft.method.update({ draft.method.update({
integrationID: Integration.ID.make(input.integrationID), integrationID: Integration.ID.make(input.integrationID),
method: input.method, method: { ...input.method, names: [...input.method.names] },
}) })
return return
} }
@@ -345,6 +346,7 @@ export function integrationHost(integration: Integration.Interface): Plugin.Cont
method: { method: {
...input.method, ...input.method,
id: Integration.MethodID.make(input.method.id), id: Integration.MethodID.make(input.method.id),
command: [...input.method.command],
}, },
}) })
return return
@@ -399,11 +401,35 @@ function oauthCredential(value: Credential.OAuth) {
return Credential.OAuth.make({ ...value, methodID: Integration.MethodID.make(value.methodID) }) return Credential.OAuth.make({ ...value, methodID: Integration.MethodID.make(value.methodID) })
} }
function internalMethod(value: IntegrationMethod): Integration.Method { function method(value: Integration.Method) {
if (value.type === "oauth" || value.type === "command") { if (value.type === "env") return { type: value.type, names: [...value.names] }
return { ...value, id: Integration.MethodID.make(value.id) } if (value.type === "key") return { type: value.type, label: value.label }
if (value.type === "command") return { ...value, command: [...value.command] }
return {
type: value.type,
id: value.id,
label: value.label,
prompts: value.prompts?.map((prompt) => {
if (prompt.type === "text") return { ...prompt }
return { ...prompt, options: prompt.options.map((option) => ({ ...option })) }
}),
}
}
function internalMethod(value: IntegrationMethodRegistration["method"]): Integration.Method {
if (value.type === "env") return value
if (value.type === "key") return value
if (value.type === "command") {
return {
...value,
id: Integration.MethodID.make(value.id),
command: [...value.command],
}
}
return {
...value,
id: Integration.MethodID.make(value.id),
} }
return value
} }
function agentInfo(value: Agent.Info) { function agentInfo(value: Agent.Info) {
@@ -8,7 +8,6 @@ import { Plugin } from "@opencode-ai/core/plugin"
import { PluginHost } from "@opencode-ai/core/plugin/host" import { PluginHost } from "@opencode-ai/core/plugin/host"
import { AzurePlugin } from "@opencode-ai/core/plugin/provider/azure" import { AzurePlugin } from "@opencode-ai/core/plugin/provider/azure"
import { Provider } from "@opencode-ai/core/provider" import { Provider } from "@opencode-ai/core/provider"
import { Integration } from "@opencode-ai/core/integration"
import { testEffect } from "../lib/effect" import { testEffect } from "../lib/effect"
import { PluginTestLayer } from "./fixture" import { PluginTestLayer } from "./fixture"
@@ -61,27 +60,6 @@ function fakeSelectorSdk(calls: string[]) {
} }
describe("AzurePlugin", () => { describe("AzurePlugin", () => {
it.effect("registers a resource name form when the environment does not provide one", () =>
withEnv({ AZURE_RESOURCE_NAME: undefined, AZURE_COGNITIVE_SERVICES_RESOURCE_NAME: undefined }, () =>
Effect.gen(function* () {
yield* addPlugin()
expect((yield* (yield* Integration.Service).get(Integration.ID.make("azure")))?.methods).toContainEqual({
type: "key",
label: "API key",
form: [
{
type: "string",
key: "resourceName",
title: "Enter Azure Resource Name",
placeholder: "e.g. my-models",
required: true,
},
],
})
}),
),
)
it.effect("resolves resourceName from env", () => it.effect("resolves resourceName from env", () =>
withEnv({ AZURE_RESOURCE_NAME: "from-env" }, () => withEnv({ AZURE_RESOURCE_NAME: "from-env" }, () =>
Effect.gen(function* () { Effect.gen(function* () {
@@ -217,17 +195,7 @@ describe("AzurePlugin", () => {
Effect.gen(function* () { Effect.gen(function* () {
const plugin = yield* Plugin.Service const plugin = yield* Plugin.Service
const aisdk = yield* AISDK.Service const aisdk = yield* AISDK.Service
const catalog = yield* Catalog.Service
yield* catalog.transform((catalog) =>
catalog.provider.update(Provider.ID.azure, (provider) => {
provider.settings = { ...provider.settings, baseURL: "https://proxy.example.com/openai" }
}),
)
yield* addPlugin() yield* addPlugin()
expect((yield* (yield* Integration.Service).get(Integration.ID.make("azure")))?.methods).toContainEqual({
type: "key",
label: "API key",
})
const result = yield* aisdk.runSDK({ const result = yield* aisdk.runSDK({
model: Model.Info.make({ model: Model.Info.make({
...Model.Info.default(Provider.ID.azure, Model.ID.make("deployment")), ...Model.Info.default(Provider.ID.azure, Model.ID.make("deployment")),
@@ -1,13 +1,11 @@
import { AISDK } from "@opencode-ai/core/aisdk" import { AISDK } from "@opencode-ai/core/aisdk"
import { describe, expect, mock } from "bun:test" import { describe, expect, mock } from "bun:test"
import { Effect } from "effect" import { Effect } from "effect"
import { Catalog } from "@opencode-ai/core/catalog"
import { Model } from "@opencode-ai/core/model" import { Model } from "@opencode-ai/core/model"
import { Plugin } from "@opencode-ai/core/plugin" import { Plugin } from "@opencode-ai/core/plugin"
import { PluginHost } from "@opencode-ai/core/plugin/host" import { PluginHost } from "@opencode-ai/core/plugin/host"
import { CloudflareAIGatewayPlugin } from "@opencode-ai/core/plugin/provider/cloudflare-ai-gateway" import { CloudflareAIGatewayPlugin } from "@opencode-ai/core/plugin/provider/cloudflare-ai-gateway"
import { Provider } from "@opencode-ai/core/provider" import { Provider } from "@opencode-ai/core/provider"
import { Integration } from "@opencode-ai/core/integration"
import { testEffect } from "../lib/effect" import { testEffect } from "../lib/effect"
import { PluginTestLayer } from "./fixture" import { PluginTestLayer } from "./fixture"
@@ -104,24 +102,6 @@ mock.module("ai-gateway-provider/providers/unified", () => ({
})) }))
describe("CloudflareAIGatewayPlugin", () => { describe("CloudflareAIGatewayPlugin", () => {
it.effect("registers account and gateway forms when the environment does not provide them", () =>
withEnv({ CLOUDFLARE_ACCOUNT_ID: undefined, CLOUDFLARE_GATEWAY_ID: undefined }, () =>
Effect.gen(function* () {
yield* addPlugin()
expect(
(yield* (yield* Integration.Service).get(Integration.ID.make("cloudflare-ai-gateway")))?.methods,
).toContainEqual({
type: "key",
label: "Gateway API token",
form: [
expect.objectContaining({ type: "string", key: "accountId", required: true }),
expect.objectContaining({ type: "string", key: "gatewayId", required: true }),
],
})
}),
),
)
it.effect("requires account, gateway, and token before creating the unified SDK", () => it.effect("requires account, gateway, and token before creating the unified SDK", () =>
withEnv( withEnv(
{ {
@@ -377,16 +357,7 @@ describe("CloudflareAIGatewayPlugin", () => {
resetCalls() resetCalls()
const plugin = yield* Plugin.Service const plugin = yield* Plugin.Service
const aisdk = yield* AISDK.Service const aisdk = yield* AISDK.Service
const catalog = yield* Catalog.Service
yield* catalog.transform((catalog) =>
catalog.provider.update(Provider.ID.make("cloudflare-ai-gateway"), (provider) => {
provider.settings = { ...provider.settings, baseURL: "https://proxy.example/v1" }
}),
)
yield* addPlugin() yield* addPlugin()
expect(
(yield* (yield* Integration.Service).get(Integration.ID.make("cloudflare-ai-gateway")))?.methods,
).toContainEqual({ type: "key", label: "Gateway API token" })
const result = yield* aisdk.runSDK({ const result = yield* aisdk.runSDK({
model: Model.Info.make({ model: Model.Info.make({
@@ -7,7 +7,6 @@ import { Plugin } from "@opencode-ai/core/plugin"
import { PluginHost } from "@opencode-ai/core/plugin/host" import { PluginHost } from "@opencode-ai/core/plugin/host"
import { CloudflareWorkersAIPlugin } from "@opencode-ai/core/plugin/provider/cloudflare-workers-ai" import { CloudflareWorkersAIPlugin } from "@opencode-ai/core/plugin/provider/cloudflare-workers-ai"
import { Provider } from "@opencode-ai/core/provider" import { Provider } from "@opencode-ai/core/provider"
import { Integration } from "@opencode-ai/core/integration"
import type { LanguageModelV3 } from "@ai-sdk/provider" import type { LanguageModelV3 } from "@ai-sdk/provider"
import { testEffect } from "../lib/effect" import { testEffect } from "../lib/effect"
import { PluginTestLayer } from "./fixture" import { PluginTestLayer } from "./fixture"
@@ -80,29 +79,6 @@ function cloudflareHeaders(sdk: unknown, modelID = "@cf/model") {
} }
describe("CloudflareWorkersAIPlugin", () => { describe("CloudflareWorkersAIPlugin", () => {
it.effect("registers an account form when the environment does not provide one", () =>
withEnv({ CLOUDFLARE_ACCOUNT_ID: undefined }, () =>
Effect.gen(function* () {
yield* addPlugin()
expect(
(yield* (yield* Integration.Service).get(Integration.ID.make("cloudflare-workers-ai")))?.methods,
).toContainEqual({
type: "key",
label: "API key",
form: [
{
type: "string",
key: "accountId",
title: "Enter your Cloudflare Account ID",
placeholder: "e.g. 1234567890abcdef1234567890abcdef",
required: true,
},
],
})
}),
),
)
it.effect("maps account ID to endpoint URL and creates an OpenAI-compatible SDK", () => it.effect("maps account ID to endpoint URL and creates an OpenAI-compatible SDK", () =>
withEnv({ CLOUDFLARE_ACCOUNT_ID: "acct", CLOUDFLARE_API_KEY: "key" }, () => withEnv({ CLOUDFLARE_ACCOUNT_ID: "acct", CLOUDFLARE_API_KEY: "key" }, () =>
Effect.gen(function* () { Effect.gen(function* () {
@@ -115,9 +91,6 @@ describe("CloudflareWorkersAIPlugin", () => {
}), }),
) )
yield* addPlugin() yield* addPlugin()
expect(
(yield* (yield* Integration.Service).get(Integration.ID.make("cloudflare-workers-ai")))?.methods,
).toContainEqual({ type: "key", label: "API key" })
const provider = required(yield* catalog.provider.get(Provider.ID.make("cloudflare-workers-ai"))) const provider = required(yield* catalog.provider.get(Provider.ID.make("cloudflare-workers-ai")))
const sdk = yield* aisdk.runSDK({ const sdk = yield* aisdk.runSDK({
model: Model.Info.make({ model: Model.Info.make({
@@ -162,16 +135,7 @@ describe("CloudflareWorkersAIPlugin", () => {
Effect.gen(function* () { Effect.gen(function* () {
const plugin = yield* Plugin.Service const plugin = yield* Plugin.Service
const aisdk = yield* AISDK.Service const aisdk = yield* AISDK.Service
const catalog = yield* Catalog.Service
yield* catalog.transform((catalog) =>
catalog.provider.update(Provider.ID.make("cloudflare-workers-ai"), (provider) => {
provider.settings = { ...provider.settings, baseURL: "https://proxy.example/v1" }
}),
)
yield* addPlugin() yield* addPlugin()
expect(
(yield* (yield* Integration.Service).get(Integration.ID.make("cloudflare-workers-ai")))?.methods,
).toContainEqual({ type: "key", label: "API key" })
const result = yield* aisdk.runSDK({ const result = yield* aisdk.runSDK({
model: Model.Info.make({ model: Model.Info.make({
...Model.Info.default(Provider.ID.make("cloudflare-workers-ai"), Model.ID.make("@cf/model")), ...Model.Info.default(Provider.ID.make("cloudflare-workers-ai"), Model.ID.make("@cf/model")),
@@ -1,14 +1,11 @@
import { AISDK } from "@opencode-ai/core/aisdk" import { AISDK } from "@opencode-ai/core/aisdk"
import { App } from "@opencode-ai/core/app" import { App } from "@opencode-ai/core/app"
import { Agent } from "@opencode-ai/schema/agent"
import { Session } from "@opencode-ai/schema/session"
import { describe, expect, test } from "bun:test" import { describe, expect, test } from "bun:test"
import { Effect } from "effect" import { Effect } from "effect"
import { Catalog } from "@opencode-ai/core/catalog" import { Catalog } from "@opencode-ai/core/catalog"
import { Model } from "@opencode-ai/core/model" import { Model } from "@opencode-ai/core/model"
import { Plugin } from "@opencode-ai/core/plugin" import { Plugin } from "@opencode-ai/core/plugin"
import { PluginHost } from "@opencode-ai/core/plugin/host" import { PluginHost } from "@opencode-ai/core/plugin/host"
import { PluginHooks } from "@opencode-ai/core/plugin/hooks"
import { copilotBaseURL, copilotFetch, GithubCopilotPlugin } from "@opencode-ai/core/plugin/provider/github-copilot" import { copilotBaseURL, copilotFetch, GithubCopilotPlugin } from "@opencode-ai/core/plugin/provider/github-copilot"
import { Provider } from "@opencode-ai/core/provider" import { Provider } from "@opencode-ai/core/provider"
import { Integration } from "@opencode-ai/core/integration" import { Integration } from "@opencode-ai/core/integration"
@@ -60,37 +57,11 @@ describe("GithubCopilotPlugin", () => {
id: Integration.MethodID.make("device"), id: Integration.MethodID.make("device"),
type: "oauth", type: "oauth",
label: "Login with GitHub Copilot", label: "Login with GitHub Copilot",
form: expect.any(Array), prompts: expect.any(Array),
}) })
}), }),
) )
it.effect("removes the generic key method", () =>
Effect.gen(function* () {
const integrations = yield* Integration.Service
yield* integrations.transform((draft) => {
draft.method.update({
integrationID: Integration.ID.make("github-copilot"),
method: { type: "key" },
})
draft.method.update({
integrationID: Integration.ID.make("github-copilot"),
method: { type: "env", names: ["GITHUB_TOKEN"] },
})
})
yield* addPlugin()
expect((yield* integrations.get(Integration.ID.make("github-copilot")))?.methods).toEqual([
{ type: "env", names: ["GITHUB_TOKEN"] },
{
id: Integration.MethodID.make("device"),
type: "oauth",
label: "Login with GitHub Copilot",
form: expect.any(Array),
},
])
}),
)
it.live("adds Copilot authentication and request metadata headers", () => it.live("adds Copilot authentication and request metadata headers", () =>
Effect.gen(function* () { Effect.gen(function* () {
const requests: Headers[] = [] const requests: Headers[] = []
@@ -100,6 +71,7 @@ describe("GithubCopilotPlugin", () => {
requests.push(new Headers(init?.headers)) requests.push(new Headers(init?.headers))
return Response.json({ ok: true }) return Response.json({ ok: true })
}, },
false,
App.make({ name: "test", version: "1.2.3", channel: "beta" }), App.make({ name: "test", version: "1.2.3", channel: "beta" }),
) )
yield* Effect.promise(() => yield* Effect.promise(() =>
@@ -120,27 +92,6 @@ describe("GithubCopilotPlugin", () => {
}), }),
) )
it.effect("adds Copilot authentication to native Anthropic requests", () =>
Effect.gen(function* () {
yield* addPlugin()
const event = yield* (yield* PluginHooks.Service).trigger("session", "http.request", {
sessionID: Session.ID.make("ses_test"),
agent: Agent.ID.make("build"),
model: Model.Ref.make({ providerID: Provider.ID.githubCopilot, id: Model.ID.make("claude-sonnet-4.5") }),
request: new Request("https://api.githubcopilot.com/v1/messages", {
method: "POST",
headers: { "Content-Type": "application/json", "x-api-key": "token" },
body: JSON.stringify({ messages: [{ role: "user", content: [{ type: "text", text: "hello" }] }] }),
}),
})
expect(event.request.headers.get("authorization")).toBe("Bearer token")
expect(event.request.headers.has("x-api-key")).toBe(false)
expect(event.request.headers.get("x-initiator")).toBe("user")
expect(event.request.headers.get("anthropic-beta")).toBe("interleaved-thinking-2025-05-14")
expect(event.request.headers.get("x-github-api-version")).toBe("2026-06-01")
}),
)
it.effect("creates the bundled Copilot SDK for the GitHub Copilot package", () => it.effect("creates the bundled Copilot SDK for the GitHub Copilot package", () =>
Effect.gen(function* () { Effect.gen(function* () {
const plugin = yield* Plugin.Service const plugin = yield* Plugin.Service
@@ -128,7 +128,7 @@ describe("OpencodePlugin", () => {
const attempt = yield* integrations.oauth.connect({ const attempt = yield* integrations.oauth.connect({
integrationID, integrationID,
methodID: Integration.MethodID.make("device"), methodID: Integration.MethodID.make("device"),
answer: { server: `${server.url.origin}/console///?ignored=true#ignored` }, inputs: { server: `${server.url.origin}/console///?ignored=true#ignored` },
}) })
expect(attempt.url).toBe(`${server.url.origin}/verify`) expect(attempt.url).toBe(`${server.url.origin}/verify`)
yield* eventually( yield* eventually(
@@ -155,7 +155,7 @@ describe("OpencodePlugin", () => {
.connect({ .connect({
integrationID: Integration.ID.make("opencode"), integrationID: Integration.ID.make("opencode"),
methodID: Integration.MethodID.make("device"), methodID: Integration.MethodID.make("device"),
answer: { server: "ftp://console.example.com" }, inputs: { server: "ftp://console.example.com" },
}) })
.pipe(Effect.flip) .pipe(Effect.flip)
expect(error).toBeInstanceOf(Integration.AuthorizationError) expect(error).toBeInstanceOf(Integration.AuthorizationError)
@@ -163,21 +163,6 @@ describe("OpencodePlugin", () => {
}), }),
) )
it.effect("rejects non-string OpenCode servers", () =>
Effect.gen(function* () {
yield* addPlugin()
const error = yield* (yield* Integration.Service).oauth
.connect({
integrationID: Integration.ID.make("opencode"),
methodID: Integration.MethodID.make("device"),
answer: { server: true },
})
.pipe(Effect.flip)
expect(error).toBeInstanceOf(Integration.AuthorizationError)
expect(String(error.cause)).toContain("Invalid OpenCode server URL: expected string")
}),
)
it.live("loads providers and models from the connected OpenCode server", () => it.live("loads providers and models from the connected OpenCode server", () =>
Effect.acquireUseRelease( Effect.acquireUseRelease(
Effect.sync(() => { Effect.sync(() => {
+1 -4
View File
@@ -129,10 +129,7 @@ describe("built-in web search providers", () => {
yield* WebSearchParallel.Plugin.effect( yield* WebSearchParallel.Plugin.effect(
host({ integration: integrationHost(integrations), websearch: webSearchHost(websearch) }), host({ integration: integrationHost(integrations), websearch: webSearchHost(websearch) }),
) )
yield* integrations.connection.key({ yield* integrations.connection.key({ integrationID: Integration.ID.make("parallel"), key: "parallel-secret" })
integrationID: Integration.ID.make("parallel"),
key: "parallel-secret",
})
const output = yield* websearch.query({ const output = yield* websearch.query({
query: "effect layers", query: "effect layers",
+5
View File
@@ -90,10 +90,15 @@ test("Core reuses the canonical shared schemas", async () => {
[coreFileSystem.Match, FileSystem.Match], [coreFileSystem.Match, FileSystem.Match],
[coreIntegration.ID, Integration.ID], [coreIntegration.ID, Integration.ID],
[coreIntegration.MethodID, Integration.MethodID], [coreIntegration.MethodID, Integration.MethodID],
[coreIntegration.When, Integration.When],
[coreIntegration.TextPrompt, Integration.TextPrompt],
[coreIntegration.SelectPrompt, Integration.SelectPrompt],
[coreIntegration.Prompt, Integration.Prompt],
[coreIntegration.OAuthMethod, Integration.OAuthMethod], [coreIntegration.OAuthMethod, Integration.OAuthMethod],
[coreIntegration.KeyMethod, Integration.KeyMethod], [coreIntegration.KeyMethod, Integration.KeyMethod],
[coreIntegration.EnvMethod, Integration.EnvMethod], [coreIntegration.EnvMethod, Integration.EnvMethod],
[coreIntegration.Method, Integration.Method], [coreIntegration.Method, Integration.Method],
[coreIntegration.Inputs, Integration.Inputs],
[coreIntegration.Ref, Integration.Ref], [coreIntegration.Ref, Integration.Ref],
[coreLocation.Ref, Location.Ref], [coreLocation.Ref, Location.Ref],
[coreAI.ProviderMetadata, AI.ProviderMetadata], [coreAI.ProviderMetadata, AI.ProviderMetadata],
+67 -55
View File
@@ -1,7 +1,7 @@
import fs from "fs/promises" import fs from "fs/promises"
import path from "path" import path from "path"
import { describe, expect } from "bun:test" import { describe, expect } from "bun:test"
import { Effect, Layer } from "effect" import { Deferred, Effect, Fiber, Layer } from "effect"
import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder" import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder"
import { LayerNode } from "@opencode-ai/util/effect/layer-node" import { LayerNode } from "@opencode-ai/util/effect/layer-node"
import { Environment } from "@opencode-ai/core/environment" import { Environment } from "@opencode-ai/core/environment"
@@ -40,6 +40,7 @@ const assertions: Permission.AssertInput[] = []
const writes: string[] = [] const writes: string[] = []
let reads = 0 let reads = 0
let denyAction: string | undefined let denyAction: string | undefined
let afterPermission = (_input: Permission.AssertInput): Effect.Effect<void> => Effect.void
let afterRead = (_target: string, _content: Uint8Array): Effect.Effect<void> => Effect.void let afterRead = (_target: string, _content: Uint8Array): Effect.Effect<void> => Effect.void
let formatFile = (_target: string): Effect.Effect<boolean> => Effect.succeed(false) let formatFile = (_target: string): Effect.Effect<boolean> => Effect.succeed(false)
@@ -48,6 +49,7 @@ const permission = Layer.succeed(
Permission.Service.of({ Permission.Service.of({
assert: (input) => assert: (input) =>
Effect.sync(() => assertions.push(input)).pipe( Effect.sync(() => assertions.push(input)).pipe(
Effect.andThen(Effect.suspend(() => afterPermission(input))),
Effect.andThen( Effect.andThen(
input.action === denyAction input.action === denyAction
? Effect.fail( ? Effect.fail(
@@ -77,6 +79,7 @@ const reset = () => {
writes.length = 0 writes.length = 0
reads = 0 reads = 0
denyAction = undefined denyAction = undefined
afterPermission = () => Effect.void
afterRead = () => Effect.void afterRead = () => Effect.void
formatFile = () => Effect.succeed(false) formatFile = () => Effect.succeed(false)
} }
@@ -174,17 +177,7 @@ describe("EditTool", () => {
}) })
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("after\nrest\n") expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("after\nrest\n")
expect(assertions).toMatchObject([{ sessionID, action: "edit", resources: ["hello.txt"], save: ["*"] }]) expect(assertions).toMatchObject([{ sessionID, action: "edit", resources: ["hello.txt"], save: ["*"] }])
expect(assertions[0]?.metadata).toMatchObject({ expect(assertions[0]?.metadata).toBeUndefined()
files: [
{
file: "hello.txt",
status: "modified",
additions: 1,
deletions: 1,
patch: expect.stringContaining("-before\n+after"),
},
],
})
expect(writes).toEqual([yield* Effect.promise(() => fs.realpath(target))]) expect(writes).toEqual([yield* Effect.promise(() => fs.realpath(target))])
}), }),
), ),
@@ -349,7 +342,7 @@ describe("EditTool", () => {
error: { type: "permission.rejected", message: "Permission denied: edit" }, error: { type: "permission.rejected", message: "Permission denied: edit" },
}) })
expect(assertions.map((input) => input.action)).toEqual(["external_directory", "edit"]) expect(assertions.map((input) => input.action)).toEqual(["external_directory", "edit"])
expect(reads).toBe(1) expect(reads).toBe(0)
expect(writes).toEqual([]) expect(writes).toEqual([])
expect(yield* Effect.promise(() => fs.readFile(external, "utf8"))).toBe("before") expect(yield* Effect.promise(() => fs.readFile(external, "utf8"))).toBe("before")
}), }),
@@ -386,7 +379,7 @@ describe("EditTool", () => {
}) })
expect(missing).toEqual(matching) expect(missing).toEqual(matching)
expect(assertions.map((input) => input.action)).toEqual(["edit", "edit"]) expect(assertions.map((input) => input.action)).toEqual(["edit", "edit"])
expect(reads).toBe(2) expect(reads).toBe(0)
expect(writes).toEqual([]) expect(writes).toEqual([])
}), }),
), ),
@@ -643,58 +636,77 @@ describe("EditTool", () => {
(tmp) => { (tmp) => {
reset() reset()
const target = path.join(tmp.path, "concurrent.txt") const target = path.join(tmp.path, "concurrent.txt")
afterRead = () => (reads === 1 ? Effect.sleep("50 millis") : Effect.void) return Effect.gen(function* () {
return Effect.promise(() => fs.writeFile(target, "one\ntwo\n")).pipe( yield* Effect.promise(() => fs.writeFile(target, "one\ntwo\n"))
Effect.andThen( const firstRead = yield* Deferred.make<void>()
withTool(tmp.path, (registry) => const releaseFirst = yield* Deferred.make<void>()
Effect.all( const secondApproved = yield* Deferred.make<void>()
[ afterRead = () =>
executeTool( reads === 1
registry, ? Deferred.succeed(firstRead, undefined).pipe(Effect.andThen(Deferred.await(releaseFirst)))
call({ path: "concurrent.txt", oldString: "one", newString: "ONE" }, "call-edit-one"), : Effect.void
), afterPermission = (input) =>
executeTool( input.source?.id === "call-edit-two"
registry, ? Deferred.succeed(secondApproved, undefined).pipe(Effect.asVoid)
call({ path: "concurrent.txt", oldString: "two", newString: "TWO" }, "call-edit-two"), : Effect.void
),
], const first = yield* withTool(tmp.path, (registry) =>
{ concurrency: "unbounded" }, executeTool(
), registry,
call({ path: "concurrent.txt", oldString: "one", newString: "ONE" }, "call-edit-one"),
), ),
), ).pipe(Effect.forkChild)
Effect.andThen((results) => yield* Deferred.await(firstRead)
Effect.gen(function* () { const second = yield* withTool(tmp.path, (registry) =>
expect(results.map((result) => result.status)).toEqual(["completed", "completed"]) executeTool(
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("ONE\nTWO\n") registry,
}), call({ path: "concurrent.txt", oldString: "two", newString: "TWO" }, "call-edit-two"),
), ),
) ).pipe(Effect.forkChild)
yield* Deferred.await(secondApproved)
expect(reads).toBe(1)
yield* Deferred.succeed(releaseFirst, undefined)
expect((yield* Fiber.join(first)).status).toBe("completed")
expect((yield* Fiber.join(second)).status).toBe("completed")
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("ONE\nTWO\n")
})
}, },
(tmp) => Effect.promise(() => tmp[Symbol.asyncDispose]()), (tmp) => Effect.promise(() => tmp[Symbol.asyncDispose]()),
), ),
) )
it.live("applies the edit when content changes after matching", () => it.live("validates current content after permission succeeds", () =>
Effect.acquireUseRelease( Effect.acquireUseRelease(
Effect.promise(() => tmpdir()), Effect.promise(() => tmpdir()),
(tmp) => { (tmp) => {
reset() reset()
const target = path.join(tmp.path, "concurrent.txt") const target = path.join(tmp.path, "concurrent.txt")
afterRead = () => (reads === 1 ? Effect.promise(() => fs.writeFile(target, "newer\n")) : Effect.void) return Effect.gen(function* () {
return Effect.promise(() => fs.writeFile(target, "before\n")).pipe( yield* Effect.promise(() => fs.writeFile(target, "before\n"))
Effect.andThen( const permissionReached = yield* Deferred.make<void>()
withTool(tmp.path, (registry) => const releasePermission = yield* Deferred.make<void>()
executeTool(registry, call({ path: "concurrent.txt", oldString: "before", newString: "after" })), afterPermission = (input) =>
), input.action === "edit"
), ? Deferred.succeed(permissionReached, undefined).pipe(Effect.andThen(Deferred.await(releasePermission)))
Effect.andThen((result) => : Effect.void
Effect.gen(function* () {
expect(result).toMatchObject({ status: "completed", output: { replacements: 1 } }) const edit = yield* withTool(tmp.path, (registry) =>
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("after\n") executeTool(registry, call({ path: "concurrent.txt", oldString: "before", newString: "after" })),
expect(writes).toEqual([target]) ).pipe(Effect.forkChild)
}), yield* Deferred.await(permissionReached)
), expect(reads).toBe(0)
) yield* Effect.promise(() => fs.writeFile(target, "newer\n"))
yield* Deferred.succeed(releasePermission, undefined)
expect(yield* Fiber.join(edit)).toMatchObject({
status: "error",
error: { message: expect.stringContaining("Could not find oldString") },
})
expect(reads).toBe(1)
expect(writes).toEqual([])
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("newer\n")
})
}, },
(tmp) => Effect.promise(() => tmp[Symbol.asyncDispose]()), (tmp) => Effect.promise(() => tmp[Symbol.asyncDispose]()),
), ),
+78 -45
View File
@@ -1,7 +1,7 @@
import fs from "fs/promises" import fs from "fs/promises"
import path from "path" import path from "path"
import { describe, expect } from "bun:test" import { describe, expect } from "bun:test"
import { Effect, Exit, Layer, Schema } from "effect" import { Deferred, Effect, Exit, Fiber, Layer, Schema } from "effect"
import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder" import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder"
import { LayerNode } from "@opencode-ai/util/effect/layer-node" import { LayerNode } from "@opencode-ai/util/effect/layer-node"
import { Environment } from "@opencode-ai/core/environment" import { Environment } from "@opencode-ai/core/environment"
@@ -33,9 +33,11 @@ let denyAction: string | undefined
let failRemoveTarget: string | undefined let failRemoveTarget: string | undefined
let failRemoveErrorTarget: string | undefined let failRemoveErrorTarget: string | undefined
let failWriteTarget: string | undefined let failWriteTarget: string | undefined
let reads = 0
let readsBeforeEditApproval = 0 let readsBeforeEditApproval = 0
let editApproved = false let editApproved = false
let afterEditApproval = (): Effect.Effect<void> => Effect.void let afterEditApproval = (_input: Permission.AssertInput): Effect.Effect<void> => Effect.void
let afterRead = (_target: string, _content: Uint8Array): Effect.Effect<void> => Effect.void
let formatFile = (_target: string): Effect.Effect<boolean> => Effect.succeed(false) let formatFile = (_target: string): Effect.Effect<boolean> => Effect.succeed(false)
const permission = Layer.succeed( const permission = Layer.succeed(
@@ -46,7 +48,7 @@ const permission = Layer.succeed(
assertions.push(input) assertions.push(input)
if (input.action === "edit") editApproved = true if (input.action === "edit") editApproved = true
}).pipe( }).pipe(
Effect.andThen(input.action === "edit" ? Effect.suspend(afterEditApproval) : Effect.void), Effect.andThen(input.action === "edit" ? Effect.suspend(() => afterEditApproval(input)) : Effect.void),
Effect.andThen( Effect.andThen(
input.action === denyAction input.action === denyAction
? Effect.fail( ? Effect.fail(
@@ -77,9 +79,11 @@ const reset = () => {
failRemoveTarget = undefined failRemoveTarget = undefined
failRemoveErrorTarget = undefined failRemoveErrorTarget = undefined
failWriteTarget = undefined failWriteTarget = undefined
reads = 0
readsBeforeEditApproval = 0 readsBeforeEditApproval = 0
editApproved = false editApproved = false
afterEditApproval = () => Effect.void afterEditApproval = () => Effect.void
afterRead = () => Effect.void
formatFile = () => Effect.succeed(false) formatFile = () => Effect.succeed(false)
} }
@@ -104,8 +108,12 @@ const withTool = <A, E, R>(
transformEnvironmentFiles(activeLocation, (files) => ({ transformEnvironmentFiles(activeLocation, (files) => ({
read: (target, range) => read: (target, range) =>
Effect.sync(() => { Effect.sync(() => {
reads++
if (!editApproved) readsBeforeEditApproval++ if (!editApproved) readsBeforeEditApproval++
}).pipe(Effect.andThen(files.read(target, range))), }).pipe(
Effect.andThen(files.read(target, range)),
Effect.tap((result) => Effect.suspend(() => afterRead(target, result.bytes))),
),
remove: (target) => { remove: (target) => {
if (failRemoveTarget && path.basename(target) === failRemoveTarget) if (failRemoveTarget && path.basename(target) === failRemoveTarget)
return Effect.die("forced remove failure") return Effect.die("forced remove failure")
@@ -219,14 +227,10 @@ describe("PatchTool", () => {
action: "edit", action: "edit",
resources: ["nested/new.txt", "update.txt", "remove.txt"], resources: ["nested/new.txt", "update.txt", "remove.txt"],
save: ["*"], save: ["*"],
metadata: {
filepath: "nested/new.txt, update.txt, remove.txt",
diff: expect.stringContaining("Index:"),
files: expect.any(Array),
},
}, },
]) ])
expect(readsBeforeEditApproval).toBe(2) expect(assertions[0]?.metadata).toBeUndefined()
expect(readsBeforeEditApproval).toBe(0)
expect(yield* Effect.promise(() => fs.readFile(path.join(tmp.path, "nested/new.txt"), "utf8"))).toBe( expect(yield* Effect.promise(() => fs.readFile(path.join(tmp.path, "nested/new.txt"), "utf8"))).toBe(
"created\n", "created\n",
) )
@@ -267,40 +271,69 @@ describe("PatchTool", () => {
it.live("serializes concurrent patch transactions", () => it.live("serializes concurrent patch transactions", () =>
withTempTool((directory, registry) => { withTempTool((directory, registry) => {
const target = path.join(directory, "concurrent.txt") const target = path.join(directory, "concurrent.txt")
afterEditApproval = () => return Effect.gen(function* () {
assertions.filter((input) => input.action === "edit").length === 1 ? Effect.sleep("50 millis") : Effect.void yield* Effect.promise(() => fs.writeFile(target, "one\ntwo\n"))
return Effect.promise(() => fs.writeFile(target, "one\ntwo\n")).pipe( const firstRead = yield* Deferred.make<void>()
Effect.andThen( const releaseFirst = yield* Deferred.make<void>()
Effect.all( const secondApproved = yield* Deferred.make<void>()
[ afterRead = () =>
executeTool( reads === 1
registry, ? Deferred.succeed(firstRead, undefined).pipe(Effect.andThen(Deferred.await(releaseFirst)))
call( : Effect.void
"*** Begin Patch\n*** Update File: concurrent.txt\n@@\n-one\n+ONE\n*** End Patch", afterEditApproval = (input) =>
"call-patch-one", input.source?.id === "call-patch-two"
), ? Deferred.succeed(secondApproved, undefined).pipe(Effect.asVoid)
), : Effect.void
executeTool(
registry, const first = yield* executeTool(
call( registry,
"*** Begin Patch\n*** Update File: concurrent.txt\n@@\n-two\n+TWO\n*** End Patch", call("*** Begin Patch\n*** Update File: concurrent.txt\n@@\n-one\n+ONE\n*** End Patch", "call-patch-one"),
"call-patch-two", ).pipe(Effect.forkChild)
), yield* Deferred.await(firstRead)
), const second = yield* executeTool(
], registry,
{ concurrency: "unbounded" }, call("*** Begin Patch\n*** Update File: concurrent.txt\n@@\n-two\n+TWO\n*** End Patch", "call-patch-two"),
), ).pipe(Effect.forkChild)
), yield* Deferred.await(secondApproved)
Effect.andThen((results) => expect(reads).toBe(1)
Effect.gen(function* () {
expect(results.map((result) => result.status)).toEqual(["completed", "completed"]) yield* Deferred.succeed(releaseFirst, undefined)
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("ONE\nTWO\n") expect((yield* Fiber.join(first)).status).toBe("completed")
}), expect((yield* Fiber.join(second)).status).toBe("completed")
), expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("ONE\nTWO\n")
) })
}), }),
) )
it.live("validates patch context after permission succeeds", () =>
withTempTool((directory, registry) =>
Effect.gen(function* () {
const target = path.join(directory, "current.txt")
yield* Effect.promise(() => fs.writeFile(target, "before\n"))
const permissionReached = yield* Deferred.make<void>()
const releasePermission = yield* Deferred.make<void>()
afterEditApproval = () =>
Deferred.succeed(permissionReached, undefined).pipe(Effect.andThen(Deferred.await(releasePermission)))
const patch = yield* executeTool(
registry,
call("*** Begin Patch\n*** Update File: current.txt\n@@\n-before\n+after\n*** End Patch"),
).pipe(Effect.forkChild)
yield* Deferred.await(permissionReached)
expect(reads).toBe(0)
yield* Effect.promise(() => fs.writeFile(target, "newer\n"))
yield* Deferred.succeed(releasePermission, undefined)
expect(yield* Fiber.join(patch)).toMatchObject({
status: "error",
error: { message: expect.stringContaining("Failed to find expected lines") },
})
expect(reads).toBe(1)
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("newer\n")
}),
),
)
it.live("returns file diffs for final formatted content", () => it.live("returns file diffs for final formatted content", () =>
withTempTool((directory, registry) => { withTempTool((directory, registry) => {
const target = path.join(directory, "formatted.txt") const target = path.join(directory, "formatted.txt")
@@ -783,7 +816,7 @@ describe("PatchTool", () => {
), ),
) )
it.live("approves an external directory before reading and requests edit permission afterward", () => it.live("approves external-directory and edit access before reading", () =>
Effect.acquireUseRelease( Effect.acquireUseRelease(
Effect.promise(() => Promise.all([tmpdir(), tmpdir()])), Effect.promise(() => Promise.all([tmpdir(), tmpdir()])),
([active, outside]) => { ([active, outside]) => {
@@ -800,7 +833,7 @@ describe("PatchTool", () => {
), ),
).toMatchObject({ status: "completed" }) ).toMatchObject({ status: "completed" })
expect(assertions.map((input) => input.action)).toEqual(["external_directory", "edit"]) expect(assertions.map((input) => input.action)).toEqual(["external_directory", "edit"])
expect(readsBeforeEditApproval).toBe(1) expect(readsBeforeEditApproval).toBe(0)
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("after\n") expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("after\n")
}), }),
), ),
@@ -931,7 +964,7 @@ describe("PatchTool", () => {
), ),
) )
it.live("approves a relative external target before reading and requests edit permission afterward", () => it.live("approves a relative external target before reading", () =>
Effect.acquireUseRelease( Effect.acquireUseRelease(
Effect.promise(() => Promise.all([tmpdir(), tmpdir()])), Effect.promise(() => Promise.all([tmpdir(), tmpdir()])),
([active, outside]) => { ([active, outside]) => {
@@ -949,7 +982,7 @@ describe("PatchTool", () => {
), ),
).toMatchObject({ status: "completed" }) ).toMatchObject({ status: "completed" })
expect(assertions.map((input) => input.action)).toEqual(["external_directory", "edit"]) expect(assertions.map((input) => input.action)).toEqual(["external_directory", "edit"])
expect(readsBeforeEditApproval).toBe(1) expect(readsBeforeEditApproval).toBe(0)
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("after\n") expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("after\n")
}), }),
), ),
+131 -25
View File
@@ -1,7 +1,7 @@
import fs from "fs/promises" import fs from "fs/promises"
import path from "path" import path from "path"
import { describe, expect } from "bun:test" import { describe, expect } from "bun:test"
import { Effect, Layer } from "effect" import { Deferred, Effect, Fiber, Layer } from "effect"
import { FileMutation } from "@opencode-ai/core/file-mutation" import { FileMutation } from "@opencode-ai/core/file-mutation"
import { Formatter } from "@opencode-ai/core/formatter" import { Formatter } from "@opencode-ai/core/formatter"
import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder" import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder"
@@ -13,6 +13,7 @@ import { Permission } from "@opencode-ai/core/permission"
import { AbsolutePath } from "@opencode-ai/core/schema" import { AbsolutePath } from "@opencode-ai/core/schema"
import { Session } from "@opencode-ai/core/session" import { Session } from "@opencode-ai/core/session"
import { Tool } from "@opencode-ai/core/tool" import { Tool } from "@opencode-ai/core/tool"
import { EditTool } from "@opencode-ai/core/tool/plugin/edit"
import { WriteTool } from "@opencode-ai/core/tool/plugin/write" import { WriteTool } from "@opencode-ai/core/tool/plugin/write"
import { transformEnvironmentFiles } from "./fixture/environment" import { transformEnvironmentFiles } from "./fixture/environment"
import { location } from "./fixture/location" import { location } from "./fixture/location"
@@ -27,10 +28,26 @@ const writeToolNode = makeLocationNode({
deps: [Tool.node, LocationMutation.node, FileMutation.node, Environment.node, Formatter.node, Permission.node], deps: [Tool.node, LocationMutation.node, FileMutation.node, Environment.node, Formatter.node, Permission.node],
}) })
const editToolNode = makeLocationNode({
name: "test/edit-tool-plugin",
layer: Layer.effectDiscard(registerToolPlugin(EditTool.Plugin)),
deps: [
Tool.node,
LocationMutation.node,
FileMutation.node,
Environment.node,
Formatter.node,
Location.node,
Permission.node,
],
})
const sessionID = Session.ID.make("ses_write_tool_test") const sessionID = Session.ID.make("ses_write_tool_test")
const assertions: Permission.AssertInput[] = [] const assertions: Permission.AssertInput[] = []
const writes: string[] = [] const writes: string[] = []
let reads = 0
let formatFile = (_target: string): Effect.Effect<boolean> => Effect.succeed(false) let formatFile = (_target: string): Effect.Effect<boolean> => Effect.succeed(false)
let afterPermission = (_input: Permission.AssertInput): Effect.Effect<void> => Effect.void
let denyAction: string | undefined let denyAction: string | undefined
const permission = Layer.succeed( const permission = Layer.succeed(
@@ -38,6 +55,7 @@ const permission = Layer.succeed(
Permission.Service.of({ Permission.Service.of({
assert: (input) => assert: (input) =>
Effect.sync(() => assertions.push(input)).pipe( Effect.sync(() => assertions.push(input)).pipe(
Effect.andThen(Effect.suspend(() => afterPermission(input))),
Effect.andThen( Effect.andThen(
input.action === denyAction input.action === denyAction
? Effect.fail( ? Effect.fail(
@@ -65,11 +83,17 @@ const formatter = Layer.mock(Formatter.Service, {
const reset = () => { const reset = () => {
assertions.length = 0 assertions.length = 0
writes.length = 0 writes.length = 0
reads = 0
formatFile = () => Effect.succeed(false) formatFile = () => Effect.succeed(false)
afterPermission = () => Effect.void
denyAction = undefined denyAction = undefined
} }
const withTool = <A, E, R>(directory: string, body: (registry: Tool.Interface) => Effect.Effect<A, E, R>) => { const withTool = <A, E, R>(
directory: string,
body: (registry: Tool.Interface) => Effect.Effect<A, E, R>,
options?: { edit?: boolean },
) => {
const activeLocation = Layer.succeed( const activeLocation = Layer.succeed(
Location.Service, Location.Service,
Location.Service.of(location({ directory: AbsolutePath.make(directory) })), Location.Service.of(location({ directory: AbsolutePath.make(directory) })),
@@ -79,11 +103,18 @@ const withTool = <A, E, R>(directory: string, body: (registry: Tool.Interface) =
}).pipe( }).pipe(
Effect.provide( Effect.provide(
AppNodeBuilder.build( AppNodeBuilder.build(
LayerNode.group([Tool.node, Tool.node, LocationMutation.node, FileMutation.node, writeToolNode]), LayerNode.group([
Tool.node,
LocationMutation.node,
FileMutation.node,
writeToolNode,
...(options?.edit ? [editToolNode] : []),
]),
[ [
[ [
Environment.node, Environment.node,
transformEnvironmentFiles(activeLocation, (files) => ({ transformEnvironmentFiles(activeLocation, (files) => ({
read: (target, range) => Effect.sync(() => reads++).pipe(Effect.andThen(files.read(target, range))),
write: (target, content) => write: (target, content) =>
Effect.sync(() => writes.push(target)).pipe(Effect.andThen(files.write(target, content))), Effect.sync(() => writes.push(target)).pipe(Effect.andThen(files.write(target, content))),
})), })),
@@ -103,6 +134,12 @@ const call = (input: typeof WriteTool.Input.Type, id = "call-write") => ({
call: { type: "tool-call" as const, id, name: "write", input }, call: { type: "tool-call" as const, id, name: "write", input },
}) })
const editCall = (input: typeof EditTool.Input.Type, id = "call-edit") => ({
sessionID,
...toolIdentity,
call: { type: "tool-call" as const, id, name: "edit", input },
})
const it = testEffect(Layer.empty) const it = testEffect(Layer.empty)
describe("WriteTool", () => { describe("WriteTool", () => {
@@ -129,17 +166,7 @@ describe("WriteTool", () => {
"created", "created",
) )
expect(assertions).toMatchObject([{ sessionID, action: "edit", resources: ["src/new.txt"], save: ["*"] }]) expect(assertions).toMatchObject([{ sessionID, action: "edit", resources: ["src/new.txt"], save: ["*"] }])
expect(assertions[0]?.metadata).toMatchObject({ expect(assertions[0]?.metadata).toBeUndefined()
files: [
{
file: "src/new.txt",
status: "added",
additions: 1,
deletions: 0,
patch: expect.stringContaining("+created"),
},
],
})
expect(writes).toEqual([path.join(yield* Effect.promise(() => fs.realpath(tmp.path)), "src", "new.txt")]) expect(writes).toEqual([path.join(yield* Effect.promise(() => fs.realpath(tmp.path)), "src", "new.txt")])
}), }),
) )
@@ -187,17 +214,7 @@ describe("WriteTool", () => {
if (settled.status !== "completed") return if (settled.status !== "completed") return
expect(settled.content).toEqual([{ type: "text", text: "Wrote file successfully: existing.txt" }]) expect(settled.content).toEqual([{ type: "text", text: "Wrote file successfully: existing.txt" }])
expect(settled.output).toMatchObject({ resource: "existing.txt", existed: true }) expect(settled.output).toMatchObject({ resource: "existing.txt", existed: true })
expect(assertions[0]?.metadata).toMatchObject({ expect(assertions[0]?.metadata).toBeUndefined()
files: [
{
file: "existing.txt",
status: "modified",
additions: 1,
deletions: 1,
patch: expect.stringMatching(/-before[\s\S]*\+after/),
},
],
})
expect(yield* Effect.promise(() => fs.readFile(path.join(tmp.path, "existing.txt"), "utf8"))).toBe( expect(yield* Effect.promise(() => fs.readFile(path.join(tmp.path, "existing.txt"), "utf8"))).toBe(
"after", "after",
) )
@@ -412,4 +429,93 @@ describe("WriteTool", () => {
), ),
), ),
) )
it.live("authorizes an edit while a write holds the same-path execution lock", () =>
Effect.acquireUseRelease(
Effect.promise(() => tmpdir()),
(tmp) => {
reset()
const target = path.join(tmp.path, "shared.txt")
return Effect.gen(function* () {
yield* Effect.promise(() => fs.writeFile(target, "initial"))
const formatting = yield* Deferred.make<void>()
const releaseFormatting = yield* Deferred.make<void>()
const editApproved = yield* Deferred.make<void>()
let formats = 0
formatFile = () =>
++formats === 1
? Deferred.succeed(formatting, undefined).pipe(
Effect.andThen(Deferred.await(releaseFormatting)),
Effect.as(false),
)
: Effect.succeed(false)
afterPermission = (input) =>
input.source?.id === "call-serialized-edit" && input.action === "edit"
? Deferred.succeed(editApproved, undefined).pipe(Effect.asVoid)
: Effect.void
const write = yield* withTool(
tmp.path,
(registry) =>
executeTool(registry, call({ path: "shared.txt", content: "before" }, "call-serialized-write")),
{ edit: true },
).pipe(Effect.forkChild)
yield* Deferred.await(formatting)
const edit = yield* withTool(
tmp.path,
(registry) =>
executeTool(
registry,
editCall({ path: "shared.txt", oldString: "before", newString: "after" }, "call-serialized-edit"),
),
{ edit: true },
).pipe(Effect.forkChild)
yield* Deferred.await(editApproved)
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("before")
yield* Deferred.succeed(releaseFormatting, undefined)
expect((yield* Fiber.join(write)).status).toBe("completed")
expect((yield* Fiber.join(edit)).status).toBe("completed")
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("after")
})
},
(tmp) => Effect.promise(() => tmp[Symbol.asyncDispose]()),
),
)
it.live("does not hold the execution lock while waiting for permission", () =>
Effect.acquireUseRelease(
Effect.promise(() => tmpdir()),
(tmp) => {
reset()
const target = path.join(tmp.path, "shared.txt")
return Effect.gen(function* () {
yield* Effect.promise(() => fs.writeFile(target, "initial"))
const firstAsked = yield* Deferred.make<void>()
const releaseFirst = yield* Deferred.make<void>()
afterPermission = (input) =>
input.source?.id === "call-waiting-write" && input.action === "edit"
? Deferred.succeed(firstAsked, undefined).pipe(Effect.andThen(Deferred.await(releaseFirst)))
: Effect.void
const first = yield* withTool(tmp.path, (registry) =>
executeTool(registry, call({ path: "shared.txt", content: "first" }, "call-waiting-write")),
).pipe(Effect.forkChild)
yield* Deferred.await(firstAsked)
expect(reads).toBe(0)
const second = yield* withTool(tmp.path, (registry) =>
executeTool(registry, call({ path: "shared.txt", content: "second" }, "call-approved-write")),
)
expect(second.status).toBe("completed")
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("second")
yield* Deferred.succeed(releaseFirst, undefined)
expect((yield* Fiber.join(first)).status).toBe("completed")
expect(yield* Effect.promise(() => fs.readFile(target, "utf8"))).toBe("first")
})
},
(tmp) => Effect.promise(() => tmp[Symbol.asyncDispose]()),
),
)
}) })
+1 -9
View File
@@ -1316,15 +1316,7 @@ export function write(
}).pipe(Effect.flatMap((content) => fs.writeFileString(join(directory, file.path), content))), }).pipe(Effect.flatMap((content) => fs.writeFileString(join(directory, file.path), content))),
{ concurrency: 8, discard: true }, { concurrency: 8, discard: true },
) )
// Format the manifest with the same prettier settings as the repo-wide yield* fs.writeFileString(manifest, JSON.stringify(output.files.map((file) => file.path).sort(), null, 2) + "\n")
// format pass, so `check:generated` stays clean after the generate bot
// reformats the tree.
const manifestJson = JSON.stringify(output.files.map((file) => file.path).sort())
const manifestContent = yield* Effect.tryPromise({
try: () => format(manifestJson, { filepath: manifest, parser: "json", printWidth: 120 }),
catch: (error) => new GenerationError({ reason: `Failed to format ${manifest}: ${String(error)}` }),
})
yield* fs.writeFileString(manifest, manifestContent)
}) })
} }
+1 -1
View File
@@ -16,7 +16,7 @@ describe("HttpApiCodegen.write", () => {
expect(writes).toEqual([ expect(writes).toEqual([
{ path: "/generated/session.ts", content: "export const session = {}\n" }, { path: "/generated/session.ts", content: "export const session = {}\n" },
{ path: "/generated/.httpapi-codegen.json", content: '["session.ts"]\n' }, { path: "/generated/.httpapi-codegen.json", content: '[\n "session.ts"\n]\n' },
]) ])
}).pipe( }).pipe(
Effect.provideService( Effect.provideService(
+10 -34
View File
@@ -1,43 +1,19 @@
import type { ConnectionInfo } from "@opencode-ai/client" import type {
ConnectionInfo,
IntegrationCommandMethod,
IntegrationEnvMethod,
IntegrationKeyMethod,
IntegrationMethod,
IntegrationOAuthMethod,
} from "@opencode-ai/client"
import type { IntegrationApi } from "@opencode-ai/client/effect/api" import type { IntegrationApi } from "@opencode-ai/client/effect/api"
import { Credential } from "@opencode-ai/schema/credential" import { Credential } from "@opencode-ai/schema/credential"
import { Form } from "@opencode-ai/schema/form"
import type { Effect, Scope } from "effect" import type { Effect, Scope } from "effect"
import type { Transform } from "./registration.js" import type { Transform } from "./registration.js"
type IntegrationInputs = Record<string, string>
type IntegrationRef = { id: string; name: string } type IntegrationRef = { id: string; name: string }
export interface IntegrationOAuthMethod {
readonly id: string
readonly type: "oauth"
readonly label: string
readonly form?: Form.Fields
}
export interface IntegrationCommandMethod {
readonly id: string
readonly type: "command"
readonly label: string
readonly command: ReadonlyArray<string>
}
export interface IntegrationKeyMethod {
readonly type: "key"
readonly label?: string
readonly form?: Form.Fields
}
export interface IntegrationEnvMethod {
readonly type: "env"
readonly names: ReadonlyArray<string>
}
export type IntegrationMethod =
| IntegrationOAuthMethod
| IntegrationCommandMethod
| IntegrationKeyMethod
| IntegrationEnvMethod
export type IntegrationOAuthAuthorization = { export type IntegrationOAuthAuthorization = {
readonly url: string readonly url: string
readonly instructions: string readonly instructions: string
@@ -55,7 +31,7 @@ export type IntegrationOAuthAuthorization = {
export type IntegrationOAuthMethodRegistration = { export type IntegrationOAuthMethodRegistration = {
readonly integrationID: string readonly integrationID: string
readonly method: IntegrationOAuthMethod readonly method: IntegrationOAuthMethod
readonly authorize: (answer: Form.Answer) => Effect.Effect<IntegrationOAuthAuthorization, unknown, Scope.Scope> readonly authorize: (inputs: IntegrationInputs) => Effect.Effect<IntegrationOAuthAuthorization, unknown, Scope.Scope>
readonly refresh?: (credential: Credential.OAuth) => Effect.Effect<Credential.OAuth, unknown> readonly refresh?: (credential: Credential.OAuth) => Effect.Effect<Credential.OAuth, unknown>
readonly label?: (credential: Credential.OAuth) => string | undefined readonly label?: (credential: Credential.OAuth) => string | undefined
} }
+11 -38
View File
@@ -1,42 +1,18 @@
import type { ConnectionInfo } from "@opencode-ai/client" import type {
ConnectionInfo,
IntegrationCommandMethod,
IntegrationEnvMethod,
IntegrationKeyMethod,
IntegrationMethod,
IntegrationOAuthMethod,
} from "@opencode-ai/client"
import type { IntegrationApi } from "@opencode-ai/client/promise/api" import type { IntegrationApi } from "@opencode-ai/client/promise/api"
import { Credential } from "@opencode-ai/schema/credential" import { Credential } from "@opencode-ai/schema/credential"
import { Form } from "@opencode-ai/schema/form"
import type { Transform } from "./registration.js" import type { Transform } from "./registration.js"
type IntegrationInputs = Record<string, string>
type IntegrationRef = { id: string; name: string } type IntegrationRef = { id: string; name: string }
export interface IntegrationOAuthMethod {
readonly id: string
readonly type: "oauth"
readonly label: string
readonly form?: Form.Fields
}
export interface IntegrationCommandMethod {
readonly id: string
readonly type: "command"
readonly label: string
readonly command: ReadonlyArray<string>
}
export interface IntegrationKeyMethod {
readonly type: "key"
readonly label?: string
readonly form?: Form.Fields
}
export interface IntegrationEnvMethod {
readonly type: "env"
readonly names: ReadonlyArray<string>
}
export type IntegrationMethod =
| IntegrationOAuthMethod
| IntegrationCommandMethod
| IntegrationKeyMethod
| IntegrationEnvMethod
export type IntegrationOAuthAuthorization = { export type IntegrationOAuthAuthorization = {
readonly url: string readonly url: string
readonly instructions: string readonly instructions: string
@@ -55,7 +31,7 @@ export type IntegrationOAuthAuthorization = {
export type IntegrationOAuthMethodRegistration = { export type IntegrationOAuthMethodRegistration = {
readonly integrationID: string readonly integrationID: string
readonly method: IntegrationOAuthMethod readonly method: IntegrationOAuthMethod
readonly authorize: (answer: Form.Answer) => Promise<IntegrationOAuthAuthorization> readonly authorize: (inputs: IntegrationInputs) => Promise<IntegrationOAuthAuthorization>
readonly refresh?: (credential: Credential.OAuth) => Promise<Credential.OAuth> readonly refresh?: (credential: Credential.OAuth) => Promise<Credential.OAuth>
readonly label?: (credential: Credential.OAuth) => string | undefined readonly label?: (credential: Credential.OAuth) => string | undefined
} }
@@ -63,10 +39,7 @@ export type IntegrationOAuthMethodRegistration = {
export type IntegrationMethodRegistration = export type IntegrationMethodRegistration =
| IntegrationOAuthMethodRegistration | IntegrationOAuthMethodRegistration
| { readonly integrationID: string; readonly method: IntegrationCommandMethod } | { readonly integrationID: string; readonly method: IntegrationCommandMethod }
| { | { readonly integrationID: string; readonly method: IntegrationKeyMethod }
readonly integrationID: string
readonly method: IntegrationKeyMethod
}
| { readonly integrationID: string; readonly method: IntegrationEnvMethod } | { readonly integrationID: string; readonly method: IntegrationEnvMethod }
export interface IntegrationDraft { export interface IntegrationDraft {
+3 -3
View File
@@ -1,11 +1,12 @@
import { Integration } from "@opencode-ai/schema/integration" import { Integration } from "@opencode-ai/schema/integration"
import { Location } from "@opencode-ai/schema/location" import { Location } from "@opencode-ai/schema/location"
import { Form } from "@opencode-ai/schema/form"
import { Schema } from "effect" import { Schema } from "effect"
import { HttpApiEndpoint, HttpApiGroup, HttpApiSchema, OpenApi } from "effect/unstable/httpapi" import { HttpApiEndpoint, HttpApiGroup, HttpApiSchema, OpenApi } from "effect/unstable/httpapi"
import { InvalidRequestError } from "../errors.js" import { InvalidRequestError } from "../errors.js"
import { LocationQuery, locationQueryOpenApi } from "./location.js" import { LocationQuery, locationQueryOpenApi } from "./location.js"
const Inputs = Schema.Record(Schema.String, Schema.String)
export const IntegrationGroup = HttpApiGroup.make("server.integration") export const IntegrationGroup = HttpApiGroup.make("server.integration")
.add( .add(
HttpApiEndpoint.get("integration.list", "/api/integration", { HttpApiEndpoint.get("integration.list", "/api/integration", {
@@ -58,7 +59,6 @@ export const IntegrationGroup = HttpApiGroup.make("server.integration")
query: LocationQuery, query: LocationQuery,
payload: Schema.Struct({ payload: Schema.Struct({
key: Schema.String, key: Schema.String,
answer: Schema.optional(Form.Answer),
label: Schema.optional(Schema.String), label: Schema.optional(Schema.String),
}), }),
success: HttpApiSchema.NoContent, success: HttpApiSchema.NoContent,
@@ -79,7 +79,7 @@ export const IntegrationGroup = HttpApiGroup.make("server.integration")
query: LocationQuery, query: LocationQuery,
payload: Schema.Struct({ payload: Schema.Struct({
methodID: Integration.MethodID, methodID: Integration.MethodID,
answer: Schema.optional(Form.Answer), inputs: Inputs,
label: Schema.optional(Schema.String), label: Schema.optional(Schema.String),
}), }),
success: Location.response(Integration.Attempt), success: Location.response(Integration.Attempt),
-2
View File
@@ -5,7 +5,6 @@ import { optional } from "./schema.js"
import { IntegrationMethodID } from "./integration-id.js" import { IntegrationMethodID } from "./integration-id.js"
import { ascending } from "./identifier.js" import { ascending } from "./identifier.js"
import { NonNegativeInt, statics } from "./schema.js" import { NonNegativeInt, statics } from "./schema.js"
import { Form } from "./form.js"
export const ID = Schema.String.pipe( export const ID = Schema.String.pipe(
Schema.brand("Credential.ID"), Schema.brand("Credential.ID"),
@@ -28,7 +27,6 @@ export const Key = Schema.Struct({
type: Schema.Literal("key"), type: Schema.Literal("key"),
key: Schema.String, key: Schema.String,
metadata: optional(Schema.Record(Schema.String, Schema.Unknown)), metadata: optional(Schema.Record(Schema.String, Schema.Unknown)),
configuration: optional(Form.Answer),
}).annotate({ identifier: "Credential.Key" }) }).annotate({ identifier: "Credential.Key" })
export const Value = Schema.Union([OAuth, Key]) export const Value = Schema.Union([OAuth, Key])
+38 -3
View File
@@ -7,7 +7,6 @@ import { Connection } from "./connection.js"
import { ascending } from "./identifier.js" import { ascending } from "./identifier.js"
import { statics } from "./schema.js" import { statics } from "./schema.js"
import { IntegrationID, IntegrationMethodID } from "./integration-id.js" import { IntegrationID, IntegrationMethodID } from "./integration-id.js"
import { Form } from "./form.js"
export const ID = IntegrationID export const ID = IntegrationID
export type ID = typeof ID.Type export type ID = typeof ID.Type
@@ -15,12 +14,46 @@ export type ID = typeof ID.Type
export const MethodID = IntegrationMethodID export const MethodID = IntegrationMethodID
export type MethodID = typeof MethodID.Type export type MethodID = typeof MethodID.Type
export interface When extends Schema.Schema.Type<typeof When> {}
export const When = Schema.Struct({
key: Schema.String,
op: Schema.Literals(["eq", "neq"]),
value: Schema.String,
}).annotate({ identifier: "Integration.When" })
export interface TextPrompt extends Schema.Schema.Type<typeof TextPrompt> {}
export const TextPrompt = Schema.Struct({
type: Schema.Literal("text"),
key: Schema.String,
message: Schema.String,
placeholder: optional(Schema.String),
when: optional(When),
}).annotate({ identifier: "Integration.TextPrompt" })
export interface SelectPrompt extends Schema.Schema.Type<typeof SelectPrompt> {}
export const SelectPrompt = Schema.Struct({
type: Schema.Literal("select"),
key: Schema.String,
message: Schema.String,
options: Schema.Array(
Schema.Struct({
label: Schema.String,
value: Schema.String,
hint: optional(Schema.String),
}),
),
when: optional(When),
}).annotate({ identifier: "Integration.SelectPrompt" })
export const Prompt = Schema.Union([TextPrompt, SelectPrompt]).pipe(Schema.toTaggedUnion("type"))
export type Prompt = typeof Prompt.Type
export interface OAuthMethod extends Schema.Schema.Type<typeof OAuthMethod> {} export interface OAuthMethod extends Schema.Schema.Type<typeof OAuthMethod> {}
export const OAuthMethod = Schema.Struct({ export const OAuthMethod = Schema.Struct({
id: MethodID, id: MethodID,
type: Schema.Literal("oauth"), type: Schema.Literal("oauth"),
label: Schema.String, label: Schema.String,
form: optional(Form.Fields), prompts: optional(Schema.Array(Prompt)),
}).annotate({ identifier: "Integration.OAuthMethod" }) }).annotate({ identifier: "Integration.OAuthMethod" })
export interface CommandMethod extends Schema.Schema.Type<typeof CommandMethod> {} export interface CommandMethod extends Schema.Schema.Type<typeof CommandMethod> {}
@@ -35,7 +68,6 @@ export interface KeyMethod extends Schema.Schema.Type<typeof KeyMethod> {}
export const KeyMethod = Schema.Struct({ export const KeyMethod = Schema.Struct({
type: Schema.Literal("key"), type: Schema.Literal("key"),
label: optional(Schema.String), label: optional(Schema.String),
form: optional(Form.Fields),
}).annotate({ identifier: "Integration.KeyMethod" }) }).annotate({ identifier: "Integration.KeyMethod" })
export interface EnvMethod extends Schema.Schema.Type<typeof EnvMethod> {} export interface EnvMethod extends Schema.Schema.Type<typeof EnvMethod> {}
@@ -49,6 +81,9 @@ export const Method = Schema.Union([OAuthMethod, CommandMethod, KeyMethod, EnvMe
.annotate({ identifier: "Integration.Method" }) .annotate({ identifier: "Integration.Method" })
export type Method = typeof Method.Type export type Method = typeof Method.Type
export const Inputs = Schema.Record(Schema.String, Schema.String).annotate({ identifier: "Integration.Inputs" })
export type Inputs = typeof Inputs.Type
const Updated = ephemeral({ const Updated = ephemeral({
type: "integration.updated", type: "integration.updated",
schema: {}, schema: {},
+1 -2
View File
@@ -58,7 +58,6 @@ export const IntegrationHandler = HttpApiBuilder.group(Api, "server.integration"
service.connection.key({ service.connection.key({
integrationID: ctx.params.integrationID, integrationID: ctx.params.integrationID,
key: ctx.payload.key, key: ctx.payload.key,
answer: ctx.payload.answer,
label: ctx.payload.label, label: ctx.payload.label,
}), }),
) )
@@ -74,7 +73,7 @@ export const IntegrationHandler = HttpApiBuilder.group(Api, "server.integration"
service.oauth.connect({ service.oauth.connect({
integrationID: ctx.params.integrationID, integrationID: ctx.params.integrationID,
methodID: ctx.payload.methodID, methodID: ctx.payload.methodID,
answer: ctx.payload.answer, inputs: ctx.payload.inputs,
label: ctx.payload.label, label: ctx.payload.label,
}), }),
), ),
+41 -252
View File
@@ -5,10 +5,6 @@ import type {
IntegrationInfo, IntegrationInfo,
IntegrationOauthConnectOutput, IntegrationOauthConnectOutput,
IntegrationOAuthMethod, IntegrationOAuthMethod,
FormAnswer,
FormField,
FormFields,
FormValue,
} from "@opencode-ai/client" } from "@opencode-ai/client"
import open from "open" import open from "open"
import { createMemo, createSignal, onCleanup, onMount, Show } from "solid-js" import { createMemo, createSignal, onCleanup, onMount, Show } from "solid-js"
@@ -22,7 +18,6 @@ import { DialogPrompt } from "../ui/dialog-prompt"
import { DialogSelect } from "../ui/dialog-select" import { DialogSelect } from "../ui/dialog-select"
import { Link } from "../ui/link" import { Link } from "../ui/link"
import { useToast } from "../ui/toast" import { useToast } from "../ui/toast"
import { formLabel, formToggleMultiselect, formValidateValue, type FormAnswerField } from "../util/form"
const INTEGRATION_PRIORITY: Record<string, number> = { const INTEGRATION_PRIORITY: Record<string, number> = {
opencode: 0, opencode: 0,
@@ -37,10 +32,6 @@ type ConnectMethod = Exclude<IntegrationInfo["methods"][number], { type: "env" }
type IntegrationAttempt = IntegrationOauthConnectOutput["data"] type IntegrationAttempt = IntegrationOauthConnectOutput["data"]
type CommandAttempt = IntegrationCommandConnectOutput["data"] type CommandAttempt = IntegrationCommandConnectOutput["data"]
type OnIntegrationConnected = (providerID?: string) => void type OnIntegrationConnected = (providerID?: string) => void
const CANCELLED = Symbol("cancelled")
const CUSTOM = Symbol("custom")
const OPEN = Symbol("open")
const SUBMIT = Symbol("submit")
export function integrationOptions(list: IntegrationInfo[]) { export function integrationOptions(list: IntegrationInfo[]) {
return list.toSorted( return list.toSorted(
@@ -190,7 +181,7 @@ function openMethod(
onConnected?: OnIntegrationConnected, onConnected?: OnIntegrationConnected,
) { ) {
if (method.type === "key") { if (method.type === "key") {
void beginKey(integration, method, dialog, onConnected) dialog.replace(() => <KeyMethod integration={integration} method={method} onConnected={onConnected} />)
return return
} }
if (method.type === "command") { if (method.type === "command") {
@@ -200,21 +191,6 @@ function openMethod(
void beginOAuth(integration, method, dialog, onConnected) void beginOAuth(integration, method, dialog, onConnected)
} }
async function beginKey(
integration: IntegrationInfo,
method: Extract<ConnectMethod, { type: "key" }>,
dialog: ReturnType<typeof useDialog>,
onConnected?: OnIntegrationConnected,
) {
const answer = method.form
? await formAnswer(dialog, method.label ?? `Connect ${integration.name}`, method.form)
: undefined
if (answer === null) return
dialog.replace(() => (
<KeyMethod integration={integration} method={method} answer={answer} onConnected={onConnected} />
))
}
function CommandStarting(props: { function CommandStarting(props: {
integration: IntegrationInfo integration: IntegrationInfo
method: Extract<ConnectMethod, { type: "command" }> method: Extract<ConnectMethod, { type: "command" }>
@@ -360,7 +336,6 @@ function CommandView(props: { title: string; output: string; message: string })
function KeyMethod(props: { function KeyMethod(props: {
integration: IntegrationInfo integration: IntegrationInfo
method: Extract<ConnectMethod, { type: "key" }> method: Extract<ConnectMethod, { type: "key" }>
answer?: FormAnswer
onConnected?: OnIntegrationConnected onConnected?: OnIntegrationConnected
}) { }) {
const data = useData() const data = useData()
@@ -381,7 +356,6 @@ function KeyMethod(props: {
integrationID: props.integration.id, integrationID: props.integration.id,
location: location(data), location: location(data),
key, key,
...(props.answer ? { answer: props.answer } : {}),
}) })
.then(() => connected(props.integration, data, dialog, toast, props.onConnected)) .then(() => connected(props.integration, data, dialog, toast, props.onConnected))
.catch((cause) => setError(message(cause))) .catch((cause) => setError(message(cause)))
@@ -399,17 +373,17 @@ async function beginOAuth(
dialog: ReturnType<typeof useDialog>, dialog: ReturnType<typeof useDialog>,
onConnected?: OnIntegrationConnected, onConnected?: OnIntegrationConnected,
) { ) {
const answer = method.form ? await formAnswer(dialog, method.label, method.form) : undefined const inputs = method.prompts?.length ? await promptInputs(dialog, method.prompts) : {}
if (answer === null) return if (inputs === null) return
dialog.replace(() => ( dialog.replace(() => (
<OAuthStarting integration={integration} method={method} answer={answer} onConnected={onConnected} /> <OAuthStarting integration={integration} method={method} inputs={inputs} onConnected={onConnected} />
)) ))
} }
function OAuthStarting(props: { function OAuthStarting(props: {
integration: IntegrationInfo integration: IntegrationInfo
method: IntegrationOAuthMethod method: IntegrationOAuthMethod
answer?: FormAnswer inputs: Record<string, string>
onConnected?: OnIntegrationConnected onConnected?: OnIntegrationConnected
}) { }) {
const data = useData() const data = useData()
@@ -423,7 +397,7 @@ function OAuthStarting(props: {
integrationID: props.integration.id, integrationID: props.integration.id,
location: location(data), location: location(data),
methodID: props.method.id, methodID: props.method.id,
...(props.answer ? { answer: props.answer } : {}), inputs: props.inputs,
}) })
.then((result) => { .then((result) => {
if (result.data.mode === "code") { if (result.data.mode === "code") {
@@ -647,234 +621,49 @@ function OAuthView(props: {
) )
} }
async function formAnswer(dialog: ReturnType<typeof useDialog>, title: string, fields: FormFields) { async function promptInputs(
const answer: FormAnswer = {}
for (const field of fields) {
if (!active(field, answer)) continue
const value = await fieldAnswer(dialog, title, field)
if (value === CANCELLED) return null
if (value !== undefined) answer[field.key] = value
}
return answer
}
function active(field: FormField, answer: FormAnswer) {
if (field.type === "external" || !field.when) return true
return field.when.every((when) => {
const value = answer[when.key]
if (value === undefined) return false
const hit = Array.isArray(value) ? value.includes(String(when.value)) : value === when.value
return when.op === "eq" ? hit : !hit
})
}
function fieldAnswer(
dialog: ReturnType<typeof useDialog>, dialog: ReturnType<typeof useDialog>,
title: string, prompts: NonNullable<IntegrationOAuthMethod["prompts"]>,
field: FormField, ) {
): Promise<FormValue | undefined | typeof CANCELLED> { const inputs: Record<string, string> = {}
if (field.type === "external") return externalAnswer(dialog, title, field) for (const prompt of prompts) {
if (field.type === "multiselect") return multiselectAnswer(dialog, title, field) if (prompt.when) {
if (field.type === "boolean" || (field.type === "string" && field.options)) { const value = inputs[prompt.when.key]
return selectAnswer(dialog, title, field) if (value === undefined) continue
} const matches = prompt.when.op === "eq" ? value === prompt.when.value : value !== prompt.when.value
return textAnswer(dialog, title, field) if (!matches) continue
} }
if (prompt.type === "select") {
async function selectAnswer( const value = await new Promise<string | null>((resolve) => {
dialog: ReturnType<typeof useDialog>, dialog.replace(
title: string, () => (
field: Extract<FormAnswerField, { type: "boolean" | "string" }>, <DialogSelect
): Promise<FormValue | undefined | typeof CANCELLED> { title={prompt.message}
const options = options={prompt.options.map((option) => ({
field.type === "boolean" title: option.label,
? field.default === false
? [
{ title: "No", value: false as FormValue },
{ title: "Yes", value: true as FormValue },
]
: [
{ title: "Yes", value: true as FormValue },
{ title: "No", value: false as FormValue },
]
: (field.options ?? []).map((option) => ({
title: option.label,
value: option.value as FormValue,
description: option.description,
}))
const choice = await new Promise<FormValue | typeof CUSTOM | undefined | typeof CANCELLED>((resolve) => {
dialog.replace(
() => (
<DialogSelect<FormValue | typeof CUSTOM | undefined>
title={formLabel(field) || title}
options={[
...options,
...(field.type === "string" && field.custom
? [{ title: "Type your own answer", value: CUSTOM as typeof CUSTOM }]
: []),
...(!field.required ? [{ title: "Skip", value: undefined }] : []),
]}
current={field.type === "string" ? field.default : undefined}
onSelect={(option) => resolve(option.value)}
/>
),
() => resolve(CANCELLED),
)
})
if (choice === CUSTOM) {
if (field.type !== "string") return CANCELLED
return textAnswer(dialog, title, field, "")
}
return choice
}
function textAnswer(
dialog: ReturnType<typeof useDialog>,
title: string,
field: Extract<FormAnswerField, { type: "string" | "number" | "integer" }>,
initial = field.default === undefined ? undefined : String(field.default),
): Promise<FormValue | undefined | typeof CANCELLED> {
return new Promise<FormValue | undefined | typeof CANCELLED>((resolve) => {
dialog.replace(
() => {
const theme = useTheme("elevated")
const [error, setError] = createSignal<string>()
return (
<DialogPrompt
title={formLabel(field) || title}
placeholder={field.type === "string" ? field.placeholder : undefined}
value={initial}
onConfirm={(input) => {
const text = input.trim()
const value = text === "" && !field.required ? undefined : field.type === "string" ? text : Number(text)
const invalid = formValidateValue(field, value)
if (invalid) {
setError(invalid)
return
}
resolve(value)
}}
description={() => (
<box gap={1}>
<Show when={field.description}>
{(description) => <text fg={theme.text.subdued}>{description()}</text>}
</Show>
<Show when={error()}>{(value) => <text fg={theme.text.feedback.error.default}>{value()}</text>}</Show>
</box>
)}
/>
)
},
() => resolve(CANCELLED),
)
})
}
async function multiselectAnswer(
dialog: ReturnType<typeof useDialog>,
title: string,
field: Extract<FormAnswerField, { type: "multiselect" }>,
): Promise<FormValue | typeof CANCELLED> {
const selected = field.default ? [...field.default] : []
while (true) {
const invalid = formValidateValue(field, selected)
const choice = await new Promise<string | typeof CUSTOM | typeof SUBMIT | typeof CANCELLED>((resolve) => {
dialog.replace(
() => (
<DialogSelect<string | typeof CUSTOM | typeof SUBMIT>
title={formLabel(field) || title}
options={[
...field.options.map((option) => ({
title: `[${selected.includes(option.value) ? "x" : " "}] ${option.label}`,
value: option.value, value: option.value,
description: option.description, description: option.hint,
disabled: }))}
!selected.includes(option.value) && field.maxItems !== undefined && selected.length >= field.maxItems, onSelect={(option) => resolve(option.value)}
})), />
...(field.custom ? [{ title: "Type your own answer", value: CUSTOM as typeof CUSTOM }] : []), ),
{ () => resolve(null),
title: "Continue", )
value: SUBMIT as typeof SUBMIT, })
description: invalid, if (value === null) return null
disabled: invalid !== undefined, inputs[prompt.key] = value
},
]}
onSelect={(option) => resolve(option.value)}
/>
),
() => resolve(CANCELLED),
)
})
if (choice === CANCELLED) return CANCELLED
if (choice === SUBMIT) return selected
if (choice === CUSTOM) {
const value = await customAnswer(dialog, title, field)
if (value === CANCELLED) return CANCELLED
if (value && !selected.includes(value)) selected.push(value)
continue continue
} }
selected.splice(0, selected.length, ...formToggleMultiselect(selected, choice)) const value = await new Promise<string | null>((resolve) => {
}
}
function customAnswer(
dialog: ReturnType<typeof useDialog>,
title: string,
field: Extract<FormAnswerField, { type: "multiselect" }>,
): Promise<string | typeof CANCELLED> {
return new Promise<string | typeof CANCELLED>((resolve) => {
dialog.replace(
() => (
<DialogPrompt
title={formLabel(field) || title}
placeholder="Type your own answer"
onConfirm={(value) => {
if (value) resolve(value)
}}
/>
),
() => resolve(CANCELLED),
)
})
}
async function externalAnswer(
dialog: ReturnType<typeof useDialog>,
title: string,
field: Extract<FormField, { type: "external" }>,
): Promise<true | typeof CANCELLED> {
let opened = false
while (true) {
const choice = await new Promise<true | typeof OPEN | typeof CANCELLED>((resolve) => {
dialog.replace( dialog.replace(
() => ( () => <DialogPrompt title={prompt.message} placeholder={prompt.placeholder} onConfirm={resolve} />,
<DialogSelect<true | typeof OPEN> () => resolve(null),
title={formLabel(field) || title}
options={[
{ title: opened ? "Open link again" : "Open link", value: OPEN as typeof OPEN, description: field.url },
{ title: "I finished", value: true as const, description: field.description, disabled: !opened },
]}
onSelect={(option) => resolve(option.value)}
/>
),
() => resolve(CANCELLED),
) )
}) })
if (choice === CANCELLED) return CANCELLED if (value === null) return null
if (choice === true) return true inputs[prompt.key] = value
const result = await new Promise<boolean | typeof CANCELLED>((resolve) => {
dialog.replace(
() => <OAuthView title={formLabel(field) || title} message="Opening link..." />,
() => resolve(CANCELLED),
)
void open(field.url).then(
() => resolve(true),
() => resolve(false),
)
})
if (result === CANCELLED) return CANCELLED
opened ||= result
} }
return inputs
} }
async function connected( async function connected(
-1
View File
@@ -38,7 +38,6 @@ export function permissionPresentation(
title: `Edit ${formatPath(file)}`, title: `Edit ${formatPath(file)}`,
lines: [], lines: [],
diff, diff,
patch: diff ? undefined : text(input.patchText) || undefined,
file, file,
} }
} }
@@ -152,7 +152,7 @@ describe("run permission shared", () => {
}) })
}) })
test("uses source patch text when an edit has no generated diff", () => { test("uses the resource display when an edit has no generated diff", () => {
const patch = '*** Begin Patch\n*** Update File: src/index.ts\n@@\n-old\n+const arrow = "→"\n*** End Patch' const patch = '*** Begin Patch\n*** Update File: src/index.ts\n@@\n-old\n+const arrow = "→"\n*** End Patch'
const request = req({ const request = req({
action: "edit", action: "edit",
@@ -171,13 +171,11 @@ describe("run permission shared", () => {
expect(permissionInfo(request)).toMatchObject({ expect(permissionInfo(request)).toMatchObject({
title: "Edit src/index.ts", title: "Edit src/index.ts",
diff: undefined, diff: undefined,
patch,
}) })
expect(permissionInfo(request, undefined, true)).toMatchObject({ expect(permissionInfo(request, undefined, true)).toMatchObject({
title: "Edit src/index.ts", title: "Edit src/index.ts",
lines: [patch], lines: [],
diff: undefined, diff: undefined,
patch: undefined,
}) })
}) })