Compare commits

..

1 Commits

Author SHA1 Message Date
James Long 0984208948 test(core): simplify file mutation layer wiring 2026-06-20 21:55:08 -04:00
7 changed files with 43 additions and 42 deletions
+3
View File
@@ -3,6 +3,7 @@ export * as FileMutation from "./file-mutation"
import { Context, Effect, Layer, Schema } from "effect" import { Context, Effect, Layer, Schema } from "effect"
import { dirname } from "path" import { dirname } from "path"
import { KeyedMutex } from "./effect/keyed-mutex" import { KeyedMutex } from "./effect/keyed-mutex"
import { LayerNode } from "./effect/layer-node"
import { FSUtil } from "./fs-util" import { FSUtil } from "./fs-util"
export interface Target { export interface Target {
@@ -171,6 +172,8 @@ export const layer = Layer.effect(
}), }),
) )
export const node = LayerNode.make(layer, [FSUtil.node])
function splitBom(text: string) { function splitBom(text: string) {
const stripped = text.replace(/^\uFEFF+/, "") const stripped = text.replace(/^\uFEFF+/, "")
return { bom: stripped.length !== text.length, text: stripped } return { bom: stripped.length !== text.length, text: stripped }
+3
View File
@@ -2,6 +2,7 @@ export * as LocationMutation from "./location-mutation"
import path from "path" import path from "path"
import { Context, Effect, Layer, Schema } from "effect" import { Context, Effect, Layer, Schema } from "effect"
import { LayerNode } from "./effect/layer-node"
import { FSUtil } from "./fs-util" import { FSUtil } from "./fs-util"
import { Location } from "./location" import { Location } from "./location"
@@ -153,3 +154,5 @@ export const layer = Layer.effect(
) )
export const locationLayer = layer export const locationLayer = layer
export const node = (location: LayerNode.Node<Location.Service>) => LayerNode.make(layer, [FSUtil.node, location])
-10
View File
@@ -29,7 +29,6 @@ import { logFailure } from "./session/logging"
import { MessageDecodeError } from "./session/error" import { MessageDecodeError } from "./session/error"
import { SessionEvent } from "./session/event" import { SessionEvent } from "./session/event"
import { SessionInput } from "./session/input" import { SessionInput } from "./session/input"
import { LayerNode } from "./effect/layer-node"
// get project -> project.locations // get project -> project.locations
// //
@@ -426,15 +425,6 @@ export const layer = Layer.effect(
}), }),
) )
export const node = LayerNode.make(layer, [
SessionExecution.node,
SessionStore.node,
SessionProjector.node,
EventV2.node,
Database.node,
ProjectV2.node,
])
export const defaultLayer = layer.pipe( export const defaultLayer = layer.pipe(
Layer.provide(SessionExecution.noopLayer), Layer.provide(SessionExecution.noopLayer),
Layer.provide(SessionStore.defaultLayer), Layer.provide(SessionStore.defaultLayer),
-3
View File
@@ -3,7 +3,6 @@ export * as SessionExecution from "./execution"
import { Context, Effect, Layer } from "effect" import { Context, Effect, Layer } from "effect"
import { SessionRunner } from "./runner/index" import { SessionRunner } from "./runner/index"
import { SessionSchema } from "./schema" import { SessionSchema } from "./schema"
import { LayerNode } from "../effect/layer-node"
export interface Interface { export interface Interface {
/** Explicitly drain one Session, making at least one provider attempt. */ /** Explicitly drain one Session, making at least one provider attempt. */
@@ -22,5 +21,3 @@ export const noopLayer = Layer.succeed(
Service, Service,
Service.of({ resume: () => Effect.void, wake: () => Effect.void, interrupt: () => Effect.void }), Service.of({ resume: () => Effect.void, wake: () => Effect.void, interrupt: () => Effect.void }),
) )
export const node = LayerNode.make(noopLayer, [])
-3
View File
@@ -9,7 +9,6 @@ import { SessionMessage } from "./message"
import { SessionSchema } from "./schema" import { SessionSchema } from "./schema"
import { SessionMessageTable, SessionTable } from "./sql" import { SessionMessageTable, SessionTable } from "./sql"
import { fromRow } from "./info" import { fromRow } from "./info"
import { LayerNode } from "../effect/layer-node"
export interface Interface { export interface Interface {
readonly get: (sessionID: SessionSchema.ID) => Effect.Effect<SessionSchema.Info | undefined> readonly get: (sessionID: SessionSchema.ID) => Effect.Effect<SessionSchema.Info | undefined>
@@ -60,6 +59,4 @@ export const layer = Layer.effect(
}), }),
) )
export const node = LayerNode.make(layer, [Database.node])
export const defaultLayer = layer.pipe(Layer.provide(Database.defaultLayer)) export const defaultLayer = layer.pipe(Layer.provide(Database.defaultLayer))
+26 -20
View File
@@ -2,6 +2,7 @@ import fs from "fs/promises"
import path from "path" import path from "path"
import { describe, expect } from "bun:test" import { describe, expect } from "bun:test"
import { Deferred, Effect, Fiber, Layer } from "effect" import { Deferred, Effect, Fiber, Layer } from "effect"
import { LayerNode } from "@opencode-ai/core/effect/layer-node"
import { FileMutation } from "@opencode-ai/core/file-mutation" import { FileMutation } from "@opencode-ai/core/file-mutation"
import { FSUtil } from "@opencode-ai/core/fs-util" import { FSUtil } from "@opencode-ai/core/fs-util"
import { Location } from "@opencode-ai/core/location" import { Location } from "@opencode-ai/core/location"
@@ -11,14 +12,16 @@ import { location } from "./fixture/location"
import { tmpdir } from "./fixture/tmpdir" import { tmpdir } from "./fixture/tmpdir"
import { it } from "./lib/effect" import { it } from "./lib/effect"
function provide(directory: string, filesystem = FSUtil.defaultLayer) { function provide(directory: string, filesystem?: LayerNode.Replacement<FSUtil.Service>) {
const activeLocation = Layer.succeed( const activeLocation = LayerNode.make(
Location.Service, Layer.succeed(Location.Service, Location.Service.of(location({ directory: AbsolutePath.make(directory) }))),
Location.Service.of(location({ directory: AbsolutePath.make(directory) })), [],
)
return Effect.provide(
LayerNode.buildLayer(LayerNode.group([LocationMutation.node(activeLocation), FileMutation.node]), {
replacements: filesystem ? [filesystem] : [],
}),
) )
const resolution = LocationMutation.layer.pipe(Layer.provide(filesystem), Layer.provide(activeLocation))
const mutation = FileMutation.layer.pipe(Layer.provide(filesystem))
return Effect.provide(Layer.mergeAll(resolution, mutation))
} }
function withTmp<A, E, R>(f: (directory: string) => Effect.Effect<A, E, R>) { function withTmp<A, E, R>(f: (directory: string) => Effect.Effect<A, E, R>) {
@@ -347,17 +350,20 @@ describe("FileMutation", () => {
}) })
function instrumentWrites(run: <E>(write: Effect.Effect<void, E>, target: string) => Effect.Effect<void, E>) { function instrumentWrites(run: <E>(write: Effect.Effect<void, E>, target: string) => Effect.Effect<void, E>) {
return Layer.effect( return LayerNode.replace(
FSUtil.Service, FSUtil.node,
Effect.gen(function* () { Layer.effect(
const filesystem = yield* FSUtil.Service FSUtil.Service,
return FSUtil.Service.of({ Effect.gen(function* () {
...filesystem, const filesystem = yield* FSUtil.Service
writeWithDirs: (target, content, mode) => run(filesystem.writeWithDirs(target, content, mode), target), return FSUtil.Service.of({
writeFile: (target, content, options) => run(filesystem.writeFile(target, content, options), target), ...filesystem,
writeFileString: (target, content, options) => writeWithDirs: (target, content, mode) => run(filesystem.writeWithDirs(target, content, mode), target),
run(filesystem.writeFileString(target, content, options), target), writeFile: (target, content, options) => run(filesystem.writeFile(target, content, options), target),
}) writeFileString: (target, content, options) =>
}), run(filesystem.writeFileString(target, content, options), target),
).pipe(Layer.provide(FSUtil.defaultLayer)) })
}),
).pipe(Layer.provide(LayerNode.buildLayer(FSUtil.node))),
)
} }
+11 -6
View File
@@ -15,10 +15,13 @@ import { SessionProjector } from "@opencode-ai/core/session/projector"
import { SessionExecution } from "@opencode-ai/core/session/execution" import { SessionExecution } from "@opencode-ai/core/session/execution"
import { SessionInput } from "@opencode-ai/core/session/input" import { SessionInput } from "@opencode-ai/core/session/input"
import { SessionInputTable, SessionMessageTable, SessionTable } from "@opencode-ai/core/session/sql" import { SessionInputTable, SessionMessageTable, SessionTable } from "@opencode-ai/core/session/sql"
import { LayerNode } from "@opencode-ai/core/effect/layer-node" import { SessionStore } from "@opencode-ai/core/session/store"
import { testEffect } from "./lib/effect" import { testEffect } from "./lib/effect"
const database = Database.layerFromPath(":memory:") const database = Database.layerFromPath(":memory:")
const events = EventV2.layer.pipe(Layer.provide(database))
const projector = SessionProjector.layer.pipe(Layer.provide(events), Layer.provide(database))
const store = SessionStore.layer.pipe(Layer.provide(database))
const executionCalls: SessionV2.ID[] = [] const executionCalls: SessionV2.ID[] = []
const interruptCalls: SessionV2.ID[] = [] const interruptCalls: SessionV2.ID[] = []
const interruptSeqs: Array<number | undefined> = [] const interruptSeqs: Array<number | undefined> = []
@@ -43,12 +46,14 @@ const execution = Layer.succeed(
}), }),
}), }),
) )
const root = LayerNode.group([SessionV2.node, SessionProjector.node, EventV2.node, Database.node]) const sessions = SessionV2.layer.pipe(
const it = testEffect( Layer.provide(events),
LayerNode.buildLayer(root, { Layer.provide(database),
replacements: [LayerNode.replace(Database.node, database), LayerNode.replace(SessionExecution.node, execution)], Layer.provide(store),
}), Layer.provide(Project.defaultLayer),
Layer.provide(execution),
) )
const it = testEffect(Layer.mergeAll(database, events, projector, store, execution, sessions))
const sessionID = SessionV2.ID.make("ses_prompt_test") const sessionID = SessionV2.ID.make("ses_prompt_test")
const messageID = SessionMessage.ID.create() const messageID = SessionMessage.ID.create()