Compare commits

..

1 Commits

Author SHA1 Message Date
Kit Langton d4bd41c4ba feat(tui): optimistic prompt submission
Echo user prompts into the local data store with a client-generated
message ID before server admission. The editor clears and the message
renders immediately; admission runs in a per-session background queue
that preserves steer order. The session.inbox.enqueued echo replaces
the local copy with server truth, wholesale sync replaces re-append
unconfirmed echoes, and failures roll back the echo, restore the
captured prompt, and toast.
2026-08-15 14:32:38 -04:00
173 changed files with 3661 additions and 4346 deletions
+3 -10
View File
@@ -1,10 +1,6 @@
name: "Setup Bun" name: "Setup Bun"
description: "Setup Bun with caching and install dependencies" description: "Setup Bun with caching and install dependencies"
inputs: inputs:
bun-version:
description: "Bun version to install instead of the root packageManager version"
required: false
default: ""
install-flags: install-flags:
description: "Additional flags to pass to 'bun install'" description: "Additional flags to pass to 'bun install'"
required: false required: false
@@ -24,22 +20,19 @@ runs:
shell: bash shell: bash
run: | run: |
if [ "$RUNNER_ARCH" = "X64" ]; then if [ "$RUNNER_ARCH" = "X64" ]; then
V="${{ inputs.bun-version }}" V=$(node -p "require('./package.json').packageManager.split('@')[1]")
if [ -z "$V" ]; then V=$(node -p "require('./package.json').packageManager.split('@')[1]"); fi
TAG=$([ "$V" = "canary" ] && echo "canary" || echo "bun-v${V}")
case "$RUNNER_OS" in case "$RUNNER_OS" in
macOS) OS=darwin ;; macOS) OS=darwin ;;
Linux) OS=linux ;; Linux) OS=linux ;;
Windows) OS=windows ;; Windows) OS=windows ;;
esac esac
echo "url=https://github.com/oven-sh/bun/releases/download/${TAG}/bun-${OS}-x64-baseline.zip" >> "$GITHUB_OUTPUT" echo "url=https://github.com/oven-sh/bun/releases/download/bun-v${V}/bun-${OS}-x64-baseline.zip" >> "$GITHUB_OUTPUT"
fi fi
- name: Setup Bun - name: Setup Bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0 uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with: with:
bun-version: ${{ !steps.bun-url.outputs.url && inputs.bun-version || '' }} bun-version-file: ${{ !steps.bun-url.outputs.url && 'package.json' || '' }}
bun-version-file: ${{ !steps.bun-url.outputs.url && !inputs.bun-version && 'package.json' || '' }}
bun-download-url: ${{ steps.bun-url.outputs.url }} bun-download-url: ${{ steps.bun-url.outputs.url }}
- name: Get cache directory - name: Get cache directory
+37
View File
@@ -0,0 +1,37 @@
name: beta
on:
workflow_dispatch:
schedule:
- cron: "0 * * * *"
jobs:
sync:
runs-on: blacksmith-4vcpu-ubuntu-2404
permissions:
contents: write
pull-requests: write
steps:
- name: Checkout repository
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
with:
fetch-depth: 0
- name: Setup Bun
uses: ./.github/actions/setup-bun
- name: Setup Git Committer
id: setup-git-committer
uses: ./.github/actions/setup-git-committer
with:
opencode-app-id: ${{ vars.OPENCODE_APP_ID }}
opencode-app-secret: ${{ secrets.OPENCODE_APP_SECRET }}
- name: Install OpenCode
run: bun i -g opencode-ai
- name: Sync beta branch
env:
GH_TOKEN: ${{ steps.setup-git-committer.outputs.token }}
OPENCODE_API_KEY: ${{ secrets.OPENCODE_API_KEY }}
run: bun script/beta.ts
+5 -22
View File
@@ -7,7 +7,6 @@ on:
- ci - ci
- dev - dev
- beta - beta
- v2
- fix/npm-native-binary-install - fix/npm-native-binary-install
- snapshot-* - snapshot-*
workflow_dispatch: workflow_dispatch:
@@ -33,7 +32,7 @@ permissions:
packages: write packages: write
env: env:
OPENCODE_CHANNEL: ${{ (github.ref_name == 'v2' && 'dev') || '' }} OPENCODE_CHANNEL: ${{ (github.ref_name == 'v2' && 'next') || '' }}
jobs: jobs:
version: version:
@@ -46,13 +45,6 @@ jobs:
- uses: ./.github/actions/setup-bun - uses: ./.github/actions/setup-bun
- name: Deploy update service
if: github.ref_name == 'v2' || github.ref_name == 'beta'
working-directory: packages/updates
run: bun run deploy
env:
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
- name: Setup git committer - name: Setup git committer
id: committer id: committer
uses: ./.github/actions/setup-git-committer uses: ./.github/actions/setup-git-committer
@@ -82,15 +74,13 @@ jobs:
build-cli: build-cli:
needs: version needs: version
runs-on: blacksmith-4vcpu-ubuntu-2404 runs-on: blacksmith-4vcpu-ubuntu-2404
if: github.repository == 'anomalyco/opencode' if: github.repository == 'anomalyco/opencode' && github.ref_name != 'beta'
steps: steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0 - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
with: with:
fetch-tags: true fetch-tags: true
- uses: ./.github/actions/setup-bun - uses: ./.github/actions/setup-bun
with:
bun-version: canary # Bun 1.4 until its stable release is published
- name: Setup git committer - name: Setup git committer
id: committer id: committer
@@ -112,7 +102,6 @@ jobs:
id: build id: build
run: ./packages/cli/script/build.ts ${{ (github.ref_name == 'beta' && '--sourcemaps') || '' }} run: ./packages/cli/script/build.ts ${{ (github.ref_name == 'beta' && '--sourcemaps') || '' }}
env: env:
BUN_COMPILE_RELEASE: canary
OPENCODE_VERSION: ${{ needs.version.outputs.version }} OPENCODE_VERSION: ${{ needs.version.outputs.version }}
OPENCODE_RELEASE: ${{ needs.version.outputs.release }} OPENCODE_RELEASE: ${{ needs.version.outputs.release }}
GH_REPO: ${{ needs.version.outputs.repo }} GH_REPO: ${{ needs.version.outputs.repo }}
@@ -196,7 +185,7 @@ jobs:
build-node-cli: build-node-cli:
needs: version needs: version
if: github.repository == 'anomalyco/opencode' if: github.repository == 'anomalyco/opencode' && github.ref_name != 'beta'
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
@@ -346,7 +335,6 @@ jobs:
build-electron: build-electron:
needs: needs:
- version - version
- sign-cli-macos
if: github.repository == 'anomalyco/opencode' && github.ref_name != 'v2' if: github.repository == 'anomalyco/opencode' && github.ref_name != 'v2'
continue-on-error: false continue-on-error: false
env: env:
@@ -385,12 +373,6 @@ jobs:
steps: steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0 - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
- uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
if: github.ref_name == 'beta'
with:
name: opencode-preview-cli
path: packages/cli/dist
- uses: apple-actions/import-codesign-certs@8f3fb608891dd2244cdab3d69cd68c0d37a7fe93 # v2.0.0 - uses: apple-actions/import-codesign-certs@8f3fb608891dd2244cdab3d69cd68c0d37a7fe93 # v2.0.0
if: runner.os == 'macOS' if: runner.os == 'macOS'
with: with:
@@ -449,7 +431,6 @@ jobs:
OPENCODE_VERSION: ${{ needs.version.outputs.version }} OPENCODE_VERSION: ${{ needs.version.outputs.version }}
OPENCODE_CHANNEL: ${{ (github.ref_name == 'beta' && 'beta') || 'prod' }} OPENCODE_CHANNEL: ${{ (github.ref_name == 'beta' && 'beta') || 'prod' }}
OPENCODE_CLI_TARGET: ${{ matrix.settings.target }} OPENCODE_CLI_TARGET: ${{ matrix.settings.target }}
OPENCODE_CLI_DIST: ${{ (github.ref_name == 'beta' && format('{0}/packages/cli/dist', github.workspace)) || '' }}
- name: Build - name: Build
run: bun run build run: bun run build
@@ -588,11 +569,13 @@ jobs:
path: packages/opencode/dist path: packages/opencode/dist
- uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
if: github.ref_name != 'beta'
with: with:
name: opencode-preview-cli name: opencode-preview-cli
path: packages/cli/dist path: packages/cli/dist
- uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
if: github.ref_name != 'beta'
with: with:
pattern: opencode-node-cli-* pattern: opencode-node-cli-*
path: packages/cli/dist/node path: packages/cli/dist/node
+1 -1
View File
@@ -9,7 +9,7 @@
- Run `bun run dev:live` from a development worktree to test its TUI against the currently elected `opencode2` background server and live sessions. - Run `bun run dev:live` from a development worktree to test its TUI against the currently elected `opencode2` background server and live sessions.
- Pass a directory after the script when needed, for example `bun run dev:live /path/to/project`. - Pass a directory after the script when needed, for example `bun run dev:live /path/to/project`.
- The script discovers the server with `opencode2 service status`, injects its private local credential from `opencode2 service get password`, and uses the `dev` TUI storage channel so tabs and other client-local state match the installed client. - The script discovers the server with `opencode2 service status`, injects its private local credential from `opencode2 service get password`, and uses the `next` TUI storage channel so tabs and other client-local state match the installed client.
- Prefer `dev:live` over plain `bun run dev` for this workflow. An implicit managed-service connection may replace the live server when the worktree client version differs; explicit `--server` warns and continues without replacing it. - Prefer `dev:live` over plain `bun run dev` for this workflow. An implicit managed-service connection may replace the live server when the worktree client version differs; explicit `--server` warns and continues without replacing it.
## V2 TUI Stories ## V2 TUI Stories
-1
View File
@@ -613,7 +613,6 @@
"@tsconfig/bun": "catalog:", "@tsconfig/bun": "catalog:",
"@types/bun": "catalog:", "@types/bun": "catalog:",
"@typescript/native-preview": "catalog:", "@typescript/native-preview": "catalog:",
"prettier": "3.6.2",
"typescript": "catalog:", "typescript": "catalog:",
}, },
}, },
+3 -3
View File
@@ -15,13 +15,13 @@ Usage: install.sh [options]
Options: Options:
-h, --help Display this help message -h, --help Display this help message
-v, --version <version> Install a specific version (e.g., 0.0.0-beta-17236) -v, --version <version> Install a specific version (e.g., 0.0.0-next-17236)
-b, --binary <path> Install from a local binary instead of downloading -b, --binary <path> Install from a local binary instead of downloading
--no-modify-path Don't modify shell config files (.zshrc, .bashrc, etc.) --no-modify-path Don't modify shell config files (.zshrc, .bashrc, etc.)
Examples: Examples:
curl -fsSL https://raw.githubusercontent.com/anomalyco/opencode/v2/install | bash curl -fsSL https://raw.githubusercontent.com/anomalyco/opencode/v2/install | bash
curl -fsSL https://raw.githubusercontent.com/anomalyco/opencode/v2/install | bash -s -- --version 0.0.0-beta-17236 curl -fsSL https://raw.githubusercontent.com/anomalyco/opencode/v2/install | bash -s -- --version 0.0.0-next-17236
./install --binary /path/to/opencode2 ./install --binary /path/to/opencode2
EOF EOF
} }
@@ -166,7 +166,7 @@ else
fi fi
if [ -z "$requested_version" ]; then if [ -z "$requested_version" ]; then
metadata=$(curl -fsSL https://registry.npmjs.org/@opencode-ai%2fcli/beta || true) metadata=$(curl -fsSL https://registry.npmjs.org/@opencode-ai%2fcli/next || true)
specific_version=$(echo "$metadata" | sed -n 's/.*"version":"\([^"]*\)".*/\1/p') specific_version=$(echo "$metadata" | sed -n 's/.*"version":"\([^"]*\)".*/\1/p')
if [ -z "$specific_version" ]; then if [ -z "$specific_version" ]; then
+1 -1
View File
@@ -8,7 +8,7 @@
"packageManager": "bun@1.3.14", "packageManager": "bun@1.3.14",
"scripts": { "scripts": {
"dev": "bun run --cwd packages/cli --conditions=browser src/index.ts", "dev": "bun run --cwd packages/cli --conditions=browser src/index.ts",
"dev:live": "OPENCODE_TUI_CHANNEL=dev OPENCODE_PASSWORD=\"$(opencode2 service get password)\" bun run dev --server \"$(opencode2 service status)\"", "dev:live": "OPENCODE_TUI_CHANNEL=next OPENCODE_PASSWORD=\"$(opencode2 service get password)\" bun run dev --server \"$(opencode2 service status)\"",
"dev:desktop": "bun --cwd packages/desktop dev", "dev:desktop": "bun --cwd packages/desktop dev",
"dev:web": "bun --cwd packages/app dev", "dev:web": "bun --cwd packages/app dev",
"dev:console": "ulimit -n 10240 2>/dev/null; bun run --cwd packages/console/app dev", "dev:console": "ulimit -n 10240 2>/dev/null; bun run --cwd packages/console/app dev",
+1 -1
View File
@@ -86,7 +86,7 @@ async function writeProtocolStream(session: CDPSession, handle: string, file: st
try { try {
while (true) { while (true) {
const chunk = await session.send("IO.read", { handle }) const chunk = await session.send("IO.read", { handle })
await (chunk.base64Encoded ? output.write(Buffer.from(chunk.data, "base64")) : output.write(chunk.data)) await output.write(chunk.base64Encoded ? Buffer.from(chunk.data, "base64") : chunk.data)
if (chunk.eof) break if (chunk.eof) break
} }
} finally { } finally {
@@ -125,20 +125,17 @@ export async function installTimelineStreamProbe(
const scrollTo = Element.prototype.scrollTo const scrollTo = Element.prototype.scrollTo
const scrollTop = Object.getOwnPropertyDescriptor(Element.prototype, "scrollTop")! const scrollTop = Object.getOwnPropertyDescriptor(Element.prototype, "scrollTop")!
if (profileVisual) { if (profileVisual) {
function measuredScrollTo(this: Element, options?: ScrollToOptions): void Element.prototype.scrollTo = function (...args) {
function measuredScrollTo(this: Element, x: number, y: number): void
function measuredScrollTo(this: Element, first?: number | ScrollToOptions, second?: number) {
state.scroll.calls += 1 state.scroll.calls += 1
const top = typeof first === "object" ? first?.top : second const top = typeof args[0] === "object" ? args[0]?.top : args[1]
if (typeof top === "number") { if (typeof top === "number") {
const target = Math.min(top, this.scrollHeight - this.clientHeight) const target = Math.min(top, this.scrollHeight - this.clientHeight)
if (Math.abs(this.scrollTop - target) < 1) state.scroll.callNoops += 1 if (Math.abs(this.scrollTop - target) < 1) state.scroll.callNoops += 1
} }
if (state.scroll.lastCallFrame === state.scroll.frame) state.scroll.sameFrameCalls += 1 if (state.scroll.lastCallFrame === state.scroll.frame) state.scroll.sameFrameCalls += 1
state.scroll.lastCallFrame = state.scroll.frame state.scroll.lastCallFrame = state.scroll.frame
Reflect.apply(scrollTo, this, typeof first === "number" ? [first, second] : [first]) return scrollTo.apply(this, args)
} }
Element.prototype.scrollTo = measuredScrollTo
Object.defineProperty(Element.prototype, "scrollTop", { Object.defineProperty(Element.prototype, "scrollTop", {
configurable: true, configurable: true,
get: scrollTop.get, get: scrollTop.get,
@@ -267,19 +267,18 @@ const childMessages = Array.from({ length: 4 }, (_, index) => [
userMessage(childID, index + 2000, 120), userMessage(childID, index + 2000, 120),
assistantMessage(childID, index + 2000, id("msg_user", index + 2000), [textPart(index + 2000, 0, 240)]), assistantMessage(childID, index + 2000, id("msg_user", index + 2000), [textPart(index + 2000, 0, 240)]),
]).flat() ]).flat()
const messages: Record<string, Message[]> = {
[sourceID]: sourceMessages,
[targetID]: targetMessages,
[childID]: childMessages,
}
function renderable(part: MessagePart) { function renderable(part: MessagePart) {
if (part.type === "tool" && part.tool === "todowrite") return false if (part.type === "tool" && part.tool === "todowrite") return false
if (part.type === "text") return !!part.text?.trim() if (part.type === "text") return !!part.text.trim()
if (part.type === "reasoning") return !!part.text?.trim() if (part.type === "reasoning") return !!part.text.trim()
return part.type !== "step-start" && part.type !== "step-finish" && part.type !== "patch" return part.type !== "step-start" && part.type !== "step-finish" && part.type !== "patch"
} }
function orderedParts(message: Message) {
return message.parts.slice().sort((a, b) => a.id.localeCompare(b.id))
}
export const fixture = { export const fixture = {
directory, directory,
project: { project: {
@@ -334,7 +333,7 @@ export const fixture = {
sourceID, sourceID,
targetID, targetID,
childID, childID,
messages, messages: { [sourceID]: sourceMessages, [targetID]: targetMessages, [childID]: childMessages },
expected: { expected: {
sourceTitle: "Uncommitted changes inquiry", sourceTitle: "Uncommitted changes inquiry",
targetTitle: "Example Game: sample jump movement & sample physics analysis", targetTitle: "Example Game: sample jump movement & sample physics analysis",
@@ -346,12 +345,16 @@ export const fixture = {
.filter((message) => message.info.role === "user") .filter((message) => message.info.role === "user")
.map((message) => message.info.id), .map((message) => message.info.id),
childMessageIDs: childMessages.filter((message) => message.info.role === "user").map((message) => message.info.id), childMessageIDs: childMessages.filter((message) => message.info.role === "user").map((message) => message.info.id),
targetPartIDs: targetMessages.flatMap((message) => message.parts.filter(renderable).map((part) => part.id)), targetPartIDs: targetMessages.flatMap((message) =>
orderedParts(message)
.filter(renderable)
.map((part) => part.id),
),
}, },
} }
export function pageMessages(sessionID: string, limit: number, before?: string) { export function pageMessages(sessionID: string, limit: number, before?: string) {
const messages = fixture.messages[sessionID] ?? [] const messages = fixture.messages[sessionID as keyof typeof fixture.messages] ?? []
const end = before const end = before
? Math.max( ? Math.max(
0, 0,
@@ -361,6 +364,6 @@ export function pageMessages(sessionID: string, limit: number, before?: string)
const start = Math.max(0, end - limit) const start = Math.max(0, end - limit)
return { return {
items: messages.slice(start, end), items: messages.slice(start, end),
cursor: start > 0 ? messages[start].info.id : undefined, cursor: start > 0 ? messages[start]!.info.id : undefined,
} }
} }
@@ -0,0 +1,60 @@
import { expect, test } from "@playwright/test"
import type { Page } from "@playwright/test"
import { fixture, pageMessages } from "../smoke/session-timeline.fixture"
import { mockOpenCodeServer } from "../utils/mock-server"
import { expectAppVisible } from "../utils/waits"
const NAMES = ["alpha-service", "bravo-web", "charlie-api", "delta-tools", "echo-infra", "foxtrot-docs"]
const worktrees = NAMES.map((name) => `/opencode-demo/${name}`)
// The sixth project sits outside the five-item recent cap, so it is only reachable if the
// dialog hands every recent project to the list filter instead of a pre-truncated slice.
const OUTSIDE_CAP = "foxtrot-docs"
// Dialog rows carry data-directory-path; the sidebar project list does not, so this
// scopes assertions to the picker instead of matching the sidebar entry of the same name.
const rows = (page: Page) => page.locator("[data-directory-path]")
const row = (page: Page, name: string) => page.locator(`[data-directory-path*="${name}"]`)
async function openProjectDialog(page: Page) {
await mockOpenCodeServer(page, {
sessions: fixture.sessions,
provider: fixture.provider,
directory: fixture.directory,
project: fixture.project,
pageMessages,
fileList: () => [],
findFiles: () => [],
})
await page.addInitScript((dirs) => {
localStorage.setItem(
"opencode.global.dat:server",
JSON.stringify({
projects: { local: dirs.map((worktree: string) => ({ worktree, expanded: false })) },
lastProject: {},
}),
)
}, worktrees)
await page.goto("/")
const add = page.getByRole("button", { name: "Add project" }).first()
await expectAppVisible(add)
await add.click()
await expect(rows(page)).toHaveCount(5)
return page.getByRole("textbox").last()
}
test("searches every recent project, not just the five most recent", async ({ page }) => {
const search = await openProjectDialog(page)
await expect(row(page, OUTSIDE_CAP)).toHaveCount(0)
await search.fill("foxtrot")
await expect(row(page, OUTSIDE_CAP)).toHaveCount(1)
})
test("still caps the idle recent list at five projects", async ({ page }) => {
await openProjectDialog(page)
await expect(row(page, NAMES[4])).toHaveCount(1)
await expect(row(page, OUTSIDE_CAP)).toHaveCount(0)
})
@@ -220,8 +220,7 @@ async function mockServers(page: Page, permissionRequests: string[], permissionR
} }
if (url.pathname === "/api/project/current") if (url.pathname === "/api/project/current")
return json(route, { id: remote ? sessionB.projectID : "project-server-a", directory }) return json(route, { id: remote ? sessionB.projectID : "project-server-a", directory })
if (url.pathname === "/api/session") if (url.pathname === "/api/session") return json(route, { data: sessions.map(currentSession), cursor: {} })
return json(route, { data: sessions.map((session) => currentSession(session)), cursor: {} })
if (url.pathname === "/api/session/active") return json(route, { data: {} }) if (url.pathname === "/api/session/active") return json(route, { data: {} })
const currentSessionInfo = sessions.find((session) => url.pathname === `/api/session/${session.id}`) const currentSessionInfo = sessions.find((session) => url.pathname === `/api/session/${session.id}`)
if (currentSessionInfo) return json(route, { data: currentSession(currentSessionInfo) }) if (currentSessionInfo) return json(route, { data: currentSession(currentSessionInfo) })
@@ -16,8 +16,9 @@ import { mockOpenCodeServer } from "../utils/mock-server"
import { installSseTransport } from "../utils/sse-transport" import { installSseTransport } from "../utils/sse-transport"
import { expectSessionTitle } from "../utils/waits" import { expectSessionTitle } from "../utils/waits"
const messagePageSize = 200 const initialPageSize = 20
const messages = Array.from({ length: messagePageSize / 2 + 1 }, (_, index) => { const historyPageSize = 200
const messages = Array.from({ length: initialPageSize + 1 }, (_, index) => {
const id = `msg_${String(index + 1001).padStart(4, "0")}_history_root_user` const id = `msg_${String(index + 1001).padStart(4, "0")}_history_root_user`
return [ return [
userMessage(undefined, { id, created: 1700000000000 + index * 2_000 }), userMessage(undefined, { id, created: 1700000000000 + index * 2_000 }),
@@ -25,7 +26,7 @@ const messages = Array.from({ length: messagePageSize / 2 + 1 }, (_, index) => {
id: `msg_${String(index + 1001).padStart(4, "0")}_history_root_assistant`, id: `msg_${String(index + 1001).padStart(4, "0")}_history_root_assistant`,
parentID: id, parentID: id,
created: 1700000001000 + index * 2_000, created: 1700000001000 + index * 2_000,
completed: index < messagePageSize / 2, completed: index < initialPageSize,
}), }),
] ]
}).flat() }).flat()
@@ -159,18 +160,21 @@ for (const scenario of scenarios) {
await expect(page.locator(`[data-timeline-part-id="${userPartID}"]`)).toBeVisible() await expect(page.locator(`[data-timeline-part-id="${userPartID}"]`)).toBeVisible()
const viewport = page.locator(".scroll-view__viewport", { has: page.locator("[data-timeline-row]") }) const viewport = page.locator(".scroll-view__viewport", { has: page.locator("[data-timeline-row]") })
await viewport.hover() await viewport.hover()
const deadline = Date.now() + 30_000 const deadline = Date.now() + 10_000
while (requests.filter((request) => request.phase === "start").length < 2) { while (requests.filter((request) => request.phase === "start").length < 2) {
if (Date.now() >= deadline) throw new Error("Timed out scrolling to the history boundary") if (Date.now() >= deadline) throw new Error("Timed out scrolling to the history boundary")
await page.mouse.wheel(0, -1_200) await page.mouse.wheel(0, -240)
await page.waitForTimeout(20) await page.waitForTimeout(20)
} }
expect(requests.filter((request) => request.phase === "end")).toHaveLength(1) expect(requests.filter((request) => request.phase === "end")).toHaveLength(1)
expect(sequence.slice(0, 3)).toEqual([ expect(sequence.slice(0, 3)).toEqual([
"messages:start:latest", "messages:start:latest",
"messages:end:latest", "messages:end:latest",
`messages:start:${messages.at(-messagePageSize)!.info.id}`, `messages:start:${messages.at(-initialPageSize)!.info.id}`,
]) ])
await expect(page.locator('[data-timeline-part-id*="_history_root_assistant:text:0"]')).toHaveCount(
initialPageSize / 2,
)
await page.evaluate(() => { await page.evaluate(() => {
;( ;(
window as Window & { window as Window & {
@@ -182,12 +186,15 @@ for (const scenario of scenarios) {
expect(await visibleContentHidden(page)).toBe(false) expect(await visibleContentHidden(page)).toBe(false)
const beforeHistory = await probeSamples(page) const beforeHistory = await probeSamples(page)
history.resolve() history.resolve()
await expect
.poll(() => page.locator('[data-timeline-part-id*="_history_root_assistant:text:0"]').count())
.toBeGreaterThan(initialPageSize / 2)
await expect.poll(() => requests.filter((request) => request.phase === "end").length).toBe(2) await expect.poll(() => requests.filter((request) => request.phase === "end").length).toBe(2)
await expect(page.getByRole("button", { name: "Stop" })).toBeVisible() await expect(page.getByRole("button", { name: "Stop" })).toBeVisible()
await waitForProbeSamples(page, beforeHistory) await waitForProbeSamples(page, beforeHistory)
expect(pages).toEqual([ expect(pages).toEqual([
{ before: undefined, limit: messagePageSize }, { before: undefined, limit: initialPageSize },
{ before: messages.at(-messagePageSize)!.info.id, limit: messagePageSize }, { before: messages.at(-initialPageSize)!.info.id, limit: historyPageSize },
]) ])
expect(roots).toEqual([]) expect(roots).toEqual([])
@@ -82,7 +82,6 @@ test("moves busy through retry and recovery to final idle content", async ({ pag
file: "src/retry.ts", file: "src/retry.ts",
additions: 1, additions: 1,
deletions: 1, deletions: 1,
status: "modified",
patch: "@@ -1 +1 @@\n-export const retry = false\n+export const retry = true", patch: "@@ -1 +1 @@\n-export const retry = false\n+export const retry = true",
}, },
], ],
@@ -1,27 +1,28 @@
import { expect, test } from "@playwright/test" import { expect, test } from "@playwright/test"
import type { SessionMessageAssistant, SessionMessageInfo } from "@opencode-ai/client/promise" import type { SessionMessageInfo } from "@opencode-ai/client/promise"
import { session, sessionID, setupTimeline } from "../performance/timeline-stability/fixture" import { session, sessionID, setupTimeline } from "../performance/timeline-stability/fixture"
const user = { id: "msg_user", type: "user", text: "Run it", time: { created: 1 } } satisfies SessionMessageInfo const user = { id: "msg_user", type: "user", text: "Run it", time: { created: 1 } } satisfies SessionMessageInfo
const assistant = (completed: boolean, tool = false, childID?: string): SessionMessageAssistant => ({ const assistant = (completed: boolean, tool = false, childID?: string) =>
id: "msg_assistant", ({
type: "assistant", id: "msg_assistant",
agent: "build", type: "assistant",
model: { id: "model", providerID: "provider" }, agent: "build",
content: tool model: { id: "model", providerID: "provider" },
? [ content: tool
{ ? [
type: "tool", {
id: "call_subagent", type: "tool",
name: "subagent", id: "call_subagent",
state: { status: "running", input: {}, metadata: childID ? { sessionID: childID } : {} }, name: "subagent",
time: { created: 2 }, state: { status: "running", input: {}, metadata: childID ? { sessionID: childID } : {} },
}, time: { created: 2 },
] },
: [{ type: "text", text: "Working" }], ]
time: { created: 2, ...(completed ? { completed: 3 } : {}) }, : [{ type: "text", text: "Working" }],
}) time: { created: 2, ...(completed ? { completed: 3 } : {}) },
}) satisfies SessionMessageInfo
test("renders current protocol notices in CLI order", async ({ page }) => { test("renders current protocol notices in CLI order", async ({ page }) => {
const ownerWarnings: string[] = [] const ownerWarnings: string[] = []
@@ -280,7 +280,6 @@ function summaryDiff(index: number) {
file: `src/diff-${index}.ts`, file: `src/diff-${index}.ts`,
additions: 1, additions: 1,
deletions: 1, deletions: 1,
status: "modified" as const,
patch: `@@ -1 +1 @@\n-export const value = ${index}\n+export const value = ${index + 1}`, patch: `@@ -1 +1 @@\n-export const value = ${index}\n+export const value = ${index + 1}`,
} }
} }
@@ -23,10 +23,11 @@ test("groups singleton and separated context operations at correct boundaries",
] ]
await setupTimeline(page, { messages: [userMessage(), assistantMessage(parts)] }) await setupTimeline(page, { messages: [userMessage(), assistantMessage(parts)] })
await expect(page.locator('[data-timeline-part-ids="prt_boundary_01_read"]')).toBeVisible() await expect(
await expect(page.locator('[data-timeline-part-ids="prt_boundary_03_glob,prt_boundary_04_grep"]')).toBeVisible() page.locator('[data-timeline-part-ids="prt_boundary_01_read,prt_boundary_03_glob,prt_boundary_04_grep"]'),
).toBeVisible()
await expect(page.locator('[data-timeline-part-ids="prt_boundary_06_list"]')).toBeVisible() await expect(page.locator('[data-timeline-part-ids="prt_boundary_06_list"]')).toBeVisible()
await expect(page.locator('[data-timeline-row="AssistantPart"]')).toHaveCount(5) await expect(page.locator('[data-timeline-row="AssistantPart"]')).toHaveCount(4)
}) })
test("reducer-hardening: converges when idle arrives before final part and message completion", async ({ page }) => { test("reducer-hardening: converges when idle arrives before final part and message completion", async ({ page }) => {
@@ -131,7 +131,6 @@ test("allows paint rounding for every framed row but not fixed turn gaps", async
file: "src/summary.ts", file: "src/summary.ts",
additions: 1, additions: 1,
deletions: 1, deletions: 1,
status: "modified",
patch: "@@ -1 +1 @@\n-export const value = 1\n+export const value = 2", patch: "@@ -1 +1 @@\n-export const value = 1\n+export const value = 2",
}, },
], ],
@@ -83,40 +83,6 @@ test("labels all web search provider variants", async ({ page }) => {
await expect(page.getByRole("button", { name: /^Web Search/ })).toBeVisible() await expect(page.getByRole("button", { name: /^Web Search/ })).toBeVisible()
}) })
test("labels V2 read tools from their path input", async ({ page }) => {
const id = "prt_read_path"
await setupTimeline(page, {
messages: [userMessage(), assistantMessage([toolPart(id, "read", "completed", { path: "src/a.ts" })])],
})
const group = page.locator(`[data-timeline-part-ids="${id}"]`)
await group.locator('[data-slot="collapsible-trigger"]').click()
await expect(group.locator('[data-slot="basic-tool-tool-subtitle"]')).toHaveText("a.ts")
})
test("labels V2 skill tools from IDs and result metadata", async ({ page }) => {
const pending = "prt_skill_id"
const completed = "prt_skill_name"
await setupTimeline(page, {
messages: [
userMessage(),
assistantMessage([
toolPart(pending, "skill", "running", { id: "sample-skill" }),
toolPart(completed, "skill", "completed", { id: "opencode" }, { metadata: { name: "OpenCode" } }),
]),
],
})
await expect(page.locator(`[data-timeline-part-id="${pending}"] [data-component="text-shimmer"]`)).toHaveAttribute(
"aria-label",
"sample-skill",
)
await expect(page.locator(`[data-timeline-part-id="${completed}"] [data-component="text-shimmer"]`)).toHaveAttribute(
"aria-label",
"OpenCode",
)
})
function questionInput() { function questionInput() {
return { questions: [{ header: "Stability", question: "Keep it stable?", options: [] }] } return { questions: [{ header: "Stability", question: "Keep it stable?", options: [] }] }
} }
@@ -21,7 +21,7 @@ type EventPayload = {
payload: Record<string, unknown> payload: Record<string, unknown>
} }
test.use({ viewport: { width: 1440, height: 900 } }) test.use({ viewport: { width: 1440, height: 900 }, reducedMotion: "no-preference" })
test("animates todo opening without replaying it across session tabs", async ({ page }) => { test("animates todo opening without replaying it across session tabs", async ({ page }) => {
test.setTimeout(90_000) test.setTimeout(90_000)
@@ -57,6 +57,7 @@ test("animates todo opening without replaying it across session tabs", async ({
default: { providerID: "opencode", modelID: "claude-opus-4-6" }, default: { providerID: "opencode", modelID: "claude-opus-4-6" },
}, },
sessions: [session(sourceID, sourceTitle, 1700000000000), session(otherID, otherTitle, 1700000001000)], sessions: [session(sourceID, sourceTitle, 1700000000000), session(otherID, otherTitle, 1700000001000)],
sessionStatus: { [sourceID]: { type: "busy" } },
pageMessages: () => ({ items: [] }), pageMessages: () => ({ items: [] }),
events: () => events.splice(0, 1), events: () => events.splice(0, 1),
eventRetry: 16, eventRetry: 16,
@@ -90,8 +90,7 @@ async function mockServer(page: Page) {
if ([`/api/session/${unresolvedSessionID}`, `/session/${unresolvedSessionID}`].includes(url.pathname)) if ([`/api/session/${unresolvedSessionID}`, `/session/${unresolvedSessionID}`].includes(url.pathname))
return new Promise(() => {}) return new Promise(() => {})
if (url.pathname === "/api/event") return sse(route) if (url.pathname === "/api/event") return sse(route)
if (url.pathname === "/api/session") if (url.pathname === "/api/session") return json(route, { data: sessions.map(currentSession), cursor: {} })
return json(route, { data: sessions.map((session) => currentSession(session)), cursor: {} })
if (url.pathname === "/api/session/active") return json(route, { data: {} }) if (url.pathname === "/api/session/active") return json(route, { data: {} })
const currentSessionInfo = sessions.find((item) => url.pathname === `/api/session/${item.id}`) const currentSessionInfo = sessions.find((item) => url.pathname === `/api/session/${item.id}`)
if (currentSessionInfo) return json(route, { data: currentSession(currentSessionInfo) }) if (currentSessionInfo) return json(route, { data: currentSession(currentSessionInfo) })
@@ -222,29 +222,30 @@ function turn(index: number): Message[] {
return [user, assistantMessage(targetID, index, user.info.id, parts)] return [user, assistantMessage(targetID, index, user.info.id, parts)]
} }
const targetMessages = Array.from({ length: 101 }, (_, index) => turn(index)).flat() const targetMessages = Array.from({ length: 72 }, (_, index) => turn(index)).flat()
const sourceMessages = Array.from({ length: 12 }, (_, index) => [ const sourceMessages = Array.from({ length: 12 }, (_, index) => [
userMessage(sourceID, index + 1000, 120), userMessage(sourceID, index + 1000, 120),
assistantMessage(sourceID, index + 1000, id("msg_user", index + 1000), [textPart(index + 1000, 0, 240)]), assistantMessage(sourceID, index + 1000, id("msg_user", index + 1000), [textPart(index + 1000, 0, 240)]),
]).flat() ]).flat()
const messages: Record<string, Message[]> = { [sourceID]: sourceMessages, [targetID]: targetMessages }
function renderable(part: MessagePart) { function renderable(part: MessagePart) {
if (part.type === "tool" && part.tool === "todowrite") return false if (part.type === "tool" && part.tool === "todowrite") return false
if (part.type === "text") return !!part.text?.trim() if (part.type === "text") return !!part.text.trim()
if (part.type === "reasoning") return !!part.text?.trim() if (part.type === "reasoning") return !!part.text.trim()
return part.type !== "step-start" && part.type !== "step-finish" && part.type !== "patch" return part.type !== "step-start" && part.type !== "step-finish" && part.type !== "patch"
} }
function currentPartIDs(message: Message) { function currentPartIDs(message: Message) {
const ordinals = { text: 0, reasoning: 0 } const ordinals = { text: 0, reasoning: 0 }
return message.parts.flatMap((part) => { return message.parts
if (!renderable(part)) return [] .flatMap((part) => {
if (part.type === "text") return [`${message.info.id}:text:${ordinals.text++}`] if (!renderable(part)) return []
if (part.type === "reasoning") return [`${message.info.id}:reasoning:${ordinals.reasoning++}`] if (part.type === "text") return [`${message.info.id}:text:${ordinals.text++}`]
if (part.type === "tool") return [typeof part.callID === "string" ? part.callID : part.id] if (part.type === "reasoning") return [`${message.info.id}:reasoning:${ordinals.reasoning++}`]
return [] if (part.type === "tool") return [typeof part.callID === "string" ? part.callID : part.id]
}) return []
})
.sort()
} }
export const fixture = { export const fixture = {
@@ -291,7 +292,7 @@ export const fixture = {
], ],
sourceID, sourceID,
targetID, targetID,
messages, messages: { [sourceID]: sourceMessages, [targetID]: targetMessages },
expected: { expected: {
sourceTitle: "Uncommitted changes inquiry", sourceTitle: "Uncommitted changes inquiry",
targetTitle: "Example Game: sample jump movement & sample physics analysis", targetTitle: "Example Game: sample jump movement & sample physics analysis",
@@ -305,7 +306,7 @@ export const fixture = {
} }
export function pageMessages(sessionID: string, limit: number, before?: string) { export function pageMessages(sessionID: string, limit: number, before?: string) {
const messages = fixture.messages[sessionID] ?? [] const messages = fixture.messages[sessionID as keyof typeof fixture.messages] ?? []
const end = before const end = before
? Math.max( ? Math.max(
0, 0,
@@ -315,6 +316,6 @@ export function pageMessages(sessionID: string, limit: number, before?: string)
const start = Math.max(0, end - limit) const start = Math.max(0, end - limit)
return { return {
items: messages.slice(start, end), items: messages.slice(start, end),
cursor: start > 0 ? messages[start].info.id : undefined, cursor: start > 0 ? messages[start]!.info.id : undefined,
} }
} }
@@ -124,7 +124,7 @@ test.describe("smoke: session timeline", () => {
provider: fixture.provider, provider: fixture.provider,
directory: fixture.directory, directory: fixture.directory,
project: fixture.project, project: fixture.project,
pageMessages: (sessionID) => ({ items: fixture.messages[sessionID] ?? [] }), pageMessages: (sessionID) => ({ items: fixture.messages[sessionID as keyof typeof fixture.messages] ?? [] }),
}) })
await configureSmokePage(page, fixture.directory) await configureSmokePage(page, fixture.directory)
await page.addInitScript( await page.addInitScript(
@@ -188,11 +188,7 @@ test.describe("smoke: session timeline", () => {
const bottom = root const bottom = root
.querySelector<HTMLElement>('[data-timeline-row="bottom-spacer"]') .querySelector<HTMLElement>('[data-timeline-row="bottom-spacer"]')
?.getBoundingClientRect() ?.getBoundingClientRect()
samples.push({ samples.push({ ids: visible, last: visible.includes(last), bottomError: bottom?.bottom - view.bottom })
ids: visible,
last: visible.includes(last),
bottomError: bottom ? bottom.bottom - view.bottom : undefined,
})
if ( if (
!firstPaint && !firstPaint &&
visible.includes(last) && visible.includes(last) &&
@@ -267,7 +263,7 @@ test.describe("smoke: session timeline", () => {
provider: fixture.provider, provider: fixture.provider,
directory: fixture.directory, directory: fixture.directory,
project: fixture.project, project: fixture.project,
pageMessages: (sessionID) => ({ items: fixture.messages[sessionID] ?? [] }), pageMessages: (sessionID) => ({ items: fixture.messages[sessionID as keyof typeof fixture.messages] ?? [] }),
}) })
await configureSmokePage(page, fixture.directory) await configureSmokePage(page, fixture.directory)
await page.addInitScript( await page.addInitScript(
@@ -727,7 +723,7 @@ function expectCompleteScroll(
).toEqual([]) ).toEqual([])
expect(new Set(expectedPartIDs).size).toBe(expectedPartIDs.length) expect(new Set(expectedPartIDs).size).toBe(expectedPartIDs.length)
expect(new Set(expectedMessageIDs).size).toBe(expectedMessageIDs.length) expect(new Set(expectedMessageIDs).size).toBe(expectedMessageIDs.length)
expect(expectedPartIDs.length).toBe(465) expect(expectedPartIDs.length).toBe(331)
} }
async function selectHomeProject(page: Page, projectName: string) { async function selectHomeProject(page: Page, projectName: string) {
+13 -3
View File
@@ -1,11 +1,21 @@
{ {
"extends": "../tsconfig.json", "extends": "../tsconfig.json",
"compilerOptions": { "compilerOptions": {
"composite": false,
"emitDeclarationOnly": false,
"noEmit": true, "noEmit": true,
"rootDir": "..", "rootDir": "..",
"types": ["node", "bun"] "types": ["node", "bun"]
}, },
"include": ["./**/*.ts", "./**/*.tsx", "../src/types.ts"] "include": [
"./performance/timeline-stability/**/*.spec.ts",
"./performance/timeline-stability/fixture.test.ts",
"./performance/timeline-stability/fixture.ts",
"./performance/unit/visual-stability.test.ts",
"./reproduction/timeline-suspense/**/*.ts",
"./reproduction/timeline-suspense/**/*.tsx",
"../src/types.ts",
"../src/pages/session/timeline/observe-element-offset.ts",
"./regression/new-session-panel-corner.spec.ts",
"./regression/session-timeline-context-resize.spec.ts",
"./utils/**/*.ts"
]
} }
@@ -72,12 +72,7 @@ test("creates a session in a new project and selects its model", async ({ page }
const addProject = page.locator('[data-action="home-add-project-row"]') const addProject = page.locator('[data-action="home-add-project-row"]')
await expectAppVisible(addProject) await expectAppVisible(addProject)
await addProject.click() await addProject.click()
const directoryItem = page.getByRole("treeitem", { name: "NewProject" }) await page.locator("[data-directory-path]").click()
await expect(directoryItem).toBeVisible()
await directoryItem.click()
const selectFolder = page.getByRole("button", { name: "Select folder" })
await expect(selectFolder).toBeEnabled()
await selectFolder.click()
await page.locator('[data-action="home-new-session"]').click() await page.locator('[data-action="home-new-session"]').click()
await expectAppVisible(page.locator('[data-component="prompt-input-v2"]')) await expectAppVisible(page.locator('[data-component="prompt-input-v2"]'))
@@ -0,0 +1,205 @@
import { useDialog } from "@opencode-ai/ui/context/dialog"
import { Dialog } from "@opencode-ai/ui/dialog"
import { FileIcon } from "@opencode-ai/ui/file-icon"
import { List } from "@opencode-ai/ui/list"
import type { ListRef } from "@opencode-ai/ui/list"
import { getDirectory, getFilename } from "@opencode-ai/core/util/path"
import { createMemo, createResource, createSignal } from "solid-js"
import { useLanguage } from "@/context/language"
import { ServerConnection } from "@/context/servers"
import { useGlobal } from "@/context/global"
import { cleanPickerInput, createDirectorySearch, displayPickerPath } from "./directory-picker-domain"
import type { Path } from "@/types"
interface DialogSelectDirectoryProps {
title?: string
multiple?: boolean
onSelect: (result: string | string[] | null) => void
server: ServerConnection.Any
}
const RECENT_PROJECT_LIMIT = 5
type Row = {
absolute: string
search: string
group: "recent" | "folders"
}
function toRow(absolute: string, home: string, group: Row["group"]): Row {
const full = displayPickerPath(absolute, "", "")
const tilde = displayPickerPath(full, "~", home)
const withSlash = (value: string) => {
if (!value) return ""
if (value.endsWith("/")) return value
return value + "/"
}
const search = Array.from(
new Set([full, withSlash(full), tilde, withSlash(tilde), getFilename(full)].filter(Boolean)),
).join("\n")
return { absolute: full, search, group }
}
function uniqueRows(rows: Row[]) {
const seen = new Set<string>()
return rows.filter((row) => {
if (seen.has(row.absolute)) return false
seen.add(row.absolute)
return true
})
}
export function DialogSelectDirectory(props: DialogSelectDirectoryProps) {
const global = useGlobal()
const { sync, sdk, ...serverCtx } = global.ensureServerCtx(props.server)
const dialog = useDialog()
const language = useLanguage()
const [filter, setFilter] = createSignal("")
let list: ListRef | undefined
const [fallbackPath] = createResource(
() => (!(sync.data.path.home || sync.data.path.directory) ? true : undefined),
() =>
sdk.api.location
.get()
.then(
(location): Path => ({
state: "",
config: "",
worktree: location.project.directory,
directory: location.directory,
home: "",
}),
)
.catch(() => undefined),
{ initialValue: undefined },
)
const home = createMemo(() => sync.data.path.home || fallbackPath()?.home || "")
const start = createMemo(
() => sync.data.path.home || sync.data.path.directory || fallbackPath()?.home || fallbackPath()?.directory,
)
const directories = createDirectorySearch({
sdk,
home,
base: start,
})
const recentProjects = createMemo(() => {
const projects = serverCtx.projects.list()
const byProject = new Map<string, number>()
for (const project of projects) {
let at = 0
const dirs = [project.worktree, ...(project.sandboxes ?? [])]
for (const directory of dirs) {
const sessions = sync.child(directory, { bootstrap: false })[0].session
for (const session of sessions) {
if (session.time.archived) continue
const updated = session.time.updated ?? session.time.created
if (updated > at) at = updated
}
}
byProject.set(project.worktree, at)
}
return projects
.map((project, index) => ({ project, at: byProject.get(project.worktree) ?? 0, index }))
.sort((a, b) => b.at - a.at || a.index - b.index)
.map(({ project }) => {
const row = toRow(project.worktree, home(), "recent")
const name = project.name || getFilename(project.worktree)
return {
...row,
search: `${row.search}\n${name}`,
}
})
})
const items = async (value: string) => {
const results = await directories(value)
const directoryRows = results.map((absolute) => toRow(absolute, home(), "folders"))
// Cap the idle list only. Once a query narrows the results, every project stays searchable.
const recent = recentProjects()
const visible = value ? recent : recent.slice(0, RECENT_PROJECT_LIMIT)
return uniqueRows([...visible, ...directoryRows])
}
function resolve(absolute: string) {
props.onSelect(props.multiple ? [absolute] : absolute)
dialog.close()
}
return (
<Dialog title={props.title ?? language.t("command.project.open")}>
<List
class="px-3"
search={{ placeholder: language.t("dialog.directory.search.placeholder"), autofocus: true }}
emptyMessage={language.t("dialog.directory.empty")}
loadingMessage={language.t("common.loading")}
items={items}
key={(x) => x.absolute}
filterKeys={["search"]}
groupBy={(item) => item.group}
sortGroupsBy={(a, b) => {
if (a.category === b.category) return 0
return a.category === "recent" ? -1 : 1
}}
groupHeader={(group) =>
group.category === "recent" ? language.t("home.recentProjects") : language.t("command.project.open")
}
ref={(r) => (list = r)}
onFilter={(value) => setFilter(cleanPickerInput(value))}
onKeyEvent={(e, item) => {
if (e.key !== "Tab") return
if (e.shiftKey) return
if (!item) return
e.preventDefault()
e.stopPropagation()
const value = displayPickerPath(item.absolute, filter(), home())
list?.setFilter(value.endsWith("/") ? value : value + "/")
}}
onSelect={(path) => {
if (!path) return
resolve(path.absolute)
}}
>
{(item) => {
const path = displayPickerPath(item.absolute, filter(), home())
if (path === "~") {
return (
<div data-directory-path={item.absolute} class="w-full flex items-center justify-between rounded-md">
<div class="flex items-center gap-x-3 grow min-w-0">
<FileIcon node={{ path: item.absolute, type: "directory" }} class="shrink-0 size-4" />
<div class="flex items-center text-14-regular min-w-0">
<span class="text-text-strong whitespace-nowrap">~</span>
<span class="text-text-weak whitespace-nowrap">/</span>
</div>
</div>
</div>
)
}
return (
<div data-directory-path={item.absolute} class="w-full flex items-center justify-between rounded-md">
<div class="flex items-center gap-x-3 grow min-w-0">
<FileIcon node={{ path: item.absolute, type: "directory" }} class="shrink-0 size-4" />
<div class="flex items-center text-14-regular min-w-0">
<span class="text-text-weak whitespace-nowrap overflow-hidden overflow-ellipsis truncate min-w-0">
{getDirectory(path)}
</span>
<span class="text-text-strong whitespace-nowrap">{getFilename(path)}</span>
<span class="text-text-weak whitespace-nowrap">/</span>
</div>
</div>
</div>
)
}}
</List>
</Dialog>
)
}
@@ -1,7 +1,9 @@
import { useDialog } from "@opencode-ai/ui/context/dialog" import { useDialog } from "@opencode-ai/ui/context/dialog"
import { ServerConnection } from "@/context/servers" import { ServerConnection } from "@/context/servers"
import { usePlatform } from "@/context/platform" import { usePlatform } from "@/context/platform"
import { useSettings } from "@/context/settings"
import { lazy } from "solid-js" import { lazy } from "solid-js"
import { DialogSelectDirectory } from "./dialog-select-directory"
import { directoryPickerKind } from "./directory-picker-policy" import { directoryPickerKind } from "./directory-picker-policy"
const DialogSelectDirectoryV2 = lazy(() => const DialogSelectDirectoryV2 = lazy(() =>
@@ -17,6 +19,7 @@ type DirectoryPickerInput = {
export function useDirectoryPicker() { export function useDirectoryPicker() {
const platform = usePlatform() const platform = usePlatform()
const settings = useSettings()
const dialog = useDialog() const dialog = useDialog()
return (input: DirectoryPickerInput) => { return (input: DirectoryPickerInput) => {
@@ -33,6 +36,10 @@ export function useDirectoryPicker() {
const cancel = () => { const cancel = () => {
if (!selected) input.onSelect(null) if (!selected) input.onSelect(null)
} }
dialog.show(() => <DialogSelectDirectoryV2 {...input} onSelect={onSelect} />, cancel) if (platform.platform === "desktop" && settings.general.newLayoutDesigns()) {
dialog.show(() => <DialogSelectDirectoryV2 {...input} onSelect={onSelect} />, cancel)
return
}
dialog.show(() => <DialogSelectDirectory {...input} onSelect={onSelect} />, cancel)
} }
} }
@@ -1,321 +0,0 @@
import { describe, expect, test } from "bun:test"
import type { Prompt } from "@/context/prompt"
import { buildPromptRequest } from "./build-prompt-request"
describe("buildPromptRequest", () => {
test("builds text, files, and agents from the prompt", () => {
const prompt: Prompt = [
{ type: "text", content: "hello", start: 0, end: 5 },
{
type: "file",
path: "src/foo.ts",
content: "@src/foo.ts",
start: 5,
end: 16,
selection: { startLine: 4, startChar: 1, endLine: 6, endChar: 1 },
},
{ type: "agent", name: "planner", content: "@planner", start: 16, end: 24 },
]
const result = buildPromptRequest({
prompt,
context: [{ key: "ctx:1", type: "file", path: "src/bar.ts", comment: "check this" }],
images: [
{ type: "image", id: "img_1", filename: "a.png", mime: "image/png", dataUrl: "data:image/png;base64,AAA" },
],
text: "hello @src/foo.ts @planner",
sessionDirectory: "/repo",
})
expect(result.text).toContain("hello @src/foo.ts @planner")
expect(result.text).toContain("check this")
expect(result.displayText).toBe("hello @src/foo.ts @planner")
expect(result.comments).toMatchObject([{ path: "src/bar.ts", comment: "check this" }])
expect(result.agents).toEqual([{ name: "planner", mention: { start: 16, end: 24, text: "@planner" } }])
expect(result.files.some((file) => file.uri.startsWith("file:///repo/src/foo.ts"))).toBe(true)
expect(result.files.find((file) => file.uri.startsWith("file:///repo/src/foo.ts"))?.mention).toEqual({
start: 5,
end: 16,
text: "@src/foo.ts",
})
})
test("keeps multiple uploaded attachments in order", () => {
const result = buildPromptRequest({
prompt: [{ type: "text", content: "check these", start: 0, end: 11 }],
context: [],
images: [
{ type: "image", id: "img_1", filename: "a.png", mime: "image/png", dataUrl: "data:image/png;base64,AAA" },
{
type: "image",
id: "img_2",
filename: "b.pdf",
mime: "application/pdf",
dataUrl: "data:application/pdf;base64,BBB",
},
],
text: "check these",
sessionDirectory: "/repo",
})
const uploads = result.files.filter((file) => file.uri.startsWith("data:"))
expect(uploads).toHaveLength(2)
expect(uploads.map((file) => file.name)).toEqual(["a.png", "b.pdf"])
})
test("preserves an external attachment source path for the model", () => {
const result = buildPromptRequest({
prompt: [],
context: [],
images: [
{
type: "image",
id: "img_external",
filename: "opencode.global.dat",
sourcePath: "C:\\Users\\Luke\\AppData\\Roaming\\ai.opencode.desktop.beta\\opencode.global.dat",
mime: "text/plain",
dataUrl: "data:text/plain;base64,AAA",
},
],
text: "inspect this",
sessionDirectory: "C:\\Repos\\sst\\opencode",
})
expect(result.files[0]?.name).toBe(
"C:\\Users\\Luke\\AppData\\Roaming\\ai.opencode.desktop.beta\\opencode.global.dat",
)
})
test("preserves reference aliases as directory files", () => {
const result = buildPromptRequest({
prompt: [
{
type: "file",
path: "/repo/../docs",
content: "@docs",
start: 0,
end: 5,
mime: "application/x-directory",
filename: "docs",
},
],
context: [],
images: [],
text: "@docs",
sessionDirectory: "/repo/app",
})
expect(result.files[0]).toEqual({
uri: "file:///repo/../docs",
mime: "application/x-directory",
name: "docs",
mention: { start: 0, end: 5, text: "@docs" },
})
})
test("deduplicates context files when prompt already includes same path", () => {
const prompt: Prompt = [{ type: "file", path: "src/foo.ts", content: "@src/foo.ts", start: 0, end: 11 }]
const result = buildPromptRequest({
prompt,
context: [
{ key: "ctx:dup", type: "file", path: "src/foo.ts" },
{ key: "ctx:comment", type: "file", path: "src/foo.ts", comment: "focus here" },
],
images: [],
text: "@src/foo.ts",
sessionDirectory: "/repo",
})
const fooFiles = result.files.filter((file) => file.uri.startsWith("file:///repo/src/foo.ts"))
expect(fooFiles).toHaveLength(2)
expect(result.text).toContain("focus here")
})
test("adds files for @mentions inside comment text", () => {
const result = buildPromptRequest({
prompt: [{ type: "text", content: "look", start: 0, end: 4 }],
context: [
{
key: "ctx:comment-mention",
type: "file",
path: "src/review.ts",
comment: "Compare with @src/shared.ts and @src/review.ts.",
},
],
images: [],
text: "look",
sessionDirectory: "/repo",
})
expect(result.files).toHaveLength(2)
expect(result.files.some((file) => file.uri === "file:///repo/src/review.ts")).toBe(true)
expect(result.files.some((file) => file.uri === "file:///repo/src/shared.ts")).toBe(true)
})
test("handles Windows paths correctly (simulated on macOS)", () => {
const prompt: Prompt = [{ type: "file", path: "src\\foo.ts", content: "@src\\foo.ts", start: 0, end: 11 }]
const result = buildPromptRequest({
prompt,
context: [],
images: [],
text: "@src\\foo.ts",
sessionDirectory: "D:\\projects\\myapp", // Windows path
})
const file = result.files[0]
expect(file).toBeDefined()
// URL should be parseable
expect(() => new URL(file!.uri)).not.toThrow()
// Should not have encoded backslashes in wrong place
expect(file!.uri).not.toContain("%5C")
// Should have normalized to forward slashes
expect(file!.uri).toContain("/src/foo.ts")
})
test("handles Windows absolute path with special characters", () => {
const prompt: Prompt = [{ type: "file", path: "file#name.txt", content: "@file#name.txt", start: 0, end: 14 }]
const result = buildPromptRequest({
prompt,
context: [],
images: [],
text: "@file#name.txt",
sessionDirectory: "C:\\Users\\test\\Documents", // Windows path
})
const file = result.files[0]
expect(file).toBeDefined()
// URL should be parseable
expect(() => new URL(file!.uri)).not.toThrow()
// Special chars should be encoded
expect(file!.uri).toContain("file%23name.txt")
// Should have Windows drive letter properly encoded
expect(file!.uri).toMatch(/file:\/\/\/[A-Z]:/)
})
test("handles Linux absolute paths correctly", () => {
const prompt: Prompt = [{ type: "file", path: "src/app.ts", content: "@src/app.ts", start: 0, end: 10 }]
const result = buildPromptRequest({
prompt,
context: [],
images: [],
text: "@src/app.ts",
sessionDirectory: "/home/user/project",
})
expect(result.files[0]?.uri).toBe("file:///home/user/project/src/app.ts")
})
test("handles macOS paths correctly", () => {
const prompt: Prompt = [{ type: "file", path: "README.md", content: "@README.md", start: 0, end: 9 }]
const result = buildPromptRequest({
prompt,
context: [],
images: [],
text: "@README.md",
sessionDirectory: "/Users/kelvin/Projects/opencode",
})
expect(result.files[0]?.uri).toBe("file:///Users/kelvin/Projects/opencode/README.md")
})
test("handles context files with Windows paths", () => {
const result = buildPromptRequest({
prompt: [],
context: [
{ key: "ctx:1", type: "file", path: "src\\utils\\helper.ts" },
{ key: "ctx:2", type: "file", path: "test\\unit.test.ts", comment: "check tests" },
],
images: [],
text: "test",
sessionDirectory: "D:\\workspace\\app",
})
expect(result.files).toHaveLength(2)
// All file URLs should be valid
result.files.forEach((file) => {
expect(() => new URL(file.uri)).not.toThrow()
expect(file.uri).not.toContain("%5C") // No encoded backslashes
})
})
test("handles absolute Windows paths (user manually specifies full path)", () => {
const prompt: Prompt = [
{ type: "file", path: "D:\\other\\project\\file.ts", content: "@D:\\other\\project\\file.ts", start: 0, end: 25 },
]
const result = buildPromptRequest({
prompt,
context: [],
images: [],
text: "@D:\\other\\project\\file.ts",
sessionDirectory: "C:\\current\\project",
})
const file = result.files[0]
expect(file).toBeDefined()
// Should handle absolute path that differs from sessionDirectory
expect(() => new URL(file!.uri)).not.toThrow()
expect(file!.uri).toContain("/D:/other/project/file.ts")
})
test("handles selection with query parameters on Windows", () => {
const prompt: Prompt = [
{
type: "file",
path: "src\\App.tsx",
content: "@src\\App.tsx",
start: 0,
end: 11,
selection: { startLine: 10, startChar: 0, endLine: 20, endChar: 5 },
},
]
const result = buildPromptRequest({
prompt,
context: [],
images: [],
text: "@src\\App.tsx",
sessionDirectory: "C:\\project",
})
const file = result.files[0]
expect(file).toBeDefined()
// Should have query parameters
expect(file!.uri).toContain("?start=10&end=20")
// Should be valid URL
expect(() => new URL(file!.uri)).not.toThrow()
// Query params should parse correctly
const url = new URL(file!.uri)
expect(url.searchParams.get("start")).toBe("10")
expect(url.searchParams.get("end")).toBe("20")
})
test("handles file paths with dots and special segments on Windows", () => {
const prompt: Prompt = [
{ type: "file", path: "..\\..\\shared\\util.ts", content: "@..\\..\\shared\\util.ts", start: 0, end: 21 },
]
const result = buildPromptRequest({
prompt,
context: [],
images: [],
text: "@..\\..\\shared\\util.ts",
sessionDirectory: "C:\\projects\\myapp\\src",
})
const file = result.files[0]
expect(file).toBeDefined()
// Should be valid URL
expect(() => new URL(file!.uri)).not.toThrow()
// Should preserve .. segments (backend normalizes)
expect(file!.uri).toContain("/..")
})
})
@@ -1,115 +0,0 @@
import { getFilename } from "@opencode-ai/core/util/path"
import type { FileSelection } from "@/context/file"
import { encodeFilePath } from "@/context/file/path"
import type { AgentPart, FileAttachmentPart, ImageAttachmentPart, Prompt } from "@/context/prompt"
import { formatCommentNote, type PromptComment } from "@/utils/comment-note"
// Network fields feed both boundaries; display fields keep desktop-only rendering details in the local echo.
type PromptRequest = {
text: string
displayText: string
files: { uri: string; mime: string; name?: string; mention?: { start: number; end: number; text: string } }[]
agents: { name: string; mention?: { start: number; end: number; text: string } }[]
comments: PromptComment[]
}
type ContextFile = {
key: string
type: "file"
path: string
selection?: FileSelection
comment?: string
commentID?: string
commentOrigin?: "review" | "file"
preview?: string
}
type BuildPromptRequestInput = {
prompt: Prompt
context: ContextFile[]
images: (Omit<ImageAttachmentPart, "blob"> & { dataUrl: string })[]
text: string
sessionDirectory: string
}
const absolute = (directory: string, path: string) => {
if (path.startsWith("/")) return path
if (/^[A-Za-z]:[\\/]/.test(path) || /^[A-Za-z]:$/.test(path)) return path
if (path.startsWith("\\\\") || path.startsWith("//")) return path
return `${directory.replace(/[\\/]+$/, "")}/${path}`
}
const fileQuery = (selection: FileSelection | undefined) =>
selection ? `?start=${selection.startLine}&end=${selection.endLine}` : ""
const mention = /(^|[\s([{"'])@(\S+)/g
const parseCommentMentions = (comment: string) => {
return Array.from(comment.matchAll(mention)).flatMap((match) => {
const path = (match[2] ?? "").replace(/[.,!?;:)}\]"']+$/, "")
if (!path) return []
return [path]
})
}
const isFileAttachment = (part: Prompt[number]): part is FileAttachmentPart => part.type === "file"
const isAgentAttachment = (part: Prompt[number]): part is AgentPart => part.type === "agent"
export function buildPromptRequest(input: BuildPromptRequestInput): PromptRequest {
const files = input.prompt.filter(isFileAttachment).map((attachment) => {
const path = absolute(input.sessionDirectory, attachment.path)
return {
uri: attachment.url ?? `file://${encodeFilePath(path)}${fileQuery(attachment.selection)}`,
mime: attachment.mime ?? "text/plain",
name: attachment.filename ?? getFilename(attachment.path),
mention: { start: attachment.start, end: attachment.end, text: attachment.content },
}
})
const agents = input.prompt.filter(isAgentAttachment).map((attachment) => ({
name: attachment.name,
mention: { start: attachment.start, end: attachment.end, text: attachment.content },
}))
const used = new Set(files.map((file) => file.uri))
const comments: PromptComment[] = []
const context = input.context.flatMap((item) => {
const path = absolute(input.sessionDirectory, item.path)
const uri = `file://${encodeFilePath(path)}${fileQuery(item.selection)}`
const comment = item.comment?.trim()
if (!comment && used.has(uri)) return []
used.add(uri)
const file = { uri, mime: "text/plain", name: getFilename(item.path) }
if (!comment) return [file]
comments.push({
path: item.path,
selection: item.selection,
comment,
preview: item.preview,
origin: item.commentOrigin,
})
const mentions = parseCommentMentions(comment).flatMap((path) => {
const uri = `file://${encodeFilePath(absolute(input.sessionDirectory, path))}`
if (used.has(uri)) return []
used.add(uri)
return [{ uri, mime: "text/plain", name: getFilename(path) }]
})
return [file, ...mentions]
})
const images = input.images.map((attachment) => ({
uri: attachment.dataUrl,
mime: attachment.mime,
name: attachment.sourcePath ?? attachment.filename,
}))
return {
text: [...(input.text.trim() ? [input.text] : []), ...comments.map(formatCommentNote)].join("\n"),
displayText: input.text,
files: [...files, ...context, ...images],
agents,
comments,
}
}
@@ -0,0 +1,396 @@
import { describe, expect, test } from "bun:test"
import type { Prompt } from "@/context/prompt"
import { buildRequestParts } from "./build-request-parts"
describe("buildRequestParts", () => {
test("builds typed request and optimistic parts without cast path", () => {
const prompt: Prompt = [
{ type: "text", content: "hello", start: 0, end: 5 },
{
type: "file",
path: "src/foo.ts",
content: "@src/foo.ts",
start: 5,
end: 16,
selection: { startLine: 4, startChar: 1, endLine: 6, endChar: 1 },
},
{ type: "agent", name: "planner", content: "@planner", start: 16, end: 24 },
]
const result = buildRequestParts({
prompt,
context: [{ key: "ctx:1", type: "file", path: "src/bar.ts", comment: "check this" }],
images: [
{ type: "image", id: "img_1", filename: "a.png", mime: "image/png", dataUrl: "data:image/png;base64,AAA" },
],
text: "hello @src/foo.ts @planner",
messageID: "msg_1",
sessionID: "ses_1",
sessionDirectory: "/repo",
})
expect(result.requestParts[0]?.type).toBe("text")
expect(result.requestParts.some((part) => part.type === "agent")).toBe(true)
expect(
result.requestParts.some((part) => part.type === "file" && part.url.startsWith("file:///repo/src/foo.ts")),
).toBe(true)
expect(result.requestParts.some((part) => part.type === "text" && part.synthetic)).toBe(true)
expect(
result.requestParts.some(
(part) =>
part.type === "text" &&
part.synthetic &&
part.metadata?.opencodeComment &&
(part.metadata.opencodeComment as { comment?: string }).comment === "check this",
),
).toBe(true)
expect(result.optimisticParts).toHaveLength(result.requestParts.length)
expect(result.optimisticParts.every((part) => part.sessionID === "ses_1" && part.messageID === "msg_1")).toBe(true)
})
test("keeps multiple uploaded attachments in order", () => {
const result = buildRequestParts({
prompt: [{ type: "text", content: "check these", start: 0, end: 11 }],
context: [],
images: [
{ type: "image", id: "img_1", filename: "a.png", mime: "image/png", dataUrl: "data:image/png;base64,AAA" },
{
type: "image",
id: "img_2",
filename: "b.pdf",
mime: "application/pdf",
dataUrl: "data:application/pdf;base64,BBB",
},
],
text: "check these",
messageID: "msg_multi",
sessionID: "ses_multi",
sessionDirectory: "/repo",
})
const files = result.requestParts.filter((part) => part.type === "file" && part.url.startsWith("data:"))
expect(files).toHaveLength(2)
expect(files.map((part) => (part.type === "file" ? part.filename : ""))).toEqual(["a.png", "b.pdf"])
})
test("preserves an external attachment source path for the model", () => {
const result = buildRequestParts({
prompt: [],
context: [],
images: [
{
type: "image",
id: "img_external",
filename: "opencode.global.dat",
sourcePath: "C:\\Users\\Luke\\AppData\\Roaming\\ai.opencode.desktop.beta\\opencode.global.dat",
mime: "text/plain",
dataUrl: "data:text/plain;base64,AAA",
},
],
text: "inspect this",
messageID: "msg_external",
sessionID: "ses_external",
sessionDirectory: "C:\\Repos\\sst\\opencode",
})
expect(result.requestParts.find((part) => part.type === "file")?.filename).toBe(
"C:\\Users\\Luke\\AppData\\Roaming\\ai.opencode.desktop.beta\\opencode.global.dat",
)
})
test("preserves reference aliases as directory file parts", () => {
const result = buildRequestParts({
prompt: [
{
type: "file",
path: "/repo/../docs",
content: "@docs",
start: 0,
end: 5,
mime: "application/x-directory",
filename: "docs",
},
],
context: [],
images: [],
text: "@docs",
messageID: "msg_reference",
sessionID: "ses_reference",
sessionDirectory: "/repo/app",
})
const filePart = result.requestParts.find((part) => part.type === "file")
expect(filePart).toBeDefined()
if (filePart?.type === "file") {
expect(filePart.mime).toBe("application/x-directory")
expect(filePart.filename).toBe("docs")
expect(filePart.url).toBe("file:///repo/../docs")
expect(filePart.source?.type).toBe("file")
if (filePart.source?.type === "file") {
expect(filePart.source.path).toBe("/repo/../docs")
expect(filePart.source.text.value).toBe("@docs")
}
}
})
test("deduplicates context files when prompt already includes same path", () => {
const prompt: Prompt = [{ type: "file", path: "src/foo.ts", content: "@src/foo.ts", start: 0, end: 11 }]
const result = buildRequestParts({
prompt,
context: [
{ key: "ctx:dup", type: "file", path: "src/foo.ts" },
{ key: "ctx:comment", type: "file", path: "src/foo.ts", comment: "focus here" },
],
images: [],
text: "@src/foo.ts",
messageID: "msg_2",
sessionID: "ses_2",
sessionDirectory: "/repo",
})
const fooFiles = result.requestParts.filter(
(part) => part.type === "file" && part.url.startsWith("file:///repo/src/foo.ts"),
)
const synthetic = result.requestParts.filter((part) => part.type === "text" && part.synthetic)
expect(fooFiles).toHaveLength(2)
expect(synthetic).toHaveLength(1)
})
test("adds file parts for @mentions inside comment text", () => {
const result = buildRequestParts({
prompt: [{ type: "text", content: "look", start: 0, end: 4 }],
context: [
{
key: "ctx:comment-mention",
type: "file",
path: "src/review.ts",
comment: "Compare with @src/shared.ts and @src/review.ts.",
},
],
images: [],
text: "look",
messageID: "msg_comment_mentions",
sessionID: "ses_comment_mentions",
sessionDirectory: "/repo",
})
const files = result.requestParts.filter((part) => part.type === "file")
expect(files).toHaveLength(2)
expect(files.some((part) => part.type === "file" && part.url === "file:///repo/src/review.ts")).toBe(true)
expect(files.some((part) => part.type === "file" && part.url === "file:///repo/src/shared.ts")).toBe(true)
})
test("handles Windows paths correctly (simulated on macOS)", () => {
const prompt: Prompt = [{ type: "file", path: "src\\foo.ts", content: "@src\\foo.ts", start: 0, end: 11 }]
const result = buildRequestParts({
prompt,
context: [],
images: [],
text: "@src\\foo.ts",
messageID: "msg_win_1",
sessionID: "ses_win_1",
sessionDirectory: "D:\\projects\\myapp", // Windows path
})
// Should create valid file URLs
const filePart = result.requestParts.find((part) => part.type === "file")
expect(filePart).toBeDefined()
if (filePart?.type === "file") {
// URL should be parseable
expect(() => new URL(filePart.url)).not.toThrow()
// Should not have encoded backslashes in wrong place
expect(filePart.url).not.toContain("%5C")
// Should have normalized to forward slashes
expect(filePart.url).toContain("/src/foo.ts")
}
})
test("handles Windows absolute path with special characters", () => {
const prompt: Prompt = [{ type: "file", path: "file#name.txt", content: "@file#name.txt", start: 0, end: 14 }]
const result = buildRequestParts({
prompt,
context: [],
images: [],
text: "@file#name.txt",
messageID: "msg_win_2",
sessionID: "ses_win_2",
sessionDirectory: "C:\\Users\\test\\Documents", // Windows path
})
const filePart = result.requestParts.find((part) => part.type === "file")
expect(filePart).toBeDefined()
if (filePart?.type === "file") {
// URL should be parseable
expect(() => new URL(filePart.url)).not.toThrow()
// Special chars should be encoded
expect(filePart.url).toContain("file%23name.txt")
// Should have Windows drive letter properly encoded
expect(filePart.url).toMatch(/file:\/\/\/[A-Z]:/)
}
})
test("handles Linux absolute paths correctly", () => {
const prompt: Prompt = [{ type: "file", path: "src/app.ts", content: "@src/app.ts", start: 0, end: 10 }]
const result = buildRequestParts({
prompt,
context: [],
images: [],
text: "@src/app.ts",
messageID: "msg_linux_1",
sessionID: "ses_linux_1",
sessionDirectory: "/home/user/project",
})
const filePart = result.requestParts.find((part) => part.type === "file")
expect(filePart).toBeDefined()
if (filePart?.type === "file") {
// URL should be parseable
expect(() => new URL(filePart.url)).not.toThrow()
// Should be a normal Unix path
expect(filePart.url).toBe("file:///home/user/project/src/app.ts")
}
})
test("handles macOS paths correctly", () => {
const prompt: Prompt = [{ type: "file", path: "README.md", content: "@README.md", start: 0, end: 9 }]
const result = buildRequestParts({
prompt,
context: [],
images: [],
text: "@README.md",
messageID: "msg_mac_1",
sessionID: "ses_mac_1",
sessionDirectory: "/Users/kelvin/Projects/opencode",
})
const filePart = result.requestParts.find((part) => part.type === "file")
expect(filePart).toBeDefined()
if (filePart?.type === "file") {
// URL should be parseable
expect(() => new URL(filePart.url)).not.toThrow()
// Should be a normal Unix path
expect(filePart.url).toBe("file:///Users/kelvin/Projects/opencode/README.md")
}
})
test("handles context files with Windows paths", () => {
const prompt: Prompt = []
const result = buildRequestParts({
prompt,
context: [
{ key: "ctx:1", type: "file", path: "src\\utils\\helper.ts" },
{ key: "ctx:2", type: "file", path: "test\\unit.test.ts", comment: "check tests" },
],
images: [],
text: "test",
messageID: "msg_win_ctx",
sessionID: "ses_win_ctx",
sessionDirectory: "D:\\workspace\\app",
})
const fileParts = result.requestParts.filter((part) => part.type === "file")
expect(fileParts).toHaveLength(2)
// All file URLs should be valid
fileParts.forEach((part) => {
if (part.type === "file") {
expect(() => new URL(part.url)).not.toThrow()
expect(part.url).not.toContain("%5C") // No encoded backslashes
}
})
})
test("handles absolute Windows paths (user manually specifies full path)", () => {
const prompt: Prompt = [
{ type: "file", path: "D:\\other\\project\\file.ts", content: "@D:\\other\\project\\file.ts", start: 0, end: 25 },
]
const result = buildRequestParts({
prompt,
context: [],
images: [],
text: "@D:\\other\\project\\file.ts",
messageID: "msg_abs",
sessionID: "ses_abs",
sessionDirectory: "C:\\current\\project",
})
const filePart = result.requestParts.find((part) => part.type === "file")
expect(filePart).toBeDefined()
if (filePart?.type === "file") {
// Should handle absolute path that differs from sessionDirectory
expect(() => new URL(filePart.url)).not.toThrow()
expect(filePart.url).toContain("/D:/other/project/file.ts")
}
})
test("handles selection with query parameters on Windows", () => {
const prompt: Prompt = [
{
type: "file",
path: "src\\App.tsx",
content: "@src\\App.tsx",
start: 0,
end: 11,
selection: { startLine: 10, startChar: 0, endLine: 20, endChar: 5 },
},
]
const result = buildRequestParts({
prompt,
context: [],
images: [],
text: "@src\\App.tsx",
messageID: "msg_sel",
sessionID: "ses_sel",
sessionDirectory: "C:\\project",
})
const filePart = result.requestParts.find((part) => part.type === "file")
expect(filePart).toBeDefined()
if (filePart?.type === "file") {
// Should have query parameters
expect(filePart.url).toContain("?start=10&end=20")
// Should be valid URL
expect(() => new URL(filePart.url)).not.toThrow()
// Query params should parse correctly
const url = new URL(filePart.url)
expect(url.searchParams.get("start")).toBe("10")
expect(url.searchParams.get("end")).toBe("20")
}
})
test("handles file paths with dots and special segments on Windows", () => {
const prompt: Prompt = [
{ type: "file", path: "..\\..\\shared\\util.ts", content: "@..\\..\\shared\\util.ts", start: 0, end: 21 },
]
const result = buildRequestParts({
prompt,
context: [],
images: [],
text: "@..\\..\\shared\\util.ts",
messageID: "msg_dots",
sessionID: "ses_dots",
sessionDirectory: "C:\\projects\\myapp\\src",
})
const filePart = result.requestParts.find((part) => part.type === "file")
expect(filePart).toBeDefined()
if (filePart?.type === "file") {
// Should be valid URL
expect(() => new URL(filePart.url)).not.toThrow()
// Should preserve .. segments (backend normalizes)
expect(filePart.url).toContain("/..")
}
})
})
@@ -0,0 +1,216 @@
import { getFilename } from "@opencode-ai/core/util/path"
import type { AgentPart as MessageAgentPart, FilePart, Part, TextPart } from "@/types"
import type { FileSelection } from "@/context/file"
import { encodeFilePath } from "@/context/file/path"
import type { AgentPart, FileAttachmentPart, ImageAttachmentPart, Prompt } from "@/context/prompt"
import { Identifier } from "@/utils/id"
import { createCommentMetadata, formatCommentNote } from "@/utils/comment-note"
type PromptRequestPart =
| (Omit<TextPart, "id" | "sessionID" | "messageID"> & { id: string })
| (Omit<FilePart, "id" | "sessionID" | "messageID"> & { id: string })
| (Omit<MessageAgentPart, "id" | "sessionID" | "messageID"> & { id: string })
type ContextFile = {
key: string
type: "file"
path: string
selection?: FileSelection
comment?: string
commentID?: string
commentOrigin?: "review" | "file"
preview?: string
}
type BuildRequestPartsInput = {
prompt: Prompt
context: ContextFile[]
images: (Omit<ImageAttachmentPart, "blob"> & { dataUrl: string })[]
text: string
messageID: string
sessionID: string
sessionDirectory: string
}
const absolute = (directory: string, path: string) => {
if (path.startsWith("/")) return path
if (/^[A-Za-z]:[\\/]/.test(path) || /^[A-Za-z]:$/.test(path)) return path
if (path.startsWith("\\\\") || path.startsWith("//")) return path
return `${directory.replace(/[\\/]+$/, "")}/${path}`
}
const fileQuery = (selection: FileSelection | undefined) =>
selection ? `?start=${selection.startLine}&end=${selection.endLine}` : ""
const mention = /(^|[\s([{"'])@(\S+)/g
const parseCommentMentions = (comment: string) => {
return Array.from(comment.matchAll(mention)).flatMap((match) => {
const path = (match[2] ?? "").replace(/[.,!?;:)}\]"']+$/, "")
if (!path) return []
return [path]
})
}
const isFileAttachment = (part: Prompt[number]): part is FileAttachmentPart => part.type === "file"
const isAgentAttachment = (part: Prompt[number]): part is AgentPart => part.type === "agent"
const toOptimisticPart = (part: PromptRequestPart, sessionID: string, messageID: string): Part => {
if (part.type === "text") {
return {
id: part.id,
type: "text",
text: part.text,
synthetic: part.synthetic,
ignored: part.ignored,
time: part.time,
metadata: part.metadata,
sessionID,
messageID,
}
}
if (part.type === "file") {
return {
id: part.id,
type: "file",
mime: part.mime,
filename: part.filename,
url: part.url,
source: part.source,
sessionID,
messageID,
}
}
return {
id: part.id,
type: "agent",
name: part.name,
source: part.source,
sessionID,
messageID,
}
}
export function buildRequestParts(input: BuildRequestPartsInput) {
const requestParts: PromptRequestPart[] = input.text.trim()
? [
{
id: Identifier.ascending("part"),
type: "text",
text: input.text,
},
]
: []
const files = input.prompt.filter(isFileAttachment).map((attachment) => {
const path = absolute(input.sessionDirectory, attachment.path)
const source = attachment.source
? {
...attachment.source,
text: {
value: attachment.content,
start: attachment.start,
end: attachment.end,
},
}
: {
type: "file" as const,
text: {
value: attachment.content,
start: attachment.start,
end: attachment.end,
},
path,
}
return {
id: Identifier.ascending("part"),
type: "file",
mime: attachment.mime ?? "text/plain",
url: attachment.url ?? `file://${encodeFilePath(path)}${fileQuery(attachment.selection)}`,
filename: attachment.filename ?? getFilename(attachment.path),
source,
} satisfies PromptRequestPart
})
const agents = input.prompt.filter(isAgentAttachment).map((attachment) => {
return {
id: Identifier.ascending("part"),
type: "agent",
name: attachment.name,
source: {
value: attachment.content,
start: attachment.start,
end: attachment.end,
},
} satisfies PromptRequestPart
})
const used = new Set(files.map((part) => part.url))
const context = input.context.flatMap((item) => {
const path = absolute(input.sessionDirectory, item.path)
const url = `file://${encodeFilePath(path)}${fileQuery(item.selection)}`
const comment = item.comment?.trim()
if (!comment && used.has(url)) return []
used.add(url)
const filePart = {
id: Identifier.ascending("part"),
type: "file",
mime: "text/plain",
url,
filename: getFilename(item.path),
} satisfies PromptRequestPart
if (!comment) return [filePart]
const mentions = parseCommentMentions(comment).flatMap((path) => {
const url = `file://${encodeFilePath(absolute(input.sessionDirectory, path))}`
if (used.has(url)) return []
used.add(url)
return [
{
id: Identifier.ascending("part"),
type: "file",
mime: "text/plain",
url,
filename: getFilename(path),
} satisfies PromptRequestPart,
]
})
return [
{
id: Identifier.ascending("part"),
type: "text",
text: formatCommentNote({ path: item.path, selection: item.selection, comment }),
synthetic: true,
metadata: createCommentMetadata({
path: item.path,
selection: item.selection,
comment,
preview: item.preview,
origin: item.commentOrigin,
}),
} satisfies PromptRequestPart,
filePart,
...mentions,
]
})
const images = input.images.map((attachment) => {
return {
id: Identifier.ascending("part"),
type: "file",
mime: attachment.mime,
url: attachment.dataUrl,
filename: attachment.sourcePath ?? attachment.filename,
} satisfies PromptRequestPart
})
requestParts.push(...files, ...context, ...agents, ...images)
return {
requestParts,
optimisticParts: requestParts.map((part) => toOptimisticPart(part, input.sessionID, input.messageID)),
}
}
@@ -11,17 +11,15 @@ type SessionCreateInput = {
model?: { id: string; providerID: string; variant?: string } model?: { id: string; providerID: string; variant?: string }
location?: { directory: string } location?: { directory: string }
} }
const admitted: Array<{ const optimistic: Array<{
directory?: string directory?: string
sessionID: string sessionID?: string
messageID: string message: {
text: string agent: string
displayText: string model: { providerID: string; modelID: string }
agent: string variant?: string
model: { providerID: string; modelID: string; variant?: string } }
comments: unknown[]
}> = [] }> = []
const confirmed: unknown[] = []
const storedSessions: Record<string, Array<{ id: string; title?: string }>> = {} const storedSessions: Record<string, Array<{ id: string; title?: string }>> = {}
const sentShell: Array<{ sessionID: string; id?: string; command: string }> = [] const sentShell: Array<{ sessionID: string; id?: string; command: string }> = []
const sentShellDirectories: string[] = [] const sentShellDirectories: string[] = []
@@ -37,11 +35,9 @@ const switchedModels: Array<{
const sessionRequestOrder: string[] = [] const sessionRequestOrder: string[] = []
const updatedDrafts: Array<{ draftID: string; worktree?: string }> = [] const updatedDrafts: Array<{ draftID: string; worktree?: string }> = []
const syncedServers: string[] = [] const syncedServers: string[] = []
const admittedServers: string[] = [] const optimisticServers: string[] = []
const promptCaptures: Array<{ scope?: unknown; target?: unknown }> = [] const promptCaptures: Array<{ scope?: unknown; target?: unknown }> = []
let serverSessionSyncs = 0 let serverSessionSyncs = 0
let restoredPrompts = 0
let clearEchoCalls = 0
let params: { id?: string } = {} let params: { id?: string } = {}
let search: { draftId?: string } = {} let search: { draftId?: string } = {}
@@ -51,8 +47,6 @@ let createSessionGate: Promise<void> | undefined
let createWorktreeGate: Promise<void> | undefined let createWorktreeGate: Promise<void> | undefined
let worktreeFailure: Error | undefined let worktreeFailure: Error | undefined
let locationFailure: Error | undefined let locationFailure: Error | undefined
let promptFailure: Error | undefined
let clearEchoResult = true
let worktreeCreates = 0 let worktreeCreates = 0
let activeSDK = "server-a" let activeSDK = "server-a"
let activeServerSync = "server-a" let activeServerSync = "server-a"
@@ -80,7 +74,7 @@ const prompt = {
set: () => undefined, set: () => undefined,
}, },
reset: () => undefined, reset: () => undefined,
set: () => restoredPrompts++, set: () => undefined,
context: { context: {
add: () => undefined, add: () => undefined,
remove: () => undefined, remove: () => undefined,
@@ -122,16 +116,7 @@ const clientFor = (directory: string) => {
sessionRequestOrder.push("prompt") sessionRequestOrder.push("prompt")
sentPrompts.push(sessionDirectories[(input as { sessionID: string }).sessionID] ?? directory) sentPrompts.push(sessionDirectories[(input as { sessionID: string }).sessionID] ?? directory)
promptInputs.push(input) promptInputs.push(input)
if (promptFailure) throw promptFailure return { data: undefined }
const prompt = input as { sessionID: string; id: string; text: string }
return {
id: prompt.id,
sessionID: prompt.sessionID,
timeCreated: 1,
type: "user" as const,
delivery: "steer" as const,
payload: { text: prompt.text },
}
}, },
switchAgent: async (input: { sessionID: string; agent: string }) => { switchAgent: async (input: { sessionID: string; agent: string }) => {
sessionRequestOrder.push("agent") sessionRequestOrder.push("agent")
@@ -250,27 +235,16 @@ beforeAll(async () => {
return { return {
data: { command: commands, project: "project" }, data: { command: commands, project: "project" },
session: { session: {
inbox: { optimistic: {
echo: (value: { add: (value: {
directory?: string directory?: string
sessionID: string sessionID?: string
messageID: string message: { agent: string; model: { providerID: string; modelID: string; variant?: string } }
text: string
displayText: string
agent: string
model: { providerID: string; modelID: string; variant?: string }
comments: unknown[]
}) => { }) => {
admittedServers.push(server) optimisticServers.push(server)
admitted.push(value) optimistic.push(value)
},
confirm: (value: unknown) => {
confirmed.push(value)
},
clearEcho: () => {
clearEchoCalls++
return clearEchoResult
}, },
remove: () => undefined,
}, },
}, },
set: () => undefined, set: () => undefined,
@@ -330,8 +304,7 @@ beforeAll(async () => {
beforeEach(() => { beforeEach(() => {
createdSessions.length = 0 createdSessions.length = 0
admitted.length = 0 optimistic.length = 0
confirmed.length = 0
promotedDrafts.length = 0 promotedDrafts.length = 0
updatedDrafts.length = 0 updatedDrafts.length = 0
sentCommands.length = 0 sentCommands.length = 0
@@ -341,10 +314,8 @@ beforeEach(() => {
switchedModels.length = 0 switchedModels.length = 0
sessionRequestOrder.length = 0 sessionRequestOrder.length = 0
syncedServers.length = 0 syncedServers.length = 0
admittedServers.length = 0 optimisticServers.length = 0
promptCaptures.length = 0 promptCaptures.length = 0
restoredPrompts = 0
clearEchoCalls = 0
params = {} params = {}
search = {} search = {}
sentShell.length = 0 sentShell.length = 0
@@ -362,8 +333,6 @@ beforeEach(() => {
createWorktreeGate = undefined createWorktreeGate = undefined
worktreeFailure = undefined worktreeFailure = undefined
locationFailure = undefined locationFailure = undefined
promptFailure = undefined
clearEchoResult = true
worktreeCreates = 0 worktreeCreates = 0
for (const key of Object.keys(draftServers)) delete draftServers[key] for (const key of Object.keys(draftServers)) delete draftServers[key]
for (const key of Object.keys(sessionDirectories)) delete sessionDirectories[key] for (const key of Object.keys(sessionDirectories)) delete sessionDirectories[key]
@@ -452,7 +421,7 @@ describe("prompt submit worktree selection", () => {
expect(updatedDrafts).toEqual([{ draftID: "draft-1", worktree: undefined }]) expect(updatedDrafts).toEqual([{ draftID: "draft-1", worktree: undefined }])
expect(promotedDrafts).toEqual([{ draftID: "draft-1", server: "project-server-a", sessionId: "session-1" }]) expect(promotedDrafts).toEqual([{ draftID: "draft-1", server: "project-server-a", sessionId: "session-1" }])
expect(syncedServers.every((server) => server === "server-a")).toBe(true) expect(syncedServers.every((server) => server === "server-a")).toBe(true)
expect(admittedServers).toEqual(["server-a"]) expect(optimisticServers).toEqual(["server-a"])
expect(promptCaptures.at(-1)?.target).toEqual({ server: "project-server-a", scope: ServerScope.local }) expect(promptCaptures.at(-1)?.target).toEqual({ server: "project-server-a", scope: ServerScope.local })
expect(submitted).toBe(0) expect(submitted).toBe(0)
}) })
@@ -472,15 +441,13 @@ describe("prompt submit worktree selection", () => {
await submit.handleSubmit(event) await submit.handleSubmit(event)
await Bun.sleep(0) await Bun.sleep(0)
expect(admitted).toHaveLength(1) expect(optimistic).toHaveLength(1)
expect(admitted[0]).toMatchObject({ expect(optimistic[0]).toMatchObject({
sessionID: "session-1", message: {
text: "ls", agent: "agent",
agent: "agent", model: { providerID: "provider", modelID: "model", variant: "high" },
model: { providerID: "provider", modelID: "model", variant: "high" }, },
}) })
expect(admitted[0]?.messageID).toStartWith("msg_")
expect(confirmed).toMatchObject([{ id: admitted[0]?.messageID, sessionID: "session-1" }])
expect(sentPrompts).toEqual(["/repo/main"]) expect(sentPrompts).toEqual(["/repo/main"])
expect(switchedAgents).toEqual([{ sessionID: "session-1", agent: "agent" }]) expect(switchedAgents).toEqual([{ sessionID: "session-1", agent: "agent" }])
expect(switchedModels).toEqual([ expect(switchedModels).toEqual([
@@ -499,22 +466,6 @@ describe("prompt submit worktree selection", () => {
expect((promptInputs[0] as { id?: string }).id).toStartWith("msg_") expect((promptInputs[0] as { id?: string }).id).toStartWith("msg_")
}) })
test("keeps a confirmed echo when the prompt response is lost", async () => {
params = { id: "session-1" }
promptFailure = new Error("connection lost")
clearEchoResult = false
const submit = makeSubmit({
info: () => ({ id: "session-1", agent: "agent", model: { id: "model", providerID: "provider" } }),
})
await submit.handleSubmit(event)
await settle()
expect(admitted).toHaveLength(1)
expect(clearEchoCalls).toBe(1)
expect(restoredPrompts).toBe(0)
})
test("submits slash commands through the current session API", async () => { test("submits slash commands through the current session API", async () => {
params = { id: "session-1" } params = { id: "session-1" }
variant = "high" variant = "high"
@@ -1,9 +1,10 @@
import type { Message } from "@/types"
import type { SessionInfo } from "@opencode-ai/client/promise" import type { SessionInfo } from "@opencode-ai/client/promise"
import { showToast } from "@/utils/toast" import { showToast } from "@/utils/toast"
import { base64Encode } from "@opencode-ai/core/util/encode" import { base64Encode } from "@opencode-ai/core/util/encode"
import { Binary } from "@opencode-ai/core/util/binary" import { Binary } from "@opencode-ai/core/util/binary"
import { useNavigate, useParams, useSearchParams } from "@solidjs/router" import { useNavigate, useParams, useSearchParams } from "@solidjs/router"
import { startTransition, type Accessor } from "solid-js" import { batch, startTransition, type Accessor } from "solid-js"
import { useTabs } from "@/context/tabs" import { useTabs } from "@/context/tabs"
import { useServerSync, type ServerSync } from "@/context/server-sync" import { useServerSync, type ServerSync } from "@/context/server-sync"
import { useLanguage } from "@/context/language" import { useLanguage } from "@/context/language"
@@ -14,7 +15,7 @@ import { useSDK, type DirectorySDK } from "@/context/sdk"
import { useSync, type DirectorySync } from "@/context/sync" import { useSync, type DirectorySync } from "@/context/sync"
import { Identifier } from "@/utils/id" import { Identifier } from "@/utils/id"
import { getDirectory } from "@opencode-ai/core/util/path" import { getDirectory } from "@opencode-ai/core/util/path"
import { buildPromptRequest } from "./build-prompt-request" import { buildRequestParts } from "./build-request-parts"
import { setCursorPosition } from "./editor-dom" import { setCursorPosition } from "./editor-dom"
import { formatServerError } from "@/utils/server-errors" import { formatServerError } from "@/utils/server-errors"
import { ScopedKey } from "@/utils/server-scope" import { ScopedKey } from "@/utils/server-scope"
@@ -99,22 +100,43 @@ export async function sendFollowupDraft(input: FollowupSendInput) {
dataUrl: await blobDataUrl(attachment.blob, attachment.mime), dataUrl: await blobDataUrl(attachment.blob, attachment.mime),
})), })),
) )
const request = buildPromptRequest({ const { requestParts, optimisticParts } = buildRequestParts({
prompt: input.draft.prompt, prompt: input.draft.prompt,
context: input.draft.context, context: input.draft.context,
images: encodedImages, images: encodedImages,
text, text,
sessionID: input.draft.sessionID,
messageID,
sessionDirectory: input.draft.sessionDirectory, sessionDirectory: input.draft.sessionDirectory,
}) })
setBusy() const message: Message = {
input.sync.session.inbox.echo({ id: messageID,
directory: input.draft.sessionDirectory,
sessionID: input.draft.sessionID, sessionID: input.draft.sessionID,
messageID, role: "user",
time: { created: Date.now() },
agent: input.draft.agent, agent: input.draft.agent,
model: { ...input.draft.model, variant: input.draft.variant }, model: { ...input.draft.model, variant: input.draft.variant },
...request, }
const add = () =>
input.sync.session.optimistic.add({
directory: input.draft.sessionDirectory,
sessionID: input.draft.sessionID,
message,
parts: optimisticParts,
})
const remove = () =>
input.sync.session.optimistic.remove({
directory: input.draft.sessionDirectory,
sessionID: input.draft.sessionID,
messageID,
})
batch(() => {
setBusy()
add()
}) })
try { try {
@@ -137,23 +159,40 @@ export async function sendFollowupDraft(input: FollowupSendInput) {
}) })
} }
const admitted = await input.api.prompt({ await input.api.prompt({
sessionID: input.draft.sessionID, sessionID: input.draft.sessionID,
id: messageID, id: messageID,
text: request.text, text: requestParts.flatMap((part) => (part.type === "text" ? [part.text] : [])).join("\n"),
files: request.files.map((file) => ({ uri: file.uri, name: file.name, mention: file.mention })), files: requestParts.flatMap((part) => {
agents: request.agents, if (part.type !== "file") return []
const text = part.source?.text
return [
{
uri: part.url,
name: part.filename,
mention: text ? { start: text.start, end: text.end, text: text.value } : undefined,
},
]
}),
agents: requestParts.flatMap((part) =>
part.type === "agent"
? [
{
name: part.name,
mention: part.source
? { start: part.source.start, end: part.source.end, text: part.source.value }
: undefined,
},
]
: [],
),
}) })
input.sync.session.inbox.confirm(admitted)
return true return true
} catch (err) { } catch (err) {
const failed = input.sync.session.inbox.clearEcho({ batch(() => {
directory: input.draft.sessionDirectory, setIdle()
sessionID: input.draft.sessionID, remove()
messageID,
}) })
if (!failed) return true
setIdle()
throw err throw err
} }
} }
@@ -499,6 +538,14 @@ export function createPromptSubmit(input: PromptSubmitInput) {
const commentItems = context.filter((item) => item.type === "file" && !!item.comment?.trim()) const commentItems = context.filter((item) => item.type === "file" && !!item.comment?.trim())
const messageID = Identifier.ascending("message") const messageID = Identifier.ascending("message")
const removeOptimisticMessage = () => {
submissionSync.session.optimistic.remove({
directory: sessionDirectory,
sessionID: session.id,
messageID,
})
}
for (const item of commentItems) submission.target().context.remove(item.key) for (const item of commentItems) submission.target().context.remove(item.key)
clearInput() clearInput()
@@ -518,6 +565,7 @@ export function createPromptSubmit(input: PromptSubmitInput) {
title: language.t("prompt.toast.promptSendFailed.title"), title: language.t("prompt.toast.promptSendFailed.title"),
description: errorMessage(err), description: errorMessage(err),
}) })
removeOptimisticMessage()
if (restoreInput()) restoreCommentItems(submission.target(), commentItems) if (restoreInput()) restoreCommentItems(submission.target(), commentItems)
}) })
} finally { } finally {
@@ -119,11 +119,9 @@ export function createProviderConnectionController(options: {
const finish = async () => { const finish = async () => {
cancelPolling() cancelPolling()
const directory = options.directory() const directory = options.directory()
const key = directory ? pathKey(directory) : null await queryClient
await Promise.all([ .refetchQueries(serverSync.queryOptions.providers(directory ? pathKey(directory) : null))
queryClient.refetchQueries(serverSync.queryOptions.providers(key)).catch(() => undefined), .catch(() => undefined)
queryClient.refetchQueries(serverSync.queryOptions.integrations(key)).catch(() => undefined),
])
if (polling.disposed) return if (polling.disposed) return
options.onComplete() options.onComplete()
} }
@@ -4,7 +4,6 @@ import { useDialog } from "@opencode-ai/ui/context/dialog"
import { ProviderIcon } from "@opencode-ai/ui/provider-icon" import { ProviderIcon } from "@opencode-ai/ui/provider-icon"
import { showToast } from "@/utils/toast" import { showToast } from "@/utils/toast"
import { popularProviders, useProviders } from "@/hooks/use-providers" import { popularProviders, useProviders } from "@/hooks/use-providers"
import { useIntegrations } from "@/hooks/use-integrations"
import { createMemo, type Component, For, Show } from "solid-js" import { createMemo, type Component, For, Show } from "solid-js"
import { useLanguage } from "@/context/language" import { useLanguage } from "@/context/language"
import { useServerSDK } from "@/context/server-sdk" import { useServerSDK } from "@/context/server-sdk"
@@ -41,9 +40,7 @@ export const SettingsProvidersV2: Component<{
const serverSdk = useServerSDK() const serverSdk = useServerSDK()
const serverSync = useServerSync() const serverSync = useServerSync()
const providers = useProviders(() => props.directory) const providers = useProviders(() => props.directory)
const integrations = useIntegrations(() => props.directory)
const providerConnect = useProviderConnectController({ onBack: props.onBack }) const providerConnect = useProviderConnectController({ onBack: props.onBack })
const integration = (providerID: string) => integrations.list().find((item) => item.id === providerID)
const connect = (provider?: string) => { const connect = (provider?: string) => {
providerConnect.select(provider) providerConnect.select(provider)
@@ -76,14 +73,7 @@ export const SettingsProvidersV2: Component<{
return items return items
}) })
// Connection state comes from the integration list like the TUI: credential
// connections mean an API key or OAuth grant, env connections mean detected
// environment variables, and a connectionless integration is config-provided.
const source = (item: ProviderItem): ProviderSource | undefined => { const source = (item: ProviderItem): ProviderSource | undefined => {
const current = integration(item.id)
if (current?.connections.some((connection) => connection.type === "credential")) return "api"
if (current?.connections.some((connection) => connection.type === "env")) return "env"
if (current) return "config"
if (!("source" in item)) return if (!("source" in item)) return
const value = item.source const value = item.source
if (value === "env" || value === "api" || value === "config" || value === "custom") return value if (value === "env" || value === "api" || value === "config" || value === "custom") return value
@@ -102,11 +92,7 @@ export const SettingsProvidersV2: Component<{
return language.t("settings.providers.tag.other") return language.t("settings.providers.tag.other")
} }
const canDisconnect = (item: ProviderItem) => { const canDisconnect = (item: ProviderItem) => source(item) !== "env" && !isConfigCustom(item.id)
const current = integration(item.id)
if (current) return current.connections.some((connection) => connection.type === "credential")
return source(item) !== "env" && !isConfigCustom(item.id)
}
const note = (id: string) => PROVIDER_NOTES.find((item) => item.match(id))?.key const note = (id: string) => PROVIDER_NOTES.find((item) => item.match(id))?.key
@@ -68,8 +68,7 @@
display: none; display: none;
} }
[data-titlebar-tab][data-title-overflow="true"]:not([data-editing="true"]) [data-slot="tab-link"], [data-titlebar-tab][data-title-overflow="true"]:not([data-editing="true"]) [data-slot="tab-link"] {
[data-titlebar-tab]:is(:hover, [data-active="true"]):not([data-editing="true"]) [data-slot="tab-link"] {
--tab-title-fade-offset: 4px; --tab-title-fade-offset: 4px;
-webkit-mask-image: linear-gradient( -webkit-mask-image: linear-gradient(
to right, to right,
@@ -87,8 +86,7 @@
); );
} }
[data-titlebar-tab][data-title-overflow="true"]:not([data-editing="true"]):dir(rtl) [data-slot="tab-link"], [data-titlebar-tab][data-title-overflow="true"]:not([data-editing="true"]):dir(rtl) [data-slot="tab-link"] {
[data-titlebar-tab]:is(:hover, [data-active="true"]):not([data-editing="true"]):dir(rtl) [data-slot="tab-link"] {
-webkit-mask-image: linear-gradient( -webkit-mask-image: linear-gradient(
to left, to left,
black 0, black 0,
@@ -105,7 +103,8 @@
); );
} }
[data-titlebar-tab]:is(:hover, [data-active="true"]):not([data-editing="true"]) [data-slot="tab-link"] { [data-titlebar-tab][data-title-overflow="true"]:is(:hover, [data-active="true"]):not([data-editing="true"])
[data-slot="tab-link"] {
--tab-title-fade-offset: 24px; --tab-title-fade-offset: 24px;
} }
+28 -10
View File
@@ -1,10 +1,10 @@
import { Binary } from "@opencode-ai/core/util/binary" import { Binary } from "@opencode-ai/core/util/binary"
import type { SessionInboxInfo, SessionInfo } from "@opencode-ai/client/promise" import type { Message, Part } from "@/types"
import type { SessionInfo } from "@opencode-ai/client/promise"
import { createMemo } from "solid-js" import { createMemo } from "solid-js"
import { produce, reconcile, type SetStoreFunction } from "solid-js/store" import { produce, reconcile, type SetStoreFunction } from "solid-js/store"
import type { createServerSdkContext } from "./server-sdk" import type { createServerSdkContext } from "./server-sdk"
import type { createServerSyncContextInner } from "./server-sync" import type { createServerSyncContextInner } from "./server-sync"
import type { PromptEcho } from "./server-session"
import type { State } from "./global-sync/types" import type { State } from "./global-sync/types"
const cmp = (a: string, b: string) => (a < b ? -1 : a > b ? 1 : 0) const cmp = (a: string, b: string) => (a < b ? -1 : a > b ? 1 : 0)
@@ -82,17 +82,35 @@ export const createDirSyncContext = (
const session = serverSync.session.get(sessionID) const session = serverSync.session.get(sessionID)
if (session?.location.directory === directory) return session if (session?.location.directory === directory) return session
}, },
inbox: { optimistic: {
echo(input: PromptEcho & { directory?: string }) { add(input: { directory?: string; sessionID: string; message: Message; parts: Part[] }) {
serverSync.session.inbox.echo(input) serverSync.session.optimistic.add(input)
}, },
confirm(input: SessionInboxInfo) { remove(input: { directory?: string; sessionID: string; messageID: string }) {
return serverSync.session.inbox.confirm(input) serverSync.session.optimistic.remove(input)
},
clearEcho(input: { directory?: string; sessionID: string; messageID: string }) {
return serverSync.session.inbox.clearEcho(input)
}, },
}, },
addOptimisticMessage(input: {
sessionID: string
messageID: string
parts: Part[]
agent: string
model: { providerID: string; modelID: string }
variant?: string
}) {
serverSync.session.optimistic.add({
sessionID: input.sessionID,
message: {
id: input.messageID,
sessionID: input.sessionID,
role: "user",
time: { created: Date.now() },
agent: input.agent,
model: { ...input.model, variant: input.variant },
},
parts: input.parts,
})
},
async sync(sessionID: string, options?: { force?: boolean }) { async sync(sessionID: string, options?: { force?: boolean }) {
await serverSync.session.sync(sessionID, options) await serverSync.session.sync(sessionID, options)
index(sessionID) index(sessionID)
+1 -1
View File
@@ -143,7 +143,7 @@ describe("encodeFilePath", () => {
}) })
test("should handle mixed separator path (Windows + Unix)", () => { test("should handle mixed separator path (Windows + Unix)", () => {
// This is what happens in build-prompt-request.ts when concatenating paths // This is what happens in build-request-parts.ts when concatenating paths
const mixedPath = "D:\\dev\\projects\\opencode/README.bs.md" const mixedPath = "D:\\dev\\projects\\opencode/README.bs.md"
const result = encodeFilePath(mixedPath) const result = encodeFilePath(mixedPath)
const fileUrl = `file://${result}` const fileUrl = `file://${result}`
+1 -2
View File
@@ -287,8 +287,7 @@ export function createServerNotificationState(input: { sdk: ServerSDK; sync: Ser
) )
return return
const directory = event.current?.location?.directory const directory = e.name
if (!directory) return
const time = Date.now() const time = Date.now()
if (event.type === "session.execution.failed") { if (event.type === "session.execution.failed") {
handleSessionError(directory, event, time) handleSessionError(directory, event, time)
+1 -1
View File
@@ -194,7 +194,7 @@ export function createServerPermissionState(input: { sdk: ServerSDK; sync: Serve
const handlePermission = (e: PermissionEvent) => { const handlePermission = (e: PermissionEvent) => {
const event = e.details const event = e.details
if (event?.type !== "permission.asked") return if (event?.type !== "permission.asked") return
void respondPending(event.properties, event.current?.location?.directory) void respondPending(event.properties, e.name)
} }
const unsubscribe = input.sdk.event.listen((event) => { const unsubscribe = input.sdk.event.listen((event) => {
+21 -12
View File
@@ -1,6 +1,6 @@
import { describe, expect, test } from "bun:test" import { describe, expect, test } from "bun:test"
import type { OpenCodeEvent } from "@opencode-ai/client/promise" import type { OpenCodeEvent } from "@opencode-ai/client/promise"
import { adaptServerEvent, coalesceServerEvents, resumeStreamAfterPageShow } from "./server-sdk" import { adaptServerEvent, coalesceServerEvents, enqueueServerEvent, resumeStreamAfterPageShow } from "./server-sdk"
describe("resumeStreamAfterPageShow", () => { describe("resumeStreamAfterPageShow", () => {
test("restarts a stream only after a back-forward cache restore", () => { test("restarts a stream only after a back-forward cache restore", () => {
@@ -45,21 +45,23 @@ describe("adaptServerEvent", () => {
}) })
describe("current event buffering", () => { describe("current event buffering", () => {
const delta = (id: string, value: string, ordinal = 0) => const delta = (id: string, value: string, ordinal = 0) => ({
adaptServerEvent({ directory: "/repo",
payload: adaptServerEvent({
id, id,
created: 1, created: 1,
type: "session.text.delta", type: "session.text.delta",
location: { directory: "/repo" }, location: { directory: "/repo" },
data: { sessionID: "ses", assistantMessageID: "msg", ordinal, delta: value }, data: { sessionID: "ses", assistantMessageID: "msg", ordinal, delta: value },
} as OpenCodeEvent) } as OpenCodeEvent),
})
test("merges adjacent text deltas for the same message and ordinal", () => { test("merges adjacent text deltas for the same message and ordinal", () => {
const result = coalesceServerEvents([delta("evt_1", "hello "), delta("evt_2", "world")]) const result = coalesceServerEvents([delta("evt_1", "hello "), delta("evt_2", "world")])
expect(result).toHaveLength(1) expect(result).toHaveLength(1)
expect(result[0]?.current).toMatchObject({ id: "evt_2", data: { delta: "hello world" } }) expect(result[0]?.payload.current).toMatchObject({ id: "evt_2", data: { delta: "hello world" } })
expect(result[0]?.properties).toMatchObject({ delta: "hello world" }) expect(result[0]?.payload.properties).toMatchObject({ delta: "hello world" })
}) })
test("coalesces current tool input deltas by tool ID", () => { test("coalesces current tool input deltas by tool ID", () => {
@@ -72,19 +74,26 @@ describe("current event buffering", () => {
data: { sessionID: "ses", assistantMessageID: "msg", id, delta }, data: { sessionID: "ses", assistantMessageID: "msg", id, delta },
} as OpenCodeEvent) } as OpenCodeEvent)
const result = coalesceServerEvents([ const result = coalesceServerEvents([
current("evt_1", "call_1", "{"), { directory: "/repo", payload: current("evt_1", "call_1", "{") },
current("evt_2", "call_1", "}"), { directory: "/repo", payload: current("evt_2", "call_1", "}") },
current("evt_3", "call_2", "[]"), { directory: "/repo", payload: current("evt_3", "call_2", "[]") },
]) ])
expect(result).toHaveLength(2) expect(result).toHaveLength(2)
expect(result[0]?.current).toMatchObject({ id: "evt_2", data: { id: "call_1", delta: "{}" } }) expect(result[0]?.payload.current).toMatchObject({ id: "evt_2", data: { id: "call_1", delta: "{}" } })
expect(result[1]?.current).toMatchObject({ id: "evt_3", data: { id: "call_2", delta: "[]" } }) expect(result[1]?.payload.current).toMatchObject({ id: "evt_3", data: { id: "call_2", delta: "[]" } })
}) })
test("preserves boundaries between distinct delta streams", () => { test("preserves boundaries between distinct delta streams", () => {
const events = [delta("evt_1", "a"), delta("evt_2", "b", 1), delta("evt_3", "c")] const events = [delta("evt_1", "a"), delta("evt_2", "b", 1), delta("evt_3", "c")]
expect(coalesceServerEvents(events).map((event) => event.current?.id)).toEqual(["evt_1", "evt_2", "evt_3"]) expect(coalesceServerEvents(events).map((event) => event.payload.current?.id)).toEqual(["evt_1", "evt_2", "evt_3"])
})
test("preserves current event order when enqueuing", () => {
const events: Parameters<typeof enqueueServerEvent>[0] = []
;[delta("evt_1", "a"), delta("evt_2", "b", 1)].forEach((event) => enqueueServerEvent(events, event))
expect(events.map((event) => event.payload.current?.id)).toEqual(["evt_1", "evt_2"])
}) })
}) })
+29 -31
View File
@@ -12,7 +12,7 @@ import { ServerScope } from "@/utils/server-scope"
import { useServer } from "./server" import { useServer } from "./server"
export type ServerEvent = Event & { id?: string; current?: OpenCodeEvent } export type ServerEvent = Event & { id?: string; current?: OpenCodeEvent }
type ServerEventMap = { [Type in ServerEvent["type"]]: Extract<ServerEvent, { type: Type }> } type QueuedServerEvent = { directory: string; payload: ServerEvent }
type CurrentDelta = Extract< type CurrentDelta = Extract<
OpenCodeEvent, OpenCodeEvent,
{ type: "session.text.delta" | "session.reasoning.delta" | "session.tool.input.delta" | "session.compaction.delta" } { type: "session.text.delta" | "session.reasoning.delta" | "session.tool.input.delta" | "session.compaction.delta" }
@@ -22,17 +22,22 @@ export function adaptServerEvent(event: OpenCodeEvent): ServerEvent {
return { id: event.id, type: event.type, properties: event.data, current: event } as ServerEvent return { id: event.id, type: event.type, properties: event.data, current: event } as ServerEvent
} }
export function coalesceServerEvents(events: ServerEvent[]) { export function enqueueServerEvent(queue: QueuedServerEvent[], event: QueuedServerEvent) {
const output: ServerEvent[] = [] queue.push(event)
return true
}
export function coalesceServerEvents(events: QueuedServerEvent[]) {
const output: QueuedServerEvent[] = []
events.forEach((event) => { events.forEach((event) => {
const current = currentDelta(event.current) const current = currentDelta(event.payload.current)
if (current) { if (current) {
const previous = output[output.length - 1] const previous = output[output.length - 1]
const prior = currentDelta(previous?.current) const prior = currentDelta(previous?.payload.current)
if ( if (
previous && previous &&
prior && prior &&
prior.location?.directory === current.location?.directory && previous.directory === event.directory &&
currentDeltaKey(prior) === currentDeltaKey(current) currentDeltaKey(prior) === currentDeltaKey(current)
) { ) {
const fragment = currentDeltaFragment(prior) + currentDeltaFragment(current) const fragment = currentDeltaFragment(prior) + currentDeltaFragment(current)
@@ -41,10 +46,13 @@ export function coalesceServerEvents(events: ServerEvent[]) {
? { ...current.data, text: fragment } ? { ...current.data, text: fragment }
: { ...current.data, delta: fragment } : { ...current.data, delta: fragment }
output[output.length - 1] = { output[output.length - 1] = {
...event, directory: event.directory,
properties: data, payload: {
current: { ...current, data } as CurrentDelta, ...event.payload,
} as ServerEvent properties: data,
current: { ...current, data } as CurrentDelta,
} as ServerEvent,
}
return return
} }
output.push(event) output.push(event)
@@ -81,8 +89,7 @@ export function resumeStreamAfterPageShow(event: PageTransitionEvent, start: ()
start() start()
} }
type ServerEventEmitter = ReturnType<typeof createGlobalEmitter<ServerEventMap>> type ServerEventEmitter = ReturnType<typeof createGlobalEmitter<{ [key: string]: ServerEvent }>>
type ServerLocationEventEmitter = ReturnType<typeof createGlobalEmitter<{ [directory: string]: ServerEvent }>>
export type ServerConnectionStatus = "connecting" | "connected" | "reconnecting" export type ServerConnectionStatus = "connecting" | "connected" | "reconnecting"
type ServerSDKBase = { type ServerSDKBase = {
server: ServerConnection.Any server: ServerConnection.Any
@@ -97,9 +104,6 @@ type ServerSDKBase = {
event: { event: {
on: ServerEventEmitter["on"] on: ServerEventEmitter["on"]
listen: ServerEventEmitter["listen"] listen: ServerEventEmitter["listen"]
location: {
on: ServerLocationEventEmitter["on"]
}
} }
} }
@@ -119,16 +123,18 @@ function createServerSdkContextBase(server: ServerConnection.Any, scope: ServerS
})() })()
const eventApi = createApiForServer({ server: server.http, fetch: eventFetch }) const eventApi = createApiForServer({ server: server.http, fetch: eventFetch })
const emitter = createGlobalEmitter<ServerEventMap>() const emitter = createGlobalEmitter<{
const locations = createGlobalEmitter<{ [directory: string]: ServerEvent }>() [key: string]: ServerEvent
}>()
type Queued = QueuedServerEvent
const FLUSH_FRAME_MS = 16 const FLUSH_FRAME_MS = 16
const STREAM_YIELD_MS = 8 const STREAM_YIELD_MS = 8
const CONNECT_TIMEOUT_MS = 2_000 const CONNECT_TIMEOUT_MS = 2_000
const RECONNECT_DELAY_MS = 1_000 const RECONNECT_DELAY_MS = 1_000
let queue: ServerEvent[] = [] let queue: Queued[] = []
let buffer: ServerEvent[] = [] let buffer: Queued[] = []
let timer: ReturnType<typeof setTimeout> | undefined let timer: ReturnType<typeof setTimeout> | undefined
let last = 0 let last = 0
@@ -146,11 +152,7 @@ function createServerSdkContextBase(server: ServerConnection.Any, scope: ServerS
last = Date.now() last = Date.now()
const output = coalesceServerEvents(events) const output = coalesceServerEvents(events)
batch(() => { batch(() => {
output.forEach((event) => { output.forEach((event) => emitter.emit(event.directory, event.payload))
emitter.emit(event.type, event)
const directory = event.current?.location?.directory
if (directory) locations.emit(directory, event)
})
}) })
buffer.length = 0 buffer.length = 0
@@ -163,8 +165,8 @@ function createServerSdkContextBase(server: ServerConnection.Any, scope: ServerS
} }
function publish(event: OpenCodeEvent) { function publish(event: OpenCodeEvent) {
queue.push(adaptServerEvent(event)) const directory = event.location?.directory ?? "global"
schedule() if (enqueueServerEvent(queue, { directory, payload: adaptServerEvent(event) })) schedule()
} }
function wait(delay: number, signal: AbortSignal) { function wait(delay: number, signal: AbortSignal) {
@@ -311,7 +313,6 @@ function createServerSdkContextBase(server: ServerConnection.Any, scope: ServerS
queue = [] queue = []
buffer = [] buffer = []
emitter.clear() emitter.clear()
locations.clear()
}) })
const api = createApiForServer({ server: server.http, fetch: platform.fetch }) const api = createApiForServer({ server: server.http, fetch: platform.fetch })
@@ -329,9 +330,6 @@ function createServerSdkContextBase(server: ServerConnection.Any, scope: ServerS
event: { event: {
on: emitter.on.bind(emitter), on: emitter.on.bind(emitter),
listen: emitter.listen.bind(emitter), listen: emitter.listen.bind(emitter),
location: {
on: locations.on.bind(locations),
},
}, },
} }
} }
@@ -367,7 +365,7 @@ export type DirectorySDK = {
function createDirSdkContext(directory: string, serverSDK: ServerSDKBase): DirectorySDK { function createDirSdkContext(directory: string, serverSDK: ServerSDKBase): DirectorySDK {
const emitter = createGlobalEmitter<SDKEventMap>() const emitter = createGlobalEmitter<SDKEventMap>()
const unsub = serverSDK.event.location.on(directory, (event) => { const unsub = serverSDK.event.on(directory, (event) => {
emitter.emit(event.type, event) emitter.emit(event.type, event)
}) })
onCleanup(unsub) onCleanup(unsub)
@@ -6,32 +6,6 @@ const event = (input: object) => input as OpenCodeEvent
const base = { created: 1, location: { directory: "/repo" }, durable: { aggregateID: "ses_1", seq: 1, version: 1 } } const base = { created: 1, location: { directory: "/repo" }, durable: { aggregateID: "ses_1", seq: 1, version: 1 } }
describe("v2 session reducer", () => { describe("v2 session reducer", () => {
test("moves a repeated inbox payload to the current event position", () => {
const reducer = createV2SessionReducer()
const result = reducer.reduce(
[
{ id: "msg_user", type: "user", text: "local", time: { created: 0 } },
{ id: "msg_agent", type: "agent-switched", agent: "review", time: { created: 1 } },
],
event({
...base,
id: "evt_admitted",
type: "session.inbox.enqueued",
data: {
sessionID: "ses_1",
inboxID: "msg_user",
item: { type: "user", delivery: "steer", payload: { text: "durable" } },
},
}),
)
expect(result?.messages).toEqual([
{ id: "msg_agent", type: "agent-switched", agent: "review", time: { created: 1 } },
{ id: "msg_user", type: "user", text: "durable", time: { created: 1 } },
])
expect(result?.touched).toEqual(["msg_user"])
})
test("projects promoted input and streaming assistant content", () => { test("projects promoted input and streaming assistant content", () => {
const reducer = createV2SessionReducer() const reducer = createV2SessionReducer()
let messages: SessionMessageInfo[] = [] let messages: SessionMessageInfo[] = []
@@ -1,10 +1,4 @@
import type { import type { OpenCodeEvent, SessionInboxItem, SessionInfo, SessionMessageInfo } from "@opencode-ai/client/promise"
OpenCodeEvent,
SessionInboxInfo,
SessionInboxItem,
SessionInfo,
SessionMessageInfo,
} from "@opencode-ai/client/promise"
type Assistant = Extract<SessionMessageInfo, { type: "assistant" }> type Assistant = Extract<SessionMessageInfo, { type: "assistant" }>
type Compaction = Extract<SessionMessageInfo, { type: "compaction" }> type Compaction = Extract<SessionMessageInfo, { type: "compaction" }>
@@ -35,14 +29,12 @@ export function createV2SessionReducer() {
}) })
const append = (message: SessionMessageInfo) => const append = (message: SessionMessageInfo) =>
result(source.some((item) => item.id === message.id) ? [...source] : [...source, message], [message.id]) result(source.some((item) => item.id === message.id) ? [...source] : [...source, message], [message.id])
const replace = (message: SessionMessageInfo) =>
result([...source.filter((item) => item.id !== message.id), message], [message.id])
switch (event.type) { switch (event.type) {
case "session.inbox.enqueued": case "session.inbox.enqueued":
pending.set(key(sessionID, event.data.inboxID), event.data.item) pending.set(key(sessionID, event.data.inboxID), event.data.item)
if (event.data.item.type === "user") if (event.data.item.type === "user")
return replace({ return append({
id: event.data.inboxID, id: event.data.inboxID,
type: "user", type: "user",
metadata: event.data.item.payload.metadata, metadata: event.data.item.payload.metadata,
@@ -52,7 +44,7 @@ export function createV2SessionReducer() {
time: { created: event.created }, time: { created: event.created },
}) })
if (event.data.item.type !== "synthetic") return result([...source]) if (event.data.item.type !== "synthetic") return result([...source])
return replace({ return append({
id: event.data.inboxID, id: event.data.inboxID,
type: "synthetic", type: "synthetic",
metadata: event.data.item.payload.metadata, metadata: event.data.item.payload.metadata,
@@ -488,9 +480,6 @@ export function createV2SessionReducer() {
return { return {
reduce, reduce,
confirm(item: SessionInboxInfo) {
pending.set(key(item.sessionID, item.id), item)
},
clear(sessionID: string) { clear(sessionID: string) {
for (const id of pending.keys()) { for (const id of pending.keys()) {
if (id.startsWith(`${sessionID}:`)) pending.delete(id) if (id.startsWith(`${sessionID}:`)) pending.delete(id)
+250 -412
View File
@@ -185,16 +185,6 @@ const textPart = (messageID: string, input: Partial<TextPart> = {}): TextPart =>
id: `${messageID}:text:${input.id === "pending" ? 1 : 0}`, id: `${messageID}:text:${input.id === "pending" ? 1 : 0}`,
}) })
const promptEcho = (messageID: string, text = "hello") => ({
sessionID: "child",
messageID,
text,
displayText: text,
agent: "build",
model: { providerID: "provider", modelID: "model" },
comments: [],
})
const response = (data: MessageResponse["data"] = [], cursor?: string): MessageResponse => ({ const response = (data: MessageResponse["data"] = [], cursor?: string): MessageResponse => ({
data, data,
response: { headers: new Headers(cursor ? { "x-next-cursor": cursor } : undefined) }, response: { headers: new Headers(cursor ? { "x-next-cursor": cursor } : undefined) },
@@ -309,26 +299,6 @@ function setup(sessions: Record<string, SessionInfo>) {
} }
describe("server session", () => { describe("server session", () => {
test("hydrates session info after a native session.created event", async () => {
const ctx = setup({ created: session("created") })
ctx.store.apply({
type: "session.created",
properties: {
sessionID: "created",
projectID: "project",
location: { directory: "/repo" },
slug: "created",
version: "test",
},
})
expect(ctx.store.get("created")).toBeUndefined()
await ctx.store.resolve("created")
expect(ctx.store.get("created")?.location.directory).toBe("/repo")
expect(ctx.get).toEqual([{ sessionID: "created" }])
})
test("projects V2 session events into current and legacy message state", () => { test("projects V2 session events into current and legacy message state", () => {
const ctx = setup({ child: session("child") }) const ctx = setup({ child: session("child") })
ctx.store.remember(session("child")) ctx.store.remember(session("child"))
@@ -370,38 +340,14 @@ describe("server session", () => {
location: { directory: "/repo" }, location: { directory: "/repo" },
data: { sessionID: "child", assistantMessageID: "msg_2_assistant", ordinal: 0, delta: "world" }, data: { sessionID: "child", assistantMessageID: "msg_2_assistant", ordinal: 0, delta: "world" },
}) })
apply({
id: "evt_tool_z",
created: 5,
type: "session.tool.input.started",
durable: { aggregateID: "child", seq: 3, version: 1 },
location: { directory: "/repo" },
data: { sessionID: "child", assistantMessageID: "msg_2_assistant", id: "call_z", name: "shell" },
})
apply({
id: "evt_tool_a",
created: 6,
type: "session.tool.input.started",
durable: { aggregateID: "child", seq: 4, version: 1 },
location: { directory: "/repo" },
data: { sessionID: "child", assistantMessageID: "msg_2_assistant", id: "call_a", name: "shell" },
})
expect(ctx.store.data.session_message.child?.at(-1)).toMatchObject({ expect(ctx.store.data.session_message.child?.at(-1)).toMatchObject({
id: "msg_2_assistant", id: "msg_2_assistant",
type: "assistant", type: "assistant",
content: [ content: [{ type: "text", text: "world" }],
{ type: "text", text: "world" },
{ type: "tool", id: "call_z" },
{ type: "tool", id: "call_a" },
],
}) })
expect(ctx.store.data.message.child?.map((message) => message.id)).toEqual(["msg_1_user", "msg_2_assistant"]) expect(ctx.store.data.message.child?.map((message) => message.id)).toEqual(["msg_1_user", "msg_2_assistant"])
expect(ctx.store.data.part.msg_2_assistant?.map((part) => part.id)).toEqual([ expect(ctx.store.data.part.msg_2_assistant).toMatchObject([{ type: "text", text: "world" }])
"msg_2_assistant:text:0",
"call_z",
"call_a",
])
}) })
test("projects V2 pending inputs and forms", () => { test("projects V2 pending inputs and forms", () => {
@@ -618,7 +564,7 @@ describe("server session", () => {
await ctx.store.sync("root") await ctx.store.sync("root")
expect(ctx.get).toEqual([{ sessionID: "root" }]) expect(ctx.get).toEqual([{ sessionID: "root" }])
expect(ctx.messages).toEqual([{ sessionID: "root", limit: 200, order: "desc" }]) expect(ctx.messages).toEqual([{ sessionID: "root", limit: 20, order: "desc" }])
expect(ctx.store.data.message.root).toEqual([]) expect(ctx.store.data.message.root).toEqual([])
}) })
@@ -629,32 +575,8 @@ describe("server session", () => {
ctx.store.invalidate() ctx.store.invalidate()
await ctx.store.sync("root") await ctx.store.sync("root")
expect(ctx.store.data.message.root).toEqual([])
expect(ctx.get).toHaveLength(2) expect(ctx.get).toHaveLength(2)
expect(ctx.messages).toEqual([ expect(ctx.messages).toHaveLength(2)
{ sessionID: "root", limit: 200, order: "desc" },
{ sessionID: "root", limit: 200, order: "desc" },
])
})
test("keeps a fixed page size after the local message cache exceeds the API limit", async () => {
const client = messageClient(response(), response())
const store = createServerSession(client)
await store.sync("child")
Array.from({ length: 428 }, (_, index) =>
store.apply({
type: "message.updated",
properties: { info: userMessage(`message-${index}`, { time: { created: index } }) },
}),
)
expect(store.data.message.child).toHaveLength(428)
await store.sync("child", { force: true })
expect(client.requests).toEqual([
{ sessionID: "child", limit: 200, order: "desc" },
{ sessionID: "child", limit: 200, order: "desc" },
])
}) })
test("loads current session content through the current message API", async () => { test("loads current session content through the current message API", async () => {
@@ -679,50 +601,11 @@ describe("server session", () => {
await store.sync("root") await store.sync("root")
expect(requests).toEqual([{ sessionID: "root", limit: 200, order: "desc" }]) expect(requests).toEqual([{ sessionID: "root", limit: 20, order: "desc" }])
expect(store.data.session_message.root.map((message) => message.id)).toEqual([user.id, assistant.id]) expect(store.data.session_message.root.map((message) => message.id)).toEqual([user.id, assistant.id])
expect(store.data.message.root.map((message) => message.id)).toEqual([user.id, assistant.id]) expect(store.data.message.root.map((message) => message.id)).toEqual([user.id, assistant.id])
}) })
test("preserves assistant content order from message history", async () => {
const source = [
{ id: "msg_user", type: "user", text: "inspect it", time: { created: 1 } },
{
id: "msg_assistant",
type: "assistant",
agent: "build",
model: { id: "model", providerID: "provider" },
content: [
{ type: "text", text: "I will inspect it." },
{
type: "tool",
id: "call_z",
name: "shell",
state: { status: "streaming", input: "" },
time: { created: 2 },
},
{
type: "tool",
id: "call_a",
name: "shell",
state: { status: "streaming", input: "" },
time: { created: 3 },
},
],
time: { created: 2 },
},
] satisfies SessionMessageInfo[]
const messageApi = {
list: async () => ({ data: source.toReversed(), cursor: { previous: null, next: null } }),
} as unknown as MessageApi
const store = createServerSession({} as SessionApi, messageApi)
store.remember(session("root"))
await store.sync("root")
expect(store.data.part.msg_assistant?.map((part) => part.id)).toEqual(["msg_assistant:text:0", "call_z", "call_a"])
})
test("extends a current page to include the user for split assistant turns", async () => { test("extends a current page to include the user for split assistant turns", async () => {
const user = { id: "msg_1_user", type: "user", text: "hello", time: { created: 1 } } as const const user = { id: "msg_1_user", type: "user", text: "hello", time: { created: 1 } } as const
const assistant = (id: string, created: number) => ({ const assistant = (id: string, created: number) => ({
@@ -755,8 +638,8 @@ describe("server session", () => {
await store.sync("root") await store.sync("root")
expect(requests).toEqual([ expect(requests).toEqual([
{ sessionID: "root", limit: 200, order: "desc" }, { sessionID: "root", limit: 20, order: "desc" },
{ sessionID: "root", limit: 200, cursor: "older" }, { sessionID: "root", limit: 20, cursor: "older" },
]) ])
expect(store.data.message.root.map((message) => message.id)).toEqual([ expect(store.data.message.root.map((message) => message.id)).toEqual([
user.id, user.id,
@@ -765,26 +648,6 @@ describe("server session", () => {
expect(assistants.map((item) => store.data.part[item.id]?.[0]?.type)).toEqual(["text", "text", "text"]) expect(assistants.map((item) => store.data.part[item.id]?.[0]?.type)).toEqual(["text", "text", "text"])
}) })
test("loads older messages by cursor with the fixed page size", async () => {
const older = userMessage("message-1")
const latest = userMessage("message-2", { time: { created: 2 } })
const client = messageClient(
response([{ info: latest, parts: [] }], "older"),
response([{ info: older, parts: [] }]),
)
const store = createServerSession(client)
await store.sync("child")
await store.history.loadMore("child")
expect(client.requests).toEqual([
{ sessionID: "child", limit: 200, order: "desc" },
{ sessionID: "child", limit: 200, cursor: "older" },
])
expect(store.data.message.child).toEqual([older, latest])
expect(store.history.more("child")).toBe(false)
})
// V2 messages are ordered projections and do not expose V1 assistant parent IDs. // V2 messages are ordered projections and do not expose V1 assistant parent IDs.
describe.skip("V1 assistant parent projections", () => { describe.skip("V1 assistant parent projections", () => {
test("backfills an assistant-only initial page through its user root", async () => { test("backfills an assistant-only initial page through its user root", async () => {
@@ -798,7 +661,7 @@ describe("server session", () => {
await store.sync("child") await store.sync("child")
expect(client.requests).toEqual([{ sessionID: "child", limit: 200, order: "desc" }]) expect(client.requests).toEqual([{ sessionID: "child", limit: 20, order: "desc" }])
expect(client.rootRequests).toEqual([{ sessionID: "child", messageID: user.id }]) expect(client.rootRequests).toEqual([{ sessionID: "child", messageID: user.id }])
expect(store.data.message.child).toEqual([user, ...assistants]) expect(store.data.message.child).toEqual([user, ...assistants])
expect(store.history.more("child")).toBe(false) expect(store.history.more("child")).toBe(false)
@@ -847,17 +710,19 @@ describe("server session", () => {
expect(store.data.part[parent.id]).toBeUndefined() expect(store.data.part[parent.id]).toBeUndefined()
}) })
test("does not let an admitted user suppress initial root backfill", async () => { test("does not let an optimistic user suppress initial root backfill", async () => {
const user = userMessage("message-1") const user = userMessage("message-1")
const part = textPart(user.id)
const assistants = [assistantMessage("message-2", user.id), assistantMessage("message-3", user.id)] const assistants = [assistantMessage("message-2", user.id), assistantMessage("message-3", user.id)]
const client = rootMessageClient( const client = rootMessageClient(
[response(assistants.map((info) => ({ info, parts: [] })))], [response(assistants.map((info) => ({ info, parts: [] })))],
[singleResponse(user)], [singleResponse(user)],
) )
const store = createServerSession(client) const store = createServerSession(client)
store.inbox.echo(promptEcho(user.id, "text")) store.optimistic.add({ sessionID: "child", message: user, parts: [part] })
await store.sync("child") await store.sync("child")
store.optimistic.remove({ sessionID: "child", messageID: user.id })
expect(client.requests).toHaveLength(1) expect(client.requests).toHaveLength(1)
expect(client.rootRequests).toHaveLength(1) expect(client.rootRequests).toHaveLength(1)
@@ -918,6 +783,28 @@ describe("server session", () => {
expect(store.data.part[stale.id]).toEqual([freshPart]) expect(store.data.part[stale.id]).toEqual([freshPart])
}) })
test("refreshes a confirmed optimistic parent while preserving pending parts", async () => {
const stale = userMessage("message-1", { summary: { title: "stale", diffs: [] } })
const fresh = { ...stale, summary: { title: "fresh", diffs: [] } }
const confirmed = textPart(stale.id, { id: "confirmed", text: "stale" })
const refreshed = { ...confirmed, text: "fresh" }
const pending = textPart(stale.id, { id: "pending", text: "pending" })
const assistant = assistantMessage("message-2", stale.id)
const client = rootMessageClient(
[response([{ info: stale, parts: [confirmed] }]), response([{ info: assistant, parts: [] }])],
[singleResponse(fresh, [refreshed])],
)
const store = createServerSession(client)
store.optimistic.add({ sessionID: "child", message: stale, parts: [confirmed, pending] })
await store.sync("child")
await store.sync("child", { force: true })
expect(client.rootRequests).toEqual([{ sessionID: "child", messageID: stale.id }])
expect(store.data.message.child).toEqual([fresh, assistant])
expect(store.data.part[stale.id]).toEqual([refreshed, pending])
})
test("uses a parent received by SSE during the replacement load", async () => { test("uses a parent received by SSE during the replacement load", async () => {
const pending = deferredResponse() const pending = deferredResponse()
const user = userMessage("message-1") const user = userMessage("message-1")
@@ -1153,6 +1040,30 @@ describe("server session", () => {
expect(store.data.part[message.id]).toBeUndefined() expect(store.data.part[message.id]).toBeUndefined()
}) })
test("preserves optimistic parts re-added after removal during a refresh", async () => {
const pending = deferredResponse()
const message = userMessage("message")
const stale = textPart(message.id, { id: "stale", text: "stale" })
const part = textPart(message.id, { id: "optimistic", text: "optimistic" })
const store = createServerSession(
messageClient(response([{ info: message, parts: [] }]), pending.promise, response()),
)
await store.sync("child")
const refreshing = store.sync("child", { force: true })
store.apply({ type: "message.removed", properties: { sessionID: "child", messageID: message.id } })
store.optimistic.add({ sessionID: "child", message, parts: [part] })
pending.resolve(response([{ info: message, parts: [stale] }]))
await refreshing
expect(store.data.message.child).toEqual([message])
expect(store.data.part[message.id]).toEqual([part])
await store.sync("child", { force: true })
expect(store.data.message.child).toEqual([message])
expect(store.data.part[message.id]).toEqual([part])
})
test("drops stale event content omitted by a complete initial page", async () => { test("drops stale event content omitted by a complete initial page", async () => {
const stale = userMessage("stale") const stale = userMessage("stale")
const store = createServerSession(messageClient(response())) const store = createServerSession(messageClient(response()))
@@ -1174,309 +1085,170 @@ describe("server session", () => {
expect(store.data.message.child).toEqual([live, fetched]) expect(store.data.message.child).toEqual([live, fetched])
}) })
test("echoes a prompt without changing durable message order", () => { test("does not restore removed optimistic content on refresh", async () => {
const store = setup({ child: session("child") }).store const message = userMessage("message")
const part = textPart(message.id, { text: "removed" })
const kept = { ...message, id: "kept" }
const keptPart = { ...part, id: "kept-part", messageID: kept.id }
const store = createServerSession(messageClient(response([{ info: kept, parts: [] }])))
store.optimistic.add({ sessionID: "child", message, parts: [part] })
store.optimistic.add({ sessionID: "child", message: kept, parts: [keptPart] })
store.inbox.echo({ store.apply({ type: "message.removed", properties: { sessionID: "child", messageID: message.id } })
...promptEcho("msg_prompt"), store.apply({
text: "hello\nThe user made the following comment regarding line 4 of src/foo.ts: check this", type: "message.part.removed",
files: [{ uri: "file:///repo/src/foo.ts", mime: "text/plain", name: "foo.ts" }], properties: { sessionID: "child", messageID: kept.id, partID: keptPart.id },
agents: [{ name: "explore" }],
comments: [
{
path: "src/foo.ts",
selection: { startLine: 4, startChar: 1, endLine: 4, endChar: 5 },
comment: "check this",
preview: "const value = 1",
origin: "review",
},
],
}) })
await store.sync("child", { force: true })
expect(store.data.pending.child).toMatchObject([{ id: "msg_prompt", type: "user", delivery: "steer" }]) expect(store.data.message.child).toEqual([kept])
expect(store.data.input.child).toEqual(["msg_prompt"]) expect(store.data.part[message.id]).toBeUndefined()
expect(store.data.session_message.child).toBeUndefined() expect(store.data.part[kept.id]).toBeUndefined()
expect(store.data.message.child?.map((message) => message.id)).toEqual(["msg_prompt"])
expect(store.data.part.msg_prompt).toMatchObject([
{ id: "msg_prompt:text:0", type: "text", text: "hello" },
{ id: "msg_prompt:file:0", type: "file", filename: "foo.ts" },
{ id: "msg_prompt:agent:0", type: "agent", name: "explore" },
{
id: "msg_prompt:comment:0",
type: "text",
synthetic: true,
metadata: {
opencodeComment: {
path: "src/foo.ts",
selection: { startLine: 4, startChar: 1, endLine: 4, endChar: 5 },
comment: "check this",
preview: "const value = 1",
origin: "review",
},
},
},
])
store.applyV2({
id: "evt_prompt",
created: 2,
type: "session.inbox.enqueued",
durable: { aggregateID: "child", seq: 1, version: 1 },
data: {
sessionID: "child",
inboxID: "msg_prompt",
item: {
type: "user",
delivery: "steer",
payload: {
text: "hello\nThe user made the following comment regarding line 4 of src/foo.ts: check this",
},
},
},
} as OpenCodeEvent)
expect(store.data.part.msg_prompt).toMatchObject([
{ id: "msg_prompt:text:0", type: "text", text: "hello" },
{ id: "msg_prompt:comment:0", type: "text", synthetic: true },
])
}) })
test("preserves a local echo while message history omits pending input", async () => { test("replaces confirmed optimistic content with the initial page", async () => {
const store = createServerSession(messageClient(response())) const optimistic = userMessage("message")
store.inbox.echo(promptEcho("msg_prompt")) const fetched = { ...optimistic, time: { created: 2 } }
store.inbox.confirm({ const store = createServerSession(messageClient(response([{ info: fetched, parts: [] }])))
id: "msg_prompt", store.optimistic.add({ sessionID: "child", message: optimistic, parts: [] })
sessionID: "child",
timeCreated: 1,
type: "user",
delivery: "steer",
payload: { text: "hello" },
})
await store.sync("child") await store.sync("child")
expect(store.data.message.child?.map((message) => message.id)).toEqual(["msg_prompt"]) expect(store.data.message.child).toEqual([fetched])
expect(store.data.part.msg_prompt).toMatchObject([{ type: "text", text: "hello" }])
}) })
test("preserves local comment presentation through message refresh", async () => { test("replaces a confirmed optimistic part with fetched content", async () => {
const note = "The user made the following comment regarding line 4 of src/foo.ts: check this" const pending = deferredResponse()
const message = userMessage("msg_prompt") const message = userMessage("message")
const optimistic = textPart(message.id, { text: "optimistic" })
const fetched = { ...optimistic, text: "fetched" }
const store = createServerSession(messageClient(pending.promise))
const loading = store.sync("child")
store.optimistic.add({ sessionID: "child", message, parts: [optimistic] })
pending.resolve(response([{ info: message, parts: [fetched] }]))
await loading
expect(store.data.part[message.id]).toEqual([fetched])
})
test("rolls back only unconfirmed optimistic parts", async () => {
const pending = deferredResponse()
const message = userMessage("message")
const confirmed = textPart(message.id, { id: "confirmed", text: "confirmed" })
const pendingPart = textPart(message.id, { id: "pending", text: "pending" })
const store = createServerSession(messageClient(pending.promise))
const loading = store.sync("child")
store.optimistic.add({ sessionID: "child", message, parts: [confirmed, pendingPart] })
pending.resolve(response([{ info: message, parts: [confirmed] }]))
await loading
store.optimistic.remove({ sessionID: "child", messageID: message.id })
expect(store.data.message.child).toEqual([message])
expect(store.data.part[message.id]).toEqual([confirmed])
})
test("updates confirmed optimistic parts from later pages", async () => {
const message = userMessage("message")
const confirmed = textPart(message.id, { id: "confirmed", text: "first" })
const updated = { ...confirmed, text: "updated" }
const pendingPart = textPart(message.id, { id: "pending", text: "pending" })
const store = createServerSession( const store = createServerSession(
messageClient(response([{ info: message, parts: [textPart(message.id, { text: note })] }])), messageClient(response([{ info: message, parts: [confirmed] }]), response([{ info: message, parts: [updated] }])),
) )
store.inbox.echo({ store.optimistic.add({ sessionID: "child", message, parts: [confirmed, pendingPart] })
...promptEcho(message.id),
text: `hello\n${note}`,
comments: [
{
path: "src/foo.ts",
selection: { startLine: 4, startChar: 1, endLine: 4, endChar: 5 },
comment: "check this",
origin: "review",
},
],
})
await store.sync("child") await store.sync("child")
expect(store.data.part.msg_prompt).toMatchObject([ await store.sync("child", { force: true })
{ id: "msg_prompt:text:0", type: "text", text: "hello" }, store.optimistic.remove({ sessionID: "child", messageID: message.id })
{ id: "msg_prompt:comment:0", type: "text", synthetic: true },
]) expect(store.data.part[message.id]).toEqual([updated])
}) })
test("retires an admitted echo absent from authoritative reconnect state", async () => { test("does not restore a confirmed optimistic part after its removal event", async () => {
const store = createServerSession(messageClient(response())) const message = userMessage("message")
store.inbox.echo(promptEcho("msg_prompt")) const confirmed = textPart(message.id, { id: "confirmed", text: "confirmed" })
store.inbox.confirm({ const pendingPart = textPart(message.id, { id: "pending", text: "pending" })
id: "msg_prompt", const store = createServerSession(
sessionID: "child", messageClient(response([{ info: message, parts: [confirmed] }]), response([{ info: message, parts: [] }])),
timeCreated: 1, )
type: "user", store.optimistic.add({ sessionID: "child", message, parts: [confirmed, pendingPart] })
delivery: "steer", await store.sync("child")
payload: { text: "hello" }, store.apply({
type: "message.part.removed",
properties: { sessionID: "child", messageID: message.id, partID: confirmed.id },
}) })
await Promise.all([store.sync("child"), store.hydrateTransient("child", async () => ({ pending: [], forms: [] }))]) await store.sync("child", { force: true })
store.inbox.reconcile("child")
expect(store.data.pending.child).toEqual([]) expect(store.data.part[message.id]).toEqual([pendingPart])
expect(store.data.message.child).toEqual([])
expect(store.data.part.msg_prompt).toBeUndefined()
}) })
test("retires a stale enqueued message when inbox hydration finishes after history", async () => { test("clears delta buffers when removing optimistic content", () => {
const store = createServerSession(messageClient(response())) const message = userMessage("message")
store.applyV2({ const part = textPart(message.id, { text: "optimistic" })
id: "evt_prompt", const store = setup({ child: session("child") }).store
created: 1, store.optimistic.add({ sessionID: "child", message, parts: [part] })
type: "session.inbox.enqueued", store.apply({
durable: { aggregateID: "child", seq: 1, version: 1 }, type: "message.part.delta",
data: { properties: { sessionID: "child", messageID: message.id, partID: part.id, field: "text", delta: " delta" },
sessionID: "child", })
inboxID: "msg_prompt",
item: { type: "user", delivery: "steer", payload: { text: "hello" } },
},
} as OpenCodeEvent)
await store.sync("child") store.optimistic.remove({ sessionID: "child", messageID: message.id })
await store.hydrateTransient("child", async () => ({ pending: [], forms: [] }))
store.inbox.reconcile("child") expect(store.data.part[message.id]).toBeUndefined()
expect(store.data.part_text_accum_delta[part.id]).toBeUndefined()
})
test("removes projected messages when rolling back optimistic content", () => {
const message = userMessage("message")
const store = setup({ child: session("child") }).store
store.optimistic.add({ sessionID: "child", message, parts: [] })
store.optimistic.remove({ sessionID: "child", messageID: message.id })
expect(store.data.pending.child).toEqual([])
expect(store.data.session_message.child).toEqual([]) expect(store.data.session_message.child).toEqual([])
expect(store.data.message.child).toEqual([])
expect(store.data.part.msg_prompt).toBeUndefined()
}) })
test("deduplicates the durable admission event against its local echo", () => { test("does not remove content confirmed by a message event", () => {
const message = userMessage("message")
const part = textPart(message.id)
const store = setup({ child: session("child") }).store const store = setup({ child: session("child") }).store
store.inbox.echo(promptEcho("msg_prompt")) store.optimistic.add({ sessionID: "child", message, parts: [part] })
store.apply({ type: "message.updated", properties: { sessionID: "child", info: message } })
store.applyV2({ store.optimistic.remove({ sessionID: "child", messageID: message.id })
id: "evt_prompt",
created: 2,
type: "session.inbox.enqueued",
durable: { aggregateID: "child", seq: 1, version: 1 },
data: {
sessionID: "child",
inboxID: "msg_prompt",
item: { type: "user", delivery: "steer", payload: { text: "hello" } },
},
} as OpenCodeEvent)
expect(store.data.pending.child).toHaveLength(1) expect(store.data.message.child).toEqual([message])
expect(store.data.input.child).toEqual(["msg_prompt"]) expect(store.data.part[message.id]).toBeUndefined()
expect(store.data.session_message.child?.filter((message) => message.id === "msg_prompt")).toHaveLength(1)
expect(store.data.message.child?.filter((message) => message.id === "msg_prompt")).toHaveLength(1)
expect(store.data.part.msg_prompt).toMatchObject([{ type: "text", text: "hello" }])
}) })
test("uses the prompt response when the admission event was missed", () => { test("does not remove parts confirmed by part events", () => {
const message = userMessage("message")
const part = textPart(message.id)
const store = setup({ child: session("child") }).store const store = setup({ child: session("child") }).store
store.inbox.echo(promptEcho("msg_prompt")) store.optimistic.add({ sessionID: "child", message, parts: [part] })
store.inbox.confirm({ store.apply({ type: "message.updated", properties: { sessionID: "child", info: message } })
id: "msg_prompt", store.apply({ type: "message.part.updated", properties: { sessionID: "child", part, time: 2 } })
sessionID: "child",
timeCreated: 2,
type: "user",
delivery: "steer",
payload: { text: "hello" },
})
store.applyV2({ store.optimistic.remove({ sessionID: "child", messageID: message.id })
id: "evt_delivered",
created: Date.now() + 1,
type: "session.inbox.delivered",
durable: { aggregateID: "child", seq: 2, version: 1 },
data: { sessionID: "child", inboxID: "msg_prompt" },
} as OpenCodeEvent)
expect(store.data.pending.child).toEqual([]) expect(store.data.message.child).toEqual([message])
expect(store.data.input.child).toEqual([]) expect(store.data.part[message.id]).toEqual([part])
expect(store.data.session_message.child).toMatchObject([{ id: "msg_prompt", type: "user", text: "hello" }])
expect(store.data.message.child?.filter((message) => message.id === "msg_prompt")).toHaveLength(1)
expect(store.data.part.msg_prompt).toMatchObject([{ type: "text", text: "hello" }])
}) })
test("keeps a durable admission when the HTTP request later fails", () => { test("treats a part event as confirmation when it precedes the message event", () => {
const message = userMessage("message")
const part = textPart(message.id)
const store = setup({ child: session("child") }).store const store = setup({ child: session("child") }).store
store.inbox.echo(promptEcho("msg_prompt")) store.optimistic.add({ sessionID: "child", message, parts: [part] })
store.applyV2({ store.apply({ type: "message.part.updated", properties: { sessionID: "child", part, time: 2 } })
id: "evt_prompt",
created: 2,
type: "session.inbox.enqueued",
durable: { aggregateID: "child", seq: 1, version: 1 },
data: {
sessionID: "child",
inboxID: "msg_prompt",
item: { type: "user", delivery: "steer", payload: { text: "hello" } },
},
} as OpenCodeEvent)
expect(store.inbox.clearEcho({ sessionID: "child", messageID: "msg_prompt" })).toBe(false) store.optimistic.remove({ sessionID: "child", messageID: message.id })
expect(store.data.pending.child).toHaveLength(1)
expect(store.data.message.child?.map((message) => message.id)).toEqual(["msg_prompt"])
})
test("places durable admission after delayed selection events", () => { expect(store.data.message.child).toEqual([message])
const store = setup({ child: session("child") }).store expect(store.data.part[message.id]).toEqual([part])
store.remember(session("child"))
store.inbox.echo(promptEcho("msg_prompt"))
store.applyV2({
id: "evt_agent",
created: 1,
type: "session.agent.selected",
durable: { aggregateID: "child", seq: 1, version: 1 },
data: { sessionID: "child", agent: "review" },
} as OpenCodeEvent)
store.applyV2({
id: "evt_model",
created: 2,
type: "session.model.selected",
durable: { aggregateID: "child", seq: 2, version: 1 },
data: { sessionID: "child", model: { id: "new-model", providerID: "new-provider" } },
} as OpenCodeEvent)
store.applyV2({
id: "evt_prompt",
created: 3,
type: "session.inbox.enqueued",
durable: { aggregateID: "child", seq: 3, version: 1 },
data: {
sessionID: "child",
inboxID: "msg_prompt",
item: { type: "user", delivery: "steer", payload: { text: "hello" } },
},
} as OpenCodeEvent)
expect(store.data.session_message.child?.map((message) => message.type)).toEqual([
"agent-switched",
"model-switched",
"user",
])
expect(store.data.message.child?.find((message) => message.id === "msg_prompt")).toMatchObject({
agent: "review",
model: { providerID: "new-provider", modelID: "new-model" },
})
})
test("removes an echoed prompt when submission fails", () => {
const store = setup({ child: session("child") }).store
store.inbox.echo(promptEcho("msg_prompt"))
expect(store.inbox.clearEcho({ sessionID: "child", messageID: "msg_prompt" })).toBe(true)
expect(store.data.pending.child).toEqual([])
expect(store.data.input.child).toEqual([])
expect(store.data.session_message.child).toBeUndefined()
expect(store.data.message.child).toEqual([])
expect(store.data.part.msg_prompt).toBeUndefined()
})
test("removes a response-confirmed echo when the server cancels it", () => {
const store = setup({ child: session("child") }).store
store.inbox.echo(promptEcho("msg_prompt"))
store.inbox.confirm({
id: "msg_prompt",
sessionID: "child",
timeCreated: 1,
type: "user",
delivery: "steer",
payload: { text: "hello" },
})
store.applyV2({
id: "evt_cancelled",
created: 2,
type: "session.inbox.cancelled",
durable: { aggregateID: "child", seq: 2, version: 1 },
data: { sessionID: "child", inboxID: "msg_prompt" },
} as OpenCodeEvent)
expect(store.data.pending.child).toEqual([])
expect(store.data.message.child).toEqual([])
expect(store.data.part.msg_prompt).toBeUndefined()
}) })
test("clears stale parts when the initial page has none", async () => { test("clears stale parts when the initial page has none", async () => {
@@ -1697,6 +1469,28 @@ describe("server session", () => {
expect(store.data.part[message.id]).toBeUndefined() expect(store.data.part[message.id]).toBeUndefined()
}) })
test("preserves optimistic re-adds across message retries", async () => {
const failed = Promise.withResolvers<MessageResponse>()
const retried = Promise.withResolvers<MessageResponse>()
const message = userMessage("message")
const stale = textPart(message.id, { id: "stale", text: "stale" })
const optimistic = textPart(message.id, { id: "optimistic", text: "optimistic" })
const client = messageClient(response([{ info: message, parts: [stale] }]), failed.promise, retried.promise)
const store = createServerSession(client, { retry: retryImmediately })
await store.sync("child")
const loading = store.sync("child", { force: true })
store.apply({ type: "message.removed", properties: { sessionID: "child", messageID: message.id } })
store.optimistic.add({ sessionID: "child", message, parts: [optimistic] })
failed.reject(new Error("failed to fetch"))
await client.requested(3)
retried.resolve(response([{ info: message, parts: [stale] }]))
await loading
expect(store.data.message.child).toEqual([message])
expect(store.data.part[message.id]).toEqual([optimistic])
})
test("accepts part omission from a successful retry after an earlier delta", async () => { test("accepts part omission from a successful retry after an earlier delta", async () => {
const failed = Promise.withResolvers<MessageResponse>() const failed = Promise.withResolvers<MessageResponse>()
const retried = Promise.withResolvers<MessageResponse>() const retried = Promise.withResolvers<MessageResponse>()
@@ -1860,6 +1654,33 @@ describe("server session", () => {
expect(store.data.part[message.id]).toBeUndefined() expect(store.data.part[message.id]).toBeUndefined()
}) })
test("does not cache skipped optimistic parts", () => {
const message = userMessage("message")
const part = { id: "part", sessionID: "child", messageID: message.id, type: "step-start" as const }
const store = setup({ child: session("child") }).store
store.optimistic.add({ sessionID: "child", message, parts: [part] })
expect(store.data.part[message.id]).toEqual([])
})
test("clears stale delta buffers when replacing optimistic parts", () => {
const message = userMessage("message")
const stale = textPart(message.id, { id: "stale", text: "stale" })
const optimistic = textPart(message.id, { id: "optimistic", text: "optimistic" })
const store = setup({ child: session("child") }).store
store.optimistic.add({ sessionID: "child", message, parts: [stale] })
store.apply({
type: "message.part.delta",
properties: { sessionID: "child", messageID: message.id, partID: stale.id, field: "text", delta: " delta" },
})
store.optimistic.add({ sessionID: "child", message, parts: [optimistic] })
expect(store.data.part_text_accum_delta[stale.id]).toBeUndefined()
expect(store.data.part_text_accum_delta[optimistic.id]).toBeUndefined()
})
test("preserves removals during history prepend", async () => { test("preserves removals during history prepend", async () => {
const pending = deferredResponse() const pending = deferredResponse()
const latest = userMessage("message-2", { time: { created: 2 } }) const latest = userMessage("message-2", { time: { created: 2 } })
@@ -2085,7 +1906,24 @@ describe("server session", () => {
test("preserves pinned session content under server-wide cache pressure", () => { test("preserves pinned session content under server-wide cache pressure", () => {
const ctx = setup({}) const ctx = setup({})
ctx.store.pin("active") ctx.store.pin("active")
ctx.store.inbox.echo({ ...promptEcho("message", "keep"), sessionID: "active" }) ctx.store.optimistic.add({
sessionID: "active",
message: {
id: "message",
sessionID: "active",
role: "assistant",
time: { created: 1 },
parentID: "parent",
modelID: "model",
providerID: "provider",
mode: "build",
agent: "agent",
path: { cwd: "/repo", root: "/repo" },
cost: 0,
tokens: { input: 0, output: 0, reasoning: 0, cache: { read: 0, write: 0 } },
},
parts: [],
})
for (let index = 0; index < 50; index++) { for (let index = 0; index < 50; index++) {
ctx.store.remember(session(`session-${index}`)) ctx.store.remember(session(`session-${index}`))
+301 -274
View File
@@ -18,22 +18,41 @@ import { compareMessages, messageKey, normalizeSessionMessages } from "@/utils/s
import { dropSessionCaches, pickSessionCacheEvictions, SESSION_CACHE_LIMIT } from "./global-sync/session-cache" import { dropSessionCaches, pickSessionCacheEvictions, SESSION_CACHE_LIMIT } from "./global-sync/session-cache"
import { createV2SessionReducer, type V2SessionReduction } from "./server-session-v2-reducer" import { createV2SessionReducer, type V2SessionReduction } from "./server-session-v2-reducer"
import type { ServerApi } from "@/utils/server" import type { ServerApi } from "@/utils/server"
import {
createCommentMetadata,
formatCommentNote,
parseCommentNote,
readCommentMetadata,
type PromptComment,
} from "@/utils/comment-note"
type MessageApi = ServerApi["message"] type MessageApi = ServerApi["message"]
const cmp = (a: string, b: string) => (a < b ? -1 : a > b ? 1 : 0) const cmp = (a: string, b: string) => (a < b ? -1 : a > b ? 1 : 0)
const SKIP_PARTS = new Set(["patch", "step-start", "step-finish"]) const SKIP_PARTS = new Set(["patch", "step-start", "step-finish"])
const messagePageSize = 200 const initialMessagePageSize = 20
const historyMessagePageSize = 200
const sessionInfoLimit = 2_048 const sessionInfoLimit = 2_048
const emptyIDs: ReadonlySet<string> = new Set() const emptyIDs: ReadonlySet<string> = new Set()
function projectMessageSource(message: Message): SessionMessageInfo[] {
if (message.role === "user") {
return [
{ id: `${message.id}:agent`, type: "agent-switched", agent: message.agent, time: message.time },
{
id: `${message.id}:model`,
type: "model-switched",
model: { id: message.model.modelID, providerID: message.model.providerID, variant: message.model.variant },
time: message.time,
},
{ id: message.id, type: "user", text: "", time: message.time },
]
}
return [
{
id: message.id,
type: "assistant",
agent: message.agent ?? message.mode,
model: { id: message.modelID, providerID: message.providerID, variant: message.variant },
content: [],
time: message.time,
},
]
}
function needsOlderTurnRoot(source: readonly SessionMessageInfo[]) { function needsOlderTurnRoot(source: readonly SessionMessageInfo[]) {
const boundary = source.find( const boundary = source.find(
(message) => (message) =>
@@ -45,6 +64,13 @@ function needsOlderTurnRoot(source: readonly SessionMessageInfo[]) {
return boundary?.type === "assistant" return boundary?.type === "assistant"
} }
type OptimisticItem = {
message: Message
parts: Part[]
confirmedParts?: Part[]
confirmedMessage?: boolean
}
type MessagePage = { type MessagePage = {
session: Message[] session: Message[]
part: { id: string; part: Part[] }[] part: { id: string; part: Part[] }[]
@@ -55,18 +81,6 @@ type MessagePage = {
complete: boolean complete: boolean
} }
export type PromptEcho = {
sessionID: string
messageID: string
text: string
displayText: string
agent: string
model: { providerID: string; modelID: string; variant?: string }
files?: { uri: string; mime: string; name?: string; mention?: { start: number; end: number; text: string } }[]
agents?: { name: string; mention?: { start: number; end: number; text: string } }[]
comments: PromptComment[]
}
// Most markers describe the current HTTP attempt; deltaParts persists non-durable stream state across retries. // Most markers describe the current HTTP attempt; deltaParts persists non-durable stream state across retries.
type MessageLoadState = { type MessageLoadState = {
touchedMessages: Set<string> touchedMessages: Set<string>
@@ -76,6 +90,7 @@ type MessageLoadState = {
deltaParts: Map<string, Set<string>> deltaParts: Map<string, Set<string>>
carriedDeltaParts: Map<string, Set<string>> carriedDeltaParts: Map<string, Set<string>>
removedParts: Map<string, Set<string>> removedParts: Map<string, Set<string>>
optimisticParts: Map<string, Set<string>>
orphanParents: Set<string> orphanParents: Set<string>
clearedMessageParts: Set<string> clearedMessageParts: Set<string>
touchedSource: Set<string> touchedSource: Set<string>
@@ -86,6 +101,34 @@ type MessageLoadBaseline = Pick<
"touchedMessages" | "retainedMessages" | "touchedParts" | "clearedMessageParts" "touchedMessages" | "retainedMessages" | "touchedParts" | "clearedMessageParts"
> >
function mergeOptimisticPage(page: MessagePage, items: OptimisticItem[]) {
if (items.length === 0) return { ...page, observed: [] as { messageID: string; parts: Part[] }[] }
const session = [...page.session]
const part = new Map(page.part.map((item) => [item.id, item.part]))
const observed: { messageID: string; parts: Part[] }[] = []
for (const item of items) {
const result = Binary.search(session, messageKey(item.message), messageKey)
const found = result.found
if (!found) session.splice(result.index, 0, item.message)
const current = part.get(item.message.id)
const confirmed = found ? item.parts.filter((part) => current?.some((value) => value.id === part.id)) : []
if (found) observed.push({ messageID: item.message.id, parts: confirmed })
part.set(
item.message.id,
merge(
found ? (current ?? []) : merge(item.confirmedParts ?? [], current ?? []),
item.parts.filter((part) => !confirmed.includes(part)),
),
)
}
return {
...page,
session,
part: [...part.entries()].sort((a, b) => cmp(a[0], b[0])).map(([id, parts]) => ({ id, part: parts })),
observed,
}
}
function runInflight(map: Map<string, Promise<void>>, key: string, task: () => Promise<void>) { function runInflight(map: Map<string, Promise<void>>, key: string, task: () => Promise<void>) {
const pending = map.get(key) const pending = map.get(key)
if (pending) return pending if (pending) return pending
@@ -160,7 +203,6 @@ export function createServerSession(
input: {} as Record<string, string[]>, input: {} as Record<string, string[]>,
message: {} as Record<string, Message[]>, message: {} as Record<string, Message[]>,
session_message: {} as Record<string, SessionMessageInfo[]>, session_message: {} as Record<string, SessionMessageInfo[]>,
// Part order is semantic and follows SessionMessageAssistant.content; IDs identify parts only.
part: {} as Record<string, Part[]>, part: {} as Record<string, Part[]>,
part_text_accum_delta: {} as Record<string, string>, part_text_accum_delta: {} as Record<string, string>,
session_working(id: string) { session_working(id: string) {
@@ -170,6 +212,7 @@ export function createServerSession(
const requests = new Map<string, Promise<SessionInfo>>() const requests = new Map<string, Promise<SessionInfo>>()
const inflight = new Map<string, Promise<void>>() const inflight = new Map<string, Promise<void>>()
const inflightTodo = new Map<string, Promise<void>>() const inflightTodo = new Map<string, Promise<void>>()
const optimistic = new Map<string, Map<string, OptimisticItem>>()
const v2 = createV2SessionReducer() const v2 = createV2SessionReducer()
const pendingRevision = new Map<string, number>() const pendingRevision = new Map<string, number>()
const formRevision = new Map<string, number>() const formRevision = new Map<string, number>()
@@ -180,45 +223,7 @@ export function createServerSession(
const pendingParts = new Map<string, Map<string, Set<string>>>() const pendingParts = new Map<string, Map<string, Set<string>>>()
const orphanParts = new Map<string, Set<string>>() const orphanParts = new Map<string, Set<string>>()
const removedMessages = new Map<string, Set<string>>() const removedMessages = new Map<string, Set<string>>()
const echoes = new Map<string, Map<string, "sending" | "admitted">>()
const messageSnapshots = new Map<string, Set<string>>()
const settledInputs = new Map<string, Set<string>>()
const deltaBases = new Map<string, { base: string; sessionID: string }>() const deltaBases = new Map<string, { base: string; sessionID: string }>()
const markEcho = (sessionID: string, messageID: string) => {
const messages = echoes.get(sessionID) ?? new Map<string, "sending" | "admitted">()
messages.set(messageID, "sending")
echoes.set(sessionID, messages)
}
const confirmEcho = (sessionID: string, messageID: string) => {
const messages = echoes.get(sessionID)
if (!messages?.has(messageID)) return false
messages.set(messageID, "admitted")
return true
}
const releaseEcho = (sessionID: string, messageID: string) => {
const messages = echoes.get(sessionID)
const state = messages?.get(messageID)
if (!messages || !state) return
messages.delete(messageID)
if (messages.size === 0) echoes.delete(sessionID)
return state
}
const present = (messageID: string, parts: Part[]) => {
const local = data.part[messageID] ?? []
const comments = local.filter(
(part) =>
part.type === "text" &&
part.synthetic &&
(readCommentMetadata(part.metadata) !== undefined || parseCommentNote(part.text) !== undefined),
)
if (!comments.length) return parts
const text = local.find((part) => part.type === "text" && !part.synthetic)
const projected = parts.flatMap((part) => {
if (part.id !== `${messageID}:text:0` || part.type !== "text") return [part]
return text?.type === "text" && text.text ? [{ ...part, text: text.text }] : []
})
return [...projected, ...comments]
}
const deleteMessageParts = ( const deleteMessageParts = (
cache: { part: Record<string, Part[] | undefined>; part_text_accum_delta: Record<string, string | undefined> }, cache: { part: Record<string, Part[] | undefined>; part_text_accum_delta: Record<string, string | undefined> },
messageID: string, messageID: string,
@@ -241,12 +246,25 @@ export function createServerSession(
return created return created
} }
const [meta, setMeta] = createStore({ const [meta, setMeta] = createStore({
limit: {} as Record<string, number | undefined>,
cursor: {} as Record<string, string | undefined>, cursor: {} as Record<string, string | undefined>,
complete: {} as Record<string, boolean | undefined>, complete: {} as Record<string, boolean | undefined>,
loading: {} as Record<string, boolean | undefined>, loading: {} as Record<string, boolean | undefined>,
at: {} as Record<string, number | undefined>, at: {} as Record<string, number | undefined>,
}) })
const indexProjectedMessage = (message: Message) => {
const current = data.session_message[message.sessionID] ?? []
if (current.some((item) => item.id === message.id)) return
const projected = projectMessageSource(message)
const projectedIDs = new Set(projected.map((item) => item.id))
setData(
"session_message",
message.sessionID,
reconcile([...current.filter((item) => !projectedIDs.has(item.id)), ...projected]),
)
}
const remember = (session: SessionInfo) => { const remember = (session: SessionInfo) => {
setData("info", session.id, reconcile(session)) setData("info", session.id, reconcile(session))
infoSeen.delete(session.id) infoSeen.delete(session.id)
@@ -258,7 +276,7 @@ export function createServerSession(
...inflight.keys(), ...inflight.keys(),
...inflightTodo.keys(), ...inflightTodo.keys(),
...messageLoads.keys(), ...messageLoads.keys(),
...echoes.keys(), ...optimistic.keys(),
...Object.entries(data.permission) ...Object.entries(data.permission)
.filter(([, items]) => items.length > 0) .filter(([, items]) => items.length > 0)
.map(([sessionID]) => sessionID), .map(([sessionID]) => sessionID),
@@ -334,6 +352,65 @@ export function createServerSession(
return { session, root } return { session, root }
} }
const clearOptimistic = (sessionID: string, messageID?: string) => {
if (!messageID) {
optimistic.delete(sessionID)
return
}
const items = optimistic.get(sessionID)
if (!items) return
items.delete(messageID)
if (items.size === 0) optimistic.delete(sessionID)
}
const clearOptimisticPart = (sessionID: string, messageID: string, partID: string) => {
const items = optimistic.get(sessionID)
const item = items?.get(messageID)
if (!items || !item) return
const parts = item.parts.filter((part) => part.id !== partID)
const confirmedParts = item.confirmedParts?.filter((part) => part.id !== partID)
if (parts.length === 0) {
clearOptimistic(sessionID, messageID)
return
}
items.set(messageID, { ...item, parts, confirmedParts, confirmedMessage: true })
}
const confirmOptimisticPart = (sessionID: string, messageID: string, part: Part) => {
const items = optimistic.get(sessionID)
const item = items?.get(messageID)
if (!items || !item) return
const parts = item.parts.filter((value) => value.id !== part.id)
if (parts.length === 0) {
clearOptimistic(sessionID, messageID)
return
}
items.set(messageID, {
...item,
parts,
confirmedParts: merge(item.confirmedParts ?? [], [part]),
confirmedMessage: true,
})
}
const confirmOptimistic = (sessionID: string, messageID: string, confirmedParts: Part[]) => {
const items = optimistic.get(sessionID)
const item = items?.get(messageID)
if (!items || !item) return
const confirmed = new Set(confirmedParts.map((part) => part.id))
const parts = item.parts.filter((part) => !confirmed.has(part.id))
if (parts.length === 0) {
clearOptimistic(sessionID, messageID)
return
}
items.set(messageID, {
...item,
parts,
confirmedParts: merge(item.confirmedParts ?? [], confirmedParts),
confirmedMessage: true,
})
}
const trackPartChange = (sessionID: string, messageID: string, partID: string) => { const trackPartChange = (sessionID: string, messageID: string, partID: string) => {
const load = messageLoads.get(sessionID) const load = messageLoads.get(sessionID)
if (!load) return if (!load) return
@@ -371,6 +448,14 @@ export function createServerSession(
const messages = data.message[sessionID] const messages = data.message[sessionID]
if (messages?.some((message) => message.id === messageID)) load.retainedMessages.add(messageID) if (messages?.some((message) => message.id === messageID)) load.retainedMessages.add(messageID)
} }
for (const [messageID, parts] of load.optimisticParts) {
load.removedMessages.delete(messageID)
load.clearedMessageParts.add(messageID)
load.touchedMessages.add(messageID)
const touched = load.touchedParts.get(messageID) ?? new Set<string>()
parts.forEach((partID) => touched.add(partID))
load.touchedParts.set(messageID, touched)
}
baseline?.touchedMessages.forEach((messageID) => load.touchedMessages.add(messageID)) baseline?.touchedMessages.forEach((messageID) => load.touchedMessages.add(messageID))
baseline?.retainedMessages.forEach((messageID) => load.retainedMessages.add(messageID)) baseline?.retainedMessages.forEach((messageID) => load.retainedMessages.add(messageID))
baseline?.clearedMessageParts.forEach((messageID) => load.clearedMessageParts.add(messageID)) baseline?.clearedMessageParts.forEach((messageID) => load.clearedMessageParts.add(messageID))
@@ -401,9 +486,7 @@ export function createServerSession(
sessionIDs.forEach((sessionID) => { sessionIDs.forEach((sessionID) => {
messageHydrationRevision.set(sessionID, (messageHydrationRevision.get(sessionID) ?? 0) + 1) messageHydrationRevision.set(sessionID, (messageHydrationRevision.get(sessionID) ?? 0) + 1)
generations.delete(sessionID) generations.delete(sessionID)
echoes.delete(sessionID) clearOptimistic(sessionID)
messageSnapshots.delete(sessionID)
settledInputs.delete(sessionID)
requests.delete(sessionID) requests.delete(sessionID)
inflight.delete(sessionID) inflight.delete(sessionID)
inflightTodo.delete(sessionID) inflightTodo.delete(sessionID)
@@ -421,6 +504,7 @@ export function createServerSession(
setMeta( setMeta(
produce((draft) => { produce((draft) => {
for (const sessionID of sessionIDs) { for (const sessionID of sessionIDs) {
delete draft.limit[sessionID]
delete draft.cursor[sessionID] delete draft.cursor[sessionID]
delete draft.complete[sessionID] delete draft.complete[sessionID]
delete draft.loading[sessionID] delete draft.loading[sessionID]
@@ -437,7 +521,7 @@ export function createServerSession(
...inflight.keys(), ...inflight.keys(),
...inflightTodo.keys(), ...inflightTodo.keys(),
...messageLoads.keys(), ...messageLoads.keys(),
...echoes.keys(), ...optimistic.keys(),
...Object.entries(data.permission) ...Object.entries(data.permission)
.filter(([, items]) => items.length > 0) .filter(([, items]) => items.length > 0)
.map(([sessionID]) => sessionID), .map(([sessionID]) => sessionID),
@@ -454,13 +538,11 @@ export function createServerSession(
pickSessionCacheEvictions({ seen, keep: sessionID, limit: SESSION_CACHE_LIMIT, preserve: protectedSessions() }), pickSessionCacheEvictions({ seen, keep: sessionID, limit: SESSION_CACHE_LIMIT, preserve: protectedSessions() }),
) )
const fetchMessages = async (sessionID: string, before?: string, onAttempt?: () => void) => { const fetchMessages = async (sessionID: string, limit: number, before?: string, onAttempt?: () => void) => {
const request = (cursor?: string) => const request = (cursor?: string) =>
(options?.retry ?? retry)(() => { (options?.retry ?? retry)(() => {
onAttempt?.() onAttempt?.()
return messageApi.list( return messageApi.list(cursor ? { sessionID, limit, cursor } : { sessionID, limit, order: "desc" })
cursor ? { sessionID, limit: messagePageSize, cursor } : { sessionID, limit: messagePageSize, order: "desc" },
)
}) })
const first = await request(before) const first = await request(before)
const pages = [first] const pages = [first]
@@ -474,7 +556,9 @@ export function createServerSession(
const normalized = normalizeSessionMessages(sessionID, source) const normalized = normalizeSessionMessages(sessionID, source)
return { return {
session: normalized.messages.sort(compareMessages), session: normalized.messages.sort(compareMessages),
part: [...normalized.parts.entries()].map(([id, part]) => ({ id, part })).sort((a, b) => cmp(a.id, b.id)), part: [...normalized.parts.entries()]
.map(([id, part]) => ({ id, part: part.sort((a, b) => cmp(a.id, b.id)) }))
.sort((a, b) => cmp(a.id, b.id)),
source, source,
sourceMode: before ? ("older" as const) : ("latest" as const), sourceMode: before ? ("older" as const) : ("latest" as const),
projectSource: true, projectSource: true,
@@ -514,10 +598,9 @@ export function createServerSession(
) => { ) => {
for (const item of items) { for (const item of items) {
if (!messageIDs.has(item.id)) continue if (!messageIDs.has(item.id)) continue
const fetched = present( const fetched = load?.clearedMessageParts.has(item.id)
item.id, ? []
load?.clearedMessageParts.has(item.id) ? [] : item.part.filter((part) => !SKIP_PARTS.has(part.type)), : item.part.filter((part) => !SKIP_PARTS.has(part.type))
)
const fetchedIDs = new Set(fetched.map((part) => part.id)) const fetchedIDs = new Set(fetched.map((part) => part.id))
const pending = pendingParts.get(sessionID)?.get(item.id) const pending = pendingParts.get(sessionID)?.get(item.id)
const touched = new Set([...(load?.touchedParts.get(item.id) ?? []), ...(pending ?? [])]) const touched = new Set([...(load?.touchedParts.get(item.id) ?? []), ...(pending ?? [])])
@@ -568,56 +651,47 @@ export function createServerSession(
preserveUnfetched: boolean | ((message: Message) => boolean), preserveUnfetched: boolean | ((message: Message) => boolean),
cleanupOrphans: boolean, cleanupOrphans: boolean,
) => { ) => {
if (page.sourceMode === "latest")
messageSnapshots.set(sessionID, new Set((page.source ?? []).map((message) => message.id)))
page.source?.forEach((message) => releaseEcho(sessionID, message.id))
const source = page.source const source = page.source
? (() => { ? (() => {
const incoming = new Map(page.source.map((message) => [message.id, message])) const incoming = new Map(page.source.map((message) => [message.id, message]))
const existing = data.session_message[sessionID] ?? [] const existing = data.session_message[sessionID] ?? []
const boundary = Math.min(...page.source.map((message) => message.time.created)) const boundary = Math.min(...page.source.map((message) => message.time.created))
const inbox = new Set(data.input[sessionID] ?? [])
const current = existing.filter( const current = existing.filter(
(message) => (message) =>
!incoming.has(message.id) && !incoming.has(message.id) &&
!inbox.has(message.id) &&
(page.sourceMode === "older" || (page.sourceMode === "older" ||
load?.touchedSource.has(message.id) || load?.touchedSource.has(message.id) ||
(!page.complete && message.time.created < boundary)), (!page.complete && message.time.created < boundary)),
) )
// message.list never returns admitted-but-undelivered inbox entries; keep them after the
// fetched history until a delivered or cancelled event resolves them.
const admitted = existing.filter((message) => !incoming.has(message.id) && inbox.has(message.id))
const combined =
page.sourceMode === "older"
? [...page.source, ...current, ...admitted]
: [...current, ...page.source, ...admitted]
const live = new Map(existing.map((message) => [message.id, message])) const live = new Map(existing.map((message) => [message.id, message]))
return combined.map((message) => return (page.sourceMode === "older" ? [...page.source, ...current] : [...current, ...page.source]).map(
load?.touchedSource.has(message.id) ? (live.get(message.id) ?? message) : message, (message) => (load?.touchedSource.has(message.id) ? (live.get(message.id) ?? message) : message),
) )
})() })()
: undefined : undefined
const merged = const projected =
page.projectSource && source page.projectSource && source
? (() => { ? (() => {
const normalized = normalizeSessionMessages(sessionID, source) const normalized = normalizeSessionMessages(sessionID, source)
return { return {
...page, ...page,
session: normalized.messages.sort(compareMessages), session: normalized.messages.sort(compareMessages),
part: [...normalized.parts.entries()].map(([id, part]) => ({ id, part })).sort((a, b) => cmp(a.id, b.id)), part: [...normalized.parts.entries()]
.map(([id, part]) => ({ id, part: part.sort((a, b) => cmp(a.id, b.id)) }))
.sort((a, b) => cmp(a.id, b.id)),
} }
})() })()
: page : page
const merged = mergeOptimisticPage(projected, [...(optimistic.get(sessionID)?.values() ?? [])])
merged.observed.forEach((item) => {
if (!load?.clearedMessageParts.has(item.messageID)) confirmOptimistic(sessionID, item.messageID, item.parts)
})
const touchedMessages = new Set([...(load?.touchedMessages ?? []), ...(removedMessages.get(sessionID) ?? [])]) const touchedMessages = new Set([...(load?.touchedMessages ?? []), ...(removedMessages.get(sessionID) ?? [])])
const messages = reconcileFetched(merged.session, data.message[sessionID] ?? [], { const messages = reconcileFetched(merged.session, data.message[sessionID] ?? [], {
touched: touchedMessages, touched: touchedMessages,
retained: load?.retainedMessages, retained: load?.retainedMessages,
removed: load?.removedMessages, removed: load?.removedMessages,
preserveUnfetched: (message) => preserveUnfetched,
echoes.get(sessionID)?.has(message.id) === true ||
preserveUnfetched === true ||
(typeof preserveUnfetched === "function" && preserveUnfetched(message)),
compare: compareMessages, compare: compareMessages,
}) })
batch(() => { batch(() => {
@@ -631,13 +705,14 @@ export function createServerSession(
} }
orphanParts.delete(sessionID) orphanParts.delete(sessionID)
} }
setMeta("limit", sessionID, messages.length)
setMeta("cursor", sessionID, merged.cursor) setMeta("cursor", sessionID, merged.cursor)
setMeta("complete", sessionID, merged.complete) setMeta("complete", sessionID, merged.complete)
setMeta("at", sessionID, Date.now()) setMeta("at", sessionID, Date.now())
}) })
} }
const loadMessages = async (sessionID: string, before?: string, mode?: "replace" | "prepend") => { const loadMessages = async (sessionID: string, limit: number, before?: string, mode?: "replace" | "prepend") => {
if (meta.loading[sessionID]) return if (meta.loading[sessionID]) return
const active = generation(sessionID) const active = generation(sessionID)
const load: MessageLoadState = { const load: MessageLoadState = {
@@ -648,6 +723,7 @@ export function createServerSession(
deltaParts: new Map(), deltaParts: new Map(),
carriedDeltaParts: new Map(), carriedDeltaParts: new Map(),
removedParts: new Map(), removedParts: new Map(),
optimisticParts: new Map(),
orphanParents: new Set(), orphanParents: new Set(),
clearedMessageParts: new Set(), clearedMessageParts: new Set(),
touchedSource: new Set(), touchedSource: new Set(),
@@ -656,7 +732,7 @@ export function createServerSession(
setMeta("loading", sessionID, true) setMeta("loading", sessionID, true)
let applied = false let applied = false
try { try {
const page = await fetchMessages(sessionID, before, () => resetMessageLoad(sessionID, load)) const page = await fetchMessages(sessionID, limit, before, () => resetMessageLoad(sessionID, load))
const first = page.session.reduce<Message | undefined>( const first = page.session.reduce<Message | undefined>(
(oldest, message) => (!oldest || compareMessages(message, oldest) < 0 ? message : oldest), (oldest, message) => (!oldest || compareMessages(message, oldest) < 0 ? message : oldest),
undefined, undefined,
@@ -668,7 +744,11 @@ export function createServerSession(
const users = new Set([ const users = new Set([
...page.session.filter((message) => message.role === "user").map((message) => message.id), ...page.session.filter((message) => message.role === "user").map((message) => message.id),
...(data.message[sessionID] ?? []) ...(data.message[sessionID] ?? [])
.filter((message) => message.role === "user" && load.touchedMessages.has(message.id)) .filter((message) => {
if (message.role !== "user") return false
const item = optimistic.get(sessionID)?.get(message.id)
return load.touchedMessages.has(message.id) && (!item || item.confirmedMessage === true)
})
.map((message) => message.id), .map((message) => message.id),
]) ])
const parentIDs = [ const parentIDs = [
@@ -735,30 +815,32 @@ export function createServerSession(
} }
} }
const sync = (sessionID: string, options?: { force?: boolean }) => { const sync = (sessionID: string, options?: { force?: boolean; messageLimit?: number }) => {
touch(sessionID) touch(sessionID)
return runInflight(inflight, sessionID, async () => { return runInflight(inflight, sessionID, async () => {
const cached = data.message[sessionID] !== undefined && meta.complete[sessionID] !== undefined const cached = data.message[sessionID] !== undefined && meta.limit[sessionID] !== undefined
const invalid = invalidated.has(sessionID) const invalid = invalidated.has(sessionID)
const revision = invalidationRevision const revision = invalidationRevision
if (cached && data.info[sessionID] && !invalid && !options?.force) return if (cached && data.info[sessionID] && !invalid && !options?.force) return
await Promise.all([ await Promise.all([
resolve(sessionID, invalid ? { ...options, force: true } : options), resolve(sessionID, invalid ? { ...options, force: true } : options),
cached && !invalid && !options?.force ? Promise.resolve() : loadMessages(sessionID), cached && !invalid && !options?.force
? Promise.resolve()
: loadMessages(sessionID, options?.messageLimit ?? meta.limit[sessionID] ?? initialMessagePageSize),
]) ])
if (invalid && invalidationRevision === revision) invalidated.delete(sessionID) if (invalid && invalidationRevision === revision) invalidated.delete(sessionID)
}) })
} }
const prefetch = async (sessionID: string, messageCount: number) => { const prefetch = async (sessionID: string, limit: number) => {
touch(sessionID) touch(sessionID)
await inflight.get(sessionID) await inflight.get(sessionID)
if ( if (
Date.now() - (meta.at[sessionID] ?? 0) <= 15_000 && Date.now() - (meta.at[sessionID] ?? 0) <= 15_000 &&
(meta.complete[sessionID] || (data.message[sessionID]?.length ?? 0) >= messageCount) (meta.complete[sessionID] || (data.message[sessionID]?.length ?? 0) >= limit)
) )
return return
await runInflight(inflight, sessionID, () => loadMessages(sessionID)) await runInflight(inflight, sessionID, () => loadMessages(sessionID, limit))
} }
const eventSessionID = (event: { type: string; properties?: unknown }) => { const eventSessionID = (event: { type: string; properties?: unknown }) => {
@@ -811,12 +893,12 @@ export function createServerSession(
apply({ type: "message.updated", properties: { sessionID: reduction.sessionID, info: message } }) apply({ type: "message.updated", properties: { sessionID: reduction.sessionID, info: message } })
} }
for (const messageID of touched) { for (const messageID of touched) {
const next = present(messageID, normalized.parts.get(messageID) ?? []) const next = normalized.parts.get(messageID) ?? []
const nextIDs = new Set(next.map((part) => part.id)) const nextIDs = new Set(next.map((part) => part.id))
for (const part of next) { for (const part of next) {
apply({ type: "message.part.updated", properties: { sessionID: reduction.sessionID, part } }) apply({ type: "message.part.updated", properties: { sessionID: reduction.sessionID, part } })
} }
for (const part of [...(data.part[messageID] ?? [])]) { for (const part of data.part[messageID] ?? []) {
if (nextIDs.has(part.id)) continue if (nextIDs.has(part.id)) continue
apply({ apply({
type: "message.part.removed", type: "message.part.removed",
@@ -844,67 +926,6 @@ export function createServerSession(
.catch(() => {}) .catch(() => {})
} }
const removeEcho = (sessionID: string, messageID: string) => {
if (!releaseEcho(sessionID, messageID)) return false
pendingRevision.set(sessionID, (pendingRevision.get(sessionID) ?? 0) + 1)
const load = messageLoads.get(sessionID)
load?.touchedMessages.add(messageID)
load?.removedMessages.add(messageID)
load?.clearedMessageParts.add(messageID)
batch(() => {
setData("pending", sessionID, (items) => items?.filter((item) => item.id !== messageID))
setData("input", sessionID, (items) => items?.filter((id) => id !== messageID))
setData("message", sessionID, (messages) => messages?.filter((message) => message.id !== messageID))
setData(produce((draft) => deleteMessageParts(draft, messageID)))
})
return true
}
const confirmInbox = (item: SessionInboxInfo) => {
if (!confirmEcho(item.sessionID, item.id)) return false
v2.confirm(item)
pendingRevision.set(item.sessionID, (pendingRevision.get(item.sessionID) ?? 0) + 1)
const current = data.pending[item.sessionID] ?? []
const index = current.findIndex((entry) => entry.id === item.id)
if (index < 0) setData("pending", item.sessionID, [...current, item])
if (index >= 0) setData("pending", item.sessionID, index, reconcile(item))
return true
}
const reconcileInbox = (sessionID: string) => {
const pending = new Set((data.pending[sessionID] ?? []).map((item) => item.id))
const fetched = messageSnapshots.get(sessionID) ?? new Set<string>()
const removed = [...(settledInputs.get(sessionID) ?? [])].filter(
(messageID) => !pending.has(messageID) && !fetched.has(messageID),
)
settledInputs.delete(sessionID)
if (removed.length) {
const ids = new Set(removed)
const source = data.session_message[sessionID] ?? []
projectV2({
sessionID,
messages: source.filter((message) => !ids.has(message.id)),
touched: [],
removed: source.filter((message) => ids.has(message.id)).map((message) => message.id),
})
}
const messages = echoes.get(sessionID)
if (!messages) return
const projected = new Set((data.session_message[sessionID] ?? []).map((message) => message.id))
for (const [messageID, state] of messages) {
if (projected.has(messageID)) {
releaseEcho(sessionID, messageID)
continue
}
if (pending.has(messageID)) {
confirmEcho(sessionID, messageID)
continue
}
if (state === "admitted") removeEcho(sessionID, messageID)
}
}
const applyV2 = (event: OpenCodeEvent) => { const applyV2 = (event: OpenCodeEvent) => {
if (event.type === "form.created") { if (event.type === "form.created") {
formRevision.set(event.data.form.sessionID, (formRevision.get(event.data.form.sessionID) ?? 0) + 1) formRevision.set(event.data.form.sessionID, (formRevision.get(event.data.form.sessionID) ?? 0) + 1)
@@ -928,9 +949,6 @@ export function createServerSession(
} }
if (!("data" in event) || !("sessionID" in event.data) || typeof event.data.sessionID !== "string") return if (!("data" in event) || !("sessionID" in event.data) || typeof event.data.sessionID !== "string") return
const sessionID = event.data.sessionID const sessionID = event.data.sessionID
if (event.type === "session.inbox.enqueued" || event.type === "session.inbox.delivered")
releaseEcho(sessionID, event.data.inboxID)
if (event.type === "session.inbox.cancelled") removeEcho(sessionID, event.data.inboxID)
if ( if (
event.type === "session.inbox.enqueued" || event.type === "session.inbox.enqueued" ||
event.type === "session.inbox.delivery.changed" || event.type === "session.inbox.delivery.changed" ||
@@ -942,10 +960,11 @@ export function createServerSession(
pendingRevision.set(sessionID, (pendingRevision.get(sessionID) ?? 0) + 1) pendingRevision.set(sessionID, (pendingRevision.get(sessionID) ?? 0) + 1)
if (event.type === "session.inbox.enqueued") { if (event.type === "session.inbox.enqueued") {
const current = data.pending[sessionID] ?? [] const current = data.pending[sessionID] ?? []
const item = { id: event.data.inboxID, sessionID, timeCreated: event.created, ...event.data.item } if (!current.some((item) => item.id === event.data.inboxID))
const index = current.findIndex((entry) => entry.id === event.data.inboxID) setData("pending", sessionID, [
if (index < 0) setData("pending", sessionID, [...current, item]) ...current,
if (index >= 0) setData("pending", sessionID, index, reconcile(item)) { id: event.data.inboxID, sessionID, timeCreated: event.created, ...event.data.item },
])
if (event.data.item.type !== "compaction" && !data.input[sessionID]?.includes(event.data.inboxID)) if (event.data.item.type !== "compaction" && !data.input[sessionID]?.includes(event.data.inboxID))
setData("input", sessionID, [...(data.input[sessionID] ?? []), event.data.inboxID]) setData("input", sessionID, [...(data.input[sessionID] ?? []), event.data.inboxID])
} }
@@ -1082,9 +1101,16 @@ export function createServerSession(
} }
case "message.updated": { case "message.updated": {
const info = (event.properties as { info: Message }).info const info = (event.properties as { info: Message }).info
indexProjectedMessage(info)
const load = messageLoads.get(info.sessionID) const load = messageLoads.get(info.sessionID)
load?.touchedMessages.add(info.id) load?.touchedMessages.add(info.id)
load?.removedMessages.delete(info.id) load?.removedMessages.delete(info.id)
const items = optimistic.get(info.sessionID)
const item = items?.get(info.id)
if (items && item) {
if (item.parts.length === 0) clearOptimistic(info.sessionID, info.id)
if (item.parts.length > 0) items.set(info.id, { ...item, confirmedMessage: true })
}
const orphans = orphanParts.get(info.sessionID) const orphans = orphanParts.get(info.sessionID)
orphans?.delete(info.id) orphans?.delete(info.id)
if (orphans?.size === 0) orphanParts.delete(info.sessionID) if (orphans?.size === 0) orphanParts.delete(info.sessionID)
@@ -1097,18 +1123,13 @@ export function createServerSession(
return return
} }
const result = Binary.search(messages, messageKey(info), messageKey) const result = Binary.search(messages, messageKey(info), messageKey)
if (result.found) { if (result.found) setData("message", info.sessionID, result.index, reconcile(info))
setData("message", info.sessionID, result.index, reconcile(info)) if (!result.found)
return setData("message", info.sessionID, (value = []) => {
} const next = value.slice()
// Delivery rewrites time.created, changing the sort key; reposition instead of duplicating. next.splice(result.index, 0, info)
setData("message", info.sessionID, (value = []) => { return next
const next = value.slice() })
const moved = next.findIndex((message) => message.id === info.id)
if (moved >= 0) next.splice(moved, 1)
next.splice(moved >= 0 && moved < result.index ? result.index - 1 : result.index, 0, info)
return next
})
return return
} }
case "message.removed": { case "message.removed": {
@@ -1123,11 +1144,13 @@ export function createServerSession(
load?.deltaParts.delete(props.messageID) load?.deltaParts.delete(props.messageID)
load?.carriedDeltaParts.delete(props.messageID) load?.carriedDeltaParts.delete(props.messageID)
load?.removedParts.delete(props.messageID) load?.removedParts.delete(props.messageID)
load?.optimisticParts.delete(props.messageID)
pendingParts.get(props.sessionID)?.delete(props.messageID) pendingParts.get(props.sessionID)?.delete(props.messageID)
if (pendingParts.get(props.sessionID)?.size === 0) pendingParts.delete(props.sessionID) if (pendingParts.get(props.sessionID)?.size === 0) pendingParts.delete(props.sessionID)
const removedMessagesForSession = removedMessages.get(props.sessionID) ?? new Set<string>() const removedMessagesForSession = removedMessages.get(props.sessionID) ?? new Set<string>()
removedMessagesForSession.add(props.messageID) removedMessagesForSession.add(props.messageID)
removedMessages.set(props.sessionID, removedMessagesForSession) removedMessages.set(props.sessionID, removedMessagesForSession)
clearOptimistic(props.sessionID, props.messageID)
setData( setData(
produce((draft) => { produce((draft) => {
const messages = draft.message[props.sessionID] const messages = draft.message[props.sessionID]
@@ -1173,8 +1196,12 @@ export function createServerSession(
pending?.delete(part.id) pending?.delete(part.id)
if (pending?.size === 0) pendingParts.get(part.sessionID)?.delete(part.messageID) if (pending?.size === 0) pendingParts.get(part.sessionID)?.delete(part.messageID)
if (pendingParts.get(part.sessionID)?.size === 0) pendingParts.delete(part.sessionID) if (pendingParts.get(part.sessionID)?.size === 0) pendingParts.delete(part.sessionID)
const optimistic = load?.optimisticParts.get(part.messageID)
optimistic?.delete(part.id)
if (optimistic?.size === 0) load?.optimisticParts.delete(part.messageID)
deltaBases.delete(part.id) deltaBases.delete(part.id)
trackPartChange(part.sessionID, part.messageID, part.id) trackPartChange(part.sessionID, part.messageID, part.id)
confirmOptimisticPart(part.sessionID, part.messageID, part)
setData( setData(
"part_text_accum_delta", "part_text_accum_delta",
produce((draft) => void delete draft[part.id]), produce((draft) => void delete draft[part.id]),
@@ -1184,9 +1211,14 @@ export function createServerSession(
setData("part", part.messageID, [part]) setData("part", part.messageID, [part])
return return
} }
const index = parts.findIndex((item) => item.id === part.id) const result = Binary.search(parts, part.id, (item) => item.id)
if (index >= 0) setData("part", part.messageID, index, reconcile(part)) if (result.found) setData("part", part.messageID, result.index, reconcile(part))
if (index < 0) setData("part", part.messageID, (value = []) => [...value, part]) if (!result.found)
setData("part", part.messageID, (value = []) => {
const next = value.slice()
next.splice(result.index, 0, part)
return next
})
return return
} }
case "message.part.removed": { case "message.part.removed": {
@@ -1208,16 +1240,20 @@ export function createServerSession(
const parts = load.removedParts.get(props.messageID) ?? new Set<string>() const parts = load.removedParts.get(props.messageID) ?? new Set<string>()
parts.add(props.partID) parts.add(props.partID)
load.removedParts.set(props.messageID, parts) load.removedParts.set(props.messageID, parts)
const optimistic = load.optimisticParts.get(props.messageID)
optimistic?.delete(props.partID)
if (optimistic?.size === 0) load.optimisticParts.delete(props.messageID)
} }
trackPartChange(props.sessionID, props.messageID, props.partID) trackPartChange(props.sessionID, props.messageID, props.partID)
clearOptimisticPart(props.sessionID, props.messageID, props.partID)
setData( setData(
produce((draft) => { produce((draft) => {
delete draft.part_text_accum_delta[props.partID] delete draft.part_text_accum_delta[props.partID]
deltaBases.delete(props.partID) deltaBases.delete(props.partID)
const parts = draft.part[props.messageID] const parts = draft.part[props.messageID]
if (!parts) return if (!parts) return
const index = parts.findIndex((part) => part.id === props.partID) const result = Binary.search(parts, props.partID, (part) => part.id)
if (index >= 0) parts.splice(index, 1) if (result.found) parts.splice(result.index, 1)
if (parts.length === 0) delete draft.part[props.messageID] if (parts.length === 0) delete draft.part[props.messageID]
}), }),
) )
@@ -1233,8 +1269,8 @@ export function createServerSession(
} }
const parts = data.part[props.messageID] const parts = data.part[props.messageID]
if (!parts) return if (!parts) return
const index = parts.findIndex((part) => part.id === props.partID) const result = Binary.search(parts, props.partID, (part) => part.id)
if (index < 0) return if (!result.found) return
trackPartChange(props.sessionID, props.messageID, props.partID) trackPartChange(props.sessionID, props.messageID, props.partID)
const load = messageLoads.get(props.sessionID) const load = messageLoads.get(props.sessionID)
if (load) { if (load) {
@@ -1246,7 +1282,7 @@ export function createServerSession(
if (carried?.size === 0) load.carriedDeltaParts.delete(props.messageID) if (carried?.size === 0) load.carriedDeltaParts.delete(props.messageID)
} }
const field = props.field as keyof (typeof parts)[number] const field = props.field as keyof (typeof parts)[number]
const current = parts[index]?.[field] const current = parts[result.index]?.[field]
if (!deltaBases.has(props.partID) && typeof current === "string") if (!deltaBases.has(props.partID) && typeof current === "string")
deltaBases.set(props.partID, { base: current, sessionID: props.sessionID }) deltaBases.set(props.partID, { base: current, sessionID: props.sessionID })
setData( setData(
@@ -1259,7 +1295,7 @@ export function createServerSession(
props.messageID, props.messageID,
produce((draft) => { produce((draft) => {
if (!draft) return if (!draft) return
const part = draft[index] const part = draft[result.index]
const field = props.field as keyof typeof part const field = props.field as keyof typeof part
;(part[field] as string) = ((part[field] as string | undefined) ?? "") + props.delta ;(part[field] as string) = ((part[field] as string | undefined) ?? "") + props.delta
}), }),
@@ -1318,30 +1354,25 @@ export function createServerSession(
while (true) { while (true) {
const pendingAt = pendingRevision.get(sessionID) ?? 0 const pendingAt = pendingRevision.get(sessionID) ?? 0
const formAt = formRevision.get(sessionID) ?? 0 const formAt = formRevision.get(sessionID) ?? 0
const previous = new Set(data.input[sessionID] ?? [])
const result = await load() const result = await load()
const pendingStable = (pendingRevision.get(sessionID) ?? 0) === pendingAt const pendingStable = (pendingRevision.get(sessionID) ?? 0) === pendingAt
const formStable = (formRevision.get(sessionID) ?? 0) === formAt const formStable = (formRevision.get(sessionID) ?? 0) === formAt
if (pendingStable) { if (pendingStable) {
const current = new Set(result.pending.filter((item) => item.type !== "compaction").map((item) => item.id))
const settled = settledInputs.get(sessionID) ?? new Set<string>()
previous.forEach((messageID) => {
if (!current.has(messageID)) settled.add(messageID)
})
if (settled.size) settledInputs.set(sessionID, settled)
result.pending.forEach(v2.confirm)
setData("pending", sessionID, reconcile(result.pending)) setData("pending", sessionID, reconcile(result.pending))
setData("input", sessionID, reconcile([...current])) setData(
"input",
sessionID,
reconcile(result.pending.filter((item) => item.type !== "compaction").map((item) => item.id)),
)
} }
if (formStable) setData("form", sessionID, reconcile(result.forms)) if (formStable) setData("form", sessionID, reconcile(result.forms))
if (pendingStable && formStable) return if (pendingStable && formStable) return
} }
}, },
refreshPinned(hydrateTransient: (sessionID: string) => Promise<void>) { refreshPinned(hydrateTransient: (sessionID: string) => Promise<void>) {
const sessions = [...pinned.keys()]
return Promise.all( return Promise.all(
sessions.flatMap((sessionID) => [sync(sessionID, { force: true }), hydrateTransient(sessionID)]), [...pinned.keys()].flatMap((sessionID) => [sync(sessionID, { force: true }), hydrateTransient(sessionID)]),
).then(() => sessions.forEach(reconcileInbox)) ).then(() => undefined)
}, },
invalidate() { invalidate() {
invalidationRevision += 1 invalidationRevision += 1
@@ -1350,81 +1381,77 @@ export function createServerSession(
setMeta("at", {}) setMeta("at", {})
}, },
prefetch, prefetch,
shouldPrefetch(sessionID: string, messageCount: number) { shouldPrefetch(sessionID: string, limit: number) {
if (data.message[sessionID] === undefined) return true if (data.message[sessionID] === undefined) return true
if (Date.now() - (meta.at[sessionID] ?? 0) > 15_000) return true if (Date.now() - (meta.at[sessionID] ?? 0) > 15_000) return true
if (meta.complete[sessionID]) return false if (meta.complete[sessionID]) return false
return (data.message[sessionID]?.length ?? 0) <= messageCount return (meta.limit[sessionID] ?? 0) <= limit
}, },
fresh(sessionID: string, ttl: number) { fresh(sessionID: string, ttl: number) {
return Date.now() - (meta.at[sessionID] ?? 0) <= ttl return Date.now() - (meta.at[sessionID] ?? 0) <= ttl
}, },
inbox: { optimistic: {
echo(input: PromptEcho) { add(input: { sessionID: string; message: Message; parts: Part[] }) {
const created = Date.now() const parts = input.parts
const files = input.files?.map((file) => ({ .filter((part) => !!part?.id && !SKIP_PARTS.has(part.type))
data: "", .sort((a, b) => cmp(a.id, b.id))
mime: file.mime, const load = messageLoads.get(input.sessionID)
source: { type: "uri" as const, uri: file.uri }, if (load?.clearedMessageParts.has(input.message.id)) {
name: file.name, const touched = load.touchedParts.get(input.message.id) ?? new Set<string>()
mention: file.mention, parts.forEach((part) => touched.add(part.id))
})) load.touchedParts.set(input.message.id, touched)
const item: SessionInboxInfo = {
id: input.messageID,
sessionID: input.sessionID,
timeCreated: created,
type: "user",
delivery: "steer",
payload: { text: input.text, files, agents: input.agents },
} }
const projected = normalizeSessionMessages(input.sessionID, [ if (load) {
{ id: `${input.messageID}:agent`, type: "agent-switched", agent: input.agent, time: { created } }, load.removedMessages.delete(input.message.id)
{ load.optimisticParts.set(input.message.id, new Set(parts.map((part) => part.id)))
id: `${input.messageID}:model`, }
type: "model-switched", const items = optimistic.get(input.sessionID)
model: { const removedMessagesForSession = removedMessages.get(input.sessionID)
id: input.model.modelID, removedMessagesForSession?.delete(input.message.id)
providerID: input.model.providerID, if (removedMessagesForSession?.size === 0) removedMessages.delete(input.sessionID)
variant: input.model.variant, if (items) items.set(input.message.id, { ...input, parts, confirmedParts: [] })
}, if (!items)
time: { created }, optimistic.set(input.sessionID, new Map([[input.message.id, { ...input, parts, confirmedParts: [] }]]))
}, indexProjectedMessage(input.message)
{ setData("message", input.sessionID, (messages = []) => merge(messages, [input.message]).sort(compareMessages))
id: input.messageID, setData(
type: "user", "part_text_accum_delta",
text: input.displayText, produce((draft) => {
files, for (const part of [...(data.part[input.message.id] ?? []), ...parts]) {
agents: input.agents, delete draft[part.id]
time: { created }, deltaBases.delete(part.id)
}, }
]) }),
const message = projected.messages[0]! )
const comments: Part[] = input.comments.map((comment, index) => ({ setData("part", input.message.id, parts)
id: `${input.messageID}:comment:${index}`,
sessionID: input.sessionID,
messageID: input.messageID,
type: "text",
text: formatCommentNote(comment),
synthetic: true,
metadata: createCommentMetadata(comment),
}))
const parts = [...(projected.parts.get(input.messageID) ?? []), ...comments]
removedMessages.get(input.sessionID)?.delete(input.messageID)
markEcho(input.sessionID, input.messageID)
pendingRevision.set(input.sessionID, (pendingRevision.get(input.sessionID) ?? 0) + 1)
batch(() => {
setData("pending", input.sessionID, (items = []) => [...items.filter((entry) => entry.id !== item.id), item])
if (!data.input[input.sessionID]?.includes(input.messageID))
setData("input", input.sessionID, [...(data.input[input.sessionID] ?? []), input.messageID])
setData("message", input.sessionID, (messages = []) => merge(messages, [message]).sort(compareMessages))
setData("part", input.messageID, parts)
})
}, },
confirm: confirmInbox, remove(input: { sessionID: string; messageID: string }) {
reconcile: reconcileInbox, const item = optimistic.get(input.sessionID)?.get(input.messageID)
clearEcho(input: { sessionID: string; messageID: string }) { if (!item) return
if (echoes.get(input.sessionID)?.get(input.messageID) !== "sending") return false messageLoads.get(input.sessionID)?.optimisticParts.delete(input.messageID)
return removeEcho(input.sessionID, input.messageID) clearOptimistic(input.sessionID, input.messageID)
if (item.confirmedMessage) {
const partIDs = new Set(item.parts.map((part) => part.id))
setData(
produce((draft) => {
for (const part of item.parts) {
delete draft.part_text_accum_delta[part.id]
deltaBases.delete(part.id)
}
const parts = draft.part[input.messageID]
if (!parts) return
draft.part[input.messageID] = parts.filter((part) => !partIDs.has(part.id))
if (draft.part[input.messageID]?.length === 0) delete draft.part[input.messageID]
}),
)
return
}
const projectedIDs = new Set(projectMessageSource(item.message).map((message) => message.id))
setData("session_message", input.sessionID, (messages) =>
messages?.filter((message) => !projectedIDs.has(message.id)),
)
setData("message", input.sessionID, (messages) => messages?.filter((message) => message.id !== input.messageID))
setData(produce((draft) => deleteMessageParts(draft, input.messageID)))
}, },
}, },
async todo(sessionID: string, request?: { force?: boolean }) { async todo(sessionID: string, request?: { force?: boolean }) {
@@ -1436,14 +1463,14 @@ export function createServerSession(
history: { history: {
more: (sessionID: string) => more: (sessionID: string) =>
data.message[sessionID] !== undefined && data.message[sessionID] !== undefined &&
meta.complete[sessionID] !== undefined && meta.limit[sessionID] !== undefined &&
!meta.complete[sessionID] && !meta.complete[sessionID] &&
!!meta.cursor[sessionID], !!meta.cursor[sessionID],
loading: (sessionID: string) => meta.loading[sessionID] ?? false, loading: (sessionID: string) => meta.loading[sessionID] ?? false,
async loadMore(sessionID: string) { async loadMore(sessionID: string, count = historyMessagePageSize) {
touch(sessionID) touch(sessionID)
if (meta.loading[sessionID] || meta.complete[sessionID] || !meta.cursor[sessionID]) return if (meta.loading[sessionID] || meta.complete[sessionID] || !meta.cursor[sessionID]) return
await loadMessages(sessionID, meta.cursor[sessionID], "prepend") await loadMessages(sessionID, count, meta.cursor[sessionID], "prepend")
}, },
}, },
evict(sessionID: string) { evict(sessionID: string) {
@@ -2,7 +2,6 @@ import { describe, expect, test } from "bun:test"
import type { import type {
McpListInput, McpListInput,
McpResourceCatalogInput, McpResourceCatalogInput,
OpenCodeEvent,
SessionApi, SessionApi,
SessionInfo, SessionInfo,
SessionListInput, SessionListInput,
@@ -16,13 +15,11 @@ import {
loadMcpResourcesQuery, loadMcpResourcesQuery,
reconcileActiveSessionStatuses, reconcileActiveSessionStatuses,
seedActiveSessionStatuses, seedActiveSessionStatuses,
sessionListEventDirectories,
shouldRefreshWorkspaceSessions, shouldRefreshWorkspaceSessions,
} from "./server-sync" } from "./server-sync"
import { ServerScope } from "@/utils/server-scope" import { ServerScope } from "@/utils/server-scope"
import { createServerSession } from "./server-session" import { createServerSession } from "./server-session"
import type { ServerApi } from "@/utils/server" import type { ServerApi } from "@/utils/server"
import { adaptServerEvent } from "./server-sdk"
type McpApi = ServerApi["mcp"] type McpApi = ServerApi["mcp"]
@@ -217,23 +214,6 @@ describe("workspace session inventory", () => {
expect(shouldRefreshWorkspaceSessions(event("session.updated", "session.moved"))).toBe(true) expect(shouldRefreshWorkspaceSessions(event("session.updated", "session.moved"))).toBe(true)
expect(shouldRefreshWorkspaceSessions(event("message.updated"))).toBe(false) expect(shouldRefreshWorkspaceSessions(event("message.updated"))).toBe(false)
}) })
test("invalidates both locations when a session moves", () => {
const event = adaptServerEvent({
id: "evt_moved",
created: 1,
type: "session.moved",
durable: { aggregateID: "ses_1", seq: 1, version: 1 },
location: { directory: "/source" },
data: {
sessionID: "ses_1",
location: { directory: "/destination" },
projectID: "project_2",
},
} satisfies Extract<OpenCodeEvent, { type: "session.moved" }>)
expect(sessionListEventDirectories(event)).toEqual(["/source", "/destination"])
})
}) })
describe("canDisposeDirectory", () => { describe("canDisposeDirectory", () => {
+16 -18
View File
@@ -88,12 +88,6 @@ const SESSION_LIST_EVENTS = new Set([
"session.usage.updated", "session.usage.updated",
]) ])
export function sessionListEventDirectories(event: ServerEvent) {
if (!SESSION_LIST_EVENTS.has(event.current?.type ?? event.type)) return []
const destination = event.current?.type === "session.moved" ? event.current.data.location.directory : undefined
return [...new Set([event.current?.location?.directory, destination].filter((item): item is string => !!item))]
}
type McpListApi = { type McpListApi = {
readonly list: (input?: McpListInput) => Promise<McpListOutput> readonly list: (input?: McpListInput) => Promise<McpListOutput>
} }
@@ -237,10 +231,7 @@ export function createServerSyncContextInner(serverSDK: ServerSDK) {
return { pending, forms } return { pending, forms }
}) })
} }
const hydrateSession = async (sessionID: string) => { const hydrateSession = (sessionID: string) => Promise.all([session.sync(sessionID), hydrateSessionState(sessionID)])
await Promise.all([session.sync(sessionID), hydrateSessionState(sessionID)])
session.inbox.reconcile(sessionID)
}
const [configQuery, providerQuery, pathQuery] = useQueries(() => ({ const [configQuery, providerQuery, pathQuery] = useQueries(() => ({
queries: [ queries: [
@@ -560,11 +551,14 @@ export function createServerSyncContextInner(serverSDK: ServerSDK) {
type: "session.updated", type: "session.updated",
properties: { sessionID: info.id, info }, properties: { sessionID: info.id, info },
}) })
const markSessionListsChanged = (event: ServerEvent) => { const markSessionListChanged = (event: ServerEvent, directory: string, previousDirectory?: string) => {
sessionListEventDirectories(event).forEach((directory) => { if (SESSION_LIST_EVENTS.has(event.current?.type ?? event.type)) {
const key = directoryKey(directory) const key = directoryKey(directory)
sessionRevision.set(key, (sessionRevision.get(key) ?? 0) + 1) sessionRevision.set(key, (sessionRevision.get(key) ?? 0) + 1)
}) }
if (!previousDirectory || previousDirectory === directory) return
const key = directoryKey(previousDirectory)
sessionRevision.set(key, (sessionRevision.get(key) ?? 0) + 1)
} }
const toDirectoryEvent = (event: ServerEvent) => { const toDirectoryEvent = (event: ServerEvent) => {
if (event.current?.type === "session.created") return if (event.current?.type === "session.created") return
@@ -575,10 +569,15 @@ export function createServerSyncContextInner(serverSDK: ServerSDK) {
} }
const unsub = serverSDK.event.listen((e) => { const unsub = serverSDK.event.listen((e) => {
const directory = e.name
const key = directoryKey(directory)
const event = e.details const event = e.details
const directory = event.current?.location?.directory
const eventType: string = event.type const eventType: string = event.type
markSessionListsChanged(event) const previousDirectory =
event.current?.type === "session.moved"
? session.get(event.current.data.sessionID)?.location.directory
: undefined
markSessionListChanged(event, directory, previousDirectory)
if (event.current) session.applyV2(event.current) if (event.current) session.applyV2(event.current)
session.apply(event) session.apply(event)
if (event.current?.type === "session.moved") { if (event.current?.type === "session.moved") {
@@ -630,9 +629,9 @@ export function createServerSyncContextInner(serverSDK: ServerSDK) {
} }
homeSessions.refresh(event.type) homeSessions.refresh(event.type)
catalog.handleEvent({ type: eventType, directory }) catalog.handleEvent({ type: eventType, directory })
connection.handleEvent({ type: eventType }) connection.handleEvent({ type: eventType, directory })
if (!directory) { if (directory === "global") {
applyGlobalEvent({ applyGlobalEvent({
event, event,
project: globalStore.project, project: globalStore.project,
@@ -645,7 +644,6 @@ export function createServerSyncContextInner(serverSDK: ServerSDK) {
return return
} }
const key = directoryKey(directory)
if (event.current?.type === "session.forked") if (event.current?.type === "session.forked")
void session void session
.resolve(event.current.data.sessionID, { force: true }) .resolve(event.current.data.sessionID, { force: true })
@@ -42,7 +42,7 @@ test("invalidates global and active catalogs after connection", async () => {
load: async () => {}, load: async () => {},
}) })
catalog.handleEvent({ type: "server.connected" }) catalog.handleEvent({ type: "server.connected", directory: "global" })
await Bun.sleep(0) await Bun.sleep(0)
expect(queryClient.getQueryState(global)?.isInvalidated).toBe(true) expect(queryClient.getQueryState(global)?.isInvalidated).toBe(true)
@@ -4,7 +4,7 @@ import { pathKey, type PathKey } from "@/utils/path-key"
type CatalogEvent = { type CatalogEvent = {
type: string type: string
directory?: string directory: string
} }
export function createCatalogSync(input: { export function createCatalogSync(input: {
@@ -24,7 +24,7 @@ export function createCatalogSync(input: {
event.type === "integration.updated" || event.type === "integration.updated" ||
event.type === "integration.connection.updated" event.type === "integration.connection.updated"
) { ) {
void refresh(event.directory ? pathKey(event.directory) : null).catch(() => undefined) void refresh(event.directory === "global" ? null : pathKey(event.directory)).catch(() => undefined)
} }
} }
@@ -12,8 +12,10 @@ test("invalidates disconnected data and synchronizes after the handshake", () =>
connected: () => calls.push("connected"), connected: () => calls.push("connected"),
}) })
connection.handleEvent({ type: "server.connected" }) connection.handleEvent({ type: "server.connected", directory: "global" })
expect(calls).toContain("connected") expect(calls).toContain("connected")
connection.handleEvent({ type: "server.connected", directory: "/repo" })
expect(calls.filter((call) => call === "connected")).toHaveLength(1)
setStatus("connected") setStatus("connected")
return dispose return dispose
}) })
@@ -12,8 +12,8 @@ export function createConnectionSync(input: {
}) })
let connectedOnce = false let connectedOnce = false
function handleEvent(event: { type: string }) { function handleEvent(event: { type: string; directory: string }) {
if (event.type !== "server.connected") return if (event.directory !== "global" || event.type !== "server.connected") return
input.connected({ reconnect: connectedOnce }) input.connected({ reconnect: connectedOnce })
connectedOnce = true connectedOnce = true
} }
@@ -0,0 +1,137 @@
import { describe, expect, test } from "bun:test"
import type { Message, Part } from "@/types"
import { applyOptimisticAdd, applyOptimisticRemove, mergeOptimisticPage } from "./sync"
type Text = Extract<Part, { type: "text" }>
const userMessage = (id: string, sessionID: string, created = 1): Message => ({
id,
sessionID,
role: "user",
time: { created },
agent: "assistant",
model: { providerID: "openai", modelID: "gpt" },
})
const textPart = (id: string, sessionID: string, messageID: string): Text => ({
id,
sessionID,
messageID,
type: "text",
text: id,
})
describe("sync optimistic reducers", () => {
test("applyOptimisticAdd inserts by creation time", () => {
const sessionID = "ses_1"
const draft = {
message: { [sessionID]: [userMessage("msg_z", sessionID, 1)] },
part: {} as Record<string, Part[] | undefined>,
}
applyOptimisticAdd(draft, {
sessionID,
message: userMessage("msg_a", sessionID, 2),
parts: [textPart("prt_2", sessionID, "msg_a"), textPart("prt_1", sessionID, "msg_a")],
})
expect(draft.message[sessionID]?.map((x) => x.id)).toEqual(["msg_z", "msg_a"])
expect(draft.part.msg_a?.map((x) => x.id)).toEqual(["prt_1", "prt_2"])
})
test("applyOptimisticRemove removes message and part entries", () => {
const sessionID = "ses_1"
const draft = {
message: { [sessionID]: [userMessage("msg_1", sessionID), userMessage("msg_2", sessionID)] },
part: {
msg_1: [textPart("prt_1", sessionID, "msg_1")],
msg_2: [textPart("prt_2", sessionID, "msg_2")],
} as Record<string, Part[] | undefined>,
}
applyOptimisticRemove(draft, { sessionID, messageID: "msg_1" })
expect(draft.message[sessionID]?.map((x) => x.id)).toEqual(["msg_2"])
expect(draft.part.msg_1).toBeUndefined()
expect(draft.part.msg_2).toHaveLength(1)
})
test("mergeOptimisticPage keeps pending messages in fetched timelines", () => {
const sessionID = "ses_1"
const page = mergeOptimisticPage(
{
session: [userMessage("msg_z", sessionID, 1)],
part: [{ id: "msg_z", part: [textPart("prt_1", sessionID, "msg_z")] }],
complete: true,
},
[{ message: userMessage("msg_a", sessionID, 2), parts: [textPart("prt_2", sessionID, "msg_a")] }],
)
expect(page.session.map((x) => x.id)).toEqual(["msg_z", "msg_a"])
expect(page.part.find((x) => x.id === "msg_a")?.part.map((x) => x.id)).toEqual(["prt_2"])
expect(page.confirmed).toEqual([])
expect(page.complete).toBe(true)
})
test("mergeOptimisticPage uses IDs only to break equal-time ties", () => {
const sessionID = "ses_1"
const page = mergeOptimisticPage(
{
session: [userMessage("msg_z", sessionID, 1)],
part: [],
complete: true,
},
[{ message: userMessage("msg_a", sessionID, 1), parts: [] }],
)
expect(page.session.map((message) => message.id)).toEqual(["msg_a", "msg_z"])
})
test("mergeOptimisticPage keeps missing optimistic parts until the server has them", () => {
const sessionID = "ses_1"
const page = mergeOptimisticPage(
{
session: [userMessage("msg_2", sessionID)],
part: [{ id: "msg_2", part: [textPart("prt_2", sessionID, "msg_2")] }],
complete: true,
},
[
{
message: userMessage("msg_2", sessionID),
parts: [textPart("prt_1", sessionID, "msg_2"), textPart("prt_2", sessionID, "msg_2")],
},
],
)
expect(page.part.find((x) => x.id === "msg_2")?.part.map((x) => x.id)).toEqual(["prt_1", "prt_2"])
expect(page.confirmed).toEqual([])
})
test("mergeOptimisticPage confirms echoed messages once all parts arrive", () => {
const sessionID = "ses_1"
const page = mergeOptimisticPage(
{
session: [userMessage("msg_2", sessionID)],
part: [
{
id: "msg_2",
part: [{ ...textPart("prt_1", sessionID, "msg_2"), text: "server" }, textPart("prt_2", sessionID, "msg_2")],
},
],
complete: true,
},
[
{
message: userMessage("msg_2", sessionID),
parts: [textPart("prt_1", sessionID, "msg_2"), textPart("prt_2", sessionID, "msg_2")],
},
],
)
expect(page.confirmed).toEqual(["msg_2"])
expect(page.part.find((x) => x.id === "msg_2")?.part).toMatchObject([
{ id: "prt_1", type: "text", text: "server" },
{ id: "prt_2", type: "text", text: "prt_2" },
])
})
})
+108
View File
@@ -1,6 +1,114 @@
import { Binary } from "@opencode-ai/core/util/binary"
import { createMemo } from "solid-js" import { createMemo } from "solid-js"
import { useServerSync } from "./server-sync" import { useServerSync } from "./server-sync"
import { useSDK } from "./sdk" import { useSDK } from "./sdk"
import type { Message, Part } from "@/types"
import { messageKey } from "@/utils/session-message"
const SKIP_PARTS = new Set(["patch", "step-start", "step-finish"])
function sortParts(parts: Part[]) {
return parts.filter((part) => !!part?.id).sort((a, b) => cmp(a.id, b.id))
}
const cmp = (a: string, b: string) => (a < b ? -1 : a > b ? 1 : 0)
type OptimisticStore = {
message: Record<string, Message[] | undefined>
part: Record<string, Part[] | undefined>
}
type OptimisticAddInput = {
sessionID: string
message: Message
parts: Part[]
}
type OptimisticRemoveInput = {
sessionID: string
messageID: string
}
type OptimisticItem = {
message: Message
parts: Part[]
}
type MessagePage = {
session: Message[]
part: { id: string; part: Part[] }[]
cursor?: string
complete: boolean
}
const hasParts = (parts: Part[] | undefined, want: Part[]) => {
if (!parts) return want.length === 0
return want.every((part) => Binary.search(parts, part.id, (item) => item.id).found)
}
const mergeParts = (parts: Part[] | undefined, want: Part[]) => {
if (!parts) return sortParts(want)
const next = [...parts]
let changed = false
for (const part of want) {
const result = Binary.search(next, part.id, (item) => item.id)
if (result.found) continue
next.splice(result.index, 0, part)
changed = true
}
if (!changed) return parts
return next
}
export function mergeOptimisticPage(page: MessagePage, items: OptimisticItem[]) {
if (items.length === 0) return { ...page, confirmed: [] as string[] }
const session = [...page.session]
const part = new Map(page.part.map((item) => [item.id, sortParts(item.part)]))
const confirmed: string[] = []
for (const item of items) {
const result = Binary.search(session, messageKey(item.message), messageKey)
const found = result.found
if (!found) session.splice(result.index, 0, item.message)
const current = part.get(item.message.id)
if (found && hasParts(current, item.parts)) {
confirmed.push(item.message.id)
continue
}
part.set(item.message.id, mergeParts(current, item.parts))
}
return {
cursor: page.cursor,
complete: page.complete,
session,
part: [...part.entries()].sort((a, b) => cmp(a[0], b[0])).map(([id, part]) => ({ id, part })),
confirmed,
}
}
export function applyOptimisticAdd(draft: OptimisticStore, input: OptimisticAddInput) {
const messages = draft.message[input.sessionID]
if (messages) {
const result = Binary.search(messages, messageKey(input.message), messageKey)
messages.splice(result.index, 0, input.message)
} else {
draft.message[input.sessionID] = [input.message]
}
draft.part[input.message.id] = sortParts(input.parts)
}
export function applyOptimisticRemove(draft: OptimisticStore, input: OptimisticRemoveInput) {
const messages = draft.message[input.sessionID]
if (messages) {
const index = messages.findIndex((message) => message.id === input.messageID)
if (index >= 0) messages.splice(index, 1)
}
delete draft.part[input.messageID]
}
export const useSync = () => { export const useSync = () => {
const serverSync = useServerSync() const serverSync = useServerSync()
+5 -16
View File
@@ -2,7 +2,6 @@ import { useQueryOptions } from "@/context/server-sync"
import { Iterable, pipe } from "effect" import { Iterable, pipe } from "effect"
import { type Accessor } from "solid-js" import { type Accessor } from "solid-js"
import { emptyProviderCatalog } from "./provider-catalog" import { emptyProviderCatalog } from "./provider-catalog"
import { useIntegrations } from "./use-integrations"
import { useQuery } from "@tanstack/solid-query" import { useQuery } from "@tanstack/solid-query"
import { pathKey } from "@/utils/path-key" import { pathKey } from "@/utils/path-key"
@@ -24,7 +23,6 @@ export function useProviders(directory: Accessor<string | undefined>) {
const dir = directory() const dir = directory()
return queryOpts.providers(dir ? pathKey(dir) : null) return queryOpts.providers(dir ? pathKey(dir) : null)
}) })
const integrations = useIntegrations(directory)
const providers = () => (!providersQuery.isSuccess ? emptyProviderCatalog : providersQuery.data) const providers = () => (!providersQuery.isSuccess ? emptyProviderCatalog : providersQuery.data)
@@ -32,22 +30,13 @@ export function useProviders(directory: Accessor<string | undefined>) {
ready: () => providersQuery.isSuccess, ready: () => providersQuery.isSuccess,
all: () => providers().all, all: () => providers().all,
default: () => providers().default, default: () => providers().default,
// V2 servers list only available providers, so the connectable catalog popular: () =>
// comes from the integration list, with the provider catalog as fallback. pipe(
popular: () => {
const catalog = integrations
.list()
.filter((integration) => popularProviderSet.has(integration.id))
.map((integration) => ({ id: integration.id, name: integration.name }))
const seen = new Set(catalog.map((integration) => integration.id))
return pipe(
providers().all, providers().all,
Iterable.map(([, p]) => p), Iterable.map(([, p]) => p),
Iterable.filter((p) => popularProviderSet.has(p.id) && !seen.has(p.id)), Iterable.filter((p) => popularProviderSet.has(p.id)),
Iterable.map((p) => ({ id: p.id, name: p.name })), (v) => Array.from(v),
(v) => [...catalog, ...v], ),
)
},
connected: () => { connected: () => {
const connected = new Set(providers().connected) const connected = new Set(providers().connected)
return pipe( return pipe(
@@ -94,7 +94,7 @@ export function createTimelineController(input: {
fallback: language.t("command.session.new"), fallback: language.t("command.session.new"),
}) })
}) })
const showHeader = createMemo(() => !!input.session.identity.sessionID()) const showHeader = createMemo(() => !!(titleValue() || input.session.data.parentID()))
const projection = createTimelineProjection({ const projection = createTimelineProjection({
messages: input.session.history.messages, messages: input.session.history.messages,
userMessages: input.userMessages, userMessages: input.userMessages,
@@ -1203,8 +1203,6 @@ function MessageTimelineView(
onCleanup(() => { onCleanup(() => {
if (contentMeasureFrame !== undefined) cancelAnimationFrame(contentMeasureFrame) if (contentMeasureFrame !== undefined) cancelAnimationFrame(contentMeasureFrame)
// Solid runs cleanup before it disconnects the row, so defer TanStack's null-ref cleanup.
queueMicrotask(() => virtualizer.measureElement(null))
}) })
return ( return (
+1 -1
View File
@@ -4,7 +4,7 @@ export type UpdaterState =
| { status: "disabled" } | { status: "disabled" }
| { status: "idle" } | { status: "idle" }
| { status: "checking" } | { status: "checking" }
| { status: "downloading"; version: string } | { status: "downloading"; version: string; percent?: number }
| { status: "ready"; version: string } | { status: "ready"; version: string }
| { status: "up-to-date" } | { status: "up-to-date" }
| { status: "installing"; version: string } | { status: "installing"; version: string }
+1 -4
View File
@@ -22,10 +22,7 @@ function blobUrl(id: string, blob: Blob) {
} }
async function blobID(blob: Blob) { async function blobID(blob: Blob) {
const bytes = crypto.subtle const id = Array.from(new Uint8Array(await crypto.subtle.digest("SHA-256", await blob.arrayBuffer())))
? new Uint8Array(await crypto.subtle.digest("SHA-256", await blob.arrayBuffer()))
: crypto.getRandomValues(new Uint8Array(16))
const id = Array.from(bytes)
.map((byte) => byte.toString(16).padStart(2, "0")) .map((byte) => byte.toString(16).padStart(2, "0"))
.join("") .join("")
return id return id
+1 -70
View File
@@ -1,7 +1,7 @@
#!/usr/bin/env bun #!/usr/bin/env bun
import { $ } from "bun" import { $ } from "bun"
import { mkdir, rm } from "fs/promises" import { rm } from "fs/promises"
import path from "path" import path from "path"
import { Script } from "@opencode-ai/script" import { Script } from "@opencode-ai/script"
import { createSolidTransformPlugin } from "@opentui/solid/bun-plugin" import { createSolidTransformPlugin } from "@opentui/solid/bun-plugin"
@@ -27,7 +27,6 @@ const requestedTarget = process.argv.find((arg) => arg.startsWith("--target="))?
const skipInstall = process.argv.includes("--skip-install") const skipInstall = process.argv.includes("--skip-install")
const skipWebUi = process.argv.includes("--skip-web-ui") const skipWebUi = process.argv.includes("--skip-web-ui")
const solidPlugin = createSolidTransformPlugin() const solidPlugin = createSolidTransformPlugin()
const releaseAssets = new Map<string, Promise<Map<string, string>>>()
const allTargets: { const allTargets: {
os: string os: string
@@ -100,7 +99,6 @@ for (const item of targets) {
} }
const target = targetName(item) const target = targetName(item)
const name = target.replace(binary, "cli") const name = target.replace(binary, "cli")
const executablePath = await compileExecutable(item)
console.log(`building ${name}`) console.log(`building ${name}`)
const result = await Bun.build({ const result = await Bun.build({
entrypoints: ["./src/index.ts"], entrypoints: ["./src/index.ts"],
@@ -117,7 +115,6 @@ for (const item of targets) {
autoloadTsconfig: true, autoloadTsconfig: true,
autoloadPackageJson: true, autoloadPackageJson: true,
target: target.replace(binary, "bun") as Bun.Build.CompileTarget, target: target.replace(binary, "bun") as Bun.Build.CompileTarget,
executablePath,
outfile: path.join(outdir, name, "bin", binary), outfile: path.join(outdir, name, "bin", binary),
execArgv: [`--user-agent=${binary}/${Script.version}`, "--use-system-ca", "--"], execArgv: [`--user-agent=${binary}/${Script.version}`, "--use-system-ca", "--"],
windows: {}, windows: {},
@@ -157,72 +154,6 @@ for (const item of targets) {
await verifyArtifact(path.join(outdir, name)) await verifyArtifact(path.join(outdir, name))
} }
async function compileExecutable(item: (typeof allTargets)[number]) {
const release = process.env.BUN_COMPILE_RELEASE
if (!release) return
const platform = item.os === "win32" ? "windows" : item.os
const name = [
"bun",
platform,
item.arch === "arm64" ? "aarch64" : item.arch,
item.abi,
item.avx2 === false ? "baseline" : undefined,
]
.filter(Boolean)
.join("-")
const cache = path.join(outdir, ".bun", release)
const executable = path.join(cache, name, item.os === "win32" ? "bun.exe" : "bun")
if (await Bun.file(executable).exists()) return executable
await mkdir(cache, { recursive: true })
const archive = path.join(cache, `${name}.zip`)
const assets = await compileReleaseAssets(release)
const url = assets.get(`${name}.zip`)
if (!url) throw new Error(`Bun release ${release} does not include ${name}.zip`)
const token = process.env.GH_TOKEN ?? process.env.GITHUB_TOKEN
const response = await fetch(url, {
headers: { Accept: "application/octet-stream", ...(token ? { Authorization: `Bearer ${token}` } : {}) },
})
if (!response.ok) throw new Error(`Failed to download ${name} from Bun release ${release}: ${response.status}`)
await Bun.write(archive, response)
await $`unzip -oq ${archive} -d ${cache}`
await rm(archive)
return executable
}
function compileReleaseAssets(release: string) {
const existing = releaseAssets.get(release)
if (existing) return existing
const pending = fetch(`https://api.github.com/repos/oven-sh/bun/releases/tags/${release}?cache=${Date.now()}`)
.then(async (response) => {
if (!response.ok) throw new Error(`Failed to resolve Bun release ${release}: ${response.status}`)
const data: unknown = await response.json()
if (typeof data !== "object" || data === null || !("assets" in data) || !Array.isArray(data.assets)) {
throw new Error(`Bun release ${release} returned invalid metadata`)
}
return new Map(
data.assets
.filter(
(asset): asset is { name: string; url: string } =>
typeof asset === "object" &&
asset !== null &&
"name" in asset &&
typeof asset.name === "string" &&
"url" in asset &&
typeof asset.url === "string",
)
.map((asset) => [asset.name, asset.url]),
)
})
.catch((error) => {
releaseAssets.delete(release)
throw error
})
releaseAssets.set(release, pending)
return pending
}
function targetName(item: (typeof allTargets)[number]) { function targetName(item: (typeof allTargets)[number]) {
return [ return [
binary, binary,
+3 -7
View File
@@ -14,13 +14,9 @@ async function published(name: string, version: string) {
async function publish(dir: string, name: string, version: string) { async function publish(dir: string, name: string, version: string) {
if (process.platform !== "win32") await $`chmod -R 755 .`.cwd(dir) if (process.platform !== "win32") await $`chmod -R 755 .`.cwd(dir)
const exists = await published(name, version) if (await published(name, version)) return console.log(`already published ${name}@${version}`)
if (exists) console.log(`already published ${name}@${version}`) await $`bun pm pack`.cwd(dir)
if (!exists) { await $`npm publish *.tgz --access public --tag ${Script.channel}`.cwd(dir)
await $`bun pm pack`.cwd(dir)
await $`npm publish *.tgz --access public --tag ${Script.channel}`.cwd(dir)
}
if (Script.channel === "beta") await $`npm dist-tag add ${`${name}@${version}`} next`
} }
async function publishDistribution(input: { root: string; name: string; binary: string; packagePrefix: string }) { async function publishDistribution(input: { root: string; name: string; binary: string; packagePrefix: string }) {
+1 -1
View File
@@ -84,7 +84,7 @@ const processEffect = Effect.fnUntraced(function* (options: Options) {
database: { database: {
path: path:
process.env.OPENCODE_DB ?? process.env.OPENCODE_DB ??
(["latest", "dev", "beta", "next", "prod"].includes(OPENCODE_CHANNEL) || (["latest", "beta", "next", "prod"].includes(OPENCODE_CHANNEL) ||
process.env.OPENCODE_DISABLE_CHANNEL_DB === "1" || process.env.OPENCODE_DISABLE_CHANNEL_DB === "1" ||
process.env.OPENCODE_DISABLE_CHANNEL_DB === "true" process.env.OPENCODE_DISABLE_CHANNEL_DB === "true"
? "opencode.db" ? "opencode.db"
+2 -2
View File
@@ -25,12 +25,12 @@ const decodeInfo = Schema.decodeUnknownEffect(Schema.fromJsonString(Info))
const decodeRegistration = Schema.decodeUnknownEffect(Schema.fromJsonString(Service.Info)) const decodeRegistration = Schema.decodeUnknownEffect(Schema.fromJsonString(Service.Info))
export function filename(channel = OPENCODE_CHANNEL) { export function filename(channel = OPENCODE_CHANNEL) {
if (channel === "latest" || channel === "dev" || channel === "beta" || channel === "next") return "service.json" if (channel === "latest" || channel === "next") return "service.json"
return `service-${channel.replace(/[^a-zA-Z0-9._-]/g, "-")}.json` return `service-${channel.replace(/[^a-zA-Z0-9._-]/g, "-")}.json`
} }
export function defaultPort(channel = OPENCODE_CHANNEL) { export function defaultPort(channel = OPENCODE_CHANNEL) {
if (channel === "latest" || channel === "dev" || channel === "beta" || channel === "next") return 0xc0de if (channel === "latest" || channel === "next") return 0xc0de
if (channel === "local") return 0xc0df if (channel === "local") return 0xc0df
return 10_000 + (Number.parseInt(Hash.fast(channel).slice(0, 8), 16) % 50_000) return 10_000 + (Number.parseInt(Hash.fast(channel).slice(0, 8), 16) % 50_000)
} }
+1 -2
View File
@@ -35,8 +35,7 @@ describe("updater", () => {
test("accepts strict release version variants", () => { test("accepts strict release version variants", () => {
expect(action("v1.2.3", " 1.2.4\n", true)).toBe("upgrade") expect(action("v1.2.3", " 1.2.4\n", true)).toBe("upgrade")
expect(action("1.2.3-alpha.1", "1.2.3-alpha.2", true)).toBe("upgrade") expect(action("1.2.3-alpha.1", "1.2.3-alpha.2", true)).toBe("upgrade")
expect(action("0.0.0-dev-17403", "0.0.0-dev-17403.2", true)).toBe("upgrade") expect(action("0.0.0-next-17403", "0.0.0-next-17403.2", true)).toBe("upgrade")
expect(action("0.0.0-next-17403", "0.0.0-beta-17404", true)).toBe("upgrade")
expect(action("1.2.3+old", "1.2.3+new", true)).toBe("none") expect(action("1.2.3+old", "1.2.3+new", true)).toBe("none")
expect(action("v1.2.3+old", "1.2.3", true)).toBe("none") expect(action("v1.2.3+old", "1.2.3", true)).toBe("none")
}) })
-4
View File
@@ -11,8 +11,6 @@ import { ServiceConfig } from "../src/services/service-config"
test("managed service ports are stable per installation channel", () => { test("managed service ports are stable per installation channel", () => {
expect(ServiceConfig.defaultPort("latest")).toBe(0xc0de) expect(ServiceConfig.defaultPort("latest")).toBe(0xc0de)
expect(ServiceConfig.defaultPort("dev")).toBe(0xc0de)
expect(ServiceConfig.defaultPort("beta")).toBe(0xc0de)
expect(ServiceConfig.defaultPort("next")).toBe(0xc0de) expect(ServiceConfig.defaultPort("next")).toBe(0xc0de)
expect(ServiceConfig.defaultPort("local")).toBe(0xc0df) expect(ServiceConfig.defaultPort("local")).toBe(0xc0df)
expect(ServiceConfig.defaultPort("preview-a")).toBe(ServiceConfig.defaultPort("preview-a")) expect(ServiceConfig.defaultPort("preview-a")).toBe(ServiceConfig.defaultPort("preview-a"))
@@ -39,8 +37,6 @@ test("local channel stores service config with the local service filename", asyn
test("service filenames share release channels and identify preview channels", () => { test("service filenames share release channels and identify preview channels", () => {
expect(ServiceConfig.filename("latest")).toBe("service.json") expect(ServiceConfig.filename("latest")).toBe("service.json")
expect(ServiceConfig.filename("dev")).toBe("service.json")
expect(ServiceConfig.filename("beta")).toBe("service.json")
expect(ServiceConfig.filename("next")).toBe("service.json") expect(ServiceConfig.filename("next")).toBe("service.json")
expect(ServiceConfig.filename("local")).toBe("service-local.json") expect(ServiceConfig.filename("local")).toBe("service-local.json")
expect(ServiceConfig.filename("preview-a")).toBe("service-preview-a.json") expect(ServiceConfig.filename("preview-a")).toBe("service-preview-a.json")
+41 -54
View File
@@ -20,6 +20,7 @@ import type { InstructionEntry } from "@opencode-ai/schema/instruction-entry"
import type { Schema } from "effect" import type { Schema } from "effect"
import type { EventLog } from "@opencode-ai/schema/event-log" import type { EventLog } from "@opencode-ai/schema/event-log"
import type { Shell } from "@opencode-ai/schema/shell" import type { Shell } from "@opencode-ai/schema/shell"
import type { DateTime } from "effect"
import type { Provider } from "@opencode-ai/schema/provider" import type { Provider } from "@opencode-ai/schema/provider"
import type { Integration } from "@opencode-ai/schema/integration" import type { Integration } from "@opencode-ai/schema/integration"
import type { Form } from "@opencode-ai/schema/form" import type { Form } from "@opencode-ai/schema/form"
@@ -315,7 +316,7 @@ export type Endpoint5_31Output =
| ( | (
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.created" readonly type: "session.created"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -335,7 +336,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.agent.selected" readonly type: "session.agent.selected"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -348,7 +349,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.model.selected" readonly type: "session.model.selected"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -361,7 +362,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.moved" readonly type: "session.moved"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -375,7 +376,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.renamed" readonly type: "session.renamed"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -384,16 +385,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.viewed"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
readonly location?: Location.Ref | undefined
readonly data: { readonly sessionID: Session.ID }
}
| {
readonly id: Event.ID
readonly created: number
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.deleted" readonly type: "session.deleted"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -402,7 +394,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.forked" readonly type: "session.forked"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -418,7 +410,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.inbox.delivered" readonly type: "session.inbox.delivered"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -427,7 +419,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.inbox.enqueued" readonly type: "session.inbox.enqueued"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -440,7 +432,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.inbox.cancelled" readonly type: "session.inbox.cancelled"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -449,7 +441,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.inbox.delivery.changed" readonly type: "session.inbox.delivery.changed"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -462,7 +454,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.execution.started" readonly type: "session.execution.started"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -471,7 +463,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.execution.succeeded" readonly type: "session.execution.succeeded"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -480,7 +472,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.execution.failed" readonly type: "session.execution.failed"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -492,7 +484,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.execution.interrupted" readonly type: "session.execution.interrupted"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -501,7 +493,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.instructions.updated" readonly type: "session.instructions.updated"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -514,7 +506,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.synthetic" readonly type: "session.synthetic"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -528,7 +520,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.skill.activated" readonly type: "session.skill.activated"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -542,7 +534,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.shell.started" readonly type: "session.shell.started"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -551,7 +543,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.shell.ended" readonly type: "session.shell.ended"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -569,7 +561,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.step.started" readonly type: "session.step.started"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -584,7 +576,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.step.ended" readonly type: "session.step.ended"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -606,7 +598,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.step.failed" readonly type: "session.step.failed"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -630,7 +622,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.text.started" readonly type: "session.text.started"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -643,7 +635,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.text.ended" readonly type: "session.text.ended"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -658,7 +650,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.reasoning.started" readonly type: "session.reasoning.started"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -672,7 +664,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.reasoning.ended" readonly type: "session.reasoning.ended"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -687,7 +679,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.tool.input.started" readonly type: "session.tool.input.started"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -701,7 +693,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.tool.input.ended" readonly type: "session.tool.input.ended"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -715,7 +707,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.tool.called" readonly type: "session.tool.called"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -731,7 +723,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.tool.success" readonly type: "session.tool.success"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -767,7 +759,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.tool.failed" readonly type: "session.tool.failed"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -806,7 +798,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.retry.scheduled" readonly type: "session.retry.scheduled"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -821,7 +813,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.compaction.started" readonly type: "session.compaction.started"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -835,7 +827,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.compaction.ended" readonly type: "session.compaction.ended"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -849,7 +841,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.compaction.failed" readonly type: "session.compaction.failed"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -863,7 +855,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.revert.staged" readonly type: "session.revert.staged"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -872,7 +864,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.revert.cleared" readonly type: "session.revert.cleared"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -881,7 +873,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.revert.committed" readonly type: "session.revert.committed"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -890,7 +882,7 @@ export type Endpoint5_31Output =
} }
| { | {
readonly id: Event.ID readonly id: Event.ID
readonly created: number readonly created: DateTime.Utc
readonly metadata?: { readonly [x: string]: unknown } | undefined readonly metadata?: { readonly [x: string]: unknown } | undefined
readonly type: "session.usage.recorded" readonly type: "session.usage.recorded"
readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version } readonly durable: { readonly aggregateID: string; readonly seq: Event.Seq; readonly version: Event.Version }
@@ -923,10 +915,6 @@ export type Endpoint5_34Input = { readonly sessionID: Session.ID; readonly messa
export type Endpoint5_34Output = SessionMessage.Info export type Endpoint5_34Output = SessionMessage.Info
export type SessionMessageOperation<E = never> = (input: Endpoint5_34Input) => Effect.Effect<Endpoint5_34Output, E> export type SessionMessageOperation<E = never> = (input: Endpoint5_34Input) => Effect.Effect<Endpoint5_34Output, E>
export type Endpoint5_35Input = { readonly sessionID: Session.ID }
export type Endpoint5_35Output = void
export type SessionViewOperation<E = never> = (input: Endpoint5_35Input) => Effect.Effect<Endpoint5_35Output, E>
export interface SessionApi<E = never> { export interface SessionApi<E = never> {
readonly list: SessionListOperation<E> readonly list: SessionListOperation<E>
readonly create: SessionCreateOperation<E> readonly create: SessionCreateOperation<E>
@@ -971,7 +959,6 @@ export interface SessionApi<E = never> {
readonly interrupt: SessionInterruptOperation<E> readonly interrupt: SessionInterruptOperation<E>
readonly background: SessionBackgroundOperation<E> readonly background: SessionBackgroundOperation<E>
readonly message: SessionMessageOperation<E> readonly message: SessionMessageOperation<E>
readonly view: SessionViewOperation<E>
} }
export type Endpoint6_0Input = { export type Endpoint6_0Input = {
@@ -86,8 +86,6 @@ import type {
Endpoint5_33Output, Endpoint5_33Output,
Endpoint5_34Input, Endpoint5_34Input,
Endpoint5_34Output, Endpoint5_34Output,
Endpoint5_35Input,
Endpoint5_35Output,
Endpoint6_0Input, Endpoint6_0Input,
Endpoint6_0Output, Endpoint6_0Output,
Endpoint7_0Input, Endpoint7_0Input,
@@ -612,11 +610,6 @@ const Endpoint5_34 = (raw: RawClient["server.session"]) => (input: Endpoint5_34I
), ),
) )
const Endpoint5_35 = (raw: RawClient["server.session"]) => (input: Endpoint5_35Input) =>
preserveEffect<Endpoint5_35Output>()(
raw["session.view"]({ params: { sessionID: input["sessionID"] } }).pipe(Effect.mapError(mapClientError)),
)
const adaptGroup5 = (raw: RawClient["server.session"]) => ({ const adaptGroup5 = (raw: RawClient["server.session"]) => ({
list: Endpoint5_0(raw), list: Endpoint5_0(raw),
create: Endpoint5_1(raw), create: Endpoint5_1(raw),
@@ -646,7 +639,6 @@ const adaptGroup5 = (raw: RawClient["server.session"]) => ({
interrupt: Endpoint5_32(raw), interrupt: Endpoint5_32(raw),
background: Endpoint5_33(raw), background: Endpoint5_33(raw),
message: Endpoint5_34(raw), message: Endpoint5_34(raw),
view: Endpoint5_35(raw),
}) })
const Endpoint6_0 = (raw: RawClient["server.message"]) => (input: Endpoint6_0Input) => const Endpoint6_0 = (raw: RawClient["server.message"]) => (input: Endpoint6_0Input) =>
@@ -80,8 +80,6 @@ import type {
SessionBackgroundOutput, SessionBackgroundOutput,
SessionMessageInput, SessionMessageInput,
SessionMessageOutput, SessionMessageOutput,
SessionViewInput,
SessionViewOutput,
MessageListInput, MessageListInput,
MessageListOutput, MessageListOutput,
ModelListInput, ModelListInput,
@@ -898,17 +896,6 @@ export function make(options: ClientOptions) {
}, },
requestOptions, requestOptions,
).then((value) => value.data), ).then((value) => value.data),
view: (input: SessionViewInput, requestOptions?: RequestOptions) =>
request<SessionViewOutput>(
{
method: "POST",
path: `/api/session/${encodeURIComponent(input.sessionID)}/view`,
successStatus: 204,
declaredStatuses: [404, 401, 400],
empty: true,
},
requestOptions,
),
}, },
message: { message: {
list: (input: MessageListInput, requestOptions?: RequestOptions) => list: (input: MessageListInput, requestOptions?: RequestOptions) =>
+5 -39
View File
@@ -192,7 +192,7 @@ export type ProviderInfo = {
id: string id: string
integrationID?: string integrationID?: string
name: string name: string
activation: "auto" | "enabled" | "disabled" disabled?: boolean
package: string package: string
settings?: { [x: string]: any } settings?: { [x: string]: any }
headers?: { [x: string]: string } headers?: { [x: string]: string }
@@ -479,16 +479,6 @@ export type SessionRenamed = {
data: { sessionID: string; title: string } data: { sessionID: string; title: string }
} }
export type SessionViewed = {
id: string
created: number
metadata?: { [x: string]: any }
type: "session.viewed"
durable: { aggregateID: string; seq: number; version: 1 }
location?: LocationRef
data: { sessionID: string }
}
export type SessionDeleted = { export type SessionDeleted = {
id: string id: string
created: number created: number
@@ -1520,7 +1510,7 @@ export type SessionInfo = {
model?: ModelRef model?: ModelRef
cost: MoneyUSD cost: MoneyUSD
tokens: TokenUsageInfo tokens: TokenUsageInfo
time: { created: number; updated: number; idle?: number; viewed?: number; archived?: number } time: { created: number; updated: number; archived?: number }
title?: string title?: string
location: LocationRef location: LocationRef
subpath?: string subpath?: string
@@ -1933,7 +1923,6 @@ export type SessionEventDurable =
| SessionModelSelected | SessionModelSelected
| SessionMoved | SessionMoved
| SessionRenamed | SessionRenamed
| SessionViewed
| SessionDeleted | SessionDeleted
| SessionForked | SessionForked
| SessionInboxDelivered | SessionInboxDelivered
@@ -2024,7 +2013,6 @@ export type V2Event =
| SessionModelSelected | SessionModelSelected
| SessionMoved | SessionMoved
| SessionRenamed | SessionRenamed
| SessionViewed
| SessionUsageUpdated | SessionUsageUpdated
| SessionDeleted | SessionDeleted
| SessionForked | SessionForked
@@ -2488,13 +2476,7 @@ export type SessionImportInput = {
readonly reasoning: number readonly reasoning: number
readonly cache: { readonly read: number; readonly write: number } readonly cache: { readonly read: number; readonly write: number }
} }
readonly time: { readonly time: { readonly created: number; readonly updated: number; readonly archived?: number }
readonly created: number
readonly updated: number
readonly idle?: number
readonly viewed?: number
readonly archived?: number
}
readonly title?: string readonly title?: string
readonly location: { readonly directory: string; readonly workspaceID?: string } readonly location: { readonly directory: string; readonly workspaceID?: string }
readonly subpath?: string readonly subpath?: string
@@ -2761,13 +2743,7 @@ export type SessionImportInput = {
readonly reasoning: number readonly reasoning: number
readonly cache: { readonly read: number; readonly write: number } readonly cache: { readonly read: number; readonly write: number }
} }
readonly time: { readonly time: { readonly created: number; readonly updated: number; readonly archived?: number }
readonly created: number
readonly updated: number
readonly idle?: number
readonly viewed?: number
readonly archived?: number
}
readonly title?: string readonly title?: string
readonly location: { readonly directory: string; readonly workspaceID?: string } readonly location: { readonly directory: string; readonly workspaceID?: string }
readonly subpath?: string readonly subpath?: string
@@ -3034,13 +3010,7 @@ export type SessionImportInput = {
readonly reasoning: number readonly reasoning: number
readonly cache: { readonly read: number; readonly write: number } readonly cache: { readonly read: number; readonly write: number }
} }
readonly time: { readonly time: { readonly created: number; readonly updated: number; readonly archived?: number }
readonly created: number
readonly updated: number
readonly idle?: number
readonly viewed?: number
readonly archived?: number
}
readonly title?: string readonly title?: string
readonly location: { readonly directory: string; readonly workspaceID?: string } readonly location: { readonly directory: string; readonly workspaceID?: string }
readonly subpath?: string readonly subpath?: string
@@ -3966,10 +3936,6 @@ export type SessionMessageInput = {
export type SessionMessageOutput = { data: SessionMessageInfo }["data"] export type SessionMessageOutput = { data: SessionMessageInfo }["data"]
export type SessionViewInput = { readonly sessionID: { readonly sessionID: string }["sessionID"] }
export type SessionViewOutput = void
export type MessageListInput = { export type MessageListInput = {
readonly sessionID: { readonly sessionID: string }["sessionID"] readonly sessionID: { readonly sessionID: string }["sessionID"]
readonly limit?: { readonly limit?: {
+4 -12
View File
@@ -136,10 +136,8 @@ test("event.subscribe terminates on Effect protocol decode failures", async () =
test("session methods retain decoded Effect inputs and outputs", async () => { test("session methods retain decoded Effect inputs and outputs", async () => {
const logQueries: Array<Record<string, string>> = [] const logQueries: Array<Record<string, string>> = []
const requests: Array<{ method: string; url: string }> = []
const httpClient = HttpClient.make((request) => { const httpClient = HttpClient.make((request) => {
const url = request.url const url = request.url
requests.push({ method: request.method, url })
if (url.includes("/log")) { if (url.includes("/log")) {
logQueries.push(Object.fromEntries(request.urlParams.params)) logQueries.push(Object.fromEntries(request.urlParams.params))
return Effect.succeed( return Effect.succeed(
@@ -185,7 +183,6 @@ test("session methods retain decoded Effect inputs and outputs", async () => {
const created = yield* client.session.create({ const created = yield* client.session.create({
location: Location.Ref.make({ directory: AbsolutePath.make("/tmp/project") }), location: Location.Ref.make({ directory: AbsolutePath.make("/tmp/project") }),
}) })
yield* client.session.view({ sessionID: Session.ID.make("ses_test") })
yield* client.session.switchAgent({ sessionID: Session.ID.make("ses_test"), agent: Agent.ID.make("build") }) yield* client.session.switchAgent({ sessionID: Session.ID.make("ses_test"), agent: Agent.ID.make("build") })
yield* client.session.switchModel({ yield* client.session.switchModel({
sessionID: Session.ID.make("ses_test"), sessionID: Session.ID.make("ses_test"),
@@ -210,11 +207,7 @@ test("session methods retain decoded Effect inputs and outputs", async () => {
return { page, active, created, admitted, context, log, message } return { page, active, created, admitted, context, log, message }
}).pipe(Effect.provideService(HttpClient.HttpClient, httpClient), Effect.runPromise) }).pipe(Effect.provideService(HttpClient.HttpClient, httpClient), Effect.runPromise)
const listed = result.page.data[0] expect(DateTime.toEpochMillis(result.page.data[0].time.created)).toBe(1_717_171_717_000)
if (!listed?.time.idle || !listed.time.viewed) throw new Error("Expected attention times")
expect(DateTime.toEpochMillis(listed.time.created)).toBe(1_717_171_717_000)
expect(DateTime.toEpochMillis(listed.time.idle)).toBe(1_717_171_717_002)
expect(DateTime.toEpochMillis(listed.time.viewed)).toBe(1_717_171_717_001)
expect(result.active).toEqual({ ses_test: { type: "running" } }) expect(result.active).toEqual({ ses_test: { type: "running" } })
expect(Object.getPrototypeOf(result.page.data[0])).toBe(Object.prototype) expect(Object.getPrototypeOf(result.page.data[0])).toBe(Object.prototype)
expect(Object.getPrototypeOf(result.created)).toBe(Object.prototype) expect(Object.getPrototypeOf(result.created)).toBe(Object.prototype)
@@ -224,10 +217,11 @@ test("session methods retain decoded Effect inputs and outputs", async () => {
expect(DateTime.toEpochMillis(result.admitted.timeCreated)).toBe(1_717_171_717_000) expect(DateTime.toEpochMillis(result.admitted.timeCreated)).toBe(1_717_171_717_000)
expect(result.context).toEqual([]) expect(result.context).toEqual([])
expect(logQueries[0]).toEqual({ after: "0" }) expect(logQueries[0]).toEqual({ after: "0" })
expect(requests).toContainEqual({ method: "POST", url: "http://localhost:3000/api/session/ses_test/view" })
const logged = Array.from(result.log) const logged = Array.from(result.log)
expect(logged.map((item) => item.type)).toEqual(["session.model.selected", "log.synced"]) expect(logged.map((item) => item.type)).toEqual(["session.model.selected", "log.synced"])
expect(logged[0]?.type === "session.model.selected" && logged[0].created).toBe(1_717_171_717_000) expect(logged[0]?.type === "session.model.selected" && DateTime.toEpochMillis(logged[0].created)).toBe(
1_717_171_717_000,
)
expect(logged.at(-1)).toEqual(synced) expect(logged.at(-1)).toEqual(synced)
expect(result.message).toEqual(expect.objectContaining({ id: "msg_model", type: "model-switched" })) expect(result.message).toEqual(expect.objectContaining({ id: "msg_model", type: "model-switched" }))
}) })
@@ -266,8 +260,6 @@ const session = {
time: { time: {
created: 1_717_171_717_000, created: 1_717_171_717_000,
updated: 1_717_171_717_000, updated: 1_717_171_717_000,
idle: 1_717_171_717_002,
viewed: 1_717_171_717_001,
}, },
title: "Test", title: "Test",
location: { directory: "/tmp/project" }, location: { directory: "/tmp/project" },
-5
View File
@@ -539,7 +539,6 @@ test("session methods use the public HTTP contract", async () => {
const page = await client.session.list({ limit: 10, order: "desc", parentID: null }) const page = await client.session.list({ limit: 10, order: "desc", parentID: null })
const active = await client.session.active() const active = await client.session.active()
const created = await client.session.create({ location: { directory: "/tmp/project" } }) const created = await client.session.create({ location: { directory: "/tmp/project" } })
await client.session.view({ sessionID: "ses_test" })
await client.session.switchAgent({ sessionID: "ses_test", agent: "build" }) await client.session.switchAgent({ sessionID: "ses_test", agent: "build" })
await client.session.switchModel({ await client.session.switchModel({
sessionID: "ses_test", sessionID: "ses_test",
@@ -566,7 +565,6 @@ test("session methods use the public HTTP contract", async () => {
const message = await client.session.message({ sessionID: "ses_test", messageID: "msg_model" }) const message = await client.session.message({ sessionID: "ses_test", messageID: "msg_model" })
expect(page.cursor.next).toBe("next") expect(page.cursor.next).toBe("next")
expect(page.data[0].time).toMatchObject({ idle: 1_717_171_717_002, viewed: 1_717_171_717_001 })
expect(active).toEqual({ ses_test: { type: "running" } }) expect(active).toEqual({ ses_test: { type: "running" } })
expect(created.id).toBe("ses_test") expect(created.id).toBe("ses_test")
expect(admitted.id).toBe("msg_test") expect(admitted.id).toBe("msg_test")
@@ -579,7 +577,6 @@ test("session methods use the public HTTP contract", async () => {
["GET", "http://localhost:3000/api/session?limit=10&order=desc&parentID=null"], ["GET", "http://localhost:3000/api/session?limit=10&order=desc&parentID=null"],
["GET", "http://localhost:3000/api/session/active"], ["GET", "http://localhost:3000/api/session/active"],
["POST", "http://localhost:3000/api/session"], ["POST", "http://localhost:3000/api/session"],
["POST", "http://localhost:3000/api/session/ses_test/view"],
["POST", "http://localhost:3000/api/session/ses_test/agent"], ["POST", "http://localhost:3000/api/session/ses_test/agent"],
["POST", "http://localhost:3000/api/session/ses_test/model"], ["POST", "http://localhost:3000/api/session/ses_test/model"],
["POST", "http://localhost:3000/api/session/ses_test/prompt"], ["POST", "http://localhost:3000/api/session/ses_test/prompt"],
@@ -654,8 +651,6 @@ const session = {
time: { time: {
created: 1_717_171_717_000, created: 1_717_171_717_000,
updated: 1_717_171_717_000, updated: 1_717_171_717_000,
idle: 1_717_171_717_002,
viewed: 1_717_171_717_001,
}, },
title: "Test", title: "Test",
location: { directory: "/tmp/project" }, location: { directory: "/tmp/project" },
@@ -21,7 +21,7 @@ export default function TermsOfService() {
<section data-component="brand-content"> <section data-component="brand-content">
<article data-component="terms-of-service"> <article data-component="terms-of-service">
<h1>Terms of Use</h1> <h1>Terms of Use</h1>
<p class="effective-date">Effective date: Aug 15, 2026</p> <p class="effective-date">Effective date: Mar 6, 2026</p>
<p> <p>
Welcome to OpenCode. Please read on to learn the rules and restrictions that govern your use of Welcome to OpenCode. Please read on to learn the rules and restrictions that govern your use of
@@ -154,11 +154,6 @@ export default function TermsOfService() {
is dangerous, harmful, fraudulent, deceptive, threatening, harassing, defamatory, obscene, or is dangerous, harmful, fraudulent, deceptive, threatening, harassing, defamatory, obscene, or
otherwise objectionable; otherwise objectionable;
</li> </li>
<li>
creates, maintains, or uses accounts in bulk, or creates, maintains, or uses multiple accounts to
circumvent usage limits, access restrictions, billing obligations, promotions, suspensions, or any
other restriction or policy applicable to the Services;
</li>
<li>automatically or programmatically extracts data or Output (defined below);</li> <li>automatically or programmatically extracts data or Output (defined below);</li>
<li>Represent that the Output was human-generated when it was not;</li> <li>Represent that the Output was human-generated when it was not;</li>
<li> <li>
+2 -22
View File
@@ -1,8 +1,8 @@
{ {
"version": "7", "version": "7",
"dialect": "sqlite", "dialect": "sqlite",
"id": "94b6c496-ad84-426f-9d5d-3e1ac3ebfb56", "id": "dcde8e6b-4bf4-4f6b-b2be-4030c2c3e936",
"prevIds": ["dcde8e6b-4bf4-4f6b-b2be-4030c2c3e936"], "prevIds": ["5c1aa56b-c3ee-4283-9a84-c0bf626dc604"],
"ddl": [ "ddl": [
{ {
"name": "account_state", "name": "account_state",
@@ -1350,26 +1350,6 @@
"entityType": "columns", "entityType": "columns",
"table": "session_v2" "table": "session_v2"
}, },
{
"type": "integer",
"notNull": false,
"autoincrement": false,
"default": null,
"generated": null,
"name": "time_idle",
"entityType": "columns",
"table": "session_v2"
},
{
"type": "integer",
"notNull": false,
"autoincrement": false,
"default": null,
"generated": null,
"name": "time_viewed",
"entityType": "columns",
"table": "session_v2"
},
{ {
"type": "integer", "type": "integer",
"notNull": false, "notNull": false,
+10 -10
View File
@@ -1,6 +1,6 @@
export * as Bus from "./bus.js" export * as Bus from "./bus.js"
import { Cause, Clock, Context, Effect, Layer, Option, PubSub, Schema, Stream } from "effect" import { Cause, Context, DateTime, Effect, Layer, Option, PubSub, Schema, Stream } from "effect"
import { Event } from "@opencode-ai/schema/event" import { Event } from "@opencode-ai/schema/event"
import type { EventLog } from "@opencode-ai/schema/event-log" import type { EventLog } from "@opencode-ai/schema/event-log"
import { and, asc, eq, gt, lte, sql } from "drizzle-orm" import { and, asc, eq, gt, lte, sql } from "drizzle-orm"
@@ -47,7 +47,7 @@ export const reserveSequence = Effect.fn("Bus.reserveSequence")(function* (
export type SerializedEvent = { export type SerializedEvent = {
readonly id: Event.ID readonly id: Event.ID
readonly type: string readonly type: string
readonly created?: number readonly created?: DateTime.Utc
readonly seq: number readonly seq: number
readonly aggregateID: string readonly aggregateID: string
readonly data: Record<string, unknown> readonly data: Record<string, unknown>
@@ -74,7 +74,7 @@ const decodeSerializedEvent = (event: SerializedEvent): Event.Payload => {
} }
return { return {
id: event.id, id: event.id,
created: event.created ?? 0, created: event.created ?? DateTime.makeUnsafe(0),
type: definition.type, type: definition.type,
durable: envelope(event.aggregateID, event.seq, definition.durable.version), durable: envelope(event.aggregateID, event.seq, definition.durable.version),
data: Schema.decodeUnknownSync(definition.data)(event.data), data: Schema.decodeUnknownSync(definition.data)(event.data),
@@ -283,7 +283,7 @@ export function configured(options?: Options) {
if ( if (
stored?.id === event.id && stored?.id === event.id &&
stored.type === versionedType(definition.type, durable.version) && stored.type === versionedType(definition.type, durable.version) &&
stored.created === (event.created ?? 0) && stored.created === DateTime.toEpochMillis(event.created ?? DateTime.makeUnsafe(0)) &&
isDeepStrictEqual(stored.data, encoded) isDeepStrictEqual(stored.data, encoded)
) { ) {
if (input.ownerID && row?.ownerID == null) { if (input.ownerID && row?.ownerID == null) {
@@ -358,7 +358,7 @@ export function configured(options?: Options) {
id: event.id, id: event.id,
aggregate_id: aggregateID, aggregate_id: aggregateID,
seq, seq,
created: event.created ?? 0, created: DateTime.toEpochMillis(event.created ?? DateTime.makeUnsafe(0)),
type: versionedType(definition.type, durable.version), type: versionedType(definition.type, durable.version),
data: encoded, data: encoded,
}, },
@@ -455,7 +455,7 @@ export function configured(options?: Options) {
definition, definition,
{ {
id: options?.id ?? Event.ID.create(), id: options?.id ?? Event.ID.create(),
created: yield* Clock.currentTimeMillis, created: yield* DateTime.now,
...(options?.metadata ? { metadata: options.metadata } : {}), ...(options?.metadata ? { metadata: options.metadata } : {}),
type: definition.type, type: definition.type,
...(location ? { location } : {}), ...(location ? { location } : {}),
@@ -491,7 +491,7 @@ export function configured(options?: Options) {
commit: options?.commit, commit: options?.commit,
event: { event: {
id: options?.id ?? Event.ID.create(), id: options?.id ?? Event.ID.create(),
created: yield* Clock.currentTimeMillis, created: yield* DateTime.now,
...(options?.metadata ? { metadata: options.metadata } : {}), ...(options?.metadata ? { metadata: options.metadata } : {}),
type: definition.type, type: definition.type,
...(location ? { location } : {}), ...(location ? { location } : {}),
@@ -571,7 +571,7 @@ export function configured(options?: Options) {
id: event.id, id: event.id,
aggregate_id: aggregateID, aggregate_id: aggregateID,
seq, seq,
created: event.created, created: DateTime.toEpochMillis(event.created),
type: versionedType(item.definition.type, item.definition.durable.version), type: versionedType(item.definition.type, item.definition.durable.version),
data: encoded, data: encoded,
}) })
@@ -619,7 +619,7 @@ export function configured(options?: Options) {
Effect.gen(function* () { Effect.gen(function* () {
const payload = { const payload = {
id: event.id, id: event.id,
created: event.created ?? 0, created: event.created ?? DateTime.makeUnsafe(0),
type: definition.type, type: definition.type,
data: Schema.decodeUnknownSync(definition.data)(event.data), data: Schema.decodeUnknownSync(definition.data)(event.data),
} as Event.Payload } as Event.Payload
@@ -733,7 +733,7 @@ export function configured(options?: Options) {
return [ return [
decodeSerializedEvent({ decodeSerializedEvent({
id: event.id, id: event.id,
created: event.created, created: DateTime.makeUnsafe(event.created),
aggregateID: event.aggregate_id, aggregateID: event.aggregate_id,
seq: event.seq, seq: event.seq,
type: event.type, type: event.type,
+2 -2
View File
@@ -65,8 +65,8 @@ const layer = Layer.effect(
const integrations = yield* Integration.Service const integrations = yield* Integration.Service
const available = (provider: Provider.Info, integration: Integration.Info | undefined) => { const available = (provider: Provider.Info, integration: Integration.Info | undefined) => {
if (provider.activation === "disabled") return false if (provider.disabled) return false
if (provider.activation === "enabled") return true if (typeof provider.settings?.apiKey === "string") return true
if (integration?.connections.length) return true if (integration?.connections.length) return true
return provider.integrationID === undefined && !integration return provider.integrationID === undefined && !integration
} }
@@ -40,7 +40,6 @@ export const Plugin = define({
for (const [id, item] of configuredProviders(loaded.entries)) { for (const [id, item] of configuredProviders(loaded.entries)) {
const providerID = id const providerID = id
catalog.provider.update(providerID, (provider) => { catalog.provider.update(providerID, (provider) => {
provider.activation = "enabled"
if (item.name !== undefined) provider.name = item.name if (item.name !== undefined) provider.name = item.name
if (item.package !== undefined) provider.package = item.package if (item.package !== undefined) provider.package = item.package
if (item.settings !== undefined) provider.settings = Provider.mergeOverlay(provider.settings, item.settings) if (item.settings !== undefined) provider.settings = Provider.mergeOverlay(provider.settings, item.settings)
-2
View File
@@ -43,7 +43,6 @@ import m40 from "./migration/20260808023530_workspace_domain.js"
import m41 from "./migration/20260811161259_execution_claim_attempts.js" import m41 from "./migration/20260811161259_execution_claim_attempts.js"
import m42 from "./migration/20260812181746_session_inbox.js" import m42 from "./migration/20260812181746_session_inbox.js"
import m43 from "./migration/20260812213948_worktree.js" import m43 from "./migration/20260812213948_worktree.js"
import m44 from "./migration/20260815182818_session_viewed_state.js"
export const migrations = [ export const migrations = [
m00, m00,
@@ -90,5 +89,4 @@ export const migrations = [
m41, m41,
m42, m42,
m43, m43,
m44,
] satisfies DatabaseMigration.Migration[] ] satisfies DatabaseMigration.Migration[]
@@ -1,14 +0,0 @@
import { Effect } from "effect"
import type { DatabaseMigration } from "../migration.js"
const migration: DatabaseMigration.Migration = {
id: "20260815182818_session_viewed_state",
up(tx) {
return Effect.gen(function* () {
yield* tx.run(`ALTER TABLE \`session_v2\` ADD \`time_idle\` integer;`)
yield* tx.run(`ALTER TABLE \`session_v2\` ADD \`time_viewed\` integer;`)
})
},
}
export default migration
-2
View File
@@ -209,8 +209,6 @@ const schema: Omit<DatabaseMigration.Migration, "id"> = {
\`model\` text, \`model\` text,
\`time_created\` integer NOT NULL, \`time_created\` integer NOT NULL,
\`time_updated\` integer NOT NULL, \`time_updated\` integer NOT NULL,
\`time_idle\` integer,
\`time_viewed\` integer,
\`time_compacting\` integer, \`time_compacting\` integer,
\`time_archived\` integer, \`time_archived\` integer,
\`time_suspended\` integer, \`time_suspended\` integer,
+20 -36
View File
@@ -23,32 +23,6 @@ export type Options = typeof Options.Type
export class Service extends Context.Service<Service, Interface>()("@opencode/FileSystem/Search") {} export class Service extends Context.Service<Service, Interface>()("@opencode/FileSystem/Search") {}
const REFRESH_INTERVAL = Duration.toMillis("10 seconds") const REFRESH_INTERVAL = Duration.toMillis("10 seconds")
type Prepared = ReturnType<typeof fuzzysort.prepare>
function emptyIndex() {
return { files: new Map<string, Prepared>(), directories: new Map<string, Prepared>() }
}
function search(index: ReturnType<typeof emptyIndex>, input: FileSystem.FindInput) {
const items =
input.type === "file"
? Array.from(index.files.values())
: input.type === "directory"
? Array.from(index.directories.values())
: [...index.files.values(), ...index.directories.values()]
const result = fuzzysort.go(input.query, items, { limit: input.limit ?? 50 })
// Targets are owned by the current location index. The only global fuzzysort
// state left is its query cache, which must not retain every query forever.
fuzzysort.cleanup()
return result.map((item) => {
const relative = item.target
const type = relative.endsWith(path.sep) ? ("directory" as const) : ("file" as const)
return FileSystem.Entry.make({
path: RelativePath.make(relative),
type,
})
})
}
export const ripgrepLayer = Layer.effect( export const ripgrepLayer = Layer.effect(
Service, Service,
@@ -58,13 +32,12 @@ export const ripgrepLayer = Layer.effect(
const scope = yield* Scope.Scope const scope = yield* Scope.Scope
const clock = yield* Clock.Clock const clock = yield* Clock.Clock
const home = Protected.isHome(location.directory) const home = Protected.isHome(location.directory)
let index = emptyIndex() let index = { files: [] as string[], directories: new Set<string>() }
let initialized = false let initialized = false
let settledAt = Number.NEGATIVE_INFINITY let settledAt = Number.NEGATIVE_INFINITY
let refreshing = false let refreshing = false
const scan = Effect.gen(function* () { const scan = Effect.gen(function* () {
const next = emptyIndex() const next = { files: [] as string[], directories: new Set<string>() }
const previous = index
if (!initialized) index = next if (!initialized) index = next
yield* ripgrep.find({ yield* ripgrep.find({
cwd: location.directory, cwd: location.directory,
@@ -73,13 +46,11 @@ export const ripgrepLayer = Layer.effect(
exclude: home ? [...Protected.names()].map((name) => `${name}/**`) : undefined, exclude: home ? [...Protected.names()].map((name) => `${name}/**`) : undefined,
onEntry: (entry) => onEntry: (entry) =>
Effect.sync(() => { Effect.sync(() => {
next.files.set(entry.path, previous.files.get(entry.path) ?? fuzzysort.prepare(entry.path)) next.files.push(entry.path)
const parts = entry.path.split("/") const parts = entry.path.split("/")
parts.slice(0, -1).forEach((_, offset) => { parts
const directory = parts.slice(0, offset + 1).join("/") + path.sep .slice(0, -1)
if (!next.directories.has(directory)) .forEach((_, offset) => next.directories.add(parts.slice(0, offset + 1).join("/") + path.sep))
next.directories.set(directory, previous.directories.get(directory) ?? fuzzysort.prepare(directory))
})
}), }),
}) })
index = next index = next
@@ -103,7 +74,20 @@ export const ripgrepLayer = Layer.effect(
find: (input) => find: (input) =>
Effect.gen(function* () { Effect.gen(function* () {
yield* refresh yield* refresh
return search(index, input) const items =
input.type === "file"
? index.files
: input.type === "directory"
? Array.from(index.directories)
: [...index.files, ...index.directories]
return fuzzysort.go(input.query, items, { limit: input.limit ?? 50 }).map((item) => {
const relative = item.target
const type = relative.endsWith(path.sep) ? ("directory" as const) : ("file" as const)
return FileSystem.Entry.make({
path: RelativePath.make(relative),
type,
})
})
}), }),
}) })
}), }),
+5 -9
View File
@@ -1,5 +1,4 @@
import { Effect, Layer, LayerMap } from "effect" import { Effect, Layer, LayerMap } from "effect"
import path from "path"
import { Agent } from "./agent.js" import { Agent } from "./agent.js"
import { AISDK } from "./aisdk.js" import { AISDK } from "./aisdk.js"
import { Catalog } from "./catalog.js" import { Catalog } from "./catalog.js"
@@ -50,7 +49,6 @@ import { ReadToolFileSystem } from "./tool/read-filesystem.js"
import { Tool } from "./tool.js" import { Tool } from "./tool.js"
import { ToolOutput } from "./tool-output.js" import { ToolOutput } from "./tool-output.js"
import { Vcs } from "./vcs.js" import { Vcs } from "./vcs.js"
import { AbsolutePath } from "./schema.js"
export { LocationServiceMap } from "./location-service-map.js" export { LocationServiceMap } from "./location-service-map.js"
@@ -112,13 +110,11 @@ export type LocationError = LayerNode.Error<typeof locationServices>
export function buildLocationServiceMap( export function buildLocationServiceMap(
replacements: LayerNode.Replacements = [], replacements: LayerNode.Replacements = [],
): Layer.Layer<LocationServiceMap.Service> { ): Layer.Layer<LocationServiceMap.Service> {
// Structural Equal distinguishes optional-key shape and Windows separator style. // Structural Equal is own-key-set sensitive, so `{ directory }` (schema-decoded
// The RcMap caches the raw key before the build callback, so normalize both here. // payloads omit optional keys) and `{ directory, workspaceID: undefined }` are
const canonical = (ref: Location.Ref) => // different RcMap keys. The RcMap caches by the raw key before the build
Location.Ref.make({ // callback runs, so canonicalize at the map boundary to the key-present shape.
directory: AbsolutePath.make(process.platform === "win32" ? path.normalize(ref.directory) : ref.directory), const canonical = (ref: Location.Ref) => Location.Ref.make({ directory: ref.directory, workspaceID: ref.workspaceID })
workspaceID: ref.workspaceID,
})
return Layer.effect( return Layer.effect(
LocationServiceMap.Service, LocationServiceMap.Service,
Effect.map( Effect.map(
+10 -43
View File
@@ -358,21 +358,17 @@ export const layer = Layer.effect(
const connection = yield* integrations.connection.active( const connection = yield* integrations.connection.active(
provider?.integrationID ?? Integration.ID.make(selected.providerID), provider?.integrationID ?? Integration.ID.make(selected.providerID),
) )
const credential = connection ? yield* integrations.connection.resolve(connection) : undefined const model = yield* resolveModel(
const runtimeInfo = yield* withVariant(selected, variant) selected,
const model = yield* fromCatalogModel(runtimeInfo, credential, { variant,
loadPackage: (specifier) => Provider.loadPackage(specifier, npm), connection ? yield* integrations.connection.resolve(connection) : undefined,
loadAISDK: (model) => aisdk.model(model), {
}) loadPackage: (specifier) => Provider.loadPackage(specifier, npm),
const runtime = loadAISDK: (model) => aisdk.model(model),
provider?.activation === "enabled" && },
credential === undefined && )
!hasConfiguredAuth(runtimeInfo) &&
usesAPIKeyAuth(runtimeInfo.package)
? LanguageModel.update(model, { route: model.route.with({ auth: Auth.none }) })
: model
return { return {
model: runtime, model,
ref: Ref.make({ ref: Ref.make({
id: selected.id, id: selected.id,
providerID: selected.providerID, providerID: selected.providerID,
@@ -403,35 +399,6 @@ export const layer = Layer.effect(
}), }),
) )
function hasConfiguredAuth(model: Info) {
return [model.settings?.apiKey, model.settings?.authToken, model.settings?.accessToken].some(
(value) => typeof value === "string" && value !== "",
)
}
function usesAPIKeyAuth(packageName: string | undefined) {
const name = Provider.packageName(packageName)
return (
name === "@ai-sdk/openai" ||
name === "@ai-sdk/anthropic" ||
name === "@ai-sdk/openai-compatible" ||
name === "@ai-sdk/google" ||
name === "@ai-sdk/xai" ||
name === "@openrouter/ai-sdk-provider" ||
name === "@ai-sdk/azure" ||
name === "@opencode-ai/ai/providers/openai" ||
name?.startsWith("@opencode-ai/ai/providers/openai/") === true ||
name === "@opencode-ai/ai/providers/anthropic" ||
name === "@opencode-ai/ai/providers/anthropic-compatible" ||
name === "@opencode-ai/ai/providers/openai-compatible" ||
name === "@opencode-ai/ai/providers/google" ||
name === "@opencode-ai/ai/providers/xai" ||
name === "@opencode-ai/ai/providers/openrouter" ||
name === "@opencode-ai/ai/providers/azure" ||
name?.startsWith("@opencode-ai/ai/providers/azure/") === true
)
}
export const node = makeLocationNode({ export const node = makeLocationNode({
service: Service, service: Service,
layer, layer,
-1
View File
@@ -86,7 +86,6 @@ function normalize(input: Record<string, SourceProvider>): readonly Snapshot[] {
const info = { const info = {
id: providerID, id: providerID,
name: item.name, name: item.name,
activation: "auto",
package: Provider.aisdk(item.npm), package: Provider.aisdk(item.npm),
...(item.api ? { settings: { baseURL: item.api } } : {}), ...(item.api ? { settings: { baseURL: item.api } } : {}),
} satisfies Provider.Info } satisfies Provider.Info
@@ -10,7 +10,7 @@ export const LLMGatewayPlugin = define({
const configured = new Set((yield* integrations.list()).map((integration) => integration.id)) const configured = new Set((yield* integrations.list()).map((integration) => integration.id))
yield* ctx.catalog.transform((evt) => { yield* ctx.catalog.transform((evt) => {
for (const item of evt.provider.list()) { for (const item of evt.provider.list()) {
if (item.provider.activation === "disabled") continue if (item.provider.disabled) continue
if (!Provider.isAISDK(item.provider.package)) continue if (!Provider.isAISDK(item.provider.package)) continue
if (Provider.packageName(item.provider.package) !== "@ai-sdk/openai-compatible") continue if (Provider.packageName(item.provider.package) !== "@ai-sdk/openai-compatible") continue
if (item.provider.settings?.baseURL !== "https://api.llmgateway.io/v1") continue if (item.provider.settings?.baseURL !== "https://api.llmgateway.io/v1") continue
@@ -178,10 +178,7 @@ export const OpencodePlugin = define<HttpClient.HttpClient | Bus.Service | Scope
if (!item) return if (!item) return
const hasKey = Boolean(process.env.OPENCODE_API_KEY || connected || item.provider.settings?.apiKey) const hasKey = Boolean(process.env.OPENCODE_API_KEY || connected || item.provider.settings?.apiKey)
catalog.provider.update(item.provider.id, (provider) => { catalog.provider.update(item.provider.id, (provider) => {
if (!hasKey) { if (!hasKey) provider.settings = { ...provider.settings, apiKey: "public" }
provider.activation = "enabled"
provider.settings = { ...provider.settings, apiKey: "public" }
}
}) })
if (hasKey) return if (hasKey) return
for (const model of item.models.values()) { for (const model of item.models.values()) {
+1 -28
View File
@@ -63,39 +63,12 @@ examples, but do not fetch it to determine the V2 configuration shape.
See the [full configuration guide](https://opencode.ai/v2/docs/config) for See the [full configuration guide](https://opencode.ai/v2/docs/config) for
every field, examples, config locations, and links to dedicated feature guides. every field, examples, config locations, and links to dedicated feature guides.
## [MCP servers](https://opencode.ai/v2/docs/mcp-servers)
Configure MCP servers under `mcp.servers`. Prefer the CLI because it preserves
unrelated configuration. Use `--global` when the user asks to set up a service
for themselves without limiting it to the current project; omit it when they
explicitly want project-local configuration.
```sh
opencode2 mcp add <name> --global --url <remote-url>
opencode2 mcp list
```
Remote servers use OAuth by default. If `mcp list` reports that a server needs
authentication, run the OAuth flow and then verify the connection:
```sh
opencode2 mcp auth <name>
opencode2 mcp list
```
The auth command prints an authorization URL, waits for the browser redirect,
and stores credentials outside the OpenCode configuration. Do not ask for or
store an API key when the server supports OAuth. Use header-based credentials
only when OAuth is unavailable or the user explicitly requires them, and use an
environment substitution such as `{env:MCP_API_KEY}` instead of writing a
secret into configuration.
## [V1 to V2 migration](https://opencode.ai/v2/docs/migrate-v1) ## [V1 to V2 migration](https://opencode.ai/v2/docs/migrate-v1)
For any request to migrate OpenCode configuration, agents, commands, skills, For any request to migrate OpenCode configuration, agents, commands, skills,
plugins, integrations, or other behavior from V1 to V2, read the full plugins, integrations, or other behavior from V1 to V2, read the full
[migration guide](https://opencode.ai/v2/docs/migrate-v1) before acting. In [migration guide](https://opencode.ai/v2/docs/migrate-v1) before acting. In
the repository, its source is `packages/www/content/docs/migrate-v1.mdx`. the repository, its source is `packages/www/content/docs/(Get started)/migrate-v1.mdx`.
V1 config files and `.opencode/` definitions are intended to remain compatible. V1 config files and `.opencode/` definitions are intended to remain compatible.
The only intentional breaking changes are the server API and plugin API. Native The only intentional breaking changes are the server API and plugin API. Native
+7 -17
View File
@@ -165,7 +165,6 @@ export interface Interface {
input: ForkInput, input: ForkInput,
) => Effect.Effect<SessionSchema.Info, NotFoundError | MessageNotFoundError | ForkEmptyError> ) => Effect.Effect<SessionSchema.Info, NotFoundError | MessageNotFoundError | ForkEmptyError>
readonly get: (sessionID: SessionSchema.ID) => Effect.Effect<SessionSchema.Info, NotFoundError> readonly get: (sessionID: SessionSchema.ID) => Effect.Effect<SessionSchema.Info, NotFoundError>
readonly view: (input: { sessionID: SessionSchema.ID }) => Effect.Effect<void, NotFoundError>
readonly remove: (sessionID: SessionSchema.ID) => Effect.Effect<void, NotFoundError> readonly remove: (sessionID: SessionSchema.ID) => Effect.Effect<void, NotFoundError>
readonly messages: (input: { readonly messages: (input: {
sessionID: SessionSchema.ID sessionID: SessionSchema.ID
@@ -448,17 +447,6 @@ const layer = Layer.effect(
if (!session) return yield* new NotFoundError({ sessionID }) if (!session) return yield* new NotFoundError({ sessionID })
return session return session
}), }),
view: Effect.fn("Session.view")(function* (input) {
const row = yield* db
.select({ idle: SessionTable.time_idle, viewed: SessionTable.time_viewed })
.from(SessionTable)
.where(eq(SessionTable.id, input.sessionID))
.get()
.pipe(Effect.orDie)
if (!row) return yield* new NotFoundError({ sessionID: input.sessionID })
if (row.idle === null || (row.viewed !== null && row.viewed >= row.idle)) return
yield* bus.publish(SessionEvent.Viewed, { sessionID: input.sessionID })
}),
remove: Effect.fn("Session.remove")(function* (sessionID) { remove: Effect.fn("Session.remove")(function* (sessionID) {
const session = yield* result.get(sessionID) const session = yield* result.get(sessionID)
yield* execution.interrupt(sessionID) yield* execution.interrupt(sessionID)
@@ -801,10 +789,7 @@ const layer = Layer.effect(
return false return false
}), }),
) )
if (recovered) { if (recovered) return
yield* execution.wakeActive(input.sessionID)
return
}
yield* execution.wake(input.sessionID) yield* execution.wake(input.sessionID)
}), }),
compact: Effect.fn("Session.compact")(function* (input) { compact: Effect.fn("Session.compact")(function* (input) {
@@ -888,7 +873,12 @@ const layer = Layer.effect(
), ),
), ),
interrupt: Effect.fn("Session.interrupt")((sessionID, options) => interrupt: Effect.fn("Session.interrupt")((sessionID, options) =>
Effect.uninterruptible(execution.interrupt(sessionID, options)), Effect.uninterruptible(
Effect.gen(function* () {
yield* execution.interrupt(sessionID)
if (options?.continue && (yield* SessionInbox.has(db, sessionID, "any"))) yield* execution.wake(sessionID)
}),
),
), ),
revert: { revert: {
stage: Effect.fn("Session.revert.stage")(function* (input) { stage: Effect.fn("Session.revert.stage")(function* (input) {
+11 -22
View File
@@ -1,8 +1,7 @@
export * as SessionExecution from "./execution.js" export * as SessionExecution from "./execution.js"
import { Cause, Context, Effect, Exit, Layer } from "effect" import { Cause, Context, Effect, Exit, Layer, Stream } from "effect"
import { Bus } from "../bus.js" import { Bus } from "../bus.js"
import { Database } from "../database/database.js"
import { LocationServiceMap } from "../location-service-map.js" import { LocationServiceMap } from "../location-service-map.js"
import { makeGlobalNode } from "@opencode-ai/util/effect/app-node" import { makeGlobalNode } from "@opencode-ai/util/effect/app-node"
import { SessionEvent } from "./event.js" import { SessionEvent } from "./event.js"
@@ -12,7 +11,6 @@ import { SessionSchema } from "./schema.js"
import { SessionStore } from "./store.js" import { SessionStore } from "./store.js"
import { toSessionError } from "./to-session-error.js" import { toSessionError } from "./to-session-error.js"
import { UserInterruptedError } from "./error.js" import { UserInterruptedError } from "./error.js"
import { SessionInbox } from "./inbox.js"
export interface Interface { export interface Interface {
/** Snapshots active execution owned by this process. */ /** Snapshots active execution owned by this process. */
@@ -21,10 +19,8 @@ export interface Interface {
readonly resume: (sessionID: SessionSchema.ID) => Effect.Effect<void, SessionRunner.RunError> readonly resume: (sessionID: SessionSchema.ID) => Effect.Effect<void, SessionRunner.RunError>
/** Registers newly recorded work. Repeated wakeups may coalesce. */ /** Registers newly recorded work. Repeated wakeups may coalesce. */
readonly wake: (sessionID: SessionSchema.ID) => Effect.Effect<void> readonly wake: (sessionID: SessionSchema.ID) => Effect.Effect<void>
/** Wakes only an active execution, preserving its current input eligibility. */
readonly wakeActive: (sessionID: SessionSchema.ID) => Effect.Effect<void>
/** Interrupt active work owned by this process. Idle interruption is a no-op. */ /** Interrupt active work owned by this process. Idle interruption is a no-op. */
readonly interrupt: (sessionID: SessionSchema.ID, options?: { readonly continue?: boolean }) => Effect.Effect<void> readonly interrupt: (sessionID: SessionSchema.ID) => Effect.Effect<void>
/** Resolves once this process owns no active execution for the Session. Returns immediately when idle and never starts work. */ /** Resolves once this process owns no active execution for the Session. Returns immediately when idle and never starts work. */
readonly awaitIdle: (sessionID: SessionSchema.ID) => Effect.Effect<void> readonly awaitIdle: (sessionID: SessionSchema.ID) => Effect.Effect<void>
} }
@@ -49,7 +45,6 @@ export const layer = Layer.effect(
const store = yield* SessionStore.Service const store = yield* SessionStore.Service
const locations = yield* LocationServiceMap.Service const locations = yield* LocationServiceMap.Service
const bus = yield* Bus.Service const bus = yield* Bus.Service
const db = (yield* Database.Service).db
const reportLifecycle = <A>(sessionID: SessionSchema.ID, effect: Effect.Effect<A>) => const reportLifecycle = <A>(sessionID: SessionSchema.ID, effect: Effect.Effect<A>) =>
effect.pipe( effect.pipe(
Effect.tapCause((cause) => Effect.tapCause((cause) =>
@@ -76,13 +71,12 @@ export const layer = Layer.effect(
sessionID: SessionSchema.ID, sessionID: SessionSchema.ID,
force: boolean, force: boolean,
continuation?: SessionRunner.Continuation, continuation?: SessionRunner.Continuation,
promotable: SessionInbox.Promotable = "input",
): Effect.Effect<void, SessionRunner.RunError> { ): Effect.Effect<void, SessionRunner.RunError> {
return Effect.gen(function* () { return Effect.gen(function* () {
const session = yield* store.get(sessionID) const session = yield* store.get(sessionID)
if (!session) return yield* Effect.die(new Error(`Session not found: ${sessionID}`)) if (!session) return yield* Effect.die(new Error(`Session not found: ${sessionID}`))
const result = yield* SessionRunner.Service.use((runner) => const result = yield* SessionRunner.Service.use((runner) =>
runner.drain({ sessionID, force, continuation, promotable }), runner.drain({ sessionID, force, continuation }),
).pipe( ).pipe(
Effect.provide(locations.get(session.location)), Effect.provide(locations.get(session.location)),
Effect.tapCause((cause) => Effect.tapCause((cause) =>
@@ -92,7 +86,7 @@ export const layer = Layer.effect(
), ),
) )
if (result.type === "complete") return if (result.type === "complete") return
return yield* drain(sessionID, false, result.continuation, promotable) return yield* drain(sessionID, false, result.continuation)
}) })
} }
const coordinator = yield* SessionRunCoordinator.make<SessionSchema.ID, SessionRunner.RunError, InterruptReason>({ const coordinator = yield* SessionRunCoordinator.make<SessionSchema.ID, SessionRunner.RunError, InterruptReason>({
@@ -101,7 +95,7 @@ export const layer = Layer.effect(
sessionID, sessionID,
bus.publish(SessionEvent.Execution.Started, { sessionID }, claimOnCommit(sessionID)), bus.publish(SessionEvent.Execution.Started, { sessionID }, claimOnCommit(sessionID)),
), ),
drain: (sessionID, force, promotable) => drain(sessionID, force, undefined, promotable), drain: (sessionID, force) => drain(sessionID, force),
// One terminal observation per busy period, covering every coalesced drain. // One terminal observation per busy period, covering every coalesced drain.
settled: (sessionID, exit, reason) => settled: (sessionID, exit, reason) =>
reportLifecycle( reportLifecycle(
@@ -133,20 +127,16 @@ export const layer = Layer.effect(
}), }),
), ),
}) })
yield* bus.subscribe(SessionEvent.Moved).pipe(
Stream.runForEach((event) => coordinator.wake(event.data.sessionID)),
Effect.forkScoped,
)
return Service.of({ return Service.of({
active: coordinator.active, active: coordinator.active,
interrupt: (sessionID, options) => interrupt: (sessionID) => coordinator.interrupt(sessionID, "user"),
coordinator.interrupt(
sessionID,
"user",
options?.continue
? { continue: { request: "steer", when: SessionInbox.has(db, sessionID, "steer") } }
: undefined,
),
resume: coordinator.run, resume: coordinator.run,
wake: coordinator.wake, wake: coordinator.wake,
wakeActive: coordinator.wakeActive,
awaitIdle: coordinator.awaitIdle, awaitIdle: coordinator.awaitIdle,
}) })
}), }),
@@ -155,7 +145,7 @@ export const layer = Layer.effect(
export const node = makeGlobalNode({ export const node = makeGlobalNode({
service: Service, service: Service,
layer, layer,
deps: [SessionStore.node, LocationServiceMap.node, Bus.node, Database.node], deps: [SessionStore.node, LocationServiceMap.node, Bus.node],
}) })
/** Low-level compatibility layer for callers that only need durable Session recording. */ /** Low-level compatibility layer for callers that only need durable Session recording. */
@@ -165,7 +155,6 @@ export const noopLayer = Layer.succeed(
active: Effect.succeed(new Set()), active: Effect.succeed(new Set()),
resume: () => Effect.void, resume: () => Effect.void,
wake: () => Effect.void, wake: () => Effect.void,
wakeActive: () => Effect.void,
interrupt: () => Effect.void, interrupt: () => Effect.void,
awaitIdle: () => Effect.void, awaitIdle: () => Effect.void,
}), }),
+3 -11
View File
@@ -161,7 +161,7 @@ export const admit = Effect.fn("SessionInbox.admit")(function* (
const base = { const base = {
id: request.id, id: request.id,
sessionID: request.sessionID, sessionID: request.sessionID,
timeCreated: DateTime.makeUnsafe(event.created), timeCreated: event.created,
} }
return Effect.succeed(Info.make({ ...base, ...request.item })) return Effect.succeed(Info.make({ ...base, ...request.item }))
}), }),
@@ -196,7 +196,7 @@ export const projectAdmitted = Effect.fn("SessionInbox.projectAdmitted")(functio
readonly id: SessionMessage.ID readonly id: SessionMessage.ID
readonly sessionID: SessionSchema.ID readonly sessionID: SessionSchema.ID
readonly item: Item readonly item: Item
readonly timeCreated: number readonly timeCreated: DateTime.Utc
}, },
) { ) {
const message = yield* db const message = yield* db
@@ -222,7 +222,7 @@ export const projectAdmitted = Effect.fn("SessionInbox.projectAdmitted")(functio
: encodeMove(request.item.payload), : encodeMove(request.item.payload),
delivery: request.item.delivery, delivery: request.item.delivery,
enqueued_seq: request.enqueuedSeq, enqueued_seq: request.enqueuedSeq,
time_created: request.timeCreated, time_created: DateTime.toEpochMillis(request.timeCreated),
}) })
.onConflictDoNothing() .onConflictDoNothing()
.returning({ id: SessionInboxTable.id }) .returning({ id: SessionInboxTable.id })
@@ -349,14 +349,6 @@ export const nextSteer = Effect.fn("SessionInbox.nextSteer")(function* (
return row ? fromRow(row) : undefined return row ? fromRow(row) : undefined
}) })
export const nextPromotable = Effect.fn("SessionInbox.nextPromotable")(function* (
db: DatabaseService,
sessionID: SessionSchema.ID,
promotable: Promotable,
) {
return (yield* nextSteer(db, sessionID)) ?? (promotable === "input" ? yield* nextQueued(db, sessionID) : undefined)
})
/** /**
* Which pending rows count: "any" counts every row, while "input" means any * Which pending rows count: "any" counts every row, while "input" means any
* item in either delivery mode. * item in either delivery mode.
-2
View File
@@ -53,8 +53,6 @@ export function fromRow(row: typeof SessionTable.$inferSelect): SessionSchema.In
time: { time: {
created: DateTime.makeUnsafe(row.time_created), created: DateTime.makeUnsafe(row.time_created),
updated: DateTime.makeUnsafe(row.time_updated), updated: DateTime.makeUnsafe(row.time_updated),
idle: row.time_idle === null ? undefined : DateTime.makeUnsafe(row.time_idle),
viewed: row.time_viewed === null ? undefined : DateTime.makeUnsafe(row.time_viewed),
archived: row.time_archived ? DateTime.makeUnsafe(row.time_archived) : undefined, archived: row.time_archived ? DateTime.makeUnsafe(row.time_archived) : undefined,
}, },
}) })
+21 -23
View File
@@ -26,7 +26,6 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
type DraftTool = WritableDraft<SessionMessage.AssistantTool> type DraftTool = WritableDraft<SessionMessage.AssistantTool>
type DraftText = WritableDraft<SessionMessage.AssistantText> type DraftText = WritableDraft<SessionMessage.AssistantText>
type DraftReasoning = WritableDraft<SessionMessage.AssistantReasoning> type DraftReasoning = WritableDraft<SessionMessage.AssistantReasoning>
const created = DateTime.makeUnsafe(event.created)
const latestTool = (assistant: DraftAssistant | undefined, id?: string) => const latestTool = (assistant: DraftAssistant | undefined, id?: string) =>
assistant?.content.findLast( assistant?.content.findLast(
@@ -60,7 +59,6 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
Match.type<SessionEvent.DurableEvent>(), Match.type<SessionEvent.DurableEvent>(),
Match.discriminatorsExhaustive("type")({ Match.discriminatorsExhaustive("type")({
"session.created": () => Effect.void, "session.created": () => Effect.void,
"session.viewed": () => Effect.void,
"session.usage.recorded": () => Effect.void, "session.usage.recorded": () => Effect.void,
"session.agent.selected": (event) => { "session.agent.selected": (event) => {
return Effect.gen(function* () { return Effect.gen(function* () {
@@ -72,7 +70,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
metadata: event.metadata, metadata: event.metadata,
agent: event.data.agent, agent: event.data.agent,
previous, previous,
time: { created }, time: { created: event.created },
}), }),
) )
}) })
@@ -87,7 +85,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
metadata: event.metadata, metadata: event.metadata,
model: event.data.model, model: event.data.model,
previous, previous,
time: { created }, time: { created: event.created },
}), }),
) )
}) })
@@ -103,7 +101,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
projectID: event.data.projectID, projectID: event.data.projectID,
subpath: event.data.subpath, subpath: event.data.subpath,
previous: yield* adapter.getLocation(), previous: yield* adapter.getLocation(),
time: { created }, time: { created: event.created },
}), }),
) )
}) })
@@ -128,7 +126,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
text: event.data.text, text: event.data.text,
description: `Instructions updated: ${Object.keys(event.data.delta).join(", ")}`, description: `Instructions updated: ${Object.keys(event.data.delta).join(", ")}`,
metadata: event.metadata, metadata: event.metadata,
time: { created }, time: { created: event.created },
}), }),
) )
}, },
@@ -140,7 +138,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
metadata: event.data.metadata, metadata: event.data.metadata,
id: SessionMessage.ID.fromEvent(event.id), id: SessionMessage.ID.fromEvent(event.id),
type: "synthetic", type: "synthetic",
time: { created }, time: { created: event.created },
}), }),
) )
}, },
@@ -153,7 +151,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
name: event.data.name, name: event.data.name,
text: event.data.text, text: event.data.text,
metadata: event.metadata, metadata: event.metadata,
time: { created }, time: { created: event.created },
}), }),
) )
}, },
@@ -166,7 +164,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
shellID: event.data.shell.id, shellID: event.data.shell.id,
command: event.data.shell.command, command: event.data.shell.command,
status: event.data.shell.status, status: event.data.shell.status,
time: { created }, time: { created: event.created },
}), }),
) )
}, },
@@ -179,7 +177,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
draft.status = event.data.shell.status draft.status = event.data.shell.status
draft.exit = event.data.shell.exit draft.exit = event.data.shell.exit
draft.output = event.data.output draft.output = event.data.output
draft.time.completed = created draft.time.completed = event.created
}), }),
) )
} }
@@ -207,7 +205,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
yield* adapter.updateAssistant( yield* adapter.updateAssistant(
produce(currentAssistant, (draft) => { produce(currentAssistant, (draft) => {
draft.retry = undefined draft.retry = undefined
draft.time.completed = created draft.time.completed = event.created
}), }),
) )
} }
@@ -218,7 +216,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
agent: event.data.agent, agent: event.data.agent,
model: event.data.model, model: event.data.model,
metadata: event.metadata, metadata: event.metadata,
time: { created }, time: { created: event.created },
content: [], content: [],
snapshot: event.data.snapshot ? { start: event.data.snapshot } : undefined, snapshot: event.data.snapshot ? { start: event.data.snapshot } : undefined,
}), }),
@@ -227,7 +225,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
}, },
"session.step.ended": (event) => { "session.step.ended": (event) => {
return updateOwnedAssistant(event.data.assistantMessageID, (draft) => { return updateOwnedAssistant(event.data.assistantMessageID, (draft) => {
draft.time.completed = created draft.time.completed = event.created
draft.finish = event.data.finish draft.finish = event.data.finish
draft.cost = event.data.cost draft.cost = event.data.cost
draft.tokens = event.data.tokens draft.tokens = event.data.tokens
@@ -241,7 +239,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
}, },
"session.step.failed": (event) => { "session.step.failed": (event) => {
return updateOwnedAssistant(event.data.assistantMessageID, (draft) => { return updateOwnedAssistant(event.data.assistantMessageID, (draft) => {
draft.time.completed = created draft.time.completed = event.created
draft.finish = "error" draft.finish = "error"
draft.error = castDraft(event.data.error) draft.error = castDraft(event.data.error)
draft.retry = undefined draft.retry = undefined
@@ -279,7 +277,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
type: "tool", type: "tool",
id: event.data.id, id: event.data.id,
name: event.data.name, name: event.data.name,
time: { created }, time: { created: event.created },
state: SessionMessage.ToolStateStreaming.make({ status: "streaming", input: "" }), state: SessionMessage.ToolStateStreaming.make({ status: "streaming", input: "" }),
}), }),
), ),
@@ -298,7 +296,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
if (match) { if (match) {
match.executed = event.data.executed match.executed = event.data.executed
match.providerState = event.data.state match.providerState = event.data.state
match.time.ran = created match.time.ran = event.created
match.state = castDraft( match.state = castDraft(
SessionMessage.ToolStateRunning.make({ SessionMessage.ToolStateRunning.make({
status: "running", status: "running",
@@ -317,7 +315,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
if (match && match.state.status === "running") { if (match && match.state.status === "running") {
match.executed = event.data.executed || match.executed === true match.executed = event.data.executed || match.executed === true
match.providerResultState = event.data.resultState match.providerResultState = event.data.resultState
match.time.completed = created match.time.completed = event.created
match.state = castDraft( match.state = castDraft(
SessionMessage.ToolStateCompleted.make({ SessionMessage.ToolStateCompleted.make({
status: "completed", status: "completed",
@@ -335,7 +333,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
if (match && (match.state.status === "streaming" || match.state.status === "running")) { if (match && (match.state.status === "streaming" || match.state.status === "running")) {
match.executed = event.data.executed || match.executed === true match.executed = event.data.executed || match.executed === true
match.providerResultState = event.data.resultState match.providerResultState = event.data.resultState
match.time.completed = created match.time.completed = event.created
match.state = castDraft( match.state = castDraft(
SessionMessage.ToolStateError.make({ SessionMessage.ToolStateError.make({
status: "error", status: "error",
@@ -356,7 +354,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
type: "reasoning", type: "reasoning",
text: "", text: "",
state: event.data.state, state: event.data.state,
time: { created }, time: { created: event.created },
}), }),
), ),
) )
@@ -367,7 +365,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
const match = latestReasoning(draft) const match = latestReasoning(draft)
if (match) { if (match) {
match.text = event.data.text match.text = event.data.text
match.time = { created: match.time?.created ?? created, completed: created } match.time = { created: match.time?.created ?? event.created, completed: event.created }
if (event.data.state !== undefined) match.state = event.data.state if (event.data.state !== undefined) match.state = event.data.state
} }
}) })
@@ -391,7 +389,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
reason: event.data.reason, reason: event.data.reason,
summary: "", summary: "",
recent: event.data.recent ?? "", recent: event.data.recent ?? "",
time: { created }, time: { created: event.created },
}), }),
), ),
"session.compaction.ended": (event) => { "session.compaction.ended": (event) => {
@@ -416,7 +414,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
reason: event.data.reason, reason: event.data.reason,
summary: event.data.text, summary: event.data.text,
recent: event.data.recent, recent: event.data.recent,
time: { created }, time: { created: event.created },
}), }),
) )
}) })
@@ -431,7 +429,7 @@ export function update(adapter: Adapter, event: SessionEvent.DurableEvent) {
metadata: current?.metadata ?? event.metadata, metadata: current?.metadata ?? event.metadata,
reason: event.data.reason, reason: event.data.reason,
error: event.data.error, error: event.data.error,
time: current?.time ?? { created }, time: current?.time ?? { created: event.created },
}) })
if (current?.status === "running") return yield* adapter.updateCompaction(failed) if (current?.status === "running") return yield* adapter.updateCompaction(failed)
yield* adapter.appendMessage(failed) yield* adapter.appendMessage(failed)
+17 -52
View File
@@ -162,8 +162,8 @@ const projectFork = Effect.fn("SessionProjector.projectFork")(function* (
tokens_reasoning: 0, tokens_reasoning: 0,
tokens_cache_read: 0, tokens_cache_read: 0,
tokens_cache_write: 0, tokens_cache_write: 0,
time_created: event.created, time_created: DateTime.toEpochMillis(event.created),
time_updated: event.created, time_updated: DateTime.toEpochMillis(event.created),
}) })
.onConflictDoNothing() .onConflictDoNothing()
.returning({ sessionID: SessionTable.id }) .returning({ sessionID: SessionTable.id })
@@ -391,30 +391,6 @@ function insertMessage(db: DatabaseService, event: SessionEvent.DurableEvent, me
.pipe(Effect.orDie) .pipe(Effect.orDie)
} }
function projectIdle(
db: DatabaseService,
event:
| typeof SessionEvent.Execution.Succeeded.Type
| typeof SessionEvent.Execution.Failed.Type
| typeof SessionEvent.Execution.Interrupted.Type,
) {
return Effect.gen(function* () {
yield* run(db, event)
if (event.type === SessionEvent.Execution.Interrupted.type && event.data.reason === "shutdown") return
const time = event.created
yield* db
.update(SessionTable)
.set({
// Unread uses a strict timestamp comparison, so every terminal must advance even within one millisecond.
time_idle: sql`max(${time}, coalesce(${SessionTable.time_idle} + 1, ${time}))`,
time_updated: sql`${SessionTable.time_updated}`,
})
.where(eq(SessionTable.id, event.data.sessionID))
.run()
.pipe(Effect.orDie)
})
}
const layer = Layer.effectDiscard( const layer = Layer.effectDiscard(
Effect.gen(function* () { Effect.gen(function* () {
const bus = yield* Bus.Service const bus = yield* Bus.Service
@@ -435,8 +411,8 @@ const layer = Layer.effectDiscard(
agent: event.data.agent, agent: event.data.agent,
model: event.data.model, model: event.data.model,
version: event.data.version, version: event.data.version,
time_created: event.created, time_created: DateTime.toEpochMillis(event.created),
time_updated: event.created, time_updated: DateTime.toEpochMillis(event.created),
}) })
.onConflictDoNothing() .onConflictDoNothing()
.returning({ sessionID: SessionTable.id }) .returning({ sessionID: SessionTable.id })
@@ -455,7 +431,7 @@ const layer = Layer.effectDiscard(
path: event.data.subpath, path: event.data.subpath,
...(event.data.projectID ? { project_id: event.data.projectID } : {}), ...(event.data.projectID ? { project_id: event.data.projectID } : {}),
workspace_id: event.data.location.workspaceID ? Workspace.ID.make(event.data.location.workspaceID) : null, workspace_id: event.data.location.workspaceID ? Workspace.ID.make(event.data.location.workspaceID) : null,
time_updated: event.created, time_updated: DateTime.toEpochMillis(event.created),
}) })
.where(eq(SessionTable.id, event.data.sessionID)) .where(eq(SessionTable.id, event.data.sessionID))
.run() .run()
@@ -511,7 +487,7 @@ const layer = Layer.effectDiscard(
yield* run(db, event) yield* run(db, event)
yield* db yield* db
.update(SessionTable) .update(SessionTable)
.set({ agent: event.data.agent, time_updated: event.created }) .set({ agent: event.data.agent, time_updated: DateTime.toEpochMillis(event.created) })
.where(eq(SessionTable.id, event.data.sessionID)) .where(eq(SessionTable.id, event.data.sessionID))
.run() .run()
.pipe(Effect.orDie) .pipe(Effect.orDie)
@@ -522,7 +498,7 @@ const layer = Layer.effectDiscard(
yield* run(db, event) yield* run(db, event)
yield* db yield* db
.update(SessionTable) .update(SessionTable)
.set({ model: event.data.model, time_updated: event.created }) .set({ model: event.data.model, time_updated: DateTime.toEpochMillis(event.created) })
.where(eq(SessionTable.id, event.data.sessionID)) .where(eq(SessionTable.id, event.data.sessionID))
.run() .run()
.pipe(Effect.orDie) .pipe(Effect.orDie)
@@ -531,18 +507,7 @@ const layer = Layer.effectDiscard(
yield* bus.project(SessionEvent.Renamed, (event) => yield* bus.project(SessionEvent.Renamed, (event) =>
db db
.update(SessionTable) .update(SessionTable)
.set({ title: event.data.title, time_updated: event.created }) .set({ title: event.data.title, time_updated: DateTime.toEpochMillis(event.created) })
.where(eq(SessionTable.id, event.data.sessionID))
.run()
.pipe(Effect.orDie),
)
yield* bus.project(SessionEvent.Viewed, (event) =>
db
.update(SessionTable)
.set({
time_viewed: sql`${SessionTable.time_idle}`,
time_updated: sql`${SessionTable.time_updated}`,
})
.where(eq(SessionTable.id, event.data.sessionID)) .where(eq(SessionTable.id, event.data.sessionID))
.run() .run()
.pipe(Effect.orDie), .pipe(Effect.orDie),
@@ -570,7 +535,7 @@ const layer = Layer.effectDiscard(
files: input.payload.files, files: input.payload.files,
agents: input.payload.agents, agents: input.payload.agents,
skills: input.payload.skills, skills: input.payload.skills,
time: { created: DateTime.makeUnsafe(event.created) }, time: { created: event.created },
} }
: { : {
id: input.id, id: input.id,
@@ -578,7 +543,7 @@ const layer = Layer.effectDiscard(
text: input.payload.text, text: input.payload.text,
description: input.payload.description, description: input.payload.description,
metadata: input.payload.metadata, metadata: input.payload.metadata,
time: { created: DateTime.makeUnsafe(event.created) }, time: { created: event.created },
}, },
) )
}), }),
@@ -596,7 +561,7 @@ const layer = Layer.effectDiscard(
}) })
yield* db yield* db
.update(SessionTable) .update(SessionTable)
.set({ time_updated: event.created }) .set({ time_updated: DateTime.toEpochMillis(event.created) })
.where(eq(SessionTable.id, event.data.sessionID)) .where(eq(SessionTable.id, event.data.sessionID))
.run() .run()
.pipe(Effect.orDie) .pipe(Effect.orDie)
@@ -615,9 +580,9 @@ const layer = Layer.effectDiscard(
delivery: event.data.delivery, delivery: event.data.delivery,
}), }),
) )
yield* bus.project(SessionEvent.Execution.Succeeded, (event) => projectIdle(db, event)) yield* bus.project(SessionEvent.Execution.Succeeded, (event) => run(db, event))
yield* bus.project(SessionEvent.Execution.Failed, (event) => projectIdle(db, event)) yield* bus.project(SessionEvent.Execution.Failed, (event) => run(db, event))
yield* bus.project(SessionEvent.Execution.Interrupted, (event) => projectIdle(db, event)) yield* bus.project(SessionEvent.Execution.Interrupted, (event) => run(db, event))
yield* bus.project(SessionEvent.InstructionsUpdated, (event) => yield* bus.project(SessionEvent.InstructionsUpdated, (event) =>
Effect.gen(function* () { Effect.gen(function* () {
yield* run(db, event) yield* run(db, event)
@@ -675,7 +640,7 @@ const layer = Layer.effectDiscard(
.update(SessionTable) .update(SessionTable)
.set({ .set({
revert: { ...revert, files: revert.files ? [...revert.files] : undefined }, revert: { ...revert, files: revert.files ? [...revert.files] : undefined },
time_updated: event.created, time_updated: DateTime.toEpochMillis(event.created),
}) })
.where(eq(SessionTable.id, event.data.sessionID)) .where(eq(SessionTable.id, event.data.sessionID))
.run() .run()
@@ -685,7 +650,7 @@ const layer = Layer.effectDiscard(
yield* bus.project(SessionEvent.RevertEvent.Cleared, (event) => yield* bus.project(SessionEvent.RevertEvent.Cleared, (event) =>
db db
.update(SessionTable) .update(SessionTable)
.set({ revert: null, time_updated: event.created }) .set({ revert: null, time_updated: DateTime.toEpochMillis(event.created) })
.where(eq(SessionTable.id, event.data.sessionID)) .where(eq(SessionTable.id, event.data.sessionID))
.run() .run()
.pipe(Effect.orDie, Effect.asVoid), .pipe(Effect.orDie, Effect.asVoid),
@@ -720,7 +685,7 @@ const layer = Layer.effectDiscard(
.pipe(Effect.orDie) .pipe(Effect.orDie)
yield* db yield* db
.update(SessionTable) .update(SessionTable)
.set({ revert: null, time_updated: event.created }) .set({ revert: null, time_updated: DateTime.toEpochMillis(event.created) })
.where(eq(SessionTable.id, event.data.sessionID)) .where(eq(SessionTable.id, event.data.sessionID))
.run() .run()
.pipe(Effect.orDie) .pipe(Effect.orDie)
+23 -82
View File
@@ -1,7 +1,6 @@
export * as SessionRunCoordinator from "./run-coordinator.js" export * as SessionRunCoordinator from "./run-coordinator.js"
import { Deferred, Effect, Exit, Fiber, FiberSet, Scope } from "effect" import { Deferred, Effect, Exit, Fiber, FiberSet, Scope } from "effect"
import type { Promotable } from "./inbox.js"
/** Serializes execution for each key while allowing different keys to run concurrently. */ /** Serializes execution for each key while allowing different keys to run concurrently. */
export interface Coordinator<Key, E, Reason = never> { export interface Coordinator<Key, E, Reason = never> {
@@ -10,41 +9,26 @@ export interface Coordinator<Key, E, Reason = never> {
/** Starts an execution while idle, or joins the active execution and returns its exit. */ /** Starts an execution while idle, or joins the active execution and returns its exit. */
readonly run: (key: Key) => Effect.Effect<void, E> readonly run: (key: Key) => Effect.Effect<void, E>
/** Rings the doorbell: an idle key starts an execution; an active one drains again before settling. */ /** Rings the doorbell: an idle key starts an execution; an active one drains again before settling. */
readonly wake: (key: Key, request?: Request) => Effect.Effect<void> readonly wake: (key: Key) => Effect.Effect<void>
/** Rings the current execution's doorbell with its existing request. Idle keys remain idle. */
readonly wakeActive: (key: Key) => Effect.Effect<void>
/** Stops the active execution, clears its doorbell, and waits for cleanup. No-op when idle. */ /** Stops the active execution, clears its doorbell, and waits for cleanup. No-op when idle. */
readonly interrupt: ( readonly interrupt: (key: Key, reason?: Reason) => Effect.Effect<void>
key: Key,
reason?: Reason,
options?: { readonly continue?: { readonly request: Request; readonly when: Effect.Effect<boolean> } },
) => Effect.Effect<void>
/** Resolves once no execution is active for the key. Returns immediately when already idle and never starts work. */ /** Resolves once no execution is active for the key. Returns immediately when already idle and never starts work. */
readonly awaitIdle: (key: Key) => Effect.Effect<void> readonly awaitIdle: (key: Key) => Effect.Effect<void>
} }
export type Request = Promotable
/** /**
* One execution is a busy period for one key: one fiber that drains from the first wake * One execution is a busy period for one key: one fiber that drains from the first wake
* until the key would stay idle. `pendingWake` is the doorbell: work recorded during the * until the key would stay idle. `pendingWake` is the doorbell: work recorded during the
* execution rings it with its eligibility request, and the execution loop drains again * execution rings it, and the execution loop drains again instead of ending. The doorbell
* instead of ending. The doorbell closes the gap between a drain's last eligibility check * closes the gap between a drain's last eligibility check and the idle transition, since
* and the idle transition, since those cannot be one atomic step. `done` resolves joiners * those cannot be one atomic step. `done` resolves joiners with this execution's exit.
* with this execution's exit.
*/ */
type Execution<E, Reason> = { type Execution<E, Reason> = {
readonly done: Deferred.Deferred<void, E> readonly done: Deferred.Deferred<void, E>
owner?: Fiber.Fiber<void> owner?: Fiber.Fiber<void>
request: Request pendingWake: boolean
pendingWake?: Request
stopping: boolean stopping: boolean
interruptionReason?: Reason interruptionReason?: Reason
continuation?: {
readonly request: Request
readonly when: Effect.Effect<boolean>
signaled: boolean
}
} }
/** /**
@@ -59,7 +43,7 @@ type Execution<E, Reason> = {
* ``` * ```
*/ */
export const make = <Key, E, Reason = never>(options: { export const make = <Key, E, Reason = never>(options: {
readonly drain: (key: Key, force: boolean, request: Request) => Effect.Effect<void, E> readonly drain: (key: Key, force: boolean) => Effect.Effect<void, E>
/** Runs once when a process-local busy period begins, before its first drain. */ /** Runs once when a process-local busy period begins, before its first drain. */
readonly started?: (key: Key) => Effect.Effect<void> readonly started?: (key: Key) => Effect.Effect<void>
/** /**
@@ -73,22 +57,21 @@ export const make = <Key, E, Reason = never>(options: {
const fork = yield* FiberSet.makeRuntime<never, void, never>() const fork = yield* FiberSet.makeRuntime<never, void, never>()
const loop = (key: Key, execution: Execution<E, Reason>, force: boolean): Effect.Effect<void, E> => const loop = (key: Key, execution: Execution<E, Reason>, force: boolean): Effect.Effect<void, E> =>
Effect.suspend(() => options.drain(key, force, execution.request)).pipe( Effect.suspend(() => options.drain(key, force)).pipe(
Effect.flatMap(() => Effect.flatMap(() =>
Effect.suspend(() => { Effect.suspend(() => {
if (execution.stopping || execution.pendingWake === undefined) return Effect.void if (execution.stopping || !execution.pendingWake) return Effect.void
execution.request = execution.pendingWake execution.pendingWake = false
execution.pendingWake = undefined
// Trampoline so drains that complete synchronously cannot grow the stack. // Trampoline so drains that complete synchronously cannot grow the stack.
return Effect.yieldNow.pipe(Effect.andThen(loop(key, execution, false))) return Effect.yieldNow.pipe(Effect.andThen(loop(key, execution, false)))
}), }),
), ),
) )
const start = (key: Key, force: boolean, request: Request) => { const start = (key: Key, force: boolean) => {
const execution: Execution<E, Reason> = { const execution: Execution<E, Reason> = {
done: Deferred.makeUnsafe<void, E>(), done: Deferred.makeUnsafe<void, E>(),
request, pendingWake: false,
stopping: false, stopping: false,
} }
executions.set(key, execution) executions.set(key, execution)
@@ -104,7 +87,7 @@ export const make = <Key, E, Reason = never>(options: {
execution.owner = undefined execution.owner = undefined
}).pipe(Effect.andThen(options.settled?.(key, exit, execution.interruptionReason) ?? Effect.void)), }).pipe(Effect.andThen(options.settled?.(key, exit, execution.interruptionReason) ?? Effect.void)),
), ),
Effect.onExit((exit) => finish(key, execution, exit)), Effect.onExit((exit) => Effect.sync(() => settle(key, execution, exit))),
Effect.exit, Effect.exit,
Effect.asVoid, Effect.asVoid,
), ),
@@ -114,22 +97,12 @@ export const make = <Key, E, Reason = never>(options: {
// A doorbell that survives the execution loop (rung after the loop decided to end, or // A doorbell that survives the execution loop (rung after the loop decided to end, or
// during failure or interruption cleanup) starts a fresh execution for the remaining work. // during failure or interruption cleanup) starts a fresh execution for the remaining work.
const settle = (key: Key, execution: Execution<E, Reason>, exit: Exit.Exit<void, E>, resume: boolean) => { const settle = (key: Key, execution: Execution<E, Reason>, exit: Exit.Exit<void, E>) => {
if (resume && execution.continuation) start(key, false, execution.continuation.request) if (execution.pendingWake) start(key, false)
else if (execution.pendingWake) start(key, false, execution.pendingWake)
else executions.delete(key) else executions.delete(key)
Deferred.doneUnsafe(execution.done, exit) Deferred.doneUnsafe(execution.done, exit)
} }
const finish = (key: Key, execution: Execution<E, Reason>, exit: Exit.Exit<void, E>) => {
if (!execution.continuation) return Effect.sync(() => settle(key, execution, exit, false))
return execution.continuation.when.pipe(
Effect.flatMap((ready) =>
Effect.sync(() => settle(key, execution, exit, ready || execution.continuation?.signaled === true)),
),
)
}
const run = (key: Key): Effect.Effect<void, E> => const run = (key: Key): Effect.Effect<void, E> =>
Effect.suspend(() => { Effect.suspend(() => {
const execution = executions.get(key) const execution = executions.get(key)
@@ -138,58 +111,26 @@ export const make = <Key, E, Reason = never>(options: {
if (execution.stopping) return Deferred.await(execution.done).pipe(Effect.andThen(run(key))) if (execution.stopping) return Deferred.await(execution.done).pipe(Effect.andThen(run(key)))
return Deferred.await(execution.done) return Deferred.await(execution.done)
} }
return Deferred.await(start(key, true, "input").done) return Deferred.await(start(key, true).done)
}) })
const wake = (key: Key, request: Request = "input") => const wake = (key: Key) =>
Effect.sync(() => { Effect.sync(() => {
const execution = executions.get(key) const execution = executions.get(key)
if (execution !== undefined) { if (execution !== undefined) {
if (execution.stopping) { execution.pendingWake = true
if (execution.continuation) execution.continuation.signaled = true
else execution.continuation = { request, when: Effect.succeed(true), signaled: true }
return
}
// Coalesced wakes keep the widest request: "input" subsumes "steer".
execution.pendingWake = execution.pendingWake === "input" ? "input" : request
return return
} }
start(key, false, request) start(key, false)
}) })
const wakeActive = (key: Key) => const interrupt = (key: Key, reason?: Reason): Effect.Effect<void> =>
Effect.suspend(() => { Effect.suspend(() => {
const execution = executions.get(key) const execution = executions.get(key)
return execution ? wake(key, execution.request) : Effect.void if (execution?.owner === undefined || execution.stopping) return Effect.void
})
const interrupt = (
key: Key,
reason?: Reason,
options?: { readonly continue?: { readonly request: Request; readonly when: Effect.Effect<boolean> } },
): Effect.Effect<void> =>
Effect.suspend(() => {
const execution = executions.get(key)
if (execution === undefined) return Effect.void
if (execution.stopping) {
if (options?.continue)
execution.continuation = {
...options.continue,
signaled: execution.continuation?.signaled ?? false,
}
return Deferred.await(execution.done).pipe(Effect.exit, Effect.asVoid)
}
if (execution.owner === undefined) {
if (!options?.continue) return Effect.void
execution.stopping = true
execution.pendingWake = undefined
execution.continuation = { ...options.continue, signaled: false }
return Deferred.await(execution.done).pipe(Effect.exit, Effect.asVoid)
}
execution.stopping = true execution.stopping = true
execution.pendingWake = undefined execution.pendingWake = false
execution.interruptionReason = reason execution.interruptionReason = reason
if (options?.continue) execution.continuation = { ...options.continue, signaled: false }
return Fiber.interrupt(execution.owner) return Fiber.interrupt(execution.owner)
}) })
@@ -202,5 +143,5 @@ export const make = <Key, E, Reason = never>(options: {
return Deferred.await(execution.done).pipe(Effect.exit, Effect.andThen(awaitIdle(key))) return Deferred.await(execution.done).pipe(Effect.exit, Effect.andThen(awaitIdle(key)))
}) })
return { active: Effect.sync(() => new Set(executions.keys())), run, wake, wakeActive, interrupt, awaitIdle } return { active: Effect.sync(() => new Set(executions.keys())), run, wake, interrupt, awaitIdle }
}) })
@@ -3,7 +3,6 @@ export * as SessionRunner from "./index.js"
import type { AIError } from "@opencode-ai/ai" import type { AIError } from "@opencode-ai/ai"
import { Context, Effect } from "effect" import { Context, Effect } from "effect"
import { SessionSchema } from "../schema.js" import { SessionSchema } from "../schema.js"
import type { Promotable } from "../inbox.js"
import type { AgentNotFoundError, MessageDecodeError, StepFailedError, UserInterruptedError } from "../error.js" import type { AgentNotFoundError, MessageDecodeError, StepFailedError, UserInterruptedError } from "../error.js"
import { SessionRunnerModel } from "./model.js" import { SessionRunnerModel } from "./model.js"
import type { Instructions } from "../../instructions/index.js" import type { Instructions } from "../../instructions/index.js"
@@ -30,8 +29,6 @@ export interface Interface {
readonly sessionID: SessionSchema.ID readonly sessionID: SessionSchema.ID
readonly force: boolean readonly force: boolean
readonly continuation?: Continuation readonly continuation?: Continuation
/** "steer" settles the active intent without promoting queued next-turn work. */
readonly promotable?: Promotable
}) => Effect.Effect<DrainResult, RunError> }) => Effect.Effect<DrainResult, RunError>
} }
+14 -16
View File
@@ -128,25 +128,22 @@ const layer = Layer.effect(
readonly sessionID: SessionSchema.ID readonly sessionID: SessionSchema.ID
readonly force: boolean readonly force: boolean
readonly continuation?: Continuation readonly continuation?: Continuation
readonly promotable?: SessionInbox.Promotable
}) { }) {
let force = input.force let force = input.force
let continuation = input.continuation let continuation = input.continuation
const promotable = input.promotable ?? "input" if (!force && !continuation && !(yield* SessionInbox.has(db, input.sessionID, "any")))
if (!force && !continuation && !(yield* SessionInbox.has(db, input.sessionID, promotable)))
return { type: "complete" as const } return { type: "complete" as const }
yield* settleStaleToolCalls(input.sessionID) yield* settleStaleToolCalls(input.sessionID)
while (true) { while (true) {
if (yield* runPendingCompaction(input.sessionID, promotable)) { if (yield* runPendingCompaction(input.sessionID)) {
force = false force = false
continue continue
} }
if (yield* runPendingMove(input.sessionID, promotable)) return { type: "moved" as const } if (yield* runPendingMove(input.sessionID, "input")) return { type: "moved" as const }
if (!force && !continuation && !(yield* SessionInbox.has(db, input.sessionID, promotable))) if (!force && !continuation && !(yield* SessionInbox.has(db, input.sessionID, "input")))
return { type: "complete" as const } return { type: "complete" as const }
const result = yield* runSteps(input.sessionID, continuation, promotable) const result = yield* runSteps(input.sessionID, continuation)
if (result.type === "moved") return result if (result.type === "moved") return result
if (promotable === "steer") return { type: "complete" as const }
force = false force = false
continuation = undefined continuation = undefined
} }
@@ -158,15 +155,14 @@ const layer = Layer.effect(
*/ */
const runSteps = Effect.fn("SessionRunner.runSteps")(function* ( const runSteps = Effect.fn("SessionRunner.runSteps")(function* (
sessionID: SessionSchema.ID, sessionID: SessionSchema.ID,
continuation: Continuation | undefined, continuation?: Continuation,
drainPromotable: SessionInbox.Promotable,
) { ) {
// Fresh work may promote queued input; resumed turns and later steps absorb steers only. // Fresh work may promote queued input; later steps absorb steers only.
let promotable: SessionInbox.Promotable = continuation ? "steer" : drainPromotable let promotable: SessionInbox.Promotable = continuation ? "steer" : "input"
let step = continuation?.step ?? 1 let step = continuation?.step ?? 1
let next = continuation let next = continuation
while (true) { while (true) {
if (yield* runPendingCompaction(sessionID, "steer")) continue if (yield* runPendingCompaction(sessionID)) continue
if (yield* runPendingMove(sessionID, "steer")) return { type: "moved" as const, continuation: next } if (yield* runPendingMove(sessionID, "steer")) return { type: "moved" as const, continuation: next }
const result = yield* runStep(sessionID, promotable, step) const result = yield* runStep(sessionID, promotable, step)
next = result.needsContinuation ? { step: result.step + 1 } : undefined next = result.needsContinuation ? { step: result.step + 1 } : undefined
@@ -519,14 +515,14 @@ const layer = Layer.effect(
/** Executes a previously admitted manual compaction request, if one is pending. */ /** Executes a previously admitted manual compaction request, if one is pending. */
const runPendingCompaction = Effect.fn("SessionRunner.runPendingCompaction")(function* ( const runPendingCompaction = Effect.fn("SessionRunner.runPendingCompaction")(function* (
sessionID: SessionSchema.ID, sessionID: SessionSchema.ID,
promotable: SessionInbox.Promotable,
) { ) {
return yield* Effect.uninterruptibleMask((restore) => return yield* Effect.uninterruptibleMask((restore) =>
Effect.gen(function* () { Effect.gen(function* () {
const pending = yield* SessionInbox.serialized( const pending = yield* SessionInbox.serialized(
sessionID, sessionID,
Effect.gen(function* () { Effect.gen(function* () {
const selected = yield* SessionInbox.nextPromotable(db, sessionID, promotable) const selected =
(yield* SessionInbox.nextSteer(db, sessionID)) ?? (yield* SessionInbox.nextQueued(db, sessionID))
if (selected?.type !== "compaction") return if (selected?.type !== "compaction") return
yield* bus.publishAll([ yield* bus.publishAll([
[SessionEvent.InboxDelivered, { sessionID, inboxID: selected.id }], [SessionEvent.InboxDelivered, { sessionID, inboxID: selected.id }],
@@ -568,7 +564,9 @@ const layer = Layer.effect(
return yield* SessionInbox.serialized( return yield* SessionInbox.serialized(
sessionID, sessionID,
Effect.gen(function* () { Effect.gen(function* () {
const pending = yield* SessionInbox.nextPromotable(db, sessionID, promotable) const pending =
(yield* SessionInbox.nextSteer(db, sessionID)) ??
(promotable === "input" ? yield* SessionInbox.nextQueued(db, sessionID) : undefined)
if (pending?.type !== "move") return false if (pending?.type !== "move") return false
yield* modelTransport.close(sessionID) yield* modelTransport.close(sessionID)
yield* bus.publishAll([ yield* bus.publishAll([
@@ -1,5 +1,5 @@
import { type LLMEvent, type ProviderMetadata, type ToolResultValue } from "@opencode-ai/ai" import { type LLMEvent, type ProviderMetadata, type ToolResultValue } from "@opencode-ai/ai"
import { Clock, Effect } from "effect" import { Effect } from "effect"
import { Bus } from "../../bus.js" import { Bus } from "../../bus.js"
import { Model } from "../../model.js" import { Model } from "../../model.js"
import { SessionEvent } from "../event.js" import { SessionEvent } from "../event.js"
@@ -81,7 +81,6 @@ const hostedContent = (result: ToolResultValue): NonEmptyContent => {
* and consumers fold by id/ordinal rather than global position. * and consumers fold by id/ordinal rather than global position.
*/ */
export const createLLMEventPublisher = (bus: Pick<Bus.Interface, "publish">, input: Input) => { export const createLLMEventPublisher = (bus: Pick<Bus.Interface, "publish">, input: Input) => {
const deltaBatchInterval = 100
const tools = new Map< const tools = new Map<
string, string,
{ {
@@ -124,56 +123,32 @@ export const createLLMEventPublisher = (bus: Pick<Bus.Interface, "publish">, inp
const fragments = ( const fragments = (
name: string, name: string,
ended: (id: string, value: string, ordinal: number, state?: Record<string, unknown>) => Effect.Effect<void>, ended: (id: string, value: string, ordinal: number, state?: Record<string, unknown>) => Effect.Effect<void>,
delta?: (id: string, value: string, ordinal: number) => Effect.Effect<void>,
single = false, single = false,
) => { ) => {
type Fragment = { const chunks = new Map<
readonly ordinal: number string,
readonly values: string[] { readonly ordinal: number; readonly values: string[]; state?: Record<string, unknown> }
pending: string >()
publishedAt?: number
state?: Record<string, unknown>
}
const chunks = new Map<string, Fragment>()
let nextOrdinal = 0 let nextOrdinal = 0
const start = (id: string, state?: Record<string, unknown>) => const start = (id: string, state?: Record<string, unknown>) =>
Effect.suspend(() => { Effect.suspend(() => {
if (chunks.has(id)) return Effect.die(new Error(`Duplicate ${name} start: ${id}`)) if (chunks.has(id)) return Effect.die(new Error(`Duplicate ${name} start: ${id}`))
if (single && chunks.size > 0) return Effect.die(new Error(`${name} start before end: ${id}`)) if (single && chunks.size > 0) return Effect.die(new Error(`${name} start before end: ${id}`))
const ordinal = nextOrdinal++ const ordinal = nextOrdinal++
chunks.set(id, { ordinal, values: [], pending: "", state }) chunks.set(id, { ordinal, values: [], state })
return Effect.succeed(ordinal) return Effect.succeed(ordinal)
}) })
const publishDelta = Effect.fnUntraced(function* (id: string, force = false) { const append = (id: string, value: string, state?: Record<string, unknown>) =>
if (!delta) return undefined Effect.suspend(() => {
const current = chunks.get(id) const current = chunks.get(id)
if (!current) return yield* Effect.die(new Error(`${name} delta before start: ${id}`)) if (!current) return Effect.die(new Error(`${name} delta before start: ${id}`))
if (!current.pending) return undefined current.values.push(value)
const now = yield* Clock.currentTimeMillis if (state !== undefined) current.state = { ...current.state, ...state }
if (!force && current.publishedAt === undefined) { return Effect.succeed(current.ordinal)
current.publishedAt = now })
return undefined
}
if (!force && current.publishedAt !== undefined && now - current.publishedAt < deltaBatchInterval)
return undefined
yield* delta(id, current.pending, current.ordinal)
current.pending = ""
current.publishedAt = now
return undefined
})
const append = Effect.fnUntraced(function* (id: string, value: string, state?: Record<string, unknown>) {
const current = chunks.get(id)
if (!current) return yield* Effect.die(new Error(`${name} delta before start: ${id}`))
current.values.push(value)
if (delta) current.pending += value
if (state !== undefined) current.state = { ...current.state, ...state }
yield* publishDelta(id)
return current.ordinal
})
const end = Effect.fnUntraced(function* (id: string, state?: Record<string, unknown>, value?: string) { const end = Effect.fnUntraced(function* (id: string, state?: Record<string, unknown>, value?: string) {
const current = chunks.get(id) const current = chunks.get(id)
if (!current) return yield* Effect.die(new Error(`${name} end before start: ${id}`)) if (!current) return yield* Effect.die(new Error(`${name} end before start: ${id}`))
yield* publishDelta(id, true)
yield* ended( yield* ended(
id, id,
value ?? current.values.join(""), value ?? current.values.join(""),
@@ -181,10 +156,9 @@ export const createLLMEventPublisher = (bus: Pick<Bus.Interface, "publish">, inp
state === undefined ? current.state : { ...current.state, ...state }, state === undefined ? current.state : { ...current.state, ...state },
) )
chunks.delete(id) chunks.delete(id)
return undefined
}) })
const flush = Effect.fnUntraced(function* () { const flush = Effect.fnUntraced(function* () {
for (const id of Array.from(chunks.keys())) yield* end(id) for (const id of chunks.keys()) yield* end(id)
}) })
return { start, append, end, flush, has: (id: string) => chunks.has(id) } return { start, append, end, flush, has: (id: string) => chunks.has(id) }
} }
@@ -201,15 +175,6 @@ export const createLLMEventPublisher = (bus: Pick<Bus.Interface, "publish">, inp
state, state,
}) })
}), }),
(_textID, value, ordinal) =>
Effect.gen(function* () {
yield* bus.publish(SessionEvent.Text.Delta, {
sessionID: input.sessionID,
assistantMessageID: yield* currentAssistantMessageID(),
ordinal,
delta: value,
})
}),
true, true,
) )
const reasoning = fragments( const reasoning = fragments(
@@ -224,15 +189,6 @@ export const createLLMEventPublisher = (bus: Pick<Bus.Interface, "publish">, inp
state, state,
}) })
}), }),
(_reasoningID, value, ordinal) =>
Effect.gen(function* () {
yield* bus.publish(SessionEvent.Reasoning.Delta, {
sessionID: input.sessionID,
assistantMessageID: yield* currentAssistantMessageID(),
ordinal,
delta: value,
})
}),
true, true,
) )
const toolInput = fragments("tool input", (id, value) => const toolInput = fragments("tool input", (id, value) =>
@@ -395,7 +351,13 @@ export const createLLMEventPublisher = (bus: Pick<Bus.Interface, "publish">, inp
}) })
return return
case "text-delta": case "text-delta":
yield* text.append(event.id, event.text, providerState(event.providerMetadata)) const deltaTextOrdinal = yield* text.append(event.id, event.text, providerState(event.providerMetadata))
yield* bus.publish(SessionEvent.Text.Delta, {
sessionID: input.sessionID,
assistantMessageID: yield* currentAssistantMessageID(),
ordinal: deltaTextOrdinal,
delta: event.text,
})
return return
case "text-end": case "text-end":
yield* text.end(event.id, providerState(event.providerMetadata)) yield* text.end(event.id, providerState(event.providerMetadata))
@@ -411,7 +373,17 @@ export const createLLMEventPublisher = (bus: Pick<Bus.Interface, "publish">, inp
}) })
return return
case "reasoning-delta": case "reasoning-delta":
yield* reasoning.append(event.id, event.text, providerState(event.providerMetadata)) const deltaReasoningOrdinal = yield* reasoning.append(
event.id,
event.text,
providerState(event.providerMetadata),
)
yield* bus.publish(SessionEvent.Reasoning.Delta, {
sessionID: input.sessionID,
assistantMessageID: yield* currentAssistantMessageID(),
ordinal: deltaReasoningOrdinal,
delta: event.text,
})
return return
case "reasoning-end": case "reasoning-end":
yield* reasoning.end(event.id, providerState(event.providerMetadata)) yield* reasoning.end(event.id, providerState(event.providerMetadata))
@@ -427,6 +399,12 @@ export const createLLMEventPublisher = (bus: Pick<Bus.Interface, "publish">, inp
return yield* Effect.die(new Error(`Tool input name changed for ${event.id}: ${tool.name} -> ${event.name}`)) return yield* Effect.die(new Error(`Tool input name changed for ${event.id}: ${tool.name} -> ${event.name}`))
if (!toolInput.has(event.id)) return yield* Effect.die(new Error(`Tool input delta after end: ${event.id}`)) if (!toolInput.has(event.id)) return yield* Effect.die(new Error(`Tool input delta after end: ${event.id}`))
yield* toolInput.append(event.id, event.text) yield* toolInput.append(event.id, event.text)
yield* bus.publish(SessionEvent.Tool.Input.Delta, {
sessionID: input.sessionID,
assistantMessageID: tool.assistantMessageID,
id: event.id,
delta: event.text,
})
return return
} }
case "tool-input-end": case "tool-input-end":
-2
View File
@@ -56,8 +56,6 @@ export const SessionTable = sqliteTable(
variant?: string variant?: string
}>(), }>(),
...Timestamps, ...Timestamps,
time_idle: integer(),
time_viewed: integer(),
time_compacting: integer(), time_compacting: integer(),
time_archived: integer(), time_archived: integer(),
/** The execution claim timestamp (historical column name; see SessionStore.claim). */ /** The execution claim timestamp (historical column name; see SessionStore.claim). */
-4
View File
@@ -117,10 +117,6 @@ const layer = Layer.effect(
tokens_cache_write: input.data.info.tokens.cache.write, tokens_cache_write: input.data.info.tokens.cache.write,
time_created: DateTime.toEpochMillis(input.data.info.time.created), time_created: DateTime.toEpochMillis(input.data.info.time.created),
time_updated: DateTime.toEpochMillis(input.data.info.time.updated), time_updated: DateTime.toEpochMillis(input.data.info.time.updated),
time_idle: input.data.info.time.idle ? DateTime.toEpochMillis(input.data.info.time.idle) : null,
time_viewed: input.data.info.time.viewed
? DateTime.toEpochMillis(input.data.info.time.viewed)
: null,
time_archived: input.data.info.time.archived time_archived: input.data.info.time.archived
? DateTime.toEpochMillis(input.data.info.time.archived) ? DateTime.toEpochMillis(input.data.info.time.archived)
: null, : null,
+3 -1
View File
@@ -181,7 +181,9 @@ export const Plugin = {
) )
const background = input.background === true const background = input.background === true
yield* context.progress({ sessionID: child.id, status: "running" }) yield* context.progress({
metadata: { sessionID: child.id, status: "running" },
})
const run = Effect.gen(function* () { const run = Effect.gen(function* () {
// The child session owns its agent/model (set at create); prompt only admits input. // The child session owns its agent/model (set at create); prompt only admits input.
+24 -25
View File
@@ -1,5 +1,5 @@
import { describe, expect } from "bun:test" import { describe, expect } from "bun:test"
import { Cause, Deferred, Effect, Exit, Fiber, Layer, Option, Ref, Schema, Stream } from "effect" import { Cause, DateTime, Deferred, Effect, Exit, Fiber, Layer, Option, Ref, Schema, Stream } from "effect"
import { Bus } from "@opencode-ai/core/bus" import { Bus } from "@opencode-ai/core/bus"
import { Event } from "@opencode-ai/schema/event" import { Event } from "@opencode-ai/schema/event"
import { Session } from "@opencode-ai/schema/session" import { Session } from "@opencode-ai/schema/session"
@@ -422,7 +422,7 @@ describe("Bus", () => {
const { db } = yield* Database.Service const { db } = yield* Database.Service
const aggregateID = Event.ID.create() const aggregateID = Event.ID.create()
const event = yield* bus.publish(SyncMessage, { id: aggregateID, text: "first" }) yield* bus.publish(SyncMessage, { id: aggregateID, text: "first" })
const rows = yield* db const rows = yield* db
.select() .select()
.from(EventTable) .from(EventTable)
@@ -433,7 +433,6 @@ describe("Bus", () => {
expect(rows).toHaveLength(1) expect(rows).toHaveLength(1)
expect(rows[0]?.type).toBe(Bus.versionedType(SyncMessage.type, 1)) expect(rows[0]?.type).toBe(Bus.versionedType(SyncMessage.type, 1))
expect(rows[0]?.aggregate_id).toBe(aggregateID) expect(rows[0]?.aggregate_id).toBe(aggregateID)
expect(rows[0]?.created).toBe(event.created)
}), }),
) )
@@ -707,7 +706,7 @@ describe("Bus", () => {
yield* bus.replay({ yield* bus.replay({
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,
@@ -727,7 +726,7 @@ describe("Bus", () => {
yield* bus.replay({ yield* bus.replay({
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,
@@ -764,7 +763,7 @@ describe("Bus", () => {
const exit = yield* bus const exit = yield* bus
.replay({ .replay({
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 1, seq: 1,
aggregateID: envelopeAggregateID, aggregateID: envelopeAggregateID,
@@ -798,7 +797,7 @@ describe("Bus", () => {
yield* bus.replay({ yield* bus.replay({
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,
@@ -807,7 +806,7 @@ describe("Bus", () => {
const exit = yield* bus const exit = yield* bus
.replay({ .replay({
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 5, seq: 5,
aggregateID, aggregateID,
@@ -832,14 +831,14 @@ describe("Bus", () => {
yield* bus.replay({ yield* bus.replay({
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(SessionEvent.InstructionsUpdated.type, 2), type: Bus.versionedType(SessionEvent.InstructionsUpdated.type, 2),
seq: 0, seq: 0,
aggregateID, aggregateID,
data: { sessionID: aggregateID, delta: { "core/context": "0".repeat(64) } }, data: { sessionID: aggregateID, delta: { "core/context": "0".repeat(64) } },
}) })
expect(received[0]?.created).toBe(0) expect(received[0]?.created).toEqual(DateTime.makeUnsafe(0))
}), }),
) )
@@ -868,7 +867,7 @@ describe("Bus", () => {
const exit = yield* bus const exit = yield* bus
.replay({ .replay({
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: "unknown.event.1", type: "unknown.event.1",
seq: 0, seq: 0,
aggregateID: Event.ID.create(), aggregateID: Event.ID.create(),
@@ -896,7 +895,7 @@ describe("Bus", () => {
yield* bus.replay( yield* bus.replay(
{ {
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 1, seq: 1,
aggregateID, aggregateID,
@@ -916,7 +915,7 @@ describe("Bus", () => {
const id = Event.ID.create() const id = Event.ID.create()
const replayed = { const replayed = {
id, id,
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,
@@ -973,7 +972,7 @@ describe("Bus", () => {
yield* bus.replay( yield* bus.replay(
{ {
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,
@@ -1002,7 +1001,7 @@ describe("Bus", () => {
yield* bus.replay( yield* bus.replay(
{ {
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 1, seq: 1,
aggregateID, aggregateID,
@@ -1013,7 +1012,7 @@ describe("Bus", () => {
yield* bus.replay( yield* bus.replay(
{ {
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 2, seq: 2,
aggregateID, aggregateID,
@@ -1046,7 +1045,7 @@ describe("Bus", () => {
yield* bus.replay( yield* bus.replay(
{ {
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,
@@ -1059,7 +1058,7 @@ describe("Bus", () => {
.replay( .replay(
{ {
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 1, seq: 1,
aggregateID, aggregateID,
@@ -1081,7 +1080,7 @@ describe("Bus", () => {
yield* bus.listen((event) => Effect.sync(() => received.push(event))) yield* bus.listen((event) => Effect.sync(() => received.push(event)))
const replayed = { const replayed = {
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,
@@ -1102,7 +1101,7 @@ describe("Bus", () => {
const aggregateID = Session.ID.create() const aggregateID = Session.ID.create()
const replayed = { const replayed = {
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,
@@ -1127,7 +1126,7 @@ describe("Bus", () => {
const id = Event.ID.create() const id = Event.ID.create()
yield* bus.replay({ yield* bus.replay({
id, id,
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,
@@ -1137,7 +1136,7 @@ describe("Bus", () => {
const exit = yield* bus const exit = yield* bus
.replay({ .replay({
id, id,
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 1, seq: 1,
aggregateID, aggregateID,
@@ -1160,7 +1159,7 @@ describe("Bus", () => {
yield* bus.replay( yield* bus.replay(
{ {
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,
@@ -1171,7 +1170,7 @@ describe("Bus", () => {
yield* bus.replay( yield* bus.replay(
{ {
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 1, seq: 1,
aggregateID, aggregateID,
@@ -1233,7 +1232,7 @@ describe("Bus", () => {
yield* bus.replay({ yield* bus.replay({
id: Event.ID.create(), id: Event.ID.create(),
created: 0, created: DateTime.makeUnsafe(0),
type: Bus.versionedType(DurableMessage.type, 1), type: Bus.versionedType(DurableMessage.type, 1),
seq: 0, seq: 0,
aggregateID, aggregateID,

Some files were not shown because too many files have changed in this diff Show More