anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-25 20:55:42 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #2572] fix(session): await cleanupRevert() to prevent dupe msgs after undo #10359

New Issue
Closed
opened 2026-02-16 18:14:59 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:14:59 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/2572

State: closed
Merged: Yes

Implemented a fix for a race condition that could duplicate the last message when a user quickly performs an undo followed by an immediate send. I didn't realize how frequently this was happening to me until I built some tooling to analyze the reasoning traces from gpt-oss-120b. Here's an example of two instances displayed in the TUI (also confirmed via packet capture):

image image

It's fairly easy to repro manually, at least on my machine (M3 Max). I use <leader>, then press u + enter in quick succession and get a near 100% hit rate on the bug.

I don't know how many folks would be impacted by this. But I do run into this issue frequently because I do a ton of best-of-N sampling, both programmatically and manually.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/2572 **State:** closed **Merged:** Yes --- Implemented a fix for a race condition that could duplicate the last message when a user quickly performs an undo followed by an immediate send. I didn't realize how frequently this was happening to me until I built some tooling to analyze the reasoning traces from gpt-oss-120b. Here's an example of two instances displayed in the TUI (also confirmed via packet capture): <img width="932" height="533" alt="image" src="https://github.com/user-attachments/assets/14fb7c11-2c74-445c-b5aa-b3edaa24f3ed" /> <img width="930" height="439" alt="image" src="https://github.com/user-attachments/assets/1ea21082-8825-4363-816f-ce696930905c" /> It's fairly easy to repro manually, at least on my machine (M3 Max). I use `<leader>`, then press `u` + `enter` in quick succession and get a near 100% hit rate on the bug. I don't know how many folks would be impacted by this. But I do run into this issue frequently because I do a ton of best-of-N sampling, both programmatically and manually.
yindo added the pull-request label 2026-02-16 18:14:59 -05:00
yindo closed this issue 2026-02-16 18:14:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#10359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?